From: Harry Wentland <harry.wentland@amd.com>
To: "Kazlauskas, Nicholas" <Nicholas.Kazlauskas@amd.com>,
"Siqueira, Rodrigo" <Rodrigo.Siqueira@amd.com>,
Simon Ser <contact@emersion.fr>
Cc: "Saarinen, Jani" <jani.saarinen@intel.com>,
"Vudum, Lakshminarayana" <lakshminarayana.vudum@intel.com>,
"Latvala, Petri" <petri.latvala@intel.com>,
"Wang, Chao-kai (Stylon)" <Stylon.Wang@amd.com>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"Choi, Nicholas" <Nicholas.Choi@amd.com>,
Mark Yacoub <markyacoub@google.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_hdr: Fix failure to read output_bpc on AMD hardware
Date: Thu, 7 Oct 2021 10:56:37 -0400 [thread overview]
Message-ID: <73ec4c04-b2d1-4392-4096-7cc7076420ed@amd.com> (raw)
In-Reply-To: <DM4PR12MB5182EFB81A2845B2F953BB57ECB19@DM4PR12MB5182.namprd12.prod.outlook.com>
On 2021-10-07 10:54, Kazlauskas, Nicholas wrote:
> [AMD Official Use Only]
>
>
> I don't have the commits in front of me, but there was an issue with the port from amd_hdr to kms_hdr where the test would do a TEST_ONLY commit that change the output bpc to 10 but then the debugfs check /after /would try and verify that the output bpc was 10 - which doesn't work if the output bpc was previously 8 because the commit wasn't actually applied.
>
https://patchwork.freedesktop.org/patch/456663/?series=95313&rev=1
Stylon, is that what is happening?
If so, please make sure the commit description reflects that. The existing
description doesn't explain why switching from TEST_ONLY to ALLOW_MODESET
fixes things.
Harry
> Regards,
> Nicholas Kazlauskas
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> *From:* Simon Ser <contact@emersion.fr>
> *Sent:* Thursday, October 7, 2021 10:49 AM
> *To:* Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>
> *Cc:* Saarinen, Jani <jani.saarinen@intel.com>; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>; Latvala, Petri <petri.latvala@intel.com>; Wang, Chao-kai (Stylon) <Stylon.Wang@amd.com>; igt-dev@lists.freedesktop.org <igt-dev@lists.freedesktop.org>; Choi, Nicholas <Nicholas.Choi@amd.com>; Mark Yacoub <markyacoub@google.com>; Wentland, Harry <Harry.Wentland@amd.com>; Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com>
> *Subject:* Re: [PATCH i-g-t] tests/kms_hdr: Fix failure to read output_bpc on AMD hardware
>
> I don't think removing TEST_ONLY is correct? bafd90661c26 ("tests/kms_hdr: Add
> bpc switch subtests") reads:
>
> v4: -Plane size back to CRTC size, regression observed in hsw again
> "Plane must cover entire CRTC" because of plane size restriction
> to 512x512. Petri/Ville suggested to use TEST_ONLY in try_commit()
> to probe whether we can use a smaller than fullscreen plane.
>
> cc Nicholas
next prev parent reply other threads:[~2021-10-07 14:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 8:53 [igt-dev] [PATCH i-g-t] tests/kms_hdr: Fix failure to read output_bpc on AMD hardware Stylon Wang
2021-10-02 15:15 ` Rodrigo Siqueira
2021-10-04 11:13 ` Petri Latvala
2021-10-04 14:18 ` Rodrigo Siqueira
2021-10-04 15:42 ` Vudum, Lakshminarayana
2021-10-04 17:07 ` Saarinen, Jani
2021-10-07 14:40 ` Rodrigo Siqueira
2021-10-07 14:49 ` Simon Ser
2021-10-07 14:54 ` Kazlauskas, Nicholas
2021-10-07 14:56 ` Harry Wentland [this message]
2021-10-07 14:59 ` Kazlauskas, Nicholas
2021-10-08 5:45 ` Wang, Chao-kai (Stylon)
2021-10-08 6:33 ` Simon Ser
2021-10-04 12:00 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-10-04 14:08 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-10-04 15:36 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73ec4c04-b2d1-4392-4096-7cc7076420ed@amd.com \
--to=harry.wentland@amd.com \
--cc=Nicholas.Choi@amd.com \
--cc=Nicholas.Kazlauskas@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Stylon.Wang@amd.com \
--cc=contact@emersion.fr \
--cc=igt-dev@lists.freedesktop.org \
--cc=jani.saarinen@intel.com \
--cc=lakshminarayana.vudum@intel.com \
--cc=markyacoub@google.com \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox