Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH] tests/kms_plane_alpha_blend: skip coverage tests on missing enum
@ 2021-11-04 16:27 Simon Ser
  2021-11-04 18:44 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Simon Ser @ 2021-11-04 16:27 UTC (permalink / raw)
  To: igt-dev

Some KMS drivers support the KMS "pixel blend mode" plane property,
but don't support the "Coverage" mode. This enum entry is missing
to indicate lack of support as seen in this drm_info exerpt:

    "pixel blend mode": enum {None, Pre-multiplied} = Pre-multiplied

Skip the coverage tests in this case.

Signed-off-by: Simon Ser <contact@emersion.fr>
Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
---
 tests/kms_plane_alpha_blend.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index 9e4ee22b43af..d061262da196 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -419,7 +419,7 @@ static void coverage_7efc(data_t *data, enum pipe pipe, igt_plane_t *plane)
 	igt_crc_t ref_crc = {}, crc = {};
 	int i;
 
-	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
+	igt_require(igt_plane_try_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage"));
 	igt_display_commit2(display, COMMIT_ATOMIC);
 	igt_pipe_crc_start(data->pipe_crc);
 
@@ -451,7 +451,7 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
 	if (plane->type != DRM_PLANE_TYPE_PRIMARY)
 		igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->gray_fb);
 
-	igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
+	igt_require(igt_plane_try_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage"));
 	igt_plane_set_fb(plane, &data->argb_fb_cov_7e);
 	igt_display_commit2(display, COMMIT_ATOMIC);
 	igt_pipe_crc_start(data->pipe_crc);
-- 
2.33.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-11-10  8:25 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-04 16:27 [igt-dev] [PATCH] tests/kms_plane_alpha_blend: skip coverage tests on missing enum Simon Ser
2021-11-04 18:44 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-11-04 21:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-11-09 15:53 ` [igt-dev] [PATCH] " Rodrigo Siqueira Jordao
2021-11-09 18:14 ` Harry Wentland
2021-11-09 22:16   ` Simon Ser
2021-11-10  8:25     ` Pekka Paalanen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox