* [igt-dev] [PATCH i-g-t 3/3] intel-gpu-top: Add support for per client stats
2022-01-06 16:49 [igt-dev] [PATCH i-g-t 0/3] Tests and intel_gpu_top with fdinfo support Tvrtko Ursulin
@ 2022-01-06 16:49 ` Tvrtko Ursulin
0 siblings, 0 replies; 8+ messages in thread
From: Tvrtko Ursulin @ 2022-01-06 16:49 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Use the i915 exported data in /proc/<pid>/fdinfo to show GPU utilization
per DRM client.
Example of the output:
intel-gpu-top: Intel Tigerlake (Gen12) @ /dev/dri/card0 - 220/ 221 MHz
70% RC6; 0.62/ 7.08 W; 760 irqs/s
ENGINES BUSY MI_SEMA MI_WAIT
Render/3D 23.06% |██████▊ | 0% 0%
Blitter 0.00% | | 0% 0%
Video 5.40% |█▋ | 0% 0%
VideoEnhance 20.67% |██████ | 0% 0%
PID NAME Render/3D Blitter Video VideoEnhance
3082 mpv | || ||▌ ||██ |
3117 neverball |█▉ || || || |
1 systemd |▍ || || || |
2338 gnome-shell | || || || |
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
man/intel_gpu_top.rst | 4 +
tools/intel_gpu_top.c | 803 +++++++++++++++++++++++++++++++++++++++++-
tools/meson.build | 2 +-
3 files changed, 806 insertions(+), 3 deletions(-)
diff --git a/man/intel_gpu_top.rst b/man/intel_gpu_top.rst
index b3b765b05feb..f4dbfc5b44d9 100644
--- a/man/intel_gpu_top.rst
+++ b/man/intel_gpu_top.rst
@@ -56,6 +56,10 @@ Supported keys:
'q' Exit from the tool.
'h' Show interactive help.
'1' Toggle between aggregated engine class and physical engine mode.
+ 'n' Toggle display of numeric client busyness overlay.
+ 's' Toggle between sort modes (runtime, total runtime, pid, client id).
+ 'i' Toggle display of clients which used no GPU time.
+ 'H' Toggle between per PID aggregation and individual clients.
DEVICE SELECTION
================
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 81c724d1fe1c..98c73a9c85c1 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -43,8 +43,10 @@
#include <sys/types.h>
#include <unistd.h>
#include <termios.h>
+#include <sys/sysmacros.h>
#include "igt_perf.h"
+#include "igt_drm_fdinfo.h"
#define ARRAY_SIZE(arr) (sizeof(arr)/sizeof(arr[0]))
@@ -309,7 +311,8 @@ static int engine_cmp(const void *__a, const void *__b)
return a->instance - b->instance;
}
-#define is_igpu_pci(x) (strcmp(x, "0000:00:02.0") == 0)
+#define IGPU_PCI "0000:00:02.0"
+#define is_igpu_pci(x) (strcmp(x, IGPU_PCI) == 0)
#define is_igpu(x) (strcmp(x, "i915") == 0)
static struct engines *discover_engines(char *device)
@@ -633,6 +636,549 @@ static void pmu_sample(struct engines *engines)
}
}
+enum client_status {
+ FREE = 0, /* mbz */
+ ALIVE,
+ PROBE
+};
+
+struct clients;
+
+struct client {
+ struct clients *clients;
+
+ enum client_status status;
+ unsigned int id;
+ unsigned int pid;
+ char name[24];
+ char print_name[24];
+ unsigned int samples;
+ unsigned long total_runtime;
+ unsigned long last_runtime;
+ struct engines *engines;
+ unsigned long *val;
+ uint64_t *last;
+};
+
+struct clients {
+ unsigned int num_clients;
+ unsigned int active_clients;
+
+ unsigned int num_classes;
+ struct engine_class *class;
+
+ char pci_slot[64];
+
+ struct client *client;
+};
+
+#define for_each_client(clients, c, tmp) \
+ for ((tmp) = (clients)->num_clients, c = (clients)->client; \
+ (tmp > 0); (tmp)--, (c)++)
+
+static struct clients *init_clients(const char *pci_slot)
+{
+ struct clients *clients;
+
+ clients = malloc(sizeof(*clients));
+ if (!clients)
+ return NULL;
+
+ memset(clients, 0, sizeof(*clients));
+
+ strncpy(clients->pci_slot, pci_slot, sizeof(clients->pci_slot));
+
+ return clients;
+}
+
+static struct client *
+find_client(struct clients *clients, enum client_status status, unsigned int id)
+{
+ unsigned int start, num;
+ struct client *c;
+
+ start = status == FREE ? clients->active_clients : 0; /* Free block at the end. */
+ num = clients->num_clients - start;
+
+ for (c = &clients->client[start]; num; c++, num--) {
+ if (status != c->status)
+ continue;
+
+ if (status == FREE || c->id == id)
+ return c;
+ }
+
+ return NULL;
+}
+
+static void
+update_client(struct client *c, unsigned int pid, char *name, uint64_t val[16])
+{
+ unsigned int i;
+
+ if (c->pid != pid)
+ c->pid = pid;
+
+ if (strcmp(c->name, name)) {
+ char *p;
+
+ strncpy(c->name, name, sizeof(c->name) - 1);
+ strncpy(c->print_name, name, sizeof(c->print_name) - 1);
+
+ p = c->print_name;
+ while (*p) {
+ if (!isprint(*p))
+ *p = '*';
+ p++;
+ }
+ }
+
+ c->last_runtime = 0;
+ c->total_runtime = 0;
+
+ for (i = 0; i < c->clients->num_classes; i++) {
+ if (val[i] < c->last[i])
+ continue; /* It will catch up soon. */
+
+ c->total_runtime += val[i];
+ c->val[i] = val[i] - c->last[i];
+ c->last_runtime += c->val[i];
+ c->last[i] = val[i];
+ }
+
+ c->samples++;
+ c->status = ALIVE;
+}
+
+static void
+add_client(struct clients *clients, unsigned int id, unsigned int pid,
+ char *name, uint64_t busy[16])
+{
+ struct client *c;
+
+ assert(!find_client(clients, ALIVE, id));
+
+ c = find_client(clients, FREE, 0);
+ if (!c) {
+ unsigned int idx = clients->num_clients;
+
+ clients->num_clients += (clients->num_clients + 2) / 2;
+ clients->client = realloc(clients->client,
+ clients->num_clients * sizeof(*c));
+ assert(clients->client);
+
+ c = &clients->client[idx];
+ memset(c, 0, (clients->num_clients - idx) * sizeof(*c));
+ }
+
+ c->id = id;
+ c->clients = clients;
+ c->val = calloc(clients->num_classes, sizeof(c->val));
+ c->last = calloc(clients->num_classes, sizeof(c->last));
+ assert(c->val && c->last);
+
+ update_client(c, pid, name, busy);
+}
+
+static void free_client(struct client *c)
+{
+ free(c->val);
+ free(c->last);
+ memset(c, 0, sizeof(*c));
+}
+
+static int client_last_cmp(const void *_a, const void *_b)
+{
+ const struct client *a = _a;
+ const struct client *b = _b;
+ long tot_a, tot_b;
+
+ /*
+ * Sort clients in descending order of runtime in the previous sampling
+ * period for active ones, followed by inactive. Tie-breaker is client
+ * id.
+ */
+
+ tot_a = a->status == ALIVE ? a->last_runtime : -1;
+ tot_b = b->status == ALIVE ? b->last_runtime : -1;
+
+ tot_b -= tot_a;
+ if (tot_b > 0)
+ return 1;
+ if (tot_b < 0)
+ return -1;
+
+ return (int)b->id - a->id;
+}
+
+static int client_total_cmp(const void *_a, const void *_b)
+{
+ const struct client *a = _a;
+ const struct client *b = _b;
+ long tot_a, tot_b;
+
+ tot_a = a->status == ALIVE ? a->total_runtime : -1;
+ tot_b = b->status == ALIVE ? b->total_runtime : -1;
+
+ tot_b -= tot_a;
+ if (tot_b > 0)
+ return 1;
+ if (tot_b < 0)
+ return -1;
+
+ return (int)b->id - a->id;
+}
+
+static int client_id_cmp(const void *_a, const void *_b)
+{
+ const struct client *a = _a;
+ const struct client *b = _b;
+ int id_a, id_b;
+
+ id_a = a->status == ALIVE ? a->id : -1;
+ id_b = b->status == ALIVE ? b->id : -1;
+
+ id_b -= id_a;
+ if (id_b > 0)
+ return 1;
+ if (id_b < 0)
+ return -1;
+
+ return (int)b->id - a->id;
+}
+
+static int client_pid_cmp(const void *_a, const void *_b)
+{
+ const struct client *a = _a;
+ const struct client *b = _b;
+ int pid_a, pid_b;
+
+ pid_a = a->status == ALIVE ? a->pid : INT_MAX;
+ pid_b = b->status == ALIVE ? b->pid : INT_MAX;
+
+ pid_b -= pid_a;
+ if (pid_b > 0)
+ return -1;
+ if (pid_b < 0)
+ return 1;
+
+ return (int)a->id - b->id;
+}
+
+static int (*client_cmp)(const void *, const void *) = client_last_cmp;
+
+static struct clients *sort_clients(struct clients *clients,
+ int (*cmp)(const void *, const void *))
+{
+ unsigned int active, free;
+ struct client *c;
+ int tmp;
+
+ if (!clients)
+ return clients;
+
+ qsort(clients->client, clients->num_clients, sizeof(*clients->client),
+ cmp);
+
+ /* Trim excessive array space. */
+ active = 0;
+ for_each_client(clients, c, tmp) {
+ if (c->status != ALIVE)
+ break; /* Active clients are first in the array. */
+ active++;
+ }
+
+ clients->active_clients = active;
+
+ free = clients->num_clients - active;
+ if (free > clients->num_clients / 2) {
+ active = clients->num_clients - free / 2;
+ if (active != clients->num_clients) {
+ clients->num_clients = active;
+ clients->client = realloc(clients->client,
+ clients->num_clients *
+ sizeof(*c));
+ }
+ }
+
+ return clients;
+}
+
+static bool aggregate_pids = true;
+
+static struct clients *display_clients(struct clients *clients)
+{
+ struct client *ac, *c, *cp = NULL;
+ struct clients *aggregated;
+ int tmp, num = 0;
+
+ if (!aggregate_pids)
+ goto out;
+
+ /* Sort by pid first to make it easy to aggregate while walking. */
+ sort_clients(clients, client_pid_cmp);
+
+ aggregated = calloc(1, sizeof(*clients));
+ assert(aggregated);
+
+ ac = calloc(clients->num_clients, sizeof(*c));
+ assert(ac);
+
+ aggregated->num_classes = clients->num_classes;
+ aggregated->class = clients->class;
+ aggregated->client = ac;
+
+ for_each_client(clients, c, tmp) {
+ unsigned int i;
+
+ if (c->status == FREE)
+ break;
+
+ assert(c->status == ALIVE);
+
+ if ((cp && c->pid != cp->pid) || !cp) {
+ ac = &aggregated->client[num++];
+
+ /* New pid. */
+ ac->clients = aggregated;
+ ac->status = ALIVE;
+ ac->id = -c->pid;
+ ac->pid = c->pid;
+ strcpy(ac->name, c->name);
+ strcpy(ac->print_name, c->print_name);
+ ac->engines = c->engines;
+ ac->val = calloc(clients->num_classes,
+ sizeof(ac->val[0]));
+ assert(ac->val);
+ ac->samples = 1;
+ }
+
+ cp = c;
+
+ if (c->samples < 2)
+ continue;
+
+ ac->samples = 2; /* All what matters for display. */
+ ac->total_runtime += c->total_runtime;
+ ac->last_runtime += c->last_runtime;
+
+ for (i = 0; i < clients->num_classes; i++)
+ ac->val[i] += c->val[i];
+ }
+
+ aggregated->num_clients = num;
+ aggregated->active_clients = num;
+
+ clients = aggregated;
+
+out:
+ return sort_clients(clients, client_cmp);
+}
+
+static void free_clients(struct clients *clients)
+{
+ struct client *c;
+ unsigned int tmp;
+
+ for_each_client(clients, c, tmp) {
+ free(c->val);
+ free(c->last);
+ }
+
+ free(clients->client);
+ free(clients);
+}
+
+static bool is_drm_fd(DIR *fd_dir, const char *name)
+{
+ struct stat stat;
+ int ret;
+
+ ret = fstatat(dirfd(fd_dir), name, &stat, 0);
+
+ return ret == 0 &&
+ (stat.st_mode & S_IFMT) == S_IFCHR &&
+ major(stat.st_rdev) == 226;
+}
+
+static bool get_task_name(const char *buffer, char *out, unsigned long sz)
+{
+ char *s = index(buffer, '(');
+ char *e = rindex(buffer, ')');
+ unsigned int len;
+
+ if (!s || !e)
+ return false;
+
+ len = --e - ++s + 1;
+ if(!len || (len + 1) >= sz)
+ return false;
+
+ strncpy(out, s, len);
+ out[len] = 0;
+
+ return true;
+}
+
+static DIR *opendirat(DIR *at, const char *name)
+{
+ DIR *dir;
+ int fd;
+
+ fd = openat(dirfd(at), name, O_DIRECTORY);
+ if (fd < 0)
+ return NULL;
+
+ dir = fdopendir(fd);
+ if (!dir)
+ close(fd);
+
+ return dir;
+}
+
+static FILE *fropenat(DIR *at, const char *name)
+{
+ FILE *f;
+ int fd;
+
+ fd = openat(dirfd(at), name, O_RDONLY);
+ if (fd < 0)
+ return NULL;
+
+ f = fdopen(fd, "r");
+ if (!f)
+ close(fd);
+
+ return f;
+}
+
+static size_t freadat2buf(char *buf, const size_t sz, DIR *at, const char *name)
+{
+ size_t count;
+ FILE *f;
+
+ f = fropenat(at, name);
+ if (!f)
+ return 0;
+
+ memset(buf, 0, sz);
+ count = fread(buf, 1, sz, f);
+ fclose(f);
+
+ return count;
+}
+
+static struct clients *scan_clients(struct clients *clients)
+{
+ struct dirent *proc_dent;
+ struct client *c;
+ DIR *proc_dir;
+ int tmp;
+
+ if (!clients)
+ return clients;
+
+ for_each_client(clients, c, tmp) {
+ assert(c->status != PROBE);
+ if (c->status == ALIVE)
+ c->status = PROBE;
+ else
+ break; /* Free block at the end of array. */
+ }
+
+ proc_dir = opendir("/proc");
+ if (!proc_dir)
+ return clients;
+
+ while ((proc_dent = readdir(proc_dir)) != NULL) {
+ DIR *pid_dir = NULL, *fd_dir = NULL, *fdinfo_dir = NULL;
+ struct dirent *fdinfo_dent;
+ char client_name[64] = { };
+ unsigned int client_pid;
+ char buf[4096];
+ size_t count;
+
+ if (proc_dent->d_type != DT_DIR)
+ continue;
+ if (!isdigit(proc_dent->d_name[0]))
+ continue;
+
+ pid_dir = opendirat(proc_dir, proc_dent->d_name);
+ if (!pid_dir)
+ continue;
+
+ count = freadat2buf(buf, sizeof(buf), pid_dir, "stat");
+ if (!count)
+ goto next;
+
+ client_pid = atoi(buf);
+ if (!client_pid)
+ goto next;
+
+ if (!get_task_name(buf, client_name, sizeof(client_name)))
+ goto next;
+
+ fd_dir = opendirat(pid_dir, "fd");
+ if (!fd_dir)
+ goto next;
+
+ fdinfo_dir = opendirat(pid_dir, "fdinfo");
+ if (!fdinfo_dir)
+ goto next;
+
+ while ((fdinfo_dent = readdir(fdinfo_dir)) != NULL) {
+ struct drm_client_fdinfo info = { };
+
+ if (fdinfo_dent->d_type != DT_REG)
+ continue;
+ if (!isdigit(fdinfo_dent->d_name[0]))
+ continue;
+
+ if (!is_drm_fd(fd_dir, fdinfo_dent->d_name))
+ continue;
+
+ if (!__igt_parse_drm_fdinfo(fdinfo_dir,
+ fdinfo_dent->d_name,
+ &info))
+ continue;
+
+ if (strcmp(info.driver, "i915"))
+ continue;
+ if (strcmp(info.pdev, clients->pci_slot))
+ continue;
+ if (find_client(clients, ALIVE, info.id))
+ continue; /* Skip duplicate fds. */
+
+ c = find_client(clients, PROBE, info.id);
+ if (!c)
+ add_client(clients, info.id, client_pid,
+ client_name, info.busy);
+ else
+ update_client(c, client_pid, client_name,
+ info.busy);
+ }
+
+next:
+ if (fdinfo_dir)
+ closedir(fdinfo_dir);
+ if (fd_dir)
+ closedir(fd_dir);
+ if (pid_dir)
+ closedir(pid_dir);
+ }
+
+ closedir(proc_dir);
+
+ for_each_client(clients, c, tmp) {
+ if (c->status == PROBE)
+ free_client(c);
+ else if (c->status == FREE)
+ break;
+ }
+
+ return display_clients(clients);
+}
+
static const char *bars[] = { " ", "▏", "▎", "▍", "▌", "▋", "▊", "▉", "█" };
static void n_spaces(const unsigned int n)
@@ -774,6 +1320,18 @@ json_close_struct(void)
fflush(stdout);
}
+static void
+__json_add_member(const char *key, const char *val)
+{
+ assert(json_indent_level < ARRAY_SIZE(json_indent));
+
+ fprintf(out, "%s%s\"%s\": \"%s\"",
+ json_struct_members ? ",\n" : "",
+ json_indent[json_indent_level], key, val);
+
+ json_struct_members++;
+}
+
static unsigned int
json_add_member(const struct cnt_group *parent, struct cnt_item *item,
unsigned int headers)
@@ -1499,6 +2057,157 @@ print_engines(struct engines *engines, double t, int lines, int w, int h)
return lines;
}
+static int
+print_clients_header(struct clients *clients, int lines,
+ int con_w, int con_h, int *class_w)
+{
+ if (output_mode == INTERACTIVE) {
+ const char *pidname = " PID NAME ";
+ unsigned int num_active = 0;
+ int len = strlen(pidname);
+
+ if (lines++ >= con_h)
+ return lines;
+
+ printf("\033[7m");
+ printf("%s", pidname);
+
+ if (lines++ >= con_h || len >= con_w)
+ return lines;
+
+ if (clients->num_classes) {
+ unsigned int i;
+ int width;
+
+ for (i = 0; i < clients->num_classes; i++) {
+ if (clients->class[i].num_engines)
+ num_active++;
+ }
+
+ *class_w = width = (con_w - len) / num_active;
+
+ for (i = 0; i < clients->num_classes; i++) {
+ const char *name = clients->class[i].name;
+ int name_len = strlen(name);
+ int pad = (width - name_len) / 2;
+ int spaces = width - pad - name_len;
+
+ if (!clients->class[i].num_engines)
+ continue; /* Assert in the ideal world. */
+
+ if (pad < 0 || spaces < 0)
+ continue;
+
+ n_spaces(pad);
+ printf("%s", name);
+ n_spaces(spaces);
+ len += pad + name_len + spaces;
+ }
+ }
+
+ n_spaces(con_w - len);
+ printf("\033[0m\n");
+ } else {
+ if (clients->num_classes)
+ pops->open_struct("clients");
+ }
+
+ return lines;
+}
+
+static bool numeric_clients;
+static bool filter_idle;
+
+static int
+print_client(struct client *c, struct engines *engines, double t, int lines,
+ int con_w, int con_h, unsigned int period_us, int *class_w)
+{
+ struct clients *clients = c->clients;
+ unsigned int i;
+
+ if (output_mode == INTERACTIVE) {
+ if (filter_idle && (!c->total_runtime || c->samples < 2))
+ return lines;
+
+ lines++;
+
+ printf("%6u %17s ", c->pid, c->print_name);
+
+ for (i = 0; c->samples > 1 && i < clients->num_classes; i++) {
+ double pct;
+
+ if (!clients->class[i].num_engines)
+ continue; /* Assert in the ideal world. */
+
+ pct = (double)c->val[i] / period_us / 1e3 * 100 /
+ clients->class[i].num_engines;
+
+ /*
+ * Guard against possible time-drift between sampling
+ * client data and time we obtained our time-delta from
+ * PMU.
+ */
+ if (pct > 100.0)
+ pct = 100.0;
+
+ print_percentage_bar(pct, *class_w, numeric_clients);
+ }
+
+ putchar('\n');
+ } else if (output_mode == JSON) {
+ char buf[64];
+
+ snprintf(buf, sizeof(buf), "%u", c->id);
+ pops->open_struct(buf);
+
+ __json_add_member("name", c->print_name);
+
+ snprintf(buf, sizeof(buf), "%u", c->pid);
+ __json_add_member("pid", buf);
+
+ if (c->samples > 1) {
+ pops->open_struct("engine-classes");
+
+ for (i = 0; i < clients->num_classes; i++) {
+ double pct;
+
+ snprintf(buf, sizeof(buf), "%s",
+ clients->class[i].name);
+ pops->open_struct(buf);
+
+ pct = (double)c->val[i] / period_us / 1e3 * 100;
+ snprintf(buf, sizeof(buf), "%f", pct);
+ __json_add_member("busy", buf);
+
+ __json_add_member("unit", "%");
+
+ pops->close_struct();
+ }
+
+ pops->close_struct();
+ }
+
+ pops->close_struct();
+ }
+
+ return lines;
+}
+
+static int
+print_clients_footer(struct clients *clients, double t,
+ int lines, int con_w, int con_h)
+{
+ if (output_mode == INTERACTIVE) {
+ if (lines++ < con_h)
+ printf("\n");
+ } else {
+ if (clients->num_classes)
+ pops->close_struct();
+ }
+
+ return lines;
+}
+
static bool stop_top;
static void sigint_handler(int sig)
@@ -1554,6 +2263,31 @@ static void interactive_stdin(void)
assert(ret == 0);
}
+static void select_client_sort(void)
+{
+ struct {
+ int (*cmp)(const void *, const void *);
+ const char *msg;
+ } cmp[] = {
+ { client_last_cmp, "Sorting clients by current GPU usage." },
+ { client_total_cmp, "Sorting clients by accummulated GPU usage." },
+ { client_pid_cmp, "Sorting clients by pid." },
+ { client_id_cmp, "Sorting clients by sysfs id." },
+ };
+ static unsigned int client_sort;
+
+bump:
+ if (++client_sort >= ARRAY_SIZE(cmp))
+ client_sort = 0;
+
+ client_cmp = cmp[client_sort].cmp;
+ header_msg = cmp[client_sort].msg;
+
+ /* Sort by client id makes no sense with pid aggregation. */
+ if (aggregate_pids && client_cmp == client_id_cmp)
+ goto bump;
+}
+
static bool in_help;
static void process_help_stdin(void)
@@ -1596,9 +2330,29 @@ static void process_normal_stdin(void)
else
header_msg = "Showing physical engines.";
break;
+ case 'i':
+ filter_idle ^= true;
+ if (filter_idle)
+ header_msg = "Hiding inactive clients.";
+ else
+ header_msg = "Showing inactive clients.";
+ break;
+ case 'n':
+ numeric_clients ^= true;
+ break;
+ case 's':
+ select_client_sort();
+ break;
case 'h':
in_help = true;
break;
+ case 'H':
+ aggregate_pids ^= true;
+ if (aggregate_pids)
+ header_msg = "Aggregating clients.";
+ else
+ header_msg = "Showing individual clients.";
+ break;
};
}
}
@@ -1626,6 +2380,10 @@ static void show_help_screen(void)
printf(
"Help for interactive commands:\n\n"
" '1' Toggle between aggregated engine class and physical engine mode.\n"
+" 'n' Toggle display of numeric client busyness overlay.\n"
+" 's' Toggle between sort modes (runtime, total runtime, pid, client id).\n"
+" 'i' Toggle display of clients which used no GPU time.\n"
+" 'H' Toggle between per PID aggregation and individual clients.\n"
"\n"
" 'h' or 'q' Exit interactive help.\n"
"\n");
@@ -1634,6 +2392,7 @@ static void show_help_screen(void)
int main(int argc, char **argv)
{
unsigned int period_us = DEFAULT_PERIOD_MS * 1000;
+ struct clients *clients = NULL;
int con_w = -1, con_h = -1;
char *output_path = NULL;
struct engines *engines;
@@ -1767,15 +2526,24 @@ int main(int argc, char **argv)
ret = EXIT_SUCCESS;
+ clients = init_clients(card.pci_slot_name[0] ?
+ card.pci_slot_name : IGPU_PCI);
init_engine_classes(engines);
+ if (clients) {
+ clients->num_classes = engines->num_classes;
+ clients->class = engines->class;
+ }
pmu_sample(engines);
+ scan_clients(clients);
codename = igt_device_get_pretty_name(&card, false);
while (!stop_top) {
+ struct clients *disp_clients;
bool consumed = false;
+ int j, lines = 0;
struct winsize ws;
- int lines = 0;
+ struct client *c;
double t;
/* Update terminal size. */
@@ -1794,6 +2562,8 @@ int main(int argc, char **argv)
pmu_sample(engines);
t = (double)(engines->ts.cur - engines->ts.prev) / 1e9;
+ disp_clients = scan_clients(clients);
+
if (stop_top)
break;
@@ -1813,12 +2583,41 @@ int main(int argc, char **argv)
lines = print_engines(engines, t, lines, con_w, con_h);
+ if (disp_clients) {
+ int class_w;
+
+ lines = print_clients_header(disp_clients, lines,
+ con_w, con_h,
+ &class_w);
+
+ for_each_client(disp_clients, c, j) {
+ assert(c->status != PROBE);
+ if (c->status != ALIVE)
+ break; /* Active clients are first in the array. */
+
+ if (lines >= con_h)
+ break;
+
+ lines = print_client(c, engines, t,
+ lines, con_w,
+ con_h, period_us,
+ &class_w);
+ }
+
+ lines = print_clients_footer(disp_clients, t,
+ lines, con_w,
+ con_h);
+ }
+
pops->close_struct();
}
if (stop_top)
break;
+ if (disp_clients != clients)
+ free_clients(disp_clients);
+
if (output_mode == INTERACTIVE)
process_stdin(period_us);
else
diff --git a/tools/meson.build b/tools/meson.build
index b6b9753463a9..771d0b9e3d5d 100644
--- a/tools/meson.build
+++ b/tools/meson.build
@@ -91,7 +91,7 @@ install_subdir('registers', install_dir : datadir)
executable('intel_gpu_top', 'intel_gpu_top.c',
install : true,
install_rpath : bindir_rpathdir,
- dependencies : [lib_igt_perf,lib_igt_device_scan,math])
+ dependencies : [lib_igt_perf,lib_igt_device_scan,lib_igt_drm_fdinfo,math])
executable('amd_hdmi_compliance', 'amd_hdmi_compliance.c',
dependencies : [tool_deps],
--
2.32.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 0/3] Per client GPU utilisation
@ 2022-04-01 14:11 Tvrtko Ursulin
2022-04-01 14:11 ` [igt-dev] [PATCH i-g-t 1/3] lib: Helper library for parsing i915 fdinfo output Tvrtko Ursulin
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Tvrtko Ursulin @ 2022-04-01 14:11 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx, dri-devel, Tvrtko Ursulin
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Only first three patches for review purposes (first stage) - adding the test and
intel_gpu_top support.
Tvrtko Ursulin (3):
lib: Helper library for parsing i915 fdinfo output
tests/i915/drm_fdinfo: Basic and functional tests for GPU busyness
exported via fdinfo
intel-gpu-top: Add support for per client stats
lib/igt_drm_fdinfo.c | 188 ++++++++++
lib/igt_drm_fdinfo.h | 69 ++++
lib/meson.build | 7 +
man/intel_gpu_top.rst | 4 +
tests/i915/drm_fdinfo.c | 557 +++++++++++++++++++++++++++
tests/meson.build | 8 +
tools/intel_gpu_top.c | 806 +++++++++++++++++++++++++++++++++++++++-
tools/meson.build | 2 +-
8 files changed, 1638 insertions(+), 3 deletions(-)
create mode 100644 lib/igt_drm_fdinfo.c
create mode 100644 lib/igt_drm_fdinfo.h
create mode 100644 tests/i915/drm_fdinfo.c
--
2.32.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 1/3] lib: Helper library for parsing i915 fdinfo output
2022-04-01 14:11 [igt-dev] [PATCH i-g-t 0/3] Per client GPU utilisation Tvrtko Ursulin
@ 2022-04-01 14:11 ` Tvrtko Ursulin
2022-04-01 15:14 ` [igt-dev] [Intel-gfx] " Umesh Nerlige Ramappa
2022-04-01 14:11 ` [igt-dev] [PATCH i-g-t 2/3] tests/i915/drm_fdinfo: Basic and functional tests for GPU busyness exported via fdinfo Tvrtko Ursulin
` (3 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Tvrtko Ursulin @ 2022-04-01 14:11 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx, dri-devel, Tvrtko Ursulin
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Tests and intel_gpu_top will share common code for parsing this file.
v2:
* Fix key-value parsing if valid key line ends with ':'.
* Return number of drm keys found.
* Add DRM_CLIENT_FDINFO_MAX_ENGINES. (Umesh)
* Always zero terminate read buffer. (Umesh)
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
lib/igt_drm_fdinfo.c | 188 +++++++++++++++++++++++++++++++++++++++++++
lib/igt_drm_fdinfo.h | 69 ++++++++++++++++
lib/meson.build | 7 ++
3 files changed, 264 insertions(+)
create mode 100644 lib/igt_drm_fdinfo.c
create mode 100644 lib/igt_drm_fdinfo.h
diff --git a/lib/igt_drm_fdinfo.c b/lib/igt_drm_fdinfo.c
new file mode 100644
index 000000000000..b422f67a4ace
--- /dev/null
+++ b/lib/igt_drm_fdinfo.c
@@ -0,0 +1,188 @@
+/*
+ * Copyright © 2022 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ */
+
+#include <ctype.h>
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <fcntl.h>
+#include <stdio.h>
+#include <string.h>
+#include <stdlib.h>
+#include <unistd.h>
+
+#include "drmtest.h"
+
+#include "igt_drm_fdinfo.h"
+
+static size_t read_fdinfo(char *buf, const size_t sz, int at, const char *name)
+{
+ size_t count;
+ int fd;
+
+ fd = openat(at, name, O_RDONLY);
+ if (fd < 0)
+ return 0;
+
+ buf[sz - 1] = 0;
+ count = read(fd, buf, sz);
+ buf[sz - 1] = 0;
+ close(fd);
+
+ return count;
+}
+
+static int parse_engine(char *line, struct drm_client_fdinfo *info,
+ size_t prefix_len, uint64_t *val)
+{
+ static const char *e2class[] = {
+ "render",
+ "copy",
+ "video",
+ "video-enhance",
+ };
+ ssize_t name_len;
+ char *name, *p;
+ int found = -1;
+ unsigned int i;
+
+ p = index(line, ':');
+ if (!p || p == line)
+ return -1;
+
+ name_len = p - line - prefix_len;
+ if (name_len < 1)
+ return -1;
+
+ name = line + prefix_len;
+
+ for (i = 0; i < ARRAY_SIZE(e2class); i++) {
+ if (!strncmp(name, e2class[i], name_len)) {
+ found = i;
+ break;
+ }
+ }
+
+ if (found >= 0) {
+ while (*++p && isspace(*p));
+ *val = strtoull(p, NULL, 10);
+ }
+
+ return found;
+}
+
+static const char *find_kv(const char *buf, const char *key, size_t keylen)
+{
+ const char *p = buf;
+
+ if (strncmp(buf, key, keylen))
+ return NULL;
+
+ p = index(buf, ':');
+ if (!p || p == buf)
+ return NULL;
+ if ((p - buf) != keylen)
+ return NULL;
+
+ p++;
+ while (*p && isspace(*p))
+ p++;
+
+ return *p ? p : NULL;
+}
+
+unsigned int
+__igt_parse_drm_fdinfo(int dir, const char *fd, struct drm_client_fdinfo *info)
+{
+ char buf[4096], *_buf = buf;
+ char *l, *ctx = NULL;
+ unsigned int good = 0, num_capacity = 0;
+ size_t count;
+
+ count = read_fdinfo(buf, sizeof(buf), dir, fd);
+ if (!count)
+ return 0;
+
+ while ((l = strtok_r(_buf, "\n", &ctx))) {
+ uint64_t val = 0;
+ const char *v;
+ int idx;
+
+ _buf = NULL;
+
+ if ((v = find_kv(l, "drm-driver", strlen("drm-driver")))) {
+ strncpy(info->driver, v, sizeof(info->driver) - 1);
+ good++;
+ } else if ((v = find_kv(l, "drm-pdev", strlen("drm-pdev")))) {
+ strncpy(info->pdev, v, sizeof(info->pdev) - 1);
+ } else if ((v = find_kv(l, "drm-client-id",
+ strlen("drm-client-id")))) {
+ info->id = atol(v);
+ good++;
+ } else if (!strncmp(l, "drm-engine-", 11) &&
+ strncmp(l, "drm-engine-capacity-", 20)) {
+ idx = parse_engine(l, info, strlen("drm-engine-"),
+ &val);
+ if (idx >= 0) {
+ if (!info->capacity[idx])
+ info->capacity[idx] = 1;
+ info->busy[idx] = val;
+ info->num_engines++;
+ }
+ } else if (!strncmp(l, "drm-engine-capacity-", 20)) {
+ idx = parse_engine(l, info,
+ strlen("drm-engine-capacity-"),
+ &val);
+ if (idx >= 0) {
+ info->capacity[idx] = val;
+ num_capacity++;
+ }
+ }
+ }
+
+ if (good < 2 || !info->num_engines)
+ return 0; /* fdinfo format not as expected */
+
+ return good + info->num_engines + num_capacity;
+}
+
+unsigned int igt_parse_drm_fdinfo(int drm_fd, struct drm_client_fdinfo *info)
+{
+ unsigned int res;
+ char fd[64];
+ int dir, ret;
+
+ ret = snprintf(fd, sizeof(fd), "%u", drm_fd);
+ if (ret < 0 || ret == sizeof(fd))
+ return false;
+
+ dir = open("/proc/self/fdinfo", O_DIRECTORY | O_RDONLY);
+ if (dir < 0)
+ return false;
+
+ res = __igt_parse_drm_fdinfo(dir, fd, info);
+
+ close(dir);
+
+ return res;
+}
diff --git a/lib/igt_drm_fdinfo.h b/lib/igt_drm_fdinfo.h
new file mode 100644
index 000000000000..5db63e28b07e
--- /dev/null
+++ b/lib/igt_drm_fdinfo.h
@@ -0,0 +1,69 @@
+/*
+ * Copyright © 2022 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ */
+
+#ifndef IGT_DRM_FDINFO_H
+#define IGT_DRM_FDINFO_H
+
+#include <sys/types.h>
+#include <dirent.h>
+#include <stdint.h>
+#include <stdbool.h>
+
+#define DRM_CLIENT_FDINFO_MAX_ENGINES 16
+
+struct drm_client_fdinfo {
+ char driver[128];
+ char pdev[128];
+ unsigned long id;
+
+ unsigned int num_engines;
+ unsigned int capacity[DRM_CLIENT_FDINFO_MAX_ENGINES];
+ uint64_t busy[DRM_CLIENT_FDINFO_MAX_ENGINES];
+};
+
+/**
+ * igt_parse_drm_fdinfo: Parses the drm fdinfo file
+ *
+ * @drm_fd: DRM file descriptor
+ * @info: Structure to populate with read data
+ *
+ * Returns the number of valid drm fdinfo keys found or zero if not all
+ * mandatory keys were present or no engines found.
+ */
+unsigned int igt_parse_drm_fdinfo(int drm_fd, struct drm_client_fdinfo *info);
+
+/**
+ * __igt_parse_drm_fdinfo: Parses the drm fdinfo file
+ *
+ * @dir: File descriptor pointing to /proc/pid/fdinfo directory
+ * @fd: String representation of the file descriptor number to parse.
+ * @info: Structure to populate with read data
+ *
+ * Returns the number of valid drm fdinfo keys found or zero if not all
+ * mandatory keys were present or no engines found.
+ */
+unsigned int __igt_parse_drm_fdinfo(int dir, const char *fd,
+ struct drm_client_fdinfo *info);
+
+#endif /* IGT_DRM_FDINFO_H */
diff --git a/lib/meson.build b/lib/meson.build
index 6fc1958604b3..ccee7a596561 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -18,6 +18,7 @@ lib_sources = [
'igt_debugfs.c',
'igt_device.c',
'igt_device_scan.c',
+ 'igt_drm_fdinfo.c',
'igt_aux.c',
'igt_gt.c',
'igt_halffloat.c',
@@ -218,6 +219,12 @@ lib_igt_device_scan_build = static_library('igt_device_scan',
lib_igt_device_scan = declare_dependency(link_with : lib_igt_device_scan_build,
include_directories : inc)
+lib_igt_drm_fdinfo_build = static_library('igt_drm_fdinfo',
+ ['igt_drm_fdinfo.c'],
+ include_directories : inc)
+
+lib_igt_drm_fdinfo = declare_dependency(link_with : lib_igt_drm_fdinfo_build,
+ include_directories : inc)
i915_perf_files = [
'igt_list.c',
'i915/perf.c',
--
2.32.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 2/3] tests/i915/drm_fdinfo: Basic and functional tests for GPU busyness exported via fdinfo
2022-04-01 14:11 [igt-dev] [PATCH i-g-t 0/3] Per client GPU utilisation Tvrtko Ursulin
2022-04-01 14:11 ` [igt-dev] [PATCH i-g-t 1/3] lib: Helper library for parsing i915 fdinfo output Tvrtko Ursulin
@ 2022-04-01 14:11 ` Tvrtko Ursulin
2022-04-01 14:11 ` [igt-dev] [PATCH i-g-t 3/3] intel-gpu-top: Add support for per client stats Tvrtko Ursulin
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Tvrtko Ursulin @ 2022-04-01 14:11 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx, dri-devel, Tvrtko Ursulin
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Mostly inherited from the perf_pmu, some basic tests, and some tests to
verify exported GPU busyness is as expected.
v2:
* Skip when kernel does not export drm keys in fdinfo.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
tests/i915/drm_fdinfo.c | 557 ++++++++++++++++++++++++++++++++++++++++
tests/meson.build | 8 +
2 files changed, 565 insertions(+)
create mode 100644 tests/i915/drm_fdinfo.c
diff --git a/tests/i915/drm_fdinfo.c b/tests/i915/drm_fdinfo.c
new file mode 100644
index 000000000000..3475d35b23b9
--- /dev/null
+++ b/tests/i915/drm_fdinfo.c
@@ -0,0 +1,557 @@
+/*
+ * Copyright © 2022 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ */
+
+#include "igt.h"
+#include "igt_core.h"
+#include "igt_device.h"
+#include "igt_drm_fdinfo.h"
+#include "i915/gem.h"
+#include "intel_ctx.h"
+
+IGT_TEST_DESCRIPTION("Test the i915 drm fdinfo data");
+
+const double tolerance = 0.05f;
+const unsigned long batch_duration_ns = 500e6;
+
+#define __assert_within_epsilon(x, ref, tol_up, tol_down) \
+ igt_assert_f((double)(x) <= (1.0 + (tol_up)) * (double)(ref) && \
+ (double)(x) >= (1.0 - (tol_down)) * (double)(ref), \
+ "'%s' != '%s' (%f not within +%.1f%%/-%.1f%% tolerance of %f)\n",\
+ #x, #ref, (double)(x), \
+ (tol_up) * 100.0, (tol_down) * 100.0, \
+ (double)(ref))
+
+#define assert_within_epsilon(x, ref, tolerance) \
+ __assert_within_epsilon(x, ref, tolerance, tolerance)
+
+static void basics(int i915, unsigned int num_classes)
+{
+ struct drm_client_fdinfo info = { };
+ unsigned int ret;
+
+ ret = igt_parse_drm_fdinfo(i915, &info);
+ igt_assert(ret);
+
+ igt_assert(!strcmp(info.driver, "i915"));
+
+ igt_assert_eq(info.num_engines, num_classes);
+}
+
+/*
+ * Helper for cases where we assert on time spent sleeping (directly or
+ * indirectly), so make it more robust by ensuring the system sleep time
+ * is within test tolerance to start with.
+ */
+static unsigned int measured_usleep(unsigned int usec)
+{
+ struct timespec ts = { };
+ unsigned int slept;
+
+ slept = igt_nsec_elapsed(&ts);
+ igt_assert(slept == 0);
+ do {
+ usleep(usec - slept);
+ slept = igt_nsec_elapsed(&ts) / 1000;
+ } while (slept < usec);
+
+ return igt_nsec_elapsed(&ts);
+}
+
+#define TEST_BUSY (1)
+#define FLAG_SYNC (2)
+#define TEST_TRAILING_IDLE (4)
+#define FLAG_HANG (8)
+#define TEST_ISOLATION (16)
+
+static igt_spin_t *__spin_poll(int fd, uint64_t ahnd, const intel_ctx_t *ctx,
+ const struct intel_execution_engine2 *e)
+{
+ struct igt_spin_factory opts = {
+ .ahnd = ahnd,
+ .ctx = ctx,
+ .engine = e->flags,
+ };
+
+ if (gem_class_can_store_dword(fd, e->class))
+ opts.flags |= IGT_SPIN_POLL_RUN;
+
+ return __igt_spin_factory(fd, &opts);
+}
+
+static unsigned long __spin_wait(int fd, igt_spin_t *spin)
+{
+ struct timespec start = { };
+
+ igt_nsec_elapsed(&start);
+
+ if (igt_spin_has_poll(spin)) {
+ unsigned long timeout = 0;
+
+ while (!igt_spin_has_started(spin)) {
+ unsigned long t = igt_nsec_elapsed(&start);
+
+ igt_assert(gem_bo_busy(fd, spin->handle));
+ if ((t - timeout) > 250e6) {
+ timeout = t;
+ igt_warn("Spinner not running after %.2fms\n",
+ (double)t / 1e6);
+ igt_assert(t < 2e9);
+ }
+ }
+ } else {
+ igt_debug("__spin_wait - usleep mode\n");
+ usleep(500e3); /* Better than nothing! */
+ }
+
+ igt_assert(gem_bo_busy(fd, spin->handle));
+ return igt_nsec_elapsed(&start);
+}
+
+static igt_spin_t *__spin_sync(int fd, uint64_t ahnd, const intel_ctx_t *ctx,
+ const struct intel_execution_engine2 *e)
+{
+ igt_spin_t *spin = __spin_poll(fd, ahnd, ctx, e);
+
+ __spin_wait(fd, spin);
+
+ return spin;
+}
+
+static igt_spin_t *spin_sync(int fd, uint64_t ahnd, const intel_ctx_t *ctx,
+ const struct intel_execution_engine2 *e)
+{
+ igt_require_gem(fd);
+
+ return __spin_sync(fd, ahnd, ctx, e);
+}
+
+static void end_spin(int fd, igt_spin_t *spin, unsigned int flags)
+{
+ if (!spin)
+ return;
+
+ igt_spin_end(spin);
+
+ if (flags & FLAG_SYNC)
+ gem_sync(fd, spin->handle);
+
+ if (flags & TEST_TRAILING_IDLE) {
+ unsigned long t, timeout = 0;
+ struct timespec start = { };
+
+ igt_nsec_elapsed(&start);
+
+ do {
+ t = igt_nsec_elapsed(&start);
+
+ if (gem_bo_busy(fd, spin->handle) &&
+ (t - timeout) > 10e6) {
+ timeout = t;
+ igt_warn("Spinner not idle after %.2fms\n",
+ (double)t / 1e6);
+ }
+
+ usleep(1e3);
+ } while (t < batch_duration_ns / 5);
+ }
+}
+
+static uint64_t read_busy(int i915, unsigned int class)
+{
+ struct drm_client_fdinfo info = { };
+
+ igt_assert(igt_parse_drm_fdinfo(i915, &info));
+
+ return info.busy[class];
+}
+
+static void
+single(int gem_fd, const intel_ctx_t *ctx,
+ const struct intel_execution_engine2 *e, unsigned int flags)
+{
+ unsigned long slept;
+ igt_spin_t *spin;
+ uint64_t val;
+ int spin_fd;
+ uint64_t ahnd;
+
+ if (flags & TEST_ISOLATION) {
+ spin_fd = gem_reopen_driver(gem_fd);
+ ctx = intel_ctx_create_all_physical(spin_fd);
+ } else {
+ spin_fd = gem_fd;
+ }
+
+ ahnd = get_reloc_ahnd(spin_fd, ctx->id);
+
+ if (flags & TEST_BUSY)
+ spin = spin_sync(spin_fd, ahnd, ctx, e);
+ else
+ spin = NULL;
+
+ val = read_busy(gem_fd, e->class);
+ slept = measured_usleep(batch_duration_ns / 1000);
+ if (flags & TEST_TRAILING_IDLE)
+ end_spin(spin_fd, spin, flags);
+ val = read_busy(gem_fd, e->class) - val;
+
+ if (flags & FLAG_HANG)
+ igt_force_gpu_reset(spin_fd);
+ else
+ end_spin(spin_fd, spin, FLAG_SYNC);
+
+ assert_within_epsilon(val,
+ (flags & TEST_BUSY) && !(flags & TEST_ISOLATION) ?
+ slept : 0.0f,
+ tolerance);
+
+ /* Check for idle after hang. */
+ if (flags & FLAG_HANG) {
+ gem_quiescent_gpu(spin_fd);
+ igt_assert(!gem_bo_busy(spin_fd, spin->handle));
+
+ val = read_busy(gem_fd, e->class);
+ slept = measured_usleep(batch_duration_ns / 1000);
+ val = read_busy(gem_fd, e->class) - val;
+
+ assert_within_epsilon(val, 0, tolerance);
+ }
+
+ igt_spin_free(spin_fd, spin);
+ put_ahnd(ahnd);
+
+ gem_quiescent_gpu(spin_fd);
+}
+
+static void log_busy(unsigned int num_engines, uint64_t *val)
+{
+ char buf[1024];
+ int rem = sizeof(buf);
+ unsigned int i;
+ char *p = buf;
+
+ for (i = 0; i < num_engines; i++) {
+ int len;
+
+ len = snprintf(p, rem, "%u=%" PRIu64 "\n", i, val[i]);
+ igt_assert(len > 0);
+ rem -= len;
+ p += len;
+ }
+
+ igt_info("%s", buf);
+}
+
+static void read_busy_all(int i915, uint64_t *val)
+{
+ struct drm_client_fdinfo info = { };
+
+ igt_assert(igt_parse_drm_fdinfo(i915, &info));
+
+ memcpy(val, info.busy, sizeof(info.busy));
+}
+
+static void
+busy_check_all(int gem_fd, const intel_ctx_t *ctx,
+ const struct intel_execution_engine2 *e,
+ const unsigned int num_engines,
+ const unsigned int classes[16], const unsigned int num_classes,
+ unsigned int flags)
+{
+ uint64_t ahnd = get_reloc_ahnd(gem_fd, ctx->id);
+ uint64_t tval[2][16];
+ unsigned long slept;
+ uint64_t val[16];
+ igt_spin_t *spin;
+ unsigned int i;
+
+ memset(tval, 0, sizeof(tval));
+
+ spin = spin_sync(gem_fd, ahnd, ctx, e);
+
+ read_busy_all(gem_fd, tval[0]);
+ slept = measured_usleep(batch_duration_ns / 1000);
+ if (flags & TEST_TRAILING_IDLE)
+ end_spin(gem_fd, spin, flags);
+ read_busy_all(gem_fd, tval[1]);
+
+ end_spin(gem_fd, spin, FLAG_SYNC);
+ igt_spin_free(gem_fd, spin);
+ put_ahnd(ahnd);
+
+ for (i = 0; i < num_classes; i++)
+ val[i] = tval[1][i] - tval[0][i];
+
+ log_busy(num_classes, val);
+
+ for (i = 0; i < num_classes; i++) {
+ double target = i == e->class ? slept : 0.0f;
+
+ assert_within_epsilon(val[i], target, tolerance);
+ }
+
+ gem_quiescent_gpu(gem_fd);
+}
+
+static void
+__submit_spin(int gem_fd, igt_spin_t *spin,
+ const struct intel_execution_engine2 *e,
+ int offset)
+{
+ struct drm_i915_gem_execbuffer2 eb = spin->execbuf;
+
+ eb.flags &= ~(0x3f | I915_EXEC_BSD_MASK);
+ eb.flags |= e->flags | I915_EXEC_NO_RELOC;
+ eb.batch_start_offset += offset;
+
+ gem_execbuf(gem_fd, &eb);
+}
+
+static void
+most_busy_check_all(int gem_fd, const intel_ctx_t *ctx,
+ const struct intel_execution_engine2 *e,
+ const unsigned int num_engines,
+ const unsigned int classes[16],
+ const unsigned int num_classes,
+ unsigned int flags)
+{
+ uint64_t ahnd = get_reloc_ahnd(gem_fd, ctx->id);
+ unsigned int busy_class[num_classes];
+ struct intel_execution_engine2 *e_;
+ igt_spin_t *spin = NULL;
+ uint64_t tval[2][16];
+ unsigned long slept;
+ uint64_t val[16];
+ unsigned int i;
+
+ memset(busy_class, 0, sizeof(busy_class));
+ memset(tval, 0, sizeof(tval));
+
+ for_each_ctx_engine(gem_fd, ctx, e_) {
+ if (e->class == e_->class && e->instance == e_->instance) {
+ continue;
+ } else if (spin) {
+ __submit_spin(gem_fd, spin, e_, 64);
+ busy_class[e_->class]++;
+ } else {
+ spin = __spin_poll(gem_fd, ahnd, ctx, e_);
+ busy_class[e_->class]++;
+ }
+ }
+ igt_require(spin); /* at least one busy engine */
+
+ /* Small delay to allow engines to start. */
+ usleep(__spin_wait(gem_fd, spin) * num_engines / 1e3);
+
+ read_busy_all(gem_fd, tval[0]);
+ slept = measured_usleep(batch_duration_ns / 1000);
+ if (flags & TEST_TRAILING_IDLE)
+ end_spin(gem_fd, spin, flags);
+ read_busy_all(gem_fd, tval[1]);
+
+ end_spin(gem_fd, spin, FLAG_SYNC);
+ igt_spin_free(gem_fd, spin);
+ put_ahnd(ahnd);
+
+ for (i = 0; i < num_classes; i++)
+ val[i] = tval[1][i] - tval[0][i];
+
+ log_busy(num_classes, val);
+
+ for (i = 0; i < num_classes; i++) {
+ double target = slept * busy_class[i];
+
+ assert_within_epsilon(val[i], target, tolerance);
+ }
+ gem_quiescent_gpu(gem_fd);
+}
+
+static void
+all_busy_check_all(int gem_fd, const intel_ctx_t *ctx,
+ const unsigned int num_engines,
+ const unsigned int classes[16],
+ const unsigned int num_classes,
+ unsigned int flags)
+{
+ uint64_t ahnd = get_reloc_ahnd(gem_fd, ctx->id);
+ unsigned int busy_class[num_classes];
+ struct intel_execution_engine2 *e;
+ igt_spin_t *spin = NULL;
+ uint64_t tval[2][16];
+ unsigned long slept;
+ uint64_t val[16];
+ unsigned int i;
+
+ memset(busy_class, 0, sizeof(busy_class));
+ memset(tval, 0, sizeof(tval));
+
+ for_each_ctx_engine(gem_fd, ctx, e) {
+ if (spin)
+ __submit_spin(gem_fd, spin, e, 64);
+ else
+ spin = __spin_poll(gem_fd, ahnd, ctx, e);
+ busy_class[e->class]++;
+ }
+
+ /* Small delay to allow engines to start. */
+ usleep(__spin_wait(gem_fd, spin) * num_engines / 1e3);
+
+ read_busy_all(gem_fd, tval[0]);
+ slept = measured_usleep(batch_duration_ns / 1000);
+ if (flags & TEST_TRAILING_IDLE)
+ end_spin(gem_fd, spin, flags);
+ read_busy_all(gem_fd, tval[1]);
+
+ end_spin(gem_fd, spin, FLAG_SYNC);
+ igt_spin_free(gem_fd, spin);
+ put_ahnd(ahnd);
+
+ for (i = 0; i < num_classes; i++)
+ val[i] = tval[1][i] - tval[0][i];
+
+ log_busy(num_classes, val);
+
+ for (i = 0; i < num_classes; i++) {
+ double target = slept * busy_class[i];
+
+ assert_within_epsilon(val[i], target, tolerance);
+ }
+ gem_quiescent_gpu(gem_fd);
+}
+
+#define test_each_engine(T, i915, ctx, e) \
+ igt_subtest_with_dynamic(T) for_each_ctx_engine(i915, ctx, e) \
+ igt_dynamic_f("%s", e->name)
+
+igt_main
+{
+ unsigned int num_engines = 0, num_classes = 0;
+ const struct intel_execution_engine2 *e;
+ unsigned int classes[16] = { };
+ const intel_ctx_t *ctx = NULL;
+ int i915 = -1;
+
+ igt_fixture {
+ struct drm_client_fdinfo info = { };
+ unsigned int i;
+
+ i915 = __drm_open_driver(DRIVER_INTEL);
+
+ igt_require_gem(i915);
+ igt_require(igt_parse_drm_fdinfo(i915, &info));
+
+ ctx = intel_ctx_create_all_physical(i915);
+
+ for_each_ctx_engine(i915, ctx, e) {
+ num_engines++;
+ igt_assert(e->class < ARRAY_SIZE(classes));
+ classes[e->class]++;
+ }
+ igt_require(num_engines);
+
+ for (i = 0; i < ARRAY_SIZE(classes); i++) {
+ if (classes[i])
+ num_classes++;
+ }
+ igt_assert(num_classes);
+ }
+
+ /**
+ * Test basic fdinfo content.
+ */
+ igt_subtest("basics")
+ basics(i915, num_classes);
+
+ /**
+ * Test that engines show no load when idle.
+ */
+ test_each_engine("idle", i915, ctx, e)
+ single(i915, ctx, e, 0);
+
+ /**
+ * Test that a single engine reports load correctly.
+ */
+ test_each_engine("busy", i915, ctx, e)
+ single(i915, ctx, e, TEST_BUSY);
+
+ test_each_engine("busy-idle", i915, ctx, e)
+ single(i915, ctx, e, TEST_BUSY | TEST_TRAILING_IDLE);
+
+ test_each_engine("busy-hang", i915, ctx, e) {
+ igt_hang_t hang = igt_allow_hang(i915, ctx->id, 0);
+
+ single(i915, ctx, e, TEST_BUSY | FLAG_HANG);
+
+ igt_disallow_hang(i915, hang);
+ }
+
+ /**
+ * Test that when one engine is loaded other report no
+ * load.
+ */
+ test_each_engine("busy-check-all", i915, ctx, e)
+ busy_check_all(i915, ctx, e, num_engines, classes, num_classes,
+ TEST_BUSY);
+
+ test_each_engine("busy-idle-check-all", i915, ctx, e)
+ busy_check_all(i915, ctx, e, num_engines, classes, num_classes,
+ TEST_BUSY | TEST_TRAILING_IDLE);
+
+ /**
+ * Test that when all except one engine are loaded all
+ * loads are correctly reported.
+ */
+ test_each_engine("most-busy-check-all", i915, ctx, e)
+ most_busy_check_all(i915, ctx, e, num_engines,
+ classes, num_classes,
+ TEST_BUSY);
+
+ test_each_engine("most-busy-idle-check-all", i915, ctx, e)
+ most_busy_check_all(i915, ctx, e, num_engines,
+ classes, num_classes,
+ TEST_BUSY | TEST_TRAILING_IDLE);
+
+ /**
+ * Test that when all engines are loaded all loads are
+ * correctly reported.
+ */
+ igt_subtest("all-busy-check-all")
+ all_busy_check_all(i915, ctx, num_engines, classes, num_classes,
+ TEST_BUSY);
+
+ igt_subtest("all-busy-idle-check-all")
+ all_busy_check_all(i915, ctx, num_engines, classes, num_classes,
+ TEST_BUSY | TEST_TRAILING_IDLE);
+
+ /**
+ * Test for no cross-client contamination.
+ */
+ test_each_engine("isolation", i915, ctx, e)
+ single(i915, ctx, e, TEST_BUSY | TEST_ISOLATION);
+
+ igt_fixture {
+ intel_ctx_destroy(i915, ctx);
+ close(i915);
+ }
+}
diff --git a/tests/meson.build b/tests/meson.build
index a152d2a05291..b0eab3d6c8e3 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -293,6 +293,14 @@ foreach prog : i915_progs
test_list += prog
endforeach
+test_executables += executable('drm_fdinfo',
+ join_paths('i915', 'drm_fdinfo.c'),
+ dependencies : test_deps + [ lib_igt_drm_fdinfo ],
+ install_dir : libexecdir,
+ install_rpath : libexecdir_rpathdir,
+ install : true)
+test_list += 'drm_fdinfo'
+
test_executables += executable('dumb_buffer', 'dumb_buffer.c',
dependencies : test_deps + [ libatomic ],
install_dir : libexecdir,
--
2.32.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 3/3] intel-gpu-top: Add support for per client stats
2022-04-01 14:11 [igt-dev] [PATCH i-g-t 0/3] Per client GPU utilisation Tvrtko Ursulin
2022-04-01 14:11 ` [igt-dev] [PATCH i-g-t 1/3] lib: Helper library for parsing i915 fdinfo output Tvrtko Ursulin
2022-04-01 14:11 ` [igt-dev] [PATCH i-g-t 2/3] tests/i915/drm_fdinfo: Basic and functional tests for GPU busyness exported via fdinfo Tvrtko Ursulin
@ 2022-04-01 14:11 ` Tvrtko Ursulin
2022-04-01 14:56 ` [igt-dev] ✓ Fi.CI.BAT: success for Per client GPU utilisation (rev3) Patchwork
2022-04-01 16:54 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Tvrtko Ursulin @ 2022-04-01 14:11 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx, dri-devel, Tvrtko Ursulin
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Use the i915 exported data in /proc/<pid>/fdinfo to show GPU utilization
per DRM client.
Example of the output:
intel-gpu-top: Intel Tigerlake (Gen12) @ /dev/dri/card0 - 220/ 221 MHz
70% RC6; 0.62/ 7.08 W; 760 irqs/s
ENGINES BUSY MI_SEMA MI_WAIT
Render/3D 23.06% |██████▊ | 0% 0%
Blitter 0.00% | | 0% 0%
Video 5.40% |█▋ | 0% 0%
VideoEnhance 20.67% |██████ | 0% 0%
PID NAME Render/3D Blitter Video VideoEnhance
3082 mpv | || ||▌ ||██ |
3117 neverball |█▉ || || || |
1 systemd |▍ || || || |
2338 gnome-shell | || || || |
v2:
* Removed hardcoded array size from client add/update by passing in
drm_fd_info directly.
* Added some asserts and simplified a couple expressions. (Umesh)
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
man/intel_gpu_top.rst | 4 +
tools/intel_gpu_top.c | 806 +++++++++++++++++++++++++++++++++++++++++-
tools/meson.build | 2 +-
3 files changed, 809 insertions(+), 3 deletions(-)
diff --git a/man/intel_gpu_top.rst b/man/intel_gpu_top.rst
index b3b765b05feb..f4dbfc5b44d9 100644
--- a/man/intel_gpu_top.rst
+++ b/man/intel_gpu_top.rst
@@ -56,6 +56,10 @@ Supported keys:
'q' Exit from the tool.
'h' Show interactive help.
'1' Toggle between aggregated engine class and physical engine mode.
+ 'n' Toggle display of numeric client busyness overlay.
+ 's' Toggle between sort modes (runtime, total runtime, pid, client id).
+ 'i' Toggle display of clients which used no GPU time.
+ 'H' Toggle between per PID aggregation and individual clients.
DEVICE SELECTION
================
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index bc11fce2bb1e..1984c10dca29 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -43,8 +43,10 @@
#include <sys/types.h>
#include <unistd.h>
#include <termios.h>
+#include <sys/sysmacros.h>
#include "igt_perf.h"
+#include "igt_drm_fdinfo.h"
#define ARRAY_SIZE(arr) (sizeof(arr)/sizeof(arr[0]))
@@ -311,7 +313,8 @@ static int engine_cmp(const void *__a, const void *__b)
return a->instance - b->instance;
}
-#define is_igpu_pci(x) (strcmp(x, "0000:00:02.0") == 0)
+#define IGPU_PCI "0000:00:02.0"
+#define is_igpu_pci(x) (strcmp(x, IGPU_PCI) == 0)
#define is_igpu(x) (strcmp(x, "i915") == 0)
static struct engines *discover_engines(char *device)
@@ -635,6 +638,552 @@ static void pmu_sample(struct engines *engines)
}
}
+enum client_status {
+ FREE = 0, /* mbz */
+ ALIVE,
+ PROBE
+};
+
+struct clients;
+
+struct client {
+ struct clients *clients;
+
+ enum client_status status;
+ unsigned int id;
+ unsigned int pid;
+ char name[24];
+ char print_name[24];
+ unsigned int samples;
+ unsigned long total_runtime;
+ unsigned long last_runtime;
+ unsigned long *val;
+ uint64_t *last;
+};
+
+struct clients {
+ unsigned int num_clients;
+ unsigned int active_clients;
+
+ unsigned int num_classes;
+ struct engine_class *class;
+
+ char pci_slot[64];
+
+ struct client *client;
+};
+
+#define for_each_client(clients, c, tmp) \
+ for ((tmp) = (clients)->num_clients, c = (clients)->client; \
+ (tmp > 0); (tmp)--, (c)++)
+
+static struct clients *init_clients(const char *pci_slot)
+{
+ struct clients *clients;
+
+ clients = malloc(sizeof(*clients));
+ if (!clients)
+ return NULL;
+
+ memset(clients, 0, sizeof(*clients));
+
+ strncpy(clients->pci_slot, pci_slot, sizeof(clients->pci_slot));
+
+ return clients;
+}
+
+static struct client *
+find_client(struct clients *clients, enum client_status status, unsigned int id)
+{
+ unsigned int start, num;
+ struct client *c;
+
+ start = status == FREE ? clients->active_clients : 0; /* Free block at the end. */
+ num = clients->num_clients - start;
+
+ for (c = &clients->client[start]; num; c++, num--) {
+ if (status != c->status)
+ continue;
+
+ if (status == FREE || c->id == id)
+ return c;
+ }
+
+ return NULL;
+}
+
+static void
+update_client(struct client *c, unsigned int pid, char *name,
+ const struct drm_client_fdinfo *info)
+{
+ unsigned int i;
+
+ if (c->pid != pid)
+ c->pid = pid;
+
+ if (strcmp(c->name, name)) {
+ char *p;
+
+ strncpy(c->name, name, sizeof(c->name) - 1);
+ strncpy(c->print_name, name, sizeof(c->print_name) - 1);
+
+ p = c->print_name;
+ while (*p) {
+ if (!isprint(*p))
+ *p = '*';
+ p++;
+ }
+ }
+
+ c->last_runtime = 0;
+ c->total_runtime = 0;
+
+ for (i = 0; i < c->clients->num_classes; i++) {
+ assert(i < ARRAY_SIZE(info->busy));
+
+ if (info->busy[i] < c->last[i])
+ continue; /* It will catch up soon. */
+
+ c->total_runtime += info->busy[i];
+ c->val[i] = info->busy[i] - c->last[i];
+ c->last_runtime += c->val[i];
+ c->last[i] = info->busy[i];
+ }
+
+ c->samples++;
+ c->status = ALIVE;
+}
+
+static void
+add_client(struct clients *clients, const struct drm_client_fdinfo *info,
+ unsigned int pid, char *name)
+{
+ struct client *c;
+
+ assert(!find_client(clients, ALIVE, info->id));
+
+ c = find_client(clients, FREE, 0);
+ if (!c) {
+ unsigned int idx = clients->num_clients;
+
+ clients->num_clients += (clients->num_clients + 2) / 2;
+ clients->client = realloc(clients->client,
+ clients->num_clients * sizeof(*c));
+ assert(clients->client);
+
+ c = &clients->client[idx];
+ memset(c, 0, (clients->num_clients - idx) * sizeof(*c));
+ }
+
+ c->id = info->id;
+ c->clients = clients;
+ c->val = calloc(clients->num_classes, sizeof(c->val));
+ c->last = calloc(clients->num_classes, sizeof(c->last));
+ assert(c->val && c->last);
+
+ update_client(c, pid, name, info);
+}
+
+static void free_client(struct client *c)
+{
+ free(c->val);
+ free(c->last);
+ memset(c, 0, sizeof(*c));
+}
+
+static int client_last_cmp(const void *_a, const void *_b)
+{
+ const struct client *a = _a;
+ const struct client *b = _b;
+ long tot_a, tot_b;
+
+ /*
+ * Sort clients in descending order of runtime in the previous sampling
+ * period for active ones, followed by inactive. Tie-breaker is client
+ * id.
+ */
+
+ tot_a = a->status == ALIVE ? a->last_runtime : -1;
+ tot_b = b->status == ALIVE ? b->last_runtime : -1;
+
+ tot_b -= tot_a;
+ if (tot_b > 0)
+ return 1;
+ if (tot_b < 0)
+ return -1;
+
+ return (int)b->id - a->id;
+}
+
+static int client_total_cmp(const void *_a, const void *_b)
+{
+ const struct client *a = _a;
+ const struct client *b = _b;
+ long tot_a, tot_b;
+
+ tot_a = a->status == ALIVE ? a->total_runtime : -1;
+ tot_b = b->status == ALIVE ? b->total_runtime : -1;
+
+ tot_b -= tot_a;
+ if (tot_b > 0)
+ return 1;
+ if (tot_b < 0)
+ return -1;
+
+ return (int)b->id - a->id;
+}
+
+static int client_id_cmp(const void *_a, const void *_b)
+{
+ const struct client *a = _a;
+ const struct client *b = _b;
+ int id_a, id_b;
+
+ id_a = a->status == ALIVE ? a->id : -1;
+ id_b = b->status == ALIVE ? b->id : -1;
+
+ id_b -= id_a;
+ if (id_b > 0)
+ return 1;
+ if (id_b < 0)
+ return -1;
+
+ return (int)b->id - a->id;
+}
+
+static int client_pid_cmp(const void *_a, const void *_b)
+{
+ const struct client *a = _a;
+ const struct client *b = _b;
+ int pid_a, pid_b;
+
+ pid_a = a->status == ALIVE ? a->pid : INT_MAX;
+ pid_b = b->status == ALIVE ? b->pid : INT_MAX;
+
+ pid_b -= pid_a;
+ if (pid_b > 0)
+ return -1;
+ if (pid_b < 0)
+ return 1;
+
+ return (int)a->id - b->id;
+}
+
+static int (*client_cmp)(const void *, const void *) = client_last_cmp;
+
+static struct clients *sort_clients(struct clients *clients,
+ int (*cmp)(const void *, const void *))
+{
+ unsigned int active, free;
+ struct client *c;
+ int tmp;
+
+ if (!clients)
+ return clients;
+
+ qsort(clients->client, clients->num_clients, sizeof(*clients->client),
+ cmp);
+
+ /* Trim excessive array space. */
+ active = 0;
+ for_each_client(clients, c, tmp) {
+ if (c->status != ALIVE)
+ break; /* Active clients are first in the array. */
+ active++;
+ }
+
+ clients->active_clients = active;
+
+ free = clients->num_clients - active;
+ if (free > clients->num_clients / 2) {
+ active = clients->num_clients - free / 2;
+ if (active != clients->num_clients) {
+ clients->num_clients = active;
+ clients->client = realloc(clients->client,
+ clients->num_clients *
+ sizeof(*c));
+ }
+ }
+
+ return clients;
+}
+
+static bool aggregate_pids = true;
+
+static struct clients *display_clients(struct clients *clients)
+{
+ struct client *ac, *c, *cp = NULL;
+ struct clients *aggregated;
+ int tmp, num = 0;
+
+ if (!aggregate_pids)
+ goto out;
+
+ /* Sort by pid first to make it easy to aggregate while walking. */
+ sort_clients(clients, client_pid_cmp);
+
+ aggregated = calloc(1, sizeof(*clients));
+ assert(aggregated);
+
+ ac = calloc(clients->num_clients, sizeof(*c));
+ assert(ac);
+
+ aggregated->num_classes = clients->num_classes;
+ aggregated->class = clients->class;
+ aggregated->client = ac;
+
+ for_each_client(clients, c, tmp) {
+ unsigned int i;
+
+ if (c->status == FREE)
+ break;
+
+ assert(c->status == ALIVE);
+
+ if (!cp || c->pid != cp->pid) {
+ ac = &aggregated->client[num++];
+
+ /* New pid. */
+ ac->clients = aggregated;
+ ac->status = ALIVE;
+ ac->id = -c->pid;
+ ac->pid = c->pid;
+ strcpy(ac->name, c->name);
+ strcpy(ac->print_name, c->print_name);
+ ac->val = calloc(clients->num_classes,
+ sizeof(ac->val[0]));
+ assert(ac->val);
+ ac->samples = 1;
+ }
+
+ cp = c;
+
+ if (c->samples < 2)
+ continue;
+
+ ac->samples = 2; /* All what matters for display. */
+ ac->total_runtime += c->total_runtime;
+ ac->last_runtime += c->last_runtime;
+
+ for (i = 0; i < clients->num_classes; i++)
+ ac->val[i] += c->val[i];
+ }
+
+ aggregated->num_clients = num;
+ aggregated->active_clients = num;
+
+ clients = aggregated;
+
+out:
+ return sort_clients(clients, client_cmp);
+}
+
+static void free_clients(struct clients *clients)
+{
+ struct client *c;
+ unsigned int tmp;
+
+ for_each_client(clients, c, tmp) {
+ free(c->val);
+ free(c->last);
+ }
+
+ free(clients->client);
+ free(clients);
+}
+
+static bool is_drm_fd(DIR *fd_dir, const char *name)
+{
+ struct stat stat;
+ int ret;
+
+ ret = fstatat(dirfd(fd_dir), name, &stat, 0);
+
+ return ret == 0 &&
+ (stat.st_mode & S_IFMT) == S_IFCHR &&
+ major(stat.st_rdev) == 226;
+}
+
+static bool get_task_name(const char *buffer, char *out, unsigned long sz)
+{
+ char *s = index(buffer, '(');
+ char *e = rindex(buffer, ')');
+ unsigned int len;
+
+ if (!s || !e)
+ return false;
+ assert(e >= s);
+
+ len = e - ++s;
+ if(!len || (len + 1) >= sz)
+ return false;
+
+ strncpy(out, s, len);
+ out[len] = 0;
+
+ return true;
+}
+
+static DIR *opendirat(DIR *at, const char *name)
+{
+ DIR *dir;
+ int fd;
+
+ fd = openat(dirfd(at), name, O_DIRECTORY);
+ if (fd < 0)
+ return NULL;
+
+ dir = fdopendir(fd);
+ if (!dir)
+ close(fd);
+
+ return dir;
+}
+
+static FILE *fropenat(DIR *at, const char *name)
+{
+ FILE *f;
+ int fd;
+
+ fd = openat(dirfd(at), name, O_RDONLY);
+ if (fd < 0)
+ return NULL;
+
+ f = fdopen(fd, "r");
+ if (!f)
+ close(fd);
+
+ return f;
+}
+
+static size_t freadat2buf(char *buf, const size_t sz, DIR *at, const char *name)
+{
+ size_t count;
+ FILE *f;
+
+ f = fropenat(at, name);
+ if (!f)
+ return 0;
+
+ buf[sz - 1] = 0;
+ count = fread(buf, 1, sz, f);
+ buf[count - 1] = 0;
+ fclose(f);
+
+ return count;
+}
+
+static struct clients *scan_clients(struct clients *clients)
+{
+ struct dirent *proc_dent;
+ struct client *c;
+ DIR *proc_dir;
+ int tmp;
+
+ if (!clients)
+ return clients;
+
+ for_each_client(clients, c, tmp) {
+ assert(c->status != PROBE);
+ if (c->status == ALIVE)
+ c->status = PROBE;
+ else
+ break; /* Free block at the end of array. */
+ }
+
+ proc_dir = opendir("/proc");
+ if (!proc_dir)
+ return clients;
+
+ while ((proc_dent = readdir(proc_dir)) != NULL) {
+ DIR *pid_dir = NULL, *fd_dir = NULL, *fdinfo_dir = NULL;
+ struct dirent *fdinfo_dent;
+ char client_name[64] = { };
+ unsigned int client_pid;
+ char buf[4096];
+ size_t count;
+
+ if (proc_dent->d_type != DT_DIR)
+ continue;
+ if (!isdigit(proc_dent->d_name[0]))
+ continue;
+
+ pid_dir = opendirat(proc_dir, proc_dent->d_name);
+ if (!pid_dir)
+ continue;
+
+ count = freadat2buf(buf, sizeof(buf), pid_dir, "stat");
+ if (!count)
+ goto next;
+
+ client_pid = atoi(buf);
+ if (!client_pid)
+ goto next;
+
+ if (!get_task_name(buf, client_name, sizeof(client_name)))
+ goto next;
+
+ fd_dir = opendirat(pid_dir, "fd");
+ if (!fd_dir)
+ goto next;
+
+ fdinfo_dir = opendirat(pid_dir, "fdinfo");
+ if (!fdinfo_dir)
+ goto next;
+
+ while ((fdinfo_dent = readdir(fdinfo_dir)) != NULL) {
+ struct drm_client_fdinfo info = { };
+
+ if (fdinfo_dent->d_type != DT_REG)
+ continue;
+ if (!isdigit(fdinfo_dent->d_name[0]))
+ continue;
+
+ if (!is_drm_fd(fd_dir, fdinfo_dent->d_name))
+ continue;
+
+ if (!__igt_parse_drm_fdinfo(dirfd(fdinfo_dir),
+ fdinfo_dent->d_name,
+ &info))
+ continue;
+
+ if (strcmp(info.driver, "i915"))
+ continue;
+ if (strcmp(info.pdev, clients->pci_slot))
+ continue;
+ if (find_client(clients, ALIVE, info.id))
+ continue; /* Skip duplicate fds. */
+
+ c = find_client(clients, PROBE, info.id);
+ if (!c)
+ add_client(clients, &info, client_pid,
+ client_name);
+ else
+ update_client(c, client_pid, client_name,
+ &info);
+ }
+
+next:
+ if (fdinfo_dir)
+ closedir(fdinfo_dir);
+ if (fd_dir)
+ closedir(fd_dir);
+ if (pid_dir)
+ closedir(pid_dir);
+ }
+
+ closedir(proc_dir);
+
+ for_each_client(clients, c, tmp) {
+ if (c->status == PROBE)
+ free_client(c);
+ else if (c->status == FREE)
+ break;
+ }
+
+ return display_clients(clients);
+}
+
static const char *bars[] = { " ", "▏", "▎", "▍", "▌", "▋", "▊", "▉", "█" };
static void n_spaces(const unsigned int n)
@@ -776,6 +1325,18 @@ json_close_struct(void)
fflush(stdout);
}
+static void
+__json_add_member(const char *key, const char *val)
+{
+ assert(json_indent_level < ARRAY_SIZE(json_indent));
+
+ fprintf(out, "%s%s\"%s\": \"%s\"",
+ json_struct_members ? ",\n" : "",
+ json_indent[json_indent_level], key, val);
+
+ json_struct_members++;
+}
+
static unsigned int
json_add_member(const struct cnt_group *parent, struct cnt_item *item,
unsigned int headers)
@@ -1501,6 +2062,157 @@ print_engines(struct engines *engines, double t, int lines, int w, int h)
return lines;
}
+static int
+print_clients_header(struct clients *clients, int lines,
+ int con_w, int con_h, int *class_w)
+{
+ if (output_mode == INTERACTIVE) {
+ const char *pidname = " PID NAME ";
+ unsigned int num_active = 0;
+ int len = strlen(pidname);
+
+ if (lines++ >= con_h)
+ return lines;
+
+ printf("\033[7m");
+ printf("%s", pidname);
+
+ if (lines++ >= con_h || len >= con_w)
+ return lines;
+
+ if (clients->num_classes) {
+ unsigned int i;
+ int width;
+
+ for (i = 0; i < clients->num_classes; i++) {
+ if (clients->class[i].num_engines)
+ num_active++;
+ }
+
+ *class_w = width = (con_w - len) / num_active;
+
+ for (i = 0; i < clients->num_classes; i++) {
+ const char *name = clients->class[i].name;
+ int name_len = strlen(name);
+ int pad = (width - name_len) / 2;
+ int spaces = width - pad - name_len;
+
+ if (!clients->class[i].num_engines)
+ continue; /* Assert in the ideal world. */
+
+ if (pad < 0 || spaces < 0)
+ continue;
+
+ n_spaces(pad);
+ printf("%s", name);
+ n_spaces(spaces);
+ len += pad + name_len + spaces;
+ }
+ }
+
+ n_spaces(con_w - len);
+ printf("\033[0m\n");
+ } else {
+ if (clients->num_classes)
+ pops->open_struct("clients");
+ }
+
+ return lines;
+}
+
+static bool numeric_clients;
+static bool filter_idle;
+
+static int
+print_client(struct client *c, struct engines *engines, double t, int lines,
+ int con_w, int con_h, unsigned int period_us, int *class_w)
+{
+ struct clients *clients = c->clients;
+ unsigned int i;
+
+ if (output_mode == INTERACTIVE) {
+ if (filter_idle && (!c->total_runtime || c->samples < 2))
+ return lines;
+
+ lines++;
+
+ printf("%6u %17s ", c->pid, c->print_name);
+
+ for (i = 0; c->samples > 1 && i < clients->num_classes; i++) {
+ double pct;
+
+ if (!clients->class[i].num_engines)
+ continue; /* Assert in the ideal world. */
+
+ pct = (double)c->val[i] / period_us / 1e3 * 100 /
+ clients->class[i].num_engines;
+
+ /*
+ * Guard against possible time-drift between sampling
+ * client data and time we obtained our time-delta from
+ * PMU.
+ */
+ if (pct > 100.0)
+ pct = 100.0;
+
+ print_percentage_bar(pct, *class_w, numeric_clients);
+ }
+
+ putchar('\n');
+ } else if (output_mode == JSON) {
+ char buf[64];
+
+ snprintf(buf, sizeof(buf), "%u", c->id);
+ pops->open_struct(buf);
+
+ __json_add_member("name", c->print_name);
+
+ snprintf(buf, sizeof(buf), "%u", c->pid);
+ __json_add_member("pid", buf);
+
+ if (c->samples > 1) {
+ pops->open_struct("engine-classes");
+
+ for (i = 0; i < clients->num_classes; i++) {
+ double pct;
+
+ snprintf(buf, sizeof(buf), "%s",
+ clients->class[i].name);
+ pops->open_struct(buf);
+
+ pct = (double)c->val[i] / period_us / 1e3 * 100;
+ snprintf(buf, sizeof(buf), "%f", pct);
+ __json_add_member("busy", buf);
+
+ __json_add_member("unit", "%");
+
+ pops->close_struct();
+ }
+
+ pops->close_struct();
+ }
+
+ pops->close_struct();
+ }
+
+ return lines;
+}
+
+static int
+print_clients_footer(struct clients *clients, double t,
+ int lines, int con_w, int con_h)
+{
+ if (output_mode == INTERACTIVE) {
+ if (lines++ < con_h)
+ printf("\n");
+ } else {
+ if (clients->num_classes)
+ pops->close_struct();
+ }
+
+ return lines;
+}
+
static void restore_term(void)
{
tcsetattr(STDIN_FILENO, TCSANOW, &termios_orig);
@@ -1565,6 +2277,31 @@ static void interactive_stdin(void)
assert(ret == 0);
}
+static void select_client_sort(void)
+{
+ struct {
+ int (*cmp)(const void *, const void *);
+ const char *msg;
+ } cmp[] = {
+ { client_last_cmp, "Sorting clients by current GPU usage." },
+ { client_total_cmp, "Sorting clients by accummulated GPU usage." },
+ { client_pid_cmp, "Sorting clients by pid." },
+ { client_id_cmp, "Sorting clients by DRM id." },
+ };
+ static unsigned int client_sort;
+
+bump:
+ if (++client_sort >= ARRAY_SIZE(cmp))
+ client_sort = 0;
+
+ client_cmp = cmp[client_sort].cmp;
+ header_msg = cmp[client_sort].msg;
+
+ /* Sort by client id makes no sense with pid aggregation. */
+ if (aggregate_pids && client_cmp == client_id_cmp)
+ goto bump;
+}
+
static bool in_help;
static void process_help_stdin(void)
@@ -1607,9 +2344,29 @@ static void process_normal_stdin(void)
else
header_msg = "Showing physical engines.";
break;
+ case 'i':
+ filter_idle ^= true;
+ if (filter_idle)
+ header_msg = "Hiding inactive clients.";
+ else
+ header_msg = "Showing inactive clients.";
+ break;
+ case 'n':
+ numeric_clients ^= true;
+ break;
+ case 's':
+ select_client_sort();
+ break;
case 'h':
in_help = true;
break;
+ case 'H':
+ aggregate_pids ^= true;
+ if (aggregate_pids)
+ header_msg = "Aggregating clients.";
+ else
+ header_msg = "Showing individual clients.";
+ break;
};
}
}
@@ -1637,6 +2394,10 @@ static void show_help_screen(void)
printf(
"Help for interactive commands:\n\n"
" '1' Toggle between aggregated engine class and physical engine mode.\n"
+" 'n' Toggle display of numeric client busyness overlay.\n"
+" 's' Toggle between sort modes (runtime, total runtime, pid, client id).\n"
+" 'i' Toggle display of clients which used no GPU time.\n"
+" 'H' Toggle between per PID aggregation and individual clients.\n"
"\n"
" 'h' or 'q' Exit interactive help.\n"
"\n");
@@ -1645,6 +2406,7 @@ static void show_help_screen(void)
int main(int argc, char **argv)
{
unsigned int period_us = DEFAULT_PERIOD_MS * 1000;
+ struct clients *clients = NULL;
int con_w = -1, con_h = -1;
char *output_path = NULL;
struct engines *engines;
@@ -1783,15 +2545,24 @@ int main(int argc, char **argv)
ret = EXIT_SUCCESS;
+ clients = init_clients(card.pci_slot_name[0] ?
+ card.pci_slot_name : IGPU_PCI);
init_engine_classes(engines);
+ if (clients) {
+ clients->num_classes = engines->num_classes;
+ clients->class = engines->class;
+ }
pmu_sample(engines);
+ scan_clients(clients);
codename = igt_device_get_pretty_name(&card, false);
while (!stop_top) {
+ struct clients *disp_clients;
bool consumed = false;
+ int j, lines = 0;
struct winsize ws;
- int lines = 0;
+ struct client *c;
double t;
/* Update terminal size. */
@@ -1810,6 +2581,8 @@ int main(int argc, char **argv)
pmu_sample(engines);
t = (double)(engines->ts.cur - engines->ts.prev) / 1e9;
+ disp_clients = scan_clients(clients);
+
if (stop_top)
break;
@@ -1829,12 +2602,41 @@ int main(int argc, char **argv)
lines = print_engines(engines, t, lines, con_w, con_h);
+ if (disp_clients) {
+ int class_w;
+
+ lines = print_clients_header(disp_clients, lines,
+ con_w, con_h,
+ &class_w);
+
+ for_each_client(disp_clients, c, j) {
+ assert(c->status != PROBE);
+ if (c->status != ALIVE)
+ break; /* Active clients are first in the array. */
+
+ if (lines >= con_h)
+ break;
+
+ lines = print_client(c, engines, t,
+ lines, con_w,
+ con_h, period_us,
+ &class_w);
+ }
+
+ lines = print_clients_footer(disp_clients, t,
+ lines, con_w,
+ con_h);
+ }
+
pops->close_struct();
}
if (stop_top)
break;
+ if (disp_clients != clients)
+ free_clients(disp_clients);
+
if (output_mode == INTERACTIVE)
process_stdin(period_us);
else
diff --git a/tools/meson.build b/tools/meson.build
index b6b9753463a9..771d0b9e3d5d 100644
--- a/tools/meson.build
+++ b/tools/meson.build
@@ -91,7 +91,7 @@ install_subdir('registers', install_dir : datadir)
executable('intel_gpu_top', 'intel_gpu_top.c',
install : true,
install_rpath : bindir_rpathdir,
- dependencies : [lib_igt_perf,lib_igt_device_scan,math])
+ dependencies : [lib_igt_perf,lib_igt_device_scan,lib_igt_drm_fdinfo,math])
executable('amd_hdmi_compliance', 'amd_hdmi_compliance.c',
dependencies : [tool_deps],
--
2.32.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for Per client GPU utilisation (rev3)
2022-04-01 14:11 [igt-dev] [PATCH i-g-t 0/3] Per client GPU utilisation Tvrtko Ursulin
` (2 preceding siblings ...)
2022-04-01 14:11 ` [igt-dev] [PATCH i-g-t 3/3] intel-gpu-top: Add support for per client stats Tvrtko Ursulin
@ 2022-04-01 14:56 ` Patchwork
2022-04-01 16:54 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-04-01 14:56 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 11224 bytes --]
== Series Details ==
Series: Per client GPU utilisation (rev3)
URL : https://patchwork.freedesktop.org/series/100571/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11438 -> IGTPW_6859
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/index.html
Participating hosts (42 -> 43)
------------------------------
Additional (6): bat-dg2-8 fi-icl-u2 fi-kbl-guc fi-kbl-8809g fi-pnv-d510 bat-rpls-1
Missing (5): fi-kbl-soraka shard-tglu fi-bsw-cyan bat-jsl-2 fi-bdw-samus
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_6859:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_lmem_swapping@verify-random:
- {bat-rpls-1}: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/bat-rpls-1/igt@gem_lmem_swapping@verify-random.html
Known issues
------------
Here are the changes found in IGTPW_6859 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@fork-gfx0:
- fi-icl-u2: NOTRUN -> [SKIP][2] ([fdo#109315]) +17 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-icl-u2/igt@amdgpu/amd_cs_nop@fork-gfx0.html
* igt@fbdev@nullptr:
- fi-kbl-guc: NOTRUN -> [SKIP][3] ([fdo#109271]) +18 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-kbl-guc/igt@fbdev@nullptr.html
* igt@gem_exec_suspend@basic-s0@smem:
- fi-kbl-8809g: NOTRUN -> [DMESG-WARN][4] ([i915#4962]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-kbl-8809g/igt@gem_exec_suspend@basic-s0@smem.html
* igt@gem_huc_copy@huc-copy:
- fi-pnv-d510: NOTRUN -> [SKIP][5] ([fdo#109271]) +57 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-pnv-d510/igt@gem_huc_copy@huc-copy.html
- fi-kbl-8809g: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#2190])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-kbl-8809g/igt@gem_huc_copy@huc-copy.html
- fi-icl-u2: NOTRUN -> [SKIP][7] ([i915#2190])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-icl-u2/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-guc: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#4613]) +3 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-kbl-guc/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][9] ([i915#4613]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-icl-u2/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_lmem_swapping@random-engines:
- fi-kbl-8809g: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#4613]) +3 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-kbl-8809g/igt@gem_lmem_swapping@random-engines.html
* igt@i915_pm_rpm@basic-rte:
- fi-kbl-8809g: NOTRUN -> [SKIP][11] ([fdo#109271]) +54 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-kbl-8809g/igt@i915_pm_rpm@basic-rte.html
* igt@kms_busy@basic:
- fi-kbl-guc: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#1845])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-kbl-guc/igt@kms_busy@basic.html
* igt@kms_chamelium@hdmi-edid-read:
- fi-kbl-8809g: NOTRUN -> [SKIP][13] ([fdo#109271] / [fdo#111827]) +8 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-kbl-8809g/igt@kms_chamelium@hdmi-edid-read.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][14] ([fdo#111827]) +8 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
- fi-kbl-guc: NOTRUN -> [SKIP][15] ([fdo#109271] / [fdo#111827]) +8 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-kbl-guc/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-icl-u2: NOTRUN -> [SKIP][16] ([fdo#109278]) +2 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-u2: NOTRUN -> [SKIP][17] ([fdo#109285])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-icl-u2/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- fi-pnv-d510: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#5341])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-pnv-d510/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
- fi-kbl-8809g: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#5341])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-kbl-8809g/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
- fi-cfl-8109u: [PASS][20] -> [DMESG-WARN][21] ([i915#295] / [i915#5341])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11438/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-8809g: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#533])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-kbl-8809g/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-cfl-8109u: [PASS][23] -> [DMESG-WARN][24] ([i915#295]) +10 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11438/fi-cfl-8109u/igt@kms_pipe_crc_basic@read-crc-pipe-b.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-cfl-8109u/igt@kms_pipe_crc_basic@read-crc-pipe-b.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-icl-u2: NOTRUN -> [SKIP][25] ([i915#3555])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-icl-u2/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-userptr:
- fi-icl-u2: NOTRUN -> [SKIP][26] ([i915#3301])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-icl-u2/igt@prime_vgem@basic-userptr.html
#### Possible fixes ####
* igt@kms_busy@basic@flip:
- {bat-adlp-6}: [DMESG-WARN][27] ([i915#3576]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11438/bat-adlp-6/igt@kms_busy@basic@flip.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/bat-adlp-6/igt@kms_busy@basic@flip.html
* igt@kms_flip@basic-flip-vs-modeset@a-edp1:
- fi-tgl-u2: [DMESG-WARN][29] ([i915#402]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11438/fi-tgl-u2/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/fi-tgl-u2/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4086]: https://gitlab.freedesktop.org/drm/intel/issues/4086
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4962]: https://gitlab.freedesktop.org/drm/intel/issues/4962
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5193]: https://gitlab.freedesktop.org/drm/intel/issues/5193
[i915#5195]: https://gitlab.freedesktop.org/drm/intel/issues/5195
[i915#5270]: https://gitlab.freedesktop.org/drm/intel/issues/5270
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5275]: https://gitlab.freedesktop.org/drm/intel/issues/5275
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5341]: https://gitlab.freedesktop.org/drm/intel/issues/5341
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5356]: https://gitlab.freedesktop.org/drm/intel/issues/5356
[i915#5482]: https://gitlab.freedesktop.org/drm/intel/issues/5482
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6405 -> IGTPW_6859
CI-20190529: 20190529
CI_DRM_11438: 1b225b6e486f2cc9c8c76f2f95d28179e79a85af @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6859: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/index.html
IGT_6405: 50f7bc405cc1411f57855ed23322c6c4d2510b58 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Testlist changes ==
+igt@drm_fdinfo@all-busy-check-all
+igt@drm_fdinfo@all-busy-idle-check-all
+igt@drm_fdinfo@basics
+igt@drm_fdinfo@busy
+igt@drm_fdinfo@busy-check-all
+igt@drm_fdinfo@busy-hang
+igt@drm_fdinfo@busy-idle
+igt@drm_fdinfo@busy-idle-check-all
+igt@drm_fdinfo@idle
+igt@drm_fdinfo@isolation
+igt@drm_fdinfo@most-busy-check-all
+igt@drm_fdinfo@most-busy-idle-check-all
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/index.html
[-- Attachment #2: Type: text/html, Size: 12078 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 1/3] lib: Helper library for parsing i915 fdinfo output
2022-04-01 14:11 ` [igt-dev] [PATCH i-g-t 1/3] lib: Helper library for parsing i915 fdinfo output Tvrtko Ursulin
@ 2022-04-01 15:14 ` Umesh Nerlige Ramappa
0 siblings, 0 replies; 8+ messages in thread
From: Umesh Nerlige Ramappa @ 2022-04-01 15:14 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev, Intel-gfx, dri-devel
lgtm, thanks for clarifications on the other patch.
Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Umesh
On Fri, Apr 01, 2022 at 03:11:53PM +0100, Tvrtko Ursulin wrote:
>From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
>Tests and intel_gpu_top will share common code for parsing this file.
>
>v2:
> * Fix key-value parsing if valid key line ends with ':'.
> * Return number of drm keys found.
> * Add DRM_CLIENT_FDINFO_MAX_ENGINES. (Umesh)
> * Always zero terminate read buffer. (Umesh)
>
>Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>---
> lib/igt_drm_fdinfo.c | 188 +++++++++++++++++++++++++++++++++++++++++++
> lib/igt_drm_fdinfo.h | 69 ++++++++++++++++
> lib/meson.build | 7 ++
> 3 files changed, 264 insertions(+)
> create mode 100644 lib/igt_drm_fdinfo.c
> create mode 100644 lib/igt_drm_fdinfo.h
>
>diff --git a/lib/igt_drm_fdinfo.c b/lib/igt_drm_fdinfo.c
>new file mode 100644
>index 000000000000..b422f67a4ace
>--- /dev/null
>+++ b/lib/igt_drm_fdinfo.c
>@@ -0,0 +1,188 @@
>+/*
>+ * Copyright © 2022 Intel Corporation
>+ *
>+ * Permission is hereby granted, free of charge, to any person obtaining a
>+ * copy of this software and associated documentation files (the "Software"),
>+ * to deal in the Software without restriction, including without limitation
>+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
>+ * and/or sell copies of the Software, and to permit persons to whom the
>+ * Software is furnished to do so, subject to the following conditions:
>+ *
>+ * The above copyright notice and this permission notice (including the next
>+ * paragraph) shall be included in all copies or substantial portions of the
>+ * Software.
>+ *
>+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
>+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
>+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
>+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
>+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
>+ * IN THE SOFTWARE.
>+ *
>+ */
>+
>+#include <ctype.h>
>+#include <sys/types.h>
>+#include <sys/stat.h>
>+#include <fcntl.h>
>+#include <stdio.h>
>+#include <string.h>
>+#include <stdlib.h>
>+#include <unistd.h>
>+
>+#include "drmtest.h"
>+
>+#include "igt_drm_fdinfo.h"
>+
>+static size_t read_fdinfo(char *buf, const size_t sz, int at, const char *name)
>+{
>+ size_t count;
>+ int fd;
>+
>+ fd = openat(at, name, O_RDONLY);
>+ if (fd < 0)
>+ return 0;
>+
>+ buf[sz - 1] = 0;
>+ count = read(fd, buf, sz);
>+ buf[sz - 1] = 0;
>+ close(fd);
>+
>+ return count;
>+}
>+
>+static int parse_engine(char *line, struct drm_client_fdinfo *info,
>+ size_t prefix_len, uint64_t *val)
>+{
>+ static const char *e2class[] = {
>+ "render",
>+ "copy",
>+ "video",
>+ "video-enhance",
>+ };
>+ ssize_t name_len;
>+ char *name, *p;
>+ int found = -1;
>+ unsigned int i;
>+
>+ p = index(line, ':');
>+ if (!p || p == line)
>+ return -1;
>+
>+ name_len = p - line - prefix_len;
>+ if (name_len < 1)
>+ return -1;
>+
>+ name = line + prefix_len;
>+
>+ for (i = 0; i < ARRAY_SIZE(e2class); i++) {
>+ if (!strncmp(name, e2class[i], name_len)) {
>+ found = i;
>+ break;
>+ }
>+ }
>+
>+ if (found >= 0) {
>+ while (*++p && isspace(*p));
>+ *val = strtoull(p, NULL, 10);
>+ }
>+
>+ return found;
>+}
>+
>+static const char *find_kv(const char *buf, const char *key, size_t keylen)
>+{
>+ const char *p = buf;
>+
>+ if (strncmp(buf, key, keylen))
>+ return NULL;
>+
>+ p = index(buf, ':');
>+ if (!p || p == buf)
>+ return NULL;
>+ if ((p - buf) != keylen)
>+ return NULL;
>+
>+ p++;
>+ while (*p && isspace(*p))
>+ p++;
>+
>+ return *p ? p : NULL;
>+}
>+
>+unsigned int
>+__igt_parse_drm_fdinfo(int dir, const char *fd, struct drm_client_fdinfo *info)
>+{
>+ char buf[4096], *_buf = buf;
>+ char *l, *ctx = NULL;
>+ unsigned int good = 0, num_capacity = 0;
>+ size_t count;
>+
>+ count = read_fdinfo(buf, sizeof(buf), dir, fd);
>+ if (!count)
>+ return 0;
>+
>+ while ((l = strtok_r(_buf, "\n", &ctx))) {
>+ uint64_t val = 0;
>+ const char *v;
>+ int idx;
>+
>+ _buf = NULL;
>+
>+ if ((v = find_kv(l, "drm-driver", strlen("drm-driver")))) {
>+ strncpy(info->driver, v, sizeof(info->driver) - 1);
>+ good++;
>+ } else if ((v = find_kv(l, "drm-pdev", strlen("drm-pdev")))) {
>+ strncpy(info->pdev, v, sizeof(info->pdev) - 1);
>+ } else if ((v = find_kv(l, "drm-client-id",
>+ strlen("drm-client-id")))) {
>+ info->id = atol(v);
>+ good++;
>+ } else if (!strncmp(l, "drm-engine-", 11) &&
>+ strncmp(l, "drm-engine-capacity-", 20)) {
>+ idx = parse_engine(l, info, strlen("drm-engine-"),
>+ &val);
>+ if (idx >= 0) {
>+ if (!info->capacity[idx])
>+ info->capacity[idx] = 1;
>+ info->busy[idx] = val;
>+ info->num_engines++;
>+ }
>+ } else if (!strncmp(l, "drm-engine-capacity-", 20)) {
>+ idx = parse_engine(l, info,
>+ strlen("drm-engine-capacity-"),
>+ &val);
>+ if (idx >= 0) {
>+ info->capacity[idx] = val;
>+ num_capacity++;
>+ }
>+ }
>+ }
>+
>+ if (good < 2 || !info->num_engines)
>+ return 0; /* fdinfo format not as expected */
>+
>+ return good + info->num_engines + num_capacity;
>+}
>+
>+unsigned int igt_parse_drm_fdinfo(int drm_fd, struct drm_client_fdinfo *info)
>+{
>+ unsigned int res;
>+ char fd[64];
>+ int dir, ret;
>+
>+ ret = snprintf(fd, sizeof(fd), "%u", drm_fd);
>+ if (ret < 0 || ret == sizeof(fd))
>+ return false;
>+
>+ dir = open("/proc/self/fdinfo", O_DIRECTORY | O_RDONLY);
>+ if (dir < 0)
>+ return false;
>+
>+ res = __igt_parse_drm_fdinfo(dir, fd, info);
>+
>+ close(dir);
>+
>+ return res;
>+}
>diff --git a/lib/igt_drm_fdinfo.h b/lib/igt_drm_fdinfo.h
>new file mode 100644
>index 000000000000..5db63e28b07e
>--- /dev/null
>+++ b/lib/igt_drm_fdinfo.h
>@@ -0,0 +1,69 @@
>+/*
>+ * Copyright © 2022 Intel Corporation
>+ *
>+ * Permission is hereby granted, free of charge, to any person obtaining a
>+ * copy of this software and associated documentation files (the "Software"),
>+ * to deal in the Software without restriction, including without limitation
>+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
>+ * and/or sell copies of the Software, and to permit persons to whom the
>+ * Software is furnished to do so, subject to the following conditions:
>+ *
>+ * The above copyright notice and this permission notice (including the next
>+ * paragraph) shall be included in all copies or substantial portions of the
>+ * Software.
>+ *
>+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
>+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
>+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
>+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
>+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
>+ * IN THE SOFTWARE.
>+ *
>+ */
>+
>+#ifndef IGT_DRM_FDINFO_H
>+#define IGT_DRM_FDINFO_H
>+
>+#include <sys/types.h>
>+#include <dirent.h>
>+#include <stdint.h>
>+#include <stdbool.h>
>+
>+#define DRM_CLIENT_FDINFO_MAX_ENGINES 16
>+
>+struct drm_client_fdinfo {
>+ char driver[128];
>+ char pdev[128];
>+ unsigned long id;
>+
>+ unsigned int num_engines;
>+ unsigned int capacity[DRM_CLIENT_FDINFO_MAX_ENGINES];
>+ uint64_t busy[DRM_CLIENT_FDINFO_MAX_ENGINES];
>+};
>+
>+/**
>+ * igt_parse_drm_fdinfo: Parses the drm fdinfo file
>+ *
>+ * @drm_fd: DRM file descriptor
>+ * @info: Structure to populate with read data
>+ *
>+ * Returns the number of valid drm fdinfo keys found or zero if not all
>+ * mandatory keys were present or no engines found.
>+ */
>+unsigned int igt_parse_drm_fdinfo(int drm_fd, struct drm_client_fdinfo *info);
>+
>+/**
>+ * __igt_parse_drm_fdinfo: Parses the drm fdinfo file
>+ *
>+ * @dir: File descriptor pointing to /proc/pid/fdinfo directory
>+ * @fd: String representation of the file descriptor number to parse.
>+ * @info: Structure to populate with read data
>+ *
>+ * Returns the number of valid drm fdinfo keys found or zero if not all
>+ * mandatory keys were present or no engines found.
>+ */
>+unsigned int __igt_parse_drm_fdinfo(int dir, const char *fd,
>+ struct drm_client_fdinfo *info);
>+
>+#endif /* IGT_DRM_FDINFO_H */
>diff --git a/lib/meson.build b/lib/meson.build
>index 6fc1958604b3..ccee7a596561 100644
>--- a/lib/meson.build
>+++ b/lib/meson.build
>@@ -18,6 +18,7 @@ lib_sources = [
> 'igt_debugfs.c',
> 'igt_device.c',
> 'igt_device_scan.c',
>+ 'igt_drm_fdinfo.c',
> 'igt_aux.c',
> 'igt_gt.c',
> 'igt_halffloat.c',
>@@ -218,6 +219,12 @@ lib_igt_device_scan_build = static_library('igt_device_scan',
> lib_igt_device_scan = declare_dependency(link_with : lib_igt_device_scan_build,
> include_directories : inc)
>
>+lib_igt_drm_fdinfo_build = static_library('igt_drm_fdinfo',
>+ ['igt_drm_fdinfo.c'],
>+ include_directories : inc)
>+
>+lib_igt_drm_fdinfo = declare_dependency(link_with : lib_igt_drm_fdinfo_build,
>+ include_directories : inc)
> i915_perf_files = [
> 'igt_list.c',
> 'i915/perf.c',
>--
>2.32.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for Per client GPU utilisation (rev3)
2022-04-01 14:11 [igt-dev] [PATCH i-g-t 0/3] Per client GPU utilisation Tvrtko Ursulin
` (3 preceding siblings ...)
2022-04-01 14:56 ` [igt-dev] ✓ Fi.CI.BAT: success for Per client GPU utilisation (rev3) Patchwork
@ 2022-04-01 16:54 ` Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-04-01 16:54 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 30252 bytes --]
== Series Details ==
Series: Per client GPU utilisation (rev3)
URL : https://patchwork.freedesktop.org/series/100571/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11438_full -> IGTPW_6859_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/index.html
Participating hosts (11 -> 7)
------------------------------
Missing (4): pig-skl-6260u shard-skl pig-kbl-iris pig-glk-j5005
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_6859_full:
### IGT changes ###
#### Possible regressions ####
* {igt@drm_fdinfo@basics} (NEW):
- shard-tglb: NOTRUN -> [SKIP][1] +10 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb3/igt@drm_fdinfo@basics.html
* {igt@drm_fdinfo@busy-idle} (NEW):
- shard-iclb: NOTRUN -> [SKIP][2] +10 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb2/igt@drm_fdinfo@busy-idle.html
* {igt@drm_fdinfo@most-busy-check-all} (NEW):
- {shard-tglu}: NOTRUN -> [SKIP][3] +6 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglu-3/igt@drm_fdinfo@most-busy-check-all.html
New tests
---------
New tests have been introduced between CI_DRM_11438_full and IGTPW_6859_full:
### New IGT tests (12) ###
* igt@drm_fdinfo@all-busy-check-all:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@all-busy-idle-check-all:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@basics:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-check-all:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-hang:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-idle:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@busy-idle-check-all:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@idle:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@isolation:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@most-busy-check-all:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@drm_fdinfo@most-busy-idle-check-all:
- Statuses :
- Exec time: [None] s
Known issues
------------
Here are the changes found in IGTPW_6859_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@unbind-rebind:
- shard-snb: [PASS][4] -> [DMESG-WARN][5] ([i915#4528])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11438/shard-snb7/igt@core_hotunplug@unbind-rebind.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-snb4/igt@core_hotunplug@unbind-rebind.html
* igt@feature_discovery@display-3x:
- shard-tglb: NOTRUN -> [SKIP][6] ([i915#1839])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb3/igt@feature_discovery@display-3x.html
* igt@gem_ccs@block-copy-uncompressed:
- shard-iclb: NOTRUN -> [SKIP][7] ([i915#5327]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb1/igt@gem_ccs@block-copy-uncompressed.html
* igt@gem_ctx_persistence@legacy-engines-hostile-preempt:
- shard-snb: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#1099]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-snb7/igt@gem_ctx_persistence@legacy-engines-hostile-preempt.html
* igt@gem_ctx_sseu@mmap-args:
- shard-tglb: NOTRUN -> [SKIP][9] ([i915#280]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb5/igt@gem_ctx_sseu@mmap-args.html
* igt@gem_eio@kms:
- shard-tglb: [PASS][10] -> [FAIL][11] ([i915#232])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11438/shard-tglb6/igt@gem_eio@kms.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb2/igt@gem_eio@kms.html
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: NOTRUN -> [SKIP][12] ([i915#4525])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb3/igt@gem_exec_balancer@parallel-bb-first.html
* igt@gem_exec_balancer@parallel-contexts:
- shard-tglb: NOTRUN -> [DMESG-WARN][13] ([i915#5076]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb2/igt@gem_exec_balancer@parallel-contexts.html
- shard-kbl: NOTRUN -> [DMESG-WARN][14] ([i915#5076])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-kbl7/igt@gem_exec_balancer@parallel-contexts.html
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: NOTRUN -> [FAIL][15] ([i915#2846])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-kbl6/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: NOTRUN -> [FAIL][16] ([i915#2842]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb1/igt@gem_exec_fair@basic-none-rrul@rcs0.html
- shard-glk: NOTRUN -> [FAIL][17] ([i915#2842])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-glk6/igt@gem_exec_fair@basic-none-rrul@rcs0.html
- shard-tglb: NOTRUN -> [FAIL][18] ([i915#2842]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb3/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: [PASS][19] -> [FAIL][20] ([i915#2842])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11438/shard-glk3/igt@gem_exec_fair@basic-pace@rcs0.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-glk5/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][21] -> [FAIL][22] ([i915#2842]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11438/shard-kbl4/igt@gem_exec_fair@basic-pace@vecs0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-kbl1/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-iclb: NOTRUN -> [SKIP][23] ([fdo#109313])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb3/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
* igt@gem_lmem_swapping@parallel-multi:
- shard-kbl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#4613]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-kbl4/igt@gem_lmem_swapping@parallel-multi.html
* igt@gem_lmem_swapping@random-engines:
- shard-iclb: NOTRUN -> [SKIP][25] ([i915#4613]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb4/igt@gem_lmem_swapping@random-engines.html
- shard-tglb: NOTRUN -> [SKIP][26] ([i915#4613]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb7/igt@gem_lmem_swapping@random-engines.html
* igt@gem_pread@exhaustion:
- shard-tglb: NOTRUN -> [WARN][27] ([i915#2658])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb3/igt@gem_pread@exhaustion.html
- shard-glk: NOTRUN -> [WARN][28] ([i915#2658])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-glk6/igt@gem_pread@exhaustion.html
- shard-apl: NOTRUN -> [WARN][29] ([i915#2658])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-apl8/igt@gem_pread@exhaustion.html
- shard-iclb: NOTRUN -> [WARN][30] ([i915#2658])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb1/igt@gem_pread@exhaustion.html
- shard-snb: NOTRUN -> [WARN][31] ([i915#2658])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-snb4/igt@gem_pread@exhaustion.html
- shard-kbl: NOTRUN -> [WARN][32] ([i915#2658])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-kbl3/igt@gem_pread@exhaustion.html
* igt@gem_pxp@create-protected-buffer:
- shard-iclb: NOTRUN -> [SKIP][33] ([i915#4270]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb1/igt@gem_pxp@create-protected-buffer.html
* igt@gem_pxp@protected-encrypted-src-copy-not-readible:
- shard-tglb: NOTRUN -> [SKIP][34] ([i915#4270]) +2 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb1/igt@gem_pxp@protected-encrypted-src-copy-not-readible.html
* igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][35] ([i915#768]) +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb5/igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-yf-tiled.html
* igt@gem_userptr_blits@unsync-unmap:
- shard-iclb: NOTRUN -> [SKIP][36] ([i915#3297]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb7/igt@gem_userptr_blits@unsync-unmap.html
* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-tglb: NOTRUN -> [SKIP][37] ([i915#3297]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb2/igt@gem_userptr_blits@unsync-unmap-cycles.html
* igt@gen3_render_mixed_blits:
- shard-tglb: NOTRUN -> [SKIP][38] ([fdo#109289]) +3 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb6/igt@gen3_render_mixed_blits.html
* igt@gen7_exec_parse@basic-offset:
- shard-apl: NOTRUN -> [SKIP][39] ([fdo#109271]) +112 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-apl3/igt@gen7_exec_parse@basic-offset.html
* igt@gen9_exec_parse@bb-start-param:
- shard-tglb: NOTRUN -> [SKIP][40] ([i915#2527] / [i915#2856]) +2 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb6/igt@gen9_exec_parse@bb-start-param.html
* igt@gen9_exec_parse@valid-registers:
- shard-iclb: NOTRUN -> [SKIP][41] ([i915#2856]) +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb1/igt@gen9_exec_parse@valid-registers.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-tglb: NOTRUN -> [SKIP][42] ([i915#1904])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb5/igt@i915_pm_dc@dc3co-vpb-simulation.html
- shard-iclb: NOTRUN -> [SKIP][43] ([i915#588])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][44] -> [FAIL][45] ([i915#454])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11438/shard-iclb7/igt@i915_pm_dc@dc6-psr.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb3/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-apl: NOTRUN -> [SKIP][46] ([fdo#109271] / [i915#1937])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-apl8/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- shard-glk: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#1937])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-glk9/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
* igt@i915_pm_rpm@pc8-residency:
- shard-iclb: NOTRUN -> [SKIP][48] ([fdo#109293] / [fdo#109506])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb7/igt@i915_pm_rpm@pc8-residency.html
- shard-tglb: NOTRUN -> [SKIP][49] ([fdo#109506] / [i915#2411])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb7/igt@i915_pm_rpm@pc8-residency.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [PASS][50] -> [INCOMPLETE][51] ([i915#3921])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11438/shard-snb7/igt@i915_selftest@live@hangcheck.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-snb4/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@forcewake:
- shard-kbl: [PASS][52] -> [DMESG-WARN][53] ([i915#180]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11438/shard-kbl1/igt@i915_suspend@forcewake.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-kbl7/igt@i915_suspend@forcewake.html
* igt@kms_atomic@atomic_plane_damage:
- shard-iclb: NOTRUN -> [SKIP][54] ([i915#4765])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb4/igt@kms_atomic@atomic_plane_damage.html
* igt@kms_atomic@plane-primary-overlay-mutable-zpos:
- shard-tglb: NOTRUN -> [SKIP][55] ([i915#404])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb1/igt@kms_atomic@plane-primary-overlay-mutable-zpos.html
* igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
- shard-tglb: NOTRUN -> [SKIP][56] ([i915#1769])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb5/igt@kms_atomic_transition@plane-all-modeset-transition-fencing.html
* igt@kms_big_fb@4-tiled-8bpp-rotate-90:
- shard-kbl: NOTRUN -> [SKIP][57] ([fdo#109271]) +220 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-kbl6/igt@kms_big_fb@4-tiled-8bpp-rotate-90.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0:
- shard-tglb: NOTRUN -> [SKIP][58] ([i915#5286]) +4 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb2/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-iclb: NOTRUN -> [SKIP][59] ([i915#5286]) +3 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb4/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_big_fb@linear-16bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][60] ([fdo#110725] / [fdo#111614])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb5/igt@kms_big_fb@linear-16bpp-rotate-90.html
* igt@kms_big_fb@linear-32bpp-rotate-180:
- shard-glk: [PASS][61] -> [DMESG-WARN][62] ([i915#118]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11438/shard-glk1/igt@kms_big_fb@linear-32bpp-rotate-180.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-glk5/igt@kms_big_fb@linear-32bpp-rotate-180.html
* igt@kms_big_fb@x-tiled-16bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][63] ([fdo#111614]) +2 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb2/igt@kms_big_fb@x-tiled-16bpp-rotate-270.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-kbl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#3777]) +2 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-kbl4/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-iclb: NOTRUN -> [SKIP][65] ([fdo#110723])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb7/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_big_joiner@invalid-modeset:
- shard-iclb: NOTRUN -> [SKIP][66] ([i915#2705])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb4/igt@kms_big_joiner@invalid-modeset.html
- shard-tglb: NOTRUN -> [SKIP][67] ([i915#2705])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb7/igt@kms_big_joiner@invalid-modeset.html
* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][68] ([fdo#109278] / [i915#3886]) +7 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb3/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][69] ([i915#3689]) +6 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb2/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_ccs.html
* igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][70] ([i915#3689] / [i915#3886]) +3 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb7/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#3886]) +3 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-glk2/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
- shard-apl: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#3886]) +5 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-apl3/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#3886]) +10 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-kbl7/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-missing-ccs-buffer-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][74] ([fdo#111615] / [i915#3689]) +5 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb5/igt@kms_ccs@pipe-d-missing-ccs-buffer-yf_tiled_ccs.html
* igt@kms_chamelium@hdmi-audio:
- shard-iclb: NOTRUN -> [SKIP][75] ([fdo#109284] / [fdo#111827]) +9 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb6/igt@kms_chamelium@hdmi-audio.html
* igt@kms_chamelium@hdmi-hpd-fast:
- shard-snb: NOTRUN -> [SKIP][76] ([fdo#109271] / [fdo#111827]) +4 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-snb7/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_chamelium@hdmi-hpd-storm:
- shard-kbl: NOTRUN -> [SKIP][77] ([fdo#109271] / [fdo#111827]) +15 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-kbl4/igt@kms_chamelium@hdmi-hpd-storm.html
* igt@kms_color@pipe-d-ctm-0-25:
- shard-iclb: NOTRUN -> [SKIP][78] ([fdo#109278] / [i915#1149]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb4/igt@kms_color@pipe-d-ctm-0-25.html
* igt@kms_color_chamelium@pipe-b-ctm-0-5:
- shard-tglb: NOTRUN -> [SKIP][79] ([fdo#109284] / [fdo#111827]) +11 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb1/igt@kms_color_chamelium@pipe-b-ctm-0-5.html
* igt@kms_color_chamelium@pipe-b-ctm-red-to-blue:
- shard-apl: NOTRUN -> [SKIP][80] ([fdo#109271] / [fdo#111827]) +6 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-apl6/igt@kms_color_chamelium@pipe-b-ctm-red-to-blue.html
- shard-glk: NOTRUN -> [SKIP][81] ([fdo#109271] / [fdo#111827]) +4 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-glk7/igt@kms_color_chamelium@pipe-b-ctm-red-to-blue.html
* igt@kms_color_chamelium@pipe-d-ctm-0-5:
- shard-iclb: NOTRUN -> [SKIP][82] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb4/igt@kms_color_chamelium@pipe-d-ctm-0-5.html
* igt@kms_content_protection@atomic:
- shard-kbl: NOTRUN -> [TIMEOUT][83] ([i915#1319]) +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-kbl3/igt@kms_content_protection@atomic.html
- shard-iclb: NOTRUN -> [SKIP][84] ([fdo#109300] / [fdo#111066]) +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb1/igt@kms_content_protection@atomic.html
* igt@kms_content_protection@dp-mst-lic-type-0:
- shard-tglb: NOTRUN -> [SKIP][85] ([i915#3116] / [i915#3299])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb6/igt@kms_content_protection@dp-mst-lic-type-0.html
* igt@kms_content_protection@srm:
- shard-glk: NOTRUN -> [SKIP][86] ([fdo#109271]) +72 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-glk2/igt@kms_content_protection@srm.html
- shard-tglb: NOTRUN -> [SKIP][87] ([i915#1063]) +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb2/igt@kms_content_protection@srm.html
- shard-apl: NOTRUN -> [TIMEOUT][88] ([i915#1319])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-apl1/igt@kms_content_protection@srm.html
* igt@kms_cursor_crc@pipe-a-cursor-512x512-sliding:
- shard-iclb: NOTRUN -> [SKIP][89] ([fdo#109278] / [fdo#109279]) +2 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb2/igt@kms_cursor_crc@pipe-a-cursor-512x512-sliding.html
* igt@kms_cursor_crc@pipe-b-cursor-32x10-random:
- shard-tglb: NOTRUN -> [SKIP][90] ([i915#3359]) +4 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb7/igt@kms_cursor_crc@pipe-b-cursor-32x10-random.html
* igt@kms_cursor_crc@pipe-b-cursor-32x32-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][91] ([i915#3319]) +3 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb1/igt@kms_cursor_crc@pipe-b-cursor-32x32-rapid-movement.html
* igt@kms_cursor_crc@pipe-c-cursor-32x10-offscreen:
- shard-iclb: NOTRUN -> [SKIP][92] ([fdo#109278]) +29 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb7/igt@kms_cursor_crc@pipe-c-cursor-32x10-offscreen.html
* igt@kms_cursor_crc@pipe-d-cursor-128x42-offscreen:
- shard-snb: NOTRUN -> [SKIP][93] ([fdo#109271]) +127 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-snb5/igt@kms_cursor_crc@pipe-d-cursor-128x42-offscreen.html
* igt@kms_cursor_crc@pipe-d-cursor-512x512-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][94] ([fdo#109279] / [i915#3359]) +3 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb6/igt@kms_cursor_crc@pipe-d-cursor-512x512-rapid-movement.html
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-iclb: NOTRUN -> [SKIP][95] ([fdo#109274] / [fdo#109278]) +3 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb6/igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-snb: [PASS][96] -> [SKIP][97] ([fdo#109271])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11438/shard-snb4/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-snb4/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-apl: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#533])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-apl1/igt@kms_cursor_legacy@pipe-d-torture-bo.html
- shard-glk: NOTRUN -> [SKIP][99] ([fdo#109271] / [i915#533])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-glk8/igt@kms_cursor_legacy@pipe-d-torture-bo.html
* igt@kms_display_modes@extended-mode-basic:
- shard-tglb: NOTRUN -> [SKIP][100] ([fdo#109274])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb1/igt@kms_display_modes@extended-mode-basic.html
* igt@kms_dp_tiled_display@basic-test-pattern:
- shard-iclb: NOTRUN -> [SKIP][101] ([i915#426])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb1/igt@kms_dp_tiled_display@basic-test-pattern.html
- shard-tglb: NOTRUN -> [SKIP][102] ([i915#426])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb3/igt@kms_dp_tiled_display@basic-test-pattern.html
* igt@kms_draw_crc@draw-method-rgb565-pwrite-4tiled:
- shard-tglb: NOTRUN -> [SKIP][103] ([i915#5287])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb5/igt@kms_draw_crc@draw-method-rgb565-pwrite-4tiled.html
* igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-4tiled:
- shard-iclb: NOTRUN -> [SKIP][104] ([i915#5287]) +1 similar issue
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb6/igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-4tiled.html
* igt@kms_dsc@basic-dsc-enable:
- shard-iclb: NOTRUN -> [SKIP][105] ([i915#3840])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb3/igt@kms_dsc@basic-dsc-enable.html
* igt@kms_flip@2x-blocking-absolute-wf_vblank-interruptible:
- shard-tglb: NOTRUN -> [SKIP][106] ([fdo#109274] / [fdo#111825]) +10 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb3/igt@kms_flip@2x-blocking-absolute-wf_vblank-interruptible.html
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
- shard-iclb: NOTRUN -> [SKIP][107] ([fdo#109274]) +3 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb7/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [PASS][108] -> [DMESG-WARN][109] ([i915#180]) +4 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11438/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: NOTRUN -> [DMESG-WARN][110] ([i915#180]) +2 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-kbl7/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling:
- shard-tglb: NOTRUN -> [SKIP][111] ([i915#2587])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb7/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-blt:
- shard-iclb: NOTRUN -> [SKIP][112] ([fdo#109280]) +25 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-plflip-blt:
- shard-tglb: NOTRUN -> [SKIP][113] ([fdo#109280] / [fdo#111825]) +34 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-tiling-4:
- shard-iclb: NOTRUN -> [SKIP][114] ([i915#5438])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-tiling-4.html
* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [PASS][115] -> [SKIP][116] ([i915#433])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11438/shard-tglb3/igt@kms_hdmi_inject@inject-audio.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb5/igt@kms_hdmi_inject@inject-audio.html
* igt@kms_invalid_mode@clock-too-high:
- shard-tglb: NOTRUN -> [SKIP][117] ([i915#4278])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb7/igt@kms_invalid_mode@clock-too-high.html
- shard-iclb: NOTRUN -> [SKIP][118] ([i915#4278])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb4/igt@kms_invalid_mode@clock-too-high.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-kbl: NOTRUN -> [FAIL][119] ([fdo#108145] / [i915#265])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-kbl7/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html
- shard-glk: NOTRUN -> [FAIL][120] ([fdo#108145] / [i915#265])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-glk4/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html
- shard-apl: NOTRUN -> [FAIL][121] ([fdo#108145] / [i915#265])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-apl1/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html
* igt@kms_plane_lowres@pipe-b-tiling-none:
- shard-iclb: NOTRUN -> [SKIP][122] ([i915#3536]) +1 similar issue
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-iclb4/igt@kms_plane_lowres@pipe-b-tiling-none.html
* igt@kms_plane_lowres@pipe-c-tiling-x:
- shard-tglb: NOTRUN -> [SKIP][123] ([i915#3536]) +1 similar issue
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb6/igt@kms_plane_lowres@pipe-c-tiling-x.html
* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][124] ([fdo#111615]) +7 similar issues
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb1/igt@kms_plane_multiple@atomic-pipe-b-tiling-yf.html
* igt@kms_plane_multiple@atomic-pipe-c-tiling-4:
- shard-tglb: NOTRUN -> [SKIP][125] ([i915#5288]) +1 similar issue
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/shard-tglb2/igt@kms_plane_multiple@atomic-pipe-c-tiling-4.html
* igt@kms_plane_scaling@downscale-with-pixel-format-fact
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6859/index.html
[-- Attachment #2: Type: text/html, Size: 34227 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-04-01 16:54 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-01 14:11 [igt-dev] [PATCH i-g-t 0/3] Per client GPU utilisation Tvrtko Ursulin
2022-04-01 14:11 ` [igt-dev] [PATCH i-g-t 1/3] lib: Helper library for parsing i915 fdinfo output Tvrtko Ursulin
2022-04-01 15:14 ` [igt-dev] [Intel-gfx] " Umesh Nerlige Ramappa
2022-04-01 14:11 ` [igt-dev] [PATCH i-g-t 2/3] tests/i915/drm_fdinfo: Basic and functional tests for GPU busyness exported via fdinfo Tvrtko Ursulin
2022-04-01 14:11 ` [igt-dev] [PATCH i-g-t 3/3] intel-gpu-top: Add support for per client stats Tvrtko Ursulin
2022-04-01 14:56 ` [igt-dev] ✓ Fi.CI.BAT: success for Per client GPU utilisation (rev3) Patchwork
2022-04-01 16:54 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2022-01-06 16:49 [igt-dev] [PATCH i-g-t 0/3] Tests and intel_gpu_top with fdinfo support Tvrtko Ursulin
2022-01-06 16:49 ` [igt-dev] [PATCH i-g-t 3/3] intel-gpu-top: Add support for per client stats Tvrtko Ursulin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox