From: Mohammed Thasleem <mohammed.thasleem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/intel/kms_pm_dc: Fix dc9-dpms test on LNL
Date: Fri, 22 Apr 2022 05:52:30 +0530 [thread overview]
Message-ID: <20220422002230.19535-1-mohammed.thasleem@intel.com> (raw)
DC5 counter on disp ver >=14 is not expected to get reset in DC9 state.
Add condition to check runtime_suspended_time value to validate
DC9 dpms test.
Signed-off-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
---
lib/intel_chipset.h | 1 +
tests/intel/kms_pm_dc.c | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h
index bd79a2cab..f413f840a 100644
--- a/lib/intel_chipset.h
+++ b/lib/intel_chipset.h
@@ -212,6 +212,7 @@ void intel_check_pch(void);
#define IS_GEN(devid, x) (intel_get_device_info(devid)->graphics_ver == x)
#define AT_LEAST_GEN(devid, x) (intel_get_device_info(devid)->graphics_ver >= x)
+#define AT_LEAST_DISPLAY(devid, x) (intel_get_device_info(devid)->display_ver >= x)
#define IS_GEN2(devid) IS_GEN(devid, 2)
#define IS_GEN3(devid) IS_GEN(devid, 3)
diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c
index 87fdbab01..33c2af95b 100644
--- a/tests/intel/kms_pm_dc.c
+++ b/tests/intel/kms_pm_dc.c
@@ -114,7 +114,7 @@
#define KMS_HELPER "/sys/module/drm_kms_helper/parameters/"
#define PACKAGE_CSTATE_PATH "pmc_core/package_cstate_show"
#define KMS_POLL_DISABLE 0
-#define DC9_RESETS_DC_COUNTERS(devid) (!(IS_DG1(devid) || IS_DG2(devid) || IS_METEORLAKE(devid)))
+#define DC9_RESETS_DC_COUNTERS(devid) (!(IS_DG1(devid) || IS_DG2(devid) || AT_LEAST_DISPLAY(devid, 14)))
#define DRM_MODE_FMT "\"%s\": %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x"
#define DRM_MODE_ARG(m) \
(m)->name, (m)->vrefresh, (m)->clock, \
@@ -608,7 +608,7 @@ static bool dc9_wait_entry(data_t *data, int dc_target, int prev_dc, int prev_rp
* Runtime suspended residency should increment once DC9 is achieved;
* this condition is valid for all platforms.
* However, resetting of dc5/dc6 counter to check if display engine was in DC9;
- * this condition at present can be skipped for dg1, dg2 and MTL platforms.
+ * this condition at present can be skipped for dg1, dg2 and MTL+ platforms.
*/
return igt_wait((read_runtime_suspended_time(data->drm_fd) > prev_rpm) &&
(!DC9_RESETS_DC_COUNTERS(data->devid) ||
--
2.25.1
next reply other threads:[~2023-11-23 17:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 0:22 Mohammed Thasleem [this message]
2023-11-23 18:48 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/intel/kms_pm_dc: Fix dc9-dpms test on LNL Patchwork
2023-11-24 8:27 ` [igt-dev] [PATCH i-g-t] " Mohammed Thasleem
2023-11-24 13:32 ` Sharma, Swati2
2023-11-29 10:19 ` [igt-dev] [PATCH i-g-t] tests/intel/kms_pm_dc: Add LNL platform for dc9-dpms validation Mohammed Thasleem
2023-11-30 13:37 ` Kamil Konieczny
2023-11-24 10:32 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/intel/kms_pm_dc: Fix dc9-dpms test on LNL (rev2) Patchwork
2023-11-24 11:43 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-11-25 13:52 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-11-29 13:03 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/intel/kms_pm_dc: Fix dc9-dpms test on LNL (rev3) Patchwork
2023-11-29 14:13 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-11-30 13:30 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220422002230.19535-1-mohammed.thasleem@intel.com \
--to=mohammed.thasleem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox