Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/kms_flip: skip test if compatible mode is not found
Date: Fri,  3 Jun 2022 12:08:36 +0530	[thread overview]
Message-ID: <20220603063836.5420-1-jeevan.b@intel.com> (raw)

skip test if the compatible mode is not found instead of
forcing the first connector mode on to the other connector.

Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/4190
Signed-off-by: Jeevan B <jeevan.b@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
---
 tests/kms_flip.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 5985e012..c5b5741a 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -950,8 +950,7 @@ static void get_compatible_modes(drmModeModeInfo *a, drmModeModeInfo *b,
 			}
 		}
 
-		/* hope for the best! */
-		*a = *b = c1->modes[0];
+		igt_skip("Compatible mode not found.\n");
 	}
 
 	return;
-- 
2.36.0

             reply	other threads:[~2022-06-03  6:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-03  6:38 Jeevan B [this message]
2022-06-03  7:24 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip: skip test if compatible mode is not found (rev2) Patchwork
2022-06-03  8:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2022-06-01 19:05 [igt-dev] [PATCH i-g-t] tests/kms_flip: skip test if compatible mode is not found Jeevan B
2022-06-02  9:19 ` Karthik B S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220603063836.5420-1-jeevan.b@intel.com \
    --to=jeevan.b@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox