Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_flip: skip test if compatible mode is not found
@ 2022-06-03  6:38 Jeevan B
  2022-06-03  7:24 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip: skip test if compatible mode is not found (rev2) Patchwork
  2022-06-03  8:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  0 siblings, 2 replies; 5+ messages in thread
From: Jeevan B @ 2022-06-03  6:38 UTC (permalink / raw)
  To: igt-dev

skip test if the compatible mode is not found instead of
forcing the first connector mode on to the other connector.

Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/4190
Signed-off-by: Jeevan B <jeevan.b@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
---
 tests/kms_flip.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 5985e012..c5b5741a 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -950,8 +950,7 @@ static void get_compatible_modes(drmModeModeInfo *a, drmModeModeInfo *b,
 			}
 		}
 
-		/* hope for the best! */
-		*a = *b = c1->modes[0];
+		igt_skip("Compatible mode not found.\n");
 	}
 
 	return;
-- 
2.36.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_flip: skip test if compatible mode is not found
@ 2022-06-01 19:05 Jeevan B
  2022-06-02  9:19 ` Karthik B S
  0 siblings, 1 reply; 5+ messages in thread
From: Jeevan B @ 2022-06-01 19:05 UTC (permalink / raw)
  To: igt-dev

skip test if the compatible mode is not found instead of
forcing the first connector mode on to the other connector.

Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
 tests/kms_flip.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 5985e012..c5b5741a 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -950,8 +950,7 @@ static void get_compatible_modes(drmModeModeInfo *a, drmModeModeInfo *b,
 			}
 		}
 
-		/* hope for the best! */
-		*a = *b = c1->modes[0];
+		igt_skip("Compatible mode not found.\n");
 	}
 
 	return;
-- 
2.36.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-03  8:41 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-03  6:38 [igt-dev] [PATCH i-g-t] tests/kms_flip: skip test if compatible mode is not found Jeevan B
2022-06-03  7:24 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip: skip test if compatible mode is not found (rev2) Patchwork
2022-06-03  8:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2022-06-01 19:05 [igt-dev] [PATCH i-g-t] tests/kms_flip: skip test if compatible mode is not found Jeevan B
2022-06-02  9:19 ` Karthik B S

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox