Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Petri Latvala <petri.latvala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>
Subject: [igt-dev] [PATCH i-g-t 7/7] runner: Disable socket communications for now
Date: Mon, 10 Oct 2022 17:57:08 +0300	[thread overview]
Message-ID: <20221010145708.1986912-7-petri.latvala@intel.com> (raw)
In-Reply-To: <20221010145708.1986912-1-petri.latvala@intel.com>

Currently, having i915 CI systems test the socket communications when
testing is impossible. If a test hangs completely, the incomplete set
of results are processed into results.json with an older IGT version
from a previous post-merge build, which is unable to parse socket
communications. Disable them for now.

This commit will get reverted after suitable testing has been possible
to execute.

Signed-off-by: Petri Latvala <petri.latvala@intel.com>
---
 runner/executor.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/runner/executor.c b/runner/executor.c
index 125f08a2..f6f27d48 100644
--- a/runner/executor.c
+++ b/runner/executor.c
@@ -1657,7 +1657,8 @@ static int execute_next_entry(struct execute_state *state,
 
 		sigprocmask(SIG_UNBLOCK, sigmask, NULL);
 
-		if (socketfd >= 0 && !getenv("IGT_RUNNER_DISABLE_SOCKET_COMMUNICATION")) {
+		if (socketfd >= 0 && !getenv("IGT_RUNNER_DISABLE_SOCKET_COMMUNICATION") &&
+		    getenv("IGT_RUNNER_ENABLE_SOCKET_COMMUNICATION")) {
 			snprintf(envstring, sizeof(envstring), "%d", socketfd);
 			setenv("IGT_RUNNER_SOCKET_FD", envstring, 1);
 		}
-- 
2.30.2

  parent reply	other threads:[~2022-10-10 14:57 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10 14:57 [igt-dev] [PATCH i-g-t 1/7] lib/runnercomms: Structured communication from tests to igt_runner Petri Latvala
2022-10-10 14:57 ` [igt-dev] [PATCH i-g-t 2/7] lib/igt_core: Send logs to runner with comms Petri Latvala
2022-10-28 13:46   ` Kamil Konieczny
2022-10-10 14:57 ` [igt-dev] [PATCH i-g-t 3/7] runner: Use socket communications Petri Latvala
2022-10-28 13:47   ` Kamil Konieczny
2022-10-10 14:57 ` [igt-dev] [PATCH i-g-t 4/7] runner/runner_tests: Add tests for " Petri Latvala
2022-10-28 13:49   ` Kamil Konieczny
2022-10-10 14:57 ` [igt-dev] [PATCH i-g-t 5/7] lib/tests: Add unit tests for socket communication packet creation Petri Latvala
2022-10-28 13:51   ` Kamil Konieczny
2022-10-10 14:57 ` [igt-dev] [PATCH i-g-t 6/7] runner: Add a socket comms decoder Petri Latvala
2022-10-28 13:52   ` Kamil Konieczny
2022-10-10 14:57 ` Petri Latvala [this message]
2022-10-28 13:59   ` [igt-dev] [PATCH i-g-t 7/7] runner: Disable socket communications for now Kamil Konieczny
2022-10-31 10:16     ` Petri Latvala
2022-10-10 15:56 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/7] lib/runnercomms: Structured communication from tests to igt_runner Patchwork
2022-10-10 21:05 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-10-11  6:25   ` Petri Latvala
2022-10-11 16:44     ` Vudum, Lakshminarayana
2022-10-11  6:45 ` Patchwork
2022-10-11 15:56 ` Patchwork
2022-10-11 16:38 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
2022-10-28 13:42 ` [igt-dev] [PATCH i-g-t 1/7] " Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221010145708.1986912-7-petri.latvala@intel.com \
    --to=petri.latvala@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox