Re: [igt-dev] [PATCH i-g-t 7/7] runner: Disable socket communications for now

[Kamil Konieczny <kamil.konieczny@linux.intel.com>]

Hi Petri,

On 2022-10-10 at 17:57:08 +0300, Petri Latvala wrote:
> Currently, having i915 CI systems test the socket communications when
> testing is impossible. If a test hangs completely, the incomplete set
> of results are processed into results.json with an older IGT version
> from a previous post-merge build, which is unable to parse socket
> communications. Disable them for now.
> 
> This commit will get reverted after suitable testing has been possible
> to execute.

imho this is a little unclear why adding var is acutally disabling
anything, but maybe it is that current CI do not have it ?

> 
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> ---
>  runner/executor.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/runner/executor.c b/runner/executor.c
> index 125f08a2..f6f27d48 100644
> --- a/runner/executor.c
> +++ b/runner/executor.c
> @@ -1657,7 +1657,8 @@ static int execute_next_entry(struct execute_state *state,
>  
>  		sigprocmask(SIG_UNBLOCK, sigmask, NULL);
>  
> -		if (socketfd >= 0 && !getenv("IGT_RUNNER_DISABLE_SOCKET_COMMUNICATION")) {
> +		if (socketfd >= 0 && !getenv("IGT_RUNNER_DISABLE_SOCKET_COMMUNICATION") &&
> +		    getenv("IGT_RUNNER_ENABLE_SOCKET_COMMUNICATION")) {

what about IGT_RUNNER_ENABLE_SOCKET_COMMUNICATION_REMOVE_ME ? 
or IGT_RUNNER_ENABLE_SOCKET_COMMUNICATION_REMOVE_FIXME ? 
Or maybe you plan to keep it here and remove _DISABLE_ one ?

With or without it
Acked-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

--
Kamil

>  			snprintf(envstring, sizeof(envstring), "%d", socketfd);
>  			setenv("IGT_RUNNER_SOCKET_FD", envstring, 1);
>  		}
> -- 
> 2.30.2
>