From: "Maíra Canal" <mcanal@igalia.com>
To: igt-dev@lists.freedesktop.org
Cc: petri.latvala@intel.com, Emma Anholt <emma@anholt.net>
Subject: [igt-dev] [PATCH i-g-t 3/6] tests/v3d: Remove unused or redundant includes
Date: Tue, 8 Nov 2022 20:57:21 -0300 [thread overview]
Message-ID: <20221108235724.126287-4-mcanal@igalia.com> (raw)
In-Reply-To: <20221108235724.126287-1-mcanal@igalia.com>
The V3D test files contain some includes that aren't required for
compilation: some includes are simply not used and others are included
through other headers. Simplify the code by removing unused includes.
Signed-off-by: Maíra Canal <mcanal@igalia.com>
---
lib/igt_v3d.c | 3 ---
tests/v3d/v3d_get_bo_offset.c | 12 ------------
tests/v3d/v3d_get_param.c | 12 ------------
tests/v3d/v3d_mmap.c | 12 ------------
4 files changed, 39 deletions(-)
diff --git a/lib/igt_v3d.c b/lib/igt_v3d.c
index 619c072c..bd645320 100644
--- a/lib/igt_v3d.c
+++ b/lib/igt_v3d.c
@@ -36,9 +36,6 @@
#include "igt_core.h"
#include "igt_v3d.h"
#include "ioctl_wrappers.h"
-#include "intel_reg.h"
-#include "intel_chipset.h"
-#include "v3d_drm.h"
/**
* SECTION:igt_v3d
diff --git a/tests/v3d/v3d_get_bo_offset.c b/tests/v3d/v3d_get_bo_offset.c
index 0923dc85..976a28b8 100644
--- a/tests/v3d/v3d_get_bo_offset.c
+++ b/tests/v3d/v3d_get_bo_offset.c
@@ -23,18 +23,6 @@
#include "igt.h"
#include "igt_v3d.h"
-#include <unistd.h>
-#include <stdlib.h>
-#include <stdio.h>
-#include <string.h>
-#include <fcntl.h>
-#include <inttypes.h>
-#include <errno.h>
-#include <sys/stat.h>
-#include <sys/ioctl.h>
-#include <poll.h>
-#include "v3d_drm.h"
-#include "igt_v3d.h"
igt_main
{
diff --git a/tests/v3d/v3d_get_param.c b/tests/v3d/v3d_get_param.c
index 76563406..816a3c7d 100644
--- a/tests/v3d/v3d_get_param.c
+++ b/tests/v3d/v3d_get_param.c
@@ -23,18 +23,6 @@
#include "igt.h"
#include "igt_v3d.h"
-#include <unistd.h>
-#include <stdlib.h>
-#include <stdio.h>
-#include <string.h>
-#include <fcntl.h>
-#include <inttypes.h>
-#include <errno.h>
-#include <sys/stat.h>
-#include <sys/ioctl.h>
-#include <poll.h>
-#include "v3d_drm.h"
-#include "igt_v3d.h"
igt_main
{
diff --git a/tests/v3d/v3d_mmap.c b/tests/v3d/v3d_mmap.c
index a6fe7e5a..ad441607 100644
--- a/tests/v3d/v3d_mmap.c
+++ b/tests/v3d/v3d_mmap.c
@@ -23,18 +23,6 @@
#include "igt.h"
#include "igt_v3d.h"
-#include <unistd.h>
-#include <stdlib.h>
-#include <stdio.h>
-#include <string.h>
-#include <fcntl.h>
-#include <inttypes.h>
-#include <errno.h>
-#include <sys/stat.h>
-#include <sys/ioctl.h>
-#include <poll.h>
-#include "v3d_drm.h"
-#include "igt_v3d.h"
igt_main
{
--
2.38.1
next prev parent reply other threads:[~2022-11-08 23:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 23:57 [igt-dev] [PATCH i-g-t 0/6] V3D IGT Tests Updates Maíra Canal
2022-11-08 23:57 ` [igt-dev] [PATCH i-g-t 1/6] include/drm-uapi: Update to the latest v3d_drm.h Maíra Canal
2022-11-08 23:57 ` [igt-dev] [PATCH i-g-t 2/6] tests/v3d: Move V3D tests to their own folder Maíra Canal
2022-11-08 23:57 ` Maíra Canal [this message]
2022-11-08 23:57 ` [igt-dev] [PATCH i-g-t 4/6] lib/igt_v3d: Add PAGE_SIZE macro to V3D Maíra Canal
2022-11-08 23:57 ` [igt-dev] [PATCH i-g-t 5/6] tests/v3d_create_bo: Create test for V3D's Create BO IOCTL Maíra Canal
2022-11-10 15:06 ` Kamil Konieczny
2022-11-08 23:57 ` [igt-dev] [PATCH i-g-t 6/6] tests/v3d_perfmon: Create test for V3D's Perfmon IOCTLs Maíra Canal
2022-11-09 1:00 ` [igt-dev] ✓ Fi.CI.BAT: success for V3D IGT Tests Updates Patchwork
2022-11-09 4:23 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221108235724.126287-4-mcanal@igalia.com \
--to=mcanal@igalia.com \
--cc=emma@anholt.net \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox