Re: [igt-dev] [PATCH i-g-t 5/6] tests/v3d_create_bo: Create test for V3D's Create BO IOCTL

[Kamil Konieczny <kamil.konieczny@linux.intel.com>]

Hi Maíra,

few nits, see below.

On 2022-11-08 at 20:57:23 -0300, Maíra Canal wrote:
> Add three igt_subtests for the DRM_IOCTL_V3D_CREATE_BO, which tests the
> creation of a zeroed BO and a 4096 bytes BO, and tests if the BO is
> properly cleaned.
> 
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
>  tests/meson.build         |  1 +
>  tests/v3d/v3d_create_bo.c | 79 +++++++++++++++++++++++++++++++++++++++
>  tests/v3d_ci/v3d.testlist |  3 ++
>  3 files changed, 83 insertions(+)
>  create mode 100644 tests/v3d/v3d_create_bo.c
> 
> diff --git a/tests/meson.build b/tests/meson.build
> index 5c9b1829..f1a6a9dd 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -256,6 +256,7 @@ msm_progs = [
>  ]
>  
>  v3d_progs = [
> +	'v3d_create_bo',
>  	'v3d_get_bo_offset',
>  	'v3d_get_param',
>  	'v3d_mmap',
> diff --git a/tests/v3d/v3d_create_bo.c b/tests/v3d/v3d_create_bo.c
> new file mode 100644
> index 00000000..9b13f603
> --- /dev/null
> +++ b/tests/v3d/v3d_create_bo.c
> @@ -0,0 +1,79 @@
> +/*
> + * Copyright © 2022 Igalia S.L.
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.

Please use SPDX licence instead.

> + *
> + * Authors:
> + * 	Maíra Canal <mcanal@igalia.com>
> + */
> +
> +#include "igt.h"
> +#include "igt_v3d.h"
> +
> +igt_main
> +{
> +	int fd;
> +
> +	igt_fixture {
> +		fd = drm_open_driver(DRIVER_V3D);
> +	}
> +

Please put description to each new added test with igt_describe,
here and below. Look at lib/igt_core.h for how to do it.
You can test it with --describe option.

Regards,
Kamil

> +	igt_subtest("create-bo-0") {
> +		struct drm_v3d_create_bo create = {
> +			.size = 0,
> +		};
> +		do_ioctl_err(fd, DRM_IOCTL_V3D_CREATE_BO, &create, EINVAL);
> +	}
> +
> +	igt_subtest("create-bo-4096") {
> +		struct v3d_bo *bo = igt_v3d_create_bo(fd, PAGE_SIZE);
> +		igt_v3d_free_bo(fd, bo);
> +	}
> +
> +	igt_subtest("create-bo-zeroed") {
> +		int fd2 = drm_open_driver(DRIVER_V3D);
> +		struct v3d_bo *bo;
> +		/* A size different from any used in our other tests, to try
> +		 * to convince it to land as the only one of its size in the
> +		 * kernel BO cache
> +		 */
> +		size_t size = 3 * PAGE_SIZE, i;
> +
> +		/* Make a BO and free it on our main fd. */
> +		bo = igt_v3d_create_bo(fd, size);
> +		bo->map = igt_v3d_mmap_bo(fd, bo->handle, size, PROT_READ | PROT_WRITE);
> +		memset(bo->map, 0xd0, size);
> +		igt_v3d_free_bo(fd, bo);
> +
> +		/* Now, allocate a BO on the other fd and make sure it doesn't
> +		 * have the old contents.
> +		 */
> +		bo = igt_v3d_create_bo(fd2, size);
> +		bo->map = igt_v3d_mmap_bo(fd2, bo->handle, size, PROT_READ | PROT_WRITE);
> +		for (i = 0; i < size / 4; i++)
> +			igt_assert_eq_u32(((uint32_t *)bo->map)[i], 0x0);
> +		igt_v3d_free_bo(fd2, bo);
> +
> +		close(fd2);
> +	}
> +
> +	igt_fixture
> +		close(fd);
> +}
> diff --git a/tests/v3d_ci/v3d.testlist b/tests/v3d_ci/v3d.testlist
> index b55e8e57..f4355285 100644
> --- a/tests/v3d_ci/v3d.testlist
> +++ b/tests/v3d_ci/v3d.testlist
> @@ -1,3 +1,6 @@
> +igt@v3d_create_bo@create-bo-0
> +igt@v3d_create_bo@create-bo-4096
> +igt@v3d_create_bo@create-bo-zeroed
>  igt@v3d_get_bo_offset@create-get-offsets
>  igt@v3d_get_bo_offset@get-bad-handle
>  igt@v3d_get_param@base-params
> -- 
> 2.38.1
>