Re: [igt-dev] [PATCH i-g-t v2 2/7] tests/v3d: Move V3D tests to their own folder

[Melissa Wen <mwen@igalia.com>]

[-- Attachment #1: Type: text/plain, Size: 2426 bytes --]

On 11/11, Maíra Canal wrote:
> With the introduction of new tests to V3D, in order to avoid polluting
> the main tests folder, move the V3D tests to a separate folder.
> 
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
>  tests/meson.build                   | 18 +++++++++++++++---
>  tests/{ => v3d}/v3d_get_bo_offset.c |  0
>  tests/{ => v3d}/v3d_get_param.c     |  0
>  tests/{ => v3d}/v3d_mmap.c          |  0
>  4 files changed, 15 insertions(+), 3 deletions(-)
>  rename tests/{ => v3d}/v3d_get_bo_offset.c (100%)
>  rename tests/{ => v3d}/v3d_get_param.c (100%)
>  rename tests/{ => v3d}/v3d_mmap.c (100%)
> 
> diff --git a/tests/meson.build b/tests/meson.build
> index 12e53e0b..5c9b1829 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -80,9 +80,6 @@ test_progs = [
>  	'syncobj_timeline',
>  	'template',
>  	'tools_test',
> -	'v3d_get_bo_offset',
> -	'v3d_get_param',
> -	'v3d_mmap',
>  	'vc4_create_bo',
>  	'vc4_dmabuf_poll',
>  	'vc4_label_bo',
> @@ -258,6 +255,12 @@ msm_progs = [
>  	'msm_submit'
>  ]
>  
> +v3d_progs = [
> +	'v3d_get_bo_offset',
> +	'v3d_get_param',
> +	'v3d_mmap',
> +]

Not a strong opinion, but I would prefer to have a subdir `v3d` and run
tests from there, the same way as done for amdgpu tests. That means,
running from build/tests/v3d/

> +
>  chamelium_progs = [
>  	'kms_chamelium',
>  ]
> @@ -305,6 +308,15 @@ foreach prog : msm_progs
>  	test_list += prog
>  endforeach
>  
> +foreach prog : v3d_progs
> +	test_executables += executable(prog, join_paths('v3d', prog + '.c'),
> +				       dependencies : test_deps,
> +				       install_dir : libexecdir,
> +				       install_rpath : libexecdir_rpathdir,
> +				       install : true)
> +	test_list += prog
> +endforeach
> +
>  if chamelium.found()
>  	foreach prog : chamelium_progs
>  		test_executables += executable(prog,
> diff --git a/tests/v3d_get_bo_offset.c b/tests/v3d/v3d_get_bo_offset.c
> similarity index 100%
> rename from tests/v3d_get_bo_offset.c
> rename to tests/v3d/v3d_get_bo_offset.c
> diff --git a/tests/v3d_get_param.c b/tests/v3d/v3d_get_param.c
> similarity index 100%
> rename from tests/v3d_get_param.c
> rename to tests/v3d/v3d_get_param.c
> diff --git a/tests/v3d_mmap.c b/tests/v3d/v3d_mmap.c
> similarity index 100%
> rename from tests/v3d_mmap.c
> rename to tests/v3d/v3d_mmap.c
> -- 
> 2.38.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]