Re: [igt-dev] [PATCH i-g-t v2 0/7] V3D IGT Tests Updates

[Melissa Wen <mwen@igalia.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2169 bytes --]

O 11/11, Maíra Canal wrote:
> This series aims to update the V3D IGT tests. The first five patches contain
> some janitorial duties related to the existing tests: updating the uAPI header,
> creating a folder for the V3D tests, removing some unused includes, adding 
> descriptions to the existing tests and adding a macro with the default PAGE_SIZE.
> The last two patches include new tests for the V3D driver.
> 
> Best Regards,
> - Maíra Canal

Hi Maira,

Thanks for this work.

Overall LGTM. I asked two improvements, and with that you can include my
r-b tag in the next version.

Reviewed-by: Melissa Wen <mwen@igalia.com>

> 
> v1 -> v2: https://patchwork.freedesktop.org/series/110681/
> - Use SPDX licence (Kamil Konieczny).
> - Add descriptions to each new added test with igt_describe (Kamil Konieczny).
> - Add descriptions to existing V3D tests.
> 
> Maíra Canal (7):
>   include/drm-uapi: Update to the latest v3d_drm.h
>   tests/v3d: Move V3D tests to their own folder
>   tests/v3d: Remove unused or redundant includes
>   tests/v3d: Add igt_describe() to all V3D subtests
>   lib/igt_v3d: Add PAGE_SIZE macro to V3D
>   tests/v3d_create_bo: Create test for V3D's Create BO IOCTL
>   tests/v3d_perfmon: Create test for V3D's Perfmon IOCTLs
> 
>  include/drm-uapi/v3d_drm.h          |  78 +++++++++++++++
>  lib/igt_v3d.c                       |  39 +++++++-
>  lib/igt_v3d.h                       |   6 ++
>  tests/meson.build                   |  20 +++-
>  tests/v3d/v3d_create_bo.c           |  63 ++++++++++++
>  tests/{ => v3d}/v3d_get_bo_offset.c |  21 ++--
>  tests/{ => v3d}/v3d_get_param.c     |  17 +---
>  tests/{ => v3d}/v3d_mmap.c          |  15 +--
>  tests/v3d/v3d_perfmon.c             | 144 ++++++++++++++++++++++++++++
>  tests/v3d_ci/v3d.testlist           |  14 +++
>  10 files changed, 373 insertions(+), 44 deletions(-)
>  create mode 100644 tests/v3d/v3d_create_bo.c
>  rename tests/{ => v3d}/v3d_get_bo_offset.c (85%)
>  rename tests/{ => v3d}/v3d_get_param.c (88%)
>  rename tests/{ => v3d}/v3d_mmap.c (85%)
>  create mode 100644 tests/v3d/v3d_perfmon.c
> 
> -- 
> 2.38.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]