public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [igt-dev] [PATCH i-g-t] tools/intel_vbt_decode: print debug-ish messages to stderr
Date: Tue, 29 Nov 2022 15:14:24 +0200	[thread overview]
Message-ID: <20221129131424.2096289-1-jani.nikula@intel.com> (raw)

The tool outputs the decoded and somewhat nicely formatted VBT to
stdout, so debug style messages to stdout aren't a great fit. For
example:

BDB blocks present:
	  1   2   9  10  12  20  27  40Generating LVDS data table pointers
  41Generating LVDS data table pointers
  42  43  44  46  51  52  53
	 56  57  58 252 253 254

Print the debug message about data table pointers to stderr instead.

Fixes: ce4d30196d3c ("tools/intel_vbt_decode: Generate LVDS data table pointes if not provided")
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 tools/intel_vbt_decode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
index 94a910b5c107..8f707c1f822a 100644
--- a/tools/intel_vbt_decode.c
+++ b/tools/intel_vbt_decode.c
@@ -460,7 +460,7 @@ static struct bdb_block *find_section(const struct context *context, int section
 
 	data = find_raw_section(context, section_id);
 	if (!data && section_id == BDB_LVDS_LFP_DATA_PTRS) {
-		printf("Generating LVDS data table pointers\n");
+		fprintf(stderr, "Generating LVDS data table pointers\n");
 		temp_block = generate_lvds_data_ptrs(context);
 		if (temp_block)
 			data = temp_block + 3;
-- 
2.34.1

             reply	other threads:[~2022-11-29 13:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-29 13:14 Jani Nikula [this message]
2022-11-29 16:53 ` [igt-dev] ✗ Fi.CI.BAT: failure for tools/intel_vbt_decode: print debug-ish messages to stderr Patchwork
2022-11-30 17:16 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221129131424.2096289-1-jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox