Re: [igt-dev] [PATCH i-g-t] tools/intel_vbt_decode: print debug-ish messages to stderr

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Nov 29, 2022 at 03:14:24PM +0200, Jani Nikula wrote:
> The tool outputs the decoded and somewhat nicely formatted VBT to
> stdout, so debug style messages to stdout aren't a great fit. For
> example:
> 
> BDB blocks present:
> 	  1   2   9  10  12  20  27  40Generating LVDS data table pointers
>   41Generating LVDS data table pointers
>   42  43  44  46  51  52  53
> 	 56  57  58 252 253 254
> 
> Print the debug message about data table pointers to stderr instead.
> 
> Fixes: ce4d30196d3c ("tools/intel_vbt_decode: Generate LVDS data table pointes if not provided")
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  tools/intel_vbt_decode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
> index 94a910b5c107..8f707c1f822a 100644
> --- a/tools/intel_vbt_decode.c
> +++ b/tools/intel_vbt_decode.c
> @@ -460,7 +460,7 @@ static struct bdb_block *find_section(const struct context *context, int section
>  
>  	data = find_raw_section(context, section_id);
>  	if (!data && section_id == BDB_LVDS_LFP_DATA_PTRS) {
> -		printf("Generating LVDS data table pointers\n");
> +		fprintf(stderr, "Generating LVDS data table pointers\n");
>  		temp_block = generate_lvds_data_ptrs(context);
>  		if (temp_block)
>  			data = temp_block + 3;
> -- 
> 2.34.1

-- 
Ville Syrjälä
Intel