[igt-dev] [PATCH i-g-t] tools/intel_vbt_decode: print debug-ish messages to stderr

[igt-dev] [PATCH i-g-t] tools/intel_vbt_decode: print debug-ish messages to stderr

[Jani Nikula]

The tool outputs the decoded and somewhat nicely formatted VBT to
stdout, so debug style messages to stdout aren't a great fit. For
example:

BDB blocks present:
	  1   2   9  10  12  20  27  40Generating LVDS data table pointers
  41Generating LVDS data table pointers
  42  43  44  46  51  52  53
	 56  57  58 252 253 254

Print the debug message about data table pointers to stderr instead.

Fixes: ce4d30196d3c ("tools/intel_vbt_decode: Generate LVDS data table pointes if not provided")
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 tools/intel_vbt_decode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
index 94a910b5c107..8f707c1f822a 100644
--- a/tools/intel_vbt_decode.c
+++ b/tools/intel_vbt_decode.c
@@ -460,7 +460,7 @@ static struct bdb_block *find_section(const struct context *context, int section
 
 	data = find_raw_section(context, section_id);
 	if (!data && section_id == BDB_LVDS_LFP_DATA_PTRS) {
-		printf("Generating LVDS data table pointers\n");
+		fprintf(stderr, "Generating LVDS data table pointers\n");
 		temp_block = generate_lvds_data_ptrs(context);
 		if (temp_block)
 			data = temp_block + 3;
-- 
2.34.1

[igt-dev] ✗ Fi.CI.BAT: failure for tools/intel_vbt_decode: print debug-ish messages to stderr

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 5172 bytes --]

== Series Details ==

Series: tools/intel_vbt_decode: print debug-ish messages to stderr
URL   : https://patchwork.freedesktop.org/series/111436/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_12444 -> IGTPW_8168
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_8168 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_8168, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8168/index.html

Participating hosts (37 -> 37)
------------------------------

  Additional (1): bat-atsm-1 
  Missing    (1): fi-cml-u2 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_8168:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_cursor_legacy@basic-flip-before-cursor@atomic-transitions-varying-size:
    - fi-bsw-kefka:       [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12444/fi-bsw-kefka/igt@kms_cursor_legacy@basic-flip-before-cursor@atomic-transitions-varying-size.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8168/fi-bsw-kefka/igt@kms_cursor_legacy@basic-flip-before-cursor@atomic-transitions-varying-size.html

  
Known issues
------------

  Here are the changes found in IGTPW_8168 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@core_hotunplug@unbind-rebind:
    - fi-apl-guc:         [PASS][3] -> [INCOMPLETE][4] ([i915#7073])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12444/fi-apl-guc/igt@core_hotunplug@unbind-rebind.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8168/fi-apl-guc/igt@core_hotunplug@unbind-rebind.html

  
#### Possible fixes ####

  * igt@fbdev@read:
    - {bat-rpls-2}:       [SKIP][5] ([i915#2582]) -> [PASS][6] +4 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12444/bat-rpls-2/igt@fbdev@read.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8168/bat-rpls-2/igt@fbdev@read.html

  * igt@i915_selftest@live@migrate:
    - {bat-adlp-6}:       [INCOMPLETE][7] ([i915#7348]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12444/bat-adlp-6/igt@i915_selftest@live@migrate.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8168/bat-adlp-6/igt@i915_selftest@live@migrate.html

  * igt@i915_selftest@live@reset:
    - {bat-rpls-1}:       [DMESG-FAIL][9] ([i915#4983]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12444/bat-rpls-1/igt@i915_selftest@live@reset.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8168/bat-rpls-1/igt@i915_selftest@live@reset.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
  [i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#6077]: https://gitlab.freedesktop.org/drm/intel/issues/6077
  [i915#6078]: https://gitlab.freedesktop.org/drm/intel/issues/6078
  [i915#6093]: https://gitlab.freedesktop.org/drm/intel/issues/6093
  [i915#6094]: https://gitlab.freedesktop.org/drm/intel/issues/6094
  [i915#6166]: https://gitlab.freedesktop.org/drm/intel/issues/6166
  [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
  [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
  [i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
  [i915#7073]: https://gitlab.freedesktop.org/drm/intel/issues/7073
  [i915#7348]: https://gitlab.freedesktop.org/drm/intel/issues/7348
  [i915#7357]: https://gitlab.freedesktop.org/drm/intel/issues/7357
  [i915#7535]: https://gitlab.freedesktop.org/drm/intel/issues/7535


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7075 -> IGTPW_8168

  CI-20190529: 20190529
  CI_DRM_12444: 72e5dd1b5229d0dec188ccbb168b2713dcb143c8 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8168: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8168/index.html
  IGT_7075: ae0ad0ffa147445cdf9d33c96a018f5a8b21a5ee @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8168/index.html

[-- Attachment #2: Type: text/html, Size: 4546 bytes --]

Re: [igt-dev] [PATCH i-g-t] tools/intel_vbt_decode: print debug-ish messages to stderr

[Ville Syrjälä]

On Tue, Nov 29, 2022 at 03:14:24PM +0200, Jani Nikula wrote:
> The tool outputs the decoded and somewhat nicely formatted VBT to
> stdout, so debug style messages to stdout aren't a great fit. For
> example:
> 
> BDB blocks present:
> 	  1   2   9  10  12  20  27  40Generating LVDS data table pointers
>   41Generating LVDS data table pointers
>   42  43  44  46  51  52  53
> 	 56  57  58 252 253 254
> 
> Print the debug message about data table pointers to stderr instead.
> 
> Fixes: ce4d30196d3c ("tools/intel_vbt_decode: Generate LVDS data table pointes if not provided")
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  tools/intel_vbt_decode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
> index 94a910b5c107..8f707c1f822a 100644
> --- a/tools/intel_vbt_decode.c
> +++ b/tools/intel_vbt_decode.c
> @@ -460,7 +460,7 @@ static struct bdb_block *find_section(const struct context *context, int section
>  
>  	data = find_raw_section(context, section_id);
>  	if (!data && section_id == BDB_LVDS_LFP_DATA_PTRS) {
> -		printf("Generating LVDS data table pointers\n");
> +		fprintf(stderr, "Generating LVDS data table pointers\n");
>  		temp_block = generate_lvds_data_ptrs(context);
>  		if (temp_block)
>  			data = temp_block + 3;
> -- 
> 2.34.1

-- 
Ville Syrjälä
Intel