public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [CI i-g-t] tests/perf_pmu: Try to understand GL #6806
@ 2022-12-15  2:54 Ashutosh Dixit
  2022-12-15  3:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
  2022-12-16 10:51 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  0 siblings, 2 replies; 3+ messages in thread
From: Ashutosh Dixit @ 2022-12-15  2:54 UTC (permalink / raw)
  To: igt-dev

CI ONLY, PLEASE DON'T REVIEW

Try to repro GL #6806 and see what is really happening there since it could
not be reproduced locally.

The only machine this is reproducing on is bat-dg2-11 which it appears has
been moved from trybot to drm-tip CI. So, sorry, not sending this patch to
trybot.

v2: See freq's (especially min) without setting min/max but after a spinner
    has been started

Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/6806
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
 tests/i915/perf_pmu.c                 | 48 +++++++++++++++++++++++++++
 tests/intel-ci/fast-feedback.testlist |  1 +
 2 files changed, 49 insertions(+)

diff --git a/tests/i915/perf_pmu.c b/tests/i915/perf_pmu.c
index f363db2ba13..265cba24616 100644
--- a/tests/i915/perf_pmu.c
+++ b/tests/i915/perf_pmu.c
@@ -1543,6 +1543,19 @@ test_interrupts_sync(int gem_fd)
 	igt_assert_lte(target, busy);
 }
 
+static void print_freq(int sysfs)
+{
+	igt_info("--------------- Freq ------------- \n");
+	igt_info("RP0 %u\n", igt_sysfs_get_u32(sysfs, "gt_RP0_freq_mhz"));
+	igt_info("RP1 %u\n", igt_sysfs_get_u32(sysfs, "gt_RP1_freq_mhz"));
+	igt_info("RPn %u\n", igt_sysfs_get_u32(sysfs, "gt_RPn_freq_mhz"));
+	igt_info("boost %u\n", igt_sysfs_get_u32(sysfs, "gt_boost_freq_mhz"));
+	igt_info("act %u\n", igt_sysfs_get_u32(sysfs, "gt_act_freq_mhz"));
+	igt_info("cur %u\n", igt_sysfs_get_u32(sysfs, "gt_cur_freq_mhz"));
+	igt_info("max %u\n", igt_sysfs_get_u32(sysfs, "gt_max_freq_mhz"));
+	igt_info("min %u\n", igt_sysfs_get_u32(sysfs, "gt_min_freq_mhz"));
+}
+
 static void
 test_frequency(int gem_fd)
 {
@@ -1568,6 +1581,27 @@ test_frequency(int gem_fd)
 	fd[0] = open_group(gem_fd, I915_PMU_REQUESTED_FREQUENCY, -1);
 	fd[1] = open_group(gem_fd, I915_PMU_ACTUAL_FREQUENCY, fd[0]);
 
+	print_freq(sysfs);
+
+	gem_quiescent_gpu(gem_fd); /* Idle to be sure the change takes effect */
+	spin = spin_sync_flags(gem_fd, ahnd, 0, I915_EXEC_DEFAULT);
+
+	slept = pmu_read_multi(fd[0], 2, start);
+	measured_usleep(batch_duration_ns / 1000);
+	slept = pmu_read_multi(fd[0], 2, val) - slept;
+
+	min[0] = 1e9*(val[0] - start[0]) / slept;
+	min[1] = 1e9*(val[1] - start[1]) / slept;
+
+	print_freq(sysfs);
+
+	igt_spin_free(gem_fd, spin);
+	gem_quiescent_gpu(gem_fd); /* Don't leak busy bo into the next phase */
+
+	usleep(1e6);
+
+	print_freq(sysfs);
+
 	/*
 	 * Set GPU to min frequency and read PMU counters.
 	 */
@@ -1578,6 +1612,8 @@ test_frequency(int gem_fd)
 	igt_require(igt_sysfs_set_u32(sysfs, "gt_boost_freq_mhz", min_freq));
 	igt_require(igt_sysfs_get_u32(sysfs, "gt_boost_freq_mhz") == min_freq);
 
+	print_freq(sysfs);
+
 	gem_quiescent_gpu(gem_fd); /* Idle to be sure the change takes effect */
 	spin = spin_sync_flags(gem_fd, ahnd, 0, I915_EXEC_DEFAULT);
 
@@ -1588,11 +1624,15 @@ test_frequency(int gem_fd)
 	min[0] = 1e9*(val[0] - start[0]) / slept;
 	min[1] = 1e9*(val[1] - start[1]) / slept;
 
+	print_freq(sysfs);
+
 	igt_spin_free(gem_fd, spin);
 	gem_quiescent_gpu(gem_fd); /* Don't leak busy bo into the next phase */
 
 	usleep(1e6);
 
+	print_freq(sysfs);
+
 	/*
 	 * Set GPU to max frequency and read PMU counters.
 	 */
@@ -1604,6 +1644,8 @@ test_frequency(int gem_fd)
 	igt_require(igt_sysfs_set_u32(sysfs, "gt_min_freq_mhz", max_freq));
 	igt_require(igt_sysfs_get_u32(sysfs, "gt_min_freq_mhz") == max_freq);
 
+	print_freq(sysfs);
+
 	gem_quiescent_gpu(gem_fd);
 	spin = spin_sync_flags(gem_fd, ahnd, 0, I915_EXEC_DEFAULT);
 
@@ -1614,9 +1656,13 @@ test_frequency(int gem_fd)
 	max[0] = 1e9*(val[0] - start[0]) / slept;
 	max[1] = 1e9*(val[1] - start[1]) / slept;
 
+	print_freq(sysfs);
+
 	igt_spin_free(gem_fd, spin);
 	gem_quiescent_gpu(gem_fd);
 
+	print_freq(sysfs);
+
 	/*
 	 * Restore min/max.
 	 */
@@ -1633,6 +1679,8 @@ test_frequency(int gem_fd)
 	igt_info("Max frequency: requested %.1f, actual %.1f\n",
 		 max[0], max[1]);
 
+	print_freq(sysfs);
+
 	assert_within_epsilon(min[0], min_freq, tolerance);
 	/*
 	 * On thermally throttled devices we cannot be sure maximum frequency
diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index 88c90221e5a..28e1b16849c 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -128,6 +128,7 @@ igt@i915_pm_backlight@basic-brightness
 igt@i915_pm_rpm@basic-pci-d3-state
 igt@i915_pm_rpm@basic-rte
 igt@i915_pm_rps@basic-api
+igt@perf_pmu@frequency
 igt@prime_self_import@basic-llseek-bad
 igt@prime_self_import@basic-llseek-size
 igt@prime_self_import@basic-with_fd_dup
-- 
2.38.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-16 10:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-15  2:54 [igt-dev] [CI i-g-t] tests/perf_pmu: Try to understand GL #6806 Ashutosh Dixit
2022-12-15  3:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-12-16 10:51 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox