From: Andrzej Hajda <andrzej.hajda@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Matthew Auld <matthew.auld@intel.com>, Nirmoy Das <nirmoy.das@intel.com>
Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: cleanup framebuffers after test
Date: Mon, 2 Jan 2023 11:49:01 +0100 [thread overview]
Message-ID: <20230102104901.214146-1-andrzej.hajda@intel.com> (raw)
In-Reply-To: <7d276e53-0798-dc64-32be-a20bb4fb84a3@linux.intel.com>
Framebuffers created by igt_create_*_fb should be removed with
igt_remove_fb after test finish. Since all this happens inside
data_t context there is cleanup_fbs helper for it.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/7331
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
tests/kms_plane_scaling.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 4c621cce842..887a55e63ff 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -366,6 +366,7 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
igt_plane_set_fb(plane, NULL);
igt_plane_set_position(plane, 0, 0);
+ cleanup_fbs(d);
igt_skip_on_f(commit_ret == -ERANGE || commit_ret == -EINVAL,
"Unsupported scaling factor with fb size %dx%d\n",
@@ -670,8 +671,7 @@ test_planes_scaling_combo(data_t *d, int w1, int h1, int w2, int h2,
test_type);
}
- igt_remove_fb(display->drm_fd, &d->fb[1]);
- igt_remove_fb(display->drm_fd, &d->fb[2]);
+ cleanup_fbs(d);
}
static void
@@ -735,9 +735,7 @@ test_invalid_num_scalers(data_t *d, enum pipe pipe, igt_output_t *output)
igt_plane_set_fb(plane[0], NULL);
igt_plane_set_fb(plane[1], NULL);
igt_plane_set_fb(plane[2], NULL);
- igt_remove_fb(display->drm_fd, &d->fb[0]);
- igt_remove_fb(display->drm_fd, &d->fb[1]);
- igt_remove_fb(display->drm_fd, &d->fb[2]);
+ cleanup_fbs(d);
}
static void test_scaler_with_multi_pipe_plane(data_t *d)
@@ -813,6 +811,7 @@ static void test_scaler_with_multi_pipe_plane(data_t *d)
igt_plane_set_fb(plane[1], NULL);
igt_plane_set_fb(plane[2], NULL);
igt_plane_set_fb(plane[3], NULL);
+ cleanup_fbs(d);
igt_skip_on_f(ret1 == -ERANGE || ret1 == -EINVAL ||
ret2 == -ERANGE || ret1 == -EINVAL,
--
2.34.1
next prev parent reply other threads:[~2023-01-02 10:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 15:58 [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: remove fb after test Andrzej Hajda
2022-12-29 16:28 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-12-29 17:48 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2022-12-30 18:55 ` [igt-dev] [PATCH i-g-t] " Das, Nirmoy
2023-01-02 10:49 ` Andrzej Hajda [this message]
2023-01-02 10:51 ` [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: cleanup framebuffers " Das, Nirmoy
2022-12-30 19:25 ` [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: remove fb " Swati Sharma
2023-01-02 13:09 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_plane_scaling: remove fb after test (rev2) Patchwork
2023-01-02 19:05 ` Andrzej Hajda
2023-01-03 13:43 ` Kamil Konieczny
2023-01-03 17:26 ` Yedireswarapu, SaiX Nandan
2023-01-03 17:16 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-01-04 3:45 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-01-04 7:38 ` Andrzej Hajda
2023-01-04 11:31 ` Veesam, RavitejaX
2023-01-04 12:07 ` Yedireswarapu, SaiX Nandan
2023-01-04 11:55 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230102104901.214146-1-andrzej.hajda@intel.com \
--to=andrzej.hajda@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=nirmoy.das@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox