Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: remove fb after test

[Swati Sharma <swati2.sharma@intel.com>]

Hi,

We have
cleanup_fbs(data) defined in the IGT.
Should we use this?

On 29-Dec-22 9:28 PM, Andrzej Hajda wrote:
> igt_create_color_fb should be accompanied with igt_remove_fb.
> 
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/7331
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
> ---
>   tests/kms_plane_scaling.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 4c621cce842..1a8f1581f3e 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -367,6 +367,8 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
>   	igt_plane_set_fb(plane, NULL);
>   	igt_plane_set_position(plane, 0, 0);
>   
> +	igt_remove_fb(d->drm_fd, &d->fb[0]);
> +
>   	igt_skip_on_f(commit_ret == -ERANGE || commit_ret == -EINVAL,
>   		      "Unsupported scaling factor with fb size %dx%d\n",
>   		      w, h);

-- 
~Swati Sharma