From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>
Subject: [igt-dev] [PATCH i-g-t 1/2] lib/igt_crc: Remove crc32 table from common section
Date: Fri, 13 Jan 2023 20:25:52 +0100 [thread overview]
Message-ID: <20230113192553.89460-2-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20230113192553.89460-1-zbigniew.kempczynski@intel.com>
I've incidentally put crc32 table definition to the header file
instead of exporting it via extern keyword. Remove this symbol
from common section to be C89 conformant.
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
lib/igt_crc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/igt_crc.h b/lib/igt_crc.h
index 5c0b934ea5..bd36cb61d1 100644
--- a/lib/igt_crc.h
+++ b/lib/igt_crc.h
@@ -24,7 +24,7 @@
* All crc tables are globals to allow direct in-code use.
*/
-const uint32_t igt_crc32_tab[256];
+extern const uint32_t igt_crc32_tab[256];
uint32_t igt_cpu_crc32(const void *buf, size_t size);
--
2.34.1
next prev parent reply other threads:[~2023-01-13 19:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 19:25 [igt-dev] [PATCH i-g-t 0/2] Remove -fcommon flag Zbigniew Kempczyński
2023-01-13 19:25 ` Zbigniew Kempczyński [this message]
2023-01-16 9:29 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_crc: Remove crc32 table from common section Petri Latvala
2023-01-13 19:25 ` [igt-dev] [PATCH i-g-t 2/2] meson.build: Remove -fcommon flag Zbigniew Kempczyński
2023-01-16 9:30 ` Petri Latvala
2023-01-16 10:25 ` Zbigniew Kempczyński
2023-01-14 0:17 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-01-14 7:46 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230113192553.89460-2-zbigniew.kempczynski@intel.com \
--to=zbigniew.kempczynski@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox