Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_crc: Remove crc32 table from common section

[Petri Latvala <petri.latvala@intel.com>]

On Fri, Jan 13, 2023 at 08:25:52PM +0100, Zbigniew Kempczyński wrote:
> I've incidentally put crc32 table definition to the header file
> instead of exporting it via extern keyword. Remove this symbol
> from common section to be C89 conformant.
> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>

Fixes: https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/126

Thanks, I was just about to send this same patch.


Reviewed-by: Petri Latvala <petri.latvala@intel.com>

> ---
>  lib/igt_crc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/igt_crc.h b/lib/igt_crc.h
> index 5c0b934ea5..bd36cb61d1 100644
> --- a/lib/igt_crc.h
> +++ b/lib/igt_crc.h
> @@ -24,7 +24,7 @@
>   * All crc tables are globals to allow direct in-code use.
>   */
>  
> -const uint32_t igt_crc32_tab[256];
> +extern const uint32_t igt_crc32_tab[256];
>  
>  uint32_t igt_cpu_crc32(const void *buf, size_t size);
>  
> -- 
> 2.34.1
>