public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t v2] lib/igt_kms: Fixed the usage of Dereferencing of null pointer
@ 2023-01-20 12:36 Mohammed Thasleem
  2023-01-20 13:35 ` [igt-dev] [PATCH i-g-t v3] lib/igt_kms: Fixed the usage of dereferencing " Mohammed Thasleem
                   ` (8 more replies)
  0 siblings, 9 replies; 11+ messages in thread
From: Mohammed Thasleem @ 2023-01-20 12:36 UTC (permalink / raw)
  To: igt-dev; +Cc: petri.latvala

Fixed the usage of Dereferencing of null pointer to avoid crash.

v2: Removed igt_require and return false if proplist empty. (Kamil)
    %s/D/d in subj and description. (Kamil)

Signed-off-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
---
 lib/igt_kms.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index b4a98ae1..6a0c5ac2 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1941,6 +1941,9 @@ kmstest_get_property(int drm_fd, uint32_t object_id, uint32_t object_type,
 	int i;
 
 	proplist = drmModeObjectGetProperties(drm_fd, object_id, object_type);
+	if (!proplist)
+		return false;
+
 	for (i = 0; i < proplist->count_props; i++) {
 		_prop = drmModeGetProperty(drm_fd, proplist->props[i]);
 		if (!_prop)
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2023-01-23 10:40 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-20 12:36 [igt-dev] [PATCH i-g-t v2] lib/igt_kms: Fixed the usage of Dereferencing of null pointer Mohammed Thasleem
2023-01-20 13:35 ` [igt-dev] [PATCH i-g-t v3] lib/igt_kms: Fixed the usage of dereferencing " Mohammed Thasleem
2023-01-23 10:40   ` Kamil Konieczny
2023-01-20 13:45 ` [igt-dev] ✗ GitLab.Pipeline: warning for lib/igt_kms: Fixed the usage of Dereferencing of null pointer (rev3) Patchwork
2023-01-20 14:15 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-01-20 14:20 ` [igt-dev] ✗ GitLab.Pipeline: warning for lib/igt_kms: Fixed the usage of Dereferencing of null pointer (rev4) Patchwork
2023-01-20 14:30 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-01-20 17:29 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_kms: Fixed the usage of Dereferencing of null pointer (rev5) Patchwork
2023-01-21 18:12 ` [igt-dev] ✓ Fi.CI.IGT: success for lib/igt_kms: Fixed the usage of Dereferencing of null pointer (rev3) Patchwork
2023-01-21 18:17 ` [igt-dev] ✓ Fi.CI.IGT: success for lib/igt_kms: Fixed the usage of Dereferencing of null pointer (rev4) Patchwork
2023-01-21 19:52 ` [igt-dev] ✓ Fi.CI.IGT: success for lib/igt_kms: Fixed the usage of Dereferencing of null pointer (rev5) Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox