From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>
Subject: [igt-dev] [PATCH i-g-t 1/4] tools/intel_reg: Simplify negative ports
Date: Wed, 25 Jan 2023 07:42:36 +0200 [thread overview]
Message-ID: <20230125054239.26812-1-ville.syrjala@linux.intel.com> (raw)
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Let's avoid having to type in the explicit negative value for
all the port enums.
v2: Copy-paste the comment from intel_reg.c (Jani)
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tools/intel_reg_spec.h | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/tools/intel_reg_spec.h b/tools/intel_reg_spec.h
index c94c61bab3f8..1a2c5ebd9a58 100644
--- a/tools/intel_reg_spec.h
+++ b/tools/intel_reg_spec.h
@@ -25,10 +25,12 @@
#define __INTEL_REG_SPEC_H__
enum port_addr {
+ /* Negative port numbers are not real sideband ports. */
+ PORT_MMIO = -127,
+ PORT_PORTIO_VGA, /* see vga reg read/write */
+ PORT_MMIO_VGA, /* see vga reg read/write */
+
PORT_NONE = 0,
- PORT_MMIO = -1,
- PORT_PORTIO_VGA = -2, /* see vga reg read/write */
- PORT_MMIO_VGA = -3, /* see vga reg read/write */
/* vlv */
PORT_BUNIT = 0x03,
--
2.39.1
next reply other threads:[~2023-01-25 5:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 5:42 Ville Syrjala [this message]
2023-01-25 5:42 ` [igt-dev] [PATCH i-g-t 2/4] tools/intel_reg: Support 8 and 16 bit mmio registers Ville Syrjala
2023-01-25 5:42 ` [igt-dev] [PATCH i-g-t 3/4] tools/intel_reg: Add support for register access via the MCHBAR mirror Ville Syrjala
2023-01-25 5:42 ` [igt-dev] [PATCH i-g-t 4/4] tools/intel_reg: Add support for reading indexed VGA registers Ville Syrjala
2023-01-25 18:31 ` [igt-dev] [PATCH i-g-t v2 " Ville Syrjala
2023-01-25 6:41 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] tools/intel_reg: Simplify negative ports Patchwork
2023-01-25 9:30 ` [igt-dev] [PATCH i-g-t 1/4] " Jani Nikula
2023-01-25 13:12 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/4] " Patchwork
2023-01-25 19:37 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] tools/intel_reg: Simplify negative ports (rev2) Patchwork
2023-01-26 5:36 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2020-03-06 12:49 [igt-dev] [PATCH i-g-t 1/4] tools/intel_reg: Simplify negative ports Ville Syrjala
2020-03-09 7:52 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230125054239.26812-1-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox