public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Petri Latvala <petri.latvala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>
Subject: [igt-dev] [PATCH i-g-t 0/3] runner: Using 'abort' as test result instead of a separate test
Date: Thu, 26 Jan 2023 12:53:35 +0200	[thread overview]
Message-ID: <20230126105338.419418-1-petri.latvala@intel.com> (raw)

If a test caused an abort condition to trigger, a pseudoresult
"igt@runner@aborted" would be generated, detailing which test caused
the condition. That was implemented in a simpler world where there
were no dynamic subtests and CI systems (i915-CI in particular) didn't
have much test resuming happening.

The generated pseudoresult was completely unable to point to a
particular dynamic subtest if the executed subtest had any, and there
could inherently be only one of them. When combined with the fact that
the pseudoresult doesn't have logs that could be used to automatically
point to particular bug reports, that made results filtering by
CIBugLog difficult.

With socket communications it's easier to inject information "in
between" test's logs and result overriding is designed into the
system. Thus, when using socket communications, this patch series will
make the abort-condition-causing test's result 'abort' instead of
using that pseudoresult.

The flow becomes a little bit messier with monitor_output() gaining
more and more out-parameters but those can be cleaned later.

Petri Latvala (3):
  runner: Don't override more results than requested
  runner: Refactor abort-checking to a helper function
  runner: Use 'abort' as result if a test caused an abort

 runner/executor.c  | 121 +++++++++++++++++++++++++++++++++++++++------
 runner/resultgen.c |   6 +++
 2 files changed, 111 insertions(+), 16 deletions(-)

-- 
2.30.2

             reply	other threads:[~2023-01-26 10:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-26 10:53 Petri Latvala [this message]
2023-01-26 10:53 ` [igt-dev] [PATCH i-g-t 1/3] runner: Don't override more results than requested Petri Latvala
2023-01-26 10:53 ` [igt-dev] [PATCH i-g-t 2/3] runner: Refactor abort-checking to a helper function Petri Latvala
2023-01-26 10:53 ` [igt-dev] [PATCH i-g-t 3/3] runner: Use 'abort' as result if a test caused an abort Petri Latvala
2023-01-26 11:43 ` [igt-dev] ✓ Fi.CI.BAT: success for runner: Using 'abort' as test result instead of a separate test Patchwork
2023-01-26 13:12 ` [igt-dev] [PATCH i-g-t 0/3] " Kamil Konieczny
2023-01-26 13:42   ` Petri Latvala
2023-01-26 17:47 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2023-01-27 11:01   ` Petri Latvala
2023-01-29  9:21     ` Yedireswarapu, SaiX Nandan
2023-01-27 13:27 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230126105338.419418-1-petri.latvala@intel.com \
    --to=petri.latvala@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox