Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Lionel G Landwerlin <lionel.g.landwerlin@linux.intel.com>
Subject: [igt-dev] [PATCH 27/30] lib/perf: Add support for MPEC format
Date: Tue, 14 Feb 2023 13:00:04 -0800	[thread overview]
Message-ID: <20230214210007.2026033-28-umesh.nerlige.ramappa@intel.com> (raw)
In-Reply-To: <20230214210007.2026033-1-umesh.nerlige.ramappa@intel.com>

Add support in perf library for MPEC formats.

Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
 lib/i915/perf.c             | 38 +++++++++++++++++++++++++++++++++++++
 lib/i915/perf_data_reader.c | 14 +++++++++-----
 2 files changed, 47 insertions(+), 5 deletions(-)

diff --git a/lib/i915/perf.c b/lib/i915/perf.c
index 24ef3819..d736490b 100644
--- a/lib/i915/perf.c
+++ b/lib/i915/perf.c
@@ -915,6 +915,34 @@ void intel_perf_accumulate_reports(struct intel_perf_accumulator *acc,
 		for (i = 0; i < 61; i++)
 			accumulate_uint32(start + 3 + i, end + 3 + i, deltas + 1 + i);
 		break;
+
+	case I915_OAM_FORMAT_MPEC8u32_B8_C8: {
+		const uint64_t *start64 = (const uint64_t *)(record0 + 1);
+		const uint64_t *end64 = (const uint64_t *)(record1 + 1);
+
+		/* 64 bit timestamp */
+		if (perf->devinfo.oa_timestamp_shift >= 0)
+			deltas[idx++] += (end64[1] - start64[1]) << perf->devinfo.oa_timestamp_shift;
+		else
+			deltas[idx++] += (end64[1] - start64[1]) >> (-perf->devinfo.oa_timestamp_shift);
+
+		/* 64 bit clock */
+		deltas[idx++] = end64[3] - start64[3];
+
+		/* 8x 32bit MPEC counters */
+		for (i = 0; i < 8; i++)
+			accumulate_uint32(start + 8 + i, end + 8 + i, deltas + idx++);
+
+		/* 8x 32bit B counters */
+		for (i = 0; i < 8; i++)
+			accumulate_uint32(start + 16 + i, end + 16 + i, deltas + idx++);
+
+		/* 8x 32bit C counters */
+		for (i = 0; i < 8; i++)
+			accumulate_uint32(start + 24 + i, end + 24 + i, deltas + idx++);
+
+		break;
+		}
 	default:
 		assert(0);
 	}
@@ -926,6 +954,7 @@ uint64_t intel_perf_read_record_timestamp(const struct intel_perf *perf,
 					  const struct drm_i915_perf_record_header *record)
 {
        const uint32_t *report32 = (const uint32_t *)(record + 1);
+       const uint64_t *report64 = (const uint64_t *)(record + 1);
        uint64_t ts;
 
        switch (metric_set->perf_oa_format) {
@@ -935,6 +964,10 @@ uint64_t intel_perf_read_record_timestamp(const struct intel_perf *perf,
                ts = report32[1];
                break;
 
+       case I915_OAM_FORMAT_MPEC8u32_B8_C8:
+               ts = report64[1];
+               break;
+
        default:
                assert(0);
        }
@@ -952,6 +985,7 @@ uint64_t intel_perf_read_record_timestamp_raw(const struct intel_perf *perf,
 					  const struct drm_i915_perf_record_header *record)
 {
        const uint32_t *report32 = (const uint32_t *)(record + 1);
+       const uint64_t *report64 = (const uint64_t *)(record + 1);
        uint64_t ts;
 
        switch (metric_set->perf_oa_format) {
@@ -961,6 +995,10 @@ uint64_t intel_perf_read_record_timestamp_raw(const struct intel_perf *perf,
                ts = report32[1];
                break;
 
+       case I915_OAM_FORMAT_MPEC8u32_B8_C8:
+               ts = report64[1];
+               break;
+
        default:
                assert(0);
        }
diff --git a/lib/i915/perf_data_reader.c b/lib/i915/perf_data_reader.c
index 10e78e63..332f530e 100644
--- a/lib/i915/perf_data_reader.c
+++ b/lib/i915/perf_data_reader.c
@@ -58,11 +58,15 @@ oa_report_ctx_is_valid(const struct intel_perf_devinfo *devinfo,
 }
 
 static uint32_t
-oa_report_ctx_id(const struct intel_perf_devinfo *devinfo, const uint8_t *report)
+oa_report_ctx_id(struct intel_perf_data_reader *reader, const uint8_t *report)
 {
-	if (!oa_report_ctx_is_valid(devinfo, report))
+	if (!oa_report_ctx_is_valid(&reader->devinfo, report))
 		return 0xffffffff;
-	return ((const uint32_t *) report)[2];
+
+	if (reader->metric_set->perf_oa_format == I915_OAM_FORMAT_MPEC8u32_B8_C8)
+		return ((const uint32_t *) report)[4];
+	else
+		return ((const uint32_t *) report)[2];
 }
 
 static void
@@ -289,8 +293,8 @@ generate_cpu_events(struct intel_perf_data_reader *reader)
 		start_report = (const uint8_t *) (last_header + 1);
 		end_report = (const uint8_t *) (current_header + 1);
 
-		last_ctx_id = oa_report_ctx_id(&reader->devinfo, start_report);
-		current_ctx_id = oa_report_ctx_id(&reader->devinfo, end_report);
+		last_ctx_id = oa_report_ctx_id(reader, start_report);
+		current_ctx_id = oa_report_ctx_id(reader, end_report);
 
 		gpu_ts_start = intel_perf_read_record_timestamp(reader->perf,
 								reader->metric_set,
-- 
2.36.1

  parent reply	other threads:[~2023-02-14 21:00 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14 20:59 [igt-dev] [PATCH 00/30] Enable OAM support in IGT and GPUvis Umesh Nerlige Ramappa
2023-02-14 20:59 ` [igt-dev] [PATCH 01/30] i915/perf: Add support for 64-bit OA formats Umesh Nerlige Ramappa
2023-02-14 20:59 ` [igt-dev] [PATCH 02/30] i915/perf: Define a default engine for OA Umesh Nerlige Ramappa
2023-02-14 20:59 ` [igt-dev] [PATCH 03/30] i915/perf: Use default engine for sseu tests Umesh Nerlige Ramappa
2023-02-14 20:59 ` [igt-dev] [PATCH 04/30] i915/perf: Ensure rcs0 is present for gen12-mi-rpc Umesh Nerlige Ramappa
2023-02-14 20:59 ` [igt-dev] [PATCH 05/30] i915/perf: Use ARRAY_SIZE for buffer-fill test Umesh Nerlige Ramappa
2023-02-14 20:59 ` [igt-dev] [PATCH 06/30] i915/perf: Add class:instance support to OA tests Umesh Nerlige Ramappa
2023-02-14 20:59 ` [igt-dev] [PATCH 07/30] i915/perf: Enable tests to run on specific engines Umesh Nerlige Ramappa
2023-02-14 20:59 ` [igt-dev] [PATCH 08/30] i915/perf: Treat ticks as 64 bit Umesh Nerlige Ramappa
2023-02-14 20:59 ` [igt-dev] [PATCH 09/30] i915/perf: Treat timestamp as 64 bit value Umesh Nerlige Ramappa
2023-02-14 20:59 ` [igt-dev] [PATCH 10/30] i915/perf: Add OAM format type Umesh Nerlige Ramappa
2023-02-14 20:59 ` [igt-dev] [PATCH 11/30] i915/perf: Use a helper for OA format Umesh Nerlige Ramappa
2023-02-14 20:59 ` [igt-dev] [PATCH 12/30] i915/perf: Add support for oa perf groups Umesh Nerlige Ramappa
2023-02-14 20:59 ` [igt-dev] [PATCH 13/30] i915/perf: Test concurrent access to OA in different groups Umesh Nerlige Ramappa
2023-02-14 20:59 ` [igt-dev] [PATCH 14/30] i915/perf: Add OAM support Umesh Nerlige Ramappa
2023-02-14 20:59 ` [igt-dev] [PATCH 15/30] lib/perf: Make chipsets aware of oa formats Umesh Nerlige Ramappa
2023-02-14 20:59 ` [igt-dev] [PATCH 16/30] i915/perf: Choose OAM format for media metrics Umesh Nerlige Ramappa
2023-02-14 20:59 ` [igt-dev] [PATCH 17/30] lib/perf" Set missing metric unit for some counters Umesh Nerlige Ramappa
2023-02-14 20:59 ` [igt-dev] [PATCH 18/30] lib/perf: Add MTL to supprted HW in oa guid registry Umesh Nerlige Ramappa
2023-02-14 20:59 ` [igt-dev] [PATCH 19/30] lib/perf: Add support for OAM format in codegen Umesh Nerlige Ramappa
2023-02-14 20:59 ` [igt-dev] [PATCH 20/30] lib/perf: Update MTL GT2 metrics for OAM Umesh Nerlige Ramappa
2023-02-14 20:59 ` [igt-dev] [PATCH 21/30] lib/perf: Update MTL GT3 " Umesh Nerlige Ramappa
2023-02-14 20:59 ` [igt-dev] [PATCH 22/30] i915/perf: Add support for engine specific metrics Umesh Nerlige Ramappa
2023-02-14 21:00 ` [igt-dev] [PATCH 23/30] i915/perf: Run non-zero-reason on media engines as well Umesh Nerlige Ramappa
2023-02-14 21:00 ` [igt-dev] [PATCH 24/30] i915/perf: Make sanity check failures descriptive Umesh Nerlige Ramappa
2023-02-14 21:00 ` [igt-dev] [PATCH 25/30] lib/perf: Enable multi-tile support for perf library Umesh Nerlige Ramappa
2023-02-14 21:00 ` [igt-dev] [PATCH 26/30] lib/perf: Update MTL OA timestamp and EU thread config Umesh Nerlige Ramappa
2023-02-14 21:00 ` Umesh Nerlige Ramappa [this message]
2023-02-14 21:00 ` [igt-dev] [PATCH 28/30] lib/perf: Adjust the GPU timestamp for new OA formats Umesh Nerlige Ramappa
2023-02-14 21:00 ` [igt-dev] [PATCH 29/30] tools/perf: Choose the right card Umesh Nerlige Ramappa
2023-02-14 21:00 ` [igt-dev] [PATCH 30/30] lib/perf: Apply shift to raw timestamp as well Umesh Nerlige Ramappa
2023-02-14 21:18 ` [igt-dev] ✗ GitLab.Pipeline: warning for Enable OAM support in IGT and GPUvis Patchwork
2023-02-14 21:47 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-02-15  0:48 ` [igt-dev] [PATCH 00/30] " Umesh Nerlige Ramappa
2023-02-15  7:22 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230214210007.2026033-28-umesh.nerlige.ramappa@intel.com \
    --to=umesh.nerlige.ramappa@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=lionel.g.landwerlin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox