From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [i-g-t v8 33/51] tests/kms_universal_plane: Add support for Bigjoiner
Date: Thu, 23 Feb 2023 20:40:00 +0530 [thread overview]
Message-ID: <20230223151018.2565040-34-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230223151018.2565040-1-bhanuprakash.modem@intel.com>
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Ananya Sharma <ananya.sharma@intel.com>
---
tests/kms_universal_plane.c | 94 +++++++++++++++++++++++++++++++++----
1 file changed, 84 insertions(+), 10 deletions(-)
diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
index dd8fa1937..2a9eb021f 100644
--- a/tests/kms_universal_plane.c
+++ b/tests/kms_universal_plane.c
@@ -381,6 +381,9 @@ sanity_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
igt_require_pipe(&data->display, pipe);
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
igt_output_set_pipe(output, pipe);
mode = igt_output_get_mode(output);
@@ -494,6 +497,9 @@ pageflip_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
igt_require_pipe(&data->display, pipe);
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
igt_output_set_pipe(output, pipe);
pageflip_test_init(&test, output, pipe);
@@ -604,6 +610,9 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
igt_require(display->has_cursor_plane);
igt_require_intel(data->drm_fd);
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
igt_output_set_pipe(output, pipe);
mode = igt_output_get_mode(output);
@@ -731,6 +740,9 @@ pageflip_win_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
igt_skip_on(is_i915_device(data->drm_fd) && data->display_ver < 9);
igt_require_pipe(&data->display, pipe);
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
igt_output_set_pipe(output, pipe);
gen9_test_init(&test, output, pipe);
@@ -766,6 +778,22 @@ pageflip_win_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
gen9_test_fini(&test, output);
}
+static bool
+pipe_output_combo_valid(igt_display_t *display,
+ enum pipe pipe, igt_output_t *output)
+{
+ bool ret = true;
+
+ igt_display_reset(display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ ret = false;
+ igt_output_set_pipe(output, PIPE_NONE);
+
+ return ret;
+}
+
static void
run_tests_for_pipe(data_t *data, enum pipe pipe)
{
@@ -784,34 +812,79 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)
igt_describe("Check the switching between different primary plane fbs with CRTC off");
igt_subtest_f("universal-plane-pipe-%s-functional",
- kmstest_pipe_name(pipe))
- for_each_valid_output_on_pipe(&data->display, pipe, output)
+ kmstest_pipe_name(pipe)) {
+ bool found = false;
+
+ for_each_valid_output_on_pipe(&data->display, pipe, output) {
+ if (!pipe_output_combo_valid(&data->display, pipe, output))
+ continue;
+
+ found = true;
functional_test_pipe(data, pipe, output);
+ }
+ igt_require_f(found, "No valid pipe/output combo found.\n");
+ }
igt_describe("Test for scale-up or scale-down using universal plane API without covering CRTC");
igt_subtest_f("universal-plane-pipe-%s-sanity",
- kmstest_pipe_name(pipe))
- for_each_valid_output_on_pipe(&data->display, pipe, output)
+ kmstest_pipe_name(pipe)) {
+ bool found = false;
+
+ for_each_valid_output_on_pipe(&data->display, pipe, output) {
+ if (!pipe_output_combo_valid(&data->display, pipe, output))
+ continue;
+
+ found = true;
sanity_test_pipe(data, pipe, output);
+ }
+ igt_require_f(found, "No valid pipe/output combo found.\n");
+ }
igt_describe("Check pageflips while primary plane is disabled before IOCTL or between IOCTL"
" and pageflip execution");
igt_subtest_f("disable-primary-vs-flip-pipe-%s",
- kmstest_pipe_name(pipe))
- for_each_valid_output_on_pipe(&data->display, pipe, output)
+ kmstest_pipe_name(pipe)) {
+ bool found = false;
+
+ for_each_valid_output_on_pipe(&data->display, pipe, output) {
+ if (!pipe_output_combo_valid(&data->display, pipe, output))
+ continue;
+
+ found = true;
pageflip_test_pipe(data, pipe, output);
+ }
+ igt_require_f(found, "No valid pipe/output combo found.\n");
+ }
igt_describe("Check for cursor leaks after performing cursor operations");
igt_subtest_f("cursor-fb-leak-pipe-%s",
- kmstest_pipe_name(pipe))
- for_each_valid_output_on_pipe(&data->display, pipe, output)
+ kmstest_pipe_name(pipe)) {
+ bool found = false;
+
+ for_each_valid_output_on_pipe(&data->display, pipe, output) {
+ if (!pipe_output_combo_valid(&data->display, pipe, output))
+ continue;
+
+ found = true;
cursor_leak_test_pipe(data, pipe, output);
+ }
+ igt_require_f(found, "No valid pipe/output combo found.\n");
+ }
igt_describe("Check if pageflip succeeds in windowed setting");
igt_subtest_f("universal-plane-pageflip-windowed-pipe-%s",
- kmstest_pipe_name(pipe))
- for_each_valid_output_on_pipe(&data->display, pipe, output)
+ kmstest_pipe_name(pipe)) {
+ bool found = false;
+
+ for_each_valid_output_on_pipe(&data->display, pipe, output) {
+ if (!pipe_output_combo_valid(&data->display, pipe, output))
+ continue;
+
+ found = true;
pageflip_win_test_pipe(data, pipe, output);
+ }
+ igt_require_f(found, "No valid pipe/output combo found.\n");
+ }
}
static data_t data;
@@ -829,6 +902,7 @@ igt_main
igt_require_pipe_crc(data.drm_fd);
igt_display_require(&data.display, data.drm_fd);
+ igt_display_require_output(&data.display);
}
for_each_pipe_static(pipe) {
--
2.39.1
next prev parent reply other threads:[~2023-02-23 15:16 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 15:09 [igt-dev] [i-g-t v8 00/51] Add IGT support for Bigjoiner Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 01/51] lib/igt_kms: Add a helper for valid pipe/output constraint Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 02/51] lib/igt_kms: Bigjoiner check in max_bpc constraint Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 03/51] tests/kms_async_flips: Add support for Bigjoiner Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 04/51] tests/kms_atomic: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 05/51] tests/kms_atomic_interruptible: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 06/51] tests/kms_atomic_transition: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 07/51] tests/kms_color_helper: Helper to check Bigjoiner constraint Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 08/51] tests/kms_color: Add support for Bigjoiner Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 09/51] tests/chamelium/kms_color_chamelium: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 10/51] tests/kms_content_protection: " Bhanuprakash Modem
2023-03-17 6:31 ` Karthik B S
2023-03-17 6:33 ` Modem, Bhanuprakash
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 11/51] tests/kms_concurrent: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 12/51] tests/kms_cursor_crc: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 13/51] tests/kms_cursor_edge_walk: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 14/51] tests/kms_cursor_legacy: " Bhanuprakash Modem
2023-03-16 9:44 ` [igt-dev] [i-g-t V9 " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 15/51] tests/kms_display_modes: " Bhanuprakash Modem
2023-03-20 10:24 ` B, Jeevan
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 16/51] tests/kms_dp_tiled_display: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 17/51] tests/kms_flip_event_leak: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 18/51] tests/kms_invalid_mode: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 19/51] tests/kms_lease: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 20/51] tests/kms_pipe_crc_basic: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 21/51] tests/kms_plane: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 22/51] tests/kms_plane_alpha_blend: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 23/51] tests/kms_plane_cursor: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 24/51] tests/kms_plane_lowres: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 25/51] tests/kms_plane_multiple: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 26/51] tests/kms_plane_scaling: " Bhanuprakash Modem
2023-03-17 5:09 ` [igt-dev] [i-g-t V9 " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 27/51] tests/kms_prime: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 28/51] tests/kms_properties: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 29/51] tests/kms_rmfb: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 30/51] tests/kms_rotation_crc: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 31/51] tests/kms_scaling_modes: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 32/51] tests/kms_sequence: " Bhanuprakash Modem
2023-02-23 15:10 ` Bhanuprakash Modem [this message]
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 34/51] tests/kms_vblank: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 35/51] tests/kms_vrr: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 36/51] tests/i915/kms_big_fb: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 37/51] tests/i915/kms_big_joiner: Negative tests " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 38/51] tests/i915/kms_busy: Add support " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 39/51] tests/i915/kms_ccs: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 40/51] tests/i915/kms_cdclk: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 41/51] tests/i915/kms_draw_crc: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 42/51] tests/i915/kms_fence_pin_leak: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 43/51] tests/i915/kms_flip_scaled_crc: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 44/51] tests/i915/kms_flip_tiling: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 45/51] tests/i915/kms_frontbuffer_tracking: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 46/51] tests/i915/kms_mmap_write_crc: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 47/51] tests/i915/kms_psr2_sf: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 48/51] tests/i915/kms_psr2_su: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 49/51] tests/i915/kms_psr: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 50/51] tests/i915/kms_psr_stress_test: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 51/51] tests/i915/kms_pwrite_crc: " Bhanuprakash Modem
2023-02-23 16:33 ` [igt-dev] ✓ Fi.CI.BAT: success for Add IGT support for Bigjoiner (rev21) Patchwork
2023-02-23 20:22 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-03-17 4:12 ` [igt-dev] ✗ Fi.CI.BUILD: failure for Add IGT support for Bigjoiner (rev23) Patchwork
2023-03-17 6:03 ` [igt-dev] ✓ Fi.CI.BAT: success for Add IGT support for Bigjoiner (rev24) Patchwork
2023-03-17 7:28 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230223151018.2565040-34-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox