From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [i-g-t v8 06/51] tests/kms_atomic_transition: Add support for Bigjoiner
Date: Thu, 23 Feb 2023 20:39:33 +0530 [thread overview]
Message-ID: <20230223151018.2565040-7-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230223151018.2565040-1-bhanuprakash.modem@intel.com>
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
tests/kms_atomic_transition.c | 50 ++++++++++++++++++++++++++++++++---
1 file changed, 46 insertions(+), 4 deletions(-)
diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
index 64e7e7091..f428641fa 100644
--- a/tests/kms_atomic_transition.c
+++ b/tests/kms_atomic_transition.c
@@ -68,6 +68,10 @@ run_primary_test(data_t *data, enum pipe pipe, igt_output_t *output)
unsigned flags = DRM_MODE_ATOMIC_TEST_ONLY | DRM_MODE_ATOMIC_ALLOW_MODESET;
igt_display_reset(&data->display);
+
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
igt_output_set_pipe(output, pipe);
primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
@@ -487,6 +491,9 @@ run_transition_test(data_t *data, enum pipe pipe, igt_output_t *output,
unsigned flags = 0;
int ret;
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
if (fencing)
prepare_fencing(data, pipe);
else
@@ -759,8 +766,13 @@ static unsigned set_combinations(data_t *data, unsigned mask, struct igt_fb *fb)
if (output->pending_pipe != PIPE_NONE)
continue;
- mode = igt_output_get_mode(output);
- break;
+ igt_output_set_pipe(output, pipe);
+ if (i915_pipe_output_combo_valid(&data->display)) {
+ mode = igt_output_get_mode(output);
+ break;
+ } else {
+ igt_output_set_pipe(output, PIPE_NONE);
+ }
}
if (!mode)
@@ -845,8 +857,17 @@ retry:
continue;
igt_output_set_pipe(output, i);
- mode = igt_output_get_mode(output);
- break;
+ if (i915_pipe_output_combo_valid(&data->display)) {
+ mode = igt_output_get_mode(output);
+
+ igt_info("(pipe %s + %s), mode:",
+ kmstest_pipe_name(i), igt_output_name(output));
+ kmstest_dump_mode(mode);
+
+ break;
+ } else {
+ igt_output_set_pipe(output, PIPE_NONE);
+ }
}
if (mode) {
@@ -984,6 +1005,21 @@ static void run_modeset_transition(data_t *data, int requested_outputs, bool non
igt_remove_fb(data->drm_fd, &data->fbs[1]);
}
+static bool pipe_output_combo_valid(igt_display_t *display,
+ enum pipe pipe, igt_output_t *output)
+{
+ bool ret = true;
+
+ igt_display_reset(display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ ret = false;
+ igt_output_set_pipe(output, PIPE_NONE);
+
+ return ret;
+}
+
static int opt_handler(int opt, int opt_index, void *_data)
{
data_t *data = _data;
@@ -1083,6 +1119,9 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
if (pipe_count == 2 * count && !data.extended)
break;
+ if (!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
+
pipe_count++;
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output))
run_primary_test(&data, pipe, output);
@@ -1112,6 +1151,9 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
if (pipe_count == 2 * count && !data.extended)
break;
+ if (!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
+
pipe_count++;
igt_dynamic_f("pipe-%s-%s",
kmstest_pipe_name(pipe),
--
2.39.1
next prev parent reply other threads:[~2023-02-23 15:15 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 15:09 [igt-dev] [i-g-t v8 00/51] Add IGT support for Bigjoiner Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 01/51] lib/igt_kms: Add a helper for valid pipe/output constraint Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 02/51] lib/igt_kms: Bigjoiner check in max_bpc constraint Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 03/51] tests/kms_async_flips: Add support for Bigjoiner Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 04/51] tests/kms_atomic: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 05/51] tests/kms_atomic_interruptible: " Bhanuprakash Modem
2023-02-23 15:09 ` Bhanuprakash Modem [this message]
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 07/51] tests/kms_color_helper: Helper to check Bigjoiner constraint Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 08/51] tests/kms_color: Add support for Bigjoiner Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 09/51] tests/chamelium/kms_color_chamelium: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 10/51] tests/kms_content_protection: " Bhanuprakash Modem
2023-03-17 6:31 ` Karthik B S
2023-03-17 6:33 ` Modem, Bhanuprakash
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 11/51] tests/kms_concurrent: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 12/51] tests/kms_cursor_crc: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 13/51] tests/kms_cursor_edge_walk: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 14/51] tests/kms_cursor_legacy: " Bhanuprakash Modem
2023-03-16 9:44 ` [igt-dev] [i-g-t V9 " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 15/51] tests/kms_display_modes: " Bhanuprakash Modem
2023-03-20 10:24 ` B, Jeevan
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 16/51] tests/kms_dp_tiled_display: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 17/51] tests/kms_flip_event_leak: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 18/51] tests/kms_invalid_mode: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 19/51] tests/kms_lease: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 20/51] tests/kms_pipe_crc_basic: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 21/51] tests/kms_plane: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 22/51] tests/kms_plane_alpha_blend: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 23/51] tests/kms_plane_cursor: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 24/51] tests/kms_plane_lowres: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 25/51] tests/kms_plane_multiple: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 26/51] tests/kms_plane_scaling: " Bhanuprakash Modem
2023-03-17 5:09 ` [igt-dev] [i-g-t V9 " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 27/51] tests/kms_prime: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 28/51] tests/kms_properties: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 29/51] tests/kms_rmfb: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 30/51] tests/kms_rotation_crc: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 31/51] tests/kms_scaling_modes: " Bhanuprakash Modem
2023-02-23 15:09 ` [igt-dev] [i-g-t v8 32/51] tests/kms_sequence: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 33/51] tests/kms_universal_plane: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 34/51] tests/kms_vblank: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 35/51] tests/kms_vrr: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 36/51] tests/i915/kms_big_fb: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 37/51] tests/i915/kms_big_joiner: Negative tests " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 38/51] tests/i915/kms_busy: Add support " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 39/51] tests/i915/kms_ccs: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 40/51] tests/i915/kms_cdclk: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 41/51] tests/i915/kms_draw_crc: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 42/51] tests/i915/kms_fence_pin_leak: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 43/51] tests/i915/kms_flip_scaled_crc: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 44/51] tests/i915/kms_flip_tiling: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 45/51] tests/i915/kms_frontbuffer_tracking: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 46/51] tests/i915/kms_mmap_write_crc: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 47/51] tests/i915/kms_psr2_sf: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 48/51] tests/i915/kms_psr2_su: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 49/51] tests/i915/kms_psr: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 50/51] tests/i915/kms_psr_stress_test: " Bhanuprakash Modem
2023-02-23 15:10 ` [igt-dev] [i-g-t v8 51/51] tests/i915/kms_pwrite_crc: " Bhanuprakash Modem
2023-02-23 16:33 ` [igt-dev] ✓ Fi.CI.BAT: success for Add IGT support for Bigjoiner (rev21) Patchwork
2023-02-23 20:22 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-03-17 4:12 ` [igt-dev] ✗ Fi.CI.BUILD: failure for Add IGT support for Bigjoiner (rev23) Patchwork
2023-03-17 6:03 ` [igt-dev] ✓ Fi.CI.BAT: success for Add IGT support for Bigjoiner (rev24) Patchwork
2023-03-17 7:28 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230223151018.2565040-7-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox