Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_plane: add invalid pixel format tests
@ 2023-02-27 11:34 Juha-Pekka Heikkila
  2023-02-27 13:29 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: Juha-Pekka Heikkila @ 2023-02-27 11:34 UTC (permalink / raw)
  To: igt-dev

Test settings for pixel formats which are not supposing to be accepted.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 tests/kms_plane.c | 52 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 164dacf40..631531284 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -1125,6 +1125,54 @@ test_pixel_formats(data_t *data, enum pipe pipe)
 	igt_assert_f(result, "At least one CRC mismatch happened\n");
 }
 
+static void test_invalid_settings(data_t *data)
+{
+	enum pipe pipe = PIPE_A;
+	igt_output_t *output;
+	igt_fb_t fb;
+	igt_plane_t *primary;
+	int rval;
+
+	/*
+	 * If here is added non-intel tests below require will need to be
+	 * changed to if(..)
+	 */
+	igt_require_intel(data->drm_fd);
+	igt_require(intel_display_ver(intel_get_drm_devid(data->drm_fd)) >= 9);
+
+	output = igt_get_single_output_for_pipe(&data->display, pipe);
+	igt_require(output);
+
+	igt_output_set_pipe(output, pipe);
+	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+
+	igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
+
+	/* test against intel_plane_check_src_coordinates() in i915 */
+	if (igt_plane_has_format_mod(primary, DRM_FORMAT_NV12,
+				     DRM_FORMAT_MOD_LINEAR)) {
+		igt_create_fb(data->drm_fd, 257, 256,
+			      DRM_FORMAT_NV12, DRM_FORMAT_MOD_LINEAR, &fb);
+		igt_plane_set_fb(primary, &fb);
+		rval = igt_display_try_commit_atomic(&data->display, 0, NULL);
+		igt_remove_fb(data->drm_fd, &fb);
+		igt_assert_f(rval == -EINVAL, "Odd width NV12 framebuffer\n");
+	} else
+		igt_debug("Odd width NV12 framebuffer test skipped\n");
+
+	/* test against intel_plane_check_src_coordinates() in i915 */
+	if (igt_plane_has_format_mod(primary, DRM_FORMAT_NV12,
+				     DRM_FORMAT_MOD_LINEAR)) {
+		igt_create_fb(data->drm_fd, 256, 257,
+			      DRM_FORMAT_NV12, DRM_FORMAT_MOD_LINEAR, &fb);
+		igt_plane_set_fb(primary, &fb);
+		rval = igt_display_try_commit_atomic(&data->display, 0, NULL);
+		igt_remove_fb(data->drm_fd, &fb);
+		igt_assert_f(rval == -EINVAL, "Odd height NV12 framebuffer\n");
+	} else
+		igt_debug("Odd height NV12 framebuffer test skipped\n");
+}
+
 static bool is_pipe_limit_reached(int count) {
 	return count >= CRTC_RESTRICT_CNT && !all_pipes;
 }
@@ -1194,6 +1242,10 @@ run_tests_for_pipe_plane(data_t *data)
 		data->flags = TEST_PANNING_BOTTOM_RIGHT | TEST_SUSPEND_RESUME;
 		run_test(data, test_plane_panning);
 	}
+
+	igt_describe("verify invalid settings for pixel format are not accepted");
+	igt_subtest_f("invalid-pixel-format-settings")
+		test_invalid_settings(data);
 }
 
 static int opt_handler(int opt, int opt_index, void *_data)
-- 
2.39.0

^ permalink raw reply related	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-03-07  9:48 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-27 11:34 [igt-dev] [PATCH i-g-t] tests/kms_plane: add invalid pixel format tests Juha-Pekka Heikkila
2023-02-27 13:29 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-02-27 17:21 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-02-27 22:30 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane: add invalid pixel format tests (rev2) Patchwork
2023-02-28  3:58 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-02-28  5:58 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane: add invalid pixel format tests (rev3) Patchwork
2023-02-28  9:35 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-03-01 12:04 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane: add invalid pixel format tests (rev4) Patchwork
2023-03-01 13:53 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-03-07  9:48 ` [igt-dev] [PATCH i-g-t] tests/kms_plane: add invalid pixel format tests Govindapillai, Vinod

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox