[igt-dev] [i-g-t 0/5] Add basic helpers to support display in XE

[igt-dev] [i-g-t 0/5] Add basic helpers to support display in XE

[Bhanuprakash Modem]

Add basic helpers to enbale the display in XE.

This series includes:
- XE device detection
- s/igt_require_intel/igt_require_i915/
- Cache dev_id

Bhanuprakash Modem (5):
  lib/drmtest: Add helpers to check and require the XE driver
  i915: s/igt_require_intel/igt_require_i915
  lib/xe/xe_query: Add dev_id() interface
  lib/intel_chipset: Add support to XE driver to get devid
  lib/igt_kms: Cache xe_device info for kms tests

 lib/drmtest.c       | 20 ++++++++++++++++++++
 lib/drmtest.h       |  4 ++++
 lib/i915/gem.c      |  2 +-
 lib/igt_fb.c        |  6 +++---
 lib/igt_kms.c       | 10 +++++++++-
 lib/intel_chipset.c | 30 ++++++++++++++++++++----------
 lib/xe/xe_query.c   |  9 +++++++++
 lib/xe/xe_query.h   |  4 ++++
 tests/i915/perf.c   |  2 +-
 9 files changed, 71 insertions(+), 16 deletions(-)

--
2.39.1

[igt-dev] [i-g-t 1/5] lib/drmtest: Add helpers to check and require the XE driver

[Bhanuprakash Modem]

In order to add support for features specific to the XE driver, add
helpers for checking and requiring the driver.

This patch will also update igt_require_intel() to support XE, and
create new helper igt_require_i915() as both i915 & XE belongs to
intel.

Credits-to: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 lib/drmtest.c | 20 ++++++++++++++++++++
 lib/drmtest.h |  4 ++++
 2 files changed, 24 insertions(+)

diff --git a/lib/drmtest.c b/lib/drmtest.c
index 0ceab1038..ef0d4909f 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -139,6 +139,16 @@ bool is_vc4_device(int fd)
 	return __is_device(fd, "vc4");
 }
 
+bool is_xe_device(int fd)
+{
+	return __is_device(fd, "xe");
+}
+
+bool is_intel_device(int fd)
+{
+	return is_i915_device(fd) || is_xe_device(fd);
+}
+
 static char _forced_driver[16] = "";
 
 /**
@@ -645,6 +655,11 @@ void igt_require_amdgpu(int fd)
 }
 
 void igt_require_intel(int fd)
+{
+	igt_require(is_i915_device(fd) || is_xe_device(fd));
+}
+
+void igt_require_i915(int fd)
 {
 	igt_require(is_i915_device(fd));
 }
@@ -658,3 +673,8 @@ void igt_require_vc4(int fd)
 {
 	igt_require(is_vc4_device(fd));
 }
+
+void igt_require_xe(int fd)
+{
+	igt_require(is_xe_device(fd));
+}
diff --git a/lib/drmtest.h b/lib/drmtest.h
index 448ac03b4..392470ac0 100644
--- a/lib/drmtest.h
+++ b/lib/drmtest.h
@@ -99,8 +99,10 @@ int __drm_open_driver_render(int chipset);
 
 void igt_require_amdgpu(int fd);
 void igt_require_intel(int fd);
+void igt_require_i915(int fd);
 void igt_require_nouveau(int fd);
 void igt_require_vc4(int fd);
+void igt_require_xe(int fd);
 
 bool is_amdgpu_device(int fd);
 bool is_i915_device(int fd);
@@ -108,6 +110,8 @@ bool is_mtk_device(int fd);
 bool is_msm_device(int fd);
 bool is_nouveau_device(int fd);
 bool is_vc4_device(int fd);
+bool is_xe_device(int fd);
+bool is_intel_device(int fd);
 
 /**
  * do_or_die:
-- 
2.39.1

Re: [igt-dev] [i-g-t 1/5] lib/drmtest: Add helpers to check and require the XE driver

[Zbigniew Kempczyński]

On Tue, Mar 14, 2023 at 04:24:48PM +0530, Bhanuprakash Modem wrote:
> In order to add support for features specific to the XE driver, add
> helpers for checking and requiring the driver.
> 
> This patch will also update igt_require_intel() to support XE, and
> create new helper igt_require_i915() as both i915 & XE belongs to
> intel.
> 
> Credits-to: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>  lib/drmtest.c | 20 ++++++++++++++++++++
>  lib/drmtest.h |  4 ++++
>  2 files changed, 24 insertions(+)
> 
> diff --git a/lib/drmtest.c b/lib/drmtest.c
> index 0ceab1038..ef0d4909f 100644
> --- a/lib/drmtest.c
> +++ b/lib/drmtest.c
> @@ -139,6 +139,16 @@ bool is_vc4_device(int fd)
>  	return __is_device(fd, "vc4");
>  }
>  
> +bool is_xe_device(int fd)
> +{
> +	return __is_device(fd, "xe");
> +}
> +
> +bool is_intel_device(int fd)
> +{
> +	return is_i915_device(fd) || is_xe_device(fd);
> +}
> +
>  static char _forced_driver[16] = "";
>  
>  /**
> @@ -645,6 +655,11 @@ void igt_require_amdgpu(int fd)
>  }
>  
>  void igt_require_intel(int fd)
> +{
> +	igt_require(is_i915_device(fd) || is_xe_device(fd));
> +}
> +
> +void igt_require_i915(int fd)
>  {
>  	igt_require(is_i915_device(fd));
>  }
> @@ -658,3 +673,8 @@ void igt_require_vc4(int fd)
>  {
>  	igt_require(is_vc4_device(fd));
>  }
> +
> +void igt_require_xe(int fd)
> +{
> +	igt_require(is_xe_device(fd));
> +}
> diff --git a/lib/drmtest.h b/lib/drmtest.h
> index 448ac03b4..392470ac0 100644
> --- a/lib/drmtest.h
> +++ b/lib/drmtest.h
> @@ -99,8 +99,10 @@ int __drm_open_driver_render(int chipset);
>  
>  void igt_require_amdgpu(int fd);
>  void igt_require_intel(int fd);
> +void igt_require_i915(int fd);
>  void igt_require_nouveau(int fd);
>  void igt_require_vc4(int fd);
> +void igt_require_xe(int fd);
>  
>  bool is_amdgpu_device(int fd);
>  bool is_i915_device(int fd);
> @@ -108,6 +110,8 @@ bool is_mtk_device(int fd);
>  bool is_msm_device(int fd);
>  bool is_nouveau_device(int fd);
>  bool is_vc4_device(int fd);
> +bool is_xe_device(int fd);
> +bool is_intel_device(int fd);
>  
>  /**
>   * do_or_die:
> -- 
> 2.39.1
>

LGTM

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>

--
Zbigniew

Re: [igt-dev] [i-g-t 1/5] lib/drmtest: Add helpers to check and require the XE driver

[Mauro Carvalho Chehab]

On Tue, 14 Mar 2023 16:24:48 +0530
Bhanuprakash Modem <bhanuprakash.modem@intel.com> wrote:

> In order to add support for features specific to the XE driver, add
> helpers for checking and requiring the driver.
> 
> This patch will also update igt_require_intel() to support XE, and
> create new helper igt_require_i915() as both i915 & XE belongs to
> intel.
> 
> Credits-to: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>  lib/drmtest.c | 20 ++++++++++++++++++++
>  lib/drmtest.h |  4 ++++
>  2 files changed, 24 insertions(+)
> 
> diff --git a/lib/drmtest.c b/lib/drmtest.c
> index 0ceab1038..ef0d4909f 100644
> --- a/lib/drmtest.c
> +++ b/lib/drmtest.c
> @@ -139,6 +139,16 @@ bool is_vc4_device(int fd)
>  	return __is_device(fd, "vc4");
>  }
>  
> +bool is_xe_device(int fd)
> +{
> +	return __is_device(fd, "xe");
> +}
> +
> +bool is_intel_device(int fd)
> +{
> +	return is_i915_device(fd) || is_xe_device(fd);
> +}
> +
>  static char _forced_driver[16] = "";
>  
>  /**
> @@ -645,6 +655,11 @@ void igt_require_amdgpu(int fd)
>  }
>  
>  void igt_require_intel(int fd)
> +{
> +	igt_require(is_i915_device(fd) || is_xe_device(fd));

I would code it as:

	igt_require(is_intel_device(fd))

With that:

Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>

> +}
> +
> +void igt_require_i915(int fd)
>  {
>  	igt_require(is_i915_device(fd));
>  }
> @@ -658,3 +673,8 @@ void igt_require_vc4(int fd)
>  {
>  	igt_require(is_vc4_device(fd));
>  }
> +
> +void igt_require_xe(int fd)
> +{
> +	igt_require(is_xe_device(fd));
> +}
> diff --git a/lib/drmtest.h b/lib/drmtest.h
> index 448ac03b4..392470ac0 100644
> --- a/lib/drmtest.h
> +++ b/lib/drmtest.h
> @@ -99,8 +99,10 @@ int __drm_open_driver_render(int chipset);
>  
>  void igt_require_amdgpu(int fd);
>  void igt_require_intel(int fd);
> +void igt_require_i915(int fd);
>  void igt_require_nouveau(int fd);
>  void igt_require_vc4(int fd);
> +void igt_require_xe(int fd);
>  
>  bool is_amdgpu_device(int fd);
>  bool is_i915_device(int fd);
> @@ -108,6 +110,8 @@ bool is_mtk_device(int fd);
>  bool is_msm_device(int fd);
>  bool is_nouveau_device(int fd);
>  bool is_vc4_device(int fd);
> +bool is_xe_device(int fd);
> +bool is_intel_device(int fd);
>  
>  /**
>   * do_or_die:

[igt-dev] [i-g-t 2/5] i915: s/igt_require_intel/igt_require_i915

[Bhanuprakash Modem]

Update to use the i915 specific helper.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 lib/i915/gem.c    | 2 +-
 lib/igt_fb.c      | 6 +++---
 lib/igt_kms.c     | 2 +-
 tests/i915/perf.c | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/lib/i915/gem.c b/lib/i915/gem.c
index 27b872c28..ed45a9ed5 100644
--- a/lib/i915/gem.c
+++ b/lib/i915/gem.c
@@ -140,7 +140,7 @@ void igt_require_gem(int i915)
 {
 	int err;
 
-	igt_require_intel(i915);
+	igt_require_i915(i915);
 
 	/*
 	 * We only want to use the throttle-ioctl for its -EIO reporting
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index ed4623139..ba89e1f60 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -442,7 +442,7 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
 		*height_ret = 1;
 		break;
 	case I915_FORMAT_MOD_X_TILED:
-		igt_require_intel(fd);
+		igt_require_i915(fd);
 		if (intel_display_ver(intel_get_drm_devid(fd)) == 2) {
 			*width_ret = 128;
 			*height_ret = 16;
@@ -460,7 +460,7 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
 	case I915_FORMAT_MOD_4_TILED_DG2_RC_CCS:
 	case I915_FORMAT_MOD_4_TILED_DG2_MC_CCS:
 	case I915_FORMAT_MOD_4_TILED_DG2_RC_CCS_CC:
-		igt_require_intel(fd);
+		igt_require_i915(fd);
 		if (intel_display_ver(intel_get_drm_devid(fd)) == 2) {
 			*width_ret = 128;
 			*height_ret = 16;
@@ -474,7 +474,7 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
 		break;
 	case I915_FORMAT_MOD_Yf_TILED:
 	case I915_FORMAT_MOD_Yf_TILED_CCS:
-		igt_require_intel(fd);
+		igt_require_i915(fd);
 		switch (fb_bpp) {
 		case 8:
 			*width_ret = 64;
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 8c7dd85b8..84091d5ce 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1458,7 +1458,7 @@ bool kmstest_force_connector(int drm_fd, drmModeConnector *connector,
 	 * Forcing DP connectors doesn't currently work, so
 	 * fail early to allow the test to skip if required.
 	 */
-	if (is_i915_device(drm_fd) &&
+	if (is_intel_device(drm_fd) &&
 	    connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort)
 		return false;
 
diff --git a/tests/i915/perf.c b/tests/i915/perf.c
index 6453354cf..edb922c75 100644
--- a/tests/i915/perf.c
+++ b/tests/i915/perf.c
@@ -4946,7 +4946,7 @@ test_i915_ref_count(void)
 	igt_debug("baseline ref count (drm fd closed) = %u\n", baseline);
 
 	drm_fd = __drm_open_driver(DRIVER_INTEL);
-	igt_require_intel(drm_fd);
+	igt_require_i915(drm_fd);
 	devid = intel_get_drm_devid(drm_fd);
 	sysfs = perf_sysfs_open(drm_fd);
 
-- 
2.39.1

Re: [igt-dev] [i-g-t 2/5] i915: s/igt_require_intel/igt_require_i915

[Zbigniew Kempczyński]

On Tue, Mar 14, 2023 at 04:24:49PM +0530, Bhanuprakash Modem wrote:
> Update to use the i915 specific helper.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>

Looks good too:

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>

--
Zbigniew

> ---
>  lib/i915/gem.c    | 2 +-
>  lib/igt_fb.c      | 6 +++---
>  lib/igt_kms.c     | 2 +-
>  tests/i915/perf.c | 2 +-
>  4 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/i915/gem.c b/lib/i915/gem.c
> index 27b872c28..ed45a9ed5 100644
> --- a/lib/i915/gem.c
> +++ b/lib/i915/gem.c
> @@ -140,7 +140,7 @@ void igt_require_gem(int i915)
>  {
>  	int err;
>  
> -	igt_require_intel(i915);
> +	igt_require_i915(i915);
>  
>  	/*
>  	 * We only want to use the throttle-ioctl for its -EIO reporting
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index ed4623139..ba89e1f60 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -442,7 +442,7 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
>  		*height_ret = 1;
>  		break;
>  	case I915_FORMAT_MOD_X_TILED:
> -		igt_require_intel(fd);
> +		igt_require_i915(fd);
>  		if (intel_display_ver(intel_get_drm_devid(fd)) == 2) {
>  			*width_ret = 128;
>  			*height_ret = 16;
> @@ -460,7 +460,7 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
>  	case I915_FORMAT_MOD_4_TILED_DG2_RC_CCS:
>  	case I915_FORMAT_MOD_4_TILED_DG2_MC_CCS:
>  	case I915_FORMAT_MOD_4_TILED_DG2_RC_CCS_CC:
> -		igt_require_intel(fd);
> +		igt_require_i915(fd);
>  		if (intel_display_ver(intel_get_drm_devid(fd)) == 2) {
>  			*width_ret = 128;
>  			*height_ret = 16;
> @@ -474,7 +474,7 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
>  		break;
>  	case I915_FORMAT_MOD_Yf_TILED:
>  	case I915_FORMAT_MOD_Yf_TILED_CCS:
> -		igt_require_intel(fd);
> +		igt_require_i915(fd);
>  		switch (fb_bpp) {
>  		case 8:
>  			*width_ret = 64;
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 8c7dd85b8..84091d5ce 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -1458,7 +1458,7 @@ bool kmstest_force_connector(int drm_fd, drmModeConnector *connector,
>  	 * Forcing DP connectors doesn't currently work, so
>  	 * fail early to allow the test to skip if required.
>  	 */
> -	if (is_i915_device(drm_fd) &&
> +	if (is_intel_device(drm_fd) &&
>  	    connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort)
>  		return false;
>  
> diff --git a/tests/i915/perf.c b/tests/i915/perf.c
> index 6453354cf..edb922c75 100644
> --- a/tests/i915/perf.c
> +++ b/tests/i915/perf.c
> @@ -4946,7 +4946,7 @@ test_i915_ref_count(void)
>  	igt_debug("baseline ref count (drm fd closed) = %u\n", baseline);
>  
>  	drm_fd = __drm_open_driver(DRIVER_INTEL);
> -	igt_require_intel(drm_fd);
> +	igt_require_i915(drm_fd);
>  	devid = intel_get_drm_devid(drm_fd);
>  	sysfs = perf_sysfs_open(drm_fd);
>  
> -- 
> 2.39.1
> 

Re: [igt-dev] [i-g-t 2/5] i915: s/igt_require_intel/igt_require_i915

[Mauro Carvalho Chehab]

On Tue, 14 Mar 2023 16:24:49 +0530
Bhanuprakash Modem <bhanuprakash.modem@intel.com> wrote:

> Update to use the i915 specific helper.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>

LGTM, although there are a bunch of tests/kms_* that also use 
igt_require_i915(). Didn't check what of them makes sense for
Xe, if any.

Anyway,

Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org>

> ---
>  lib/i915/gem.c    | 2 +-
>  lib/igt_fb.c      | 6 +++---
>  lib/igt_kms.c     | 2 +-
>  tests/i915/perf.c | 2 +-
>  4 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/i915/gem.c b/lib/i915/gem.c
> index 27b872c28..ed45a9ed5 100644
> --- a/lib/i915/gem.c
> +++ b/lib/i915/gem.c
> @@ -140,7 +140,7 @@ void igt_require_gem(int i915)
>  {
>  	int err;
>  
> -	igt_require_intel(i915);
> +	igt_require_i915(i915);
>  
>  	/*
>  	 * We only want to use the throttle-ioctl for its -EIO reporting
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index ed4623139..ba89e1f60 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -442,7 +442,7 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
>  		*height_ret = 1;
>  		break;
>  	case I915_FORMAT_MOD_X_TILED:
> -		igt_require_intel(fd);
> +		igt_require_i915(fd);
>  		if (intel_display_ver(intel_get_drm_devid(fd)) == 2) {
>  			*width_ret = 128;
>  			*height_ret = 16;
> @@ -460,7 +460,7 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
>  	case I915_FORMAT_MOD_4_TILED_DG2_RC_CCS:
>  	case I915_FORMAT_MOD_4_TILED_DG2_MC_CCS:
>  	case I915_FORMAT_MOD_4_TILED_DG2_RC_CCS_CC:
> -		igt_require_intel(fd);
> +		igt_require_i915(fd);
>  		if (intel_display_ver(intel_get_drm_devid(fd)) == 2) {
>  			*width_ret = 128;
>  			*height_ret = 16;
> @@ -474,7 +474,7 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
>  		break;
>  	case I915_FORMAT_MOD_Yf_TILED:
>  	case I915_FORMAT_MOD_Yf_TILED_CCS:
> -		igt_require_intel(fd);
> +		igt_require_i915(fd);
>  		switch (fb_bpp) {
>  		case 8:
>  			*width_ret = 64;
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 8c7dd85b8..84091d5ce 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -1458,7 +1458,7 @@ bool kmstest_force_connector(int drm_fd, drmModeConnector *connector,
>  	 * Forcing DP connectors doesn't currently work, so
>  	 * fail early to allow the test to skip if required.
>  	 */
> -	if (is_i915_device(drm_fd) &&
> +	if (is_intel_device(drm_fd) &&
>  	    connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort)
>  		return false;
>  
> diff --git a/tests/i915/perf.c b/tests/i915/perf.c
> index 6453354cf..edb922c75 100644
> --- a/tests/i915/perf.c
> +++ b/tests/i915/perf.c
> @@ -4946,7 +4946,7 @@ test_i915_ref_count(void)
>  	igt_debug("baseline ref count (drm fd closed) = %u\n", baseline);
>  
>  	drm_fd = __drm_open_driver(DRIVER_INTEL);
> -	igt_require_intel(drm_fd);
> +	igt_require_i915(drm_fd);
>  	devid = intel_get_drm_devid(drm_fd);
>  	sysfs = perf_sysfs_open(drm_fd);
>  

Re: [igt-dev] [i-g-t 2/5] i915: s/igt_require_intel/igt_require_i915

[Modem, Bhanuprakash]

On Tue-14-03-2023 05:33 pm, Mauro Carvalho Chehab wrote:
> On Tue, 14 Mar 2023 16:24:49 +0530
> Bhanuprakash Modem <bhanuprakash.modem@intel.com> wrote:
> 
>> Update to use the i915 specific helper.
>>
>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> 
> LGTM, although there are a bunch of tests/kms_* that also use
> igt_require_i915(). Didn't check what of them makes sense for
> Xe, if any.

I am planning to address individual kms tests as a separate task.

- Bhanu

> 
> Anyway,
> 
> Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> 
>> ---
>>   lib/i915/gem.c    | 2 +-
>>   lib/igt_fb.c      | 6 +++---
>>   lib/igt_kms.c     | 2 +-
>>   tests/i915/perf.c | 2 +-
>>   4 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/lib/i915/gem.c b/lib/i915/gem.c
>> index 27b872c28..ed45a9ed5 100644
>> --- a/lib/i915/gem.c
>> +++ b/lib/i915/gem.c
>> @@ -140,7 +140,7 @@ void igt_require_gem(int i915)
>>   {
>>   	int err;
>>   
>> -	igt_require_intel(i915);
>> +	igt_require_i915(i915);
>>   
>>   	/*
>>   	 * We only want to use the throttle-ioctl for its -EIO reporting
>> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
>> index ed4623139..ba89e1f60 100644
>> --- a/lib/igt_fb.c
>> +++ b/lib/igt_fb.c
>> @@ -442,7 +442,7 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
>>   		*height_ret = 1;
>>   		break;
>>   	case I915_FORMAT_MOD_X_TILED:
>> -		igt_require_intel(fd);
>> +		igt_require_i915(fd);
>>   		if (intel_display_ver(intel_get_drm_devid(fd)) == 2) {
>>   			*width_ret = 128;
>>   			*height_ret = 16;
>> @@ -460,7 +460,7 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
>>   	case I915_FORMAT_MOD_4_TILED_DG2_RC_CCS:
>>   	case I915_FORMAT_MOD_4_TILED_DG2_MC_CCS:
>>   	case I915_FORMAT_MOD_4_TILED_DG2_RC_CCS_CC:
>> -		igt_require_intel(fd);
>> +		igt_require_i915(fd);
>>   		if (intel_display_ver(intel_get_drm_devid(fd)) == 2) {
>>   			*width_ret = 128;
>>   			*height_ret = 16;
>> @@ -474,7 +474,7 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
>>   		break;
>>   	case I915_FORMAT_MOD_Yf_TILED:
>>   	case I915_FORMAT_MOD_Yf_TILED_CCS:
>> -		igt_require_intel(fd);
>> +		igt_require_i915(fd);
>>   		switch (fb_bpp) {
>>   		case 8:
>>   			*width_ret = 64;
>> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
>> index 8c7dd85b8..84091d5ce 100644
>> --- a/lib/igt_kms.c
>> +++ b/lib/igt_kms.c
>> @@ -1458,7 +1458,7 @@ bool kmstest_force_connector(int drm_fd, drmModeConnector *connector,
>>   	 * Forcing DP connectors doesn't currently work, so
>>   	 * fail early to allow the test to skip if required.
>>   	 */
>> -	if (is_i915_device(drm_fd) &&
>> +	if (is_intel_device(drm_fd) &&
>>   	    connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort)
>>   		return false;
>>   
>> diff --git a/tests/i915/perf.c b/tests/i915/perf.c
>> index 6453354cf..edb922c75 100644
>> --- a/tests/i915/perf.c
>> +++ b/tests/i915/perf.c
>> @@ -4946,7 +4946,7 @@ test_i915_ref_count(void)
>>   	igt_debug("baseline ref count (drm fd closed) = %u\n", baseline);
>>   
>>   	drm_fd = __drm_open_driver(DRIVER_INTEL);
>> -	igt_require_intel(drm_fd);
>> +	igt_require_i915(drm_fd);
>>   	devid = intel_get_drm_devid(drm_fd);
>>   	sysfs = perf_sysfs_open(drm_fd);
>>   

[igt-dev] [i-g-t 3/5] lib/xe/xe_query: Add dev_id() interface

[Bhanuprakash Modem]

Add support to query XE_QUERY_CONFIG_REV_AND_DEVICE_ID.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 lib/xe/xe_query.c | 9 +++++++++
 lib/xe/xe_query.h | 4 ++++
 2 files changed, 13 insertions(+)

diff --git a/lib/xe/xe_query.c b/lib/xe/xe_query.c
index a6926057f..e27d14383 100644
--- a/lib/xe/xe_query.c
+++ b/lib/xe/xe_query.c
@@ -247,6 +247,7 @@ struct xe_device *xe_device_get(int fd)
 	xe_dev->config = xe_query_config_new(fd);
 	xe_dev->number_gt = xe_dev->config->info[XE_QUERY_CONFIG_GT_COUNT];
 	xe_dev->va_bits = xe_dev->config->info[XE_QUERY_CONFIG_VA_BITS];
+	xe_dev->dev_id = xe_dev->config->info[XE_QUERY_CONFIG_REV_AND_DEVICE_ID] & 0xffff;
 	xe_dev->gts = xe_query_gts_new(fd);
 	xe_dev->memory_regions = __memory_regions(xe_dev->gts);
 	xe_dev->hw_engines = xe_query_engines_new(fd, &xe_dev->number_hw_engines);
@@ -465,6 +466,14 @@ xe_dev_FN(xe_supports_faults, supports_faults, bool);
  */
 xe_dev_FN(xe_va_bits, va_bits, uint32_t);
 
+/**
+ * xe_dev_id:
+ * @fd: xe device fd
+ *
+ * Returns Device id of xe device @fd.
+ */
+xe_dev_FN(xe_dev_id, dev_id, uint32_t);
+
 igt_constructor
 {
 	xe_device_cache_init();
diff --git a/lib/xe/xe_query.h b/lib/xe/xe_query.h
index fe1343f61..08cee7e14 100644
--- a/lib/xe/xe_query.h
+++ b/lib/xe/xe_query.h
@@ -58,6 +58,9 @@ struct xe_device {
 
 	/** @va_bits: va length in bits */
 	uint32_t va_bits;
+
+	/** @dev_id: Device id of xe device*/
+	uint32_t dev_id;
 };
 
 #define for_each_hw_engine(__fd, __hwe) \
@@ -85,6 +88,7 @@ bool xe_has_vram(int fd);
 uint64_t xe_vram_size(int fd, int gt);
 uint32_t xe_get_default_alignment(int fd);
 uint32_t xe_va_bits(int fd);
+uint32_t xe_dev_id(int fd);
 bool xe_supports_faults(int fd);
 const char *xe_engine_class_string(uint32_t engine_class);
 
-- 
2.39.1

Re: [igt-dev] [i-g-t 3/5] lib/xe/xe_query: Add dev_id() interface

[Zbigniew Kempczyński]

On Tue, Mar 14, 2023 at 04:24:50PM +0530, Bhanuprakash Modem wrote:
> Add support to query XE_QUERY_CONFIG_REV_AND_DEVICE_ID.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>  lib/xe/xe_query.c | 9 +++++++++
>  lib/xe/xe_query.h | 4 ++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/lib/xe/xe_query.c b/lib/xe/xe_query.c
> index a6926057f..e27d14383 100644
> --- a/lib/xe/xe_query.c
> +++ b/lib/xe/xe_query.c
> @@ -247,6 +247,7 @@ struct xe_device *xe_device_get(int fd)
>  	xe_dev->config = xe_query_config_new(fd);
>  	xe_dev->number_gt = xe_dev->config->info[XE_QUERY_CONFIG_GT_COUNT];
>  	xe_dev->va_bits = xe_dev->config->info[XE_QUERY_CONFIG_VA_BITS];
> +	xe_dev->dev_id = xe_dev->config->info[XE_QUERY_CONFIG_REV_AND_DEVICE_ID] & 0xffff;
>  	xe_dev->gts = xe_query_gts_new(fd);
>  	xe_dev->memory_regions = __memory_regions(xe_dev->gts);
>  	xe_dev->hw_engines = xe_query_engines_new(fd, &xe_dev->number_hw_engines);
> @@ -465,6 +466,14 @@ xe_dev_FN(xe_supports_faults, supports_faults, bool);
>   */
>  xe_dev_FN(xe_va_bits, va_bits, uint32_t);
>  
> +/**
> + * xe_dev_id:
> + * @fd: xe device fd
> + *
> + * Returns Device id of xe device @fd.
> + */
> +xe_dev_FN(xe_dev_id, dev_id, uint32_t);
> +
>  igt_constructor
>  {
>  	xe_device_cache_init();
> diff --git a/lib/xe/xe_query.h b/lib/xe/xe_query.h
> index fe1343f61..08cee7e14 100644
> --- a/lib/xe/xe_query.h
> +++ b/lib/xe/xe_query.h
> @@ -58,6 +58,9 @@ struct xe_device {
>  
>  	/** @va_bits: va length in bits */
>  	uint32_t va_bits;
> +
> +	/** @dev_id: Device id of xe device*/
                                           ^ missing space
> +	uint32_t dev_id;

You're truncating with 0xffff, so it should be uint16_t.

>  };
>  
>  #define for_each_hw_engine(__fd, __hwe) \
> @@ -85,6 +88,7 @@ bool xe_has_vram(int fd);
>  uint64_t xe_vram_size(int fd, int gt);
>  uint32_t xe_get_default_alignment(int fd);
>  uint32_t xe_va_bits(int fd);
> +uint32_t xe_dev_id(int fd);

uint16_t.

With small nits fixed:

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>

--
Zbigniew

>  bool xe_supports_faults(int fd);
>  const char *xe_engine_class_string(uint32_t engine_class);
>  
> -- 
> 2.39.1
> 

Re: [igt-dev] [i-g-t 3/5] lib/xe/xe_query: Add dev_id() interface

[Mauro Carvalho Chehab]

On Tue, 14 Mar 2023 16:24:50 +0530
Bhanuprakash Modem <bhanuprakash.modem@intel.com> wrote:

> Add support to query XE_QUERY_CONFIG_REV_AND_DEVICE_ID.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>

Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
>  lib/xe/xe_query.c | 9 +++++++++
>  lib/xe/xe_query.h | 4 ++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/lib/xe/xe_query.c b/lib/xe/xe_query.c
> index a6926057f..e27d14383 100644
> --- a/lib/xe/xe_query.c
> +++ b/lib/xe/xe_query.c
> @@ -247,6 +247,7 @@ struct xe_device *xe_device_get(int fd)
>  	xe_dev->config = xe_query_config_new(fd);
>  	xe_dev->number_gt = xe_dev->config->info[XE_QUERY_CONFIG_GT_COUNT];
>  	xe_dev->va_bits = xe_dev->config->info[XE_QUERY_CONFIG_VA_BITS];
> +	xe_dev->dev_id = xe_dev->config->info[XE_QUERY_CONFIG_REV_AND_DEVICE_ID] & 0xffff;
>  	xe_dev->gts = xe_query_gts_new(fd);
>  	xe_dev->memory_regions = __memory_regions(xe_dev->gts);
>  	xe_dev->hw_engines = xe_query_engines_new(fd, &xe_dev->number_hw_engines);
> @@ -465,6 +466,14 @@ xe_dev_FN(xe_supports_faults, supports_faults, bool);
>   */
>  xe_dev_FN(xe_va_bits, va_bits, uint32_t);
>  
> +/**
> + * xe_dev_id:
> + * @fd: xe device fd
> + *
> + * Returns Device id of xe device @fd.
> + */
> +xe_dev_FN(xe_dev_id, dev_id, uint32_t);
> +
>  igt_constructor
>  {
>  	xe_device_cache_init();
> diff --git a/lib/xe/xe_query.h b/lib/xe/xe_query.h
> index fe1343f61..08cee7e14 100644
> --- a/lib/xe/xe_query.h
> +++ b/lib/xe/xe_query.h
> @@ -58,6 +58,9 @@ struct xe_device {
>  
>  	/** @va_bits: va length in bits */
>  	uint32_t va_bits;
> +
> +	/** @dev_id: Device id of xe device*/
> +	uint32_t dev_id;
>  };
>  
>  #define for_each_hw_engine(__fd, __hwe) \
> @@ -85,6 +88,7 @@ bool xe_has_vram(int fd);
>  uint64_t xe_vram_size(int fd, int gt);
>  uint32_t xe_get_default_alignment(int fd);
>  uint32_t xe_va_bits(int fd);
> +uint32_t xe_dev_id(int fd);
>  bool xe_supports_faults(int fd);
>  const char *xe_engine_class_string(uint32_t engine_class);
>  

[igt-dev] [i-g-t 4/5] lib/intel_chipset: Add support to XE driver to get devid

[Bhanuprakash Modem]

As many tests are using intel devid, add a helper to get it for
XE driver.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 lib/intel_chipset.c | 30 ++++++++++++++++++++----------
 1 file changed, 20 insertions(+), 10 deletions(-)

diff --git a/lib/intel_chipset.c b/lib/intel_chipset.c
index efb6f1771..73dbd813d 100644
--- a/lib/intel_chipset.c
+++ b/lib/intel_chipset.c
@@ -41,6 +41,7 @@
 #include "drmtest.h"
 #include "intel_chipset.h"
 #include "igt_core.h"
+#include "xe/xe_query.h"
 
 /**
  * SECTION:intel_chipset
@@ -112,9 +113,22 @@ intel_get_pci_device(void)
 	return pci_dev;
 }
 
+static uint32_t __i915_get_drm_devid(int fd)
+{
+	struct drm_i915_getparam gp;
+	int devid = 0;
+
+	memset(&gp, 0, sizeof(gp));
+	gp.param = I915_PARAM_CHIPSET_ID;
+	gp.value = &devid;
+	ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp, sizeof(gp));
+
+	return devid;
+}
+
 /**
  * intel_get_drm_devid:
- * @fd: open i915 drm file descriptor
+ * @fd: open i915/xe drm file descriptor
  *
  * Queries the kernel for the pci device id corresponding to the drm file
  * descriptor.
@@ -125,22 +139,18 @@ intel_get_pci_device(void)
 uint32_t
 intel_get_drm_devid(int fd)
 {
-	struct drm_i915_getparam gp;
 	const char *override;
-	int devid = 0;
 
-	igt_assert(is_i915_device(fd));
+	igt_assert(is_intel_device(fd));
 
 	override = getenv("INTEL_DEVID_OVERRIDE");
 	if (override)
 		return strtol(override, NULL, 0);
 
-	memset(&gp, 0, sizeof(gp));
-	gp.param = I915_PARAM_CHIPSET_ID;
-	gp.value = &devid;
-	ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp, sizeof(gp));
-
-	return devid;
+	if (is_i915_device(fd))
+		return __i915_get_drm_devid(fd);
+	else
+		return xe_dev_id(fd);
 }
 
 /**
-- 
2.39.1

Re: [igt-dev] [i-g-t 4/5] lib/intel_chipset: Add support to XE driver to get devid

[Zbigniew Kempczyński]

On Tue, Mar 14, 2023 at 04:24:51PM +0530, Bhanuprakash Modem wrote:
> As many tests are using intel devid, add a helper to get it for
> XE driver.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>  lib/intel_chipset.c | 30 ++++++++++++++++++++----------
>  1 file changed, 20 insertions(+), 10 deletions(-)
> 
> diff --git a/lib/intel_chipset.c b/lib/intel_chipset.c
> index efb6f1771..73dbd813d 100644
> --- a/lib/intel_chipset.c
> +++ b/lib/intel_chipset.c
> @@ -41,6 +41,7 @@
>  #include "drmtest.h"
>  #include "intel_chipset.h"
>  #include "igt_core.h"
> +#include "xe/xe_query.h"
>  
>  /**
>   * SECTION:intel_chipset
> @@ -112,9 +113,22 @@ intel_get_pci_device(void)
>  	return pci_dev;
>  }
>  
> +static uint32_t __i915_get_drm_devid(int fd)
> +{
> +	struct drm_i915_getparam gp;
> +	int devid = 0;
> +
> +	memset(&gp, 0, sizeof(gp));
> +	gp.param = I915_PARAM_CHIPSET_ID;
> +	gp.value = &devid;
> +	ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp, sizeof(gp));
> +
> +	return devid;
> +}
> +
>  /**
>   * intel_get_drm_devid:
> - * @fd: open i915 drm file descriptor
> + * @fd: open i915/xe drm file descriptor
>   *
>   * Queries the kernel for the pci device id corresponding to the drm file
>   * descriptor.
> @@ -125,22 +139,18 @@ intel_get_pci_device(void)
>  uint32_t
>  intel_get_drm_devid(int fd)
>  {
> -	struct drm_i915_getparam gp;
>  	const char *override;
> -	int devid = 0;
>  
> -	igt_assert(is_i915_device(fd));
> +	igt_assert(is_intel_device(fd));
>  
>  	override = getenv("INTEL_DEVID_OVERRIDE");
>  	if (override)
>  		return strtol(override, NULL, 0);
>  
> -	memset(&gp, 0, sizeof(gp));
> -	gp.param = I915_PARAM_CHIPSET_ID;
> -	gp.value = &devid;
> -	ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp, sizeof(gp));
> -
> -	return devid;
> +	if (is_i915_device(fd))
> +		return __i915_get_drm_devid(fd);
> +	else
> +		return xe_dev_id(fd);

This is the problem, it depends on implicit xe_device calls I've
added to cache driver/hw settings, but this function shouldn't
rely on it. I mean similar to __i915_get_drm_devid() you should
create helper which doesn't depend on anything.

--
Zbigniew

>  }
>  
>  /**
> -- 
> 2.39.1
> 

Re: [igt-dev] [i-g-t 4/5] lib/intel_chipset: Add support to XE driver to get devid

[Mauro Carvalho Chehab]

On Tue, 14 Mar 2023 16:24:51 +0530
Bhanuprakash Modem <bhanuprakash.modem@intel.com> wrote:

> As many tests are using intel devid, add a helper to get it for
> XE driver.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>  lib/intel_chipset.c | 30 ++++++++++++++++++++----------
>  1 file changed, 20 insertions(+), 10 deletions(-)
> 
> diff --git a/lib/intel_chipset.c b/lib/intel_chipset.c
> index efb6f1771..73dbd813d 100644
> --- a/lib/intel_chipset.c
> +++ b/lib/intel_chipset.c
> @@ -41,6 +41,7 @@
>  #include "drmtest.h"
>  #include "intel_chipset.h"
>  #include "igt_core.h"
> +#include "xe/xe_query.h"
>  
>  /**
>   * SECTION:intel_chipset
> @@ -112,9 +113,22 @@ intel_get_pci_device(void)
>  	return pci_dev;
>  }
>  
> +static uint32_t __i915_get_drm_devid(int fd)
> +{
> +	struct drm_i915_getparam gp;
> +	int devid = 0;
> +
> +	memset(&gp, 0, sizeof(gp));
> +	gp.param = I915_PARAM_CHIPSET_ID;
> +	gp.value = &devid;
> +	ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp, sizeof(gp));
> +
> +	return devid;
> +}
> +

Hmm... Shouldn't it be cached? Anyway:

Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>


>  /**
>   * intel_get_drm_devid:
> - * @fd: open i915 drm file descriptor
> + * @fd: open i915/xe drm file descriptor
>   *
>   * Queries the kernel for the pci device id corresponding to the drm file
>   * descriptor.
> @@ -125,22 +139,18 @@ intel_get_pci_device(void)
>  uint32_t
>  intel_get_drm_devid(int fd)
>  {
> -	struct drm_i915_getparam gp;
>  	const char *override;
> -	int devid = 0;
>  
> -	igt_assert(is_i915_device(fd));
> +	igt_assert(is_intel_device(fd));
>  
>  	override = getenv("INTEL_DEVID_OVERRIDE");
>  	if (override)
>  		return strtol(override, NULL, 0);
>  
> -	memset(&gp, 0, sizeof(gp));
> -	gp.param = I915_PARAM_CHIPSET_ID;
> -	gp.value = &devid;
> -	ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp, sizeof(gp));
> -
> -	return devid;
> +	if (is_i915_device(fd))
> +		return __i915_get_drm_devid(fd);
> +	else
> +		return xe_dev_id(fd);
>  }
>  
>  /**

Re: [igt-dev] [i-g-t 4/5] lib/intel_chipset: Add support to XE driver to get devid

[Zbigniew Kempczyński]

On Tue, Mar 14, 2023 at 01:08:05PM +0100, Mauro Carvalho Chehab wrote:
> On Tue, 14 Mar 2023 16:24:51 +0530
> Bhanuprakash Modem <bhanuprakash.modem@intel.com> wrote:
> 
> > As many tests are using intel devid, add a helper to get it for
> > XE driver.
> > 
> > Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> > ---
> >  lib/intel_chipset.c | 30 ++++++++++++++++++++----------
> >  1 file changed, 20 insertions(+), 10 deletions(-)
> > 
> > diff --git a/lib/intel_chipset.c b/lib/intel_chipset.c
> > index efb6f1771..73dbd813d 100644
> > --- a/lib/intel_chipset.c
> > +++ b/lib/intel_chipset.c
> > @@ -41,6 +41,7 @@
> >  #include "drmtest.h"
> >  #include "intel_chipset.h"
> >  #include "igt_core.h"
> > +#include "xe/xe_query.h"
> >  
> >  /**
> >   * SECTION:intel_chipset
> > @@ -112,9 +113,22 @@ intel_get_pci_device(void)
> >  	return pci_dev;
> >  }
> >  
> > +static uint32_t __i915_get_drm_devid(int fd)
> > +{
> > +	struct drm_i915_getparam gp;
> > +	int devid = 0;
> > +
> > +	memset(&gp, 0, sizeof(gp));
> > +	gp.param = I915_PARAM_CHIPSET_ID;
> > +	gp.value = &devid;
> > +	ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp, sizeof(gp));
> > +
> > +	return devid;
> > +}
> > +
> 
> Hmm... Shouldn't it be cached? Anyway:
> 
> Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> 
> 
> >  /**
> >   * intel_get_drm_devid:
> > - * @fd: open i915 drm file descriptor
> > + * @fd: open i915/xe drm file descriptor
> >   *
> >   * Queries the kernel for the pci device id corresponding to the drm file
> >   * descriptor.
> > @@ -125,22 +139,18 @@ intel_get_pci_device(void)
> >  uint32_t
> >  intel_get_drm_devid(int fd)
> >  {
> > -	struct drm_i915_getparam gp;
> >  	const char *override;
> > -	int devid = 0;
> >  
> > -	igt_assert(is_i915_device(fd));
> > +	igt_assert(is_intel_device(fd));
> >  
> >  	override = getenv("INTEL_DEVID_OVERRIDE");
> >  	if (override)
> >  		return strtol(override, NULL, 0);
> >  
> > -	memset(&gp, 0, sizeof(gp));
> > -	gp.param = I915_PARAM_CHIPSET_ID;
> > -	gp.value = &devid;
> > -	ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp, sizeof(gp));
> > -
> > -	return devid;
> > +	if (is_i915_device(fd))
> > +		return __i915_get_drm_devid(fd);
> > +	else
> > +		return xe_dev_id(fd);

This call is problematic imo, it strongly depends on previously
calling xe_device_get(). As this library part I would explicitly
call config query ioctl() to get device id to avoid this dependency.

--
Zbigniew


> >  }
> >  
> >  /**

Re: [igt-dev] [i-g-t 4/5] lib/intel_chipset: Add support to XE driver to get devid

[Modem, Bhanuprakash]

On Tue-14-03-2023 05:50 pm, Zbigniew Kempczyński wrote:
> On Tue, Mar 14, 2023 at 01:08:05PM +0100, Mauro Carvalho Chehab wrote:
>> On Tue, 14 Mar 2023 16:24:51 +0530
>> Bhanuprakash Modem <bhanuprakash.modem@intel.com> wrote:
>>
>>> As many tests are using intel devid, add a helper to get it for
>>> XE driver.
>>>
>>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>>> ---
>>>   lib/intel_chipset.c | 30 ++++++++++++++++++++----------
>>>   1 file changed, 20 insertions(+), 10 deletions(-)
>>>
>>> diff --git a/lib/intel_chipset.c b/lib/intel_chipset.c
>>> index efb6f1771..73dbd813d 100644
>>> --- a/lib/intel_chipset.c
>>> +++ b/lib/intel_chipset.c
>>> @@ -41,6 +41,7 @@
>>>   #include "drmtest.h"
>>>   #include "intel_chipset.h"
>>>   #include "igt_core.h"
>>> +#include "xe/xe_query.h"
>>>   
>>>   /**
>>>    * SECTION:intel_chipset
>>> @@ -112,9 +113,22 @@ intel_get_pci_device(void)
>>>   	return pci_dev;
>>>   }
>>>   
>>> +static uint32_t __i915_get_drm_devid(int fd)
>>> +{
>>> +	struct drm_i915_getparam gp;
>>> +	int devid = 0;
>>> +
>>> +	memset(&gp, 0, sizeof(gp));
>>> +	gp.param = I915_PARAM_CHIPSET_ID;
>>> +	gp.value = &devid;
>>> +	ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp, sizeof(gp));
>>> +
>>> +	return devid;
>>> +}
>>> +
>>
>> Hmm... Shouldn't it be cached? Anyway:
>>
>> Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>
>>
>>
>>>   /**
>>>    * intel_get_drm_devid:
>>> - * @fd: open i915 drm file descriptor
>>> + * @fd: open i915/xe drm file descriptor
>>>    *
>>>    * Queries the kernel for the pci device id corresponding to the drm file
>>>    * descriptor.
>>> @@ -125,22 +139,18 @@ intel_get_pci_device(void)
>>>   uint32_t
>>>   intel_get_drm_devid(int fd)
>>>   {
>>> -	struct drm_i915_getparam gp;
>>>   	const char *override;
>>> -	int devid = 0;
>>>   
>>> -	igt_assert(is_i915_device(fd));
>>> +	igt_assert(is_intel_device(fd));
>>>   
>>>   	override = getenv("INTEL_DEVID_OVERRIDE");
>>>   	if (override)
>>>   		return strtol(override, NULL, 0);
>>>   
>>> -	memset(&gp, 0, sizeof(gp));
>>> -	gp.param = I915_PARAM_CHIPSET_ID;
>>> -	gp.value = &devid;
>>> -	ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp, sizeof(gp));
>>> -
>>> -	return devid;
>>> +	if (is_i915_device(fd))
>>> +		return __i915_get_drm_devid(fd);
>>> +	else
>>> +		return xe_dev_id(fd);
> 
> This call is problematic imo, it strongly depends on previously
> calling xe_device_get(). As this library part I would explicitly
> call config query ioctl() to get device id to avoid this dependency.

Every KMS test is supposed to call xe_device_get() before starting the 
execution (Please check patch [5/5] in this series).

Still, having a separate helper to get the dev_id is a good option to 
me. I'll float a new rev by adding this.

- Bhanu

> 
> --
> Zbigniew
> 
> 
>>>   }
>>>   
>>>   /**

[igt-dev] [i-g-t 5/5] lib/igt_kms: Cache xe_device info for kms tests

[Bhanuprakash Modem]

Create or get xe_device data from Cache, so that all KMS tests
will utilize.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 lib/igt_kms.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 84091d5ce..d88863a90 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -59,6 +59,7 @@
 #include "igt_device.h"
 #include "igt_sysfs.h"
 #include "sw_sync.h"
+#include "xe/xe_query.h"
 #ifdef HAVE_CHAMELIUM
 #include "igt_chamelium.h"
 #endif
@@ -2541,6 +2542,9 @@ void igt_display_require(igt_display_t *display, int drm_fd)
 	}
 #endif
 
+	if (is_xe_device(drm_fd))
+		xe_device_get(drm_fd);
+
 	/*
 	 * With non-contiguous pipes display, crtc mapping is not always same
 	 * as pipe mapping, In i915 pipe is enum id of i915's crtc object.
@@ -2889,6 +2893,10 @@ static void igt_output_fini(igt_output_t *output)
 void igt_display_fini(igt_display_t *display)
 {
 	int i;
+	int drm_fd = display->drm_fd;
+
+	if (is_xe_device(drm_fd))
+		xe_device_put(drm_fd);
 
 	for (i = 0; i < display->n_planes; ++i) {
 		igt_plane_t *plane = &display->planes[i];
-- 
2.39.1

Re: [igt-dev] [i-g-t 5/5] lib/igt_kms: Cache xe_device info for kms tests

[Zbigniew Kempczyński]

On Tue, Mar 14, 2023 at 04:24:52PM +0530, Bhanuprakash Modem wrote:
> Create or get xe_device data from Cache, so that all KMS tests
> will utilize.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>  lib/igt_kms.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 84091d5ce..d88863a90 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -59,6 +59,7 @@
>  #include "igt_device.h"
>  #include "igt_sysfs.h"
>  #include "sw_sync.h"
> +#include "xe/xe_query.h"
>  #ifdef HAVE_CHAMELIUM
>  #include "igt_chamelium.h"
>  #endif
> @@ -2541,6 +2542,9 @@ void igt_display_require(igt_display_t *display, int drm_fd)
>  	}
>  #endif
>  
> +	if (is_xe_device(drm_fd))
> +		xe_device_get(drm_fd);
> +

Maybe in the future we will try to use xe_device more explicitly but at
the moment it would require to rewrite almost everything. So for this
change in the library:

Acked-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>

--
Zbigniew

>  	/*
>  	 * With non-contiguous pipes display, crtc mapping is not always same
>  	 * as pipe mapping, In i915 pipe is enum id of i915's crtc object.
> @@ -2889,6 +2893,10 @@ static void igt_output_fini(igt_output_t *output)
>  void igt_display_fini(igt_display_t *display)
>  {
>  	int i;
> +	int drm_fd = display->drm_fd;
> +
> +	if (is_xe_device(drm_fd))
> +		xe_device_put(drm_fd);
>  
>  	for (i = 0; i < display->n_planes; ++i) {
>  		igt_plane_t *plane = &display->planes[i];
> -- 
> 2.39.1
> 

Re: [igt-dev] [i-g-t 5/5] lib/igt_kms: Cache xe_device info for kms tests

[Mauro Carvalho Chehab]

On Tue, 14 Mar 2023 16:24:52 +0530
Bhanuprakash Modem <bhanuprakash.modem@intel.com> wrote:

> Create or get xe_device data from Cache, so that all KMS tests
> will utilize.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>

Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>

> ---
>  lib/igt_kms.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 84091d5ce..d88863a90 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -59,6 +59,7 @@
>  #include "igt_device.h"
>  #include "igt_sysfs.h"
>  #include "sw_sync.h"
> +#include "xe/xe_query.h"
>  #ifdef HAVE_CHAMELIUM
>  #include "igt_chamelium.h"
>  #endif
> @@ -2541,6 +2542,9 @@ void igt_display_require(igt_display_t *display, int drm_fd)
>  	}
>  #endif
>  
> +	if (is_xe_device(drm_fd))
> +		xe_device_get(drm_fd);
> +
>  	/*
>  	 * With non-contiguous pipes display, crtc mapping is not always same
>  	 * as pipe mapping, In i915 pipe is enum id of i915's crtc object.
> @@ -2889,6 +2893,10 @@ static void igt_output_fini(igt_output_t *output)
>  void igt_display_fini(igt_display_t *display)
>  {
>  	int i;
> +	int drm_fd = display->drm_fd;
> +
> +	if (is_xe_device(drm_fd))
> +		xe_device_put(drm_fd);
>  
>  	for (i = 0; i < display->n_planes; ++i) {
>  		igt_plane_t *plane = &display->planes[i];

[igt-dev] ✓ Fi.CI.BAT: success for Add basic helpers to support display in XE

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 4521 bytes --]

== Series Details ==

Series: Add basic helpers to support display in XE
URL   : https://patchwork.freedesktop.org/series/115113/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12857 -> IGTPW_8601
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/index.html

Participating hosts (36 -> 35)
------------------------------

  Missing    (1): fi-snb-2520m 

Known issues
------------

  Here are the changes found in IGTPW_8601 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_suspend@basic-s3@smem:
    - bat-adln-1:         [PASS][1] -> [DMESG-WARN][2] ([i915#2867])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/bat-adln-1/igt@gem_exec_suspend@basic-s3@smem.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/bat-adln-1/igt@gem_exec_suspend@basic-s3@smem.html

  * igt@i915_selftest@live@execlists:
    - fi-bsw-nick:        [PASS][3] -> [ABORT][4] ([i915#7911] / [i915#7913])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/fi-bsw-nick/igt@i915_selftest@live@execlists.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/fi-bsw-nick/igt@i915_selftest@live@execlists.html

  * igt@i915_selftest@live@slpc:
    - bat-rpls-1:         NOTRUN -> [DMESG-FAIL][5] ([i915#6367] / [i915#7996])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/bat-rpls-1/igt@i915_selftest@live@slpc.html

  * igt@kms_chamelium_hpd@common-hpd-after-suspend:
    - bat-adlp-9:         NOTRUN -> [SKIP][6] ([i915#7828])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/bat-adlp-9/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
    - bat-rpls-1:         NOTRUN -> [SKIP][7] ([i915#7828])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/bat-rpls-1/igt@kms_chamelium_hpd@common-hpd-after-suspend.html

  * igt@kms_pipe_crc_basic@suspend-read-crc:
    - bat-rpls-1:         NOTRUN -> [SKIP][8] ([i915#1845])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/bat-rpls-1/igt@kms_pipe_crc_basic@suspend-read-crc.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@gt_heartbeat:
    - fi-cfl-8109u:       [DMESG-FAIL][9] ([i915#5334]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/fi-cfl-8109u/igt@i915_selftest@live@gt_heartbeat.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/fi-cfl-8109u/igt@i915_selftest@live@gt_heartbeat.html

  * igt@i915_selftest@live@requests:
    - bat-rpls-1:         [ABORT][11] ([i915#4983] / [i915#7694] / [i915#7911] / [i915#7981]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/bat-rpls-1/igt@i915_selftest@live@requests.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/bat-rpls-1/igt@i915_selftest@live@requests.html
    - bat-adlp-9:         [ABORT][13] ([i915#7982]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/bat-adlp-9/igt@i915_selftest@live@requests.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/bat-adlp-9/igt@i915_selftest@live@requests.html

  
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
  [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
  [i915#7694]: https://gitlab.freedesktop.org/drm/intel/issues/7694
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
  [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
  [i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981
  [i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
  [i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7194 -> IGTPW_8601

  CI-20190529: 20190529
  CI_DRM_12857: 004fefbbf160569f80946d1e516d538b7ecb04f2 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8601: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/index.html
  IGT_7194: d22d66efd6211a22d301649b63d58c8c293e0817 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/index.html

[-- Attachment #2: Type: text/html, Size: 5449 bytes --]

[igt-dev] ✓ Fi.CI.IGT: success for Add basic helpers to support display in XE

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 27250 bytes --]

== Series Details ==

Series: Add basic helpers to support display in XE
URL   : https://patchwork.freedesktop.org/series/115113/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12857_full -> IGTPW_8601_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/index.html

Participating hosts (8 -> 9)
------------------------------

  Additional (1): shard-rkl0 

Known issues
------------

  Here are the changes found in IGTPW_8601_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_fair@basic-none-share@rcs0:
    - shard-glk:          [PASS][1] -> [FAIL][2] ([i915#2842]) +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-glk7/igt@gem_exec_fair@basic-none-share@rcs0.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-glk3/igt@gem_exec_fair@basic-none-share@rcs0.html

  * igt@gem_exec_fair@basic-pace-solo@rcs0:
    - shard-apl:          [PASS][3] -> [FAIL][4] ([i915#2842])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-apl1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-apl4/igt@gem_exec_fair@basic-pace-solo@rcs0.html

  * igt@i915_pm_rps@reset:
    - shard-snb:          [PASS][5] -> [INCOMPLETE][6] ([i915#7790])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-snb2/igt@i915_pm_rps@reset.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-snb5/igt@i915_pm_rps@reset.html

  * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
    - shard-glk:          [PASS][7] -> [FAIL][8] ([i915#72])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-glk5/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
    - shard-apl:          [PASS][9] -> [FAIL][10] ([i915#2346])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
    - shard-glk:          [PASS][11] -> [FAIL][12] ([i915#2346])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-glk5/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

  * igt@kms_flip@flip-vs-expired-vblank@b-dp1:
    - shard-apl:          [PASS][13] -> [FAIL][14] ([i915#79])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-apl4/igt@kms_flip@flip-vs-expired-vblank@b-dp1.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-apl4/igt@kms_flip@flip-vs-expired-vblank@b-dp1.html

  
#### Possible fixes ####

  * igt@device_reset@unbind-reset-rebind:
    - {shard-rkl}:        [FAIL][15] ([i915#4778]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-rkl-5/igt@device_reset@unbind-reset-rebind.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-rkl-6/igt@device_reset@unbind-reset-rebind.html

  * igt@fbdev@unaligned-write:
    - {shard-rkl}:        [SKIP][17] ([i915#2582]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-rkl-1/igt@fbdev@unaligned-write.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-rkl-6/igt@fbdev@unaligned-write.html

  * igt@feature_discovery@psr1:
    - {shard-rkl}:        [SKIP][19] ([i915#658]) -> [PASS][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-rkl-3/igt@feature_discovery@psr1.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-rkl-6/igt@feature_discovery@psr1.html

  * igt@gem_bad_reloc@negative-reloc:
    - {shard-rkl}:        [SKIP][21] ([i915#3281]) -> [PASS][22] +12 similar issues
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-rkl-6/igt@gem_bad_reloc@negative-reloc.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-rkl-5/igt@gem_bad_reloc@negative-reloc.html

  * igt@gem_ctx_persistence@engines-hang@bcs0:
    - {shard-rkl}:        [SKIP][23] ([i915#6252]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-rkl-5/igt@gem_ctx_persistence@engines-hang@bcs0.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-rkl-4/igt@gem_ctx_persistence@engines-hang@bcs0.html

  * igt@gem_exec_fair@basic-deadline:
    - {shard-rkl}:        [FAIL][25] ([i915#2846]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-rkl-2/igt@gem_exec_fair@basic-deadline.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-rkl-2/igt@gem_exec_fair@basic-deadline.html

  * igt@gem_exec_fair@basic-none-share@rcs0:
    - {shard-tglu}:       [FAIL][27] ([i915#2842]) -> [PASS][28]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-tglu-3/igt@gem_exec_fair@basic-none-share@rcs0.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-tglu-5/igt@gem_exec_fair@basic-none-share@rcs0.html

  * igt@gem_exec_fair@basic-none-vip@rcs0:
    - shard-glk:          [FAIL][29] ([i915#2842]) -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-glk6/igt@gem_exec_fair@basic-none-vip@rcs0.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-glk8/igt@gem_exec_fair@basic-none-vip@rcs0.html

  * igt@gem_exec_suspend@basic-s4-devices@lmem0:
    - {shard-dg1}:        [ABORT][31] ([i915#7975]) -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-dg1-14/igt@gem_exec_suspend@basic-s4-devices@lmem0.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-dg1-12/igt@gem_exec_suspend@basic-s4-devices@lmem0.html

  * igt@gem_mmap_wc@set-cache-level:
    - {shard-tglu}:       [SKIP][33] ([i915#1850]) -> [PASS][34]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-tglu-9/igt@gem_mmap_wc@set-cache-level.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-tglu-4/igt@gem_mmap_wc@set-cache-level.html
    - {shard-rkl}:        [SKIP][35] ([i915#1850]) -> [PASS][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-rkl-5/igt@gem_mmap_wc@set-cache-level.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-rkl-6/igt@gem_mmap_wc@set-cache-level.html

  * igt@gem_pwrite@basic-self:
    - {shard-rkl}:        [SKIP][37] ([i915#3282]) -> [PASS][38] +1 similar issue
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-rkl-1/igt@gem_pwrite@basic-self.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-rkl-5/igt@gem_pwrite@basic-self.html

  * igt@gen9_exec_parse@unaligned-jump:
    - {shard-rkl}:        [SKIP][39] ([i915#2527]) -> [PASS][40]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-rkl-1/igt@gen9_exec_parse@unaligned-jump.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-rkl-5/igt@gen9_exec_parse@unaligned-jump.html

  * igt@i915_pm_rpm@dpms-mode-unset-lpsp:
    - {shard-rkl}:        [SKIP][41] ([i915#1397]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-rkl-2/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-rkl-6/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html

  * igt@i915_pm_rpm@modeset-lpsp:
    - {shard-tglu}:       [SKIP][43] ([i915#1397]) -> [PASS][44]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-tglu-9/igt@i915_pm_rpm@modeset-lpsp.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-tglu-5/igt@i915_pm_rpm@modeset-lpsp.html

  * igt@i915_pm_rpm@pm-tiling:
    - {shard-rkl}:        [SKIP][45] ([fdo#109308]) -> [PASS][46]
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-rkl-2/igt@i915_pm_rpm@pm-tiling.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-rkl-6/igt@i915_pm_rpm@pm-tiling.html

  * {igt@i915_power@sanity}:
    - {shard-rkl}:        [SKIP][47] ([i915#7984]) -> [PASS][48]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-rkl-1/igt@i915_power@sanity.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-rkl-5/igt@i915_power@sanity.html

  * igt@i915_selftest@live@dmabuf:
    - shard-apl:          [DMESG-FAIL][49] ([i915#7562]) -> [PASS][50]
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-apl2/igt@i915_selftest@live@dmabuf.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-apl7/igt@i915_selftest@live@dmabuf.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
    - shard-apl:          [FAIL][51] ([i915#2346]) -> [PASS][52]
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

  * igt@kms_fbcon_fbt@fbc-suspend:
    - shard-apl:          [FAIL][53] ([i915#4767]) -> [PASS][54]
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-apl6/igt@kms_fbcon_fbt@fbc-suspend.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-apl2/igt@kms_fbcon_fbt@fbc-suspend.html

  * igt@kms_fbcon_fbt@psr-suspend:
    - {shard-rkl}:        [SKIP][55] ([fdo#110189] / [i915#3955]) -> [PASS][56]
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-rkl-2/igt@kms_fbcon_fbt@psr-suspend.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-rkl-6/igt@kms_fbcon_fbt@psr-suspend.html

  * igt@kms_fence_pin_leak:
    - {shard-tglu}:       [SKIP][57] ([fdo#109274] / [i915#1845]) -> [PASS][58]
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-tglu-9/igt@kms_fence_pin_leak.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-tglu-3/igt@kms_fence_pin_leak.html

  * igt@kms_frontbuffer_tracking@fbc-tiling-linear:
    - {shard-rkl}:        [SKIP][59] ([i915#1849] / [i915#4098]) -> [PASS][60] +11 similar issues
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-rkl-5/igt@kms_frontbuffer_tracking@fbc-tiling-linear.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-tiling-linear.html
    - {shard-tglu}:       [SKIP][61] ([i915#1849]) -> [PASS][62] +6 similar issues
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-tglu-9/igt@kms_frontbuffer_tracking@fbc-tiling-linear.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-tglu-4/igt@kms_frontbuffer_tracking@fbc-tiling-linear.html

  * igt@kms_psr@dpms:
    - {shard-rkl}:        [SKIP][63] ([i915#1072]) -> [PASS][64] +1 similar issue
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-rkl-3/igt@kms_psr@dpms.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-rkl-6/igt@kms_psr@dpms.html

  * igt@kms_rotation_crc@cursor-rotation-180:
    - {shard-tglu}:       [SKIP][65] ([i915#1845]) -> [PASS][66] +3 similar issues
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-tglu-9/igt@kms_rotation_crc@cursor-rotation-180.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-tglu-8/igt@kms_rotation_crc@cursor-rotation-180.html

  * igt@kms_rotation_crc@exhaust-fences:
    - {shard-rkl}:        [SKIP][67] ([i915#1845] / [i915#4098]) -> [PASS][68] +20 similar issues
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-rkl-2/igt@kms_rotation_crc@exhaust-fences.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-rkl-6/igt@kms_rotation_crc@exhaust-fences.html

  * igt@kms_universal_plane@cursor-fb-leak-pipe-c:
    - {shard-tglu}:       [SKIP][69] ([fdo#109274]) -> [PASS][70] +1 similar issue
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-tglu-9/igt@kms_universal_plane@cursor-fb-leak-pipe-c.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-tglu-7/igt@kms_universal_plane@cursor-fb-leak-pipe-c.html

  * igt@kms_vblank@pipe-d-wait-busy:
    - {shard-tglu}:       [SKIP][71] ([i915#1845] / [i915#7651]) -> [PASS][72] +21 similar issues
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-tglu-9/igt@kms_vblank@pipe-d-wait-busy.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-tglu-4/igt@kms_vblank@pipe-d-wait-busy.html

  * igt@perf@gen8-unprivileged-single-ctx-counters:
    - {shard-rkl}:        [SKIP][73] ([i915#2436]) -> [PASS][74]
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-rkl-2/igt@perf@gen8-unprivileged-single-ctx-counters.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-rkl-5/igt@perf@gen8-unprivileged-single-ctx-counters.html

  * igt@perf@mi-rpc:
    - {shard-rkl}:        [SKIP][75] ([i915#2434]) -> [PASS][76]
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-rkl-4/igt@perf@mi-rpc.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-rkl-5/igt@perf@mi-rpc.html

  * igt@prime_self_import@basic-with_one_bo:
    - {shard-rkl}:        [SKIP][77] ([fdo#109315]) -> [PASS][78] +3 similar issues
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-rkl-5/igt@prime_self_import@basic-with_one_bo.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-rkl-1/igt@prime_self_import@basic-with_one_bo.html

  * igt@syncobj_timeline@wait-all-for-submit-delayed-submit:
    - {shard-rkl}:        [SKIP][79] ([i915#2575]) -> [PASS][80] +2 similar issues
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-rkl-5/igt@syncobj_timeline@wait-all-for-submit-delayed-submit.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-rkl-3/igt@syncobj_timeline@wait-all-for-submit-delayed-submit.html

  * igt@sysfs_heartbeat_interval@precise@vcs0:
    - {shard-dg1}:        [FAIL][81] ([i915#1755]) -> [PASS][82] +2 similar issues
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-dg1-15/igt@sysfs_heartbeat_interval@precise@vcs0.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-dg1-15/igt@sysfs_heartbeat_interval@precise@vcs0.html

  
#### Warnings ####

  * igt@i915_pm_dc@dc9-dpms:
    - shard-apl:          [SKIP][83] ([fdo#109271]) -> [FAIL][84] ([i915#4275])
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12857/shard-apl6/igt@i915_pm_dc@dc9-dpms.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/shard-apl4/igt@i915_pm_dc@dc9-dpms.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
  [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
  [fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
  [fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
  [fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
  [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
  [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
  [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
  [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
  [fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
  [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
  [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
  [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
  [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
  [i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
  [i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
  [i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
  [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
  [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
  [i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
  [i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
  [i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
  [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
  [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
  [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
  [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
  [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
  [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
  [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
  [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
  [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
  [i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
  [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
  [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
  [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
  [i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
  [i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
  [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
  [i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
  [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
  [i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
  [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
  [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
  [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
  [i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
  [i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
  [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
  [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
  [i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
  [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
  [i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
  [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
  [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
  [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
  [i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
  [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
  [i915#4275]: https://gitlab.freedesktop.org/drm/intel/issues/4275
  [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
  [i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
  [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
  [i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
  [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
  [i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
  [i915#4778]: https://gitlab.freedesktop.org/drm/intel/issues/4778
  [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
  [i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818
  [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
  [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
  [i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
  [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
  [i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879
  [i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
  [i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
  [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
  [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
  [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
  [i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
  [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
  [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
  [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
  [i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
  [i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
  [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
  [i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
  [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
  [i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
  [i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
  [i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
  [i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
  [i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
  [i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
  [i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259
  [i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
  [i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
  [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
  [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
  [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
  [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
  [i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
  [i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
  [i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
  [i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
  [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
  [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
  [i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
  [i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
  [i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
  [i915#7330]: https://gitlab.freedesktop.org/drm/intel/issues/7330
  [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
  [i915#7562]: https://gitlab.freedesktop.org/drm/intel/issues/7562
  [i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
  [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
  [i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
  [i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
  [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
  [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
  [i915#7790]: https://gitlab.freedesktop.org/drm/intel/issues/7790
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
  [i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
  [i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957
  [i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
  [i915#7984]: https://gitlab.freedesktop.org/drm/intel/issues/7984
  [i915#8151]: https://gitlab.freedesktop.org/drm/intel/issues/8151
  [i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152
  [i915#8154]: https://gitlab.freedesktop.org/drm/intel/issues/8154
  [i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
  [i915#8273]: https://gitlab.freedesktop.org/drm/intel/issues/8273
  [i915#8282]: https://gitlab.freedesktop.org/drm/intel/issues/8282


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7194 -> IGTPW_8601
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_12857: 004fefbbf160569f80946d1e516d538b7ecb04f2 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8601: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/index.html
  IGT_7194: d22d66efd6211a22d301649b63d58c8c293e0817 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8601/index.html

[-- Attachment #2: Type: text/html, Size: 20868 bytes --]