Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Luca Coelho <luciano.coelho@intel.com>
Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Fix out-of-bound array access
Date: Thu, 16 Mar 2023 21:43:53 +0530	[thread overview]
Message-ID: <20230316161353.30915-1-swati2.sharma@intel.com> (raw)

With this fix we are solving 2 issues. Firstly, the
planes_scaling_combo() tests were leaving one scaler assigned
after running sub-test with two consecutive planes because
one scaler was getting reused in the next run.

Secondly, when k == n_planes - 1, we were trying to access
planes[n_planes], which led to array out of bounds error.

Suggested-by: Luca Coelho <luciano.coelho@intel.com>
Suggested-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Reported-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_plane_scaling.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 3a6904afb..3898446ed 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -744,7 +744,7 @@ test_planes_scaling_combo(data_t *d, int w1, int h1, int w2, int h2,
 		igt_assert(0);
 	}
 
-	for (int k = 0; k < display->pipes[pipe].n_planes; k++) {
+	for (int k = 0; k < display->pipes[pipe].n_planes; k += 2) {
 		igt_plane_t *p1, *p2;
 
 		p1 = &display->pipes[pipe].planes[k];
-- 
2.25.1

             reply	other threads:[~2023-03-16 16:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-16 16:13 Swati Sharma [this message]
2023-03-16 19:13 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_plane_scaling: Fix out-of-bound array access (rev3) Patchwork
2023-03-17  7:35 ` [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Fix out-of-bound array access Coelho, Luciano
2023-03-19 20:13 ` Juha-Pekka Heikkilä
2023-03-20  5:51 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_scaling: Fix out-of-bound array access (rev4) Patchwork
2023-03-20  7:01 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2023-03-16 14:50 [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Fix out-of-bound array access Swati Sharma
2023-03-16 14:34 Swati Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230316161353.30915-1-swati2.sharma@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=luciano.coelho@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox