From: "Coelho, Luciano" <luciano.coelho@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"Sharma, Swati2" <swati2.sharma@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Fix out-of-bound array access
Date: Fri, 17 Mar 2023 07:35:45 +0000 [thread overview]
Message-ID: <a6f343d2ccb318fd0dd35f6353423b3da2e5d1f7.camel@intel.com> (raw)
In-Reply-To: <20230316161353.30915-1-swati2.sharma@intel.com>
On Thu, 2023-03-16 at 21:43 +0530, Swati Sharma wrote:
> With this fix we are solving 2 issues. Firstly, the
> planes_scaling_combo() tests were leaving one scaler assigned
> after running sub-test with two consecutive planes because
> one scaler was getting reused in the next run.
>
> Secondly, when k == n_planes - 1, we were trying to access
> planes[n_planes], which led to array out of bounds error.
>
> Suggested-by: Luca Coelho <luciano.coelho@intel.com>
> Suggested-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> Reported-by: Luca Coelho <luciano.coelho@intel.com>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
Looks goods. Thanks for fixing it.
Reviewed-by: Luca Coelho <luciano.coelho@intel.com>
--
Cheers,
Luca.
next prev parent reply other threads:[~2023-03-17 7:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 16:13 [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Fix out-of-bound array access Swati Sharma
2023-03-16 19:13 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_plane_scaling: Fix out-of-bound array access (rev3) Patchwork
2023-03-17 7:35 ` Coelho, Luciano [this message]
2023-03-19 20:13 ` [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Fix out-of-bound array access Juha-Pekka Heikkilä
2023-03-20 5:51 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_scaling: Fix out-of-bound array access (rev4) Patchwork
2023-03-20 7:01 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-03-16 14:50 [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Fix out-of-bound array access Swati Sharma
2023-03-16 14:34 Swati Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6f343d2ccb318fd0dd35f6353423b3da2e5d1f7.camel@intel.com \
--to=luciano.coelho@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox