* [igt-dev] [PATCH i-g-t 0/2] Add support for Xe driver unload/reload
@ 2023-03-21 14:46 Mauro Carvalho Chehab
2023-03-21 14:46 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_kmod: add support for Xe driver Mauro Carvalho Chehab
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Mauro Carvalho Chehab @ 2023-03-21 14:46 UTC (permalink / raw)
To: igt-dev
From: Mauro Carvalho Chehab <mchehab@kernel.org>
It is interesting to let IGT to unload/reload the Xe driver,
as it can help CI to track track troubles.
Add support for it.
Mauro Carvalho Chehab (2):
lib/igt_kmod: add support for Xe driver
xe/xe_module_load: add a test to load/unload Xe driver
lib/igt_kmod.c | 34 ++---
lib/igt_kmod.h | 31 ++++-
tests/intel-ci/xe-fast-feedback.testlist | 3 +
tests/meson.build | 1 +
tests/xe/xe_module_load.c | 163 +++++++++++++++++++++++
5 files changed, 212 insertions(+), 20 deletions(-)
create mode 100644 tests/xe/xe_module_load.c
--
2.39.2
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 1/2] lib/igt_kmod: add support for Xe driver
2023-03-21 14:46 [igt-dev] [PATCH i-g-t 0/2] Add support for Xe driver unload/reload Mauro Carvalho Chehab
@ 2023-03-21 14:46 ` Mauro Carvalho Chehab
2023-03-22 10:41 ` Kamil Konieczny
2023-03-21 14:46 ` [igt-dev] [PATCH i-g-t 2/2] xe/xe_module_load: add a test to load/unload " Mauro Carvalho Chehab
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Mauro Carvalho Chehab @ 2023-03-21 14:46 UTC (permalink / raw)
To: igt-dev
From: Mauro Carvalho Chehab <mchehab@kernel.org>
Change the kmod logic to also work with the Xe driver.
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
lib/igt_kmod.c | 34 +++++++++++++++++-----------------
lib/igt_kmod.h | 31 ++++++++++++++++++++++++++++---
2 files changed, 45 insertions(+), 20 deletions(-)
diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
index 6d6ecf0187ed..ccf0063ca1b1 100644
--- a/lib/igt_kmod.c
+++ b/lib/igt_kmod.c
@@ -404,23 +404,23 @@ static void *strdup_realloc(char *origptr, const char *strdata)
}
/**
- * igt_i915_driver_load:
- * @opts: options to pass to i915 driver
+ * igt_intel_driver_load:
+ * @opts: options to pass to Intel driver
*
- * Loads the i915 driver and its dependencies.
+ * Loads an Intel driver and its dependencies.
*
*/
int
-igt_i915_driver_load(const char *opts)
+igt_intel_driver_load(const char *opts, const char *driver)
{
int ret;
if (opts)
- igt_info("Reloading i915 with %s\n\n", opts);
+ igt_info("Reloading %s with %s\n\n", driver, opts);
- ret = igt_kmod_load("i915", opts);
+ ret = igt_kmod_load(driver, opts);
if (ret) {
- igt_debug("Could not load i915\n");
+ igt_debug("Could not load %s\n", driver);
return ret;
}
@@ -496,7 +496,7 @@ int igt_audio_driver_unload(char **who)
return igt_always_unload_audio_driver(who);
}
-int __igt_i915_driver_unload(char **who)
+int __igt_intel_driver_unload(char **who, const char *driver)
{
int ret;
@@ -530,11 +530,11 @@ int __igt_i915_driver_unload(char **who)
}
}
- if (igt_kmod_is_loaded("i915")) {
- ret = igt_kmod_unload("i915", 0);
+ if (igt_kmod_is_loaded(driver)) {
+ ret = igt_kmod_unload(driver, 0);
if (ret) {
if (who)
- *who = strdup_realloc(*who, "i915");
+ *who = strdup_realloc(*who, driver);
return ret;
}
@@ -544,18 +544,18 @@ int __igt_i915_driver_unload(char **who)
}
/**
- * igt_i915_driver_unload:
+ * igt_intel_driver_unload:
*
- * Unloads the i915 driver and its dependencies.
+ * Unloads an Intel driver and its dependencies.
*
*/
int
-igt_i915_driver_unload(void)
+igt_intel_driver_unload(const char *driver)
{
char *who = NULL;
int ret;
- ret = __igt_i915_driver_unload(&who);
+ ret = __igt_intel_driver_unload(&who, driver);
if (ret) {
igt_warn("Could not unload %s\n", who);
igt_kmod_list_loaded();
@@ -572,8 +572,8 @@ igt_i915_driver_unload(void)
igt_kmod_unload("drm_kms_helper", 0);
igt_kmod_unload("drm", 0);
- if (igt_kmod_is_loaded("i915")) {
- igt_warn("i915.ko still loaded!\n");
+ if (igt_kmod_is_loaded("driver")) {
+ igt_warn("%s.ko still loaded!\n", driver);
return -EBUSY;
}
diff --git a/lib/igt_kmod.h b/lib/igt_kmod.h
index f98dd29fb175..a6b422abf328 100644
--- a/lib/igt_kmod.h
+++ b/lib/igt_kmod.h
@@ -38,9 +38,34 @@ int igt_kmod_unload(const char *mod_name, unsigned int flags);
int igt_audio_driver_unload(char **whom);
-int igt_i915_driver_load(const char *opts);
-int igt_i915_driver_unload(void);
-int __igt_i915_driver_unload(char **whom);
+int igt_intel_driver_load(const char *opts, const char *driver);
+int igt_intel_driver_unload(const char *driver);
+int __igt_intel_driver_unload(char **who, const char *driver);
+
+static inline int igt_i915_driver_load(const char *opts)
+{
+ return igt_intel_driver_load(opts, "i915");
+}
+
+static inline int igt_i915_driver_unload(void)
+{
+ return igt_intel_driver_unload("i915");
+}
+
+static inline int __igt_i915_driver_unload(char **whom) {
+ return __igt_intel_driver_unload(whom, "i915");
+};
+
+static inline int igt_xe_driver_load(const char *opts)
+{
+ return igt_intel_driver_load(opts, "xe");
+}
+
+
+static inline int igt_xe_driver_unload(void)
+{
+ return igt_intel_driver_unload("xe");
+}
int igt_amdgpu_driver_load(const char *opts);
int igt_amdgpu_driver_unload(void);
--
2.39.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 2/2] xe/xe_module_load: add a test to load/unload Xe driver
2023-03-21 14:46 [igt-dev] [PATCH i-g-t 0/2] Add support for Xe driver unload/reload Mauro Carvalho Chehab
2023-03-21 14:46 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_kmod: add support for Xe driver Mauro Carvalho Chehab
@ 2023-03-21 14:46 ` Mauro Carvalho Chehab
2023-03-22 12:06 ` Kamil Konieczny
2023-03-21 15:20 ` [igt-dev] ✓ Fi.CI.BAT: success for Add support for Xe driver unload/reload Patchwork
2023-03-21 20:16 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 1 reply; 8+ messages in thread
From: Mauro Carvalho Chehab @ 2023-03-21 14:46 UTC (permalink / raw)
To: igt-dev
From: Mauro Carvalho Chehab <mchehab@kernel.org>
This is helpful to allow IGT to check if there are issues
during module load/unload.
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
tests/intel-ci/xe-fast-feedback.testlist | 3 +
tests/meson.build | 1 +
tests/xe/xe_module_load.c | 163 +++++++++++++++++++++++
3 files changed, 167 insertions(+)
create mode 100644 tests/xe/xe_module_load.c
diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
index 6525b1676b6f..3140d648833a 100644
--- a/tests/intel-ci/xe-fast-feedback.testlist
+++ b/tests/intel-ci/xe-fast-feedback.testlist
@@ -1,3 +1,6 @@
+# Should be the first test
+igt@xe_module_load@force-load
+
igt@xe_compute@compute-square
igt@xe_debugfs@base
igt@xe_debugfs@gt
diff --git a/tests/meson.build b/tests/meson.build
index 632e36e059d8..f9fef103a736 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -256,6 +256,7 @@ xe_progs = [
'xe_huc_copy',
'xe_mmap',
'xe_mmio',
+ 'xe_module_load',
'xe_pm',
'xe_prime_self_import',
'xe_query',
diff --git a/tests/xe/xe_module_load.c b/tests/xe/xe_module_load.c
new file mode 100644
index 000000000000..00302be561c1
--- /dev/null
+++ b/tests/xe/xe_module_load.c
@@ -0,0 +1,163 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2023 Intel Corporation
+ */
+
+/**
+ * TEST: Tests the xe module loading
+ * Category: Sofware building block
+ * Sub-category: driver
+ * Test category: functionality test
+ */
+
+#include "igt.h"
+#include <dirent.h>
+#include <sys/utsname.h>
+#ifdef __linux__
+#include <linux/limits.h>
+#endif
+#include <signal.h>
+#include <libgen.h>
+#include <signal.h>
+#include <sys/ioctl.h>
+#include <fcntl.h>
+
+#include "igt_debugfs.h"
+#include "igt_aux.h"
+#include "igt_kmod.h"
+#include "igt_sysfs.h"
+#include "igt_core.h"
+
+#define BAR_SIZE_SHIFT 20
+#define MIN_BAR_SIZE 256
+
+static void
+hda_dynamic_debug(bool enable)
+{
+ FILE *fp;
+ const char snd_hda_intel_on[] = "module snd_hda_intel +pf";
+ const char snd_hda_core_on[] = "module snd_hda_core +pf";
+
+ const char snd_hda_intel_off[] = "module snd_hda_core =_";
+ const char snd_hda_core_off[] = "module snd_hda_intel =_";
+
+ fp = fopen("/sys/kernel/debug/dynamic_debug/control", "w");
+ if (!fp) {
+ igt_debug("hda dynamic debug not available\n");
+ return;
+ }
+
+ if (enable) {
+ fwrite(snd_hda_intel_on, 1, sizeof(snd_hda_intel_on), fp);
+ fwrite(snd_hda_core_on, 1, sizeof(snd_hda_core_on), fp);
+ } else {
+ fwrite(snd_hda_intel_off, 1, sizeof(snd_hda_intel_off), fp);
+ fwrite(snd_hda_core_off, 1, sizeof(snd_hda_core_off), fp);
+ }
+
+ fclose(fp);
+}
+
+static void load_and_check_xe(const char *opts)
+{
+ int error;
+ int drm_fd;
+
+ hda_dynamic_debug(true);
+ error = igt_xe_driver_load(opts);
+ hda_dynamic_debug(false);
+
+ igt_assert_eq(error, 0);
+
+ /* driver is ready, check if it's bound */
+ drm_fd = __drm_open_driver(DRIVER_XE);
+ igt_fail_on_f(drm_fd < 0, "Cannot open the xe DRM driver after modprobing xe.\n");
+}
+
+/**
+ * SUBTEST: force-load
+ * Description: Load the Xe driver passing ``force_probe=*`` parameter
+ * Run type: BAT
+ *
+ * SUBTEST: load
+ * Description: Load the Xe driver
+ * Run type: FULL
+ *
+ * SUBTEST: unload
+ * Description: Unload the Xe driver
+ * Run type: FULL
+ *
+ * SUBTEST: reload
+ * Description: Reload the Xe driver
+ * Run type: FULL
+ *
+ * SUBTEST: reload-no-display
+ * Description: Reload the Xe driver passing ``enable_display=0`` parameter
+ * Run type: FULL
+ *
+ * SUBTEST: many-reload
+ * Description: Reload the Xe driver many times
+ * Run type: FULL
+ */
+igt_main
+{
+ igt_describe("Check if xe and friends are not yet loaded, then load them.");
+ igt_subtest("load") {
+ const char * unwanted_drivers[] = {
+ "xe",
+ "i915",
+ NULL
+ };
+
+ for (int i = 0; unwanted_drivers[i] != NULL; i++) {
+ igt_skip_on_f(igt_kmod_is_loaded(unwanted_drivers[i]),
+ "%s is already loaded\n", unwanted_drivers[i]);
+ }
+
+ load_and_check_xe(NULL);
+ }
+
+ igt_subtest("unload") {
+ igt_xe_driver_unload();
+ }
+
+ igt_subtest("force-load") {
+ const char * unwanted_drivers[] = {
+ "xe",
+ "i915",
+ NULL
+ };
+
+ for (int i = 0; unwanted_drivers[i] != NULL; i++) {
+ igt_skip_on_f(igt_kmod_is_loaded(unwanted_drivers[i]),
+ "%s is already loaded\n", unwanted_drivers[i]);
+ }
+
+ load_and_check_xe("force_probe=*");
+ }
+
+ igt_subtest("reload-no-display") {
+ igt_xe_driver_unload();
+ load_and_check_xe("enable_display=0");
+ }
+
+
+ igt_subtest("many-reload") {
+ int i;
+
+ for (i = 0; i < 10; i++) {
+ igt_xe_driver_unload();
+ load_and_check_xe(NULL);
+ sleep(1);
+ }
+ }
+
+ igt_subtest("reload") {
+ igt_xe_driver_unload();
+ load_and_check_xe(NULL);
+
+ /* only default modparams, can leave module loaded */
+ }
+
+ /* Subtests should unload the module themselves if they use modparams */
+}
--
2.39.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for Add support for Xe driver unload/reload
2023-03-21 14:46 [igt-dev] [PATCH i-g-t 0/2] Add support for Xe driver unload/reload Mauro Carvalho Chehab
2023-03-21 14:46 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_kmod: add support for Xe driver Mauro Carvalho Chehab
2023-03-21 14:46 ` [igt-dev] [PATCH i-g-t 2/2] xe/xe_module_load: add a test to load/unload " Mauro Carvalho Chehab
@ 2023-03-21 15:20 ` Patchwork
2023-03-21 20:16 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2023-03-21 15:20 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 13287 bytes --]
== Series Details ==
Series: Add support for Xe driver unload/reload
URL : https://patchwork.freedesktop.org/series/115451/
State : success
== Summary ==
CI Bug Log - changes from IGT_7210 -> IGTPW_8653
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/index.html
Participating hosts (35 -> 36)
------------------------------
Additional (2): bat-rpls-2 bat-atsm-1
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in IGTPW_8653 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-rpls-2: NOTRUN -> [SKIP][1] ([i915#7456])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-rpls-2/igt@debugfs_test@basic-hwmon.html
* igt@fbdev@eof:
- bat-atsm-1: NOTRUN -> [SKIP][2] ([i915#2582]) +4 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-atsm-1/igt@fbdev@eof.html
* igt@fbdev@read:
- bat-rpls-2: NOTRUN -> [SKIP][3] ([i915#2582]) +4 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-rpls-2/igt@fbdev@read.html
* igt@gem_huc_copy@huc-copy:
- fi-glk-j4005: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/fi-glk-j4005/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-glk-j4005: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/fi-glk-j4005/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@verify-random:
- bat-rpls-2: NOTRUN -> [SKIP][6] ([i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-rpls-2/igt@gem_lmem_swapping@verify-random.html
* igt@gem_mmap@basic:
- bat-atsm-1: NOTRUN -> [SKIP][7] ([i915#4083])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-atsm-1/igt@gem_mmap@basic.html
* igt@gem_tiled_fence_blits@basic:
- bat-atsm-1: NOTRUN -> [SKIP][8] ([i915#4077]) +2 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-atsm-1/igt@gem_tiled_fence_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-atsm-1: NOTRUN -> [SKIP][9] ([i915#4079]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-atsm-1/igt@gem_tiled_pread_basic.html
- bat-rpls-2: NOTRUN -> [SKIP][10] ([i915#3282])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-rpls-2/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-rpls-2: NOTRUN -> [SKIP][11] ([i915#7561])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-rpls-2/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rps@basic-api:
- bat-rpls-2: NOTRUN -> [SKIP][12] ([i915#6621])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-rpls-2/igt@i915_pm_rps@basic-api.html
- bat-atsm-1: NOTRUN -> [SKIP][13] ([i915#6621])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-atsm-1/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@gt_pm:
- bat-rpls-2: NOTRUN -> [DMESG-FAIL][14] ([i915#4258])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@slpc:
- bat-rpls-2: NOTRUN -> [DMESG-FAIL][15] ([i915#6367] / [i915#7913] / [i915#7996])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-rpls-2/igt@i915_selftest@live@slpc.html
- bat-rpls-1: NOTRUN -> [DMESG-FAIL][16] ([i915#6367] / [i915#7996])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-rpls-1/igt@i915_selftest@live@slpc.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-atsm-1: NOTRUN -> [SKIP][17] ([i915#6645])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-atsm-1/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_addfb_basic@size-max:
- bat-atsm-1: NOTRUN -> [SKIP][18] ([i915#6077]) +36 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-atsm-1/igt@kms_addfb_basic@size-max.html
* igt@kms_busy@basic:
- bat-rpls-2: NOTRUN -> [SKIP][19] ([i915#1845]) +15 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-rpls-2/igt@kms_busy@basic.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-rpls-2: NOTRUN -> [SKIP][20] ([i915#7828]) +8 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-rpls-2/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
- bat-rpls-1: NOTRUN -> [SKIP][21] ([i915#7828])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-rpls-1/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-glk-j4005: NOTRUN -> [SKIP][22] ([fdo#109271]) +19 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/fi-glk-j4005/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- bat-atsm-1: NOTRUN -> [SKIP][23] ([i915#6078]) +19 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-atsm-1/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
* igt@kms_flip@basic-flip-vs-dpms:
- bat-rpls-2: NOTRUN -> [SKIP][24] ([i915#3637]) +3 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-rpls-2/igt@kms_flip@basic-flip-vs-dpms.html
* igt@kms_flip@basic-plain-flip:
- bat-atsm-1: NOTRUN -> [SKIP][25] ([i915#6166]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-atsm-1/igt@kms_flip@basic-plain-flip.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-rpls-2: NOTRUN -> [SKIP][26] ([fdo#109285])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-rpls-2/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-atsm-1: NOTRUN -> [SKIP][27] ([i915#6093]) +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-atsm-1/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_frontbuffer_tracking@basic:
- bat-rpls-2: NOTRUN -> [SKIP][28] ([i915#1849])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-rpls-2/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@hang-read-crc:
- bat-atsm-1: NOTRUN -> [SKIP][29] ([i915#1836]) +6 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-atsm-1/igt@kms_pipe_crc_basic@hang-read-crc.html
* igt@kms_pipe_crc_basic@read-crc:
- bat-adlp-9: NOTRUN -> [SKIP][30] ([i915#3546]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-adlp-9/igt@kms_pipe_crc_basic@read-crc.html
* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-rpls-1: NOTRUN -> [SKIP][31] ([i915#1845])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-rpls-1/igt@kms_pipe_crc_basic@suspend-read-crc.html
* igt@kms_prop_blob@basic:
- bat-atsm-1: NOTRUN -> [SKIP][32] ([i915#7357])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-atsm-1/igt@kms_prop_blob@basic.html
* igt@kms_psr@sprite_plane_onoff:
- bat-rpls-2: NOTRUN -> [SKIP][33] ([i915#1072]) +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-rpls-2/igt@kms_psr@sprite_plane_onoff.html
- bat-atsm-1: NOTRUN -> [SKIP][34] ([i915#1072]) +3 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-atsm-1/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-atsm-1: NOTRUN -> [SKIP][35] ([i915#6094])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-atsm-1/igt@kms_setmode@basic-clone-single-crtc.html
- bat-rpls-2: NOTRUN -> [SKIP][36] ([i915#3555])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-rpls-2/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- bat-atsm-1: NOTRUN -> [SKIP][37] ([fdo#109295] / [i915#6078])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-atsm-1/igt@prime_vgem@basic-fence-flip.html
- bat-rpls-2: NOTRUN -> [SKIP][38] ([fdo#109295] / [i915#1845] / [i915#3708])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-rpls-2/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-fence-mmap:
- bat-atsm-1: NOTRUN -> [SKIP][39] ([fdo#109295] / [i915#4077]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-atsm-1/igt@prime_vgem@basic-fence-mmap.html
* igt@prime_vgem@basic-fence-read:
- bat-rpls-2: NOTRUN -> [SKIP][40] ([fdo#109295] / [i915#3708]) +3 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-rpls-2/igt@prime_vgem@basic-fence-read.html
* igt@prime_vgem@basic-write:
- bat-atsm-1: NOTRUN -> [SKIP][41] ([fdo#109295]) +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-atsm-1/igt@prime_vgem@basic-write.html
#### Possible fixes ####
* igt@i915_module_load@load:
- fi-glk-j4005: [ABORT][42] -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/fi-glk-j4005/igt@i915_module_load@load.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/fi-glk-j4005/igt@i915_module_load@load.html
* igt@i915_selftest@live@requests:
- bat-rpls-1: [ABORT][44] ([i915#7911] / [i915#7982]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/bat-rpls-1/igt@i915_selftest@live@requests.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/bat-rpls-1/igt@i915_selftest@live@requests.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#6077]: https://gitlab.freedesktop.org/drm/intel/issues/6077
[i915#6078]: https://gitlab.freedesktop.org/drm/intel/issues/6078
[i915#6093]: https://gitlab.freedesktop.org/drm/intel/issues/6093
[i915#6094]: https://gitlab.freedesktop.org/drm/intel/issues/6094
[i915#6166]: https://gitlab.freedesktop.org/drm/intel/issues/6166
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#7357]: https://gitlab.freedesktop.org/drm/intel/issues/7357
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
[i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7210 -> IGTPW_8653
CI-20190529: 20190529
CI_DRM_12884: 1d4054731cfcb1cb9810d309b70535ae0b90ecf0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8653: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/index.html
IGT_7210: 5f7116708590b55864456acd993ecdb02374a06f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
+igt@xe_module_load@force-load
+igt@xe_module_load@load
+igt@xe_module_load@many-reload
+igt@xe_module_load@reload
+igt@xe_module_load@reload-no-display
+igt@xe_module_load@unload
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/index.html
[-- Attachment #2: Type: text/html, Size: 16168 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for Add support for Xe driver unload/reload
2023-03-21 14:46 [igt-dev] [PATCH i-g-t 0/2] Add support for Xe driver unload/reload Mauro Carvalho Chehab
` (2 preceding siblings ...)
2023-03-21 15:20 ` [igt-dev] ✓ Fi.CI.BAT: success for Add support for Xe driver unload/reload Patchwork
@ 2023-03-21 20:16 ` Patchwork
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2023-03-21 20:16 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 26834 bytes --]
== Series Details ==
Series: Add support for Xe driver unload/reload
URL : https://patchwork.freedesktop.org/series/115451/
State : success
== Summary ==
CI Bug Log - changes from IGT_7210_full -> IGTPW_8653_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/index.html
Participating hosts (8 -> 7)
------------------------------
Missing (1): shard-rkl0
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8653_full:
### IGT changes ###
#### Possible regressions ####
* {igt@xe_module_load@force-load} (NEW):
- {shard-rkl}: NOTRUN -> [SKIP][1] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-rkl-2/igt@xe_module_load@force-load.html
- {shard-dg1}: NOTRUN -> [SKIP][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-dg1-18/igt@xe_module_load@force-load.html
- {shard-tglu}: NOTRUN -> [SKIP][3] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-tglu-3/igt@xe_module_load@force-load.html
* {igt@xe_module_load@many-reload} (NEW):
- shard-snb: NOTRUN -> [FAIL][4] +2 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-snb5/igt@xe_module_load@many-reload.html
- {shard-dg1}: NOTRUN -> [FAIL][5] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-dg1-13/igt@xe_module_load@many-reload.html
- {shard-tglu}: NOTRUN -> [FAIL][6] +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-tglu-6/igt@xe_module_load@many-reload.html
* {igt@xe_module_load@reload} (NEW):
- shard-glk: NOTRUN -> [FAIL][7] +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-glk9/igt@xe_module_load@reload.html
- {shard-rkl}: NOTRUN -> [FAIL][8] +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-rkl-3/igt@xe_module_load@reload.html
* {igt@xe_module_load@reload-no-display} (NEW):
- shard-apl: NOTRUN -> [FAIL][9] +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-apl1/igt@xe_module_load@reload-no-display.html
New tests
---------
New tests have been introduced between IGT_7210_full and IGTPW_8653_full:
### New IGT tests (6) ###
* igt@xe_module_load@force-load:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@xe_module_load@load:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@xe_module_load@many-reload:
- Statuses : 5 fail(s)
- Exec time: [0.0] s
* igt@xe_module_load@reload:
- Statuses : 6 fail(s)
- Exec time: [0.0] s
* igt@xe_module_load@reload-no-display:
- Statuses : 5 fail(s)
- Exec time: [0.0] s
* igt@xe_module_load@unload:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in IGTPW_8653_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][10] -> [FAIL][11] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-snb: NOTRUN -> [SKIP][12] ([fdo#109271]) +2 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-snb7/igt@kms_cursor_crc@cursor-alpha-opaque.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [PASS][13] -> [FAIL][14] ([i915#2346])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-glk2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
- shard-apl: [PASS][15] -> [FAIL][16] ([i915#2346])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-blt:
- shard-snb: [PASS][17] -> [SKIP][18] ([fdo#109271])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-snb7/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-blt.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-snb7/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-blt.html
* {igt@xe_module_load@force-load} (NEW):
- shard-apl: NOTRUN -> [SKIP][19] ([fdo#109271]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-apl2/igt@xe_module_load@force-load.html
- shard-glk: NOTRUN -> [SKIP][20] ([fdo#109271]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-glk1/igt@xe_module_load@force-load.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-check-all@rcs0:
- {shard-rkl}: [FAIL][21] ([i915#7742]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-rkl-6/igt@drm_fdinfo@most-busy-check-all@rcs0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-rkl-4/igt@drm_fdinfo@most-busy-check-all@rcs0.html
* igt@fbdev@write:
- {shard-tglu}: [SKIP][23] ([i915#2582]) -> [PASS][24] +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-tglu-10/igt@fbdev@write.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-tglu-3/igt@fbdev@write.html
* {igt@gem_barrier_race@remote-request@rcs0}:
- {shard-tglu}: [ABORT][25] ([i915#8211]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-tglu-10/igt@gem_barrier_race@remote-request@rcs0.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-tglu-10/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-rkl}: [FAIL][27] ([i915#6268]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-rkl-6/igt@gem_ctx_exec@basic-nohangcheck.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-rkl-3/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_ctx_persistence@hang:
- {shard-rkl}: [SKIP][29] ([i915#6252]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-rkl-5/igt@gem_ctx_persistence@hang.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-rkl-4/igt@gem_ctx_persistence@hang.html
* igt@gem_eio@reset-stress:
- {shard-dg1}: [FAIL][31] ([i915#5784]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-dg1-17/igt@gem_eio@reset-stress.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-dg1-18/igt@gem_eio@reset-stress.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][33] ([i915#2846]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-glk9/igt@gem_exec_fair@basic-deadline.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-glk1/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none@vcs0:
- {shard-rkl}: [FAIL][35] ([i915#2842]) -> [PASS][36] +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-rkl-6/igt@gem_exec_fair@basic-none@vcs0.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-rkl-5/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: [FAIL][37] ([i915#2842]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-glk7/igt@gem_exec_fair@basic-pace@rcs0.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-glk8/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_reloc@basic-gtt-wc-noreloc:
- {shard-rkl}: [SKIP][39] ([i915#3281]) -> [PASS][40] +9 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-rkl-3/igt@gem_exec_reloc@basic-gtt-wc-noreloc.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-rkl-5/igt@gem_exec_reloc@basic-gtt-wc-noreloc.html
* igt@gem_exec_schedule@semaphore-power:
- {shard-rkl}: [SKIP][41] ([i915#7276]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-rkl-6/igt@gem_exec_schedule@semaphore-power.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-rkl-5/igt@gem_exec_schedule@semaphore-power.html
* igt@gem_lmem_swapping@smem-oom@lmem0:
- {shard-dg1}: [DMESG-WARN][43] ([i915#4936]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-dg1-15/igt@gem_lmem_swapping@smem-oom@lmem0.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-dg1-13/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@gem_partial_pwrite_pread@reads-uncached:
- {shard-rkl}: [SKIP][45] ([i915#3282]) -> [PASS][46] +6 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-rkl-4/igt@gem_partial_pwrite_pread@reads-uncached.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-rkl-5/igt@gem_partial_pwrite_pread@reads-uncached.html
* igt@gen9_exec_parse@batch-invalid-length:
- {shard-rkl}: [SKIP][47] ([i915#2527]) -> [PASS][48] +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-rkl-4/igt@gen9_exec_parse@batch-invalid-length.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-rkl-5/igt@gen9_exec_parse@batch-invalid-length.html
* igt@i915_pm_dc@dc6-dpms:
- {shard-tglu}: [FAIL][49] ([i915#3989] / [i915#454]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-tglu-7/igt@i915_pm_dc@dc6-dpms.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-tglu-2/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [SKIP][51] ([fdo#109271]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-apl2/igt@i915_pm_dc@dc9-dpms.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-apl7/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- {shard-dg1}: [SKIP][53] ([i915#1937]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-dg1-15/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-dg1-14/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- {shard-rkl}: [WARN][55] ([i915#2681]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-rkl-5/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-rkl-2/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
* igt@i915_pm_rpm@dpms-lpsp:
- {shard-tglu}: [SKIP][57] ([i915#1397]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-tglu-9/igt@i915_pm_rpm@dpms-lpsp.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-tglu-3/igt@i915_pm_rpm@dpms-lpsp.html
* igt@i915_pm_rpm@drm-resources-equal:
- {shard-tglu}: [SKIP][59] ([i915#3547]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-tglu-9/igt@i915_pm_rpm@drm-resources-equal.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-tglu-8/igt@i915_pm_rpm@drm-resources-equal.html
* igt@i915_pm_sseu@full-enable:
- {shard-rkl}: [SKIP][61] ([i915#4387]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-rkl-3/igt@i915_pm_sseu@full-enable.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-rkl-5/igt@i915_pm_sseu@full-enable.html
* igt@kms_big_fb@x-tiled-8bpp-rotate-180:
- {shard-tglu}: [SKIP][63] ([i915#1845]) -> [PASS][64] +18 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-tglu-10/igt@kms_big_fb@x-tiled-8bpp-rotate-180.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-tglu-3/igt@kms_big_fb@x-tiled-8bpp-rotate-180.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- {shard-tglu}: [SKIP][65] ([i915#1849]) -> [PASS][66] +9 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-tglu-10/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-tglu-1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render:
- {shard-rkl}: [SKIP][67] ([i915#1849] / [i915#4098]) -> [PASS][68] +11 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-rkl-4/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render.html
* igt@kms_pipe_crc_basic@bad-source:
- {shard-rkl}: [SKIP][69] ([i915#1845] / [i915#4098]) -> [PASS][70] +8 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-rkl-4/igt@kms_pipe_crc_basic@bad-source.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-rkl-6/igt@kms_pipe_crc_basic@bad-source.html
* igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-a:
- {shard-rkl}: [SKIP][71] ([i915#4098]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-rkl-2/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-a.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-rkl-6/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-a.html
* igt@kms_vblank@pipe-a-query-forked:
- {shard-tglu}: [SKIP][73] ([i915#1845] / [i915#7651]) -> [PASS][74] +25 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-tglu-9/igt@kms_vblank@pipe-a-query-forked.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-tglu-7/igt@kms_vblank@pipe-a-query-forked.html
* igt@perf_pmu@idle@rcs0:
- {shard-rkl}: [FAIL][75] ([i915#4349]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-rkl-3/igt@perf_pmu@idle@rcs0.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-rkl-3/igt@perf_pmu@idle@rcs0.html
* igt@prime_vgem@basic-write:
- {shard-rkl}: [SKIP][77] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7210/shard-rkl-4/igt@prime_vgem@basic-write.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/shard-rkl-5/igt@prime_vgem@basic-write.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5251]: https://gitlab.freedesktop.org/drm/intel/issues/5251
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5431]: https://gitlab.freedesktop.org/drm/intel/issues/5431
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#7178]: https://gitlab.freedesktop.org/drm/intel/issues/7178
[i915#7276]: https://gitlab.freedesktop.org/drm/intel/issues/7276
[i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
[i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8018]: https://gitlab.freedesktop.org/drm/intel/issues/8018
[i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152
[i915#8154]: https://gitlab.freedesktop.org/drm/intel/issues/8154
[i915#8155]: https://gitlab.freedesktop.org/drm/intel/issues/8155
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8282]: https://gitlab.freedesktop.org/drm/intel/issues/8282
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7210 -> IGTPW_8653
CI-20190529: 20190529
CI_DRM_12884: 1d4054731cfcb1cb9810d309b70535ae0b90ecf0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8653: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/index.html
IGT_7210: 5f7116708590b55864456acd993ecdb02374a06f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8653/index.html
[-- Attachment #2: Type: text/html, Size: 20692 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_kmod: add support for Xe driver
2023-03-21 14:46 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_kmod: add support for Xe driver Mauro Carvalho Chehab
@ 2023-03-22 10:41 ` Kamil Konieczny
0 siblings, 0 replies; 8+ messages in thread
From: Kamil Konieczny @ 2023-03-22 10:41 UTC (permalink / raw)
To: igt-dev
Hi Mauro,
On 2023-03-21 at 15:46:13 +0100, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
>
> Change the kmod logic to also work with the Xe driver.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
> lib/igt_kmod.c | 34 +++++++++++++++++-----------------
> lib/igt_kmod.h | 31 ++++++++++++++++++++++++++++---
> 2 files changed, 45 insertions(+), 20 deletions(-)
>
> diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
> index 6d6ecf0187ed..ccf0063ca1b1 100644
> --- a/lib/igt_kmod.c
> +++ b/lib/igt_kmod.c
> @@ -404,23 +404,23 @@ static void *strdup_realloc(char *origptr, const char *strdata)
> }
>
> /**
> - * igt_i915_driver_load:
> - * @opts: options to pass to i915 driver
> + * igt_intel_driver_load:
> + * @opts: options to pass to Intel driver
> *
> - * Loads the i915 driver and its dependencies.
> + * Loads an Intel driver and its dependencies.
> *
> */
> int
> -igt_i915_driver_load(const char *opts)
> +igt_intel_driver_load(const char *opts, const char *driver)
> {
> int ret;
>
> if (opts)
> - igt_info("Reloading i915 with %s\n\n", opts);
> + igt_info("Reloading %s with %s\n\n", driver, opts);
>
> - ret = igt_kmod_load("i915", opts);
> + ret = igt_kmod_load(driver, opts);
> if (ret) {
> - igt_debug("Could not load i915\n");
> + igt_debug("Could not load %s\n", driver);
> return ret;
> }
>
> @@ -496,7 +496,7 @@ int igt_audio_driver_unload(char **who)
> return igt_always_unload_audio_driver(who);
> }
>
> -int __igt_i915_driver_unload(char **who)
> +int __igt_intel_driver_unload(char **who, const char *driver)
> {
> int ret;
>
> @@ -530,11 +530,11 @@ int __igt_i915_driver_unload(char **who)
> }
> }
>
> - if (igt_kmod_is_loaded("i915")) {
> - ret = igt_kmod_unload("i915", 0);
> + if (igt_kmod_is_loaded(driver)) {
> + ret = igt_kmod_unload(driver, 0);
> if (ret) {
> if (who)
> - *who = strdup_realloc(*who, "i915");
> + *who = strdup_realloc(*who, driver);
>
> return ret;
> }
> @@ -544,18 +544,18 @@ int __igt_i915_driver_unload(char **who)
> }
>
> /**
> - * igt_i915_driver_unload:
> + * igt_intel_driver_unload:
> *
> - * Unloads the i915 driver and its dependencies.
> + * Unloads an Intel driver and its dependencies.
> *
> */
> int
> -igt_i915_driver_unload(void)
> +igt_intel_driver_unload(const char *driver)
> {
> char *who = NULL;
> int ret;
>
> - ret = __igt_i915_driver_unload(&who);
> + ret = __igt_intel_driver_unload(&who, driver);
> if (ret) {
> igt_warn("Could not unload %s\n", who);
> igt_kmod_list_loaded();
> @@ -572,8 +572,8 @@ igt_i915_driver_unload(void)
> igt_kmod_unload("drm_kms_helper", 0);
> igt_kmod_unload("drm", 0);
>
> - if (igt_kmod_is_loaded("i915")) {
> - igt_warn("i915.ko still loaded!\n");
> + if (igt_kmod_is_loaded("driver")) {
> + igt_warn("%s.ko still loaded!\n", driver);
> return -EBUSY;
> }
>
> diff --git a/lib/igt_kmod.h b/lib/igt_kmod.h
> index f98dd29fb175..a6b422abf328 100644
> --- a/lib/igt_kmod.h
> +++ b/lib/igt_kmod.h
> @@ -38,9 +38,34 @@ int igt_kmod_unload(const char *mod_name, unsigned int flags);
>
> int igt_audio_driver_unload(char **whom);
>
> -int igt_i915_driver_load(const char *opts);
> -int igt_i915_driver_unload(void);
> -int __igt_i915_driver_unload(char **whom);
> +int igt_intel_driver_load(const char *opts, const char *driver);
> +int igt_intel_driver_unload(const char *driver);
> +int __igt_intel_driver_unload(char **who, const char *driver);
> +
> +static inline int igt_i915_driver_load(const char *opts)
> +{
> + return igt_intel_driver_load(opts, "i915");
> +}
> +
> +static inline int igt_i915_driver_unload(void)
> +{
> + return igt_intel_driver_unload("i915");
> +}
> +
> +static inline int __igt_i915_driver_unload(char **whom) {
---------------------------------------------------------- ^
This should be in new line.
With that fixed
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
--
Kamil
> + return __igt_intel_driver_unload(whom, "i915");
> +};
> +
> +static inline int igt_xe_driver_load(const char *opts)
> +{
> + return igt_intel_driver_load(opts, "xe");
> +}
> +
> +
> +static inline int igt_xe_driver_unload(void)
> +{
> + return igt_intel_driver_unload("xe");
> +}
>
> int igt_amdgpu_driver_load(const char *opts);
> int igt_amdgpu_driver_unload(void);
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] xe/xe_module_load: add a test to load/unload Xe driver
2023-03-21 14:46 ` [igt-dev] [PATCH i-g-t 2/2] xe/xe_module_load: add a test to load/unload " Mauro Carvalho Chehab
@ 2023-03-22 12:06 ` Kamil Konieczny
2023-03-22 12:24 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 8+ messages in thread
From: Kamil Konieczny @ 2023-03-22 12:06 UTC (permalink / raw)
To: igt-dev
Hi Mauro,
On 2023-03-21 at 15:46:14 +0100, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
>
> This is helpful to allow IGT to check if there are issues
> during module load/unload.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
> tests/intel-ci/xe-fast-feedback.testlist | 3 +
> tests/meson.build | 1 +
> tests/xe/xe_module_load.c | 163 +++++++++++++++++++++++
> 3 files changed, 167 insertions(+)
> create mode 100644 tests/xe/xe_module_load.c
>
> diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
> index 6525b1676b6f..3140d648833a 100644
> --- a/tests/intel-ci/xe-fast-feedback.testlist
> +++ b/tests/intel-ci/xe-fast-feedback.testlist
> @@ -1,3 +1,6 @@
> +# Should be the first test
> +igt@xe_module_load@force-load
> +
> igt@xe_compute@compute-square
> igt@xe_debugfs@base
> igt@xe_debugfs@gt
> diff --git a/tests/meson.build b/tests/meson.build
> index 632e36e059d8..f9fef103a736 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -256,6 +256,7 @@ xe_progs = [
> 'xe_huc_copy',
> 'xe_mmap',
> 'xe_mmio',
> + 'xe_module_load',
> 'xe_pm',
> 'xe_prime_self_import',
> 'xe_query',
> diff --git a/tests/xe/xe_module_load.c b/tests/xe/xe_module_load.c
> new file mode 100644
> index 000000000000..00302be561c1
> --- /dev/null
> +++ b/tests/xe/xe_module_load.c
> @@ -0,0 +1,163 @@
> +// SPDX-License-Identifier: MIT
> +/*
> + * Copyright © 2023 Intel Corporation
> + */
> +
> +/**
> + * TEST: Tests the xe module loading
> + * Category: Sofware building block
> + * Sub-category: driver
> + * Test category: functionality test
> + */
> +
> +#include "igt.h"
------------ ^
Move this after system includes.
> +#include <dirent.h>
> +#include <sys/utsname.h>
> +#ifdef __linux__
> +#include <linux/limits.h>
> +#endif
> +#include <signal.h>
------------ ^
> +#include <libgen.h>
> +#include <signal.h>
------------ ^
Duplicated.
> +#include <sys/ioctl.h>
> +#include <fcntl.h>
Consider sorting system include aplhabetically.
> +
> +#include "igt_debugfs.h"
> +#include "igt_aux.h"
> +#include "igt_kmod.h"
> +#include "igt_sysfs.h"
> +#include "igt_core.h"
These also may be sorted.
Please add global description here, for example:
IGT_TEST_DESCRIPTION("Check Xe module loading.");
> +
> +#define BAR_SIZE_SHIFT 20
> +#define MIN_BAR_SIZE 256
> +
> +static void
> +hda_dynamic_debug(bool enable)
Please write it on one line:
static void hda_dynamic_debug(bool enable)
> +{
> + FILE *fp;
> + const char snd_hda_intel_on[] = "module snd_hda_intel +pf";
------- ^
Add static to const char*, here and below.
> + const char snd_hda_core_on[] = "module snd_hda_core +pf";
> +
> + const char snd_hda_intel_off[] = "module snd_hda_core =_";
> + const char snd_hda_core_off[] = "module snd_hda_intel =_";
> +
> + fp = fopen("/sys/kernel/debug/dynamic_debug/control", "w");
> + if (!fp) {
> + igt_debug("hda dynamic debug not available\n");
> + return;
> + }
> +
> + if (enable) {
> + fwrite(snd_hda_intel_on, 1, sizeof(snd_hda_intel_on), fp);
> + fwrite(snd_hda_core_on, 1, sizeof(snd_hda_core_on), fp);
> + } else {
> + fwrite(snd_hda_intel_off, 1, sizeof(snd_hda_intel_off), fp);
> + fwrite(snd_hda_core_off, 1, sizeof(snd_hda_core_off), fp);
> + }
> +
> + fclose(fp);
> +}
> +
> +static void load_and_check_xe(const char *opts)
> +{
> + int error;
> + int drm_fd;
> +
> + hda_dynamic_debug(true);
> + error = igt_xe_driver_load(opts);
> + hda_dynamic_debug(false);
> +
> + igt_assert_eq(error, 0);
> +
> + /* driver is ready, check if it's bound */
> + drm_fd = __drm_open_driver(DRIVER_XE);
> + igt_fail_on_f(drm_fd < 0, "Cannot open the xe DRM driver after modprobing xe.\n");
> +}
> +
> +/**
> + * SUBTEST: force-load
> + * Description: Load the Xe driver passing ``force_probe=*`` parameter
> + * Run type: BAT
> + *
> + * SUBTEST: load
> + * Description: Load the Xe driver
> + * Run type: FULL
> + *
> + * SUBTEST: unload
> + * Description: Unload the Xe driver
> + * Run type: FULL
> + *
> + * SUBTEST: reload
> + * Description: Reload the Xe driver
> + * Run type: FULL
> + *
> + * SUBTEST: reload-no-display
> + * Description: Reload the Xe driver passing ``enable_display=0`` parameter
> + * Run type: FULL
> + *
> + * SUBTEST: many-reload
> + * Description: Reload the Xe driver many times
> + * Run type: FULL
> + */
> +igt_main
> +{
> + igt_describe("Check if xe and friends are not yet loaded, then load them.");
> + igt_subtest("load") {
> + const char * unwanted_drivers[] = {
--------------- ^ --------- ^
static const char *unwanted_drivers[] = {
> + "xe",
> + "i915",
> + NULL
> + };
> +
> + for (int i = 0; unwanted_drivers[i] != NULL; i++) {
> + igt_skip_on_f(igt_kmod_is_loaded(unwanted_drivers[i]),
> + "%s is already loaded\n", unwanted_drivers[i]);
-- ^
Use more tabs.
> + }
> +
> + load_and_check_xe(NULL);
> + }
> +
Add here description with igt_describe.
> + igt_subtest("unload") {
> + igt_xe_driver_unload();
> + }
> +
Same here.
> + igt_subtest("force-load") {
> + const char * unwanted_drivers[] = {
--------------- ^ --------- ^
These are the same as above, maybe declare that before all tests
in igt_main ? Or maybe make it separate function and call it
from two places ?
> + "xe",
> + "i915",
> + NULL
> + };
> +
> + for (int i = 0; unwanted_drivers[i] != NULL; i++) {
> + igt_skip_on_f(igt_kmod_is_loaded(unwanted_drivers[i]),
> + "%s is already loaded\n", unwanted_drivers[i]);
-- ^
Use more tabs.
> + }
> +
> + load_and_check_xe("force_probe=*");
> + }
> +
Same here, write description.
> + igt_subtest("reload-no-display") {
> + igt_xe_driver_unload();
> + load_and_check_xe("enable_display=0");
> + }
> +
> +
Remove extra empty line, add description.
> + igt_subtest("many-reload") {
> + int i;
> +
> + for (i = 0; i < 10; i++) {
imho here it is worth printing igt_debug("reload cycle: %d\n", i);
> + igt_xe_driver_unload();
> + load_and_check_xe(NULL);
> + sleep(1);
> + }
> + }
> +
Add description.
Regards,
Kamil
> + igt_subtest("reload") {
> + igt_xe_driver_unload();
> + load_and_check_xe(NULL);
> +
> + /* only default modparams, can leave module loaded */
> + }
> +
> + /* Subtests should unload the module themselves if they use modparams */
> +}
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] xe/xe_module_load: add a test to load/unload Xe driver
2023-03-22 12:06 ` Kamil Konieczny
@ 2023-03-22 12:24 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 8+ messages in thread
From: Mauro Carvalho Chehab @ 2023-03-22 12:24 UTC (permalink / raw)
To: Kamil Konieczny; +Cc: igt-dev
On Wed, 22 Mar 2023 13:06:28 +0100
Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote:
> Hi Mauro,
>
> On 2023-03-21 at 15:46:14 +0100, Mauro Carvalho Chehab wrote:
> > From: Mauro Carvalho Chehab <mchehab@kernel.org>
> >
> > This is helpful to allow IGT to check if there are issues
> > during module load/unload.
> >
> > Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> > ---
> > tests/intel-ci/xe-fast-feedback.testlist | 3 +
> > tests/meson.build | 1 +
> > tests/xe/xe_module_load.c | 163 +++++++++++++++++++++++
> > 3 files changed, 167 insertions(+)
> > create mode 100644 tests/xe/xe_module_load.c
> >
> > diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
> > index 6525b1676b6f..3140d648833a 100644
> > --- a/tests/intel-ci/xe-fast-feedback.testlist
> > +++ b/tests/intel-ci/xe-fast-feedback.testlist
> > @@ -1,3 +1,6 @@
> > +# Should be the first test
> > +igt@xe_module_load@force-load
> > +
> > igt@xe_compute@compute-square
> > igt@xe_debugfs@base
> > igt@xe_debugfs@gt
> > diff --git a/tests/meson.build b/tests/meson.build
> > index 632e36e059d8..f9fef103a736 100644
> > --- a/tests/meson.build
> > +++ b/tests/meson.build
> > @@ -256,6 +256,7 @@ xe_progs = [
> > 'xe_huc_copy',
> > 'xe_mmap',
> > 'xe_mmio',
> > + 'xe_module_load',
> > 'xe_pm',
> > 'xe_prime_self_import',
> > 'xe_query',
> > diff --git a/tests/xe/xe_module_load.c b/tests/xe/xe_module_load.c
> > new file mode 100644
> > index 000000000000..00302be561c1
> > --- /dev/null
> > +++ b/tests/xe/xe_module_load.c
> > @@ -0,0 +1,163 @@
> > +// SPDX-License-Identifier: MIT
> > +/*
> > + * Copyright © 2023 Intel Corporation
> > + */
> > +
> > +/**
> > + * TEST: Tests the xe module loading
> > + * Category: Sofware building block
> > + * Sub-category: driver
> > + * Test category: functionality test
> > + */
> > +
> > +#include "igt.h"
> ------------ ^
> Move this after system includes.
>
> > +#include <dirent.h>
> > +#include <sys/utsname.h>
> > +#ifdef __linux__
> > +#include <linux/limits.h>
> > +#endif
> > +#include <signal.h>
> ------------ ^
> > +#include <libgen.h>
> > +#include <signal.h>
> ------------ ^
> Duplicated.
>
> > +#include <sys/ioctl.h>
> > +#include <fcntl.h>
>
> Consider sorting system include aplhabetically.
>
> > +
> > +#include "igt_debugfs.h"
> > +#include "igt_aux.h"
> > +#include "igt_kmod.h"
> > +#include "igt_sysfs.h"
> > +#include "igt_core.h"
>
> These also may be sorted.
Ok.
>
> Please add global description here, for example:
>
> IGT_TEST_DESCRIPTION("Check Xe module loading.");
With regards to IGT documentation, it is provided already, via the
comments, which, in turn, already produces documentation:
> > +/**
> > + * TEST: Tests the xe module loading
> > + * Category: Sofware building block
> > + * Sub-category: driver
> > + * Test category: functionality test
> > + */
Which is more complete than what IGT_TEST_DESCRIPTION() would allow.
IMO, keeping both will just duplicate information for no good reason,
and it makes harder to maintain, as the same descriptions will be on
two parts of the test file.
> > +
> > +#define BAR_SIZE_SHIFT 20
> > +#define MIN_BAR_SIZE 256
> > +
> > +static void
> > +hda_dynamic_debug(bool enable)
>
> Please write it on one line:
>
> static void hda_dynamic_debug(bool enable)
>
> > +{
> > + FILE *fp;
> > + const char snd_hda_intel_on[] = "module snd_hda_intel +pf";
> ------- ^
> Add static to const char*, here and below.
>
> > + const char snd_hda_core_on[] = "module snd_hda_core +pf";
> > +
> > + const char snd_hda_intel_off[] = "module snd_hda_core =_";
> > + const char snd_hda_core_off[] = "module snd_hda_intel =_";
> > +
> > + fp = fopen("/sys/kernel/debug/dynamic_debug/control", "w");
> > + if (!fp) {
> > + igt_debug("hda dynamic debug not available\n");
> > + return;
> > + }
> > +
> > + if (enable) {
> > + fwrite(snd_hda_intel_on, 1, sizeof(snd_hda_intel_on), fp);
> > + fwrite(snd_hda_core_on, 1, sizeof(snd_hda_core_on), fp);
> > + } else {
> > + fwrite(snd_hda_intel_off, 1, sizeof(snd_hda_intel_off), fp);
> > + fwrite(snd_hda_core_off, 1, sizeof(snd_hda_core_off), fp);
> > + }
> > +
> > + fclose(fp);
> > +}
> > +
> > +static void load_and_check_xe(const char *opts)
> > +{
> > + int error;
> > + int drm_fd;
> > +
> > + hda_dynamic_debug(true);
> > + error = igt_xe_driver_load(opts);
> > + hda_dynamic_debug(false);
> > +
> > + igt_assert_eq(error, 0);
> > +
> > + /* driver is ready, check if it's bound */
> > + drm_fd = __drm_open_driver(DRIVER_XE);
> > + igt_fail_on_f(drm_fd < 0, "Cannot open the xe DRM driver after modprobing xe.\n");
> > +}
> > +
> > +/**
> > + * SUBTEST: force-load
> > + * Description: Load the Xe driver passing ``force_probe=*`` parameter
> > + * Run type: BAT
> > + *
> > + * SUBTEST: load
> > + * Description: Load the Xe driver
> > + * Run type: FULL
> > + *
> > + * SUBTEST: unload
> > + * Description: Unload the Xe driver
> > + * Run type: FULL
> > + *
> > + * SUBTEST: reload
> > + * Description: Reload the Xe driver
> > + * Run type: FULL
> > + *
> > + * SUBTEST: reload-no-display
> > + * Description: Reload the Xe driver passing ``enable_display=0`` parameter
> > + * Run type: FULL
> > + *
> > + * SUBTEST: many-reload
> > + * Description: Reload the Xe driver many times
> > + * Run type: FULL
> > + */
> > +igt_main
> > +{
> > + igt_describe("Check if xe and friends are not yet loaded, then load them.");
> > + igt_subtest("load") {
> > + const char * unwanted_drivers[] = {
> --------------- ^ --------- ^
> static const char *unwanted_drivers[] = {
>
> > + "xe",
> > + "i915",
> > + NULL
> > + };
> > +
> > + for (int i = 0; unwanted_drivers[i] != NULL; i++) {
> > + igt_skip_on_f(igt_kmod_is_loaded(unwanted_drivers[i]),
> > + "%s is already loaded\n", unwanted_drivers[i]);
> -- ^
> Use more tabs.
>
> > + }
> > +
> > + load_and_check_xe(NULL);
> > + }
> > +
>
> Add here description with igt_describe.
Same comment about the description: those are at the subtest comment:
> > +/**
> > + * SUBTEST: force-load
> > + * Description: Load the Xe driver passing ``force_probe=*`` parameter
> > + * Run type: BAT
> > + *
> > + * SUBTEST: load
> > + * Description: Load the Xe driver
> > + * Run type: FULL
> > + *
> > + * SUBTEST: unload
> > + * Description: Unload the Xe driver
> > + * Run type: FULL
> > + *
> > + * SUBTEST: reload
> > + * Description: Reload the Xe driver
> > + * Run type: FULL
> > + *
> > + * SUBTEST: reload-no-display
> > + * Description: Reload the Xe driver passing ``enable_display=0`` parameter
> > + * Run type: FULL
> > + *
> > + * SUBTEST: many-reload
> > + * Description: Reload the Xe driver many times
> > + * Run type: FULL
> > + */
I'll address the remaining comments. Should send a new version soon.
Regards,
Mauro
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-03-22 12:24 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-21 14:46 [igt-dev] [PATCH i-g-t 0/2] Add support for Xe driver unload/reload Mauro Carvalho Chehab
2023-03-21 14:46 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_kmod: add support for Xe driver Mauro Carvalho Chehab
2023-03-22 10:41 ` Kamil Konieczny
2023-03-21 14:46 ` [igt-dev] [PATCH i-g-t 2/2] xe/xe_module_load: add a test to load/unload " Mauro Carvalho Chehab
2023-03-22 12:06 ` Kamil Konieczny
2023-03-22 12:24 ` Mauro Carvalho Chehab
2023-03-21 15:20 ` [igt-dev] ✓ Fi.CI.BAT: success for Add support for Xe driver unload/reload Patchwork
2023-03-21 20:16 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox