From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org, swati2.sharma@intel.com
Subject: [igt-dev] [i-g-t] lib/igt_kms: Silent errors on invalid pipe/output combo
Date: Tue, 28 Mar 2023 16:47:45 +0530 [thread overview]
Message-ID: <20230328111745.3738878-1-bhanuprakash.modem@intel.com> (raw)
To use i915_pipe_output_combo_valid(), tests must set output
to pipe. Instead of throwing an error, just return as a valid
combo.
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
lib/igt_kms.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index c12823d318e..e178ecffc1a 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -5912,7 +5912,10 @@ bool i915_pipe_output_combo_valid(igt_display_t *display)
combo++;
}
- igt_assert_f(combo, "At least one pipe/output combo needed.\n");
+ if (!combo) {
+ igt_debug("At least one pipe/output combo needed.\n");
+ return true;
+ }
/*
* Check the given pipe/output combo is valid for Bigjoiner.
--
2.40.0
next reply other threads:[~2023-03-28 11:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 11:17 Bhanuprakash Modem [this message]
2023-03-28 12:54 ` [igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_kms: Silent errors on invalid pipe/output combo Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328111745.3738878-1-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox