Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [i-g-t] lib/igt_kms: Silent errors on invalid pipe/output combo
@ 2023-03-28 11:17 Bhanuprakash Modem
  2023-03-28 12:54 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
  0 siblings, 1 reply; 2+ messages in thread
From: Bhanuprakash Modem @ 2023-03-28 11:17 UTC (permalink / raw)
  To: igt-dev, swati2.sharma

To use i915_pipe_output_combo_valid(), tests must set output
to pipe. Instead of throwing an error, just return as a valid
combo.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 lib/igt_kms.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index c12823d318e..e178ecffc1a 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -5912,7 +5912,10 @@ bool i915_pipe_output_combo_valid(igt_display_t *display)
 		combo++;
 	}
 
-	igt_assert_f(combo, "At least one pipe/output combo needed.\n");
+	if (!combo) {
+		igt_debug("At least one pipe/output combo needed.\n");
+		return true;
+	}
 
 	/*
 	 * Check the given pipe/output combo is valid for Bigjoiner.
-- 
2.40.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-28 12:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-28 11:17 [igt-dev] [i-g-t] lib/igt_kms: Silent errors on invalid pipe/output combo Bhanuprakash Modem
2023-03-28 12:54 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox