Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Maíra Canal" <mcanal@igalia.com>
To: Melissa Wen <mwen@igalia.com>,
	Petri Latvala <adrinael@adrinael.net>,
	Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 1/4] tests/kms_rotation_crc: make the subtest "bad-pixel-format" i915-specific
Date: Mon,  3 Apr 2023 10:01:21 -0300	[thread overview]
Message-ID: <20230403130124.15946-2-mcanal@igalia.com> (raw)
In-Reply-To: <20230403130124.15946-1-mcanal@igalia.com>

The subtest "bad-pixel-format" expects that RGB565 rotation is not
supported for 90 degrees, which is not necessarily true for non-i915
devices. Therefore, require the device to be i915 before running the
subtest "bad-pixel-format", as we can only guarantee bad pixel formats
for i915 devices.

Signed-off-by: Maíra Canal <mcanal@igalia.com>
---
 tests/kms_rotation_crc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index 295aed76..0d7b3962 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -1181,6 +1181,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 
 	igt_describe("Checking unsupported pixel format for gen9+ with 90 degree of rotation");
 	igt_subtest_f("bad-pixel-format") {
+		igt_require(is_i915_device(data.gfx_fd));
+
 		 /* gen11 enables RGB565 rotation for 90/270 degrees.
 		  * so apart from this, any other gen11+ pixel format
 		  * can be used which doesn't support 90/270 degree
-- 
2.39.2

  reply	other threads:[~2023-04-03 13:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-03 13:01 [igt-dev] [PATCH i-g-t 0/4] kms_rotation_crc improvements and generalization Maíra Canal
2023-04-03 13:01 ` Maíra Canal [this message]
2023-05-22 13:25   ` [igt-dev] [PATCH i-g-t 1/4] tests/kms_rotation_crc: make the subtest "bad-pixel-format" i915-specific Kamil Konieczny
2023-04-03 13:01 ` [igt-dev] [PATCH i-g-t 2/4] tests/kms_rotation_crc: use DRM_FORMAT_MOD_LINEAR as default modifier Maíra Canal
2023-05-22 13:40   ` Kamil Konieczny
2023-04-03 13:01 ` [igt-dev] [PATCH i-g-t 3/4] tests/kms_rotation_crc: add tests for a rotated plane in a given position Maíra Canal
2023-05-22 13:48   ` Kamil Konieczny
2023-04-03 13:01 ` [igt-dev] [PATCH i-g-t 4/4] tests/kms_rotation_crc: create generic reflection tests Maíra Canal
2023-05-22 14:02   ` Kamil Konieczny
2023-04-03 13:52 ` [igt-dev] ✓ Fi.CI.BAT: success for kms_rotation_crc improvements and generalization Patchwork
2023-04-03 18:37 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-04-25 11:58 ` [igt-dev] [PATCH i-g-t 0/4] " Maíra Canal
2023-04-27 17:19 ` [igt-dev] ✓ Fi.CI.BAT: success for kms_rotation_crc improvements and generalization (rev2) Patchwork
2023-04-27 23:52 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230403130124.15946-2-mcanal@igalia.com \
    --to=mcanal@igalia.com \
    --cc=adrinael@adrinael.net \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=mwen@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox