From: "Maíra Canal" <mcanal@igalia.com>
To: Melissa Wen <mwen@igalia.com>,
Petri Latvala <adrinael@adrinael.net>,
Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 0/4] kms_rotation_crc improvements and generalization
Date: Tue, 25 Apr 2023 08:58:50 -0300 [thread overview]
Message-ID: <cd4cdc0a-489b-dcb3-7e17-ae9043aba1e8@igalia.com> (raw)
In-Reply-To: <20230403130124.15946-1-mcanal@igalia.com>
Gentle ping. Thanks!
Best Regards,
- Maíra Canal
On 4/3/23 10:01, Maíra Canal wrote:
> This patchset introduces some improvements and generalizes the kms_rotation_crc
> test. Currently, I'm working on the rotation property of the vkms driver [1]
> and while working on it, I noticed that some subtests could be added and some
> subtests could be more generic.
>
> The first and second patches make the tests more generic. Currently, some
> subtests use i915 modifiers, which make the subtest fail for other vendors
> that are not Intel. Therefore, check if the device is i915 before using the
> i915-specific modifiers.
>
> The third patch expands the subtest "sprite-rotation-90-pos-100-0" by testing
> all 90, 180 and 270 degrees rotation with x and y offsets. This can helps us
> to assure that 90, 180 and 270 degrees rotation happens correctly even with
> offsets.
>
> Finally, add generic tests for reflect-x and reflect-y. Currently, there are
> no tests for reflection values. So, add some generic reflection tests to
> ensure that these properties are working correctly. Note that these subtests
> must skip on i915 devices, as i915 uses reflect-x together with specific
> modifiers.
>
> [1] https://gitlab.freedesktop.org/mairacanal/linux/-/commits/vkms/rotation
>
> Best Regards,
> - Maíra Canal
>
> Maíra Canal (4):
> tests/kms_rotation_crc: make the subtest "bad-pixel-format" i915-specific
> tests/kms_rotation_crc: use DRM_FORMAT_MOD_LINEAR as default modifier
> tests/kms_rotation_crc: add tests for a rotated plane in a given position
> tests/kms_rotation_crc: create generic reflection tests
>
> tests/kms_rotation_crc.c | 69 ++++++++++++++++++++++++++++++++++++----
> 1 file changed, 62 insertions(+), 7 deletions(-)
>
next prev parent reply other threads:[~2023-04-25 11:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 13:01 [igt-dev] [PATCH i-g-t 0/4] kms_rotation_crc improvements and generalization Maíra Canal
2023-04-03 13:01 ` [igt-dev] [PATCH i-g-t 1/4] tests/kms_rotation_crc: make the subtest "bad-pixel-format" i915-specific Maíra Canal
2023-05-22 13:25 ` Kamil Konieczny
2023-04-03 13:01 ` [igt-dev] [PATCH i-g-t 2/4] tests/kms_rotation_crc: use DRM_FORMAT_MOD_LINEAR as default modifier Maíra Canal
2023-05-22 13:40 ` Kamil Konieczny
2023-04-03 13:01 ` [igt-dev] [PATCH i-g-t 3/4] tests/kms_rotation_crc: add tests for a rotated plane in a given position Maíra Canal
2023-05-22 13:48 ` Kamil Konieczny
2023-04-03 13:01 ` [igt-dev] [PATCH i-g-t 4/4] tests/kms_rotation_crc: create generic reflection tests Maíra Canal
2023-05-22 14:02 ` Kamil Konieczny
2023-04-03 13:52 ` [igt-dev] ✓ Fi.CI.BAT: success for kms_rotation_crc improvements and generalization Patchwork
2023-04-03 18:37 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-04-25 11:58 ` Maíra Canal [this message]
2023-04-27 17:19 ` [igt-dev] ✓ Fi.CI.BAT: success for kms_rotation_crc improvements and generalization (rev2) Patchwork
2023-04-27 23:52 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd4cdc0a-489b-dcb3-7e17-ae9043aba1e8@igalia.com \
--to=mcanal@igalia.com \
--cc=adrinael@adrinael.net \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=mwen@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox