[igt-dev] [PATCH i-g-t] xe/xe_huc_copy: use IS_TIGERLAKE macro

[igt-dev] [PATCH i-g-t] xe/xe_huc_copy: use IS_TIGERLAKE macro

[Mauro Carvalho Chehab]

From: Mauro Carvalho Chehab <mchehab@kernel.org>

Instead of hardcoding the PCI IDs at the test, use a macro
to check if the platform is compatible with the test.

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 tests/xe/xe_huc_copy.c | 38 +-------------------------------------
 1 file changed, 1 insertion(+), 37 deletions(-)

diff --git a/tests/xe/xe_huc_copy.c b/tests/xe/xe_huc_copy.c
index ee3896cef8b9..cd68dbb5ac50 100644
--- a/tests/xe/xe_huc_copy.c
+++ b/tests/xe/xe_huc_copy.c
@@ -152,42 +152,6 @@ test_huc_copy(int fd)
 	xe_vm_destroy(fd, vm);
 }
 
-static bool
-is_device_supported(int fd)
-{
-	struct drm_xe_query_config *config;
-	struct drm_xe_device_query query = {
-		.extensions = 0,
-		.query = DRM_XE_DEVICE_QUERY_CONFIG,
-		.size = 0,
-		.data = 0,
-	};
-	uint16_t devid;
-
-	igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query), 0);
-
-	config = malloc(query.size);
-	igt_assert(config);
-
-	query.data = to_user_pointer(config);
-	igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query), 0);
-
-	devid = config->info[XE_QUERY_CONFIG_REV_AND_DEVICE_ID] & 0xffff;
-	return (
-			devid == 0x9A60 ||
-			devid == 0x9A68 ||
-			devid == 0x9A70 ||
-			devid == 0x9A40 ||
-			devid == 0x9A49 ||
-			devid == 0x9A59 ||
-			devid == 0x9A78 ||
-			devid == 0x9AC0 ||
-			devid == 0x9AC9 ||
-			devid == 0x9AD9 ||
-			devid == 0x9AF8
-		);
-}
-
 igt_main
 {
 	int xe;
@@ -198,7 +162,7 @@ igt_main
 	}
 
 	igt_subtest("huc_copy") {
-		igt_skip_on(!is_device_supported(xe));
+		igt_skip_on(!IS_TIGERLAKE(intel_get_drm_devid(xe)));
 		test_huc_copy(xe);
 	}
 
-- 
2.39.2

[igt-dev] ✓ Fi.CI.BAT: success for xe/xe_huc_copy: use IS_TIGERLAKE macro

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 4183 bytes --]

== Series Details ==

Series: xe/xe_huc_copy: use IS_TIGERLAKE macro
URL   : https://patchwork.freedesktop.org/series/115707/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12924 -> IGTPW_8696
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/index.html

Participating hosts (36 -> 36)
------------------------------

  No changes in participating hosts

Known issues
------------

  Here are the changes found in IGTPW_8696 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live@hangcheck:
    - bat-dg2-11:         [PASS][1] -> [ABORT][2] ([i915#7913])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12924/bat-dg2-11/igt@i915_selftest@live@hangcheck.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/bat-dg2-11/igt@i915_selftest@live@hangcheck.html

  * igt@i915_selftest@live@reset:
    - bat-rpls-1:         [PASS][3] -> [ABORT][4] ([i915#4983] / [i915#7981])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12924/bat-rpls-1/igt@i915_selftest@live@reset.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/bat-rpls-1/igt@i915_selftest@live@reset.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck@pipe-d-dp-1:
    - bat-dg2-8:          [PASS][5] -> [FAIL][6] ([i915#7932])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12924/bat-dg2-8/igt@kms_pipe_crc_basic@compare-crc-sanitycheck@pipe-d-dp-1.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/bat-dg2-8/igt@kms_pipe_crc_basic@compare-crc-sanitycheck@pipe-d-dp-1.html

  * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
    - bat-dg2-11:         NOTRUN -> [SKIP][7] ([i915#5354])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html

  
#### Possible fixes ####

  * igt@i915_pm_rps@basic-api:
    - bat-dg2-11:         [FAIL][8] ([i915#8308]) -> [PASS][9]
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12924/bat-dg2-11/igt@i915_pm_rps@basic-api.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/bat-dg2-11/igt@i915_pm_rps@basic-api.html

  * igt@i915_selftest@live@migrate:
    - bat-dg2-11:         [DMESG-WARN][10] ([i915#7699]) -> [PASS][11]
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12924/bat-dg2-11/igt@i915_selftest@live@migrate.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/bat-dg2-11/igt@i915_selftest@live@migrate.html

  
#### Warnings ####

  * igt@i915_selftest@live@slpc:
    - bat-rpls-2:         [DMESG-FAIL][12] ([i915#6367] / [i915#7913] / [i915#7996]) -> [DMESG-FAIL][13] ([i915#6997] / [i915#7913])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12924/bat-rpls-2/igt@i915_selftest@live@slpc.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/bat-rpls-2/igt@i915_selftest@live@slpc.html

  
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
  [i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
  [i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
  [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
  [i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
  [i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981
  [i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996
  [i915#8308]: https://gitlab.freedesktop.org/drm/intel/issues/8308


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7221 -> IGTPW_8696

  CI-20190529: 20190529
  CI_DRM_12924: ebd5c3d494ecd03a2f2851241c0b699f46746e4c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8696: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/index.html
  IGT_7221: 4b77c6d85024d22ca521d510f8eee574128fe04f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/index.html

[-- Attachment #2: Type: text/html, Size: 5067 bytes --]

Re: [igt-dev] [PATCH i-g-t] xe/xe_huc_copy: use IS_TIGERLAKE macro

[Kamil Konieczny]

On 2023-03-28 at 10:39:08 +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
> 
> Instead of hardcoding the PCI IDs at the test, use a macro
> to check if the platform is compatible with the test.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
>  tests/xe/xe_huc_copy.c | 38 +-------------------------------------
>  1 file changed, 1 insertion(+), 37 deletions(-)
> 
> diff --git a/tests/xe/xe_huc_copy.c b/tests/xe/xe_huc_copy.c
> index ee3896cef8b9..cd68dbb5ac50 100644
> --- a/tests/xe/xe_huc_copy.c
> +++ b/tests/xe/xe_huc_copy.c
> @@ -152,42 +152,6 @@ test_huc_copy(int fd)
>  	xe_vm_destroy(fd, vm);
>  }
>  
> -static bool
> -is_device_supported(int fd)
> -{
> -	struct drm_xe_query_config *config;
> -	struct drm_xe_device_query query = {
> -		.extensions = 0,
> -		.query = DRM_XE_DEVICE_QUERY_CONFIG,
> -		.size = 0,
> -		.data = 0,
> -	};
> -	uint16_t devid;
> -
> -	igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query), 0);
> -
> -	config = malloc(query.size);
> -	igt_assert(config);
> -
> -	query.data = to_user_pointer(config);
> -	igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query), 0);
> -
> -	devid = config->info[XE_QUERY_CONFIG_REV_AND_DEVICE_ID] & 0xffff;
> -	return (
> -			devid == 0x9A60 ||
> -			devid == 0x9A68 ||
> -			devid == 0x9A70 ||
> -			devid == 0x9A40 ||
> -			devid == 0x9A49 ||
> -			devid == 0x9A59 ||
> -			devid == 0x9A78 ||
> -			devid == 0x9AC0 ||
> -			devid == 0x9AC9 ||
> -			devid == 0x9AD9 ||
> -			devid == 0x9AF8
> -		);
> -}
> -
>  igt_main
>  {
>  	int xe;
> @@ -198,7 +162,7 @@ igt_main
>  	}
>  
>  	igt_subtest("huc_copy") {
> -		igt_skip_on(!is_device_supported(xe));
> +		igt_skip_on(!IS_TIGERLAKE(intel_get_drm_devid(xe)));

LGTM,
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

Regards,
Kamil

>  		test_huc_copy(xe);
>  	}
>  
> -- 
> 2.39.2
> 

[igt-dev] ✓ Fi.CI.IGT: success for xe/xe_huc_copy: use IS_TIGERLAKE macro

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 14131 bytes --]

== Series Details ==

Series: xe/xe_huc_copy: use IS_TIGERLAKE macro
URL   : https://patchwork.freedesktop.org/series/115707/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12924_full -> IGTPW_8696_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/index.html

Participating hosts (7 -> 7)
------------------------------

  No changes in participating hosts

Known issues
------------

  Here are the changes found in IGTPW_8696_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_isolation@preservation-s3@vcs0:
    - shard-apl:          [PASS][1] -> [ABORT][2] ([i915#180])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12924/shard-apl6/igt@gem_ctx_isolation@preservation-s3@vcs0.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/shard-apl3/igt@gem_ctx_isolation@preservation-s3@vcs0.html

  * igt@gem_exec_fair@basic-deadline:
    - shard-glk:          [PASS][3] -> [FAIL][4] ([i915#2846])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12924/shard-glk3/igt@gem_exec_fair@basic-deadline.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/shard-glk2/igt@gem_exec_fair@basic-deadline.html

  * igt@gem_exec_fair@basic-none-solo@rcs0:
    - shard-apl:          [PASS][5] -> [FAIL][6] ([i915#2842])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12924/shard-apl2/igt@gem_exec_fair@basic-none-solo@rcs0.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/shard-apl6/igt@gem_exec_fair@basic-none-solo@rcs0.html

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - shard-glk:          [PASS][7] -> [FAIL][8] ([i915#2842]) +3 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12924/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@gem_lmem_swapping@heavy-multi:
    - shard-glk:          NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#4613])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/shard-glk8/igt@gem_lmem_swapping@heavy-multi.html

  * igt@gem_mmap_wc@set-cache-level:
    - shard-snb:          [PASS][10] -> [SKIP][11] ([fdo#109271])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12924/shard-snb2/igt@gem_mmap_wc@set-cache-level.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/shard-snb2/igt@gem_mmap_wc@set-cache-level.html

  * igt@gen9_exec_parse@allowed-single:
    - shard-apl:          [PASS][12] -> [ABORT][13] ([i915#5566])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12924/shard-apl1/igt@gen9_exec_parse@allowed-single.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/shard-apl3/igt@gen9_exec_parse@allowed-single.html

  * igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
    - shard-glk:          NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#3886]) +2 similar issues
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/shard-glk5/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html

  * igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf:
    - shard-glk:          NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#658])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/shard-glk8/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html

  * igt@kms_rotation_crc@primary-y-tiled-reflect-x-90:
    - shard-glk:          NOTRUN -> [SKIP][16] ([fdo#109271]) +76 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/shard-glk6/igt@kms_rotation_crc@primary-y-tiled-reflect-x-90.html

  
#### Possible fixes ####

  * igt@gem_ctx_exec@basic-nohangcheck:
    - {shard-tglu}:       [FAIL][17] ([i915#6268]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12924/shard-tglu-2/igt@gem_ctx_exec@basic-nohangcheck.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/shard-tglu-8/igt@gem_ctx_exec@basic-nohangcheck.html

  * igt@gem_eio@hibernate:
    - {shard-tglu}:       [ABORT][19] ([i915#7975]) -> [PASS][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12924/shard-tglu-10/igt@gem_eio@hibernate.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/shard-tglu-6/igt@gem_eio@hibernate.html

  * igt@i915_pm_dc@dc9-dpms:
    - shard-apl:          [SKIP][21] ([fdo#109271]) -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12924/shard-apl7/igt@i915_pm_dc@dc9-dpms.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/shard-apl7/igt@i915_pm_dc@dc9-dpms.html

  * igt@i915_pm_rc6_residency@rc6-idle@vecs0:
    - {shard-dg1}:        [FAIL][23] ([i915#3591]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12924/shard-dg1-17/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/shard-dg1-17/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html

  * igt@i915_selftest@live@gt_heartbeat:
    - shard-apl:          [DMESG-FAIL][25] ([i915#5334]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12924/shard-apl7/igt@i915_selftest@live@gt_heartbeat.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/shard-apl4/igt@i915_selftest@live@gt_heartbeat.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1:
    - shard-glk:          [FAIL][27] ([i915#79]) -> [PASS][28]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12924/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html

  * igt@kms_flip@plain-flip-fb-recreate@a-hdmi-a1:
    - {shard-tglu}:       [FAIL][29] -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12924/shard-tglu-3/igt@kms_flip@plain-flip-fb-recreate@a-hdmi-a1.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/shard-tglu-6/igt@kms_flip@plain-flip-fb-recreate@a-hdmi-a1.html

  * {igt@perf@stress-open-close@0-rcs0}:
    - shard-glk:          [ABORT][31] ([i915#5213]) -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12924/shard-glk7/igt@perf@stress-open-close@0-rcs0.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/shard-glk6/igt@perf@stress-open-close@0-rcs0.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
  [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
  [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
  [fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
  [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
  [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
  [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
  [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
  [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
  [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
  [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
  [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
  [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
  [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
  [i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
  [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
  [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
  [i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
  [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
  [i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
  [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
  [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
  [i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
  [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
  [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
  [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
  [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
  [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
  [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
  [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
  [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
  [i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
  [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
  [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
  [i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818
  [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
  [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
  [i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
  [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
  [i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
  [i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
  [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
  [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
  [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
  [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
  [i915#5431]: https://gitlab.freedesktop.org/drm/intel/issues/5431
  [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
  [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
  [i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
  [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
  [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
  [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
  [i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
  [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
  [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
  [i915#7178]: https://gitlab.freedesktop.org/drm/intel/issues/7178
  [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
  [i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
  [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
  [i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
  [i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981
  [i915#8155]: https://gitlab.freedesktop.org/drm/intel/issues/8155
  [i915#8229]: https://gitlab.freedesktop.org/drm/intel/issues/8229


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7221 -> IGTPW_8696
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_12924: ebd5c3d494ecd03a2f2851241c0b699f46746e4c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8696: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/index.html
  IGT_7221: 4b77c6d85024d22ca521d510f8eee574128fe04f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8696/index.html

[-- Attachment #2: Type: text/html, Size: 9684 bytes --]

Re: [igt-dev] [PATCH i-g-t] xe/xe_huc_copy: use IS_TIGERLAKE macro

[Lucas De Marchi]

On Tue, Mar 28, 2023 at 10:39:08AM +0200, Mauro Carvalho Chehab wrote:
>From: Mauro Carvalho Chehab <mchehab@kernel.org>
>
>Instead of hardcoding the PCI IDs at the test, use a macro
>to check if the platform is compatible with the test.
>
>Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

neither this or the previous solution scale well. Can we get this info
from huc_info in debugfs?

We are already loading HuC in platforms other than TGL

Lucas De Marchi

>---
> tests/xe/xe_huc_copy.c | 38 +-------------------------------------
> 1 file changed, 1 insertion(+), 37 deletions(-)
>
>diff --git a/tests/xe/xe_huc_copy.c b/tests/xe/xe_huc_copy.c
>index ee3896cef8b9..cd68dbb5ac50 100644
>--- a/tests/xe/xe_huc_copy.c
>+++ b/tests/xe/xe_huc_copy.c
>@@ -152,42 +152,6 @@ test_huc_copy(int fd)
> 	xe_vm_destroy(fd, vm);
> }
>
>-static bool
>-is_device_supported(int fd)
>-{
>-	struct drm_xe_query_config *config;
>-	struct drm_xe_device_query query = {
>-		.extensions = 0,
>-		.query = DRM_XE_DEVICE_QUERY_CONFIG,
>-		.size = 0,
>-		.data = 0,
>-	};
>-	uint16_t devid;
>-
>-	igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query), 0);
>-
>-	config = malloc(query.size);
>-	igt_assert(config);
>-
>-	query.data = to_user_pointer(config);
>-	igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query), 0);
>-
>-	devid = config->info[XE_QUERY_CONFIG_REV_AND_DEVICE_ID] & 0xffff;
>-	return (
>-			devid == 0x9A60 ||
>-			devid == 0x9A68 ||
>-			devid == 0x9A70 ||
>-			devid == 0x9A40 ||
>-			devid == 0x9A49 ||
>-			devid == 0x9A59 ||
>-			devid == 0x9A78 ||
>-			devid == 0x9AC0 ||
>-			devid == 0x9AC9 ||
>-			devid == 0x9AD9 ||
>-			devid == 0x9AF8
>-		);
>-}
>-
> igt_main
> {
> 	int xe;
>@@ -198,7 +162,7 @@ igt_main
> 	}
>
> 	igt_subtest("huc_copy") {
>-		igt_skip_on(!is_device_supported(xe));
>+		igt_skip_on(!IS_TIGERLAKE(intel_get_drm_devid(xe)));
> 		test_huc_copy(xe);
> 	}
>
>-- 
>2.39.2
>

Re: [igt-dev] [PATCH i-g-t] xe/xe_huc_copy: use IS_TIGERLAKE macro

[Mauro Carvalho Chehab]

On Mon, 3 Apr 2023 23:27:01 -0700
Lucas De Marchi <lucas.demarchi@intel.com> wrote:

> On Tue, Mar 28, 2023 at 10:39:08AM +0200, Mauro Carvalho Chehab wrote:
> >From: Mauro Carvalho Chehab <mchehab@kernel.org>
> >
> >Instead of hardcoding the PCI IDs at the test, use a macro
> >to check if the platform is compatible with the test.
> >
> >Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>  
> 
> neither this or the previous solution scale well. Can we get this info
> from huc_info in debugfs?
> 
> We are already loading HuC in platforms other than TGL

Changing IGT to not use IS_platform macros anymore is not an easy task,
as this is used on lots of place, for both i915 and Xe drivers.

If debugfs can be used for it on both drivers, I guess such macros
could be changed to use huc_info from debugfs. Still, not sure if 
this is worth, specially since I don't think HUC is mandatory at
the i915 driver, and such macros are meant to work with both
drivers.

Regards,
Mauro

> 
> Lucas De Marchi
> 
> >---
> > tests/xe/xe_huc_copy.c | 38 +-------------------------------------
> > 1 file changed, 1 insertion(+), 37 deletions(-)
> >
> >diff --git a/tests/xe/xe_huc_copy.c b/tests/xe/xe_huc_copy.c
> >index ee3896cef8b9..cd68dbb5ac50 100644
> >--- a/tests/xe/xe_huc_copy.c
> >+++ b/tests/xe/xe_huc_copy.c
> >@@ -152,42 +152,6 @@ test_huc_copy(int fd)
> > 	xe_vm_destroy(fd, vm);
> > }
> >
> >-static bool
> >-is_device_supported(int fd)
> >-{
> >-	struct drm_xe_query_config *config;
> >-	struct drm_xe_device_query query = {
> >-		.extensions = 0,
> >-		.query = DRM_XE_DEVICE_QUERY_CONFIG,
> >-		.size = 0,
> >-		.data = 0,
> >-	};
> >-	uint16_t devid;
> >-
> >-	igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query), 0);
> >-
> >-	config = malloc(query.size);
> >-	igt_assert(config);
> >-
> >-	query.data = to_user_pointer(config);
> >-	igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query), 0);
> >-
> >-	devid = config->info[XE_QUERY_CONFIG_REV_AND_DEVICE_ID] & 0xffff;
> >-	return (
> >-			devid == 0x9A60 ||
> >-			devid == 0x9A68 ||
> >-			devid == 0x9A70 ||
> >-			devid == 0x9A40 ||
> >-			devid == 0x9A49 ||
> >-			devid == 0x9A59 ||
> >-			devid == 0x9A78 ||
> >-			devid == 0x9AC0 ||
> >-			devid == 0x9AC9 ||
> >-			devid == 0x9AD9 ||
> >-			devid == 0x9AF8
> >-		);
> >-}
> >-
> > igt_main
> > {
> > 	int xe;
> >@@ -198,7 +162,7 @@ igt_main
> > 	}
> >
> > 	igt_subtest("huc_copy") {
> >-		igt_skip_on(!is_device_supported(xe));
> >+		igt_skip_on(!IS_TIGERLAKE(intel_get_drm_devid(xe)));
> > 		test_huc_copy(xe);
> > 	}
> >
> >-- 
> >2.39.2
> >  

Re: [igt-dev] [PATCH i-g-t] xe/xe_huc_copy: use IS_TIGERLAKE macro

[Lucas De Marchi]

On Tue, Apr 04, 2023 at 09:52:00AM +0200, Mauro Carvalho Chehab wrote:
>On Mon, 3 Apr 2023 23:27:01 -0700
>Lucas De Marchi <lucas.demarchi@intel.com> wrote:
>
>> On Tue, Mar 28, 2023 at 10:39:08AM +0200, Mauro Carvalho Chehab wrote:
>> >From: Mauro Carvalho Chehab <mchehab@kernel.org>
>> >
>> >Instead of hardcoding the PCI IDs at the test, use a macro
>> >to check if the platform is compatible with the test.
>> >
>> >Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
>>
>> neither this or the previous solution scale well. Can we get this info
>> from huc_info in debugfs?
>>
>> We are already loading HuC in platforms other than TGL
>
>Changing IGT to not use IS_platform macros anymore is not an easy task,
>as this is used on lots of place, for both i915 and Xe drivers.

I'm not talking generically everywhere in igt. I'm talking specifically
about huc. For i915 there is a query, for xe we don't have it. But the
same info can be obtained from the huc_info file in debugfs.

>If debugfs can be used for it on both drivers, I guess such macros
>could be changed to use huc_info from debugfs. Still, not sure if
>this is worth, specially since I don't think HUC is mandatory at

huc is not mandatory on any platform, but if we want to test
xe-huc-copy we better check we have huc rather than checking for
platform. Otherwise we will be forever out of sync with kernel.
It is already for the short lifespan of this test and will continue
to be as we add support for huc to more platforms. We support it
on ADL-S already, ADL-P is probably ok to enable and was just hold back
since it was increasing the error rate of unrelated things.
We will soon have RKL. Then there are the newer platforms.

>the i915 driver, and such macros are meant to work with both
>drivers.

i915 already uses something else. This is a xe-specific test that moved
to filter by pciid because we don't have the query... It should rather
moved to debugfs directly.

+Anusha / +Matt Atwood. Maybe they already have something in the works
for igt.

Lucas De Marchi

>
>Regards,
>Mauro
>
>>
>> Lucas De Marchi
>>
>> >---
>> > tests/xe/xe_huc_copy.c | 38 +-------------------------------------
>> > 1 file changed, 1 insertion(+), 37 deletions(-)
>> >
>> >diff --git a/tests/xe/xe_huc_copy.c b/tests/xe/xe_huc_copy.c
>> >index ee3896cef8b9..cd68dbb5ac50 100644
>> >--- a/tests/xe/xe_huc_copy.c
>> >+++ b/tests/xe/xe_huc_copy.c
>> >@@ -152,42 +152,6 @@ test_huc_copy(int fd)
>> > 	xe_vm_destroy(fd, vm);
>> > }
>> >
>> >-static bool
>> >-is_device_supported(int fd)
>> >-{
>> >-	struct drm_xe_query_config *config;
>> >-	struct drm_xe_device_query query = {
>> >-		.extensions = 0,
>> >-		.query = DRM_XE_DEVICE_QUERY_CONFIG,
>> >-		.size = 0,
>> >-		.data = 0,
>> >-	};
>> >-	uint16_t devid;
>> >-
>> >-	igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query), 0);
>> >-
>> >-	config = malloc(query.size);
>> >-	igt_assert(config);
>> >-
>> >-	query.data = to_user_pointer(config);
>> >-	igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query), 0);
>> >-
>> >-	devid = config->info[XE_QUERY_CONFIG_REV_AND_DEVICE_ID] & 0xffff;
>> >-	return (
>> >-			devid == 0x9A60 ||
>> >-			devid == 0x9A68 ||
>> >-			devid == 0x9A70 ||
>> >-			devid == 0x9A40 ||
>> >-			devid == 0x9A49 ||
>> >-			devid == 0x9A59 ||
>> >-			devid == 0x9A78 ||
>> >-			devid == 0x9AC0 ||
>> >-			devid == 0x9AC9 ||
>> >-			devid == 0x9AD9 ||
>> >-			devid == 0x9AF8
>> >-		);
>> >-}
>> >-
>> > igt_main
>> > {
>> > 	int xe;
>> >@@ -198,7 +162,7 @@ igt_main
>> > 	}
>> >
>> > 	igt_subtest("huc_copy") {
>> >-		igt_skip_on(!is_device_supported(xe));
>> >+		igt_skip_on(!IS_TIGERLAKE(intel_get_drm_devid(xe)));
>> > 		test_huc_copy(xe);
>> > 	}
>> >
>> >--
>> >2.39.2
>> >

Re: [igt-dev] [PATCH i-g-t] xe/xe_huc_copy: use IS_TIGERLAKE macro

[Matt Atwood]

On Tue, Apr 04, 2023 at 08:29:58AM -0700, Lucas De Marchi wrote:
> On Tue, Apr 04, 2023 at 09:52:00AM +0200, Mauro Carvalho Chehab wrote:
> > On Mon, 3 Apr 2023 23:27:01 -0700
> > Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> > 
> > > On Tue, Mar 28, 2023 at 10:39:08AM +0200, Mauro Carvalho Chehab wrote:
> > > >From: Mauro Carvalho Chehab <mchehab@kernel.org>
> > > >
> > > >Instead of hardcoding the PCI IDs at the test, use a macro
> > > >to check if the platform is compatible with the test.
> > > >
> > > >Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> > > 
> > > neither this or the previous solution scale well. Can we get this info
> > > from huc_info in debugfs?
> > > 
> > > We are already loading HuC in platforms other than TGL
> > 
> > Changing IGT to not use IS_platform macros anymore is not an easy task,
> > as this is used on lots of place, for both i915 and Xe drivers.
> 
> I'm not talking generically everywhere in igt. I'm talking specifically
> about huc. For i915 there is a query, for xe we don't have it. But the
> same info can be obtained from the huc_info file in debugfs.
I have a patch ill post by EOD for this.
> 
> > If debugfs can be used for it on both drivers, I guess such macros
> > could be changed to use huc_info from debugfs. Still, not sure if
> > this is worth, specially since I don't think HUC is mandatory at
> 
> huc is not mandatory on any platform, but if we want to test
> xe-huc-copy we better check we have huc rather than checking for
> platform. Otherwise we will be forever out of sync with kernel.
> It is already for the short lifespan of this test and will continue
> to be as we add support for huc to more platforms. We support it
> on ADL-S already, ADL-P is probably ok to enable and was just hold back
> since it was increasing the error rate of unrelated things.
> We will soon have RKL. Then there are the newer platforms.
> 
> > the i915 driver, and such macros are meant to work with both
> > drivers.
> 
> i915 already uses something else. This is a xe-specific test that moved
> to filter by pciid because we don't have the query... It should rather
> moved to debugfs directly.
> 
> +Anusha / +Matt Atwood. Maybe they already have something in the works
> for igt.
> 
> Lucas De Marchi
> 
> > 
> > Regards,
> > Mauro
> > 
> > > 
> > > Lucas De Marchi
> > > 
> > > >---
> > > > tests/xe/xe_huc_copy.c | 38 +-------------------------------------
> > > > 1 file changed, 1 insertion(+), 37 deletions(-)
> > > >
> > > >diff --git a/tests/xe/xe_huc_copy.c b/tests/xe/xe_huc_copy.c
> > > >index ee3896cef8b9..cd68dbb5ac50 100644
> > > >--- a/tests/xe/xe_huc_copy.c
> > > >+++ b/tests/xe/xe_huc_copy.c
> > > >@@ -152,42 +152,6 @@ test_huc_copy(int fd)
> > > > 	xe_vm_destroy(fd, vm);
> > > > }
> > > >
> > > >-static bool
> > > >-is_device_supported(int fd)
> > > >-{
> > > >-	struct drm_xe_query_config *config;
> > > >-	struct drm_xe_device_query query = {
> > > >-		.extensions = 0,
> > > >-		.query = DRM_XE_DEVICE_QUERY_CONFIG,
> > > >-		.size = 0,
> > > >-		.data = 0,
> > > >-	};
> > > >-	uint16_t devid;
> > > >-
> > > >-	igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query), 0);
> > > >-
> > > >-	config = malloc(query.size);
> > > >-	igt_assert(config);
> > > >-
> > > >-	query.data = to_user_pointer(config);
> > > >-	igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query), 0);
> > > >-
> > > >-	devid = config->info[XE_QUERY_CONFIG_REV_AND_DEVICE_ID] & 0xffff;
> > > >-	return (
> > > >-			devid == 0x9A60 ||
> > > >-			devid == 0x9A68 ||
> > > >-			devid == 0x9A70 ||
> > > >-			devid == 0x9A40 ||
> > > >-			devid == 0x9A49 ||
> > > >-			devid == 0x9A59 ||
> > > >-			devid == 0x9A78 ||
> > > >-			devid == 0x9AC0 ||
> > > >-			devid == 0x9AC9 ||
> > > >-			devid == 0x9AD9 ||
> > > >-			devid == 0x9AF8
> > > >-		);
> > > >-}
> > > >-
> > > > igt_main
> > > > {
> > > > 	int xe;
> > > >@@ -198,7 +162,7 @@ igt_main
> > > > 	}
> > > >
> > > > 	igt_subtest("huc_copy") {
> > > >-		igt_skip_on(!is_device_supported(xe));
> > > >+		igt_skip_on(!IS_TIGERLAKE(intel_get_drm_devid(xe)));
> > > > 		test_huc_copy(xe);
> > > > 	}
> > > >
> > > >--
> > > >2.39.2
> > > >
MattA

Re: [igt-dev] [PATCH i-g-t] xe/xe_huc_copy: use IS_TIGERLAKE macro

[Mauro Carvalho Chehab]

Hi Lucas,

On Tue, 4 Apr 2023 08:29:58 -0700
Lucas De Marchi <lucas.demarchi@intel.com> wrote:

> On Tue, Apr 04, 2023 at 09:52:00AM +0200, Mauro Carvalho Chehab wrote:
> >On Mon, 3 Apr 2023 23:27:01 -0700
> >Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> >  
> >> On Tue, Mar 28, 2023 at 10:39:08AM +0200, Mauro Carvalho Chehab wrote:  
> >> >From: Mauro Carvalho Chehab <mchehab@kernel.org>
> >> >
> >> >Instead of hardcoding the PCI IDs at the test, use a macro
> >> >to check if the platform is compatible with the test.
> >> >
> >> >Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>  
> >>
> >> neither this or the previous solution scale well. Can we get this info
> >> from huc_info in debugfs?
> >>
> >> We are already loading HuC in platforms other than TGL  
> >
> >Changing IGT to not use IS_platform macros anymore is not an easy task,
> >as this is used on lots of place, for both i915 and Xe drivers.  
> 
> I'm not talking generically everywhere in igt. I'm talking specifically
> about huc. For i915 there is a query, for xe we don't have it. But the
> same info can be obtained from the huc_info file in debugfs.

Ah, I see. I was thinking that you wanted to replace the IS_platform
macros with something else based on HuC debugfs data.

Yeah, for this specific sense, I fully agree that we need a better
solution to detect HuC and if it has support for whatever functionality
huc-specific tests are exercising.

Regards,
Mauro