* [igt-dev] [PATCH i-g-t] tests/xe/xe_huc_copy: check debugfs for huc running
@ 2023-04-12 21:05 Matt Atwood
2023-04-12 21:44 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2023-04-12 21:56 ` [igt-dev] [PATCH i-g-t] " Lucas De Marchi
0 siblings, 2 replies; 4+ messages in thread
From: Matt Atwood @ 2023-04-12 21:05 UTC (permalink / raw)
To: igt-dev
Use debugfs to make sure that huc is loaded for xe_huc_copy. This
function will need to be updated for multitile functionality.
Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
---
tests/xe/xe_huc_copy.c | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/tests/xe/xe_huc_copy.c b/tests/xe/xe_huc_copy.c
index cd68dbb5ac..58d770106e 100644
--- a/tests/xe/xe_huc_copy.c
+++ b/tests/xe/xe_huc_copy.c
@@ -152,6 +152,22 @@ test_huc_copy(int fd)
xe_vm_destroy(fd, vm);
}
+static bool
+is_huc_running(int fd)
+{
+ char buf[4096];
+ char *s;
+
+ /*
+ * TODO: add multi tile support
+ */
+
+ igt_debugfs_read(fd, "gt0/uc/huc_info", buf);
+ s = strstr(buf, "RUNNING");
+
+ return s;
+}
+
igt_main
{
int xe;
@@ -162,7 +178,7 @@ igt_main
}
igt_subtest("huc_copy") {
- igt_skip_on(!IS_TIGERLAKE(intel_get_drm_devid(xe)));
+ igt_skip_on(!is_huc_running(xe));
test_huc_copy(xe);
}
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for tests/xe/xe_huc_copy: check debugfs for huc running
2023-04-12 21:05 [igt-dev] [PATCH i-g-t] tests/xe/xe_huc_copy: check debugfs for huc running Matt Atwood
@ 2023-04-12 21:44 ` Patchwork
2023-04-12 21:56 ` [igt-dev] [PATCH i-g-t] " Lucas De Marchi
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2023-04-12 21:44 UTC (permalink / raw)
To: Matt Atwood; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 13583 bytes --]
== Series Details ==
Series: tests/xe/xe_huc_copy: check debugfs for huc running
URL : https://patchwork.freedesktop.org/series/116399/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12997 -> IGTPW_8793
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_8793 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_8793, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/index.html
Participating hosts (37 -> 35)
------------------------------
Missing (2): fi-kbl-soraka fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8793:
### IGT changes ###
#### Possible regressions ####
* igt@core_hotunplug@unbind-rebind:
- bat-atsm-1: [PASS][1] -> [SKIP][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-atsm-1/igt@core_hotunplug@unbind-rebind.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-atsm-1/igt@core_hotunplug@unbind-rebind.html
* igt@i915_selftest@live@slpc:
- bat-atsm-1: [PASS][3] -> [FAIL][4] +38 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-atsm-1/igt@i915_selftest@live@slpc.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-atsm-1/igt@i915_selftest@live@slpc.html
Known issues
------------
Here are the changes found in IGTPW_8793 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_lmem_swapping@basic:
- bat-atsm-1: NOTRUN -> [SKIP][5] ([i915#5775]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-atsm-1/igt@gem_lmem_swapping@basic.html
* igt@gem_sync@basic-each:
- bat-atsm-1: [PASS][6] -> [SKIP][7] ([i915#2575]) +38 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-atsm-1/igt@gem_sync@basic-each.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-atsm-1/igt@gem_sync@basic-each.html
* igt@gem_wait@busy:
- bat-atsm-1: NOTRUN -> [SKIP][8] ([i915#2575]) +11 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-atsm-1/igt@gem_wait@busy.html
* igt@i915_pm_rpm@basic-rte:
- bat-atsm-1: [PASS][9] -> [SKIP][10] ([i915#5174]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-atsm-1/igt@i915_pm_rpm@basic-rte.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-atsm-1/igt@i915_pm_rpm@basic-rte.html
* igt@i915_selftest@live@reset:
- bat-rpls-1: [PASS][11] -> [ABORT][12] ([i915#4983])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-rpls-1/igt@i915_selftest@live@reset.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@i915_selftest@live@slpc:
- bat-rpls-2: NOTRUN -> [DMESG-FAIL][13] ([i915#6997] / [i915#7913])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-rpls-2/igt@i915_selftest@live@slpc.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-rpls-2: NOTRUN -> [SKIP][14] ([i915#7828])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-rpls-2/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
- fi-cfl-8700k: NOTRUN -> [SKIP][15] ([fdo#109271])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/fi-cfl-8700k/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1:
- bat-dg2-8: [PASS][16] -> [FAIL][17] ([i915#7932])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
* igt@kms_pipe_crc_basic@read-crc:
- bat-dg2-11: NOTRUN -> [SKIP][18] ([i915#5354]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-dg2-11/igt@kms_pipe_crc_basic@read-crc.html
* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-rpls-2: NOTRUN -> [SKIP][19] ([i915#1845])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-rpls-2/igt@kms_pipe_crc_basic@suspend-read-crc.html
#### Possible fixes ####
* igt@fbdev@eof:
- bat-atsm-1: [SKIP][20] ([i915#2582]) -> [PASS][21] +4 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-atsm-1/igt@fbdev@eof.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-atsm-1/igt@fbdev@eof.html
* igt@i915_pm_rps@basic-api:
- bat-dg2-11: [FAIL][22] ([i915#8308]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-dg2-11/igt@i915_pm_rps@basic-api.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-dg2-11/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@reset:
- bat-rpls-2: [ABORT][24] ([i915#4983] / [i915#7913]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-rpls-2/igt@i915_selftest@live@reset.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-rpls-2/igt@i915_selftest@live@reset.html
* igt@i915_suspend@basic-s2idle-without-i915:
- fi-cfl-8700k: [ABORT][26] ([i915#8299]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/fi-cfl-8700k/igt@i915_suspend@basic-s2idle-without-i915.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/fi-cfl-8700k/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1:
- bat-dg2-8: [FAIL][28] ([i915#7932]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html
#### Warnings ####
* igt@gem_mmap@basic:
- bat-atsm-1: [SKIP][30] ([i915#4083]) -> [SKIP][31] ([i915#2575])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-atsm-1/igt@gem_mmap@basic.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-atsm-1/igt@gem_mmap@basic.html
* igt@gem_tiled_fence_blits@basic:
- bat-atsm-1: [SKIP][32] ([i915#4077]) -> [SKIP][33] ([i915#2575]) +2 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-atsm-1/igt@gem_tiled_fence_blits@basic.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-atsm-1/igt@gem_tiled_fence_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-atsm-1: [SKIP][34] ([i915#4079]) -> [SKIP][35] ([i915#2575]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-atsm-1/igt@gem_tiled_pread_basic.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-atsm-1/igt@gem_tiled_pread_basic.html
* igt@kms_addfb_basic@size-max:
- bat-atsm-1: [SKIP][36] ([i915#6077]) -> [SKIP][37] ([i915#2575]) +36 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-atsm-1/igt@kms_addfb_basic@size-max.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-atsm-1/igt@kms_addfb_basic@size-max.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- bat-atsm-1: [SKIP][38] ([i915#6078]) -> [SKIP][39] ([i915#2575]) +19 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-atsm-1/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-atsm-1/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
* igt@kms_flip@basic-plain-flip:
- bat-atsm-1: [SKIP][40] ([i915#6166]) -> [SKIP][41] ([i915#2575]) +3 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-atsm-1/igt@kms_flip@basic-plain-flip.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-atsm-1/igt@kms_flip@basic-plain-flip.html
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-atsm-1: [SKIP][42] ([i915#6093]) -> [SKIP][43] ([i915#2575]) +3 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-atsm-1/igt@kms_force_connector_basic@prune-stale-modes.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-atsm-1/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_pipe_crc_basic@hang-read-crc:
- bat-atsm-1: [SKIP][44] ([i915#1836]) -> [SKIP][45] ([i915#2575]) +6 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-atsm-1/igt@kms_pipe_crc_basic@hang-read-crc.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-atsm-1/igt@kms_pipe_crc_basic@hang-read-crc.html
* igt@kms_prop_blob@basic:
- bat-atsm-1: [SKIP][46] ([i915#7357]) -> [SKIP][47] ([i915#2575])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-atsm-1/igt@kms_prop_blob@basic.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-atsm-1/igt@kms_prop_blob@basic.html
* igt@kms_psr@sprite_plane_onoff:
- bat-atsm-1: [SKIP][48] ([i915#1072]) -> [SKIP][49] ([i915#2575]) +3 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-atsm-1/igt@kms_psr@sprite_plane_onoff.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-atsm-1/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-atsm-1: [SKIP][50] ([i915#6094]) -> [SKIP][51] ([i915#2575])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-atsm-1/igt@kms_setmode@basic-clone-single-crtc.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-atsm-1/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- bat-atsm-1: [SKIP][52] ([fdo#109295] / [i915#6078]) -> [SKIP][53] ([i915#2575])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-atsm-1/igt@prime_vgem@basic-fence-flip.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-atsm-1/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-fence-mmap:
- bat-atsm-1: [SKIP][54] ([fdo#109295] / [i915#4077]) -> [SKIP][55] ([i915#2575]) +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-atsm-1/igt@prime_vgem@basic-fence-mmap.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-atsm-1/igt@prime_vgem@basic-fence-mmap.html
* igt@prime_vgem@basic-write:
- bat-atsm-1: [SKIP][56] ([fdo#109295]) -> [SKIP][57] ([i915#2575]) +3 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12997/bat-atsm-1/igt@prime_vgem@basic-write.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/bat-atsm-1/igt@prime_vgem@basic-write.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5174]: https://gitlab.freedesktop.org/drm/intel/issues/5174
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5775]: https://gitlab.freedesktop.org/drm/intel/issues/5775
[i915#6077]: https://gitlab.freedesktop.org/drm/intel/issues/6077
[i915#6078]: https://gitlab.freedesktop.org/drm/intel/issues/6078
[i915#6093]: https://gitlab.freedesktop.org/drm/intel/issues/6093
[i915#6094]: https://gitlab.freedesktop.org/drm/intel/issues/6094
[i915#6166]: https://gitlab.freedesktop.org/drm/intel/issues/6166
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7357]: https://gitlab.freedesktop.org/drm/intel/issues/7357
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#8299]: https://gitlab.freedesktop.org/drm/intel/issues/8299
[i915#8308]: https://gitlab.freedesktop.org/drm/intel/issues/8308
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7253 -> IGTPW_8793
CI-20190529: 20190529
CI_DRM_12997: afe31b57e95ebf86f5814fd01a030c2f9551acb4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8793: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/index.html
IGT_7253: 1a619e8dbc6ca887f2ae24b2d7f1ac536342f58c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8793/index.html
[-- Attachment #2: Type: text/html, Size: 16442 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/xe/xe_huc_copy: check debugfs for huc running
2023-04-12 21:05 [igt-dev] [PATCH i-g-t] tests/xe/xe_huc_copy: check debugfs for huc running Matt Atwood
2023-04-12 21:44 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2023-04-12 21:56 ` Lucas De Marchi
2023-04-12 22:02 ` Matt Atwood
1 sibling, 1 reply; 4+ messages in thread
From: Lucas De Marchi @ 2023-04-12 21:56 UTC (permalink / raw)
To: Matt Atwood; +Cc: igt-dev
On Wed, Apr 12, 2023 at 02:05:58PM -0700, Matt Atwood wrote:
>Use debugfs to make sure that huc is loaded for xe_huc_copy. This
>function will need to be updated for multitile functionality.
>
>Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
>---
> tests/xe/xe_huc_copy.c | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
>diff --git a/tests/xe/xe_huc_copy.c b/tests/xe/xe_huc_copy.c
>index cd68dbb5ac..58d770106e 100644
>--- a/tests/xe/xe_huc_copy.c
>+++ b/tests/xe/xe_huc_copy.c
>@@ -152,6 +152,22 @@ test_huc_copy(int fd)
> xe_vm_destroy(fd, vm);
> }
>
>+static bool
>+is_huc_running(int fd)
>+{
>+ char buf[4096];
>+ char *s;
>+
>+ /*
>+ * TODO: add multi tile support
can't be a todo, otherwise it doesn't work on MTL since there
the media gt is gt1. It's simple enough to add
int gt;
xe_for_each_gt(fd, gt) {
char name[256];
sprintf(name, "gt%d/uc/huc_info", gt);
...
if (s)
return true;
}
return false;
in xe it seems that when HuC is not loaded, for whatever reason
we fail module load. So this is fine for now. Eventually we will need to
differentiate "failed to load HuC" from "platform doesn't have huc"
from "huc failed to run for whatever reason". I think this can be a
TODO.
Lucas De Marchi
>+ */
>+
>+ igt_debugfs_read(fd, "gt0/uc/huc_info", buf);
>+ s = strstr(buf, "RUNNING");
>+
>+ return s;
>+}
>+
> igt_main
> {
> int xe;
>@@ -162,7 +178,7 @@ igt_main
> }
>
> igt_subtest("huc_copy") {
>- igt_skip_on(!IS_TIGERLAKE(intel_get_drm_devid(xe)));
>+ igt_skip_on(!is_huc_running(xe));
> test_huc_copy(xe);
> }
>
>--
>2.39.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/xe/xe_huc_copy: check debugfs for huc running
2023-04-12 21:56 ` [igt-dev] [PATCH i-g-t] " Lucas De Marchi
@ 2023-04-12 22:02 ` Matt Atwood
0 siblings, 0 replies; 4+ messages in thread
From: Matt Atwood @ 2023-04-12 22:02 UTC (permalink / raw)
To: Lucas De Marchi, igt-dev; +Cc: igt-dev
On Wed, Apr 12, 2023 at 02:56:39PM -0700, Lucas De Marchi wrote:
> On Wed, Apr 12, 2023 at 02:05:58PM -0700, Matt Atwood wrote:
> > Use debugfs to make sure that huc is loaded for xe_huc_copy. This
> > function will need to be updated for multitile functionality.
> >
> > Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
> > ---
> > tests/xe/xe_huc_copy.c | 18 +++++++++++++++++-
> > 1 file changed, 17 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/xe/xe_huc_copy.c b/tests/xe/xe_huc_copy.c
> > index cd68dbb5ac..58d770106e 100644
> > --- a/tests/xe/xe_huc_copy.c
> > +++ b/tests/xe/xe_huc_copy.c
> > @@ -152,6 +152,22 @@ test_huc_copy(int fd)
> > xe_vm_destroy(fd, vm);
> > }
> >
> > +static bool
> > +is_huc_running(int fd)
> > +{
> > + char buf[4096];
> > + char *s;
> > +
> > + /*
> > + * TODO: add multi tile support
>
> can't be a todo, otherwise it doesn't work on MTL since there
> the media gt is gt1. It's simple enough to add
>
> int gt;
>
> xe_for_each_gt(fd, gt) {
> char name[256];
>
> sprintf(name, "gt%d/uc/huc_info", gt);
> ...
> if (s)
> return true;
> }
>
> return false;
Ack
>
> in xe it seems that when HuC is not loaded, for whatever reason
> we fail module load. So this is fine for now. Eventually we will need to
> differentiate "failed to load HuC" from "platform doesn't have huc"
> from "huc failed to run for whatever reason". I think this can be a
> TODO.
will leave as todo.
>
> Lucas De Marchi
>
> > + */
> > +
> > + igt_debugfs_read(fd, "gt0/uc/huc_info", buf);
> > + s = strstr(buf, "RUNNING");
> > +
> > + return s;
> > +}
> > +
> > igt_main
> > {
> > int xe;
> > @@ -162,7 +178,7 @@ igt_main
> > }
> >
> > igt_subtest("huc_copy") {
> > - igt_skip_on(!IS_TIGERLAKE(intel_get_drm_devid(xe)));
> > + igt_skip_on(!is_huc_running(xe));
> > test_huc_copy(xe);
> > }
> >
> > --
> > 2.39.2
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-04-12 22:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-12 21:05 [igt-dev] [PATCH i-g-t] tests/xe/xe_huc_copy: check debugfs for huc running Matt Atwood
2023-04-12 21:44 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2023-04-12 21:56 ` [igt-dev] [PATCH i-g-t] " Lucas De Marchi
2023-04-12 22:02 ` Matt Atwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox