From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [i-g-t 04/45] lib/intel_allocator: Add allocator support for Xe
Date: Tue, 18 Apr 2023 22:14:20 +0530 [thread overview]
Message-ID: <20230418164501.1687266-5-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230418164501.1687266-1-bhanuprakash.modem@intel.com>
From: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Start supporting va range configuration for xe allocator.
During opening allocator has to be aware of vm range (start and end).
i915 driver doesn't expose vm range information so those variables
have to be detected. In xe driver we get information of va size from
the kernel query so va end can be directly configured. At the moment
there's no autodetection of va start for xe what might need to be
address in the future if due some reason lower offsets might not be
in use.
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
lib/intel_allocator.c | 49 ++++++++++++++++++++++++++-----------------
1 file changed, 30 insertions(+), 19 deletions(-)
diff --git a/lib/intel_allocator.c b/lib/intel_allocator.c
index 2b08dd599..f644e2f49 100644
--- a/lib/intel_allocator.c
+++ b/lib/intel_allocator.c
@@ -16,6 +16,7 @@
#include "igt_map.h"
#include "intel_allocator.h"
#include "intel_allocator_msgchannel.h"
+#include "xe/xe_query.h"
//#define ALLOCDBG
#ifdef ALLOCDBG
@@ -910,24 +911,33 @@ static uint64_t __intel_allocator_open_full(int fd, uint32_t ctx,
struct alloc_resp resp;
uint64_t gtt_size;
- if (!start)
- req.open.start = gem_detect_safe_start_offset(fd);
+ if (is_i915_device(fd)) {
+ if (!start)
+ req.open.start = gem_detect_safe_start_offset(fd);
- if (!end) {
- igt_assert_f(can_report_gtt_size(fd), "Invalid fd\n");
- gtt_size = gem_aperture_size(fd);
- if (!gem_uses_full_ppgtt(fd))
- gtt_size /= 2;
- else
- gtt_size -= RESERVED;
+ if (!end) {
+ igt_assert_f(can_report_gtt_size(fd), "Invalid fd\n");
+ gtt_size = gem_aperture_size(fd);
+ if (!gem_uses_full_ppgtt(fd))
+ gtt_size /= 2;
+ else
+ gtt_size -= RESERVED;
- req.open.end = gtt_size;
- }
+ req.open.end = gtt_size;
+ }
+
+ if (!default_alignment)
+ req.open.default_alignment = gem_detect_safe_alignment(fd);
+
+ req.open.start = ALIGN(req.open.start, req.open.default_alignment);
+ } else {
+ struct xe_device *xe_dev = xe_device_get(fd);
- if (!default_alignment)
- req.open.default_alignment = gem_detect_safe_alignment(fd);
+ igt_assert(xe_dev);
- req.open.start = ALIGN(req.open.start, req.open.default_alignment);
+ if (!end)
+ req.open.end = 1ull << xe_dev->va_bits;
+ }
/* Get child_tid only once at open() */
if (child_tid == -1)
@@ -991,6 +1001,7 @@ uint64_t intel_allocator_open_vm_full(int fd, uint32_t vm,
uint64_t default_alignment)
{
igt_assert(vm != 0);
+
return __intel_allocator_open_full(fd, 0, vm, start, end,
allocator_type, strategy,
default_alignment);
@@ -998,7 +1009,7 @@ uint64_t intel_allocator_open_vm_full(int fd, uint32_t vm,
/**
* intel_allocator_open:
- * @fd: i915 descriptor
+ * @fd: i915 or xe descriptor
* @ctx: context
* @allocator_type: one of INTEL_ALLOCATOR_* define
*
@@ -1014,14 +1025,14 @@ uint64_t intel_allocator_open_vm_full(int fd, uint32_t vm,
*/
uint64_t intel_allocator_open(int fd, uint32_t ctx, uint8_t allocator_type)
{
- return intel_allocator_open_full(fd, ctx, 0, 0, allocator_type,
- ALLOC_STRATEGY_HIGH_TO_LOW, 0);
+ return __intel_allocator_open_full(fd, ctx, 0, 0, 0, allocator_type,
+ ALLOC_STRATEGY_HIGH_TO_LOW, 0);
}
uint64_t intel_allocator_open_vm(int fd, uint32_t vm, uint8_t allocator_type)
{
- return intel_allocator_open_vm_full(fd, vm, 0, 0, allocator_type,
- ALLOC_STRATEGY_HIGH_TO_LOW, 0);
+ return __intel_allocator_open_full(fd, 0, vm, 0, 0, allocator_type,
+ ALLOC_STRATEGY_HIGH_TO_LOW, 0);
}
uint64_t intel_allocator_open_vm_as(uint64_t allocator_handle, uint32_t new_vm)
--
2.40.0
next prev parent reply other threads:[~2023-04-18 16:49 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 16:44 [igt-dev] [i-g-t 00/45] Add IGT display support for XE Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 01/45] lib/xe_ioctl: Add missing header for direct resolving Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 02/45] lib/xe_query: Add region helpers and missing doc Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 03/45] lib/xe_query: Remove commented out function prototype Bhanuprakash Modem
2023-04-18 16:44 ` Bhanuprakash Modem [this message]
2023-04-18 16:44 ` [igt-dev] [i-g-t 05/45] lib/intel_bufops: Add Xe support in bufops Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 06/45] lib/intel_batchbuffer: Add Xe support in intel-bb Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 07/45] tests/xe_intel_bb: Check if intel-bb Xe support correctness Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 08/45] tests/xe-fast-feedback: Add xe_intel_bb test to BAT Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 09/45] lib/gpgpu_fill: Use RENDER engine flag to work on Xe Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 10/45] tests/xe_gpgpu_fill: Exercise gpgpu fill " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 11/45] lib: Use i915 namespace for XE debugfs Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 12/45] lib/igt_fb: Add copy engine support for XE Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 13/45] lib/igt_draw: Add gpu draw routine " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 14/45] tests/i915/kms_big_fb: Add XE support Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 15/45] tests/i915/kms_big_joiner: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 16/45] tests/i915/kms_cdclk: " Bhanuprakash Modem
2023-04-21 9:47 ` Nautiyal, Ankit K
2023-04-18 16:44 ` [igt-dev] [i-g-t 17/45] tests/i915/kms_draw_crc: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 18/45] tests/i915/kms_dsc: " Bhanuprakash Modem
2023-04-21 9:51 ` Nautiyal, Ankit K
2023-04-18 16:44 ` [igt-dev] [i-g-t 19/45] tests/i915/kms_flip_scaled_crc: " Bhanuprakash Modem
2023-04-21 8:07 ` Nautiyal, Ankit K
2023-04-18 16:44 ` [igt-dev] [i-g-t 20/45] tests/i915/kms_flip_tiling: " Bhanuprakash Modem
2023-04-21 9:57 ` Nautiyal, Ankit K
2023-04-18 16:44 ` [igt-dev] [i-g-t 21/45] tests/i915/kms_mmap_write_crc: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 22/45] tests/i915/kms_psr*: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 23/45] tests/kms_3d: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 24/45] tests/kms_async_flips: No " Bhanuprakash Modem
2023-04-21 9:15 ` Karthik B S
2023-04-18 16:44 ` [igt-dev] [i-g-t 25/45] tests/kms_atomic_transition: Add " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 26/45] tests/color: " Bhanuprakash Modem
2023-04-24 8:00 ` [igt-dev] [i-g-t,26/45] " Joshi, Kunal1
2023-04-24 8:13 ` Modem, Bhanuprakash
2023-04-18 16:44 ` [igt-dev] [i-g-t 27/45] tests/kms_concurrent: " Bhanuprakash Modem
2023-04-24 8:08 ` [igt-dev] [i-g-t,27/45] " Joshi, Kunal1
2023-04-18 16:44 ` [igt-dev] [i-g-t 28/45] tests/kms_content_protection: " Bhanuprakash Modem
2023-04-24 9:02 ` [igt-dev] [i-g-t, " Joshi, Kunal1
2023-04-18 16:44 ` [igt-dev] [i-g-t 29/45] tests/kms_cursor_crc: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 30/45] tests/kms_cursor_legacy: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 31/45] tests/kms_flip: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 32/45] tests/kms_flip_event_leak: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 33/45] tests/kms_getfb: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 34/45] tests/kms_hdmi_inject: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 35/45] tests/kms_hdr: " Bhanuprakash Modem
2023-04-21 10:09 ` Nautiyal, Ankit K
2023-04-18 16:44 ` [igt-dev] [i-g-t 36/45] tests/kms_panel_fitting: " Bhanuprakash Modem
2023-04-21 10:17 ` Nautiyal, Ankit K
2023-04-18 16:44 ` [igt-dev] [i-g-t 37/45] tests/kms_plane: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 38/45] tests/kms_plane_lowers: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 39/45] tests/kms_plane_scaling: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 40/45] tests/kms_prime: " Bhanuprakash Modem
2023-04-25 4:16 ` Karthik B S
2023-04-18 16:44 ` [igt-dev] [i-g-t 41/45] tests/kms_rotation_crc: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 42/45] tests/kms_setmode: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 43/45] tests/kms_universal_plane: " Bhanuprakash Modem
2023-04-18 16:45 ` [igt-dev] [i-g-t 44/45] tests/kms: Move intel specific kms tests to new dir Bhanuprakash Modem
2023-04-18 16:45 ` [igt-dev] [i-g-t 45/45] xe-fast-feedback: Add kms tests to XE BAT Bhanuprakash Modem
2023-04-18 16:58 ` [igt-dev] [i-g-t 00/45] Add IGT display support for XE Ville Syrjälä
2023-04-19 7:01 ` Zbigniew Kempczyński
2023-04-19 11:57 ` Modem, Bhanuprakash
2023-04-19 16:19 ` Zbigniew Kempczyński
2023-04-21 6:47 ` Nautiyal, Ankit K
2023-04-21 7:33 ` Modem, Bhanuprakash
2023-04-21 9:33 ` Nautiyal, Ankit K
2023-04-18 17:24 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-04-18 21:28 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-04-21 16:43 ` [igt-dev] [i-g-t 00/45] " Kamil Konieczny
2023-04-24 5:21 ` Modem, Bhanuprakash
2023-04-24 9:45 ` Kamil Konieczny
2023-04-24 10:05 ` Modem, Bhanuprakash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230418164501.1687266-5-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox