Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [i-g-t 05/45] lib/intel_bufops: Add Xe support in bufops
Date: Tue, 18 Apr 2023 22:14:21 +0530	[thread overview]
Message-ID: <20230418164501.1687266-6-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230418164501.1687266-1-bhanuprakash.modem@intel.com>

From: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>

Extend bufops to support Xe:
 - change region to 64bit region mask,
 - add initialization helper (full) which allows passing handle,
   size and region,
 - mapping functions (read + write) selects driver specific mapping

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 lib/intel_bufops.c | 73 ++++++++++++++++++++++++++++++++++++++++++----
 lib/intel_bufops.h | 13 ++++++++-
 2 files changed, 80 insertions(+), 6 deletions(-)

diff --git a/lib/intel_bufops.c b/lib/intel_bufops.c
index cdc7a1698..3307f30ee 100644
--- a/lib/intel_bufops.c
+++ b/lib/intel_bufops.c
@@ -26,6 +26,8 @@
 #include <cairo.h>
 
 #include "i915/gem_create.h"
+#include "xe/xe_ioctl.h"
+#include "xe/xe_query.h"
 #include "igt.h"
 #include "igt_x86.h"
 #include "intel_bufops.h"
@@ -488,6 +490,9 @@ static void *mmap_write(int fd, struct intel_buf *buf)
 {
 	void *map = NULL;
 
+	if (is_xe_device(fd))
+		return xe_bo_map(fd, buf->handle, buf->surface[0].size);
+
 	if (gem_has_lmem(fd)) {
 		/*
 		 * set/get_caching and set_domain are no longer supported on
@@ -530,6 +535,9 @@ static void *mmap_read(int fd, struct intel_buf *buf)
 {
 	void *map = NULL;
 
+	if (is_xe_device(fd))
+		return xe_bo_map(fd, buf->handle, buf->surface[0].size);
+
 	if (gem_has_lmem(fd)) {
 		/*
 		 * set/get_caching and set_domain are no longer supported on
@@ -809,7 +817,7 @@ static void __intel_buf_init(struct buf_ops *bops,
 			     int width, int height, int bpp, int alignment,
 			     uint32_t req_tiling, uint32_t compression,
 			     uint64_t bo_size, int bo_stride,
-			     uint32_t region)
+			     uint64_t region)
 {
 	uint32_t tiling = req_tiling;
 	uint64_t size;
@@ -899,9 +907,17 @@ static void __intel_buf_init(struct buf_ops *bops,
 	buf->size = size;
 	buf->handle = handle;
 
-	if (!handle)
-		if (__gem_create_in_memory_regions(bops->fd, &buf->handle, &size, region))
-			igt_assert_eq(__gem_create(bops->fd, &size, &buf->handle), 0);
+	if (!handle) {
+		if (is_i915_device(bops->fd)) {
+			if (__gem_create_in_memory_regions(bops->fd, &buf->handle, &size, region))
+				igt_assert_eq(__gem_create(bops->fd, &size, &buf->handle), 0);
+		} else {
+			region = vram_if_possible(bops->fd, 0);
+			size = ALIGN(size, xe_get_default_alignment(bops->fd));
+			buf->handle = xe_bo_create_flags(bops->fd, 0, size, region);
+		}
+	}
+	buf->region = region;
 
 	/* Store gem bo size */
 	buf->bo_size = size;
@@ -945,7 +961,7 @@ void intel_buf_init_in_region(struct buf_ops *bops,
 			      struct intel_buf *buf,
 			      int width, int height, int bpp, int alignment,
 			      uint32_t tiling, uint32_t compression,
-			      uint32_t region)
+			      uint64_t region)
 {
 	__intel_buf_init(bops, 0, buf, width, height, bpp, alignment,
 			 tiling, compression, 0, 0, region);
@@ -1010,6 +1026,41 @@ void intel_buf_init_using_handle(struct buf_ops *bops,
 			 req_tiling, compression, 0, 0, -1);
 }
 
+/**
+ * intel_buf_init_full
+ * @bops: pointer to buf_ops
+ * @handle: BO handle created by the caller
+ * @buf: pointer to intel_buf structure to be filled
+ * @width: surface width
+ * @height: surface height
+ * @bpp: bits-per-pixel (8 / 16 / 32 / 64)
+ * @alignment: alignment of the stride for linear surfaces
+ * @req_tiling: surface tiling
+ * @compression: surface compression type
+ * @size: size
+ * @region: region
+ *
+ * Function configures BO handle within intel_buf structure passed by the caller
+ * (with all its metadata - width, height, ...). Useful if BO was created
+ * outside. Allows passing real size which caller is aware of.
+ *
+ * Note: intel_buf_close() can be used because intel_buf is aware it is not
+ * buffer owner so it won't close it underneath.
+ */
+void intel_buf_init_full(struct buf_ops *bops,
+			 uint32_t handle,
+			 struct intel_buf *buf,
+			 int width, int height,
+			 int bpp, int alignment,
+			 uint32_t req_tiling,
+			 uint32_t compression,
+			 uint64_t size,
+			 uint64_t region)
+{
+	__intel_buf_init(bops, handle, buf, width, height, bpp, alignment,
+			 req_tiling, compression, size, 0, region);
+}
+
 /**
  * intel_buf_create
  * @bops: pointer to buf_ops
@@ -1423,6 +1474,18 @@ static struct buf_ops *__buf_ops_create(int fd, bool check_idempotency)
 	igt_debug("generation: %d, supported tiles: 0x%02x\n",
 		  bops->intel_gen, bops->supported_tiles);
 
+	/* No tiling support in XE. */
+	if (is_xe_device(fd)) {
+		bops->supported_hw_tiles = TILE_NONE;
+
+		bops->linear_to_x = copy_linear_to_x;
+		bops->x_to_linear = copy_x_to_linear;
+		bops->linear_to_y = copy_linear_to_y;
+		bops->y_to_linear = copy_y_to_linear;
+
+		return bops;
+	}
+
 	/*
 	 * Warning!
 	 *
diff --git a/lib/intel_bufops.h b/lib/intel_bufops.h
index 25b430739..0b6e025ca 100644
--- a/lib/intel_bufops.h
+++ b/lib/intel_bufops.h
@@ -43,6 +43,7 @@ struct intel_buf {
 	} addr;
 
 	uint64_t bo_size;
+	uint64_t region;
 
 	/* Tracking */
 	struct intel_bb *ibb;
@@ -135,7 +136,7 @@ void intel_buf_init_in_region(struct buf_ops *bops,
 			      struct intel_buf *buf,
 			      int width, int height, int bpp, int alignment,
 			      uint32_t tiling, uint32_t compression,
-			      uint32_t region);
+			      uint64_t region);
 void intel_buf_close(struct buf_ops *bops, struct intel_buf *buf);
 
 void intel_buf_init_using_handle(struct buf_ops *bops,
@@ -143,6 +144,15 @@ void intel_buf_init_using_handle(struct buf_ops *bops,
 				 struct intel_buf *buf,
 				 int width, int height, int bpp, int alignment,
 				 uint32_t req_tiling, uint32_t compression);
+void intel_buf_init_full(struct buf_ops *bops,
+			 uint32_t handle,
+			 struct intel_buf *buf,
+			 int width, int height,
+			 int bpp, int alignment,
+			 uint32_t req_tiling,
+			 uint32_t compression,
+			 uint64_t size,
+			 uint64_t region);
 
 struct intel_buf *intel_buf_create(struct buf_ops *bops,
 				   int width, int height,
@@ -164,6 +174,7 @@ struct intel_buf *intel_buf_create_using_handle_and_size(struct buf_ops *bops,
 							 uint32_t compression,
 							 uint64_t size,
 							 int stride);
+
 void intel_buf_destroy(struct intel_buf *buf);
 
 static inline void intel_buf_set_pxp(struct intel_buf *buf, bool new_pxp_state)
-- 
2.40.0

  parent reply	other threads:[~2023-04-18 16:49 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-18 16:44 [igt-dev] [i-g-t 00/45] Add IGT display support for XE Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 01/45] lib/xe_ioctl: Add missing header for direct resolving Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 02/45] lib/xe_query: Add region helpers and missing doc Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 03/45] lib/xe_query: Remove commented out function prototype Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 04/45] lib/intel_allocator: Add allocator support for Xe Bhanuprakash Modem
2023-04-18 16:44 ` Bhanuprakash Modem [this message]
2023-04-18 16:44 ` [igt-dev] [i-g-t 06/45] lib/intel_batchbuffer: Add Xe support in intel-bb Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 07/45] tests/xe_intel_bb: Check if intel-bb Xe support correctness Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 08/45] tests/xe-fast-feedback: Add xe_intel_bb test to BAT Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 09/45] lib/gpgpu_fill: Use RENDER engine flag to work on Xe Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 10/45] tests/xe_gpgpu_fill: Exercise gpgpu fill " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 11/45] lib: Use i915 namespace for XE debugfs Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 12/45] lib/igt_fb: Add copy engine support for XE Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 13/45] lib/igt_draw: Add gpu draw routine " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 14/45] tests/i915/kms_big_fb: Add XE support Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 15/45] tests/i915/kms_big_joiner: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 16/45] tests/i915/kms_cdclk: " Bhanuprakash Modem
2023-04-21  9:47   ` Nautiyal, Ankit K
2023-04-18 16:44 ` [igt-dev] [i-g-t 17/45] tests/i915/kms_draw_crc: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 18/45] tests/i915/kms_dsc: " Bhanuprakash Modem
2023-04-21  9:51   ` Nautiyal, Ankit K
2023-04-18 16:44 ` [igt-dev] [i-g-t 19/45] tests/i915/kms_flip_scaled_crc: " Bhanuprakash Modem
2023-04-21  8:07   ` Nautiyal, Ankit K
2023-04-18 16:44 ` [igt-dev] [i-g-t 20/45] tests/i915/kms_flip_tiling: " Bhanuprakash Modem
2023-04-21  9:57   ` Nautiyal, Ankit K
2023-04-18 16:44 ` [igt-dev] [i-g-t 21/45] tests/i915/kms_mmap_write_crc: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 22/45] tests/i915/kms_psr*: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 23/45] tests/kms_3d: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 24/45] tests/kms_async_flips: No " Bhanuprakash Modem
2023-04-21  9:15   ` Karthik B S
2023-04-18 16:44 ` [igt-dev] [i-g-t 25/45] tests/kms_atomic_transition: Add " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 26/45] tests/color: " Bhanuprakash Modem
2023-04-24  8:00   ` [igt-dev] [i-g-t,26/45] " Joshi, Kunal1
2023-04-24  8:13     ` Modem, Bhanuprakash
2023-04-18 16:44 ` [igt-dev] [i-g-t 27/45] tests/kms_concurrent: " Bhanuprakash Modem
2023-04-24  8:08   ` [igt-dev] [i-g-t,27/45] " Joshi, Kunal1
2023-04-18 16:44 ` [igt-dev] [i-g-t 28/45] tests/kms_content_protection: " Bhanuprakash Modem
2023-04-24  9:02   ` [igt-dev] [i-g-t, " Joshi, Kunal1
2023-04-18 16:44 ` [igt-dev] [i-g-t 29/45] tests/kms_cursor_crc: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 30/45] tests/kms_cursor_legacy: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 31/45] tests/kms_flip: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 32/45] tests/kms_flip_event_leak: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 33/45] tests/kms_getfb: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 34/45] tests/kms_hdmi_inject: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 35/45] tests/kms_hdr: " Bhanuprakash Modem
2023-04-21 10:09   ` Nautiyal, Ankit K
2023-04-18 16:44 ` [igt-dev] [i-g-t 36/45] tests/kms_panel_fitting: " Bhanuprakash Modem
2023-04-21 10:17   ` Nautiyal, Ankit K
2023-04-18 16:44 ` [igt-dev] [i-g-t 37/45] tests/kms_plane: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 38/45] tests/kms_plane_lowers: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 39/45] tests/kms_plane_scaling: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 40/45] tests/kms_prime: " Bhanuprakash Modem
2023-04-25  4:16   ` Karthik B S
2023-04-18 16:44 ` [igt-dev] [i-g-t 41/45] tests/kms_rotation_crc: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 42/45] tests/kms_setmode: " Bhanuprakash Modem
2023-04-18 16:44 ` [igt-dev] [i-g-t 43/45] tests/kms_universal_plane: " Bhanuprakash Modem
2023-04-18 16:45 ` [igt-dev] [i-g-t 44/45] tests/kms: Move intel specific kms tests to new dir Bhanuprakash Modem
2023-04-18 16:45 ` [igt-dev] [i-g-t 45/45] xe-fast-feedback: Add kms tests to XE BAT Bhanuprakash Modem
2023-04-18 16:58 ` [igt-dev] [i-g-t 00/45] Add IGT display support for XE Ville Syrjälä
2023-04-19  7:01   ` Zbigniew Kempczyński
2023-04-19 11:57     ` Modem, Bhanuprakash
2023-04-19 16:19       ` Zbigniew Kempczyński
2023-04-21  6:47       ` Nautiyal, Ankit K
2023-04-21  7:33         ` Modem, Bhanuprakash
2023-04-21  9:33           ` Nautiyal, Ankit K
2023-04-18 17:24 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-04-18 21:28 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-04-21 16:43 ` [igt-dev] [i-g-t 00/45] " Kamil Konieczny
2023-04-24  5:21   ` Modem, Bhanuprakash
2023-04-24  9:45     ` Kamil Konieczny
2023-04-24 10:05       ` Modem, Bhanuprakash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230418164501.1687266-6-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox