* [igt-dev] [PATCH 0/1] test/gem_create: exercise gem_create_ext_set_pat
@ 2023-04-22 5:45 fei.yang
2023-04-22 5:45 ` [igt-dev] [PATCH 1/1] " fei.yang
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: fei.yang @ 2023-04-22 5:45 UTC (permalink / raw)
To: igt-dev; +Cc: Fei Yang
From: Fei Yang <fei.yang@intel.com>
This is the first draft of a new test case exercising the set_pat
extension for GEM_CREATE.
Fei Yang (1):
test/gem_create: exercise gem_create_ext_set_pat
include/drm-uapi/i915_drm.h | 33 +++++++++++++++++++++++++++++++++
tests/i915/gem_create.c | 28 ++++++++++++++++++++++++++++
2 files changed, 61 insertions(+)
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] [PATCH 1/1] test/gem_create: exercise gem_create_ext_set_pat
2023-04-22 5:45 [igt-dev] [PATCH 0/1] test/gem_create: exercise gem_create_ext_set_pat fei.yang
@ 2023-04-22 5:45 ` fei.yang
2023-04-28 9:58 ` Tvrtko Ursulin
2023-04-22 6:22 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-04-22 12:18 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: fei.yang @ 2023-04-22 5:45 UTC (permalink / raw)
To: igt-dev; +Cc: Fei Yang
From: Fei Yang <fei.yang@intel.com>
Gem_create uAPI has been extended with capability of setting PAT index.
Add a test case to exercise this new extension.
Signed-off-by: Fei Yang <fei.yang@intel.com>
---
include/drm-uapi/i915_drm.h | 33 +++++++++++++++++++++++++++++++++
tests/i915/gem_create.c | 28 ++++++++++++++++++++++++++++
2 files changed, 61 insertions(+)
diff --git a/include/drm-uapi/i915_drm.h b/include/drm-uapi/i915_drm.h
index a0876ee4..1fdaa372 100644
--- a/include/drm-uapi/i915_drm.h
+++ b/include/drm-uapi/i915_drm.h
@@ -3499,6 +3499,7 @@ struct drm_i915_gem_create_ext {
*/
#define I915_GEM_CREATE_EXT_MEMORY_REGIONS 0
#define I915_GEM_CREATE_EXT_PROTECTED_CONTENT 1
+#define I915_GEM_CREATE_EXT_SET_PAT 2
__u64 extensions;
};
@@ -3616,6 +3617,38 @@ struct drm_i915_gem_create_ext_protected_content {
/* ID of the protected content session managed by i915 when PXP is active */
#define I915_PROTECTED_CONTENT_DEFAULT_SESSION 0xf
+/**
+ * struct drm_i915_gem_create_ext_set_pat - The
+ * I915_GEM_CREATE_EXT_SET_PAT extension.
+ *
+ * If this extension is provided, the specified caching policy (PAT index) is
+ * applied to the buffer object.
+ *
+ * Below is an example on how to create an object with specific caching policy:
+ *
+ * .. code-block:: C
+ *
+ * struct drm_i915_gem_create_ext_set_pat set_pat_ext = {
+ * .base = { .name = I915_GEM_CREATE_EXT_SET_PAT },
+ * .pat_index = 0,
+ * };
+ * struct drm_i915_gem_create_ext create_ext = {
+ * .size = PAGE_SIZE,
+ * .extensions = (uintptr_t)&set_pat_ext,
+ * };
+ *
+ * int err = ioctl(fd, DRM_IOCTL_I915_GEM_CREATE_EXT, &create_ext);
+ * if (err) ...
+ */
+struct drm_i915_gem_create_ext_set_pat {
+ /** @base: Extension link. See struct i915_user_extension. */
+ struct i915_user_extension base;
+ /** @pat_index: PAT index to be set */
+ __u32 pat_index;
+ /** @rsvd: reserved for future use */
+ __u32 rsvd;
+};
+
#if defined(__cplusplus)
}
#endif
diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c
index c719ab6c..7f514355 100644
--- a/tests/i915/gem_create.c
+++ b/tests/i915/gem_create.c
@@ -537,6 +537,29 @@ static void create_ext_placement_each(int fd)
free(regions);
}
+static void create_ext_set_pat(int fd)
+{
+ struct drm_i915_gem_create_ext_set_pat setparam_pat = {
+ .base = { .name = I915_GEM_CREATE_EXT_SET_PAT },
+ .pat_index = 0,
+ };
+ struct drm_i915_gem_create_ext_set_pat setparam_inv_pat = {
+ .base = { .name = I915_GEM_CREATE_EXT_SET_PAT },
+ .pat_index = 65,
+ };
+ uint64_t size;
+ uint32_t handle;
+
+ size = PAGE_SIZE;
+
+ igt_assert_eq(__gem_create_ext(fd, &size, 0, &handle,
+ &setparam_pat.base), 0);
+
+ igt_assert_lt(__gem_create_ext(fd, &size, 0, &handle,
+ &setparam_inv_pat.base), 0);
+ gem_close(fd, handle);
+}
+
static bool supports_needs_cpu_access(int fd)
{
struct drm_i915_gem_memory_class_instance regions[] = {
@@ -897,6 +920,11 @@ igt_main
igt_subtest("create-ext-placement-all")
create_ext_placement_all(fd);
+ igt_describe("Create objects with specific cache setting"
+ " create-ext.");
+ igt_subtest("create-ext-set-pat")
+ create_ext_set_pat(fd);
+
igt_describe("Verify the basic functionally and expected ABI contract around I915_GEM_CREATE_EXT_FLAG_NEEDS_CPU_ACCESS");
igt_subtest("create-ext-cpu-access-sanity-check") {
igt_require(supports_needs_cpu_access(fd));
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for test/gem_create: exercise gem_create_ext_set_pat
2023-04-22 5:45 [igt-dev] [PATCH 0/1] test/gem_create: exercise gem_create_ext_set_pat fei.yang
2023-04-22 5:45 ` [igt-dev] [PATCH 1/1] " fei.yang
@ 2023-04-22 6:22 ` Patchwork
2023-04-22 12:18 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-04-22 6:22 UTC (permalink / raw)
To: fei.yang; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 4491 bytes --]
== Series Details ==
Series: test/gem_create: exercise gem_create_ext_set_pat
URL : https://patchwork.freedesktop.org/series/116856/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13043 -> IGTPW_8840
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/index.html
Participating hosts (36 -> 37)
------------------------------
Additional (2): fi-kbl-soraka bat-mtlp-8
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in IGTPW_8840 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][3] ([i915#1886])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@requests:
- bat-rpls-1: [PASS][4] -> [ABORT][5] ([i915#7911] / [i915#7982])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/bat-rpls-1/igt@i915_selftest@live@requests.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/bat-rpls-1/igt@i915_selftest@live@requests.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][6] ([fdo#109271]) +16 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
[i915#8346]: https://gitlab.freedesktop.org/drm/intel/issues/8346
[i915#8368]: https://gitlab.freedesktop.org/drm/intel/issues/8368
[i915#8369]: https://gitlab.freedesktop.org/drm/intel/issues/8369
[i915#8379]: https://gitlab.freedesktop.org/drm/intel/issues/8379
[i915#8382]: https://gitlab.freedesktop.org/drm/intel/issues/8382
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7264 -> IGTPW_8840
CI-20190529: 20190529
CI_DRM_13043: 2fa9c266135355c9993507d7c27cc6722956bfec @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8840: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/index.html
IGT_7264: 2f0a07378e58e5c7d7b589b39ace7e3a2317f6b2 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
+igt@gem_create@create-ext-set-pat
-igt@i915_pm_freq_api@freq-basic-api
-igt@i915_pm_freq_api@freq-reset
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/index.html
[-- Attachment #2: Type: text/html, Size: 3986 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for test/gem_create: exercise gem_create_ext_set_pat
2023-04-22 5:45 [igt-dev] [PATCH 0/1] test/gem_create: exercise gem_create_ext_set_pat fei.yang
2023-04-22 5:45 ` [igt-dev] [PATCH 1/1] " fei.yang
2023-04-22 6:22 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2023-04-22 12:18 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-04-22 12:18 UTC (permalink / raw)
To: fei.yang; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 17717 bytes --]
== Series Details ==
Series: test/gem_create: exercise gem_create_ext_set_pat
URL : https://patchwork.freedesktop.org/series/116856/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13043_full -> IGTPW_8840_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/index.html
Participating hosts (7 -> 8)
------------------------------
Additional (1): shard-rkl0
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8840_full:
### IGT changes ###
#### Possible regressions ####
* {igt@gem_create@create-ext-set-pat} (NEW):
- shard-glk: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-glk6/igt@gem_create@create-ext-set-pat.html
- {shard-rkl}: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-rkl-7/igt@gem_create@create-ext-set-pat.html
- shard-snb: NOTRUN -> [FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-snb6/igt@gem_create@create-ext-set-pat.html
- {shard-dg1}: NOTRUN -> [FAIL][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-dg1-17/igt@gem_create@create-ext-set-pat.html
- shard-apl: NOTRUN -> [FAIL][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-apl4/igt@gem_create@create-ext-set-pat.html
- {shard-tglu}: NOTRUN -> [FAIL][6]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-tglu-4/igt@gem_create@create-ext-set-pat.html
New tests
---------
New tests have been introduced between CI_DRM_13043_full and IGTPW_8840_full:
### New IGT tests (1) ###
* igt@gem_create@create-ext-set-pat:
- Statuses : 6 fail(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in IGTPW_8840_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@drm_fdinfo@virtual-idle:
- shard-glk: [PASS][7] -> [DMESG-WARN][8] ([i915#118])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-glk6/igt@drm_fdinfo@virtual-idle.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-glk8/igt@drm_fdinfo@virtual-idle.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: NOTRUN -> [FAIL][9] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-glk4/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_lmem_swapping@parallel-random-verify-ccs:
- shard-glk: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#4613]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-glk6/igt@gem_lmem_swapping@parallel-random-verify-ccs.html
* igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#3886]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-glk6/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-glk: [PASS][12] -> [FAIL][13] ([i915#2346])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render:
- shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271]) +3 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-apl3/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt:
- shard-glk: NOTRUN -> [SKIP][15] ([fdo#109271]) +41 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-glk5/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-vga-1:
- shard-snb: NOTRUN -> [SKIP][16] ([fdo#109271]) +28 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-snb6/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-vga-1.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-glk: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#658])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-glk5/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-check-all@rcs0:
- {shard-rkl}: [FAIL][18] ([i915#7742]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-rkl-4/igt@drm_fdinfo@most-busy-check-all@rcs0.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-rkl-1/igt@drm_fdinfo@most-busy-check-all@rcs0.html
* igt@gem_exec_endless@dispatch@vecs0:
- {shard-tglu}: [TIMEOUT][20] ([i915#3778]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-tglu-10/igt@gem_exec_endless@dispatch@vecs0.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-tglu-3/igt@gem_exec_endless@dispatch@vecs0.html
* igt@gem_exec_fair@basic-none@vecs0:
- {shard-rkl}: [FAIL][22] ([i915#2842]) -> [PASS][23] +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-rkl-1/igt@gem_exec_fair@basic-none@vecs0.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-rkl-7/igt@gem_exec_fair@basic-none@vecs0.html
* igt@gem_exec_schedule@smoketest@rcs0:
- shard-glk: [DMESG-WARN][24] ([i915#118]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-glk4/igt@gem_exec_schedule@smoketest@rcs0.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-glk4/igt@gem_exec_schedule@smoketest@rcs0.html
* igt@gem_lmem_swapping@smem-oom@lmem0:
- {shard-dg1}: [DMESG-WARN][26] ([i915#4936] / [i915#5493]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-dg1-15/igt@gem_lmem_swapping@smem-oom@lmem0.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-dg1-17/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@gen9_exec_parse@allowed-all:
- shard-apl: [ABORT][28] ([i915#5566]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-apl7/igt@gen9_exec_parse@allowed-all.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-apl6/igt@gen9_exec_parse@allowed-all.html
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [SKIP][30] ([fdo#109271]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-apl4/igt@i915_pm_dc@dc9-dpms.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-apl6/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rpm@dpms-non-lpsp:
- {shard-rkl}: [SKIP][32] ([i915#1397]) -> [PASS][33] +2 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-rkl-7/igt@i915_pm_rpm@dpms-non-lpsp.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-rkl-2/igt@i915_pm_rpm@dpms-non-lpsp.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [FAIL][34] ([i915#72]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-glk4/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-apl: [FAIL][36] ([i915#2346]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@single-move@pipe-b:
- {shard-rkl}: [INCOMPLETE][38] ([i915#8011]) -> [PASS][39] +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-rkl-7/igt@kms_cursor_legacy@single-move@pipe-b.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-rkl-4/igt@kms_cursor_legacy@single-move@pipe-b.html
* igt@perf_pmu@idle@rcs0:
- {shard-dg1}: [FAIL][40] ([i915#4349]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-dg1-14/igt@perf_pmu@idle@rcs0.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/shard-dg1-18/igt@perf_pmu@idle@rcs0.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3778]: https://gitlab.freedesktop.org/drm/intel/issues/3778
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8381]: https://gitlab.freedesktop.org/drm/intel/issues/8381
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7264 -> IGTPW_8840
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_13043: 2fa9c266135355c9993507d7c27cc6722956bfec @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8840: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/index.html
IGT_7264: 2f0a07378e58e5c7d7b589b39ace7e3a2317f6b2 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8840/index.html
[-- Attachment #2: Type: text/html, Size: 12666 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH 1/1] test/gem_create: exercise gem_create_ext_set_pat
2023-04-22 5:45 ` [igt-dev] [PATCH 1/1] " fei.yang
@ 2023-04-28 9:58 ` Tvrtko Ursulin
0 siblings, 0 replies; 5+ messages in thread
From: Tvrtko Ursulin @ 2023-04-28 9:58 UTC (permalink / raw)
To: fei.yang, igt-dev
On 22/04/2023 06:45, fei.yang@intel.com wrote:
> From: Fei Yang <fei.yang@intel.com>
>
> Gem_create uAPI has been extended with capability of setting PAT index.
> Add a test case to exercise this new extension.
>
> Signed-off-by: Fei Yang <fei.yang@intel.com>
> ---
> include/drm-uapi/i915_drm.h | 33 +++++++++++++++++++++++++++++++++
> tests/i915/gem_create.c | 28 ++++++++++++++++++++++++++++
> 2 files changed, 61 insertions(+)
>
> diff --git a/include/drm-uapi/i915_drm.h b/include/drm-uapi/i915_drm.h
> index a0876ee4..1fdaa372 100644
> --- a/include/drm-uapi/i915_drm.h
> +++ b/include/drm-uapi/i915_drm.h
> @@ -3499,6 +3499,7 @@ struct drm_i915_gem_create_ext {
> */
> #define I915_GEM_CREATE_EXT_MEMORY_REGIONS 0
> #define I915_GEM_CREATE_EXT_PROTECTED_CONTENT 1
> +#define I915_GEM_CREATE_EXT_SET_PAT 2
> __u64 extensions;
> };
>
> @@ -3616,6 +3617,38 @@ struct drm_i915_gem_create_ext_protected_content {
> /* ID of the protected content session managed by i915 when PXP is active */
> #define I915_PROTECTED_CONTENT_DEFAULT_SESSION 0xf
>
> +/**
> + * struct drm_i915_gem_create_ext_set_pat - The
> + * I915_GEM_CREATE_EXT_SET_PAT extension.
> + *
> + * If this extension is provided, the specified caching policy (PAT index) is
> + * applied to the buffer object.
> + *
> + * Below is an example on how to create an object with specific caching policy:
> + *
> + * .. code-block:: C
> + *
> + * struct drm_i915_gem_create_ext_set_pat set_pat_ext = {
> + * .base = { .name = I915_GEM_CREATE_EXT_SET_PAT },
> + * .pat_index = 0,
> + * };
> + * struct drm_i915_gem_create_ext create_ext = {
> + * .size = PAGE_SIZE,
> + * .extensions = (uintptr_t)&set_pat_ext,
> + * };
> + *
> + * int err = ioctl(fd, DRM_IOCTL_I915_GEM_CREATE_EXT, &create_ext);
> + * if (err) ...
> + */
> +struct drm_i915_gem_create_ext_set_pat {
> + /** @base: Extension link. See struct i915_user_extension. */
> + struct i915_user_extension base;
> + /** @pat_index: PAT index to be set */
> + __u32 pat_index;
> + /** @rsvd: reserved for future use */
> + __u32 rsvd;
> +};
> +
> #if defined(__cplusplus)
> }
> #endif
> diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c
> index c719ab6c..7f514355 100644
> --- a/tests/i915/gem_create.c
> +++ b/tests/i915/gem_create.c
> @@ -537,6 +537,29 @@ static void create_ext_placement_each(int fd)
> free(regions);
> }
>
> +static void create_ext_set_pat(int fd)
> +{
> + struct drm_i915_gem_create_ext_set_pat setparam_pat = {
> + .base = { .name = I915_GEM_CREATE_EXT_SET_PAT },
> + .pat_index = 0,
> + };
> + struct drm_i915_gem_create_ext_set_pat setparam_inv_pat = {
> + .base = { .name = I915_GEM_CREATE_EXT_SET_PAT },
> + .pat_index = 65,
> + };
> + uint64_t size;
> + uint32_t handle;
> +
> + size = PAGE_SIZE;
> +
> + igt_assert_eq(__gem_create_ext(fd, &size, 0, &handle,
> + &setparam_pat.base), 0);
> +
> + igt_assert_lt(__gem_create_ext(fd, &size, 0, &handle,
> + &setparam_inv_pat.base), 0);
You should add some tests to check get/set_caching is rejected after set
too.
Checking for EFAULT would be nice too.
Regards,
Tvrtko
> + gem_close(fd, handle);
> +}
> +
> static bool supports_needs_cpu_access(int fd)
> {
> struct drm_i915_gem_memory_class_instance regions[] = {
> @@ -897,6 +920,11 @@ igt_main
> igt_subtest("create-ext-placement-all")
> create_ext_placement_all(fd);
>
> + igt_describe("Create objects with specific cache setting"
> + " create-ext.");
> + igt_subtest("create-ext-set-pat")
> + create_ext_set_pat(fd);
> +
> igt_describe("Verify the basic functionally and expected ABI contract around I915_GEM_CREATE_EXT_FLAG_NEEDS_CPU_ACCESS");
> igt_subtest("create-ext-cpu-access-sanity-check") {
> igt_require(supports_needs_cpu_access(fd));
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-04-28 9:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-22 5:45 [igt-dev] [PATCH 0/1] test/gem_create: exercise gem_create_ext_set_pat fei.yang
2023-04-22 5:45 ` [igt-dev] [PATCH 1/1] " fei.yang
2023-04-28 9:58 ` Tvrtko Ursulin
2023-04-22 6:22 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-04-22 12:18 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox