[igt-dev] [PATCH i-g-t v2] tests/kms_plane: allow pixel-format tests to run on drivers without legacy LUT

[igt-dev] [PATCH i-g-t v2] tests/kms_plane: allow pixel-format tests to run on drivers without legacy LUT

[Maíra Canal]

Currently, the tests pixel-format and pixel-format-source-clamping
fail for drivers that doesn't have support for legacy LUT, as they
are not able to complete drmModeCrtcSetGamma() successfully. Therefore,
if !crtc->gamma_size, don't set legacy LUT and allow the pixel-format
tests to run even if the driver doesn't support legacy LUT.

Signed-off-by: Maíra Canal <mcanal@igalia.com>
---
 tests/kms_plane.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 62aee9ad..9b49f951 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -455,6 +455,9 @@ static void set_legacy_lut(data_t *data, enum pipe pipe,
 	lut_size = crtc->gamma_size;
 	drmModeFreeCrtc(crtc);
 
+	if (!crtc->gamma_size)
+		return;
+
 	lut = malloc(sizeof(uint16_t) * lut_size);
 
 	for (i = 0; i < lut_size; i++)
-- 
2.40.0

[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_plane: allow pixel-format tests to run on drivers without legacy LUT

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 3447 bytes --]

== Series Details ==

Series: tests/kms_plane: allow pixel-format tests to run on drivers without legacy LUT
URL   : https://patchwork.freedesktop.org/series/116934/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13062 -> IGTPW_8855
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_8855 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_8855, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8855/index.html

Participating hosts (39 -> 36)
------------------------------

  Missing    (3): fi-kbl-soraka bat-mtlp-8 fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_8855:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_exec_suspend@basic-s3@smem:
    - bat-rpls-1:         NOTRUN -> [ABORT][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8855/bat-rpls-1/igt@gem_exec_suspend@basic-s3@smem.html

  * igt@i915_selftest@live@requests:
    - bat-adlp-9:         [PASS][2] -> [ABORT][3]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13062/bat-adlp-9/igt@i915_selftest@live@requests.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8855/bat-adlp-9/igt@i915_selftest@live@requests.html

  * igt@i915_selftest@live@slpc:
    - bat-rpls-1:         NOTRUN -> [FAIL][4]
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8855/bat-rpls-1/igt@i915_selftest@live@slpc.html

  
Known issues
------------

  Here are the changes found in IGTPW_8855 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_suspend@basic-s3@smem:
    - fi-rkl-11600:       [PASS][5] -> [FAIL][6] ([fdo#103375])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13062/fi-rkl-11600/igt@gem_exec_suspend@basic-s3@smem.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8855/fi-rkl-11600/igt@gem_exec_suspend@basic-s3@smem.html

  * igt@kms_pipe_crc_basic@read-crc:
    - bat-dg2-11:         NOTRUN -> [SKIP][7] ([i915#5354])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8855/bat-dg2-11/igt@kms_pipe_crc_basic@read-crc.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@reset:
    - bat-rpls-1:         [ABORT][8] ([i915#8384]) -> [PASS][9]
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13062/bat-rpls-1/igt@i915_selftest@live@reset.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8855/bat-rpls-1/igt@i915_selftest@live@reset.html

  
  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7270 -> IGTPW_8855

  CI-20190529: 20190529
  CI_DRM_13062: 5a0333cf630a335d7e8f60fd2b8526ed0895900c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8855: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8855/index.html
  IGT_7270: 3bd8bf9bca97bbfb7b4b408f9fccd0cf6f742d4c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8855/index.html

[-- Attachment #2: Type: text/html, Size: 4207 bytes --]

Re: [igt-dev] [PATCH i-g-t v2] tests/kms_plane: allow pixel-format tests to run on drivers without legacy LUT

[Kamil Konieczny]

Hi Maira,

On 2023-04-25 at 12:29:04 -0300, Maíra Canal wrote:
> Currently, the tests pixel-format and pixel-format-source-clamping
> fail for drivers that doesn't have support for legacy LUT, as they
> are not able to complete drmModeCrtcSetGamma() successfully. Therefore,
> if !crtc->gamma_size, don't set legacy LUT and allow the pixel-format
> tests to run even if the driver doesn't support legacy LUT.
> 
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
>  tests/kms_plane.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index 62aee9ad..9b49f951 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -455,6 +455,9 @@ static void set_legacy_lut(data_t *data, enum pipe pipe,
---------------------------- ^
Maybe you should change that to bool.

>  	lut_size = crtc->gamma_size;
>  	drmModeFreeCrtc(crtc);
>  
> +	if (!crtc->gamma_size)
----------- ^
Use lut_size here, see function set_c8_legacy_lut
and correct caller sites to check if it is supported.

Regards,
Kamil

> +		return;
> +
>  	lut = malloc(sizeof(uint16_t) * lut_size);
>  
>  	for (i = 0; i < lut_size; i++)
> -- 
> 2.40.0
>