From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [i-g-t V3 17/45] lib/igt_draw: Add gpu draw routine support for XE
Date: Wed, 26 Apr 2023 17:16:57 +0530 [thread overview]
Message-ID: <20230426114725.2244653-18-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230426114725.2244653-1-bhanuprakash.modem@intel.com>
Add GPU blt, render & WC draw routine support for XE driver.
V2: - Rebase
Credits-to: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Acked-by: Swati Sharma <swati2.sharma@intel.com>
---
lib/igt_draw.c | 81 +++++++++++++++++++++++++++++++++++---------------
lib/igt_draw.h | 2 ++
2 files changed, 59 insertions(+), 24 deletions(-)
diff --git a/lib/igt_draw.c b/lib/igt_draw.c
index c5f2fdfe2..d719b2400 100644
--- a/lib/igt_draw.c
+++ b/lib/igt_draw.c
@@ -37,6 +37,7 @@
#include "i915/gem_create.h"
#include "i915/gem_mman.h"
#include "i915/intel_mocs.h"
+#include "xe/xe_ioctl.h"
#include "xe/xe_query.h"
#ifndef PAGE_ALIGN
@@ -494,24 +495,29 @@ static void draw_rect_mmap_wc(int fd, struct buf_data *buf, struct rect *rect,
{
uint32_t *ptr;
- gem_set_domain(fd, buf->handle, I915_GEM_DOMAIN_GTT,
- I915_GEM_DOMAIN_GTT);
-
- /* We didn't implement suport for the older tiling methods yet. */
- if (tiling != I915_TILING_NONE)
- igt_require(intel_display_ver(intel_get_drm_devid(fd)) >= 5);
-
- if (gem_has_lmem(fd))
- ptr = gem_mmap_offset__fixed(fd, buf->handle, 0,
- PAGE_ALIGN(buf->size),
- PROT_READ | PROT_WRITE);
- else if (gem_has_legacy_mmap(fd))
- ptr = gem_mmap__wc(fd, buf->handle, 0, PAGE_ALIGN(buf->size),
- PROT_READ | PROT_WRITE);
- else
- ptr = gem_mmap_offset__wc(fd, buf->handle, 0,
- PAGE_ALIGN(buf->size),
- PROT_READ | PROT_WRITE);
+ if (is_i915_device(fd)) {
+ gem_set_domain(fd, buf->handle, I915_GEM_DOMAIN_GTT,
+ I915_GEM_DOMAIN_GTT);
+
+ /* We didn't implement suport for the older tiling methods yet. */
+ if (tiling != I915_TILING_NONE)
+ igt_require(intel_display_ver(intel_get_drm_devid(fd)) >= 5);
+
+ if (gem_has_lmem(fd))
+ ptr = gem_mmap_offset__fixed(fd, buf->handle, 0,
+ PAGE_ALIGN(buf->size),
+ PROT_READ | PROT_WRITE);
+ else if (gem_has_legacy_mmap(fd))
+ ptr = gem_mmap__wc(fd, buf->handle, 0, PAGE_ALIGN(buf->size),
+ PROT_READ | PROT_WRITE);
+ else
+ ptr = gem_mmap_offset__wc(fd, buf->handle, 0,
+ PAGE_ALIGN(buf->size),
+ PROT_READ | PROT_WRITE);
+ } else {
+ ptr = xe_bo_mmap_ext(fd, buf->handle, buf->size,
+ PROT_READ | PROT_WRITE);
+ }
switch (tiling) {
case I915_TILING_NONE:
@@ -671,11 +677,14 @@ static void draw_rect_blt(int fd, struct cmd_data *cmd_data,
int gen = intel_gen(devid);
int pitch;
+ if (tiling)
+ igt_require_i915(fd);
+
dst = create_buf(fd, cmd_data->bops, buf, tiling);
ibb = intel_bb_create(fd, PAGE_SIZE);
intel_bb_add_intel_buf(ibb, dst, true);
- if (HAS_4TILE(intel_get_drm_devid(fd))) {
+ if (is_i915_device(fd) && HAS_4TILE(intel_get_drm_devid(fd))) {
int buf_height = buf->size / buf->stride;
switch (buf->bpp) {
@@ -780,11 +789,21 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
/* We create a temporary buffer and copy from it using rendercopy. */
tmp.size = rect->w * rect->h * pixel_size;
- tmp.handle = gem_create(fd, tmp.size);
+ if (is_i915_device(fd))
+ tmp.handle = gem_create(fd, tmp.size);
+ else
+ tmp.handle = xe_bo_create_flags(fd, 0,
+ ALIGN(tmp.size, xe_get_default_alignment(fd)),
+ vram_if_possible(fd, 0));
+
tmp.stride = rect->w * pixel_size;
tmp.bpp = buf->bpp;
- draw_rect_mmap_cpu(fd, &tmp, &(struct rect){0, 0, rect->w, rect->h},
- I915_TILING_NONE, I915_BIT_6_SWIZZLE_NONE, color);
+ if (is_i915_device(fd))
+ draw_rect_mmap_cpu(fd, &tmp, &(struct rect){0, 0, rect->w, rect->h},
+ I915_TILING_NONE, I915_BIT_6_SWIZZLE_NONE, color);
+ else
+ draw_rect_mmap_wc(fd, &tmp, &(struct rect){0, 0, rect->w, rect->h},
+ I915_TILING_NONE, I915_BIT_6_SWIZZLE_NONE, color);
src = create_buf(fd, cmd_data->bops, &tmp, I915_TILING_NONE);
dst = create_buf(fd, cmd_data->bops, buf, tiling);
@@ -912,7 +931,21 @@ void igt_draw_rect_fb(int fd, struct buf_ops *bops,
void igt_draw_fill_fb(int fd, struct igt_fb *fb, uint32_t color)
{
igt_draw_rect_fb(fd, NULL, 0, fb,
- gem_has_mappable_ggtt(fd) ? IGT_DRAW_MMAP_GTT :
- IGT_DRAW_MMAP_WC,
+ igt_draw_supports_method(fd, IGT_DRAW_MMAP_GTT) ?
+ IGT_DRAW_MMAP_GTT : IGT_DRAW_MMAP_WC,
0, 0, fb->width, fb->height, color);
}
+
+bool igt_draw_supports_method(int fd, enum igt_draw_method method)
+{
+ if (method == IGT_DRAW_MMAP_GTT)
+ return is_i915_device(fd) && gem_has_mappable_ggtt(fd);
+
+ if (method == IGT_DRAW_MMAP_WC)
+ return (is_i915_device(fd) && gem_mmap__has_wc(fd)) || is_xe_device(fd);
+
+ if (method == IGT_DRAW_MMAP_CPU || method == IGT_DRAW_PWRITE)
+ return is_i915_device(fd);
+
+ return true;
+}
diff --git a/lib/igt_draw.h b/lib/igt_draw.h
index 2d18ef6c9..fe7531b79 100644
--- a/lib/igt_draw.h
+++ b/lib/igt_draw.h
@@ -50,6 +50,8 @@ enum igt_draw_method {
const char *igt_draw_get_method_name(enum igt_draw_method method);
+bool igt_draw_supports_method(int fd, enum igt_draw_method method);
+
void igt_draw_rect(int fd, struct buf_ops *bops, uint32_t ctx,
uint32_t buf_handle, uint32_t buf_size, uint32_t buf_stride,
uint32_t tiling, enum igt_draw_method method,
--
2.40.0
next prev parent reply other threads:[~2023-04-26 11:52 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 11:46 [igt-dev] [i-g-t V3 00/45] Add IGT display support for XE Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 01/45] lib/xe_ioctl: Add missing header for direct resolving Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 02/45] lib/xe_query: Add region helpers and missing doc Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 03/45] lib/xe_query: Remove commented out function prototype Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 04/45] lib/intel_allocator: Add allocator support for Xe Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 05/45] lib/drmtest: Add driver enum for i915/xe Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 06/45] lib/intel_bufops: Add Xe support in bufops Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 07/45] lib/intel_batchbuffer: Rename i915 -> fd as preparation step for xe Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 08/45] lib/intel_batchbuffer: Add Xe support in intel-bb Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 09/45] tests/xe_intel_bb: Check if intel-bb Xe support correctness Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 10/45] tests/xe-fast-feedback: Add xe_intel_bb test to BAT Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 11/45] lib/gpgpu_fill: Use RENDER engine flag to work on Xe Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 12/45] tests/xe_gpgpu_fill: Exercise gpgpu fill " Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 13/45] lib/igt_fb: For xe assume vram is used on discrete Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 14/45] lib/igt_draw: Pass region while building intel_buf from flink Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 15/45] tests/kms_big_fb: Deduce region for xe framebuffer Bhanuprakash Modem
2023-04-27 6:13 ` B, Jeevan
2023-04-27 6:14 ` B, Jeevan
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 16/45] lib/igt_fb: Add copy engine support for XE Bhanuprakash Modem
2023-04-27 11:29 ` [igt-dev] [i-g-t V4 " Bhanuprakash Modem
2023-04-27 11:49 ` Zbigniew Kempczyński
2023-04-27 12:20 ` [igt-dev] [i-g-t V3 " B, Jeevan
2023-04-26 11:46 ` Bhanuprakash Modem [this message]
2023-04-27 2:21 ` [igt-dev] [i-g-t, V3, 17/45] lib/igt_draw: Add gpu draw routine " Gupta, Nidhi1
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 18/45] tests/i915/kms_big_fb: Add XE support Bhanuprakash Modem
2023-04-27 5:46 ` B, Jeevan
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 19/45] tests/i915/kms_big_joiner: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 20/45] tests/i915/kms_cdclk: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 21/45] tests/i915/kms_draw_crc: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 22/45] tests/i915/kms_dsc: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 23/45] tests/i915/kms_flip_scaled_crc: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 24/45] tests/i915/kms_flip_tiling: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 25/45] tests/i915/kms_mmap_write_crc: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 26/45] tests/kms_3d: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 27/45] tests/kms_async_flips: No " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 28/45] tests/kms_atomic_transition: Add " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 29/45] tests/color: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 30/45] tests/kms_concurrent: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 31/45] tests/kms_content_protection: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 32/45] tests/kms_cursor_crc: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 33/45] tests/kms_flip_event_leak: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 34/45] tests/kms_getfb: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 35/45] tests/kms_hdmi_inject: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 36/45] tests/kms_hdr: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 37/45] tests/kms_panel_fitting: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 38/45] tests/kms_plane: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 39/45] tests/kms_plane_lowers: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 40/45] tests/kms_plane_scaling: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 41/45] tests/kms_prime: Use Rendercopy instead of Blit Bhanuprakash Modem
2023-04-27 11:06 ` B, Jeevan
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 42/45] tests/kms_prime: Add XE support Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 43/45] tests/kms_rotation_crc: " Bhanuprakash Modem
2023-04-27 5:43 ` Sharma, Swati2
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 44/45] tests/kms_setmode: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 45/45] tests/kms_universal_plane: " Bhanuprakash Modem
2023-04-26 12:24 ` [igt-dev] ✓ Fi.CI.BAT: success for Add IGT display support for XE (rev5) Patchwork
2023-04-26 13:51 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-04-27 14:05 ` [igt-dev] ✓ Fi.CI.BAT: success for Add IGT display support for XE (rev6) Patchwork
2023-04-27 18:48 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230426114725.2244653-18-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox