From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org, zbigniew.kempczynski@intel.com
Subject: [igt-dev] [i-g-t V4 16/45] lib/igt_fb: Add copy engine support for XE
Date: Thu, 27 Apr 2023 16:59:08 +0530 [thread overview]
Message-ID: <20230427112908.2421803-1-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230426114725.2244653-17-bhanuprakash.modem@intel.com>
Add copy engine support for kms framebuffer mappings.
V2: - Drop unused syncobj(Zbigniew)
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
lib/igt_fb.c | 24 ++++++++++++++++++++----
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 76f2e1245..cf24d9e66 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -45,6 +45,7 @@
#include "igt_amd.h"
#include "igt_x86.h"
#include "igt_nouveau.h"
+#include "igt_syncobj.h"
#include "ioctl_wrappers.h"
#include "intel_batchbuffer.h"
#include "intel_chipset.h"
@@ -2489,12 +2490,13 @@ static bool blitter_ok(const struct igt_fb *fb)
static bool use_enginecopy(const struct igt_fb *fb)
{
- if (blitter_ok(fb))
+ if (!is_xe_device(fb->fd) && blitter_ok(fb))
return false;
return fb->modifier == I915_FORMAT_MOD_Yf_TILED ||
is_ccs_modifier(fb->modifier) ||
- !gem_has_mappable_ggtt(fb->fd);
+ (is_xe_device(fb->fd) && fb->modifier == DRM_FORMAT_MOD_LINEAR) ||
+ (is_i915_device(fb->fd) && !gem_has_mappable_ggtt(fb->fd));
}
static bool use_blitter(const struct igt_fb *fb)
@@ -2504,7 +2506,7 @@ static bool use_blitter(const struct igt_fb *fb)
return fb->modifier == I915_FORMAT_MOD_Y_TILED ||
fb->modifier == I915_FORMAT_MOD_Yf_TILED ||
- !gem_has_mappable_ggtt(fb->fd);
+ (is_i915_device(fb->fd) && !gem_has_mappable_ggtt(fb->fd));
}
static void init_buf_ccs(struct intel_buf *buf, int ccs_idx,
@@ -2706,7 +2708,7 @@ static void blitcopy(const struct igt_fb *dst_fb,
src_tiling = igt_fb_mod_to_tiling(src_fb->modifier);
dst_tiling = igt_fb_mod_to_tiling(dst_fb->modifier);
- if (!gem_has_relocations(dst_fb->fd)) {
+ if (is_i915_device(dst_fb->fd) && !gem_has_relocations(dst_fb->fd)) {
igt_require(gem_has_contexts(dst_fb->fd));
ctx = gem_context_create(dst_fb->fd);
ahnd = get_reloc_ahnd(dst_fb->fd, ctx);
@@ -2786,6 +2788,12 @@ static void free_linear_mapping(struct fb_blit_upload *blit)
} else if (is_nouveau_device(fd)) {
igt_nouveau_fb_blit(fb, &linear->fb);
igt_nouveau_delete_bo(&linear->fb);
+ } else if (is_xe_device(fd)) {
+ gem_munmap(linear->map, linear->fb.size);
+ copy_with_engine(blit, fb, &linear->fb);
+
+ syncobj_wait(fd, &blit->ibb->engine_syncobj, 1, INT64_MAX, 0, NULL);
+ gem_close(fd, linear->fb.gem_handle);
} else {
gem_munmap(linear->map, linear->fb.size);
gem_set_domain(fd, linear->fb.gem_handle,
@@ -2863,6 +2871,11 @@ static void setup_linear_mapping(struct fb_blit_upload *blit)
igt_nouveau_fb_blit(&linear->fb, fb);
linear->map = igt_nouveau_mmap_bo(&linear->fb, PROT_READ | PROT_WRITE);
+ } else if (is_xe_device(fd)) {
+ copy_with_engine(blit, &linear->fb, fb);
+
+ linear->map = xe_bo_mmap_ext(fd, linear->fb.gem_handle,
+ linear->fb.size, PROT_READ | PROT_WRITE);
} else {
/* Copy fb content to linear BO */
gem_set_domain(fd, linear->fb.gem_handle,
@@ -2969,6 +2982,9 @@ static void *map_bo(int fd, struct igt_fb *fb)
PROT_READ | PROT_WRITE);
else if (is_nouveau_device(fd))
ptr = igt_nouveau_mmap_bo(fb, PROT_READ | PROT_WRITE);
+ else if (is_xe_device(fd))
+ ptr = xe_bo_mmap_ext(fd, fb->gem_handle,
+ fb->size, PROT_READ | PROT_WRITE);
else
igt_assert(false);
--
2.40.0
next prev parent reply other threads:[~2023-04-27 11:33 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 11:46 [igt-dev] [i-g-t V3 00/45] Add IGT display support for XE Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 01/45] lib/xe_ioctl: Add missing header for direct resolving Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 02/45] lib/xe_query: Add region helpers and missing doc Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 03/45] lib/xe_query: Remove commented out function prototype Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 04/45] lib/intel_allocator: Add allocator support for Xe Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 05/45] lib/drmtest: Add driver enum for i915/xe Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 06/45] lib/intel_bufops: Add Xe support in bufops Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 07/45] lib/intel_batchbuffer: Rename i915 -> fd as preparation step for xe Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 08/45] lib/intel_batchbuffer: Add Xe support in intel-bb Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 09/45] tests/xe_intel_bb: Check if intel-bb Xe support correctness Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 10/45] tests/xe-fast-feedback: Add xe_intel_bb test to BAT Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 11/45] lib/gpgpu_fill: Use RENDER engine flag to work on Xe Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 12/45] tests/xe_gpgpu_fill: Exercise gpgpu fill " Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 13/45] lib/igt_fb: For xe assume vram is used on discrete Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 14/45] lib/igt_draw: Pass region while building intel_buf from flink Bhanuprakash Modem
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 15/45] tests/kms_big_fb: Deduce region for xe framebuffer Bhanuprakash Modem
2023-04-27 6:13 ` B, Jeevan
2023-04-27 6:14 ` B, Jeevan
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 16/45] lib/igt_fb: Add copy engine support for XE Bhanuprakash Modem
2023-04-27 11:29 ` Bhanuprakash Modem [this message]
2023-04-27 11:49 ` [igt-dev] [i-g-t V4 " Zbigniew Kempczyński
2023-04-27 12:20 ` [igt-dev] [i-g-t V3 " B, Jeevan
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 17/45] lib/igt_draw: Add gpu draw routine " Bhanuprakash Modem
2023-04-27 2:21 ` [igt-dev] [i-g-t, V3, " Gupta, Nidhi1
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 18/45] tests/i915/kms_big_fb: Add XE support Bhanuprakash Modem
2023-04-27 5:46 ` B, Jeevan
2023-04-26 11:46 ` [igt-dev] [i-g-t V3 19/45] tests/i915/kms_big_joiner: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 20/45] tests/i915/kms_cdclk: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 21/45] tests/i915/kms_draw_crc: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 22/45] tests/i915/kms_dsc: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 23/45] tests/i915/kms_flip_scaled_crc: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 24/45] tests/i915/kms_flip_tiling: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 25/45] tests/i915/kms_mmap_write_crc: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 26/45] tests/kms_3d: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 27/45] tests/kms_async_flips: No " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 28/45] tests/kms_atomic_transition: Add " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 29/45] tests/color: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 30/45] tests/kms_concurrent: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 31/45] tests/kms_content_protection: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 32/45] tests/kms_cursor_crc: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 33/45] tests/kms_flip_event_leak: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 34/45] tests/kms_getfb: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 35/45] tests/kms_hdmi_inject: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 36/45] tests/kms_hdr: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 37/45] tests/kms_panel_fitting: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 38/45] tests/kms_plane: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 39/45] tests/kms_plane_lowers: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 40/45] tests/kms_plane_scaling: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 41/45] tests/kms_prime: Use Rendercopy instead of Blit Bhanuprakash Modem
2023-04-27 11:06 ` B, Jeevan
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 42/45] tests/kms_prime: Add XE support Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 43/45] tests/kms_rotation_crc: " Bhanuprakash Modem
2023-04-27 5:43 ` Sharma, Swati2
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 44/45] tests/kms_setmode: " Bhanuprakash Modem
2023-04-26 11:47 ` [igt-dev] [i-g-t V3 45/45] tests/kms_universal_plane: " Bhanuprakash Modem
2023-04-26 12:24 ` [igt-dev] ✓ Fi.CI.BAT: success for Add IGT display support for XE (rev5) Patchwork
2023-04-26 13:51 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-04-27 14:05 ` [igt-dev] ✓ Fi.CI.BAT: success for Add IGT display support for XE (rev6) Patchwork
2023-04-27 18:48 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230427112908.2421803-1-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox