From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [i-g-t V5 09/47] lib/intel_batchbuffer: Update intel-bb docs
Date: Fri, 28 Apr 2023 12:43:12 +0530 [thread overview]
Message-ID: <20230428071350.2561575-10-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230428071350.2561575-1-bhanuprakash.modem@intel.com>
From: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
After RANDOM pseudo-allocator was removed and RELOC allocator becomed
stateful docs stays intact and documents old code. Fix this before
adding xe code.
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
lib/intel_batchbuffer.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
index 99b0b6158..306b7650e 100644
--- a/lib/intel_batchbuffer.c
+++ b/lib/intel_batchbuffer.c
@@ -836,7 +836,7 @@ static inline uint64_t __intel_bb_get_offset(struct intel_bb *ibb,
* @allocator_type: allocator type, must be INTEL_ALLOCATOR_NONE for relocations
*
* intel-bb assumes it will work in one of two modes - with relocations or
- * with using allocator (currently RANDOM and SIMPLE are implemented).
+ * with using allocator (currently RELOC and SIMPLE are implemented).
* Some description is required to describe how they maintain the addresses.
*
* Before entering into each scenarios generic rule is intel-bb keeps objects
@@ -854,10 +854,10 @@ static inline uint64_t __intel_bb_get_offset(struct intel_bb *ibb,
*
* This mode is valid only for ppgtt. Addresses are acquired from allocator
* and softpinned. intel-bb cache must be then coherent with allocator
- * (simple is coherent, random is not due to fact we don't keep its state).
+ * (simple is coherent, reloc partially [doesn't support address reservation]).
* When we do intel-bb reset with purging cache it has to reacquire addresses
* from allocator (allocator should return same address - what is true for
- * simple allocator and false for random as mentioned before).
+ * simple and reloc allocators).
*
* If we do reset without purging caches we use addresses from intel-bb cache
* during execbuf objects construction.
@@ -967,7 +967,7 @@ __intel_bb_create(int fd, uint32_t ctx, const intel_ctx_cfg_t *cfg,
* @size: size of the batchbuffer
* @start: allocator vm start address
* @end: allocator vm start address
- * @allocator_type: allocator type, SIMPLE, RANDOM, ...
+ * @allocator_type: allocator type, SIMPLE, RELOC, ...
* @strategy: allocation strategy
*
* Creates bb with context passed in @ctx, size in @size and allocator type
--
2.40.0
next prev parent reply other threads:[~2023-04-28 7:18 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 7:13 [igt-dev] [i-g-t V5 00/47] Add IGT display support for XE Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 01/47] lib/xe_ioctl: Add missing header for direct resolving Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 02/47] lib/xe_query: Add region helpers and missing doc Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 03/47] lib/xe_query: Remove commented out function prototype Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 04/47] lib/intel_allocator: Add allocator support for Xe Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 05/47] lib/drmtest: Add driver enum for i915/xe Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 06/47] lib/intel_bufops: Add Xe support in bufops Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 07/47] lib/intel_batchbuffer: Rename i915 -> fd as preparation step for xe Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 08/47] lib/intel_batchbuffer: Reacquire offset for reloc allocator in reset path Bhanuprakash Modem
2023-04-28 7:13 ` Bhanuprakash Modem [this message]
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 10/47] lib/intel_batchbuffer: Add Xe support in intel-bb Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 11/47] tests/xe_intel_bb: Check if intel-bb Xe support correctness Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 12/47] tests/xe-fast-feedback: Add xe_intel_bb test to BAT Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 13/47] lib/gpgpu_fill: Use RENDER engine flag to work on Xe Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 14/47] tests/xe_gpgpu_fill: Exercise gpgpu fill " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 15/47] lib/igt_fb: For xe assume vram is used on discrete Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 16/47] lib/igt_draw: Pass region while building intel_buf from flink Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 17/47] tests/kms_big_fb: Deduce region for xe framebuffer Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 18/47] lib/igt_fb: Add copy engine support for XE Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 19/47] lib/igt_draw: Add gpu draw routine " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 20/47] tests/i915/kms_big_fb: Add XE support Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 21/47] tests/i915/kms_big_joiner: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 22/47] tests/i915/kms_cdclk: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 23/47] tests/i915/kms_draw_crc: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 24/47] tests/i915/kms_dsc: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 25/47] tests/i915/kms_flip_scaled_crc: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 26/47] tests/i915/kms_flip_tiling: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 27/47] tests/i915/kms_mmap_write_crc: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 28/47] tests/kms_3d: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 29/47] tests/kms_async_flips: No " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 30/47] tests/kms_atomic_transition: Add " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 31/47] tests/color: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 32/47] tests/kms_concurrent: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 33/47] tests/kms_content_protection: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 34/47] tests/kms_cursor_crc: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 35/47] tests/kms_flip_event_leak: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 36/47] tests/kms_getfb: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 37/47] tests/kms_hdmi_inject: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 38/47] tests/kms_hdr: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 39/47] tests/kms_panel_fitting: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 40/47] tests/kms_plane: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 41/47] tests/kms_plane_lowers: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 42/47] tests/kms_plane_scaling: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 43/47] tests/kms_prime: Use Rendercopy instead of Blit Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 44/47] tests/kms_prime: Add XE support Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 45/47] tests/kms_rotation_crc: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 46/47] tests/kms_setmode: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 47/47] tests/kms_universal_plane: " Bhanuprakash Modem
2023-04-28 8:20 ` [igt-dev] ✓ Fi.CI.BAT: success for Add IGT display support for XE (rev8) Patchwork
2023-04-28 11:07 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230428071350.2561575-10-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox