From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [i-g-t V5 45/47] tests/kms_rotation_crc: Add XE support
Date: Fri, 28 Apr 2023 12:43:48 +0530 [thread overview]
Message-ID: <20230428071350.2561575-46-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230428071350.2561575-1-bhanuprakash.modem@intel.com>
Add XE driver support for kms tests.
V2: - Drop i915 check for bad-tiling test.
- Skip exhaust-fences as it needs Y-tiling
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>
---
tests/kms_rotation_crc.c | 23 +++++++++++++++--------
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index 295aed762..28b4fd27c 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -459,7 +459,7 @@ static bool test_format(data_t *data,
if (!igt_fb_supported_format(format))
return false;
- if (!is_i915_device(data->gfx_fd) ||
+ if (!is_intel_device(data->gfx_fd) ||
data->extended)
return true;
@@ -545,14 +545,14 @@ static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_form
igt_require(igt_plane_has_prop(plane, IGT_PLANE_ROTATION));
igt_require(igt_plane_has_rotation(plane, data->rotation));
/* CHV can't rotate and reflect simultaneously */
- igt_require(!is_i915_device(data->gfx_fd) ||
+ igt_require(!is_intel_device(data->gfx_fd) ||
!IS_CHERRYVIEW(data->devid) ||
data->rotation != (IGT_ROTATION_180 | IGT_REFLECT_X));
prepare_crtc(data, output, pipe, plane, true);
for (i = 0; i < num_rectangle_types; i++) {
- /* Unsupported on i915 */
+ /* Unsupported on intel */
if (plane_type == DRM_PLANE_TYPE_CURSOR &&
i != square)
continue;
@@ -560,9 +560,8 @@ static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_form
/* Only support partial covering primary plane on gen9+ */
if (is_amdgpu_device(data->gfx_fd) ||
(plane_type == DRM_PLANE_TYPE_PRIMARY &&
- is_i915_device(data->gfx_fd) &&
- intel_display_ver(
- intel_get_drm_devid(data->gfx_fd)) < 9)) {
+ is_intel_device(data->gfx_fd) &&
+ intel_display_ver(data->devid) < 9)) {
if (i != rectangle)
continue;
else
@@ -592,7 +591,7 @@ static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_form
data->override_fmt, test_bad_format);
}
}
- if (is_i915_device(data->gfx_fd)) {
+ if (is_intel_device(data->gfx_fd)) {
igt_pipe_crc_stop(data->pipe_crc);
}
}
@@ -841,6 +840,10 @@ static void test_multi_plane_rotation(data_t *data, enum pipe pipe)
igt_pipe_crc_start(data->pipe_crc);
for (i = 0; i < ARRAY_SIZE(planeconfigs); i++) {
+ if (is_xe_device(data->gfx_fd) &&
+ planeconfigs[i].modifier != DRM_FORMAT_MOD_LINEAR)
+ continue;
+
p[0].fbinfo = &planeconfigs[i];
pointlocation(data, p, mode, 0);
@@ -1137,7 +1140,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
igt_fixture {
data.gfx_fd = drm_open_driver_master(DRIVER_ANY);
- if (is_i915_device(data.gfx_fd)) {
+ if (is_intel_device(data.gfx_fd)) {
data.devid = intel_get_drm_devid(data.gfx_fd);
gen = intel_display_ver(data.devid);
}
@@ -1201,6 +1204,9 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
igt_describe("Tiling and Rotation test for gen 10+ for primary plane");
for (reflect_x = reflect_x_subtests; reflect_x->modifier; reflect_x++) {
+ igt_fixture
+ igt_require_i915(data.gfx_fd);
+
igt_subtest_f("primary-%s-reflect-x-%s",
modifier_test_str(reflect_x->modifier),
rot_test_str(reflect_x->rot)) {
@@ -1260,6 +1266,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
enum pipe pipe;
igt_output_t *output;
+ igt_require_i915(data.gfx_fd);
igt_display_require_output(&data.display);
for_each_pipe_with_valid_output(&data.display, pipe, output) {
--
2.40.0
next prev parent reply other threads:[~2023-04-28 7:19 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 7:13 [igt-dev] [i-g-t V5 00/47] Add IGT display support for XE Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 01/47] lib/xe_ioctl: Add missing header for direct resolving Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 02/47] lib/xe_query: Add region helpers and missing doc Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 03/47] lib/xe_query: Remove commented out function prototype Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 04/47] lib/intel_allocator: Add allocator support for Xe Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 05/47] lib/drmtest: Add driver enum for i915/xe Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 06/47] lib/intel_bufops: Add Xe support in bufops Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 07/47] lib/intel_batchbuffer: Rename i915 -> fd as preparation step for xe Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 08/47] lib/intel_batchbuffer: Reacquire offset for reloc allocator in reset path Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 09/47] lib/intel_batchbuffer: Update intel-bb docs Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 10/47] lib/intel_batchbuffer: Add Xe support in intel-bb Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 11/47] tests/xe_intel_bb: Check if intel-bb Xe support correctness Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 12/47] tests/xe-fast-feedback: Add xe_intel_bb test to BAT Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 13/47] lib/gpgpu_fill: Use RENDER engine flag to work on Xe Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 14/47] tests/xe_gpgpu_fill: Exercise gpgpu fill " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 15/47] lib/igt_fb: For xe assume vram is used on discrete Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 16/47] lib/igt_draw: Pass region while building intel_buf from flink Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 17/47] tests/kms_big_fb: Deduce region for xe framebuffer Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 18/47] lib/igt_fb: Add copy engine support for XE Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 19/47] lib/igt_draw: Add gpu draw routine " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 20/47] tests/i915/kms_big_fb: Add XE support Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 21/47] tests/i915/kms_big_joiner: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 22/47] tests/i915/kms_cdclk: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 23/47] tests/i915/kms_draw_crc: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 24/47] tests/i915/kms_dsc: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 25/47] tests/i915/kms_flip_scaled_crc: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 26/47] tests/i915/kms_flip_tiling: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 27/47] tests/i915/kms_mmap_write_crc: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 28/47] tests/kms_3d: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 29/47] tests/kms_async_flips: No " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 30/47] tests/kms_atomic_transition: Add " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 31/47] tests/color: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 32/47] tests/kms_concurrent: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 33/47] tests/kms_content_protection: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 34/47] tests/kms_cursor_crc: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 35/47] tests/kms_flip_event_leak: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 36/47] tests/kms_getfb: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 37/47] tests/kms_hdmi_inject: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 38/47] tests/kms_hdr: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 39/47] tests/kms_panel_fitting: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 40/47] tests/kms_plane: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 41/47] tests/kms_plane_lowers: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 42/47] tests/kms_plane_scaling: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 43/47] tests/kms_prime: Use Rendercopy instead of Blit Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 44/47] tests/kms_prime: Add XE support Bhanuprakash Modem
2023-04-28 7:13 ` Bhanuprakash Modem [this message]
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 46/47] tests/kms_setmode: " Bhanuprakash Modem
2023-04-28 7:13 ` [igt-dev] [i-g-t V5 47/47] tests/kms_universal_plane: " Bhanuprakash Modem
2023-04-28 8:20 ` [igt-dev] ✓ Fi.CI.BAT: success for Add IGT display support for XE (rev8) Patchwork
2023-04-28 11:07 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230428071350.2561575-46-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox