* [igt-dev] [PATCH i-g-t] lib/instdone: GEN12 INSTDONE initialization
@ 2023-05-17 8:58 janga.rahul.kumar
2023-05-17 11:30 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: janga.rahul.kumar @ 2023-05-17 8:58 UTC (permalink / raw)
To: igt-dev, ramadevi.gandi, janga.rahul.kumar
From: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
Add GEN12 INSTDONE initialization as per spec.
Cc: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
---
lib/instdone.c | 69 +++++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 68 insertions(+), 1 deletion(-)
diff --git a/lib/instdone.c b/lib/instdone.c
index a83f8836..d1c92793 100644
--- a/lib/instdone.c
+++ b/lib/instdone.c
@@ -274,6 +274,30 @@
# define GEN6_VS0_DONE (1 << 1)
# define GEN6_VF_DONE (1 << 0)
+# define GEN12_TSG1_DONE (1 << 24)
+# define GEN12_RCCFBC_CS_DONE (1 << 23)
+# define GEN12_SDE_DONE (1 << 22)
+# define GEN12_CS_DONE (1 << 21)
+# define GEN12_RS_DONE (1 << 20)
+# define GEN12_GAFD_DONE (1 << 19)
+# define GEN12_GAFM_DONE (1 << 18)
+# define GEN12_TSG0_DONE (1 << 17)
+# define GEN12_VFE_DONE (1 << 16)
+# define GEN12_GAFS_DONE (1 << 15)
+# define GEN12_SVG_DONE (1 << 14)
+# define GEN12_URBM_DONE (1 << 13)
+# define GEN12_TDG0_DONE (1 << 12)
+# define GEN12_TDG1_DONE (1 << 11)
+# define GEN12_SF_DONE (1 << 9)
+# define GEN12_CL_DONE (1 << 8)
+# define GEN12_SOL_DONE (1 << 7)
+# define GEN12_GS_DONE (1 << 6)
+# define GEN12_DS_DONE (1 << 5)
+# define GEN12_TE_DONE (1 << 4)
+# define GEN12_HS_DONE (1 << 3)
+# define GEN12_VS_DONE (1 << 2)
+# define GEN12_VFG_DONE (1 << 1)
+
struct instdone_bit instdone_bits[MAX_INSTDONE_BITS];
int num_instdone_bits = 0;
@@ -425,10 +449,53 @@ init_gen11_instdone(void)
init_gen8_instdone();
}
+static void
+init_xehp_instdone(void)
+{
+ gen6_instdone1_bit(GEN12_RCCFBC_CS_DONE, "RCCFBC CS");
+ gen6_instdone1_bit(GEN12_CS_DONE, "CS");
+ gen6_instdone1_bit(GEN12_RS_DONE, "RS");
+ gen6_instdone1_bit(GEN12_VFE_DONE, "VFE");
+ gen6_instdone1_bit(GEN12_VFG_DONE, "VFG");
+}
+
+static void
+init_gen12_instdone(uint32_t devid)
+{
+ if (intel_graphics_ver(devid) >= IP_VER(12, 50)) {
+ init_xehp_instdone();
+ } else {
+ gen6_instdone1_bit(GEN12_TSG1_DONE, "TSG1");
+ gen6_instdone1_bit(GEN12_RCCFBC_CS_DONE, "RCCFBC CS");
+ gen6_instdone1_bit(GEN12_SDE_DONE, "SDE");
+ gen6_instdone1_bit(GEN12_CS_DONE, "CS");
+ gen6_instdone1_bit(GEN12_RS_DONE, "RS");
+ gen6_instdone1_bit(GEN12_GAFD_DONE, "GAFD");
+ gen6_instdone1_bit(GEN12_GAFM_DONE, "GAFM");
+ gen6_instdone1_bit(GEN12_TSG0_DONE, "TSG0");
+ gen6_instdone1_bit(GEN12_VFE_DONE, "VFE");
+ gen6_instdone1_bit(GEN12_GAFS_DONE, "GAFS");
+ gen6_instdone1_bit(GEN12_SVG_DONE, "SVG");
+ gen6_instdone1_bit(GEN12_URBM_DONE, "URBM");
+ gen6_instdone1_bit(GEN12_TDG0_DONE, "TDG0");
+ gen6_instdone1_bit(GEN12_TDG1_DONE, "TDG1");
+ gen6_instdone1_bit(GEN12_SF_DONE, "SF");
+ gen6_instdone1_bit(GEN12_CL_DONE, "CL");
+ gen6_instdone1_bit(GEN12_SOL_DONE, "SOL");
+ gen6_instdone1_bit(GEN12_GS_DONE, "GS");
+ gen6_instdone1_bit(GEN12_DS_DONE, "DS");
+ gen6_instdone1_bit(GEN12_TE_DONE, "TE");
+ gen6_instdone1_bit(GEN12_HS_DONE, "HS");
+ gen6_instdone1_bit(GEN12_VS_DONE, "VS");
+ gen6_instdone1_bit(GEN12_VFG_DONE, "VFG");
+ }
+}
bool
init_instdone_definitions(uint32_t devid)
{
- if (IS_GEN11(devid)) {
+ if (IS_GEN12(devid)) {
+ init_gen12_instdone(devid);
+ } else if (IS_GEN11(devid)) {
init_gen11_instdone();
} else if (IS_GEN8(devid) || IS_GEN9(devid) || IS_GEN10(devid)) {
init_gen8_instdone();
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for lib/instdone: GEN12 INSTDONE initialization 2023-05-17 8:58 [igt-dev] [PATCH i-g-t] lib/instdone: GEN12 INSTDONE initialization janga.rahul.kumar @ 2023-05-17 11:30 ` Patchwork 2023-05-17 21:48 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2023-05-25 16:18 ` [igt-dev] [PATCH i-g-t] " Matt Roper 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2023-05-17 11:30 UTC (permalink / raw) To: janga.rahul.kumar; +Cc: igt-dev [-- Attachment #1: Type: text/plain, Size: 5602 bytes --] == Series Details == Series: lib/instdone: GEN12 INSTDONE initialization URL : https://patchwork.freedesktop.org/series/117863/ State : success == Summary == CI Bug Log - changes from CI_DRM_13158 -> IGTPW_8983 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/index.html Participating hosts (36 -> 35) ------------------------------ Missing (1): fi-snb-2520m Known issues ------------ Here are the changes found in IGTPW_8983 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s0@smem: - bat-jsl-3: [PASS][1] -> [ABORT][2] ([i915#5122]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/bat-jsl-3/igt@gem_exec_suspend@basic-s0@smem.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/bat-jsl-3/igt@gem_exec_suspend@basic-s0@smem.html * igt@i915_selftest@live@guc: - bat-rpls-2: NOTRUN -> [DMESG-WARN][3] ([i915#7852]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/bat-rpls-2/igt@i915_selftest@live@guc.html * igt@i915_selftest@live@hangcheck: - bat-atsm-1: [PASS][4] -> [INCOMPLETE][5] ([i915#7913]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/bat-atsm-1/igt@i915_selftest@live@hangcheck.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/bat-atsm-1/igt@i915_selftest@live@hangcheck.html * igt@i915_selftest@live@migrate: - bat-adlp-9: [PASS][6] -> [DMESG-FAIL][7] ([i915#7699] / [i915#7913]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/bat-adlp-9/igt@i915_selftest@live@migrate.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/bat-adlp-9/igt@i915_selftest@live@migrate.html * igt@i915_selftest@live@slpc: - bat-rpls-2: NOTRUN -> [DMESG-WARN][8] ([i915#6367]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/bat-rpls-2/igt@i915_selftest@live@slpc.html * igt@i915_suspend@basic-s2idle-without-i915: - bat-rpls-2: NOTRUN -> [ABORT][9] ([i915#6687]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/bat-rpls-2/igt@i915_suspend@basic-s2idle-without-i915.html * igt@i915_suspend@basic-s3-without-i915: - bat-jsl-3: [PASS][10] -> [FAIL][11] ([fdo#103375]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/bat-jsl-3/igt@i915_suspend@basic-s3-without-i915.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/bat-jsl-3/igt@i915_suspend@basic-s3-without-i915.html #### Possible fixes #### * igt@i915_selftest@live@hangcheck: - fi-skl-guc: [DMESG-WARN][12] ([i915#8073]) -> [PASS][13] [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/fi-skl-guc/igt@i915_selftest@live@hangcheck.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/fi-skl-guc/igt@i915_selftest@live@hangcheck.html * igt@i915_selftest@live@reset: - bat-rpls-2: [ABORT][14] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#8347]) -> [PASS][15] [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/bat-rpls-2/igt@i915_selftest@live@reset.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/bat-rpls-2/igt@i915_selftest@live@reset.html * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1: - bat-dg2-8: [FAIL][16] ([i915#7932]) -> [PASS][17] +1 similar issue [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html #### Warnings #### * igt@kms_psr@sprite_plane_onoff: - bat-adln-1: [ABORT][18] ([i915#8442]) -> [ABORT][19] ([i915#8434] / [i915#8442]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/bat-adln-1/igt@kms_psr@sprite_plane_onoff.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/bat-adln-1/igt@kms_psr@sprite_plane_onoff.html [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 [i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122 [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367 [i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687 [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461 [i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699 [i915#7852]: https://gitlab.freedesktop.org/drm/intel/issues/7852 [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913 [i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932 [i915#8073]: https://gitlab.freedesktop.org/drm/intel/issues/8073 [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347 [i915#8434]: https://gitlab.freedesktop.org/drm/intel/issues/8434 [i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_7293 -> IGTPW_8983 CI-20190529: 20190529 CI_DRM_13158: b45eb9c3ab2393968cda9bb8eb12878be3df8ce6 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_8983: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/index.html IGT_7293: a19a081d1b8a8f902d7d8009a6ea6c471d5531ad @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/index.html [-- Attachment #2: Type: text/html, Size: 6652 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for lib/instdone: GEN12 INSTDONE initialization 2023-05-17 8:58 [igt-dev] [PATCH i-g-t] lib/instdone: GEN12 INSTDONE initialization janga.rahul.kumar 2023-05-17 11:30 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork @ 2023-05-17 21:48 ` Patchwork 2023-05-25 16:18 ` [igt-dev] [PATCH i-g-t] " Matt Roper 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2023-05-17 21:48 UTC (permalink / raw) To: janga.rahul.kumar; +Cc: igt-dev [-- Attachment #1: Type: text/plain, Size: 13663 bytes --] == Series Details == Series: lib/instdone: GEN12 INSTDONE initialization URL : https://patchwork.freedesktop.org/series/117863/ State : success == Summary == CI Bug Log - changes from CI_DRM_13158_full -> IGTPW_8983_full ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/index.html Participating hosts (7 -> 7) ------------------------------ No changes in participating hosts Known issues ------------ Here are the changes found in IGTPW_8983_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-apl: [PASS][1] -> [FAIL][2] ([i915#2842]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/shard-apl3/igt@gem_exec_fair@basic-pace-solo@rcs0.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/shard-apl6/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@kms_async_flips@alternate-sync-async-flip@pipe-a-hdmi-a-1: - shard-glk: [PASS][3] -> [FAIL][4] ([i915#2521]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/shard-glk9/igt@kms_async_flips@alternate-sync-async-flip@pipe-a-hdmi-a-1.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/shard-glk6/igt@kms_async_flips@alternate-sync-async-flip@pipe-a-hdmi-a-1.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-glk: [PASS][5] -> [FAIL][6] ([i915#2346]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2: - shard-glk: [PASS][7] -> [FAIL][8] ([i915#79]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@b-dp1: - shard-apl: [PASS][9] -> [FAIL][10] ([i915#79]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/shard-apl2/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-dp1.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/shard-apl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-dp1.html #### Possible fixes #### * igt@gem_ctx_exec@basic-nohangcheck: - {shard-rkl}: [FAIL][11] ([i915#6268]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/shard-rkl-3/igt@gem_ctx_exec@basic-nohangcheck.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/shard-rkl-7/igt@gem_ctx_exec@basic-nohangcheck.html - {shard-tglu}: [FAIL][13] ([i915#6268]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/shard-tglu-5/igt@gem_ctx_exec@basic-nohangcheck.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/shard-tglu-8/igt@gem_ctx_exec@basic-nohangcheck.html * igt@gem_eio@hibernate: - {shard-dg1}: [ABORT][15] ([i915#4391] / [i915#7975] / [i915#8213]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/shard-dg1-14/igt@gem_eio@hibernate.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/shard-dg1-18/igt@gem_eio@hibernate.html * igt@gem_exec_fair@basic-none@bcs0: - {shard-rkl}: [FAIL][17] ([i915#2842]) -> [PASS][18] +2 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/shard-rkl-6/igt@gem_exec_fair@basic-none@bcs0.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/shard-rkl-7/igt@gem_exec_fair@basic-none@bcs0.html * igt@gem_exec_fair@basic-pace@rcs0: - shard-glk: [FAIL][19] ([i915#2842]) -> [PASS][20] +1 similar issue [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/shard-glk3/igt@gem_exec_fair@basic-pace@rcs0.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/shard-glk3/igt@gem_exec_fair@basic-pace@rcs0.html * igt@i915_pm_rpm@modeset-lpsp: - {shard-rkl}: [SKIP][21] ([i915#1397]) -> [PASS][22] [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/shard-rkl-2/igt@i915_pm_rpm@modeset-lpsp.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/shard-rkl-7/igt@i915_pm_rpm@modeset-lpsp.html * igt@i915_suspend@basic-s3-without-i915: - {shard-rkl}: [FAIL][23] ([fdo#103375]) -> [PASS][24] [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/shard-rkl-6/igt@i915_suspend@basic-s3-without-i915.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/shard-rkl-1/igt@i915_suspend@basic-s3-without-i915.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-glk: [FAIL][25] ([i915#2346]) -> [PASS][26] [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a1: - shard-glk: [FAIL][27] ([i915#79]) -> [PASS][28] [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/shard-glk4/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a1.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/shard-glk8/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a1.html * igt@kms_rotation_crc@multiplane-rotation-cropping-bottom: - {shard-rkl}: [ABORT][29] ([i915#7461] / [i915#8311]) -> [PASS][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/shard-rkl-4/igt@kms_rotation_crc@multiplane-rotation-cropping-bottom.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/shard-rkl-1/igt@kms_rotation_crc@multiplane-rotation-cropping-bottom.html * igt@perf_pmu@idle@rcs0: - {shard-rkl}: [FAIL][31] ([i915#4349]) -> [PASS][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/shard-rkl-7/igt@perf_pmu@idle@rcs0.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/shard-rkl-3/igt@perf_pmu@idle@rcs0.html * igt@prime_vgem@basic-gtt: - {shard-rkl}: [ABORT][33] -> [PASS][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13158/shard-rkl-1/igt@prime_vgem@basic-gtt.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/shard-rkl-7/igt@prime_vgem@basic-gtt.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279 [fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303 [fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312 [fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681 [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023 [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116 [i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291 [i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323 [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458 [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734 [i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804 [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955 [i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349 [i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387 [i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391 [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5234]: https://gitlab.freedesktop.org/drm/intel/issues/5234 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 [i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268 [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433 [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768 [i915#6786]: https://gitlab.freedesktop.org/drm/intel/issues/6786 [i915#7276]: https://gitlab.freedesktop.org/drm/intel/issues/7276 [i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456 [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461 [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561 [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697 [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711 [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975 [i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011 [i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213 [i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247 [i915#8311]: https://gitlab.freedesktop.org/drm/intel/issues/8311 [i915#8381]: https://gitlab.freedesktop.org/drm/intel/issues/8381 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_7293 -> IGTPW_8983 * Piglit: piglit_4509 -> None CI-20190529: 20190529 CI_DRM_13158: b45eb9c3ab2393968cda9bb8eb12878be3df8ce6 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_8983: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/index.html IGT_7293: a19a081d1b8a8f902d7d8009a6ea6c471d5531ad @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8983/index.html [-- Attachment #2: Type: text/html, Size: 9867 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/instdone: GEN12 INSTDONE initialization 2023-05-17 8:58 [igt-dev] [PATCH i-g-t] lib/instdone: GEN12 INSTDONE initialization janga.rahul.kumar 2023-05-17 11:30 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2023-05-17 21:48 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork @ 2023-05-25 16:18 ` Matt Roper 2023-05-25 16:19 ` Matt Roper 2 siblings, 1 reply; 5+ messages in thread From: Matt Roper @ 2023-05-25 16:18 UTC (permalink / raw) To: janga.rahul.kumar; +Cc: igt-dev, ramadevi.gandi On Wed, May 17, 2023 at 02:28:17PM +0530, janga.rahul.kumar@intel.com wrote: > From: Janga Rahul Kumar <janga.rahul.kumar@intel.com> > > Add GEN12 INSTDONE initialization as per spec. > > Cc: Matt Roper <matthew.d.roper@intel.com> > Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com> > --- > lib/instdone.c | 69 +++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 68 insertions(+), 1 deletion(-) > > diff --git a/lib/instdone.c b/lib/instdone.c > index a83f8836..d1c92793 100644 > --- a/lib/instdone.c > +++ b/lib/instdone.c > @@ -274,6 +274,30 @@ > # define GEN6_VS0_DONE (1 << 1) > # define GEN6_VF_DONE (1 << 0) > > +# define GEN12_TSG1_DONE (1 << 24) > +# define GEN12_RCCFBC_CS_DONE (1 << 23) > +# define GEN12_SDE_DONE (1 << 22) > +# define GEN12_CS_DONE (1 << 21) > +# define GEN12_RS_DONE (1 << 20) > +# define GEN12_GAFD_DONE (1 << 19) > +# define GEN12_GAFM_DONE (1 << 18) > +# define GEN12_TSG0_DONE (1 << 17) > +# define GEN12_VFE_DONE (1 << 16) > +# define GEN12_GAFS_DONE (1 << 15) > +# define GEN12_SVG_DONE (1 << 14) > +# define GEN12_URBM_DONE (1 << 13) > +# define GEN12_TDG0_DONE (1 << 12) > +# define GEN12_TDG1_DONE (1 << 11) > +# define GEN12_SF_DONE (1 << 9) > +# define GEN12_CL_DONE (1 << 8) > +# define GEN12_SOL_DONE (1 << 7) > +# define GEN12_GS_DONE (1 << 6) > +# define GEN12_DS_DONE (1 << 5) > +# define GEN12_TE_DONE (1 << 4) > +# define GEN12_HS_DONE (1 << 3) > +# define GEN12_VS_DONE (1 << 2) > +# define GEN12_VFG_DONE (1 << 1) > + > struct instdone_bit instdone_bits[MAX_INSTDONE_BITS]; > int num_instdone_bits = 0; > > @@ -425,10 +449,53 @@ init_gen11_instdone(void) > init_gen8_instdone(); > } > > +static void > +init_xehp_instdone(void) > +{ > + gen6_instdone1_bit(GEN12_RCCFBC_CS_DONE, "RCCFBC CS"); > + gen6_instdone1_bit(GEN12_CS_DONE, "CS"); > + gen6_instdone1_bit(GEN12_RS_DONE, "RS"); > + gen6_instdone1_bit(GEN12_VFE_DONE, "VFE"); > + gen6_instdone1_bit(GEN12_VFG_DONE, "VFG"); > +} > + > +static void > +init_gen12_instdone(uint32_t devid) > +{ > + if (intel_graphics_ver(devid) >= IP_VER(12, 50)) { > + init_xehp_instdone(); Rather than putting this inside the init_gen12_instdone function it would be better to add this to the top of the if/else ladder in init_instdone_definitions(). Even though Xe_HP platforms have a version number that starts with 12, they're not considered to be "gen12" platforms so putting it here is confusing. Aside from that minor change, Reviewed-by: Matt Roper <matthew.d.roper@intel.com> > + } else { > + gen6_instdone1_bit(GEN12_TSG1_DONE, "TSG1"); > + gen6_instdone1_bit(GEN12_RCCFBC_CS_DONE, "RCCFBC CS"); > + gen6_instdone1_bit(GEN12_SDE_DONE, "SDE"); > + gen6_instdone1_bit(GEN12_CS_DONE, "CS"); > + gen6_instdone1_bit(GEN12_RS_DONE, "RS"); > + gen6_instdone1_bit(GEN12_GAFD_DONE, "GAFD"); > + gen6_instdone1_bit(GEN12_GAFM_DONE, "GAFM"); > + gen6_instdone1_bit(GEN12_TSG0_DONE, "TSG0"); > + gen6_instdone1_bit(GEN12_VFE_DONE, "VFE"); > + gen6_instdone1_bit(GEN12_GAFS_DONE, "GAFS"); > + gen6_instdone1_bit(GEN12_SVG_DONE, "SVG"); > + gen6_instdone1_bit(GEN12_URBM_DONE, "URBM"); > + gen6_instdone1_bit(GEN12_TDG0_DONE, "TDG0"); > + gen6_instdone1_bit(GEN12_TDG1_DONE, "TDG1"); > + gen6_instdone1_bit(GEN12_SF_DONE, "SF"); > + gen6_instdone1_bit(GEN12_CL_DONE, "CL"); > + gen6_instdone1_bit(GEN12_SOL_DONE, "SOL"); > + gen6_instdone1_bit(GEN12_GS_DONE, "GS"); > + gen6_instdone1_bit(GEN12_DS_DONE, "DS"); > + gen6_instdone1_bit(GEN12_TE_DONE, "TE"); > + gen6_instdone1_bit(GEN12_HS_DONE, "HS"); > + gen6_instdone1_bit(GEN12_VS_DONE, "VS"); > + gen6_instdone1_bit(GEN12_VFG_DONE, "VFG"); > + } > +} > bool > init_instdone_definitions(uint32_t devid) > { > - if (IS_GEN11(devid)) { > + if (IS_GEN12(devid)) { > + init_gen12_instdone(devid); > + } else if (IS_GEN11(devid)) { > init_gen11_instdone(); > } else if (IS_GEN8(devid) || IS_GEN9(devid) || IS_GEN10(devid)) { > init_gen8_instdone(); > -- > 2.25.1 > -- Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/instdone: GEN12 INSTDONE initialization 2023-05-25 16:18 ` [igt-dev] [PATCH i-g-t] " Matt Roper @ 2023-05-25 16:19 ` Matt Roper 0 siblings, 0 replies; 5+ messages in thread From: Matt Roper @ 2023-05-25 16:19 UTC (permalink / raw) To: janga.rahul.kumar; +Cc: igt-dev, ramadevi.gandi On Thu, May 25, 2023 at 09:18:59AM -0700, Matt Roper wrote: > On Wed, May 17, 2023 at 02:28:17PM +0530, janga.rahul.kumar@intel.com wrote: > > From: Janga Rahul Kumar <janga.rahul.kumar@intel.com> > > > > Add GEN12 INSTDONE initialization as per spec. > > > > Cc: Matt Roper <matthew.d.roper@intel.com> > > Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com> > > --- > > lib/instdone.c | 69 +++++++++++++++++++++++++++++++++++++++++++++++++- > > 1 file changed, 68 insertions(+), 1 deletion(-) > > > > diff --git a/lib/instdone.c b/lib/instdone.c > > index a83f8836..d1c92793 100644 > > --- a/lib/instdone.c > > +++ b/lib/instdone.c > > @@ -274,6 +274,30 @@ > > # define GEN6_VS0_DONE (1 << 1) > > # define GEN6_VF_DONE (1 << 0) > > > > +# define GEN12_TSG1_DONE (1 << 24) > > +# define GEN12_RCCFBC_CS_DONE (1 << 23) > > +# define GEN12_SDE_DONE (1 << 22) > > +# define GEN12_CS_DONE (1 << 21) > > +# define GEN12_RS_DONE (1 << 20) > > +# define GEN12_GAFD_DONE (1 << 19) > > +# define GEN12_GAFM_DONE (1 << 18) > > +# define GEN12_TSG0_DONE (1 << 17) > > +# define GEN12_VFE_DONE (1 << 16) > > +# define GEN12_GAFS_DONE (1 << 15) > > +# define GEN12_SVG_DONE (1 << 14) > > +# define GEN12_URBM_DONE (1 << 13) > > +# define GEN12_TDG0_DONE (1 << 12) > > +# define GEN12_TDG1_DONE (1 << 11) > > +# define GEN12_SF_DONE (1 << 9) > > +# define GEN12_CL_DONE (1 << 8) > > +# define GEN12_SOL_DONE (1 << 7) > > +# define GEN12_GS_DONE (1 << 6) > > +# define GEN12_DS_DONE (1 << 5) > > +# define GEN12_TE_DONE (1 << 4) > > +# define GEN12_HS_DONE (1 << 3) > > +# define GEN12_VS_DONE (1 << 2) > > +# define GEN12_VFG_DONE (1 << 1) > > + > > struct instdone_bit instdone_bits[MAX_INSTDONE_BITS]; > > int num_instdone_bits = 0; > > > > @@ -425,10 +449,53 @@ init_gen11_instdone(void) > > init_gen8_instdone(); > > } > > > > +static void > > +init_xehp_instdone(void) > > +{ > > + gen6_instdone1_bit(GEN12_RCCFBC_CS_DONE, "RCCFBC CS"); > > + gen6_instdone1_bit(GEN12_CS_DONE, "CS"); > > + gen6_instdone1_bit(GEN12_RS_DONE, "RS"); > > + gen6_instdone1_bit(GEN12_VFE_DONE, "VFE"); > > + gen6_instdone1_bit(GEN12_VFG_DONE, "VFG"); > > +} > > + > > +static void > > +init_gen12_instdone(uint32_t devid) > > +{ > > + if (intel_graphics_ver(devid) >= IP_VER(12, 50)) { > > + init_xehp_instdone(); > > Rather than putting this inside the init_gen12_instdone function it > would be better to add this to the top of the if/else ladder in > init_instdone_definitions(). Even though Xe_HP platforms have a version > number that starts with 12, they're not considered to be "gen12" > platforms so putting it here is confusing. Oh, and it might also be worth changing the patch title to "lib/instdone: GEN12 and XEHP INSTDONE initialization" for similar reasons. Matt > > Aside from that minor change, > > Reviewed-by: Matt Roper <matthew.d.roper@intel.com> > > > + } else { > > + gen6_instdone1_bit(GEN12_TSG1_DONE, "TSG1"); > > + gen6_instdone1_bit(GEN12_RCCFBC_CS_DONE, "RCCFBC CS"); > > + gen6_instdone1_bit(GEN12_SDE_DONE, "SDE"); > > + gen6_instdone1_bit(GEN12_CS_DONE, "CS"); > > + gen6_instdone1_bit(GEN12_RS_DONE, "RS"); > > + gen6_instdone1_bit(GEN12_GAFD_DONE, "GAFD"); > > + gen6_instdone1_bit(GEN12_GAFM_DONE, "GAFM"); > > + gen6_instdone1_bit(GEN12_TSG0_DONE, "TSG0"); > > + gen6_instdone1_bit(GEN12_VFE_DONE, "VFE"); > > + gen6_instdone1_bit(GEN12_GAFS_DONE, "GAFS"); > > + gen6_instdone1_bit(GEN12_SVG_DONE, "SVG"); > > + gen6_instdone1_bit(GEN12_URBM_DONE, "URBM"); > > + gen6_instdone1_bit(GEN12_TDG0_DONE, "TDG0"); > > + gen6_instdone1_bit(GEN12_TDG1_DONE, "TDG1"); > > + gen6_instdone1_bit(GEN12_SF_DONE, "SF"); > > + gen6_instdone1_bit(GEN12_CL_DONE, "CL"); > > + gen6_instdone1_bit(GEN12_SOL_DONE, "SOL"); > > + gen6_instdone1_bit(GEN12_GS_DONE, "GS"); > > + gen6_instdone1_bit(GEN12_DS_DONE, "DS"); > > + gen6_instdone1_bit(GEN12_TE_DONE, "TE"); > > + gen6_instdone1_bit(GEN12_HS_DONE, "HS"); > > + gen6_instdone1_bit(GEN12_VS_DONE, "VS"); > > + gen6_instdone1_bit(GEN12_VFG_DONE, "VFG"); > > + } > > +} > > bool > > init_instdone_definitions(uint32_t devid) > > { > > - if (IS_GEN11(devid)) { > > + if (IS_GEN12(devid)) { > > + init_gen12_instdone(devid); > > + } else if (IS_GEN11(devid)) { > > init_gen11_instdone(); > > } else if (IS_GEN8(devid) || IS_GEN9(devid) || IS_GEN10(devid)) { > > init_gen8_instdone(); > > -- > > 2.25.1 > > > > -- > Matt Roper > Graphics Software Engineer > Linux GPU Platform Enablement > Intel Corporation -- Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-05-25 16:20 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-05-17 8:58 [igt-dev] [PATCH i-g-t] lib/instdone: GEN12 INSTDONE initialization janga.rahul.kumar 2023-05-17 11:30 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2023-05-17 21:48 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2023-05-25 16:18 ` [igt-dev] [PATCH i-g-t] " Matt Roper 2023-05-25 16:19 ` Matt Roper
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox