[igt-dev] [PATCH i-g-t 0/6] Improve description of tests used by i915 validation

Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed

* [igt-dev] [PATCH i-g-t 0/6] Improve description of tests used by i915 validation
@ 2023-05-17 15:11 Mauro Carvalho Chehab
  2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 1/6] tests: better document core_* tests used for " Mauro Carvalho Chehab
                   ` (7 more replies)
  0 siblings, 8 replies; 15+ messages in thread
From: Mauro Carvalho Chehab @ 2023-05-17 15:11 UTC (permalink / raw)
  To: igt-dev

From: Mauro Carvalho Chehab <mchehab@kernel.org>

This patch series was entirely generated by a script which imports data
from an internal spreadsheet containing additional documentation from
IGT tests.

Once we get this added, it should be easy to edit each test file to
improve tests documentation.

Mauro Carvalho Chehab (6):
  tests: better document core_* tests used for i915 validation
  tests: better document the remaining core used by i915 validation
  i915/gem_exec_*: better document gem exec tests used for i915
    validation
  i915/gem_ctx_*: better document i915 context tests
  i915/perf_*: better document tests
  i915/: better document the remaining i915 tests

 tests/core_auth.c                        |   4 +
 tests/core_getclient.c                   |   4 +
 tests/core_getstats.c                    |   4 +
 tests/core_getversion.c                  |   4 +
 tests/core_hotunplug.c                   |   2 +
 tests/core_setmaster.c                   |   4 +
 tests/core_setmaster_vs_auth.c           |   4 +
 tests/debugfs_test.c                     |  15 +-
 tests/device_reset.c                     |   8 +-
 tests/dmabuf.c                           |   2 +-
 tests/dumb_buffer.c                      |   4 +
 tests/i915/api_intel_allocator.c         |  23 ++-
 tests/i915/api_intel_bb.c                |  33 ++++-
 tests/i915/gem_barrier_race.c            |   1 +
 tests/i915/gem_basic.c                   |   7 +
 tests/i915/gem_blits.c                   |   4 +
 tests/i915/gem_busy.c                    |   7 +
 tests/i915/gem_caching.c                 |   4 +
 tests/i915/gem_close.c                   |   4 +
 tests/i915/gem_close_race.c              |   7 +
 tests/i915/gem_create.c                  |  41 +++++-
 tests/i915/gem_cs_tlb.c                  |   4 +
 tests/i915/gem_ctx_bad_destroy.c         |   4 +
 tests/i915/gem_ctx_create.c              |   8 ++
 tests/i915/gem_ctx_engines.c             |   4 +
 tests/i915/gem_ctx_exec.c                |  12 ++
 tests/i915/gem_ctx_freq.c                |   4 +
 tests/i915/gem_ctx_isolation.c           |  26 +++-
 tests/i915/gem_ctx_param.c               |   4 +
 tests/i915/gem_ctx_persistence.c         |   4 +
 tests/i915/gem_ctx_shared.c              |  22 +++
 tests/i915/gem_eio.c                     |  68 ++++++++-
 tests/i915/gem_exec_alignment.c          |   4 +
 tests/i915/gem_exec_async.c              |   4 +
 tests/i915/gem_exec_await.c              |   4 +
 tests/i915/gem_exec_balancer.c           | 100 +++++++++++++
 tests/i915/gem_exec_basic.c              |   6 +-
 tests/i915/gem_exec_big.c                |   4 +
 tests/i915/gem_exec_capture.c            |   4 +
 tests/i915/gem_exec_create.c             |   7 +
 tests/i915/gem_exec_endless.c            |   4 +
 tests/i915/gem_exec_fence.c              | 112 +++++++++++++++
 tests/i915/gem_exec_gttfill.c            |   7 +
 tests/i915/gem_exec_nop.c                |   8 ++
 tests/i915/gem_exec_parallel.c           |   8 ++
 tests/i915/gem_exec_params.c             |  76 ++++++++++
 tests/i915/gem_exec_schedule.c           |   4 +
 tests/i915/gem_exec_store.c              |   4 +
 tests/i915/gem_exec_whisper.c            |   4 +
 tests/i915/gem_exercise_blt.c            |   9 +-
 tests/i915/gem_flink_basic.c             |  14 +-
 tests/i915/gem_flink_race.c              |   4 +
 tests/i915/gem_gpgpu_fill.c              |   4 +
 tests/i915/gem_linear_blits.c            |   6 +
 tests/i915/gem_lmem_evict.c              |   1 +
 tests/i915/gem_lmem_swapping.c           |   4 +
 tests/i915/gem_madvise.c                 |   4 +
 tests/i915/gem_mmap_offset.c             |   4 +
 tests/i915/gem_pipe_control_store_loop.c |   4 +
 tests/i915/gem_ppgtt.c                   |   6 +
 tests/i915/gem_request_retire.c          |   4 +
 tests/i915/gem_ringfill.c                |   8 ++
 tests/i915/gem_shrink.c                  |   4 +
 tests/i915/gem_softpin.c                 |  69 ++++++++-
 tests/i915/gem_spin_batch.c              |  37 +++++
 tests/i915/gem_sync.c                    |  14 ++
 tests/i915/gem_unref_active_buffers.c    |   4 +
 tests/i915/gem_userptr_blits.c           |  76 ++++++++++
 tests/i915/gem_vm_create.c               |   4 +
 tests/i915/gem_wait.c                    |   4 +
 tests/i915/gem_workarounds.c             |  32 ++++-
 tests/i915/i915_getparams_basic.c        |   4 +
 tests/i915/i915_hangman.c                |  40 ++++--
 tests/i915/i915_hwmon.c                  |   1 +
 tests/i915/i915_module_load.c            |   4 +
 tests/i915/i915_pciid.c                  |   4 +
 tests/i915/i915_pm_rpm.c                 |   6 +-
 tests/i915/i915_pm_rps.c                 |  12 +-
 tests/i915/i915_power.c                  |   1 +
 tests/i915/i915_query.c                  |   4 +
 tests/i915/i915_suspend.c                |  26 +++-
 tests/i915/perf.c                        | 126 +++++++++++++----
 tests/i915/perf_pmu.c                    | 171 ++++++++++++++++++-----
 tests/i915/sysfs_defaults.c              |   4 +
 tests/i915/sysfs_heartbeat_interval.c    |   6 +
 tests/i915/sysfs_preempt_timeout.c       |   4 +
 tests/i915/sysfs_timeslice_duration.c    |   5 +
 tests/prime_busy.c                       |   4 +
 tests/prime_mmap.c                       |   4 +
 tests/prime_mmap_coherency.c             |   4 +
 tests/prime_self_import.c                |   4 +
 tests/prime_vgem.c                       |   9 +-
 tests/sw_sync.c                          |   4 +
 tests/syncobj_basic.c                    |   4 +
 tests/syncobj_timeline.c                 |   4 +
 tests/syncobj_wait.c                     |   4 +
 tests/vgem_basic.c                       |  14 ++
 tests/vgem_slow.c                        |   4 +
 98 files changed, 1398 insertions(+), 101 deletions(-)

-- 
2.40.1

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [igt-dev] [PATCH i-g-t 1/6] tests: better document core_* tests used for i915 validation
  2023-05-17 15:11 [igt-dev] [PATCH i-g-t 0/6] Improve description of tests used by i915 validation Mauro Carvalho Chehab
@ 2023-05-17 15:11 ` Mauro Carvalho Chehab
  2023-05-19 15:37   ` Kamil Konieczny
  2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 2/6] tests: better document the remaining core used by " Mauro Carvalho Chehab
                   ` (6 subsequent siblings)
  7 siblings, 1 reply; 15+ messages in thread
From: Mauro Carvalho Chehab @ 2023-05-17 15:11 UTC (permalink / raw)
  To: igt-dev

From: Mauro Carvalho Chehab <mchehab@kernel.org>

Merge data from some ancillary internal documentation to improve
core test descriptions.

This patch was auto-generated via script.

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 tests/core_auth.c              | 4 ++++
 tests/core_getclient.c         | 4 ++++
 tests/core_getstats.c          | 4 ++++
 tests/core_getversion.c        | 4 ++++
 tests/core_hotunplug.c         | 2 ++
 tests/core_setmaster.c         | 4 ++++
 tests/core_setmaster_vs_auth.c | 4 ++++
 7 files changed, 26 insertions(+)

diff --git a/tests/core_auth.c b/tests/core_auth.c
index ee7fbaabfa92..ed736e1ae39f 100644
--- a/tests/core_auth.c
+++ b/tests/core_auth.c
@@ -44,8 +44,12 @@
 #include "drm.h"
 /**
  * TEST: core auth
+ * Category: Desktop client
  * Description: Call drmGetMagic() and drmAuthMagic() and see if it behaves.
  * Feature: core
+ * Functionality: permission management for clients
+ * Sub-category: DRM
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic-auth
  * Description: Test magic numbers for master and slave.
diff --git a/tests/core_getclient.c b/tests/core_getclient.c
index 1ab56e9f304c..993801ead5a0 100644
--- a/tests/core_getclient.c
+++ b/tests/core_getclient.c
@@ -33,9 +33,13 @@
 
 /**
  * TEST: core getclient
+ * Category: Desktop client
  * Description: Tests the DRM_IOCTL_GET_CLIENT ioctl.
  * Feature: core
+ * Functionality: permission management for clients
  * Run type: FULL
+ * Sub-category: DRM
+ * Test category: GEM_Legacy
  *
  * SUBTEST:
  */
diff --git a/tests/core_getstats.c b/tests/core_getstats.c
index f2b1abac738e..fef12258356e 100644
--- a/tests/core_getstats.c
+++ b/tests/core_getstats.c
@@ -34,9 +34,13 @@
 
 /**
  * TEST: core getstats
+ * Category: Desktop client
  * Description: Tests the DRM_IOCTL_GET_STATS ioctl.
  * Feature: core
+ * Functionality: permission management for clients
  * Run type: FULL
+ * Sub-category: DRM
+ * Test category: GEM_Legacy
  *
  * SUBTEST:
  */
diff --git a/tests/core_getversion.c b/tests/core_getversion.c
index ae6fc8f8d7d9..36ba01b865c5 100644
--- a/tests/core_getversion.c
+++ b/tests/core_getversion.c
@@ -30,9 +30,13 @@
 #include <sys/ioctl.h>
 /**
  * TEST: core getversion
+ * Category: Desktop client
  * Description: Tests the DRM_IOCTL_GET_VERSION ioctl and libdrm's drmGetVersion() interface to it.
  * Feature: core
+ * Functionality: permission management for clients
  * Run type: FULL
+ * Sub-category: DRM
+ * Test category: GEM_Legacy
  *
  * SUBTEST:
  */
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index 472e9237ddc2..9a027bfdf5a8 100644
--- a/tests/core_hotunplug.c
+++ b/tests/core_hotunplug.c
@@ -43,6 +43,8 @@
  * TEST: core hotunplug
  * Description: Examine behavior of a driver on device hot unplug
  * Feature: SMI, core
+ * Functionality: device hotplug
+ * Test category: SysMan
  *
  * SUBTEST: hotrebind
  * Description:
diff --git a/tests/core_setmaster.c b/tests/core_setmaster.c
index 95a131a4d3c9..621bc24696a8 100644
--- a/tests/core_setmaster.c
+++ b/tests/core_setmaster.c
@@ -40,9 +40,13 @@
 #include <sys/stat.h>
 /**
  * TEST: core setmaster
+ * Category: Desktop client
  * Description: Check that Drop/SetMaster behaves correctly wrt root/user access
  * Feature: core
+ * Functionality: permission management for clients
  * Run type: FULL
+ * Sub-category: DRM
+ * Test category: GEM_Legacy
  *
  * SUBTEST: master-drop-set-root
  * Description: Ensure that root can Set/DropMaster
diff --git a/tests/core_setmaster_vs_auth.c b/tests/core_setmaster_vs_auth.c
index 37bb378ab011..adca1c1117d3 100644
--- a/tests/core_setmaster_vs_auth.c
+++ b/tests/core_setmaster_vs_auth.c
@@ -42,9 +42,13 @@
 #include "igt_device.h"
 /**
  * TEST: core setmaster vs auth
+ * Category: Desktop client
  * Description: Check that drop/setMaster correctly transfer master state
  * Feature: core
+ * Functionality: permission management for clients
  * Run type: FULL
+ * Sub-category: DRM
+ * Test category: GEM_Legacy
  *
  * SUBTEST:
  */
-- 
2.40.1

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 1/6] tests: better document core_* tests used for i915 validation
  2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 1/6] tests: better document core_* tests used for " Mauro Carvalho Chehab
@ 2023-05-19 15:37   ` Kamil Konieczny
  0 siblings, 0 replies; 15+ messages in thread
From: Kamil Konieczny @ 2023-05-19 15:37 UTC (permalink / raw)
  To: igt-dev

Hi Mauro,

thank you for splitting this into smaller pieces.

On 2023-05-17 at 17:11:05 +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
> 
> Merge data from some ancillary internal documentation to improve
> core test descriptions.
> 
> This patch was auto-generated via script.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

--
Kamil

> ---
>  tests/core_auth.c              | 4 ++++
>  tests/core_getclient.c         | 4 ++++
>  tests/core_getstats.c          | 4 ++++
>  tests/core_getversion.c        | 4 ++++
>  tests/core_hotunplug.c         | 2 ++
>  tests/core_setmaster.c         | 4 ++++
>  tests/core_setmaster_vs_auth.c | 4 ++++
>  7 files changed, 26 insertions(+)
> 
> diff --git a/tests/core_auth.c b/tests/core_auth.c
> index ee7fbaabfa92..ed736e1ae39f 100644
> --- a/tests/core_auth.c
> +++ b/tests/core_auth.c
> @@ -44,8 +44,12 @@
>  #include "drm.h"
>  /**
>   * TEST: core auth
> + * Category: Desktop client
>   * Description: Call drmGetMagic() and drmAuthMagic() and see if it behaves.
>   * Feature: core
> + * Functionality: permission management for clients
> + * Sub-category: DRM
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic-auth
>   * Description: Test magic numbers for master and slave.
> diff --git a/tests/core_getclient.c b/tests/core_getclient.c
> index 1ab56e9f304c..993801ead5a0 100644
> --- a/tests/core_getclient.c
> +++ b/tests/core_getclient.c
> @@ -33,9 +33,13 @@
>  
>  /**
>   * TEST: core getclient
> + * Category: Desktop client
>   * Description: Tests the DRM_IOCTL_GET_CLIENT ioctl.
>   * Feature: core
> + * Functionality: permission management for clients
>   * Run type: FULL
> + * Sub-category: DRM
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST:
>   */
> diff --git a/tests/core_getstats.c b/tests/core_getstats.c
> index f2b1abac738e..fef12258356e 100644
> --- a/tests/core_getstats.c
> +++ b/tests/core_getstats.c
> @@ -34,9 +34,13 @@
>  
>  /**
>   * TEST: core getstats
> + * Category: Desktop client
>   * Description: Tests the DRM_IOCTL_GET_STATS ioctl.
>   * Feature: core
> + * Functionality: permission management for clients
>   * Run type: FULL
> + * Sub-category: DRM
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST:
>   */
> diff --git a/tests/core_getversion.c b/tests/core_getversion.c
> index ae6fc8f8d7d9..36ba01b865c5 100644
> --- a/tests/core_getversion.c
> +++ b/tests/core_getversion.c
> @@ -30,9 +30,13 @@
>  #include <sys/ioctl.h>
>  /**
>   * TEST: core getversion
> + * Category: Desktop client
>   * Description: Tests the DRM_IOCTL_GET_VERSION ioctl and libdrm's drmGetVersion() interface to it.
>   * Feature: core
> + * Functionality: permission management for clients
>   * Run type: FULL
> + * Sub-category: DRM
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST:
>   */
> diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
> index 472e9237ddc2..9a027bfdf5a8 100644
> --- a/tests/core_hotunplug.c
> +++ b/tests/core_hotunplug.c
> @@ -43,6 +43,8 @@
>   * TEST: core hotunplug
>   * Description: Examine behavior of a driver on device hot unplug
>   * Feature: SMI, core
> + * Functionality: device hotplug
> + * Test category: SysMan
>   *
>   * SUBTEST: hotrebind
>   * Description:
> diff --git a/tests/core_setmaster.c b/tests/core_setmaster.c
> index 95a131a4d3c9..621bc24696a8 100644
> --- a/tests/core_setmaster.c
> +++ b/tests/core_setmaster.c
> @@ -40,9 +40,13 @@
>  #include <sys/stat.h>
>  /**
>   * TEST: core setmaster
> + * Category: Desktop client
>   * Description: Check that Drop/SetMaster behaves correctly wrt root/user access
>   * Feature: core
> + * Functionality: permission management for clients
>   * Run type: FULL
> + * Sub-category: DRM
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: master-drop-set-root
>   * Description: Ensure that root can Set/DropMaster
> diff --git a/tests/core_setmaster_vs_auth.c b/tests/core_setmaster_vs_auth.c
> index 37bb378ab011..adca1c1117d3 100644
> --- a/tests/core_setmaster_vs_auth.c
> +++ b/tests/core_setmaster_vs_auth.c
> @@ -42,9 +42,13 @@
>  #include "igt_device.h"
>  /**
>   * TEST: core setmaster vs auth
> + * Category: Desktop client
>   * Description: Check that drop/setMaster correctly transfer master state
>   * Feature: core
> + * Functionality: permission management for clients
>   * Run type: FULL
> + * Sub-category: DRM
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST:
>   */
> -- 
> 2.40.1
> 


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [igt-dev] [PATCH i-g-t 2/6] tests: better document the remaining core used by i915 validation
  2023-05-17 15:11 [igt-dev] [PATCH i-g-t 0/6] Improve description of tests used by i915 validation Mauro Carvalho Chehab
  2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 1/6] tests: better document core_* tests used for " Mauro Carvalho Chehab
@ 2023-05-17 15:11 ` Mauro Carvalho Chehab
  2023-05-19 15:43   ` Kamil Konieczny
  2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 3/6] i915/gem_exec_*: better document gem exec tests used for " Mauro Carvalho Chehab
                   ` (5 subsequent siblings)
  7 siblings, 1 reply; 15+ messages in thread
From: Mauro Carvalho Chehab @ 2023-05-17 15:11 UTC (permalink / raw)
  To: igt-dev

From: Mauro Carvalho Chehab <mchehab@kernel.org>

Merge data from some ancillary internal documentation to improve
test descriptions for the remaining core tests used during i915
validation.

This patch was auto-generated via script.

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 tests/debugfs_test.c         | 15 +++++++++++++--
 tests/device_reset.c         |  8 +++++++-
 tests/dmabuf.c               |  2 +-
 tests/dumb_buffer.c          |  4 ++++
 tests/prime_busy.c           |  4 ++++
 tests/prime_mmap.c           |  4 ++++
 tests/prime_mmap_coherency.c |  4 ++++
 tests/prime_self_import.c    |  4 ++++
 tests/prime_vgem.c           |  9 ++++-----
 tests/sw_sync.c              |  4 ++++
 tests/syncobj_basic.c        |  4 ++++
 tests/syncobj_timeline.c     |  4 ++++
 tests/syncobj_wait.c         |  4 ++++
 tests/vgem_basic.c           | 14 ++++++++++++++
 tests/vgem_slow.c            |  4 ++++
 15 files changed, 79 insertions(+), 9 deletions(-)

diff --git a/tests/debugfs_test.c b/tests/debugfs_test.c
index 39b001671bcc..d6439e139790 100644
--- a/tests/debugfs_test.c
+++ b/tests/debugfs_test.c
@@ -33,14 +33,20 @@
  * TEST: debugfs test
  * Description: Read entries from debugfs, hwmon and sysfs paths.
  * Feature: core
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic-hwmon
  * Description: Read all entries from hwmon path
  * Run type: BAT
  *
  * SUBTEST: read_all_entries
- * Description: Read all entries from debugfs path.
+ * Category: Infrastructure
+ * Description:
+ *   Read all entries from debugfs path.
+ *   validating debugfs entries
+ * Functionality: debugfs entries
  * Run type: BAT
+ * Sub-category: i915
  *
  * SUBTEST: read_all_entries_display_off
  * Description: Read all debugfs entries with display on/off.
@@ -51,8 +57,13 @@
  * Run type: FULL
  *
  * SUBTEST: sysfs
- * Description: Read all entries from sysfs path.
+ * Category: Infrastructure
+ * Description:
+ *   Read all entries from sysfs path.
+ *   validating debugfs entries
+ * Functionality: debugfs entries
  * Run type: FULL
+ * Sub-category: i915
  */
 
 IGT_TEST_DESCRIPTION("Read entries from debugfs, hwmon and sysfs paths.");
diff --git a/tests/device_reset.c b/tests/device_reset.c
index 0c23aecff595..9ebd479dfefa 100644
--- a/tests/device_reset.c
+++ b/tests/device_reset.c
@@ -32,8 +32,14 @@
  * Feature: reset
  *
  * SUBTEST: unbind-reset-rebind
- * Description: Unbinds driver from device, initiates reset then rebinds driver to device
+ * Category: Server
+ * Description:
+ *   Unbinds driver from device, initiates reset then rebinds driver to device
+ *   validating device resets
  * Feature: reset, sriov-reset
+ * Functionality: reset
+ * Sub-category: sysman
+ * Test category: GEM_Legacy
  */
 
 IGT_TEST_DESCRIPTION("Examine behavior of a driver on device sysfs reset");
diff --git a/tests/dmabuf.c b/tests/dmabuf.c
index 4bc9b35b619d..acd3080cf3d3 100644
--- a/tests/dmabuf.c
+++ b/tests/dmabuf.c
@@ -27,9 +27,9 @@
  * TEST: dmabuf
  * Description: Kernel selftests for the dmabuf API
  * Feature: mapping, prime
- * Run type: BAT
  *
  * SUBTEST: all-tests
+ * Run type: BAT
  */
 
 IGT_TEST_DESCRIPTION("Kernel selftests for the dmabuf API");
diff --git a/tests/dumb_buffer.c b/tests/dumb_buffer.c
index 0c7ce714eb6c..9495d28ff724 100644
--- a/tests/dumb_buffer.c
+++ b/tests/dumb_buffer.c
@@ -51,9 +51,13 @@
 #include "ioctl_wrappers.h"
 /**
  * TEST: dumb buffer
+ * Category: Desktop client
  * Description: This is a test for the generic dumb buffer interface.
  * Feature: prime
+ * Functionality: IOCTL check for buffer management
  * Run type: FULL
+ * Sub-category: Compositor
+ * Test category: GEM_Legacy
  *
  * SUBTEST: create-clear
  *
diff --git a/tests/prime_busy.c b/tests/prime_busy.c
index 4f7dba7d0e3c..6b0d7310b806 100644
--- a/tests/prime_busy.c
+++ b/tests/prime_busy.c
@@ -28,9 +28,13 @@
 #include "igt.h"
 /**
  * TEST: prime busy
+ * Category: Infrastructure
  * Description: Basic check of polling for prime fences.
  * Feature: prime
+ * Functionality: buffer management
  * Run type: FULL
+ * Sub-category: DRM
+ * Test category: GEM_Legacy
  *
  * SUBTEST: after
  *
diff --git a/tests/prime_mmap.c b/tests/prime_mmap.c
index 8ffe37fe199f..efd4deff921e 100644
--- a/tests/prime_mmap.c
+++ b/tests/prime_mmap.c
@@ -52,8 +52,12 @@
 #include "i915/intel_memory_region.h"
 /**
  * TEST: prime mmap
+ * Category: Infrastructure
  * Feature: prime
+ * Functionality: memory management
  * Run type: FULL
+ * Sub-category: DRM
+ * Test category: GEM_Legacy
  *
  * SUBTEST: test_aperture_limit
  *
diff --git a/tests/prime_mmap_coherency.c b/tests/prime_mmap_coherency.c
index e50f52fdfdb0..e5f7c92b2324 100644
--- a/tests/prime_mmap_coherency.c
+++ b/tests/prime_mmap_coherency.c
@@ -33,11 +33,15 @@
 #include "igt.h"
 /**
  * TEST: prime mmap coherency
+ * Category: Infrastructure
  * Description:
  *   Test dma-buf mmap on !llc platforms mostly and provoke coherency bugs so we know for sure where
  *   we need the sync ioctls.
  * Feature: prime
+ * Functionality: memory management
  * Run type: FULL
+ * Sub-category: DRM
+ * Test category: GEM_Legacy
  *
  * SUBTEST: ioctl-errors
  *
diff --git a/tests/prime_self_import.c b/tests/prime_self_import.c
index 7d423b8cd442..30f2bf013cb5 100644
--- a/tests/prime_self_import.c
+++ b/tests/prime_self_import.c
@@ -47,8 +47,12 @@
 #include "i915/gem_create.h"
 /**
  * TEST: prime self import
+ * Category: Infrastructure
  * Description: Check whether prime import/export works on the same device... but with different fds.
  * Feature: prime
+ * Functionality: buffer management
+ * Sub-category: DRM
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic-llseek-bad
  * Description: Check dmabuf llseek support with invalid values.
diff --git a/tests/prime_vgem.c b/tests/prime_vgem.c
index 27b3744014bb..827d9b1d496c 100644
--- a/tests/prime_vgem.c
+++ b/tests/prime_vgem.c
@@ -32,7 +32,11 @@
 #include "intel_batchbuffer.h"	/* igt_blitter_src_copy() */
 /**
  * TEST: prime vgem
+ * Category: Infrastructure
  * Description: Basic check of polling for prime/vgem fences.
+ * Functionality: mock device
+ * Sub-category: DRM
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic-blt
  * Description: Examine blitter access path.
@@ -69,11 +73,6 @@
  * Feature: gtt, prime
  * Run type: BAT
  *
- * SUBTEST: basic-userptr
- * Description: Check that we wrap the vgem mmap with userptr.
- * Feature: prime
- * Run type: BAT
- *
  * SUBTEST: basic-write
  * Description: Examine write access path.
  * Feature: gtt, prime
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index e626cd14cd28..6c476ff46776 100644
--- a/tests/sw_sync.c
+++ b/tests/sw_sync.c
@@ -40,9 +40,13 @@
 
 /**
  * TEST: sw sync
+ * Category: Infrastructure
  * Description: Test SW Sync Framework
  * Feature: synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: DRM
+ * Test category: GEM_Legacy
  *
  * SUBTEST: alloc_fence
  *
diff --git a/tests/syncobj_basic.c b/tests/syncobj_basic.c
index 8d98137e7bd6..3252dbd693fb 100644
--- a/tests/syncobj_basic.c
+++ b/tests/syncobj_basic.c
@@ -28,9 +28,13 @@
 #include "drm.h"
 /**
  * TEST: syncobj basic
+ * Category: Infrastructure
  * Description: Basic check for drm sync objects.
  * Feature: synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: DRM
+ * Test category: GEM_Legacy
  *
  * SUBTEST: bad-create-flags
  *
diff --git a/tests/syncobj_timeline.c b/tests/syncobj_timeline.c
index 1158a99fe58f..134a6099512e 100644
--- a/tests/syncobj_timeline.c
+++ b/tests/syncobj_timeline.c
@@ -32,9 +32,13 @@
 #include "drm.h"
 /**
  * TEST: syncobj timeline
+ * Category: Infrastructure
  * Description: Tests for the drm timeline sync object API
  * Feature: synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: DRM
+ * Test category: GEM_Legacy
  *
  * SUBTEST: 32bits-limit
  * Description:
diff --git a/tests/syncobj_wait.c b/tests/syncobj_wait.c
index 930096f6d10e..2583ef72eb1d 100644
--- a/tests/syncobj_wait.c
+++ b/tests/syncobj_wait.c
@@ -32,9 +32,13 @@
 #include "drm.h"
 /**
  * TEST: syncobj wait
+ * Category: Infrastructure
  * Description: Tests for the drm sync object wait API
  * Feature: synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: DRM
+ * Test category: GEM_Legacy
  *
  * SUBTEST: invalid-multi-wait-all-unsubmitted
  *
diff --git a/tests/vgem_basic.c b/tests/vgem_basic.c
index 2a5f6242e995..f2255a61902d 100644
--- a/tests/vgem_basic.c
+++ b/tests/vgem_basic.c
@@ -33,7 +33,10 @@
 #include <dirent.h>
 /**
  * TEST: vgem basic
+ * Category: Infrastructure
  * Description: Basic sanity check of Virtual GEM module (vGEM).
+ * Functionality: mock device
+ * Test category: GEM_Legacy
  *
  * SUBTEST: bad-fence
  * Description: Make sure a non-existent fence cannot be signaled.
@@ -64,56 +67,67 @@
  * Description: Check the basic working of vgem_create ioctl.
  * Feature: vgem
  * Run type: BAT
+ * Sub-category: DRM
  *
  * SUBTEST: debugfs
  * Description: Check the basic access to debugfs and also try to read entries in the directory.
  * Feature: vgem
  * Run type: BAT
+ * Sub-category: DRM
  *
  * SUBTEST: dmabuf-export
  * Description: Check whether it can export/import the vgem handle using prime.
  * Feature: prime, vgem
  * Run type: BAT
+ * Sub-category: DRM
  *
  * SUBTEST: dmabuf-fence
  * Description: Check the working of dma-buf fence interop.
  * Feature: prime, vgem
  * Run type: BAT
+ * Sub-category: DRM
  *
  * SUBTEST: dmabuf-fence-before
  * Description: Attach a fence before exporting a vgem handle and check the working of fence.
  * Feature: prime, vgem
  * Run type: BAT
+ * Sub-category: DRM
  *
  * SUBTEST: dmabuf-mmap
  * Description: Export the vgem handle along with RDWR capabilities using prime and check if it can be mmaped.
  * Feature: prime, vgem
  * Run type: BAT
+ * Sub-category: DRM
  *
  * SUBTEST: mmap
  * Description: Create a vgem handle and check if it can be mmaped.
  * Feature: vgem
  * Run type: BAT
+ * Sub-category: DRM
  *
  * SUBTEST: second-client
  * Description: Check whether it can open multiple clients.
  * Feature: vgem
  * Run type: BAT
+ * Sub-category: DRM
  *
  * SUBTEST: setversion
  * Description: Check the working of SET_VERSION ioctl.
  * Feature: vgem
  * Run type: BAT
+ * Sub-category: DRM
  *
  * SUBTEST: sysfs
  * Description: Check the basic access to sysfs and also try to read entries in the directory.
  * Feature: vgem
  * Run type: BAT
+ * Sub-category: DRM
  *
  * SUBTEST: unload
  * Description: Basic test for handling of module unload.
  * Feature: vgem
  * Run type: BAT
+ * Sub-category: DRM
  */
 
 IGT_TEST_DESCRIPTION("Basic sanity check of Virtual GEM module (vGEM).");
diff --git a/tests/vgem_slow.c b/tests/vgem_slow.c
index d2a7effff115..0c91cdb9dece 100644
--- a/tests/vgem_slow.c
+++ b/tests/vgem_slow.c
@@ -32,9 +32,13 @@
 #include <dirent.h>
 /**
  * TEST: vgem slow
+ * Category: Infrastructure
  * Description: Extended sanity check of Virtual GEM module (vGEM).
  * Feature: vgem
+ * Functionality: mock device
  * Run type: FULL
+ * Sub-category: DRM
+ * Test category: GEM_Legacy
  *
  * SUBTEST: nohang
  */
-- 
2.40.1

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 2/6] tests: better document the remaining core used by i915 validation
  2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 2/6] tests: better document the remaining core used by " Mauro Carvalho Chehab
@ 2023-05-19 15:43   ` Kamil Konieczny
  0 siblings, 0 replies; 15+ messages in thread
From: Kamil Konieczny @ 2023-05-19 15:43 UTC (permalink / raw)
  To: igt-dev

On 2023-05-17 at 17:11:06 +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
> 
> Merge data from some ancillary internal documentation to improve
> test descriptions for the remaining core tests used during i915
> validation.
> 
> This patch was auto-generated via script.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

> ---
>  tests/debugfs_test.c         | 15 +++++++++++++--
>  tests/device_reset.c         |  8 +++++++-
>  tests/dmabuf.c               |  2 +-
>  tests/dumb_buffer.c          |  4 ++++
>  tests/prime_busy.c           |  4 ++++
>  tests/prime_mmap.c           |  4 ++++
>  tests/prime_mmap_coherency.c |  4 ++++
>  tests/prime_self_import.c    |  4 ++++
>  tests/prime_vgem.c           |  9 ++++-----
>  tests/sw_sync.c              |  4 ++++
>  tests/syncobj_basic.c        |  4 ++++
>  tests/syncobj_timeline.c     |  4 ++++
>  tests/syncobj_wait.c         |  4 ++++
>  tests/vgem_basic.c           | 14 ++++++++++++++
>  tests/vgem_slow.c            |  4 ++++
>  15 files changed, 79 insertions(+), 9 deletions(-)
> 
> diff --git a/tests/debugfs_test.c b/tests/debugfs_test.c
> index 39b001671bcc..d6439e139790 100644
> --- a/tests/debugfs_test.c
> +++ b/tests/debugfs_test.c
> @@ -33,14 +33,20 @@
>   * TEST: debugfs test
>   * Description: Read entries from debugfs, hwmon and sysfs paths.
>   * Feature: core
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic-hwmon
>   * Description: Read all entries from hwmon path
>   * Run type: BAT
>   *
>   * SUBTEST: read_all_entries
> - * Description: Read all entries from debugfs path.
> + * Category: Infrastructure
> + * Description:
> + *   Read all entries from debugfs path.
> + *   validating debugfs entries
> + * Functionality: debugfs entries
>   * Run type: BAT
> + * Sub-category: i915
>   *
>   * SUBTEST: read_all_entries_display_off
>   * Description: Read all debugfs entries with display on/off.
> @@ -51,8 +57,13 @@
>   * Run type: FULL
>   *
>   * SUBTEST: sysfs
> - * Description: Read all entries from sysfs path.
> + * Category: Infrastructure
> + * Description:
> + *   Read all entries from sysfs path.
> + *   validating debugfs entries
> + * Functionality: debugfs entries
>   * Run type: FULL
> + * Sub-category: i915
>   */
>  
>  IGT_TEST_DESCRIPTION("Read entries from debugfs, hwmon and sysfs paths.");
> diff --git a/tests/device_reset.c b/tests/device_reset.c
> index 0c23aecff595..9ebd479dfefa 100644
> --- a/tests/device_reset.c
> +++ b/tests/device_reset.c
> @@ -32,8 +32,14 @@
>   * Feature: reset
>   *
>   * SUBTEST: unbind-reset-rebind
> - * Description: Unbinds driver from device, initiates reset then rebinds driver to device
> + * Category: Server
> + * Description:
> + *   Unbinds driver from device, initiates reset then rebinds driver to device
> + *   validating device resets
>   * Feature: reset, sriov-reset
> + * Functionality: reset
> + * Sub-category: sysman
> + * Test category: GEM_Legacy
>   */
>  
>  IGT_TEST_DESCRIPTION("Examine behavior of a driver on device sysfs reset");
> diff --git a/tests/dmabuf.c b/tests/dmabuf.c
> index 4bc9b35b619d..acd3080cf3d3 100644
> --- a/tests/dmabuf.c
> +++ b/tests/dmabuf.c
> @@ -27,9 +27,9 @@
>   * TEST: dmabuf
>   * Description: Kernel selftests for the dmabuf API
>   * Feature: mapping, prime
> - * Run type: BAT
>   *
>   * SUBTEST: all-tests
> + * Run type: BAT
>   */
>  
>  IGT_TEST_DESCRIPTION("Kernel selftests for the dmabuf API");
> diff --git a/tests/dumb_buffer.c b/tests/dumb_buffer.c
> index 0c7ce714eb6c..9495d28ff724 100644
> --- a/tests/dumb_buffer.c
> +++ b/tests/dumb_buffer.c
> @@ -51,9 +51,13 @@
>  #include "ioctl_wrappers.h"
>  /**
>   * TEST: dumb buffer
> + * Category: Desktop client
>   * Description: This is a test for the generic dumb buffer interface.
>   * Feature: prime
> + * Functionality: IOCTL check for buffer management
>   * Run type: FULL
> + * Sub-category: Compositor
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: create-clear
>   *
> diff --git a/tests/prime_busy.c b/tests/prime_busy.c
> index 4f7dba7d0e3c..6b0d7310b806 100644
> --- a/tests/prime_busy.c
> +++ b/tests/prime_busy.c
> @@ -28,9 +28,13 @@
>  #include "igt.h"
>  /**
>   * TEST: prime busy
> + * Category: Infrastructure
>   * Description: Basic check of polling for prime fences.
>   * Feature: prime
> + * Functionality: buffer management
>   * Run type: FULL
> + * Sub-category: DRM
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: after
>   *
> diff --git a/tests/prime_mmap.c b/tests/prime_mmap.c
> index 8ffe37fe199f..efd4deff921e 100644
> --- a/tests/prime_mmap.c
> +++ b/tests/prime_mmap.c
> @@ -52,8 +52,12 @@
>  #include "i915/intel_memory_region.h"
>  /**
>   * TEST: prime mmap
> + * Category: Infrastructure
>   * Feature: prime
> + * Functionality: memory management
>   * Run type: FULL
> + * Sub-category: DRM
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: test_aperture_limit
>   *
> diff --git a/tests/prime_mmap_coherency.c b/tests/prime_mmap_coherency.c
> index e50f52fdfdb0..e5f7c92b2324 100644
> --- a/tests/prime_mmap_coherency.c
> +++ b/tests/prime_mmap_coherency.c
> @@ -33,11 +33,15 @@
>  #include "igt.h"
>  /**
>   * TEST: prime mmap coherency
> + * Category: Infrastructure
>   * Description:
>   *   Test dma-buf mmap on !llc platforms mostly and provoke coherency bugs so we know for sure where
>   *   we need the sync ioctls.
>   * Feature: prime
> + * Functionality: memory management
>   * Run type: FULL
> + * Sub-category: DRM
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: ioctl-errors
>   *
> diff --git a/tests/prime_self_import.c b/tests/prime_self_import.c
> index 7d423b8cd442..30f2bf013cb5 100644
> --- a/tests/prime_self_import.c
> +++ b/tests/prime_self_import.c
> @@ -47,8 +47,12 @@
>  #include "i915/gem_create.h"
>  /**
>   * TEST: prime self import
> + * Category: Infrastructure
>   * Description: Check whether prime import/export works on the same device... but with different fds.
>   * Feature: prime
> + * Functionality: buffer management
> + * Sub-category: DRM
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic-llseek-bad
>   * Description: Check dmabuf llseek support with invalid values.
> diff --git a/tests/prime_vgem.c b/tests/prime_vgem.c
> index 27b3744014bb..827d9b1d496c 100644
> --- a/tests/prime_vgem.c
> +++ b/tests/prime_vgem.c
> @@ -32,7 +32,11 @@
>  #include "intel_batchbuffer.h"	/* igt_blitter_src_copy() */
>  /**
>   * TEST: prime vgem
> + * Category: Infrastructure
>   * Description: Basic check of polling for prime/vgem fences.
> + * Functionality: mock device
> + * Sub-category: DRM
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic-blt
>   * Description: Examine blitter access path.
> @@ -69,11 +73,6 @@
>   * Feature: gtt, prime
>   * Run type: BAT
>   *
> - * SUBTEST: basic-userptr
> - * Description: Check that we wrap the vgem mmap with userptr.
> - * Feature: prime
> - * Run type: BAT
> - *
>   * SUBTEST: basic-write
>   * Description: Examine write access path.
>   * Feature: gtt, prime
> diff --git a/tests/sw_sync.c b/tests/sw_sync.c
> index e626cd14cd28..6c476ff46776 100644
> --- a/tests/sw_sync.c
> +++ b/tests/sw_sync.c
> @@ -40,9 +40,13 @@
>  
>  /**
>   * TEST: sw sync
> + * Category: Infrastructure
>   * Description: Test SW Sync Framework
>   * Feature: synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: DRM
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: alloc_fence
>   *
> diff --git a/tests/syncobj_basic.c b/tests/syncobj_basic.c
> index 8d98137e7bd6..3252dbd693fb 100644
> --- a/tests/syncobj_basic.c
> +++ b/tests/syncobj_basic.c
> @@ -28,9 +28,13 @@
>  #include "drm.h"
>  /**
>   * TEST: syncobj basic
> + * Category: Infrastructure
>   * Description: Basic check for drm sync objects.
>   * Feature: synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: DRM
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: bad-create-flags
>   *
> diff --git a/tests/syncobj_timeline.c b/tests/syncobj_timeline.c
> index 1158a99fe58f..134a6099512e 100644
> --- a/tests/syncobj_timeline.c
> +++ b/tests/syncobj_timeline.c
> @@ -32,9 +32,13 @@
>  #include "drm.h"
>  /**
>   * TEST: syncobj timeline
> + * Category: Infrastructure
>   * Description: Tests for the drm timeline sync object API
>   * Feature: synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: DRM
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: 32bits-limit
>   * Description:
> diff --git a/tests/syncobj_wait.c b/tests/syncobj_wait.c
> index 930096f6d10e..2583ef72eb1d 100644
> --- a/tests/syncobj_wait.c
> +++ b/tests/syncobj_wait.c
> @@ -32,9 +32,13 @@
>  #include "drm.h"
>  /**
>   * TEST: syncobj wait
> + * Category: Infrastructure
>   * Description: Tests for the drm sync object wait API
>   * Feature: synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: DRM
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: invalid-multi-wait-all-unsubmitted
>   *
> diff --git a/tests/vgem_basic.c b/tests/vgem_basic.c
> index 2a5f6242e995..f2255a61902d 100644
> --- a/tests/vgem_basic.c
> +++ b/tests/vgem_basic.c
> @@ -33,7 +33,10 @@
>  #include <dirent.h>
>  /**
>   * TEST: vgem basic
> + * Category: Infrastructure
>   * Description: Basic sanity check of Virtual GEM module (vGEM).
> + * Functionality: mock device
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: bad-fence
>   * Description: Make sure a non-existent fence cannot be signaled.
> @@ -64,56 +67,67 @@
>   * Description: Check the basic working of vgem_create ioctl.
>   * Feature: vgem
>   * Run type: BAT
> + * Sub-category: DRM
>   *
>   * SUBTEST: debugfs
>   * Description: Check the basic access to debugfs and also try to read entries in the directory.
>   * Feature: vgem
>   * Run type: BAT
> + * Sub-category: DRM
>   *
>   * SUBTEST: dmabuf-export
>   * Description: Check whether it can export/import the vgem handle using prime.
>   * Feature: prime, vgem
>   * Run type: BAT
> + * Sub-category: DRM
>   *
>   * SUBTEST: dmabuf-fence
>   * Description: Check the working of dma-buf fence interop.
>   * Feature: prime, vgem
>   * Run type: BAT
> + * Sub-category: DRM
>   *
>   * SUBTEST: dmabuf-fence-before
>   * Description: Attach a fence before exporting a vgem handle and check the working of fence.
>   * Feature: prime, vgem
>   * Run type: BAT
> + * Sub-category: DRM
>   *
>   * SUBTEST: dmabuf-mmap
>   * Description: Export the vgem handle along with RDWR capabilities using prime and check if it can be mmaped.
>   * Feature: prime, vgem
>   * Run type: BAT
> + * Sub-category: DRM
>   *
>   * SUBTEST: mmap
>   * Description: Create a vgem handle and check if it can be mmaped.
>   * Feature: vgem
>   * Run type: BAT
> + * Sub-category: DRM
>   *
>   * SUBTEST: second-client
>   * Description: Check whether it can open multiple clients.
>   * Feature: vgem
>   * Run type: BAT
> + * Sub-category: DRM
>   *
>   * SUBTEST: setversion
>   * Description: Check the working of SET_VERSION ioctl.
>   * Feature: vgem
>   * Run type: BAT
> + * Sub-category: DRM
>   *
>   * SUBTEST: sysfs
>   * Description: Check the basic access to sysfs and also try to read entries in the directory.
>   * Feature: vgem
>   * Run type: BAT
> + * Sub-category: DRM
>   *
>   * SUBTEST: unload
>   * Description: Basic test for handling of module unload.
>   * Feature: vgem
>   * Run type: BAT
> + * Sub-category: DRM
>   */
>  
>  IGT_TEST_DESCRIPTION("Basic sanity check of Virtual GEM module (vGEM).");
> diff --git a/tests/vgem_slow.c b/tests/vgem_slow.c
> index d2a7effff115..0c91cdb9dece 100644
> --- a/tests/vgem_slow.c
> +++ b/tests/vgem_slow.c
> @@ -32,9 +32,13 @@
>  #include <dirent.h>
>  /**
>   * TEST: vgem slow
> + * Category: Infrastructure
>   * Description: Extended sanity check of Virtual GEM module (vGEM).
>   * Feature: vgem
> + * Functionality: mock device
>   * Run type: FULL
> + * Sub-category: DRM
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: nohang
>   */
> -- 
> 2.40.1
> 


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [igt-dev] [PATCH i-g-t 3/6] i915/gem_exec_*: better document gem exec tests used for i915 validation
  2023-05-17 15:11 [igt-dev] [PATCH i-g-t 0/6] Improve description of tests used by i915 validation Mauro Carvalho Chehab
  2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 1/6] tests: better document core_* tests used for " Mauro Carvalho Chehab
  2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 2/6] tests: better document the remaining core used by " Mauro Carvalho Chehab
@ 2023-05-17 15:11 ` Mauro Carvalho Chehab
  2023-05-19 15:46   ` Kamil Konieczny
  2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 4/6] i915/gem_ctx_*: better document i915 context tests Mauro Carvalho Chehab
                   ` (4 subsequent siblings)
  7 siblings, 1 reply; 15+ messages in thread
From: Mauro Carvalho Chehab @ 2023-05-17 15:11 UTC (permalink / raw)
  To: igt-dev

From: Mauro Carvalho Chehab <mchehab@kernel.org>

Merge data from some ancillary internal documentation to improve
core test descriptions.

This patch was auto-generated via script.

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 tests/i915/gem_exec_alignment.c |   4 ++
 tests/i915/gem_exec_async.c     |   4 ++
 tests/i915/gem_exec_await.c     |   4 ++
 tests/i915/gem_exec_balancer.c  | 100 ++++++++++++++++++++++++++++
 tests/i915/gem_exec_basic.c     |   6 +-
 tests/i915/gem_exec_big.c       |   4 ++
 tests/i915/gem_exec_capture.c   |   4 ++
 tests/i915/gem_exec_create.c    |   7 ++
 tests/i915/gem_exec_endless.c   |   4 ++
 tests/i915/gem_exec_fence.c     | 112 ++++++++++++++++++++++++++++++++
 tests/i915/gem_exec_gttfill.c   |   7 ++
 tests/i915/gem_exec_nop.c       |   8 +++
 tests/i915/gem_exec_parallel.c  |   8 +++
 tests/i915/gem_exec_params.c    |  76 ++++++++++++++++++++++
 tests/i915/gem_exec_schedule.c  |   4 ++
 tests/i915/gem_exec_store.c     |   4 ++
 tests/i915/gem_exec_whisper.c   |   4 ++
 17 files changed, 359 insertions(+), 1 deletion(-)

diff --git a/tests/i915/gem_exec_alignment.c b/tests/i915/gem_exec_alignment.c
index 6f7b9ac9b909..9d965270fa9f 100644
--- a/tests/i915/gem_exec_alignment.c
+++ b/tests/i915/gem_exec_alignment.c
@@ -47,9 +47,13 @@
 #include "igt_types.h"
 /**
  * TEST: gem exec alignment
+ * Category: Desktop client
  * Description: Exercises the basic execbuffer using object alignments
  * Feature: cmd_submission
+ * Functionality: command submission
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: forked
  *
diff --git a/tests/i915/gem_exec_async.c b/tests/i915/gem_exec_async.c
index 1153c0bf2e30..f3c2f671f6ec 100644
--- a/tests/i915/gem_exec_async.c
+++ b/tests/i915/gem_exec_async.c
@@ -26,9 +26,13 @@
 #include "igt.h"
 /**
  * TEST: gem exec async
+ * Category: Infrastructure
  * Description: Check that we can issue concurrent writes across the engines.
  * Feature: cmd_submission
+ * Functionality: command submission
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: concurrent-writes
  *
diff --git a/tests/i915/gem_exec_await.c b/tests/i915/gem_exec_await.c
index c7f949c9cd2b..c78403466480 100644
--- a/tests/i915/gem_exec_await.c
+++ b/tests/i915/gem_exec_await.c
@@ -33,8 +33,12 @@
 #include "igt_vgem.h"
 /**
  * TEST: gem exec await
+ * Category: Infrastructure
  * Feature: cmd_submission
+ * Functionality: command submission
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: wide-all
  *
diff --git a/tests/i915/gem_exec_balancer.c b/tests/i915/gem_exec_balancer.c
index d1d92e6ba689..3ab0903ac89e 100644
--- a/tests/i915/gem_exec_balancer.c
+++ b/tests/i915/gem_exec_balancer.c
@@ -65,95 +65,195 @@
  * Feature: cmd_submission, media_scalability
  *
  * SUBTEST: busy
+ * Category: Desktop \ Server
  * Feature: cmd_submission, media_scalability
+ * Functionality: load balancing
+ * Sub-category: Media & Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: fairslice
  * Feature: cmd_submission, media_scalability
  *
  * SUBTEST: full
+ * Category: Desktop \ Server
  * Feature: cmd_submission, media_scalability, multictx
+ * Functionality: load balancing
+ * Sub-category: Media & Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: full-late
+ * Category: Desktop \ Server
  * Feature: cmd_submission, media_scalability, multictx
+ * Functionality: load balancing
+ * Sub-category: Media & Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: full-late-pulse
+ * Category: Desktop \ Server
  * Feature: cmd_submission, media_scalability, multictx
+ * Functionality: load balancing
+ * Sub-category: Media & Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: full-pulse
+ * Category: Desktop \ Server
  * Feature: cmd_submission, media_scalability, multictx
+ * Functionality: load balancing
+ * Sub-category: Media & Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: hang
+ * Category: Desktop \ Server
  * Feature: cmd_submission, media_scalability
+ * Functionality: load balancing
+ * Sub-category: Media & Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: hog
  * Feature: cmd_submission, media_scalability
  *
  * SUBTEST: indices
+ * Category: Desktop \ Server
  * Feature: cmd_submission, media_scalability, multictx
+ * Functionality: load balancing
+ * Sub-category: Media & Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: individual
+ * Category: Desktop \ Server
  * Feature: cmd_submission, media_scalability
+ * Functionality: load balancing
+ * Sub-category: Media & Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: invalid-balancer
+ * Category: Desktop \ Server
  * Feature: cmd_submission, media_scalability
+ * Functionality: load balancing
+ * Sub-category: Media & Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: invalid-bonds
  * Feature: cmd_submission, media_scalability
  *
  * SUBTEST: nohangcheck
+ * Category: Desktop \ Server
  * Feature: cmd_submission, media_scalability
+ * Functionality: load balancing
+ * Sub-category: Media & Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: noheartbeat
+ * Category: Desktop \ Server
  * Feature: cmd_submission, media_scalability
+ * Functionality: load balancing
+ * Sub-category: Media & Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: nop
+ * Category: Desktop \ Server
  * Feature: cmd_submission, media_scalability
+ * Functionality: load balancing
+ * Sub-category: Media & Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: parallel
+ * Category: Desktop client
  * Feature: cmd_submission, media_scalability
+ * Functionality: command submission
+ * Sub-category: Media
+ * Test category: GEM_Legacy
  *
  * SUBTEST: parallel-balancer
+ * Category: Desktop client
  * Feature: cmd_submission, media_scalability
+ * Functionality: command submission
+ * Sub-category: Media
+ * Test category: GEM_Legacy
  *
  * SUBTEST: parallel-bb-first
+ * Category: Desktop client
  * Feature: cmd_submission, media_scalability
+ * Functionality: command submission
+ * Sub-category: Media
+ * Test category: GEM_Legacy
  *
  * SUBTEST: parallel-contexts
+ * Category: Desktop client
  * Feature: cmd_submission, media_scalability
+ * Functionality: command submission
+ * Sub-category: Media
+ * Test category: GEM_Legacy
  *
  * SUBTEST: parallel-dmabuf-import-out-fence
  * Description: Regression test to check that dmabuf imported sync file can handle fence array
  * Feature: cmd_submission, media_scalability
  *
  * SUBTEST: parallel-keep-in-fence
+ * Category: Desktop client
  * Feature: cmd_submission, media_scalability
+ * Functionality: command submission
+ * Sub-category: Media
+ * Test category: GEM_Legacy
  *
  * SUBTEST: parallel-keep-submit-fence
+ * Category: Desktop client
  * Feature: cmd_submission, media_scalability
+ * Functionality: command submission
+ * Sub-category: Media
+ * Test category: GEM_Legacy
  *
  * SUBTEST: parallel-ordering
+ * Category: Desktop client
  * Feature: cmd_submission, media_scalability
+ * Functionality: command submission
+ * Sub-category: Media
+ * Test category: GEM_Legacy
  *
  * SUBTEST: parallel-out-fence
+ * Category: Desktop client
  * Feature: cmd_submission, media_scalability
+ * Functionality: command submission
+ * Sub-category: Media
+ * Test category: GEM_Legacy
  *
  * SUBTEST: persistence
+ * Category: Desktop \ Server
  * Feature: cmd_submission, media_scalability
+ * Functionality: load balancing
+ * Sub-category: Media & Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: semaphore
+ * Category: Desktop \ Server
  * Feature: cmd_submission, media_scalability, multictx
+ * Functionality: load balancing
+ * Sub-category: Media & Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: sequential
+ * Category: Desktop \ Server
  * Feature: cmd_submission, media_scalability
+ * Functionality: load balancing
+ * Sub-category: Media & Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: sliced
  * Feature: cmd_submission, media_scalability
  *
  * SUBTEST: smoke
+ * Category: Desktop \ Server
  * Feature: cmd_submission, media_scalability
+ * Functionality: load balancing
+ * Sub-category: Media & Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: waits
+ * Category: Desktop \ Server
  * Feature: cmd_submission, media_scalability
+ * Functionality: load balancing
+ * Sub-category: Media & Compute
+ * Test category: GEM_Legacy
  */
 
 IGT_TEST_DESCRIPTION("Exercise in-kernel load-balancing");
diff --git a/tests/i915/gem_exec_basic.c b/tests/i915/gem_exec_basic.c
index 437ce0954557..3c47a98ef461 100644
--- a/tests/i915/gem_exec_basic.c
+++ b/tests/i915/gem_exec_basic.c
@@ -27,14 +27,18 @@
 #include "i915/gem_create.h"
 /**
  * TEST: gem exec basic
+ * Category: Infrastructure
  * Description: Basic sanity check of execbuf-ioctl rings.
  * Feature: cmd_submission
- * Run type: BAT
+ * Functionality: command submission
+ * Sub-category: i915
  *
  * SUBTEST: basic
  * Description:
  *   Check basic functionality of GEM_EXECBUFFER2 ioctl on every ring and iterating over memory
  *   regions.
+ * Run type: BAT
+ * Test category: GEM_Legacy
  */
 
 IGT_TEST_DESCRIPTION("Basic sanity check of execbuf-ioctl rings.");
diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
index 7f07cf6c69db..3acdb3741f65 100644
--- a/tests/i915/gem_exec_big.c
+++ b/tests/i915/gem_exec_big.c
@@ -57,6 +57,10 @@
  * SUBTEST: exhaustive
  *
  * SUBTEST: single
+ * Category: Infrastructure
+ * Functionality: command submission
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  */
 
 IGT_TEST_DESCRIPTION("Run a large nop batch to stress test the error capture"
diff --git a/tests/i915/gem_exec_capture.c b/tests/i915/gem_exec_capture.c
index aa72e9ee9ed3..3ab659c039fc 100644
--- a/tests/i915/gem_exec_capture.c
+++ b/tests/i915/gem_exec_capture.c
@@ -33,9 +33,13 @@
 #include "igt_sysfs.h"
 /**
  * TEST: gem exec capture
+ * Category: Server
  * Description: Check that we capture the user specified objects on a hang
  * Feature: cmd_submission
+ * Functionality: offline debugging
  * Run type: FULL
+ * Sub-category: debugger
+ * Test category: GEM_Legacy
  *
  * SUBTEST: capture
  *
diff --git a/tests/i915/gem_exec_create.c b/tests/i915/gem_exec_create.c
index 89e9a8ec8ad3..830e7581b893 100644
--- a/tests/i915/gem_exec_create.c
+++ b/tests/i915/gem_exec_create.c
@@ -48,29 +48,36 @@
 #include "i915/intel_memory_region.h"
 /**
  * TEST: gem exec create
+ * Category: Infrastructure
  * Description:
  *   This test overloads the driver with transient active objects and checks if we don't kill the
  *   system under the memory pressure some of the symptoms this test look for include mysterious
  *   hangs.
  * Feature: cmd_submission
+ * Functionality: buffer management
+ * Sub-category: i915
  *
  * SUBTEST: basic
  * Description: Check if we kill system by overloading it with active objects iterating over all engines.
  * Run type: BAT
+ * Test category: GEM_Legacy
  *
  * SUBTEST: forked
  * Description: Concurrently overloads system with active objects and checks if we kill system.
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: legacy
  * Description:
  *   Check if we kill the system by overloading it with active objects iterating over legacy
  *   engines.
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: madvise
  * Description: This test does a forced reclaim, behaving like a bad application leaking its bo cache.
  * Run type: FULL
+ * Test category: GEM_Legacy
  */
 
 IGT_TEST_DESCRIPTION("This test overloads the driver with transient active objects"
diff --git a/tests/i915/gem_exec_endless.c b/tests/i915/gem_exec_endless.c
index 25ad16898761..42991c018bff 100644
--- a/tests/i915/gem_exec_endless.c
+++ b/tests/i915/gem_exec_endless.c
@@ -32,8 +32,12 @@
 #include "sw_sync.h"
 /**
  * TEST: gem exec endless
+ * Category: Server
  * Feature: cmd_submission
+ * Functionality: command submission
  * Run type: FULL
+ * Sub-category: Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: dispatch
  */
diff --git a/tests/i915/gem_exec_fence.c b/tests/i915/gem_exec_fence.c
index 5a67a93e8eed..9b3f91b70bea 100644
--- a/tests/i915/gem_exec_fence.c
+++ b/tests/i915/gem_exec_fence.c
@@ -47,27 +47,37 @@
  * SUBTEST: basic-await
  * Description: Basic check for explicit fence with async wait on each engine.
  * Feature: cmd_submission, multitile, synchronization
+ * Functionality: Basic check for explicit fence with async wait on each engine.
  * Run type: BAT
+ * Test category: MultiTile
  *
  * SUBTEST: basic-busy
  * Description: Basic check for explicit fence on each busy engine.
  * Feature: cmd_submission, multitile, synchronization
+ * Functionality: Basic check for explicit fence on each busy engine.
  * Run type: BAT
+ * Test category: MultiTile
  *
  * SUBTEST: basic-busy-all
  * Description: Basic check for composite fence on all busy engines.
  * Feature: cmd_submission, multitile, synchronization
+ * Functionality: Basic check for composite fence on all busy engines.
  * Run type: FULL
+ * Test category: MultiTile
  *
  * SUBTEST: basic-wait
  * Description: Basic check for explicit fence with additinal wait time on each busy engine.
  * Feature: cmd_submission, multitile, synchronization
+ * Functionality: Basic check for explicit fence with additional wait time on each busy engine.
  * Run type: BAT
+ * Test category: MultiTile
  *
  * SUBTEST: basic-wait-all
  * Description: Basic check for composite fence with additional wait on all busy engines.
  * Feature: cmd_submission, multitile, synchronization
+ * Functionality: Execute the same batch on each engine and check that the composite fence across all engines completes only after the batch is completed on every engine.
  * Run type: FULL
+ * Test category: MultiTile
  *
  * SUBTEST: busy-hang
  * Description: Check for explicit fence on each busy engine with a pending gpu hang.
@@ -85,36 +95,56 @@
  * Run type: FULL
  *
  * SUBTEST: expired-history
+ * Category: Infrastructure
  * Description: Verifies long history of fences are expired.
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: invalid-fence-array
+ * Category: Infrastructure
  * Description: Verifies invalid fence-array pointers are rejected.
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: invalid-timeline-fence-array
+ * Category: Infrastructure
  * Description:
  *   Verifies invalid execbuf parameters in drm_i915_gem_execbuffer_ext_timeline_fences
  *   are rejected
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: keep-in-fence
  * Description: Check in-fence is not overwritten with out-fence on each engine.
  * Feature: cmd_submission, multitile, synchronization
+ * Functionality: Check in-fence is not overwritten with out-fence on each engine
  * Run type: FULL
+ * Test category: MultiTile
  *
  * SUBTEST: long-history
+ * Category: Infrastructure
  * Description: Verifies accumulation of long history of fences.
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: nb-await
  * Description: Check for explicit fence with non-blocking wait on each engine.
  * Feature: cmd_submission, multitile, synchronization
+ * Functionality: Check for explicit fence with non-blocking wait on each
  * Run type: BAT
+ * Test category: MultiTile
  *
  * SUBTEST: nb-await-hang
  * Description: Check for explicit fence with non-blocking async wait on each engine with a pending gpu hang.
@@ -124,7 +154,9 @@
  * SUBTEST: parallel
  * Description: Check for EXEC_FENCE_SUBMIT in parallel execution scenarios on each engine.
  * Feature: cmd_submission, multitile, synchronization
+ * Functionality: Check for EXEC_FENCE_SUBMIT in parallel execution scenarios
  * Run type: FULL
+ * Test category: MultiTile
  *
  * SUBTEST: submit
  * Description: Check timeslicing on submit-fence.
@@ -149,117 +181,197 @@
  * Run type: FULL
  *
  * SUBTEST: syncobj-backward-timeline-chain-engines
+ * Category: Infrastructure
  * Description:
  *   Engine chaining tests to verify ordering of timeline syncobjs with backward timeline
  *   points.
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: syncobj-channel
+ * Category: Infrastructure
  * Description: Verifies two clients racing for syncobj using channel.
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: syncobj-export
+ * Category: Infrastructure
  * Description: Verify exporting of fence-array syncobj signaled by i915.
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: syncobj-import
+ * Category: Infrastructure
  * Description: Verifies creating of a syncobj from explicit fence.
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: syncobj-invalid-flags
+ * Category: Infrastructure
  * Description: Verifies that invalid fence flags in fence-array are rejected.
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: syncobj-invalid-wait
+ * Category: Infrastructure
  * Description: Verifies that submitting an execbuf with a wait on a syncobj that doesn't exists is rejected.
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: syncobj-repeat
+ * Category: Infrastructure
  * Description: Verifies that waiting & signaling a same fence-array syncobj within the same execbuf works.
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: syncobj-signal
+ * Category: Infrastructure
  * Description: Verifies proper signaling of a fence-array syncobj through execbuf.
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: syncobj-stationary-timeline-chain-engines
+ * Category: Infrastructure
  * Description:
  *   Engine chaining tests to verify ordering of timeline syncobj with stationary timeline
  *   points.
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: syncobj-timeline-chain-engines
+ * Category: Infrastructure
  * Description: Engine chaining tests to verify ordering of timeline syncobjs through execbuf.
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: syncobj-timeline-export
+ * Category: Infrastructure
  * Description: Verify exporting of timeline syncobj signaled by i915
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: syncobj-timeline-invalid-flags
+ * Category: Infrastructure
  * Description:
  *   Verifies that invalid fence flags in drm_i915_gem_execbuffer_ext_timeline_fences are
  *   rejected
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: syncobj-timeline-invalid-wait
+ * Category: Infrastructure
  * Description:
  *   Verifies that submitting an execbuf with a wait on a timeline syncobj point that does not
  *   exists is rejected
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: syncobj-timeline-multiple-ext-nodes
+ * Category: Infrastructure
  * Description: Verify that passing multiple execbuffer_ext nodes works
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: syncobj-timeline-repeat
+ * Category: Infrastructure
  * Description:
  *   Verifies that waiting & signaling a same timeline syncobj point within the same execbuf
  *   fworks
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: syncobj-timeline-signal
+ * Category: Infrastructure
  * Description: Verifies proper signaling of a timeline syncobj through execbuf
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: syncobj-timeline-unused-fence
+ * Category: Infrastructure
  * Description:
  *   Verifies that a timeline syncobj passed into
  *   drm_i915_gem_execbuffer_ext_timeline_fences but with no signal/wait flag is left
  *   untouched
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: syncobj-timeline-wait
+ * Category: Infrastructure
  * Description: Verifies that waiting on a timeline syncobj point between engines works
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: syncobj-unused-fence
+ * Category: Infrastructure
  * Description: Verifies that a syncobj passed into execbuf but with no signal/wait flag is left untouched.
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: syncobj-wait
+ * Category: Infrastructure
  * Description: Verifies that waiting on a timeline syncobj point between engines works.
  * Feature: cmd_submission, synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: wait-hang
  * Description:
diff --git a/tests/i915/gem_exec_gttfill.c b/tests/i915/gem_exec_gttfill.c
index 496ad6e8bb16..a31a8b82a9e4 100644
--- a/tests/i915/gem_exec_gttfill.c
+++ b/tests/i915/gem_exec_gttfill.c
@@ -28,26 +28,33 @@
 #include "igt_rand.h"
 /**
  * TEST: gem exec gttfill
+ * Category: Infrastructure
  * Description: Fill the GTT with batches.
+ * Functionality: command submission
+ * Sub-category: i915
  *
  * SUBTEST: all-engines
  * Description: Stress test check behaviour/correctness of handling batches to fill gtt
  * Feature: cmd_submission, gtt
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic
  * Description: Checks if it can handle enough batches to fill gtt
  * Feature: cmd_submission, gtt
  * Run type: BAT
+ * Test category: GEM_Legacy
  *
  * SUBTEST: engines
  * Description: Checks the correctness of handling enough batches to fill gtt for each engine
  * Feature: cmd_submission, gtt
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: multigpu-basic
  * Feature: cmd_submission, gtt, multigpu
  * Run type: FULL
+ * Test category: MultiGPU
  */
 
 IGT_TEST_DESCRIPTION("Fill the GTT with batches.");
diff --git a/tests/i915/gem_exec_nop.c b/tests/i915/gem_exec_nop.c
index b06c3ac8a696..101843acd651 100644
--- a/tests/i915/gem_exec_nop.c
+++ b/tests/i915/gem_exec_nop.c
@@ -50,16 +50,24 @@
 
 /**
  * TEST: gem exec nop
+ * Category: Infrastructure
  * Run type: FULL
+ * Sub-category: i915
  *
  * SUBTEST: basic-parallel
  * Feature: cmd_submission
+ * Functionality: command submission
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic-sequential
  * Feature: cmd_submission
+ * Functionality: command submission
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic-series
  * Feature: cmd_submission
+ * Functionality: command submission
+ * Test category: GEM_Legacy
  *
  * SUBTEST: context-sequential
  * Feature: cmd_submission
diff --git a/tests/i915/gem_exec_parallel.c b/tests/i915/gem_exec_parallel.c
index 7e6500d60257..55b51bfe3f31 100644
--- a/tests/i915/gem_exec_parallel.c
+++ b/tests/i915/gem_exec_parallel.c
@@ -35,28 +35,36 @@
 #include "igt_gt.h"
 /**
  * TEST: gem exec parallel
+ * Category: Infrastructure
  * Description: Exercise filling buffers by many clients working in parallel.
  * Feature: cmd_submission
+ * Functionality: command submission
+ * Sub-category: i915
  *
  * SUBTEST: basic
  * Description: Check basic functionality per engine.
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: contexts
  * Description: Check with many contexts.
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: engines
  * Description: Check with engines working in parallel.
  * Run type: BAT
+ * Test category: GEM_Legacy
  *
  * SUBTEST: fds
  * Description: Check with many fds.
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: userptr
  * Description: Check basic userptr thrashing.
  * Run type: FULL
+ * Test category: GEM_Legacy
  */
 
 IGT_TEST_DESCRIPTION("Exercise filling buffers by many clients working in parallel.");
diff --git a/tests/i915/gem_exec_params.c b/tests/i915/gem_exec_params.c
index bd7ec2cd1f39..16ae7a5a6bb5 100644
--- a/tests/i915/gem_exec_params.c
+++ b/tests/i915/gem_exec_params.c
@@ -55,22 +55,46 @@
  * Feature: cmd_submission
  *
  * SUBTEST: batch-first
+ * Category: Desktop client
  * Feature: cmd_submission
+ * Functionality: command submission
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: cliprects-invalid
+ * Category: Desktop client
  * Feature: cmd_submission
+ * Functionality: command submission
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: cliprects_ptr-dirt
+ * Category: Desktop client
  * Feature: cmd_submission
+ * Functionality: command submission
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: invalid-batch-start-offset
+ * Category: Desktop client
  * Feature: cmd_submission
+ * Functionality: command submission
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: invalid-bsd-ring
+ * Category: Desktop client
  * Feature: cmd_submission
+ * Functionality: command submission
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: invalid-bsd1-flag-on-blt
+ * Category: Desktop client
  * Feature: cmd_submission
+ * Functionality: command submission
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: invalid-bsd1-flag-on-render
  * Feature: cmd_submission
@@ -79,7 +103,11 @@
  * Feature: cmd_submission
  *
  * SUBTEST: invalid-bsd2-flag-on-blt
+ * Category: Desktop client
  * Feature: cmd_submission
+ * Functionality: command submission
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: invalid-bsd2-flag-on-render
  * Feature: cmd_submission
@@ -88,25 +116,53 @@
  * Feature: cmd_submission
  *
  * SUBTEST: invalid-fence-in
+ * Category: Desktop client
  * Feature: cmd_submission
+ * Functionality: command submission
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: invalid-fence-in-submit
+ * Category: Desktop client
  * Feature: cmd_submission
+ * Functionality: command submission
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: invalid-flag
+ * Category: Desktop client
  * Feature: cmd_submission
+ * Functionality: command submission
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: invalid-ring
+ * Category: Desktop client
  * Feature: cmd_submission
+ * Functionality: command submission
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: invalid-ring2
+ * Category: Desktop client
  * Feature: cmd_submission
+ * Functionality: command submission
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: larger-than-life-batch
+ * Category: Desktop client
  * Feature: cmd_submission
+ * Functionality: command submission
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: mmapped
+ * Category: Desktop client
  * Feature: cmd_submission
+ * Functionality: command submission
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: no-blt
  * Feature: cmd_submission
@@ -118,19 +174,35 @@
  * Feature: cmd_submission
  *
  * SUBTEST: readonly
+ * Category: Desktop client
  * Feature: cmd_submission
+ * Functionality: command submission
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: rel-constants-invalid
+ * Category: Desktop client
  * Feature: cmd_submission
+ * Functionality: command submission
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: rel-constants-invalid-rel-gen5
+ * Category: Desktop client
  * Feature: cmd_submission
+ * Functionality: command submission
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: rel-constants-invalid-ring
  * Feature: cmd_submission
  *
  * SUBTEST: rs-invalid
+ * Category: Desktop client
  * Feature: cmd_submission
+ * Functionality: command submission
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: rsvd2-dirt
  * Feature: cmd_submission
@@ -145,7 +217,11 @@
  * Feature: cmd_submission
  *
  * SUBTEST: sol-reset-not-gen7
+ * Category: Desktop client
  * Feature: cmd_submission
+ * Functionality: command submission
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  */
 
 #define ALIGNMENT (1 << 22)
diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c
index d17d07893f07..2156c043811c 100644
--- a/tests/i915/gem_exec_schedule.c
+++ b/tests/i915/gem_exec_schedule.c
@@ -46,8 +46,12 @@
 #include "sw_sync.h"
 /**
  * TEST: gem exec schedule
+ * Category: Desktop \ Server
  * Description: Check that we can control the order of execution
+ * Functionality: command submission
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: deep
  * Feature: cmd_submission
diff --git a/tests/i915/gem_exec_store.c b/tests/i915/gem_exec_store.c
index 19c1a060e3b0..d61072dfa6c0 100644
--- a/tests/i915/gem_exec_store.c
+++ b/tests/i915/gem_exec_store.c
@@ -36,8 +36,12 @@
 #include "igt_gt.h"
 /**
  * TEST: gem exec store
+ * Category: Infrastructure
  * Description: Exercise store dword functionality using execbuf-ioctl
  * Feature: cmd_submission
+ * Functionality: coherency
+ * Sub-category: HW
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic
  * Description: Verify that all capable engines can store dwords to a common buffer object
diff --git a/tests/i915/gem_exec_whisper.c b/tests/i915/gem_exec_whisper.c
index 978b1b4a8455..bab9700640d8 100644
--- a/tests/i915/gem_exec_whisper.c
+++ b/tests/i915/gem_exec_whisper.c
@@ -39,8 +39,12 @@
 #include "intel_ctx.h"
 /**
  * TEST: gem exec whisper
+ * Category: Infrastructure
  * Feature: cmd_submission
+ * Functionality: command submission
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic-contexts
  *
-- 
2.40.1

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 3/6] i915/gem_exec_*: better document gem exec tests used for i915 validation
  2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 3/6] i915/gem_exec_*: better document gem exec tests used for " Mauro Carvalho Chehab
@ 2023-05-19 15:46   ` Kamil Konieczny
  0 siblings, 0 replies; 15+ messages in thread
From: Kamil Konieczny @ 2023-05-19 15:46 UTC (permalink / raw)
  To: igt-dev

On 2023-05-17 at 17:11:07 +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
> 
> Merge data from some ancillary internal documentation to improve
> core test descriptions.
> 
> This patch was auto-generated via script.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

> ---
>  tests/i915/gem_exec_alignment.c |   4 ++
>  tests/i915/gem_exec_async.c     |   4 ++
>  tests/i915/gem_exec_await.c     |   4 ++
>  tests/i915/gem_exec_balancer.c  | 100 ++++++++++++++++++++++++++++
>  tests/i915/gem_exec_basic.c     |   6 +-
>  tests/i915/gem_exec_big.c       |   4 ++
>  tests/i915/gem_exec_capture.c   |   4 ++
>  tests/i915/gem_exec_create.c    |   7 ++
>  tests/i915/gem_exec_endless.c   |   4 ++
>  tests/i915/gem_exec_fence.c     | 112 ++++++++++++++++++++++++++++++++
>  tests/i915/gem_exec_gttfill.c   |   7 ++
>  tests/i915/gem_exec_nop.c       |   8 +++
>  tests/i915/gem_exec_parallel.c  |   8 +++
>  tests/i915/gem_exec_params.c    |  76 ++++++++++++++++++++++
>  tests/i915/gem_exec_schedule.c  |   4 ++
>  tests/i915/gem_exec_store.c     |   4 ++
>  tests/i915/gem_exec_whisper.c   |   4 ++
>  17 files changed, 359 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/i915/gem_exec_alignment.c b/tests/i915/gem_exec_alignment.c
> index 6f7b9ac9b909..9d965270fa9f 100644
> --- a/tests/i915/gem_exec_alignment.c
> +++ b/tests/i915/gem_exec_alignment.c
> @@ -47,9 +47,13 @@
>  #include "igt_types.h"
>  /**
>   * TEST: gem exec alignment
> + * Category: Desktop client
>   * Description: Exercises the basic execbuffer using object alignments
>   * Feature: cmd_submission
> + * Functionality: command submission
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: forked
>   *
> diff --git a/tests/i915/gem_exec_async.c b/tests/i915/gem_exec_async.c
> index 1153c0bf2e30..f3c2f671f6ec 100644
> --- a/tests/i915/gem_exec_async.c
> +++ b/tests/i915/gem_exec_async.c
> @@ -26,9 +26,13 @@
>  #include "igt.h"
>  /**
>   * TEST: gem exec async
> + * Category: Infrastructure
>   * Description: Check that we can issue concurrent writes across the engines.
>   * Feature: cmd_submission
> + * Functionality: command submission
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: concurrent-writes
>   *
> diff --git a/tests/i915/gem_exec_await.c b/tests/i915/gem_exec_await.c
> index c7f949c9cd2b..c78403466480 100644
> --- a/tests/i915/gem_exec_await.c
> +++ b/tests/i915/gem_exec_await.c
> @@ -33,8 +33,12 @@
>  #include "igt_vgem.h"
>  /**
>   * TEST: gem exec await
> + * Category: Infrastructure
>   * Feature: cmd_submission
> + * Functionality: command submission
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: wide-all
>   *
> diff --git a/tests/i915/gem_exec_balancer.c b/tests/i915/gem_exec_balancer.c
> index d1d92e6ba689..3ab0903ac89e 100644
> --- a/tests/i915/gem_exec_balancer.c
> +++ b/tests/i915/gem_exec_balancer.c
> @@ -65,95 +65,195 @@
>   * Feature: cmd_submission, media_scalability
>   *
>   * SUBTEST: busy
> + * Category: Desktop \ Server
>   * Feature: cmd_submission, media_scalability
> + * Functionality: load balancing
> + * Sub-category: Media & Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: fairslice
>   * Feature: cmd_submission, media_scalability
>   *
>   * SUBTEST: full
> + * Category: Desktop \ Server
>   * Feature: cmd_submission, media_scalability, multictx
> + * Functionality: load balancing
> + * Sub-category: Media & Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: full-late
> + * Category: Desktop \ Server
>   * Feature: cmd_submission, media_scalability, multictx
> + * Functionality: load balancing
> + * Sub-category: Media & Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: full-late-pulse
> + * Category: Desktop \ Server
>   * Feature: cmd_submission, media_scalability, multictx
> + * Functionality: load balancing
> + * Sub-category: Media & Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: full-pulse
> + * Category: Desktop \ Server
>   * Feature: cmd_submission, media_scalability, multictx
> + * Functionality: load balancing
> + * Sub-category: Media & Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: hang
> + * Category: Desktop \ Server
>   * Feature: cmd_submission, media_scalability
> + * Functionality: load balancing
> + * Sub-category: Media & Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: hog
>   * Feature: cmd_submission, media_scalability
>   *
>   * SUBTEST: indices
> + * Category: Desktop \ Server
>   * Feature: cmd_submission, media_scalability, multictx
> + * Functionality: load balancing
> + * Sub-category: Media & Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: individual
> + * Category: Desktop \ Server
>   * Feature: cmd_submission, media_scalability
> + * Functionality: load balancing
> + * Sub-category: Media & Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: invalid-balancer
> + * Category: Desktop \ Server
>   * Feature: cmd_submission, media_scalability
> + * Functionality: load balancing
> + * Sub-category: Media & Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: invalid-bonds
>   * Feature: cmd_submission, media_scalability
>   *
>   * SUBTEST: nohangcheck
> + * Category: Desktop \ Server
>   * Feature: cmd_submission, media_scalability
> + * Functionality: load balancing
> + * Sub-category: Media & Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: noheartbeat
> + * Category: Desktop \ Server
>   * Feature: cmd_submission, media_scalability
> + * Functionality: load balancing
> + * Sub-category: Media & Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: nop
> + * Category: Desktop \ Server
>   * Feature: cmd_submission, media_scalability
> + * Functionality: load balancing
> + * Sub-category: Media & Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: parallel
> + * Category: Desktop client
>   * Feature: cmd_submission, media_scalability
> + * Functionality: command submission
> + * Sub-category: Media
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: parallel-balancer
> + * Category: Desktop client
>   * Feature: cmd_submission, media_scalability
> + * Functionality: command submission
> + * Sub-category: Media
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: parallel-bb-first
> + * Category: Desktop client
>   * Feature: cmd_submission, media_scalability
> + * Functionality: command submission
> + * Sub-category: Media
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: parallel-contexts
> + * Category: Desktop client
>   * Feature: cmd_submission, media_scalability
> + * Functionality: command submission
> + * Sub-category: Media
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: parallel-dmabuf-import-out-fence
>   * Description: Regression test to check that dmabuf imported sync file can handle fence array
>   * Feature: cmd_submission, media_scalability
>   *
>   * SUBTEST: parallel-keep-in-fence
> + * Category: Desktop client
>   * Feature: cmd_submission, media_scalability
> + * Functionality: command submission
> + * Sub-category: Media
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: parallel-keep-submit-fence
> + * Category: Desktop client
>   * Feature: cmd_submission, media_scalability
> + * Functionality: command submission
> + * Sub-category: Media
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: parallel-ordering
> + * Category: Desktop client
>   * Feature: cmd_submission, media_scalability
> + * Functionality: command submission
> + * Sub-category: Media
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: parallel-out-fence
> + * Category: Desktop client
>   * Feature: cmd_submission, media_scalability
> + * Functionality: command submission
> + * Sub-category: Media
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: persistence
> + * Category: Desktop \ Server
>   * Feature: cmd_submission, media_scalability
> + * Functionality: load balancing
> + * Sub-category: Media & Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: semaphore
> + * Category: Desktop \ Server
>   * Feature: cmd_submission, media_scalability, multictx
> + * Functionality: load balancing
> + * Sub-category: Media & Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: sequential
> + * Category: Desktop \ Server
>   * Feature: cmd_submission, media_scalability
> + * Functionality: load balancing
> + * Sub-category: Media & Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: sliced
>   * Feature: cmd_submission, media_scalability
>   *
>   * SUBTEST: smoke
> + * Category: Desktop \ Server
>   * Feature: cmd_submission, media_scalability
> + * Functionality: load balancing
> + * Sub-category: Media & Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: waits
> + * Category: Desktop \ Server
>   * Feature: cmd_submission, media_scalability
> + * Functionality: load balancing
> + * Sub-category: Media & Compute
> + * Test category: GEM_Legacy
>   */
>  
>  IGT_TEST_DESCRIPTION("Exercise in-kernel load-balancing");
> diff --git a/tests/i915/gem_exec_basic.c b/tests/i915/gem_exec_basic.c
> index 437ce0954557..3c47a98ef461 100644
> --- a/tests/i915/gem_exec_basic.c
> +++ b/tests/i915/gem_exec_basic.c
> @@ -27,14 +27,18 @@
>  #include "i915/gem_create.h"
>  /**
>   * TEST: gem exec basic
> + * Category: Infrastructure
>   * Description: Basic sanity check of execbuf-ioctl rings.
>   * Feature: cmd_submission
> - * Run type: BAT
> + * Functionality: command submission
> + * Sub-category: i915
>   *
>   * SUBTEST: basic
>   * Description:
>   *   Check basic functionality of GEM_EXECBUFFER2 ioctl on every ring and iterating over memory
>   *   regions.
> + * Run type: BAT
> + * Test category: GEM_Legacy
>   */
>  
>  IGT_TEST_DESCRIPTION("Basic sanity check of execbuf-ioctl rings.");
> diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
> index 7f07cf6c69db..3acdb3741f65 100644
> --- a/tests/i915/gem_exec_big.c
> +++ b/tests/i915/gem_exec_big.c
> @@ -57,6 +57,10 @@
>   * SUBTEST: exhaustive
>   *
>   * SUBTEST: single
> + * Category: Infrastructure
> + * Functionality: command submission
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   */
>  
>  IGT_TEST_DESCRIPTION("Run a large nop batch to stress test the error capture"
> diff --git a/tests/i915/gem_exec_capture.c b/tests/i915/gem_exec_capture.c
> index aa72e9ee9ed3..3ab659c039fc 100644
> --- a/tests/i915/gem_exec_capture.c
> +++ b/tests/i915/gem_exec_capture.c
> @@ -33,9 +33,13 @@
>  #include "igt_sysfs.h"
>  /**
>   * TEST: gem exec capture
> + * Category: Server
>   * Description: Check that we capture the user specified objects on a hang
>   * Feature: cmd_submission
> + * Functionality: offline debugging
>   * Run type: FULL
> + * Sub-category: debugger
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: capture
>   *
> diff --git a/tests/i915/gem_exec_create.c b/tests/i915/gem_exec_create.c
> index 89e9a8ec8ad3..830e7581b893 100644
> --- a/tests/i915/gem_exec_create.c
> +++ b/tests/i915/gem_exec_create.c
> @@ -48,29 +48,36 @@
>  #include "i915/intel_memory_region.h"
>  /**
>   * TEST: gem exec create
> + * Category: Infrastructure
>   * Description:
>   *   This test overloads the driver with transient active objects and checks if we don't kill the
>   *   system under the memory pressure some of the symptoms this test look for include mysterious
>   *   hangs.
>   * Feature: cmd_submission
> + * Functionality: buffer management
> + * Sub-category: i915
>   *
>   * SUBTEST: basic
>   * Description: Check if we kill system by overloading it with active objects iterating over all engines.
>   * Run type: BAT
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: forked
>   * Description: Concurrently overloads system with active objects and checks if we kill system.
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: legacy
>   * Description:
>   *   Check if we kill the system by overloading it with active objects iterating over legacy
>   *   engines.
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: madvise
>   * Description: This test does a forced reclaim, behaving like a bad application leaking its bo cache.
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   */
>  
>  IGT_TEST_DESCRIPTION("This test overloads the driver with transient active objects"
> diff --git a/tests/i915/gem_exec_endless.c b/tests/i915/gem_exec_endless.c
> index 25ad16898761..42991c018bff 100644
> --- a/tests/i915/gem_exec_endless.c
> +++ b/tests/i915/gem_exec_endless.c
> @@ -32,8 +32,12 @@
>  #include "sw_sync.h"
>  /**
>   * TEST: gem exec endless
> + * Category: Server
>   * Feature: cmd_submission
> + * Functionality: command submission
>   * Run type: FULL
> + * Sub-category: Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: dispatch
>   */
> diff --git a/tests/i915/gem_exec_fence.c b/tests/i915/gem_exec_fence.c
> index 5a67a93e8eed..9b3f91b70bea 100644
> --- a/tests/i915/gem_exec_fence.c
> +++ b/tests/i915/gem_exec_fence.c
> @@ -47,27 +47,37 @@
>   * SUBTEST: basic-await
>   * Description: Basic check for explicit fence with async wait on each engine.
>   * Feature: cmd_submission, multitile, synchronization
> + * Functionality: Basic check for explicit fence with async wait on each engine.
>   * Run type: BAT
> + * Test category: MultiTile
>   *
>   * SUBTEST: basic-busy
>   * Description: Basic check for explicit fence on each busy engine.
>   * Feature: cmd_submission, multitile, synchronization
> + * Functionality: Basic check for explicit fence on each busy engine.
>   * Run type: BAT
> + * Test category: MultiTile
>   *
>   * SUBTEST: basic-busy-all
>   * Description: Basic check for composite fence on all busy engines.
>   * Feature: cmd_submission, multitile, synchronization
> + * Functionality: Basic check for composite fence on all busy engines.
>   * Run type: FULL
> + * Test category: MultiTile
>   *
>   * SUBTEST: basic-wait
>   * Description: Basic check for explicit fence with additinal wait time on each busy engine.
>   * Feature: cmd_submission, multitile, synchronization
> + * Functionality: Basic check for explicit fence with additional wait time on each busy engine.
>   * Run type: BAT
> + * Test category: MultiTile
>   *
>   * SUBTEST: basic-wait-all
>   * Description: Basic check for composite fence with additional wait on all busy engines.
>   * Feature: cmd_submission, multitile, synchronization
> + * Functionality: Execute the same batch on each engine and check that the composite fence across all engines completes only after the batch is completed on every engine.
>   * Run type: FULL
> + * Test category: MultiTile
>   *
>   * SUBTEST: busy-hang
>   * Description: Check for explicit fence on each busy engine with a pending gpu hang.
> @@ -85,36 +95,56 @@
>   * Run type: FULL
>   *
>   * SUBTEST: expired-history
> + * Category: Infrastructure
>   * Description: Verifies long history of fences are expired.
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: invalid-fence-array
> + * Category: Infrastructure
>   * Description: Verifies invalid fence-array pointers are rejected.
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: invalid-timeline-fence-array
> + * Category: Infrastructure
>   * Description:
>   *   Verifies invalid execbuf parameters in drm_i915_gem_execbuffer_ext_timeline_fences
>   *   are rejected
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: keep-in-fence
>   * Description: Check in-fence is not overwritten with out-fence on each engine.
>   * Feature: cmd_submission, multitile, synchronization
> + * Functionality: Check in-fence is not overwritten with out-fence on each engine
>   * Run type: FULL
> + * Test category: MultiTile
>   *
>   * SUBTEST: long-history
> + * Category: Infrastructure
>   * Description: Verifies accumulation of long history of fences.
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: nb-await
>   * Description: Check for explicit fence with non-blocking wait on each engine.
>   * Feature: cmd_submission, multitile, synchronization
> + * Functionality: Check for explicit fence with non-blocking wait on each
>   * Run type: BAT
> + * Test category: MultiTile
>   *
>   * SUBTEST: nb-await-hang
>   * Description: Check for explicit fence with non-blocking async wait on each engine with a pending gpu hang.
> @@ -124,7 +154,9 @@
>   * SUBTEST: parallel
>   * Description: Check for EXEC_FENCE_SUBMIT in parallel execution scenarios on each engine.
>   * Feature: cmd_submission, multitile, synchronization
> + * Functionality: Check for EXEC_FENCE_SUBMIT in parallel execution scenarios
>   * Run type: FULL
> + * Test category: MultiTile
>   *
>   * SUBTEST: submit
>   * Description: Check timeslicing on submit-fence.
> @@ -149,117 +181,197 @@
>   * Run type: FULL
>   *
>   * SUBTEST: syncobj-backward-timeline-chain-engines
> + * Category: Infrastructure
>   * Description:
>   *   Engine chaining tests to verify ordering of timeline syncobjs with backward timeline
>   *   points.
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: syncobj-channel
> + * Category: Infrastructure
>   * Description: Verifies two clients racing for syncobj using channel.
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: syncobj-export
> + * Category: Infrastructure
>   * Description: Verify exporting of fence-array syncobj signaled by i915.
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: syncobj-import
> + * Category: Infrastructure
>   * Description: Verifies creating of a syncobj from explicit fence.
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: syncobj-invalid-flags
> + * Category: Infrastructure
>   * Description: Verifies that invalid fence flags in fence-array are rejected.
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: syncobj-invalid-wait
> + * Category: Infrastructure
>   * Description: Verifies that submitting an execbuf with a wait on a syncobj that doesn't exists is rejected.
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: syncobj-repeat
> + * Category: Infrastructure
>   * Description: Verifies that waiting & signaling a same fence-array syncobj within the same execbuf works.
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: syncobj-signal
> + * Category: Infrastructure
>   * Description: Verifies proper signaling of a fence-array syncobj through execbuf.
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: syncobj-stationary-timeline-chain-engines
> + * Category: Infrastructure
>   * Description:
>   *   Engine chaining tests to verify ordering of timeline syncobj with stationary timeline
>   *   points.
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: syncobj-timeline-chain-engines
> + * Category: Infrastructure
>   * Description: Engine chaining tests to verify ordering of timeline syncobjs through execbuf.
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: syncobj-timeline-export
> + * Category: Infrastructure
>   * Description: Verify exporting of timeline syncobj signaled by i915
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: syncobj-timeline-invalid-flags
> + * Category: Infrastructure
>   * Description:
>   *   Verifies that invalid fence flags in drm_i915_gem_execbuffer_ext_timeline_fences are
>   *   rejected
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: syncobj-timeline-invalid-wait
> + * Category: Infrastructure
>   * Description:
>   *   Verifies that submitting an execbuf with a wait on a timeline syncobj point that does not
>   *   exists is rejected
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: syncobj-timeline-multiple-ext-nodes
> + * Category: Infrastructure
>   * Description: Verify that passing multiple execbuffer_ext nodes works
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: syncobj-timeline-repeat
> + * Category: Infrastructure
>   * Description:
>   *   Verifies that waiting & signaling a same timeline syncobj point within the same execbuf
>   *   fworks
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: syncobj-timeline-signal
> + * Category: Infrastructure
>   * Description: Verifies proper signaling of a timeline syncobj through execbuf
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: syncobj-timeline-unused-fence
> + * Category: Infrastructure
>   * Description:
>   *   Verifies that a timeline syncobj passed into
>   *   drm_i915_gem_execbuffer_ext_timeline_fences but with no signal/wait flag is left
>   *   untouched
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: syncobj-timeline-wait
> + * Category: Infrastructure
>   * Description: Verifies that waiting on a timeline syncobj point between engines works
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: syncobj-unused-fence
> + * Category: Infrastructure
>   * Description: Verifies that a syncobj passed into execbuf but with no signal/wait flag is left untouched.
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: syncobj-wait
> + * Category: Infrastructure
>   * Description: Verifies that waiting on a timeline syncobj point between engines works.
>   * Feature: cmd_submission, synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: wait-hang
>   * Description:
> diff --git a/tests/i915/gem_exec_gttfill.c b/tests/i915/gem_exec_gttfill.c
> index 496ad6e8bb16..a31a8b82a9e4 100644
> --- a/tests/i915/gem_exec_gttfill.c
> +++ b/tests/i915/gem_exec_gttfill.c
> @@ -28,26 +28,33 @@
>  #include "igt_rand.h"
>  /**
>   * TEST: gem exec gttfill
> + * Category: Infrastructure
>   * Description: Fill the GTT with batches.
> + * Functionality: command submission
> + * Sub-category: i915
>   *
>   * SUBTEST: all-engines
>   * Description: Stress test check behaviour/correctness of handling batches to fill gtt
>   * Feature: cmd_submission, gtt
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic
>   * Description: Checks if it can handle enough batches to fill gtt
>   * Feature: cmd_submission, gtt
>   * Run type: BAT
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: engines
>   * Description: Checks the correctness of handling enough batches to fill gtt for each engine
>   * Feature: cmd_submission, gtt
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: multigpu-basic
>   * Feature: cmd_submission, gtt, multigpu
>   * Run type: FULL
> + * Test category: MultiGPU
>   */
>  
>  IGT_TEST_DESCRIPTION("Fill the GTT with batches.");
> diff --git a/tests/i915/gem_exec_nop.c b/tests/i915/gem_exec_nop.c
> index b06c3ac8a696..101843acd651 100644
> --- a/tests/i915/gem_exec_nop.c
> +++ b/tests/i915/gem_exec_nop.c
> @@ -50,16 +50,24 @@
>  
>  /**
>   * TEST: gem exec nop
> + * Category: Infrastructure
>   * Run type: FULL
> + * Sub-category: i915
>   *
>   * SUBTEST: basic-parallel
>   * Feature: cmd_submission
> + * Functionality: command submission
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic-sequential
>   * Feature: cmd_submission
> + * Functionality: command submission
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic-series
>   * Feature: cmd_submission
> + * Functionality: command submission
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: context-sequential
>   * Feature: cmd_submission
> diff --git a/tests/i915/gem_exec_parallel.c b/tests/i915/gem_exec_parallel.c
> index 7e6500d60257..55b51bfe3f31 100644
> --- a/tests/i915/gem_exec_parallel.c
> +++ b/tests/i915/gem_exec_parallel.c
> @@ -35,28 +35,36 @@
>  #include "igt_gt.h"
>  /**
>   * TEST: gem exec parallel
> + * Category: Infrastructure
>   * Description: Exercise filling buffers by many clients working in parallel.
>   * Feature: cmd_submission
> + * Functionality: command submission
> + * Sub-category: i915
>   *
>   * SUBTEST: basic
>   * Description: Check basic functionality per engine.
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: contexts
>   * Description: Check with many contexts.
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: engines
>   * Description: Check with engines working in parallel.
>   * Run type: BAT
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: fds
>   * Description: Check with many fds.
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: userptr
>   * Description: Check basic userptr thrashing.
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   */
>  
>  IGT_TEST_DESCRIPTION("Exercise filling buffers by many clients working in parallel.");
> diff --git a/tests/i915/gem_exec_params.c b/tests/i915/gem_exec_params.c
> index bd7ec2cd1f39..16ae7a5a6bb5 100644
> --- a/tests/i915/gem_exec_params.c
> +++ b/tests/i915/gem_exec_params.c
> @@ -55,22 +55,46 @@
>   * Feature: cmd_submission
>   *
>   * SUBTEST: batch-first
> + * Category: Desktop client
>   * Feature: cmd_submission
> + * Functionality: command submission
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: cliprects-invalid
> + * Category: Desktop client
>   * Feature: cmd_submission
> + * Functionality: command submission
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: cliprects_ptr-dirt
> + * Category: Desktop client
>   * Feature: cmd_submission
> + * Functionality: command submission
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: invalid-batch-start-offset
> + * Category: Desktop client
>   * Feature: cmd_submission
> + * Functionality: command submission
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: invalid-bsd-ring
> + * Category: Desktop client
>   * Feature: cmd_submission
> + * Functionality: command submission
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: invalid-bsd1-flag-on-blt
> + * Category: Desktop client
>   * Feature: cmd_submission
> + * Functionality: command submission
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: invalid-bsd1-flag-on-render
>   * Feature: cmd_submission
> @@ -79,7 +103,11 @@
>   * Feature: cmd_submission
>   *
>   * SUBTEST: invalid-bsd2-flag-on-blt
> + * Category: Desktop client
>   * Feature: cmd_submission
> + * Functionality: command submission
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: invalid-bsd2-flag-on-render
>   * Feature: cmd_submission
> @@ -88,25 +116,53 @@
>   * Feature: cmd_submission
>   *
>   * SUBTEST: invalid-fence-in
> + * Category: Desktop client
>   * Feature: cmd_submission
> + * Functionality: command submission
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: invalid-fence-in-submit
> + * Category: Desktop client
>   * Feature: cmd_submission
> + * Functionality: command submission
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: invalid-flag
> + * Category: Desktop client
>   * Feature: cmd_submission
> + * Functionality: command submission
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: invalid-ring
> + * Category: Desktop client
>   * Feature: cmd_submission
> + * Functionality: command submission
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: invalid-ring2
> + * Category: Desktop client
>   * Feature: cmd_submission
> + * Functionality: command submission
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: larger-than-life-batch
> + * Category: Desktop client
>   * Feature: cmd_submission
> + * Functionality: command submission
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: mmapped
> + * Category: Desktop client
>   * Feature: cmd_submission
> + * Functionality: command submission
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: no-blt
>   * Feature: cmd_submission
> @@ -118,19 +174,35 @@
>   * Feature: cmd_submission
>   *
>   * SUBTEST: readonly
> + * Category: Desktop client
>   * Feature: cmd_submission
> + * Functionality: command submission
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: rel-constants-invalid
> + * Category: Desktop client
>   * Feature: cmd_submission
> + * Functionality: command submission
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: rel-constants-invalid-rel-gen5
> + * Category: Desktop client
>   * Feature: cmd_submission
> + * Functionality: command submission
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: rel-constants-invalid-ring
>   * Feature: cmd_submission
>   *
>   * SUBTEST: rs-invalid
> + * Category: Desktop client
>   * Feature: cmd_submission
> + * Functionality: command submission
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: rsvd2-dirt
>   * Feature: cmd_submission
> @@ -145,7 +217,11 @@
>   * Feature: cmd_submission
>   *
>   * SUBTEST: sol-reset-not-gen7
> + * Category: Desktop client
>   * Feature: cmd_submission
> + * Functionality: command submission
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   */
>  
>  #define ALIGNMENT (1 << 22)
> diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c
> index d17d07893f07..2156c043811c 100644
> --- a/tests/i915/gem_exec_schedule.c
> +++ b/tests/i915/gem_exec_schedule.c
> @@ -46,8 +46,12 @@
>  #include "sw_sync.h"
>  /**
>   * TEST: gem exec schedule
> + * Category: Desktop \ Server
>   * Description: Check that we can control the order of execution
> + * Functionality: command submission
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: deep
>   * Feature: cmd_submission
> diff --git a/tests/i915/gem_exec_store.c b/tests/i915/gem_exec_store.c
> index 19c1a060e3b0..d61072dfa6c0 100644
> --- a/tests/i915/gem_exec_store.c
> +++ b/tests/i915/gem_exec_store.c
> @@ -36,8 +36,12 @@
>  #include "igt_gt.h"
>  /**
>   * TEST: gem exec store
> + * Category: Infrastructure
>   * Description: Exercise store dword functionality using execbuf-ioctl
>   * Feature: cmd_submission
> + * Functionality: coherency
> + * Sub-category: HW
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic
>   * Description: Verify that all capable engines can store dwords to a common buffer object
> diff --git a/tests/i915/gem_exec_whisper.c b/tests/i915/gem_exec_whisper.c
> index 978b1b4a8455..bab9700640d8 100644
> --- a/tests/i915/gem_exec_whisper.c
> +++ b/tests/i915/gem_exec_whisper.c
> @@ -39,8 +39,12 @@
>  #include "intel_ctx.h"
>  /**
>   * TEST: gem exec whisper
> + * Category: Infrastructure
>   * Feature: cmd_submission
> + * Functionality: command submission
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic-contexts
>   *
> -- 
> 2.40.1
> 


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [igt-dev] [PATCH i-g-t 4/6] i915/gem_ctx_*: better document i915 context tests
  2023-05-17 15:11 [igt-dev] [PATCH i-g-t 0/6] Improve description of tests used by i915 validation Mauro Carvalho Chehab
                   ` (2 preceding siblings ...)
  2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 3/6] i915/gem_exec_*: better document gem exec tests used for " Mauro Carvalho Chehab
@ 2023-05-17 15:11 ` Mauro Carvalho Chehab
  2023-05-19 15:48   ` Kamil Konieczny
  2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 5/6] i915/perf_*: better document tests Mauro Carvalho Chehab
                   ` (3 subsequent siblings)
  7 siblings, 1 reply; 15+ messages in thread
From: Mauro Carvalho Chehab @ 2023-05-17 15:11 UTC (permalink / raw)
  To: igt-dev

From: Mauro Carvalho Chehab <mchehab@kernel.org>

Merge data from some ancillary internal documentation to improve
i915 gem_ctx test descriptions.

This patch was auto-generated via script.

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 tests/i915/gem_ctx_bad_destroy.c |  4 ++++
 tests/i915/gem_ctx_create.c      |  8 ++++++++
 tests/i915/gem_ctx_engines.c     |  4 ++++
 tests/i915/gem_ctx_exec.c        | 12 ++++++++++++
 tests/i915/gem_ctx_freq.c        |  4 ++++
 tests/i915/gem_ctx_isolation.c   | 26 +++++++++++++++++++++++++-
 tests/i915/gem_ctx_param.c       |  4 ++++
 tests/i915/gem_ctx_persistence.c |  4 ++++
 tests/i915/gem_ctx_shared.c      | 22 ++++++++++++++++++++++
 9 files changed, 87 insertions(+), 1 deletion(-)

diff --git a/tests/i915/gem_ctx_bad_destroy.c b/tests/i915/gem_ctx_bad_destroy.c
index 90495da8ab2e..8c47e7c1cb67 100644
--- a/tests/i915/gem_ctx_bad_destroy.c
+++ b/tests/i915/gem_ctx_bad_destroy.c
@@ -36,9 +36,13 @@
 
 /**
  * TEST: gem ctx bad destroy
+ * Category: Infrastructure
  * Description: Negative test cases for destroy contexts.
  * Feature: context
+ * Functionality: context management
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: double-destroy
  *
diff --git a/tests/i915/gem_ctx_create.c b/tests/i915/gem_ctx_create.c
index 0c65027bc838..3c806ee5b9d9 100644
--- a/tests/i915/gem_ctx_create.c
+++ b/tests/i915/gem_ctx_create.c
@@ -51,12 +51,20 @@
  * Run type: FULL
  *
  * SUBTEST: basic
+ * Category: Infrastructure
  * Description: Test random context creation
+ * Functionality: context management
  * Run type: BAT
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic-files
+ * Category: Infrastructure
  * Description: Exercise implicit per-fd context creation
+ * Functionality: context management
  * Run type: BAT
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: ext-param
  * Description: Verify valid and invalid context extensions
diff --git a/tests/i915/gem_ctx_engines.c b/tests/i915/gem_ctx_engines.c
index d15a7b7e5f67..61718494e86a 100644
--- a/tests/i915/gem_ctx_engines.c
+++ b/tests/i915/gem_ctx_engines.c
@@ -45,8 +45,12 @@
 #include "sw_sync.h"
 /**
  * TEST: gem ctx engines
+ * Category: Infrastructure
  * Feature: context
+ * Functionality: context management
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: execute-allforone
  *
diff --git a/tests/i915/gem_ctx_exec.c b/tests/i915/gem_ctx_exec.c
index 9fec2bb10fdf..4109eb3f03d1 100644
--- a/tests/i915/gem_ctx_exec.c
+++ b/tests/i915/gem_ctx_exec.c
@@ -51,26 +51,38 @@
  * TEST: gem ctx exec
  * Description: Test context batch buffer execution.
  * Feature: context
+ * Functionality: command submission
+ * Sub-category: i915
  *
  * SUBTEST: basic
+ * Category: Infrastructure
  * Description: Check the basic context batch buffer execution.
  * Run type: BAT
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic-close-race
+ * Category: Infrastructure
  * Description: Race the execution and interrupt handlers along a context, while closing it at a random time.
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic-invalid-context
+ * Category: Infrastructure
  * Description: Verify that execbuf with invalid context fails.
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic-nohangcheck
+ * Category: Server
  * Description: Verify that contexts are automatically shotdown on close, if hangchecking is disabled.
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic-norecovery
+ * Category: Server
  * Description: Check the status of context after a hang by setting and unsetting the RECOVERABLE.
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: eviction
  * Description: Check maximum number of buffers it can evict for a context.
diff --git a/tests/i915/gem_ctx_freq.c b/tests/i915/gem_ctx_freq.c
index 8e432cbdf8f5..2c30934daa23 100644
--- a/tests/i915/gem_ctx_freq.c
+++ b/tests/i915/gem_ctx_freq.c
@@ -36,8 +36,12 @@
 #include "sw_sync.h"
 /**
  * TEST: gem ctx freq
+ * Category: Server
  * Feature: context
+ * Functionality: frequency management
  * Run type: FULL
+ * Sub-category: Performance
+ * Test category: GEM_Legacy
  *
  * SUBTEST: sysfs
  */
diff --git a/tests/i915/gem_ctx_isolation.c b/tests/i915/gem_ctx_isolation.c
index 2c2da296d301..4f806a22cb4a 100644
--- a/tests/i915/gem_ctx_isolation.c
+++ b/tests/i915/gem_ctx_isolation.c
@@ -28,26 +28,50 @@
 #include "igt_types.h"
 /**
  * TEST: gem ctx isolation
- * Feature: context
+ * Category: Infrastructure
  * Run type: FULL
+ * Sub-category: HW
  *
  * SUBTEST: clean
+ * Feature: context
+ * Functionality: security
+ * Test category: GEM_Legacy
  *
  * SUBTEST: dirty-create
+ * Feature: context
+ * Functionality: security
+ * Test category: GEM_Legacy
  *
  * SUBTEST: dirty-switch
+ * Feature: context
+ * Functionality: security
+ * Test category: GEM_Legacy
  *
  * SUBTEST: nonpriv
+ * Feature: context
+ * Functionality: security
+ * Test category: GEM_Legacy
  *
  * SUBTEST: nonpriv-switch
+ * Feature: context
+ * Functionality: security
+ * Test category: GEM_Legacy
  *
  * SUBTEST: preservation
+ * Feature: context
+ * Functionality: security
+ * Test category: GEM_Legacy
  *
  * SUBTEST: preservation-S3
+ * Feature: context
  *
  * SUBTEST: preservation-S4
+ * Feature: context
  *
  * SUBTEST: preservation-reset
+ * Feature: context
+ * Functionality: security
+ * Test category: GEM_Legacy
  */
 
 /* MAX_REG must be greater than the maximum register address. */
diff --git a/tests/i915/gem_ctx_param.c b/tests/i915/gem_ctx_param.c
index 5e56c645572b..dddc946a28af 100644
--- a/tests/i915/gem_ctx_param.c
+++ b/tests/i915/gem_ctx_param.c
@@ -32,8 +32,12 @@
 #include "i915/gem_vm.h"
 /**
  * TEST: gem ctx param
+ * Category: Infrastructure
  * Description: Basic test for context set/get param input validation.
+ * Functionality: context management
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic
  * Description: Basic test for context get/set param ioctls using valid context
diff --git a/tests/i915/gem_ctx_persistence.c b/tests/i915/gem_ctx_persistence.c
index 42cf9632989e..bc5a4b5b41ba 100644
--- a/tests/i915/gem_ctx_persistence.c
+++ b/tests/i915/gem_ctx_persistence.c
@@ -47,8 +47,12 @@
 #include "sw_sync.h"
 /**
  * TEST: gem ctx persistence
+ * Category: Server
  * Feature: context
+ * Functionality: security
  * Run type: FULL
+ * Sub-category: Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: engines-cleanup
  *
diff --git a/tests/i915/gem_ctx_shared.c b/tests/i915/gem_ctx_shared.c
index 98827f09f9ea..f29005518c40 100644
--- a/tests/i915/gem_ctx_shared.c
+++ b/tests/i915/gem_ctx_shared.c
@@ -66,20 +66,42 @@
  * SUBTEST: Q-smoketest-all
  *
  * SUBTEST: create-shared-gtt
+ * Category: Desktop client
+ * Functionality: context management
+ * Sub-category: Media
+ * Test category: GEM_Legacy
  *
  * SUBTEST: detached-shared-gtt
+ * Category: Desktop client
+ * Functionality: context management
+ * Sub-category: Media
+ * Test category: GEM_Legacy
  *
  * SUBTEST: disjoint-timelines
+ * Category: Desktop client
+ * Functionality: context management
+ * Sub-category: Media
+ * Test category: GEM_Legacy
  *
  * SUBTEST: exec-shared-gtt
+ * Category: Desktop client
+ * Functionality: context management
+ * Sub-category: Media
+ * Test category: GEM_Legacy
  *
  * SUBTEST: exec-single-timeline
+ * Category: Desktop client
+ * Functionality: context management
+ * Test category: GEM_Legacy
  *
  * SUBTEST: exhaust-shared-gtt
  *
  * SUBTEST: exhaust-shared-gtt-lrc
  *
  * SUBTEST: single-timeline
+ * Category: Desktop client
+ * Functionality: context management
+ * Test category: GEM_Legacy
  */
 
 #define LO 0
-- 
2.40.1

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 4/6] i915/gem_ctx_*: better document i915 context tests
  2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 4/6] i915/gem_ctx_*: better document i915 context tests Mauro Carvalho Chehab
@ 2023-05-19 15:48   ` Kamil Konieczny
  0 siblings, 0 replies; 15+ messages in thread
From: Kamil Konieczny @ 2023-05-19 15:48 UTC (permalink / raw)
  To: igt-dev

On 2023-05-17 at 17:11:08 +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
> 
> Merge data from some ancillary internal documentation to improve
> i915 gem_ctx test descriptions.
> 
> This patch was auto-generated via script.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

> ---
>  tests/i915/gem_ctx_bad_destroy.c |  4 ++++
>  tests/i915/gem_ctx_create.c      |  8 ++++++++
>  tests/i915/gem_ctx_engines.c     |  4 ++++
>  tests/i915/gem_ctx_exec.c        | 12 ++++++++++++
>  tests/i915/gem_ctx_freq.c        |  4 ++++
>  tests/i915/gem_ctx_isolation.c   | 26 +++++++++++++++++++++++++-
>  tests/i915/gem_ctx_param.c       |  4 ++++
>  tests/i915/gem_ctx_persistence.c |  4 ++++
>  tests/i915/gem_ctx_shared.c      | 22 ++++++++++++++++++++++
>  9 files changed, 87 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/i915/gem_ctx_bad_destroy.c b/tests/i915/gem_ctx_bad_destroy.c
> index 90495da8ab2e..8c47e7c1cb67 100644
> --- a/tests/i915/gem_ctx_bad_destroy.c
> +++ b/tests/i915/gem_ctx_bad_destroy.c
> @@ -36,9 +36,13 @@
>  
>  /**
>   * TEST: gem ctx bad destroy
> + * Category: Infrastructure
>   * Description: Negative test cases for destroy contexts.
>   * Feature: context
> + * Functionality: context management
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: double-destroy
>   *
> diff --git a/tests/i915/gem_ctx_create.c b/tests/i915/gem_ctx_create.c
> index 0c65027bc838..3c806ee5b9d9 100644
> --- a/tests/i915/gem_ctx_create.c
> +++ b/tests/i915/gem_ctx_create.c
> @@ -51,12 +51,20 @@
>   * Run type: FULL
>   *
>   * SUBTEST: basic
> + * Category: Infrastructure
>   * Description: Test random context creation
> + * Functionality: context management
>   * Run type: BAT
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic-files
> + * Category: Infrastructure
>   * Description: Exercise implicit per-fd context creation
> + * Functionality: context management
>   * Run type: BAT
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: ext-param
>   * Description: Verify valid and invalid context extensions
> diff --git a/tests/i915/gem_ctx_engines.c b/tests/i915/gem_ctx_engines.c
> index d15a7b7e5f67..61718494e86a 100644
> --- a/tests/i915/gem_ctx_engines.c
> +++ b/tests/i915/gem_ctx_engines.c
> @@ -45,8 +45,12 @@
>  #include "sw_sync.h"
>  /**
>   * TEST: gem ctx engines
> + * Category: Infrastructure
>   * Feature: context
> + * Functionality: context management
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: execute-allforone
>   *
> diff --git a/tests/i915/gem_ctx_exec.c b/tests/i915/gem_ctx_exec.c
> index 9fec2bb10fdf..4109eb3f03d1 100644
> --- a/tests/i915/gem_ctx_exec.c
> +++ b/tests/i915/gem_ctx_exec.c
> @@ -51,26 +51,38 @@
>   * TEST: gem ctx exec
>   * Description: Test context batch buffer execution.
>   * Feature: context
> + * Functionality: command submission
> + * Sub-category: i915
>   *
>   * SUBTEST: basic
> + * Category: Infrastructure
>   * Description: Check the basic context batch buffer execution.
>   * Run type: BAT
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic-close-race
> + * Category: Infrastructure
>   * Description: Race the execution and interrupt handlers along a context, while closing it at a random time.
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic-invalid-context
> + * Category: Infrastructure
>   * Description: Verify that execbuf with invalid context fails.
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic-nohangcheck
> + * Category: Server
>   * Description: Verify that contexts are automatically shotdown on close, if hangchecking is disabled.
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic-norecovery
> + * Category: Server
>   * Description: Check the status of context after a hang by setting and unsetting the RECOVERABLE.
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: eviction
>   * Description: Check maximum number of buffers it can evict for a context.
> diff --git a/tests/i915/gem_ctx_freq.c b/tests/i915/gem_ctx_freq.c
> index 8e432cbdf8f5..2c30934daa23 100644
> --- a/tests/i915/gem_ctx_freq.c
> +++ b/tests/i915/gem_ctx_freq.c
> @@ -36,8 +36,12 @@
>  #include "sw_sync.h"
>  /**
>   * TEST: gem ctx freq
> + * Category: Server
>   * Feature: context
> + * Functionality: frequency management
>   * Run type: FULL
> + * Sub-category: Performance
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: sysfs
>   */
> diff --git a/tests/i915/gem_ctx_isolation.c b/tests/i915/gem_ctx_isolation.c
> index 2c2da296d301..4f806a22cb4a 100644
> --- a/tests/i915/gem_ctx_isolation.c
> +++ b/tests/i915/gem_ctx_isolation.c
> @@ -28,26 +28,50 @@
>  #include "igt_types.h"
>  /**
>   * TEST: gem ctx isolation
> - * Feature: context
> + * Category: Infrastructure
>   * Run type: FULL
> + * Sub-category: HW
>   *
>   * SUBTEST: clean
> + * Feature: context
> + * Functionality: security
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: dirty-create
> + * Feature: context
> + * Functionality: security
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: dirty-switch
> + * Feature: context
> + * Functionality: security
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: nonpriv
> + * Feature: context
> + * Functionality: security
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: nonpriv-switch
> + * Feature: context
> + * Functionality: security
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: preservation
> + * Feature: context
> + * Functionality: security
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: preservation-S3
> + * Feature: context
>   *
>   * SUBTEST: preservation-S4
> + * Feature: context
>   *
>   * SUBTEST: preservation-reset
> + * Feature: context
> + * Functionality: security
> + * Test category: GEM_Legacy
>   */
>  
>  /* MAX_REG must be greater than the maximum register address. */
> diff --git a/tests/i915/gem_ctx_param.c b/tests/i915/gem_ctx_param.c
> index 5e56c645572b..dddc946a28af 100644
> --- a/tests/i915/gem_ctx_param.c
> +++ b/tests/i915/gem_ctx_param.c
> @@ -32,8 +32,12 @@
>  #include "i915/gem_vm.h"
>  /**
>   * TEST: gem ctx param
> + * Category: Infrastructure
>   * Description: Basic test for context set/get param input validation.
> + * Functionality: context management
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic
>   * Description: Basic test for context get/set param ioctls using valid context
> diff --git a/tests/i915/gem_ctx_persistence.c b/tests/i915/gem_ctx_persistence.c
> index 42cf9632989e..bc5a4b5b41ba 100644
> --- a/tests/i915/gem_ctx_persistence.c
> +++ b/tests/i915/gem_ctx_persistence.c
> @@ -47,8 +47,12 @@
>  #include "sw_sync.h"
>  /**
>   * TEST: gem ctx persistence
> + * Category: Server
>   * Feature: context
> + * Functionality: security
>   * Run type: FULL
> + * Sub-category: Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: engines-cleanup
>   *
> diff --git a/tests/i915/gem_ctx_shared.c b/tests/i915/gem_ctx_shared.c
> index 98827f09f9ea..f29005518c40 100644
> --- a/tests/i915/gem_ctx_shared.c
> +++ b/tests/i915/gem_ctx_shared.c
> @@ -66,20 +66,42 @@
>   * SUBTEST: Q-smoketest-all
>   *
>   * SUBTEST: create-shared-gtt
> + * Category: Desktop client
> + * Functionality: context management
> + * Sub-category: Media
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: detached-shared-gtt
> + * Category: Desktop client
> + * Functionality: context management
> + * Sub-category: Media
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: disjoint-timelines
> + * Category: Desktop client
> + * Functionality: context management
> + * Sub-category: Media
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: exec-shared-gtt
> + * Category: Desktop client
> + * Functionality: context management
> + * Sub-category: Media
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: exec-single-timeline
> + * Category: Desktop client
> + * Functionality: context management
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: exhaust-shared-gtt
>   *
>   * SUBTEST: exhaust-shared-gtt-lrc
>   *
>   * SUBTEST: single-timeline
> + * Category: Desktop client
> + * Functionality: context management
> + * Test category: GEM_Legacy
>   */
>  
>  #define LO 0
> -- 
> 2.40.1
> 


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [igt-dev] [PATCH i-g-t 5/6] i915/perf_*: better document tests
  2023-05-17 15:11 [igt-dev] [PATCH i-g-t 0/6] Improve description of tests used by i915 validation Mauro Carvalho Chehab
                   ` (3 preceding siblings ...)
  2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 4/6] i915/gem_ctx_*: better document i915 context tests Mauro Carvalho Chehab
@ 2023-05-17 15:11 ` Mauro Carvalho Chehab
  2023-05-19 15:52   ` Kamil Konieczny
  2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 6/6] i915/: better document the remaining i915 tests Mauro Carvalho Chehab
                   ` (2 subsequent siblings)
  7 siblings, 1 reply; 15+ messages in thread
From: Mauro Carvalho Chehab @ 2023-05-17 15:11 UTC (permalink / raw)
  To: igt-dev

From: Mauro Carvalho Chehab <mchehab@kernel.org>

Merge data from some ancillary internal documentation to improve
i915 perf test descriptions.

This patch was auto-generated via script.

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 tests/i915/perf.c     | 126 +++++++++++++++++++++++++------
 tests/i915/perf_pmu.c | 171 +++++++++++++++++++++++++++++++++---------
 2 files changed, 238 insertions(+), 59 deletions(-)

diff --git a/tests/i915/perf.c b/tests/i915/perf.c
index 1b1c39aafb8b..f22be7f6eaba 100644
--- a/tests/i915/perf.c
+++ b/tests/i915/perf.c
@@ -49,23 +49,39 @@
  * TEST: perf
  * Description: Test the i915 perf metrics streaming interface
  * Run type: FULL
+ * Test category: Perf
  *
  * SUBTEST: blocking
  * Description: Test blocking read with default hrtimer frequency
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test blocking read with default hrtimer frequency
  *
  * SUBTEST: blocking-parameterized
  * Description: Test blocking read with different hrtimer frequencies
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test blocking read with different hrtimer frequencies
  *
  * SUBTEST: buffer-fill
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test the i915 perf metrics streaming interface
  *
  * SUBTEST: create-destroy-userspace-config
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test the i915 perf metrics streaming interface
  *
  * SUBTEST: disabled-read-error
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test the i915 perf metrics streaming interface
  *
  * SUBTEST: enable-disable
  * Feature: oa
@@ -84,7 +100,10 @@
  *
  * SUBTEST: gen12-invalid-class-instance
  * Description: Verify invalid class instance
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Verify invalid class instance
  *
  * SUBTEST: gen12-mi-rpc
  * Description: Test MI REPORT PERF COUNT for Gen 12
@@ -92,7 +111,10 @@
  *
  * SUBTEST: gen12-oa-tlb-invalidate
  * Description: Test OA TLB invalidate
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test OA TLB invalidate
  *
  * SUBTEST: gen12-unprivileged-single-ctx-counters
  * Description: Measure performance for a specific context using OAR in Gen 12
@@ -110,84 +132,138 @@
  * Feature: oa
  *
  * SUBTEST: i915-ref-count
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test the i915 perf metrics streaming interface
  *
  * SUBTEST: invalid-create-userspace-config
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test the i915 perf metrics streaming interface
  *
  * SUBTEST: invalid-oa-exponent
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test the i915 perf metrics streaming interface
  *
  * SUBTEST: invalid-oa-format-id
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test the i915 perf metrics streaming interface
  *
  * SUBTEST: invalid-oa-metric-set-id
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test the i915 perf metrics streaming interface
  *
  * SUBTEST: invalid-open-flags
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test the i915 perf metrics streaming interface
  *
  * SUBTEST: invalid-remove-userspace-config
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test the i915 perf metrics streaming interface
  *
  * SUBTEST: low-oa-exponent-permissions
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test the i915 perf metrics streaming interface
  *
  * SUBTEST: mi-rpc
  * Feature: oa
  *
  * SUBTEST: missing-sample-flags
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test the i915 perf metrics streaming interface
  *
  * SUBTEST: non-sampling-read-error
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test the i915 perf metrics streaming interface
  *
  * SUBTEST: non-system-wide-paranoid
  * Feature: oa
  *
  * SUBTEST: non-zero-reason
  * Description: Test that reason field in OA reports is never 0 on Gen8+
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test that reason field in OA reports is never 0 on Gen8+
  *
  * SUBTEST: oa-exponents
  * Feature: oa
  *
  * SUBTEST: oa-formats
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test the i915 perf metrics streaming interface
  *
  * SUBTEST: per-context-mode-unprivileged
  * Feature: oa, obsolete
  *
  * SUBTEST: polling
  * Description: Test polled read with default hrtimer frequency
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test polled read with default hrtimer frequency
  *
  * SUBTEST: polling-parameterized
  * Description: Test polled read with different hrtimer frequencies
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test polled read with different hrtimer frequencies
  *
  * SUBTEST: polling-small-buf
  * Description: Test polled read with buffer size smaller than available data
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test polled read with buffer size smaller than available data
  *
  * SUBTEST: rc6-disable
  * Feature: oa
  *
  * SUBTEST: short-reads
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test the i915 perf metrics streaming interface
  *
  * SUBTEST: stress-open-close
  * Description: Stress tests opening & closing the i915-perf stream in a busy loop
  * Feature: oa
  *
  * SUBTEST: sysctl-defaults
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test the i915 perf metrics streaming interface
  *
  * SUBTEST: unprivileged-single-ctx-counters
  * Feature: oa, obsolete
  *
  * SUBTEST: whitelisted-registers-userspace-config
- * Feature: oa
+ * Feature:
+ *   oa
+ *   i915 streaming interface
+ * Functionality: Test the i915 perf metrics streaming interface
  */
 
 IGT_TEST_DESCRIPTION("Test the i915 perf metrics streaming interface");
diff --git a/tests/i915/perf_pmu.c b/tests/i915/perf_pmu.c
index bedadbe92797..653b5e99c78c 100644
--- a/tests/i915/perf_pmu.c
+++ b/tests/i915/perf_pmu.c
@@ -53,54 +53,103 @@
  * TEST: perf pmu
  * Description: Test the i915 pmu perf interface
  * Run type: FULL
+ * Test category: Perf
  *
  * SUBTEST: all-busy-check-all
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test the i915 pmu perf interface
  *
  * SUBTEST: all-busy-idle-check-all
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test the i915 pmu perf interface
  *
  * SUBTEST: busy
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test to ensure gpu is busy when there a workload by reading engine busyness pmu counters
  *
  * SUBTEST: busy-accuracy-2
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test the i915 pmu perf interface
  *
  * SUBTEST: busy-accuracy-50
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test the i915 pmu perf interface
  *
  * SUBTEST: busy-accuracy-98
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test the i915 pmu perf interface
  *
  * SUBTEST: busy-check-all
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test to ensure gpu all engines report busy when there is a workload by reading engine busyness pmu counters
  *
  * SUBTEST: busy-double-start
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test the i915 pmu perf interface
  *
  * SUBTEST: busy-hang
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test to ensure there is no hanf when all engines are busy
  *
  * SUBTEST: busy-idle
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test to ensure gpu engine reports idle when there is no workload
  *
  * SUBTEST: busy-idle-check-all
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test to ensure gpu all engine reports idle when there is no workload
  *
  * SUBTEST: busy-idle-no-semaphores
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test to verify gpu idle through engine business pmu counters
  *
  * SUBTEST: busy-no-semaphores
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test to verify gpu busyness through engine business pmu counters
  *
  * SUBTEST: busy-start
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test to verify gpu busyness through engine business pmu counters
  *
  * SUBTEST: cpu-hotplug
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test the i915 pmu perf interface
  *
  * SUBTEST: enable-race
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test the i915 pmu perf interface
  *
  * SUBTEST: event-wait
  * Feature: obsolete, pmu
@@ -109,52 +158,97 @@
  * Feature: pmu
  *
  * SUBTEST: frequency
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Read requested freq and actual frequency via PMU within specified time interval for any given workload changes
  *
  * SUBTEST: frequency-idle
  * Feature: pmu
  *
  * SUBTEST: gt-awake
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Setup workload on all engines,measure gt awake time via pmu
  *
  * SUBTEST: idle
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test to ensure gpu is idle when there is no workload by reading engine busyness pmu counters
  *
  * SUBTEST: idle-no-semaphores
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test to ensure gpu is idle when there is no workload by reading engine busyness pmu counters
  *
  * SUBTEST: init-busy
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test to verify gpu busyness init through pmu perf interface
  *
  * SUBTEST: init-sema
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test to verify gpu busyness init through pmu perf interface
  *
  * SUBTEST: init-wait
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test to verify gpu busyness init through pmu perf interface
  *
  * SUBTEST: interrupts
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test the i915 pmu perf interface
  *
  * SUBTEST: interrupts-sync
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test the i915 pmu perf interface
  *
  * SUBTEST: invalid-init
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Tests that i915 PMU corectly errors out in invalid initialization
  *
  * SUBTEST: invalid-open
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test the i915 pmu perf interface
  *
  * SUBTEST: module-unload
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test the i915 pmu perf interface
  *
  * SUBTEST: most-busy-check-all
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test the i915 pmu perf interface
  *
  * SUBTEST: most-busy-idle-check-all
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test the i915 pmu perf interface
  *
  * SUBTEST: multi-client
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test the i915 pmu perf interface
  *
  * SUBTEST: pmu-read
  * Description: Verify i915 pmu dir exists and read all events
@@ -179,13 +273,22 @@
  * Feature: pmu
  *
  * SUBTEST: semaphore-busy
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test the i915 pmu perf interface
  *
  * SUBTEST: semaphore-wait
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test the i915 pmu perf interface
  *
  * SUBTEST: semaphore-wait-idle
- * Feature: pmu
+ * Feature:
+ *   pmu
+ *   i915 pmu perf interface
+ * Functionality: Test the i915 pmu perf interface
  */
 
 IGT_TEST_DESCRIPTION("Test the i915 pmu perf interface");
-- 
2.40.1

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 5/6] i915/perf_*: better document tests
  2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 5/6] i915/perf_*: better document tests Mauro Carvalho Chehab
@ 2023-05-19 15:52   ` Kamil Konieczny
  0 siblings, 0 replies; 15+ messages in thread
From: Kamil Konieczny @ 2023-05-19 15:52 UTC (permalink / raw)
  To: igt-dev

Hi Mauro,

it seems that there are problem with mixing description into
functionality, see below.

On 2023-05-17 at 17:11:09 +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
> 
> Merge data from some ancillary internal documentation to improve
> i915 perf test descriptions.
> 
> This patch was auto-generated via script.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
>  tests/i915/perf.c     | 126 +++++++++++++++++++++++++------
>  tests/i915/perf_pmu.c | 171 +++++++++++++++++++++++++++++++++---------
>  2 files changed, 238 insertions(+), 59 deletions(-)
> 
> diff --git a/tests/i915/perf.c b/tests/i915/perf.c
> index 1b1c39aafb8b..f22be7f6eaba 100644
> --- a/tests/i915/perf.c
> +++ b/tests/i915/perf.c
> @@ -49,23 +49,39 @@
>   * TEST: perf
>   * Description: Test the i915 perf metrics streaming interface
>   * Run type: FULL
> + * Test category: Perf
>   *
>   * SUBTEST: blocking
>   * Description: Test blocking read with default hrtimer frequency
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test blocking read with default hrtimer frequency
-------------------- ^
Is it really functionality ? I ask because it seems more like
description, see next comment.

>   *
>   * SUBTEST: blocking-parameterized
>   * Description: Test blocking read with different hrtimer frequencies
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test blocking read with different hrtimer frequencies
>   *
>   * SUBTEST: buffer-fill
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test the i915 perf metrics streaming interface
>   *
>   * SUBTEST: create-destroy-userspace-config
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test the i915 perf metrics streaming interface
>   *
>   * SUBTEST: disabled-read-error
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test the i915 perf metrics streaming interface
>   *
>   * SUBTEST: enable-disable
>   * Feature: oa
> @@ -84,7 +100,10 @@
>   *
>   * SUBTEST: gen12-invalid-class-instance
>   * Description: Verify invalid class instance
------------------ ^

> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Verify invalid class instance
-------------------- ^
These are the same strings.

Regards,
Kamil

>   *
>   * SUBTEST: gen12-mi-rpc
>   * Description: Test MI REPORT PERF COUNT for Gen 12
> @@ -92,7 +111,10 @@
>   *
>   * SUBTEST: gen12-oa-tlb-invalidate
>   * Description: Test OA TLB invalidate
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test OA TLB invalidate
>   *
>   * SUBTEST: gen12-unprivileged-single-ctx-counters
>   * Description: Measure performance for a specific context using OAR in Gen 12
> @@ -110,84 +132,138 @@
>   * Feature: oa
>   *
>   * SUBTEST: i915-ref-count
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test the i915 perf metrics streaming interface
>   *
>   * SUBTEST: invalid-create-userspace-config
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test the i915 perf metrics streaming interface
>   *
>   * SUBTEST: invalid-oa-exponent
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test the i915 perf metrics streaming interface
>   *
>   * SUBTEST: invalid-oa-format-id
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test the i915 perf metrics streaming interface
>   *
>   * SUBTEST: invalid-oa-metric-set-id
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test the i915 perf metrics streaming interface
>   *
>   * SUBTEST: invalid-open-flags
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test the i915 perf metrics streaming interface
>   *
>   * SUBTEST: invalid-remove-userspace-config
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test the i915 perf metrics streaming interface
>   *
>   * SUBTEST: low-oa-exponent-permissions
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test the i915 perf metrics streaming interface
>   *
>   * SUBTEST: mi-rpc
>   * Feature: oa
>   *
>   * SUBTEST: missing-sample-flags
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test the i915 perf metrics streaming interface
>   *
>   * SUBTEST: non-sampling-read-error
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test the i915 perf metrics streaming interface
>   *
>   * SUBTEST: non-system-wide-paranoid
>   * Feature: oa
>   *
>   * SUBTEST: non-zero-reason
>   * Description: Test that reason field in OA reports is never 0 on Gen8+
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test that reason field in OA reports is never 0 on Gen8+
>   *
>   * SUBTEST: oa-exponents
>   * Feature: oa
>   *
>   * SUBTEST: oa-formats
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test the i915 perf metrics streaming interface
>   *
>   * SUBTEST: per-context-mode-unprivileged
>   * Feature: oa, obsolete
>   *
>   * SUBTEST: polling
>   * Description: Test polled read with default hrtimer frequency
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test polled read with default hrtimer frequency
>   *
>   * SUBTEST: polling-parameterized
>   * Description: Test polled read with different hrtimer frequencies
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test polled read with different hrtimer frequencies
>   *
>   * SUBTEST: polling-small-buf
>   * Description: Test polled read with buffer size smaller than available data
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test polled read with buffer size smaller than available data
>   *
>   * SUBTEST: rc6-disable
>   * Feature: oa
>   *
>   * SUBTEST: short-reads
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test the i915 perf metrics streaming interface
>   *
>   * SUBTEST: stress-open-close
>   * Description: Stress tests opening & closing the i915-perf stream in a busy loop
>   * Feature: oa
>   *
>   * SUBTEST: sysctl-defaults
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test the i915 perf metrics streaming interface
>   *
>   * SUBTEST: unprivileged-single-ctx-counters
>   * Feature: oa, obsolete
>   *
>   * SUBTEST: whitelisted-registers-userspace-config
> - * Feature: oa
> + * Feature:
> + *   oa
> + *   i915 streaming interface
> + * Functionality: Test the i915 perf metrics streaming interface
>   */
>  
>  IGT_TEST_DESCRIPTION("Test the i915 perf metrics streaming interface");
> diff --git a/tests/i915/perf_pmu.c b/tests/i915/perf_pmu.c
> index bedadbe92797..653b5e99c78c 100644
> --- a/tests/i915/perf_pmu.c
> +++ b/tests/i915/perf_pmu.c
> @@ -53,54 +53,103 @@
>   * TEST: perf pmu
>   * Description: Test the i915 pmu perf interface
>   * Run type: FULL
> + * Test category: Perf
>   *
>   * SUBTEST: all-busy-check-all
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test the i915 pmu perf interface
>   *
>   * SUBTEST: all-busy-idle-check-all
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test the i915 pmu perf interface
>   *
>   * SUBTEST: busy
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test to ensure gpu is busy when there a workload by reading engine busyness pmu counters
>   *
>   * SUBTEST: busy-accuracy-2
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test the i915 pmu perf interface
>   *
>   * SUBTEST: busy-accuracy-50
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test the i915 pmu perf interface
>   *
>   * SUBTEST: busy-accuracy-98
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test the i915 pmu perf interface
>   *
>   * SUBTEST: busy-check-all
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test to ensure gpu all engines report busy when there is a workload by reading engine busyness pmu counters
>   *
>   * SUBTEST: busy-double-start
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test the i915 pmu perf interface
>   *
>   * SUBTEST: busy-hang
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test to ensure there is no hanf when all engines are busy
>   *
>   * SUBTEST: busy-idle
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test to ensure gpu engine reports idle when there is no workload
>   *
>   * SUBTEST: busy-idle-check-all
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test to ensure gpu all engine reports idle when there is no workload
>   *
>   * SUBTEST: busy-idle-no-semaphores
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test to verify gpu idle through engine business pmu counters
>   *
>   * SUBTEST: busy-no-semaphores
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test to verify gpu busyness through engine business pmu counters
>   *
>   * SUBTEST: busy-start
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test to verify gpu busyness through engine business pmu counters
>   *
>   * SUBTEST: cpu-hotplug
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test the i915 pmu perf interface
>   *
>   * SUBTEST: enable-race
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test the i915 pmu perf interface
>   *
>   * SUBTEST: event-wait
>   * Feature: obsolete, pmu
> @@ -109,52 +158,97 @@
>   * Feature: pmu
>   *
>   * SUBTEST: frequency
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Read requested freq and actual frequency via PMU within specified time interval for any given workload changes
>   *
>   * SUBTEST: frequency-idle
>   * Feature: pmu
>   *
>   * SUBTEST: gt-awake
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Setup workload on all engines,measure gt awake time via pmu
>   *
>   * SUBTEST: idle
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test to ensure gpu is idle when there is no workload by reading engine busyness pmu counters
>   *
>   * SUBTEST: idle-no-semaphores
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test to ensure gpu is idle when there is no workload by reading engine busyness pmu counters
>   *
>   * SUBTEST: init-busy
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test to verify gpu busyness init through pmu perf interface
>   *
>   * SUBTEST: init-sema
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test to verify gpu busyness init through pmu perf interface
>   *
>   * SUBTEST: init-wait
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test to verify gpu busyness init through pmu perf interface
>   *
>   * SUBTEST: interrupts
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test the i915 pmu perf interface
>   *
>   * SUBTEST: interrupts-sync
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test the i915 pmu perf interface
>   *
>   * SUBTEST: invalid-init
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Tests that i915 PMU corectly errors out in invalid initialization
>   *
>   * SUBTEST: invalid-open
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test the i915 pmu perf interface
>   *
>   * SUBTEST: module-unload
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test the i915 pmu perf interface
>   *
>   * SUBTEST: most-busy-check-all
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test the i915 pmu perf interface
>   *
>   * SUBTEST: most-busy-idle-check-all
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test the i915 pmu perf interface
>   *
>   * SUBTEST: multi-client
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test the i915 pmu perf interface
>   *
>   * SUBTEST: pmu-read
>   * Description: Verify i915 pmu dir exists and read all events
> @@ -179,13 +273,22 @@
>   * Feature: pmu
>   *
>   * SUBTEST: semaphore-busy
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test the i915 pmu perf interface
>   *
>   * SUBTEST: semaphore-wait
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test the i915 pmu perf interface
>   *
>   * SUBTEST: semaphore-wait-idle
> - * Feature: pmu
> + * Feature:
> + *   pmu
> + *   i915 pmu perf interface
> + * Functionality: Test the i915 pmu perf interface
>   */
>  
>  IGT_TEST_DESCRIPTION("Test the i915 pmu perf interface");
> -- 
> 2.40.1
> 


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [igt-dev] [PATCH i-g-t 6/6] i915/: better document the remaining i915 tests
  2023-05-17 15:11 [igt-dev] [PATCH i-g-t 0/6] Improve description of tests used by i915 validation Mauro Carvalho Chehab
                   ` (4 preceding siblings ...)
  2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 5/6] i915/perf_*: better document tests Mauro Carvalho Chehab
@ 2023-05-17 15:11 ` Mauro Carvalho Chehab
  2023-05-19 16:15   ` Kamil Konieczny
  2023-05-17 16:51 ` [igt-dev] ✓ Fi.CI.BAT: success for Improve description of tests used by i915 validation Patchwork
  2023-05-18  5:19 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  7 siblings, 1 reply; 15+ messages in thread
From: Mauro Carvalho Chehab @ 2023-05-17 15:11 UTC (permalink / raw)
  To: igt-dev

From: Mauro Carvalho Chehab <mchehab@kernel.org>

Merge data from some ancillary internal documentation to improve
i915 test descriptions.

This patch was auto-generated via script.

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 tests/i915/api_intel_allocator.c         | 23 ++++++-
 tests/i915/api_intel_bb.c                | 33 +++++++++-
 tests/i915/gem_barrier_race.c            |  1 +
 tests/i915/gem_basic.c                   |  7 +++
 tests/i915/gem_blits.c                   |  4 ++
 tests/i915/gem_busy.c                    |  7 +++
 tests/i915/gem_caching.c                 |  4 ++
 tests/i915/gem_close.c                   |  4 ++
 tests/i915/gem_close_race.c              |  7 +++
 tests/i915/gem_create.c                  | 41 ++++++++++++-
 tests/i915/gem_cs_tlb.c                  |  4 ++
 tests/i915/gem_eio.c                     | 68 ++++++++++++++++++++-
 tests/i915/gem_exercise_blt.c            |  9 ++-
 tests/i915/gem_flink_basic.c             | 14 ++++-
 tests/i915/gem_flink_race.c              |  4 ++
 tests/i915/gem_gpgpu_fill.c              |  4 ++
 tests/i915/gem_linear_blits.c            |  6 ++
 tests/i915/gem_lmem_evict.c              |  1 +
 tests/i915/gem_lmem_swapping.c           |  4 ++
 tests/i915/gem_madvise.c                 |  4 ++
 tests/i915/gem_mmap_offset.c             |  4 ++
 tests/i915/gem_pipe_control_store_loop.c |  4 ++
 tests/i915/gem_ppgtt.c                   |  6 ++
 tests/i915/gem_request_retire.c          |  4 ++
 tests/i915/gem_ringfill.c                |  8 +++
 tests/i915/gem_shrink.c                  |  4 ++
 tests/i915/gem_softpin.c                 | 69 ++++++++++++++++++++-
 tests/i915/gem_spin_batch.c              | 37 ++++++++++++
 tests/i915/gem_sync.c                    | 14 +++++
 tests/i915/gem_unref_active_buffers.c    |  4 ++
 tests/i915/gem_userptr_blits.c           | 76 ++++++++++++++++++++++++
 tests/i915/gem_vm_create.c               |  4 ++
 tests/i915/gem_wait.c                    |  4 ++
 tests/i915/gem_workarounds.c             | 32 +++++++++-
 tests/i915/i915_getparams_basic.c        |  4 ++
 tests/i915/i915_hangman.c                | 40 ++++++++++---
 tests/i915/i915_hwmon.c                  |  1 +
 tests/i915/i915_module_load.c            |  4 ++
 tests/i915/i915_pciid.c                  |  4 ++
 tests/i915/i915_pm_rpm.c                 |  6 +-
 tests/i915/i915_pm_rps.c                 | 12 +++-
 tests/i915/i915_power.c                  |  1 +
 tests/i915/i915_query.c                  |  4 ++
 tests/i915/i915_suspend.c                | 26 ++++++--
 tests/i915/sysfs_defaults.c              |  4 ++
 tests/i915/sysfs_heartbeat_interval.c    |  6 ++
 tests/i915/sysfs_preempt_timeout.c       |  4 ++
 tests/i915/sysfs_timeslice_duration.c    |  5 ++
 48 files changed, 609 insertions(+), 31 deletions(-)

diff --git a/tests/i915/api_intel_allocator.c b/tests/i915/api_intel_allocator.c
index 3962231ebcc7..7759032b75db 100644
--- a/tests/i915/api_intel_allocator.c
+++ b/tests/i915/api_intel_allocator.c
@@ -11,44 +11,65 @@
 #include "intel_allocator.h"
 /**
  * TEST: api intel allocator
+ * Category: Infrastructure
  * Feature: igt_core
+ * Functionality: virtual address ranges
  * Run type: FULL
+ * Sub-category: IGT Lib
+ * Test category: GEM_Legacy
  *
  * SUBTEST: alloc-simple
+ * Description: checking the virtual address ranges
  *
  * SUBTEST: default-alignment
  * Description:
  *   For simple allocator check does default alignment is properly handled in open and alloc
  *   functions
+ *   checking the virtual address ranges
  *
  * SUBTEST: execbuf-with-allocator
+ * Description: checking the virtual address ranges
  *
  * SUBTEST: fork-simple-once
+ * Description: checking the virtual address ranges
  *
  * SUBTEST: fork-simple-stress
+ * Description: checking the virtual address ranges
  *
  * SUBTEST: fork-simple-stress-signal
+ * Description: checking the virtual address ranges
  *
  * SUBTEST: gem-pool
- * Description: Verifies creating and executing bb from gem pool
+ * Description:
+ *   Verifies creating and executing bb from gem pool
+ *   checking the virtual address ranges
  *
  * SUBTEST: open-vm
+ * Description: checking the virtual address ranges
  *
  * SUBTEST: reloc-allocator
+ * Description: checking the virtual address ranges
  *
  * SUBTEST: reopen
+ * Description: checking the virtual address ranges
  *
  * SUBTEST: reopen-fork
+ * Description: checking the virtual address ranges
  *
  * SUBTEST: reserve-simple
+ * Description: checking the virtual address ranges
  *
  * SUBTEST: simple-allocator
+ * Description: checking the virtual address ranges
  *
  * SUBTEST: standalone
+ * Description: checking the virtual address ranges
  *
  * SUBTEST: two-level-inception
+ * Description: checking the virtual address ranges
  *
  * SUBTEST: two-level-inception-interruptible
+ * Description: checking the virtual address ranges
  */
 
 #define OBJ_SIZE 1024
diff --git a/tests/i915/api_intel_bb.c b/tests/i915/api_intel_bb.c
index 198a29eb4f26..09d90199ef4a 100644
--- a/tests/i915/api_intel_bb.c
+++ b/tests/i915/api_intel_bb.c
@@ -43,66 +43,95 @@
 #include "i915/i915_blt.h"
 /**
  * TEST: api intel bb
+ * Category: Infrastructure
  * Description: intel_bb API check.
  * Feature: igt_core
+ * Functionality: dummy buffer creation & submission
  * Run type: FULL
+ * Sub-category: IGT Lib
+ * Test category: GEM_Legacy
  *
  * SUBTEST: add-remove-objects
+ * Description: checking dummy buffer creation & submission
  *
  * SUBTEST: bb-with-allocator
+ * Description: checking dummy buffer creation & submission
  *
  * SUBTEST: blit-noreloc-keep-cache
+ * Description: checking dummy buffer creation & submission
  *
  * SUBTEST: blit-noreloc-purge-cache
+ * Description: checking dummy buffer creation & submission
  *
  * SUBTEST: blit-reloc-keep-cache
+ * Description: checking dummy buffer creation & submission
  *
  * SUBTEST: blit-reloc-purge-cache
+ * Description: checking dummy buffer creation & submission
  *
  * SUBTEST: crc32
  * Description: Compare cpu and gpu crc32 sums on input object
  *
  * SUBTEST: delta-check
+ * Description: checking dummy buffer creation & submission
  *
  * SUBTEST: destroy-bb
+ * Description: checking dummy buffer creation & submission
  *
  * SUBTEST: full-batch
+ * Description: checking dummy buffer creation & submission
  *
  * SUBTEST: intel-bb-blit-none
+ * Description: checking dummy buffer creation & submission
  *
  * SUBTEST: intel-bb-blit-x
  *
  * SUBTEST: intel-bb-blit-y
+ * Description: checking dummy buffer creation & submission
  *
  * SUBTEST: lot-of-buffers
+ * Description: checking dummy buffer creation & submission
  *
  * SUBTEST: misplaced-blitter
- * Description: Execute intel_bb with set of engines provided by userspace
+ * Description:
+ *   Execute intel_bb with set of engines provided by userspace
+ *   checking dummy buffer creation & submission
  *
  * SUBTEST: object-noreloc-keep-cache-simple
+ * Description: checking dummy buffer creation & submission
  *
  * SUBTEST: object-noreloc-purge-cache-simple
+ * Description: checking dummy buffer creation & submission
  *
  * SUBTEST: object-reloc-keep-cache
+ * Description: checking dummy buffer creation & submission
  *
  * SUBTEST: object-reloc-purge-cache
+ * Description: checking dummy buffer creation & submission
  *
  * SUBTEST: offset-control
+ * Description: checking dummy buffer creation & submission
  *
  * SUBTEST: purge-bb
+ * Description: checking dummy buffer creation & submission
  *
  * SUBTEST: render
  *
  * SUBTEST: render-ccs
  *
  * SUBTEST: reset-bb
- * Description: Ensure reset is possible on fresh bb
+ * Description:
+ *   Ensure reset is possible on fresh bb
+ *   checking dummy buffer creation & submission
  *
  * SUBTEST: reset-flags
+ * Description: checking dummy buffer creation & submission
  *
  * SUBTEST: simple-bb
+ * Description: checking dummy buffer creation & submission
  *
  * SUBTEST: simple-bb-ctx
+ * Description: checking dummy buffer creation & submission
  */
 
 #define PAGE_SIZE 4096
diff --git a/tests/i915/gem_barrier_race.c b/tests/i915/gem_barrier_race.c
index ec8ebaa63611..be71d20e7f24 100644
--- a/tests/i915/gem_barrier_race.c
+++ b/tests/i915/gem_barrier_race.c
@@ -22,6 +22,7 @@
  * Description: Exercise engine barriers and their interaction with other subsystems
  * Feature: core
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: remote-request
  * Description:
diff --git a/tests/i915/gem_basic.c b/tests/i915/gem_basic.c
index 8605429799aa..8df581bb3e48 100644
--- a/tests/i915/gem_basic.c
+++ b/tests/i915/gem_basic.c
@@ -43,27 +43,34 @@
 #include "lib/igt_device_scan.h"
 /**
  * TEST: gem basic
+ * Category: Infrastructure
  * Description: Tests basic gem_create and gem_close IOCTLs
+ * Functionality: driver handler
+ * Sub-category: i915
  *
  * SUBTEST: bad-close
  * Description: Verify that gem_close fails with bad params.
  * Feature: gem_core
  * Run type: BAT
+ * Test category: GEM_Legacy
  *
  * SUBTEST: create-close
  * Description: Verify basic functionality of gem_create and gem_close.
  * Feature: gem_core
  * Run type: BAT
+ * Test category: GEM_Legacy
  *
  * SUBTEST: create-fd-close
  * Description: Verify that closing drm driver is possible with opened gem object.
  * Feature: gem_core
  * Run type: BAT
+ * Test category: GEM_Legacy
  *
  * SUBTEST: multigpu-create-close
  * Description: Verify basic functionality of gem_create and gem_close on multi-GPU.
  * Feature: gem_core, multigpu
  * Run type: FULL
+ * Test category: MultiGPU
  */
 
 IGT_TEST_DESCRIPTION("Tests basic gem_create and gem_close IOCTLs");
diff --git a/tests/i915/gem_blits.c b/tests/i915/gem_blits.c
index acc1adc165f3..681fe046665b 100644
--- a/tests/i915/gem_blits.c
+++ b/tests/i915/gem_blits.c
@@ -30,8 +30,12 @@
 #include "i915/i915_blt.h"
 /**
  * TEST: gem blits
+ * Category: Infrastructure
  * Feature: blitter
+ * Functionality: command streamer
  * Run type: FULL
+ * Sub-category: HW
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic
  */
diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
index 38d66f8f292a..34f6c5984b0b 100644
--- a/tests/i915/gem_busy.c
+++ b/tests/i915/gem_busy.c
@@ -32,19 +32,25 @@
 #include "igt_vgem.h"
 /**
  * TEST: gem busy
+ * Category: Desktop client
  * Description: Basic check of busy-ioctl ABI.
  * Feature: cmd_submission
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: busy
  * Description: Basic test to check busyness of each engine.
+ * Functionality: semaphore
  * Run type: FULL
  *
  * SUBTEST: close-race
  * Description: Test to check race condition by randomly closing the handle using gem_close.
+ * Functionality: semaphore
  * Run type: FULL
  *
  * SUBTEST: extended
  * Description: Extended test to check busyness of dwstore-capable engines.
+ * Functionality: semaphore
  * Run type: FULL
  *
  * SUBTEST: hang
@@ -61,6 +67,7 @@
  * Description:
  *   Extended test to check busyness of dwstore-capable engines while doing parallel
  *   execution.
+ * Functionality: semaphore
  * Run type: FULL
  *
  * SUBTEST: semaphore
diff --git a/tests/i915/gem_caching.c b/tests/i915/gem_caching.c
index d24e6cce059b..7af427d7e48c 100644
--- a/tests/i915/gem_caching.c
+++ b/tests/i915/gem_caching.c
@@ -42,9 +42,13 @@
 #include "i915/i915_blt.h"
 /**
  * TEST: gem caching
+ * Category: Desktop client
  * Description: Test snoop consistency when touching partial cachelines.
  * Feature: caching
+ * Functionality: data coherency
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: read-writes
  *
diff --git a/tests/i915/gem_close.c b/tests/i915/gem_close.c
index 212fd8e9062a..20aff600d595 100644
--- a/tests/i915/gem_close.c
+++ b/tests/i915/gem_close.c
@@ -27,8 +27,12 @@
 #include "igt_types.h"
 /**
  * TEST: gem close
+ * Category: Infrastructure
  * Feature: mapping
+ * Functionality: driver handler
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic
  *
diff --git a/tests/i915/gem_close_race.c b/tests/i915/gem_close_race.c
index 802fa3abbe6a..e02cea17ccad 100644
--- a/tests/i915/gem_close_race.c
+++ b/tests/i915/gem_close_race.c
@@ -50,12 +50,16 @@
 #include "igt_device_scan.h"
 /**
  * TEST: gem close race
+ * Category: Infrastructure
  * Description: Test try to race gem_close against workload submission.
+ * Functionality: driver handler
+ * Sub-category: i915
  *
  * SUBTEST: basic-process
  * Description: Basic workload submission.
  * Feature: synchronization
  * Run type: BAT
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic-threads
  * Description:
@@ -63,6 +67,7 @@
  *   continuous workload with minimum timeout.
  * Feature: synchronization
  * Run type: BAT
+ * Test category: GEM_Legacy
  *
  * SUBTEST: contexts
  * Description:
@@ -82,11 +87,13 @@
  * Description: Basic workload submission on multi-GPU machine.
  * Feature: multigpu, synchronization
  * Run type: FULL
+ * Test category: MultiGPU
  *
  * SUBTEST: multigpu-basic-threads
  * Description: Run basic-threads race on multi-GPU machine.
  * Feature: multigpu, synchronization
  * Run type: FULL
+ * Test category: MultiGPU
  *
  * SUBTEST: process-exit
  * Description: Test try to race gem_close against submission of continuous workload.
diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c
index fc99189499b8..ed79031f59de 100644
--- a/tests/i915/gem_create.c
+++ b/tests/i915/gem_create.c
@@ -67,50 +67,89 @@
  * Description:
  *   Ensure that basic gem_create and gem_create_ext works and that invalid input combinations
  *   are rejected.
- * Feature: mapping
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: busy-create
+ * Category: Infrastructure
  * Description: Create buffer objects while GPU is busy.
+ * Feature: mapping
+ * Functionality: buffer management
+ * Sub-category: i915
  *
  * SUBTEST: create-clear
+ * Category: Infrastructure
  * Description: Verify that all new objects are clear.
+ * Feature: mapping
+ * Functionality: buffer management
+ * Sub-category: i915
  *
  * SUBTEST: create-ext-cpu-access-big
  * Description:
  *   Verify the extreme cases with very large objects and.
  *   I915_GEM_CREATE_EXT_FLAG_NEEDS_CPU_ACCESS
+ * Feature: mapping
  *
  * SUBTEST: create-ext-cpu-access-sanity-check
  * Description:
  *   Verify the basic functionally and expected ABI contract around.
  *   I915_GEM_CREATE_EXT_FLAG_NEEDS_CPU_ACCESS
+ * Feature: mapping
  *
  * SUBTEST: create-ext-placement-all
+ * Category: Infrastructure
  * Description: Create objects in every memory region using create_ext.
+ * Feature: mapping
+ * Functionality: buffer management
+ * Sub-category: i915
  *
  * SUBTEST: create-ext-placement-each
+ * Category: Infrastructure
  * Description: Create one object with memory pieces in each memory region using create_ext.
+ * Feature: mapping
+ * Functionality: buffer management
+ * Sub-category: i915
  *
  * SUBTEST: create-ext-placement-sanity-check
+ * Category: Infrastructure
  * Description: Exercise create_ext placements extension.
+ * Feature: mapping
+ * Functionality: buffer management
+ * Sub-category: i915
  *
  * SUBTEST: create-invalid-size
+ * Category: Infrastructure
  * Description: Try to create a gem object of invalid size 0 and check if ioctl returns error.
+ * Feature: mapping
+ * Functionality: buffer management
+ * Sub-category: i915
  *
  * SUBTEST: create-massive
+ * Category: Infrastructure
  * Description: Exercise creation of buffer object with impossible size and check for the expected error.
+ * Feature: mapping
+ * Functionality: buffer management
+ * Sub-category: i915
  *
  * SUBTEST: create-size-update
+ * Category: Infrastructure
  * Description: Try to create a gem object with size 15 and check actual created size.
+ * Feature: mapping
+ * Functionality: buffer management
+ * Sub-category: i915
  *
  * SUBTEST: create-valid-nonaligned
+ * Category: Infrastructure
  * Description:
  *   Try to create an object with non-aligned size, check we got one with size aligned up to page
  *   size and test we can write into the padded extra memory.
+ * Feature: mapping
+ * Functionality: buffer management
+ * Sub-category: i915
  *
  * SUBTEST: hog-create
  * Description: Create buffer objects while GPU is busy.
+ * Feature: mapping
  */
 
 IGT_TEST_DESCRIPTION("Ensure that basic gem_create and gem_create_ext works"
diff --git a/tests/i915/gem_cs_tlb.c b/tests/i915/gem_cs_tlb.c
index ab09efa251b3..3f285f42c1ac 100644
--- a/tests/i915/gem_cs_tlb.c
+++ b/tests/i915/gem_cs_tlb.c
@@ -54,9 +54,13 @@
 #include "igt.h"
 /**
  * TEST: gem cs tlb
+ * Category: Infrastructure
  * Description: Check whether we correctly invalidate the cs tlb.
  * Feature: mapping
+ * Functionality: command submission
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: engines
  */
diff --git a/tests/i915/gem_eio.c b/tests/i915/gem_eio.c
index 4aef96d18e8c..3b7d02f74294 100644
--- a/tests/i915/gem_eio.c
+++ b/tests/i915/gem_eio.c
@@ -54,96 +54,158 @@
 #include "sw_sync.h"
 /**
  * TEST: gem eio
+ * Category: Infrastructure
  * Description: Test that specific ioctls report a wedged GPU (EIO).
  * Run type: FULL
+ * Sub-category: i915
  *
  * SUBTEST: banned
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  *
  * SUBTEST: context-create
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  *
  * SUBTEST: create
  * Description: Validate i915_gem_create_ioctl, while gpu is wedged for fb scanout.
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  *
  * SUBTEST: create-ext
  * Description:
  *   Validate i915_gem_create_ext_ioctl and checks if returns clear backing store while gpu is
  *   wedged for fb scanout.
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  *
  * SUBTEST: execbuf
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  *
  * SUBTEST: hibernate
- * Feature: hibernate, reset
+ * Feature:
+ *   hibernate, reset
+ *   suspend
+ * Functionality: Test that specific ioctls report a wedged GPU (EIO) during suspend
+ * Test category: suspend
  *
  * SUBTEST: in-flight-10ms
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  *
  * SUBTEST: in-flight-1us
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  *
  * SUBTEST: in-flight-contexts-10ms
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  *
  * SUBTEST: in-flight-contexts-1us
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  *
  * SUBTEST: in-flight-contexts-immediate
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  *
  * SUBTEST: in-flight-external
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  *
  * SUBTEST: in-flight-immediate
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  *
  * SUBTEST: in-flight-internal-10ms
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  *
  * SUBTEST: in-flight-internal-1us
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  *
  * SUBTEST: in-flight-internal-immediate
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  *
  * SUBTEST: in-flight-suspend
- * Feature: reset
+ * Feature:
+ *   reset
+ *   suspend
+ * Functionality: Test that specific ioctls report a wedged GPU (EIO) during suspend
+ * Test category: suspend
  *
  * SUBTEST: kms
  * Feature: kms_gem_interop, reset
  *
  * SUBTEST: reset-stress
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  *
  * SUBTEST: suspend
- * Feature: reset, suspend
+ * Feature:
+ *   reset, suspend
+ *   suspend
+ * Functionality: Test that specific ioctls report a wedged GPU (EIO) during suspend
+ * Test category: suspend
  *
  * SUBTEST: throttle
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  *
  * SUBTEST: unwedge-stress
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  *
  * SUBTEST: wait-10ms
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  *
  * SUBTEST: wait-1us
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  *
  * SUBTEST: wait-immediate
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  *
  * SUBTEST: wait-wedge-10ms
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  *
  * SUBTEST: wait-wedge-1us
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  *
  * SUBTEST: wait-wedge-immediate
  * Feature: reset
+ * Functionality: reset
+ * Test category: GEM_Legacy
  */
 
 IGT_TEST_DESCRIPTION("Test that specific ioctls report a wedged GPU (EIO).");
diff --git a/tests/i915/gem_exercise_blt.c b/tests/i915/gem_exercise_blt.c
index af86d5edc2ab..3287ced76a59 100644
--- a/tests/i915/gem_exercise_blt.c
+++ b/tests/i915/gem_exercise_blt.c
@@ -15,12 +15,17 @@
  * Description: Exercise blitter commands
  * Feature: blitter
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: fast-copy
- * Description: Check fast-copy blit
+ * Description:
+ *   Check fast-copy blit
+ *   blitter
  *
  * SUBTEST: fast-copy-emit
- * Description: Check multiple fast-copy in one batch
+ * Description:
+ *   Check multiple fast-copy in one batch
+ *   blitter
  */
 
 IGT_TEST_DESCRIPTION("Exercise blitter commands");
diff --git a/tests/i915/gem_flink_basic.c b/tests/i915/gem_flink_basic.c
index 7feabf61a303..fd99ee5538e4 100644
--- a/tests/i915/gem_flink_basic.c
+++ b/tests/i915/gem_flink_basic.c
@@ -40,24 +40,36 @@
 #include "igt_types.h"
 /**
  * TEST: gem flink basic
+ * Category: Desktop client
  * Description: Tests for flink - a way to export a gem object by name
  * Feature: xorg_dri2
- * Run type: BAT
+ * Functionality: buffer management
+ * Sub-category: DRM
  *
  * SUBTEST: bad-flink
  * Description: Verify that GEM_FLINK ioctl with invalid gem object fails.
+ * Run type: BAT
+ * Test category: GEM_Legacy
  *
  * SUBTEST: bad-open
  * Description: Verify that GEM_OPEN ioctl with invalid flink name fails.
+ * Run type: BAT
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic
  * Description: Check if gem object can be exported to global namespace and then opened.
+ * Run type: BAT
+ * Test category: GEM_Legacy
  *
  * SUBTEST: double-flink
  * Description: Tests that multiple flinks for the same gem object share the same name.
+ * Run type: BAT
+ * Test category: GEM_Legacy
  *
  * SUBTEST: flink-lifetime
  * Description: Tests flink lifetime by referencing from multiple descriptors.
+ * Run type: BAT
+ * Test category: GEM_Legacy
  */
 
 IGT_TEST_DESCRIPTION("Tests for flink - a way to export a gem object by name");
diff --git a/tests/i915/gem_flink_race.c b/tests/i915/gem_flink_race.c
index 5ebf1969b992..a9177ce1b775 100644
--- a/tests/i915/gem_flink_race.c
+++ b/tests/i915/gem_flink_race.c
@@ -37,9 +37,13 @@
 #include "igt_stats.h"
 /**
  * TEST: gem flink race
+ * Category: Desktop client
  * Description: Check for flink/open vs. gem close races.
  * Feature: xorg_dri2
+ * Functionality: buffer management
  * Run type: FULL
+ * Sub-category: DRM
+ * Test category: GEM_Legacy
  *
  * SUBTEST: flink_close
  *
diff --git a/tests/i915/gem_gpgpu_fill.c b/tests/i915/gem_gpgpu_fill.c
index f350e9fbb6d0..e79df7409c01 100644
--- a/tests/i915/gem_gpgpu_fill.c
+++ b/tests/i915/gem_gpgpu_fill.c
@@ -50,8 +50,12 @@
 #include "i915/intel_memory_region.h"
 /**
  * TEST: gem gpgpu fill
+ * Category: Server
  * Feature: compute
+ * Functionality: command submission
  * Run type: FULL
+ * Sub-category: Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic
  */
diff --git a/tests/i915/gem_linear_blits.c b/tests/i915/gem_linear_blits.c
index 4c3576503ca3..40ab4fab3df4 100644
--- a/tests/i915/gem_linear_blits.c
+++ b/tests/i915/gem_linear_blits.c
@@ -51,20 +51,26 @@
 #include "i915/i915_blt.h"
 /**
  * TEST: gem linear blits
+ * Category: Infrastructure
  * Description: Test doing many blits with a working set larger than the aperture size.
  * Feature: blitter
+ * Functionality: command submission
+ * Sub-category: i915
  *
  * SUBTEST: basic
  * Description: Basic blitter functionality check with 2 buffers
  * Run type: BAT
+ * Test category: GEM_Legacy
  *
  * SUBTEST: interruptible
  * Description: Test with interrupts in between the parent process
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: normal
  * Description: The intent is to push beyond the working GTT size to force the driver to rebind the buffers
  * Run type: FULL
+ * Test category: GEM_Legacy
  */
 
 IGT_TEST_DESCRIPTION("Test doing many blits with a working set larger than the"
diff --git a/tests/i915/gem_lmem_evict.c b/tests/i915/gem_lmem_evict.c
index e40eab2d2914..54277e11dac7 100644
--- a/tests/i915/gem_lmem_evict.c
+++ b/tests/i915/gem_lmem_evict.c
@@ -12,6 +12,7 @@
  * Description: Force tiny lmem size for easily testing eviction scenarios.
  * Feature: local_memory
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: dontneed-evict-race
  * Description: Regression test to verify that madvise will sync against busy dma-resv object for lmem
diff --git a/tests/i915/gem_lmem_swapping.c b/tests/i915/gem_lmem_swapping.c
index f6a1c0082c78..014068da79f3 100644
--- a/tests/i915/gem_lmem_swapping.c
+++ b/tests/i915/gem_lmem_swapping.c
@@ -26,8 +26,12 @@
 #include "i915/intel_mocs.h"
 /**
  * TEST: gem lmem swapping
+ * Category: Server
  * Description: Exercise local memory swapping.
  * Feature: local_memory
+ * Functionality: buffer management
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic
  * Description: Exercise local memory swapping to system memory
diff --git a/tests/i915/gem_madvise.c b/tests/i915/gem_madvise.c
index 17653cc4ad53..139376d1b3e3 100644
--- a/tests/i915/gem_madvise.c
+++ b/tests/i915/gem_madvise.c
@@ -40,8 +40,12 @@
 #include "i915/gem_create.h"
 /**
  * TEST: gem madvise
+ * Category: Desktop client
  * Description: Checks that the kernel reports EFAULT when trying to use purged bo.
+ * Functionality: buffer management
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: dontneed-after-mmap
  * Description:
diff --git a/tests/i915/gem_mmap_offset.c b/tests/i915/gem_mmap_offset.c
index afabe2426291..f6d3374dd6e8 100644
--- a/tests/i915/gem_mmap_offset.c
+++ b/tests/i915/gem_mmap_offset.c
@@ -39,9 +39,13 @@
 #include "igt_x86.h"
 /**
  * TEST: gem mmap offset
+ * Category: Infrastructure
  * Description: Basic MMAP_OFFSET IOCTL tests for mem regions
  * Feature: mapping
+ * Functionality: memory management
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: bad-extensions
  *
diff --git a/tests/i915/gem_pipe_control_store_loop.c b/tests/i915/gem_pipe_control_store_loop.c
index 5e6ef049085b..986dbf673164 100644
--- a/tests/i915/gem_pipe_control_store_loop.c
+++ b/tests/i915/gem_pipe_control_store_loop.c
@@ -45,9 +45,13 @@
 #include "igt.h"
 /**
  * TEST: gem pipe control store loop
+ * Category: Desktop client
  * Description: Test (TLB-)Coherency of pipe_control QW writes.
  * Feature: cmd_submission
+ * Functionality: command submission
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: fresh-buffer
  * Description: Checks tlb consistency of the pipe_control with fresh buffer.
diff --git a/tests/i915/gem_ppgtt.c b/tests/i915/gem_ppgtt.c
index 368f8b17db75..6a0512ab6010 100644
--- a/tests/i915/gem_ppgtt.c
+++ b/tests/i915/gem_ppgtt.c
@@ -50,15 +50,21 @@
  * Feature: mapping
  *
  * SUBTEST: flink-and-close-vma-leak
+ * Category: Desktop client
  * Feature: mapping, xorg_dri2
+ * Functionality: buffer management
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: shrink-vs-evict-any
  * Description: Regression test to verify GTT eviction can't randomly fail due to object lock contention
  * Feature: mapping
+ * Test category: GEM_Legacy
  *
  * SUBTEST: shrink-vs-evict-pinned
  * Description: Regression test to verify GTT eviction can't randomly fail due to object lock contention
  * Feature: mapping
+ * Test category: GEM_Legacy
  */
 
 #define WIDTH 512
diff --git a/tests/i915/gem_request_retire.c b/tests/i915/gem_request_retire.c
index 9e074706d259..9814b435d937 100644
--- a/tests/i915/gem_request_retire.c
+++ b/tests/i915/gem_request_retire.c
@@ -51,9 +51,13 @@
 #include "igt_types.h"
 /**
  * TEST: gem request retire
+ * Category: Infrastructure
  * Description: Collection of tests targeting request retirement code paths.
  * Feature: cmd_submission
+ * Functionality: command submission
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: retire-vma-not-inactive
  */
diff --git a/tests/i915/gem_ringfill.c b/tests/i915/gem_ringfill.c
index 451876526e9a..d350cd7fea57 100644
--- a/tests/i915/gem_ringfill.c
+++ b/tests/i915/gem_ringfill.c
@@ -43,14 +43,18 @@
 #include <sys/ioctl.h>
 /**
  * TEST: gem ringfill
+ * Category: Infrastructure
  * Description:
  *   Exercise many tiny batchbuffer operations, in the hope of catching failure to manage the ring
  *   properly near full.
+ * Sub-category: i915
  *
  * SUBTEST: basic-all
  * Description: Basic check to fill the ring upto maximum on all engines simultaneously.
  * Feature: cmd_submission
+ * Functionality: command submission
  * Run type: BAT
+ * Test category: GEM_Legacy
  *
  * SUBTEST: engines-S3
  * Description: Handle a full ring across suspend cycle.
@@ -65,7 +69,9 @@
  * SUBTEST: engines-basic
  * Description: Basic check how the driver handles a full ring.
  * Feature: cmd_submission, multitile
+ * Functionality: Test spamming ring with contexts
  * Run type: FULL
+ * Test category: MultiTile
  *
  * SUBTEST: engines-bomb
  * Description:
@@ -114,7 +120,9 @@
  * SUBTEST: legacy-basic
  * Description: Basic check how the driver handles a full ring - on legacy ring.
  * Feature: cmd_submission, multitile
+ * Functionality: Test spamming ring with contexts - legacy path
  * Run type: FULL
+ * Test category: MultiTile
  *
  * SUBTEST: legacy-bomb
  * Description:
diff --git a/tests/i915/gem_shrink.c b/tests/i915/gem_shrink.c
index a65792c84137..79301754babc 100644
--- a/tests/i915/gem_shrink.c
+++ b/tests/i915/gem_shrink.c
@@ -139,6 +139,10 @@
  * SUBTEST: pwrite-userptr-dirty
  *
  * SUBTEST: reclaim
+ * Category: Desktop client
+ * Functionality: buffer management
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  */
 
 #ifndef MADV_FREE
diff --git a/tests/i915/gem_softpin.c b/tests/i915/gem_softpin.c
index 27e5781b9b73..6bea75d1fe37 100644
--- a/tests/i915/gem_softpin.c
+++ b/tests/i915/gem_softpin.c
@@ -33,116 +33,183 @@
 #include "intel_allocator.h"
 /**
  * TEST: gem softpin
+ * Category: Infrastructure
  * Description:
  *   Tests softpin feature with normal usage, invalid inputs scenarios and couple of eviction
  *   tests which copy buffers between CPU and GPU.
- * Feature: mapping
+ * Sub-category: i915
  *
  * SUBTEST: 32b-excludes-last-page
  * Description: Check the last 32b page is excluded.
+ * Feature: mapping
+ * Functionality: command submission
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: allocator-basic
  * Description: Check that we can place objects at start/end of the GTT using the allocator.
+ * Feature: mapping
+ * Functionality: command submission
  * Run type: BAT
+ * Test category: GEM_Legacy
  *
  * SUBTEST: allocator-basic-reserve
  * Description: Check that if we can reserve a space for an object starting from a given offset.
+ * Feature: mapping
+ * Functionality: command submission
  * Run type: BAT
+ * Test category: GEM_Legacy
  *
  * SUBTEST: allocator-evict
  * Description: Exercise eviction with softpinning.
+ * Feature: mapping
+ * Functionality: command submission
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: allocator-fork
  * Description: Check if multiple processes can use alloctor.
+ * Feature: mapping
+ * Functionality: command submission
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: allocator-nopin
  * Description: Check that we can combine manual placement with automatic GTT placement.
+ * Feature: mapping
+ * Functionality: command submission
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: allocator-nopin-reserve
  * Description:
  *   Check that we can combine manual placement with automatic GTT placement and
  *   reserves/unreserves space for objects.
+ * Feature: mapping
+ * Functionality: command submission
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: evict-active
  * Description: Check eviction with active bo.
+ * Feature: mapping
+ * Functionality: command submission
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: evict-active-interruptible
  * Description: Check eviction with active bo with interrupts.
+ * Feature: mapping
+ * Functionality: command submission
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: evict-hang
  * Description: Check eviction of softpinned bo with hung batch.
+ * Feature: mapping
  * Run type: FULL
  *
  * SUBTEST: evict-prime
  * Description: Check eviction of vma on importing prime fd in reopened drm fds
+ * Feature: mapping
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: evict-prime-sanity-check
  * Description: Check eviction of vma on importing prime fd in reopened drm fd in single thread
+ * Feature: mapping
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: evict-single-offset
  * Description: Use same offset for all engines and for different handles.
+ * Feature: mapping
+ * Functionality: command submission
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: evict-snoop
  * Description: Check eviction against snooping.
+ * Feature: mapping
  * Run type: FULL
  *
  * SUBTEST: evict-snoop-interruptible
  * Description: Check eviction against snooping with interrupts.
+ * Feature: mapping
  * Run type: FULL
  *
  * SUBTEST: full
  * Description: Check the total occupancy by using pad-to-size to fill the entire GTT.
+ * Feature: mapping
+ * Functionality: command submission
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: invalid
  * Description: Check that invalid inputs are handled correctly.
+ * Feature: mapping
+ * Functionality: command submission
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: noreloc
  * Description: Check that noreloc support works.
+ * Feature: mapping
+ * Functionality: command submission
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: noreloc-S3
  * Description: Check noreloc survives after suspend to RAM/resume cycle.
+ * Feature: mapping
  * Run type: FULL
  *
  * SUBTEST: noreloc-S4
  * Description: Check noreloc survives after suspend to disk/resume cycle.
+ * Feature: mapping
  * Run type: FULL
  *
  * SUBTEST: noreloc-interruptible
  * Description: Check noreloc support with interruptible.
+ * Feature: mapping
+ * Functionality: command submission
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: overlap
  * Description: Check all the possible pages aligned overlaps.
+ * Feature: mapping
+ * Functionality: command submission
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: reverse
  * Description: Check that if the user demands the vma will be swapped.
+ * Feature: mapping
+ * Functionality: command submission
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: safe-alignment
  * Description: Check start offset and alignment detection.
+ * Feature: mapping
+ * Functionality: command submission
  * Run type: BAT
+ * Test category: GEM_Legacy
  *
  * SUBTEST: softpin
  * Description: Check softpinning of a gem buffer object.
+ * Feature: mapping
+ * Functionality: command submission
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: zero
  * Description: Check full placement control under full-ppGTT.
+ * Feature: mapping
+ * Functionality: command submission
  * Run type: FULL
+ * Test category: GEM_Legacy
  */
 
 IGT_TEST_DESCRIPTION("Tests softpin feature with normal usage, invalid inputs"
diff --git a/tests/i915/gem_spin_batch.c b/tests/i915/gem_spin_batch.c
index 0a6c088da630..cd828beb26c2 100644
--- a/tests/i915/gem_spin_batch.c
+++ b/tests/i915/gem_spin_batch.c
@@ -28,42 +28,79 @@
 /**
  * TEST: gem spin batch
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: engines
+ * Category: Infrastructure
  * Feature: context, igt_core
+ * Functionality: dummy workload
+ * Sub-category: IGT Lib
  *
  * SUBTEST: legacy
+ * Category: Infrastructure
  * Feature: context, igt_core
+ * Functionality: dummy workload
+ * Sub-category: IGT Lib
  *
  * SUBTEST: legacy-resubmit
+ * Category: Infrastructure
  * Feature: context, igt_core
+ * Functionality: dummy workload
+ * Sub-category: IGT Lib
  *
  * SUBTEST: legacy-resubmit-new
+ * Category: Infrastructure
  * Feature: context, igt_core, multictx
+ * Functionality: dummy workload
+ * Sub-category: IGT Lib
  *
  * SUBTEST: resubmit
+ * Category: Infrastructure
  * Feature: context, igt_core
+ * Functionality: dummy workload
+ * Sub-category: IGT Lib
  *
  * SUBTEST: resubmit-all
+ * Category: Infrastructure
  * Feature: context, igt_core, multictx
+ * Functionality: dummy workload
+ * Sub-category: IGT Lib
  *
  * SUBTEST: resubmit-new
+ * Category: Infrastructure
  * Feature: context, igt_core, multictx
+ * Functionality: dummy workload
+ * Sub-category: IGT Lib
  *
  * SUBTEST: resubmit-new-all
+ * Category: Infrastructure
  * Feature: context, igt_core, multictx
+ * Functionality: dummy workload
+ * Sub-category: IGT Lib
  *
  * SUBTEST: spin-all
+ * Category: Infrastructure
  * Feature: igt_core, multictx
+ * Functionality: dummy workload
+ * Sub-category: IGT Lib
  *
  * SUBTEST: spin-all-new
+ * Category: Infrastructure
  * Feature: igt_core, multictx
+ * Functionality: dummy workload
+ * Sub-category: IGT Lib
  *
  * SUBTEST: spin-each
+ * Category: Infrastructure
  * Feature: igt_core, multictx
+ * Functionality: dummy workload
+ * Sub-category: IGT Lib
  *
  * SUBTEST: user-each
+ * Category: Infrastructure
  * Feature: igt_core, multictx
+ * Functionality: dummy workload
+ * Sub-category: IGT Lib
  */
 
 #define MAX_ERROR 5 /* % */
diff --git a/tests/i915/gem_sync.c b/tests/i915/gem_sync.c
index 1c7e51a92bfa..9a855a221654 100644
--- a/tests/i915/gem_sync.c
+++ b/tests/i915/gem_sync.c
@@ -57,29 +57,43 @@
  * Run type: FULL
  *
  * SUBTEST: basic-all
+ * Category: Infrastructure
  * Description: Basic test to wait upon a batch on all rings.
  * Feature: synchronization
+ * Functionality: semaphore
  * Run type: BAT
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic-each
  * Description: Check synchronisation of ring.
  * Feature: multitile, synchronization
+ * Functionality: Exercise all physical engine selection and legacy rings
  * Run type: BAT
+ * Test category: MultiTile
  *
  * SUBTEST: basic-many-each
  * Description: Create race condition and see if we can catch interrupts.
  * Feature: multitile, synchronization
+ * Functionality: Basic check of ring to ring write synchronisation
  * Run type: FULL
+ * Test category: MultiTile
  *
  * SUBTEST: basic-store-all
+ * Category: Infrastructure
  * Description: Basic version of store synchronisation test.
  * Feature: synchronization
+ * Functionality: semaphore
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic-store-each
  * Description: Check that store synchronisation works.
  * Feature: multitile, synchronization
+ * Functionality: Basic check of ring to ring write, store synchronisation
  * Run type: FULL
+ * Test category: MultiTile
  *
  * SUBTEST: default
  * Description: Check synchronisation of rings on each engine.
diff --git a/tests/i915/gem_unref_active_buffers.c b/tests/i915/gem_unref_active_buffers.c
index 90a63e8f9acf..badded1f71a6 100644
--- a/tests/i915/gem_unref_active_buffers.c
+++ b/tests/i915/gem_unref_active_buffers.c
@@ -43,9 +43,13 @@
 #include "i915/gem_create.h"
 /**
  * TEST: gem unref active buffers
+ * Category: Infrastructure
  * Description: Test unreferencing of active buffers.
  * Feature: cmd_submission
+ * Functionality: buffer management
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST:
  */
diff --git a/tests/i915/gem_userptr_blits.c b/tests/i915/gem_userptr_blits.c
index 4df604d6dcd6..e9235a6898d5 100644
--- a/tests/i915/gem_userptr_blits.c
+++ b/tests/i915/gem_userptr_blits.c
@@ -81,7 +81,11 @@
  * Feature: userptr
  *
  * SUBTEST: create-destroy-sync
+ * Category: Server
  * Feature: userptr
+ * Functionality: buffer management
+ * Sub-category: Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: create-destroy-unsync
  * Feature: userptr
@@ -195,17 +199,29 @@
  * Feature: userptr
  *
  * SUBTEST: huge-split
+ * Category: Server
  * Feature: userptr
+ * Functionality: buffer management
+ * Sub-category: Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: input-checking
+ * Category: Server
  * Feature: userptr
+ * Functionality: buffer management
+ * Sub-category: Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: invalid-mmap-offset-unsync
  * Description: Verify unsynchronized userptr on mmap-offset mappings fails
  * Feature: userptr
  *
  * SUBTEST: invalid-null-pointer
+ * Category: Server
  * Feature: userptr
+ * Functionality: buffer management
+ * Sub-category: Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: major-normal-sync
  * Feature: userptr
@@ -260,14 +276,26 @@
  * Feature: userptr
  *
  * SUBTEST: mmap-offset-banned
+ * Category: Server
  * Description: Verify mmap_offset to userptr is banned
  * Feature: userptr
+ * Functionality: buffer management
+ * Sub-category: Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: nohangcheck
+ * Category: Server
  * Feature: userptr
+ * Functionality: buffer management
+ * Sub-category: Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: probe
+ * Category: Server
  * Feature: userptr
+ * Functionality: buffer management
+ * Sub-category: Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: process-exit
  * Feature: userptr
@@ -285,22 +313,46 @@
  * Feature: userptr
  *
  * SUBTEST: sd-probe
+ * Category: Server
  * Feature: userptr
+ * Functionality: buffer management
+ * Sub-category: Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: set-cache-level
+ * Category: Server
  * Feature: userptr
+ * Functionality: buffer management
+ * Sub-category: Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: stress-mm
+ * Category: Server
  * Feature: userptr
+ * Functionality: buffer management
+ * Sub-category: Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: stress-mm-invalidate-close
+ * Category: Server
  * Feature: userptr
+ * Functionality: buffer management
+ * Sub-category: Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: stress-mm-invalidate-close-overlap
+ * Category: Server
  * Feature: userptr
+ * Functionality: buffer management
+ * Sub-category: Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: stress-purge
+ * Category: Server
  * Feature: userptr
+ * Functionality: buffer management
+ * Sub-category: Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: swapping-normal-sync
  * Feature: userptr
@@ -315,16 +367,32 @@
  * Feature: userptr
  *
  * SUBTEST: sync-overlap
+ * Category: Server
  * Feature: userptr
+ * Functionality: buffer management
+ * Sub-category: Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: sync-unmap
+ * Category: Server
  * Feature: userptr
+ * Functionality: buffer management
+ * Sub-category: Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: sync-unmap-after-close
+ * Category: Server
  * Feature: userptr
+ * Functionality: buffer management
+ * Sub-category: Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: sync-unmap-cycles
+ * Category: Server
  * Feature: userptr
+ * Functionality: buffer management
+ * Sub-category: Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: unsync-overlap
  * Feature: userptr
@@ -339,13 +407,21 @@
  * Feature: userptr
  *
  * SUBTEST: usage-restrictions
+ * Category: Server
  * Feature: userptr
+ * Functionality: buffer management
+ * Sub-category: Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: userfault
  * Feature: userptr
  *
  * SUBTEST: vma-merge
+ * Category: Server
  * Feature: userptr
+ * Functionality: buffer management
+ * Sub-category: Compute
+ * Test category: GEM_Legacy
  */
 
 #ifndef PAGE_SIZE
diff --git a/tests/i915/gem_vm_create.c b/tests/i915/gem_vm_create.c
index 2b19ca973acc..f24aefdae729 100644
--- a/tests/i915/gem_vm_create.c
+++ b/tests/i915/gem_vm_create.c
@@ -29,7 +29,11 @@
 #include "igt_dummyload.h"
 /**
  * TEST: gem vm create
+ * Category: Server
+ * Functionality: context management
  * Run type: FULL
+ * Sub-category: Compute
+ * Test category: GEM_Legacy
  *
  * SUBTEST: create-ext
  * Feature: mapping
diff --git a/tests/i915/gem_wait.c b/tests/i915/gem_wait.c
index 874ccd87eee3..40e548579226 100644
--- a/tests/i915/gem_wait.c
+++ b/tests/i915/gem_wait.c
@@ -33,8 +33,12 @@
 #include "igt_vgem.h"
 /**
  * TEST: gem wait
+ * Category: Infrastructure
  * Description: Tests the GEM_WAIT ioctl
  * Feature: synchronization
+ * Functionality: semaphore
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: await
  * Description: Verify GEM_WAIT functionality in await mode.
diff --git a/tests/i915/gem_workarounds.c b/tests/i915/gem_workarounds.c
index b635fd342ac5..02c8977d5cb6 100644
--- a/tests/i915/gem_workarounds.c
+++ b/tests/i915/gem_workarounds.c
@@ -34,16 +34,24 @@
 #include "igt_types.h"
 /**
  * TEST: gem workarounds
+ * Category: Infrastructure
  * Run type: FULL
+ * Sub-category: HW
  *
  * SUBTEST: basic-read
  * Feature: workarounds
+ * Functionality: context management
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic-read-context
  * Feature: workarounds
+ * Functionality: context management
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic-read-fd
  * Feature: workarounds
+ * Functionality: context management
+ * Test category: GEM_Legacy
  *
  * SUBTEST: hibernate-resume
  * Feature: hibernate, workarounds
@@ -56,21 +64,39 @@
  *
  * SUBTEST: reset
  * Feature: workarounds
+ * Functionality: context management
+ * Test category: GEM_Legacy
  *
  * SUBTEST: reset-context
  * Feature: workarounds
+ * Functionality: context management
+ * Test category: GEM_Legacy
  *
  * SUBTEST: reset-fd
  * Feature: workarounds
+ * Functionality: context management
+ * Test category: GEM_Legacy
  *
  * SUBTEST: suspend-resume
- * Feature: suspend, workarounds
+ * Feature:
+ *   suspend, workarounds
+ *   suspend
+ * Functionality: Test to verify gem WA registers during suspend-resume
+ * Test category: suspend
  *
  * SUBTEST: suspend-resume-context
- * Feature: suspend, workarounds
+ * Feature:
+ *   suspend, workarounds
+ *   suspend
+ * Functionality: Test to verify gem WA registers during suspend-resume
+ * Test category: suspend
  *
  * SUBTEST: suspend-resume-fd
- * Feature: suspend, workarounds
+ * Feature:
+ *   suspend, workarounds
+ *   suspend
+ * Functionality: Test to verify gem WA registers during suspend-resume
+ * Test category: suspend
  */
 
 #define PAGE_SIZE 4096
diff --git a/tests/i915/i915_getparams_basic.c b/tests/i915/i915_getparams_basic.c
index e026aad565ff..74ccaf4d35f0 100644
--- a/tests/i915/i915_getparams_basic.c
+++ b/tests/i915/i915_getparams_basic.c
@@ -32,9 +32,13 @@
 #include <i915_drm.h>
 /**
  * TEST: i915 getparams basic
+ * Category: Infrastructure
  * Description: Tests the export of parameters via DRM_IOCTL_I915_GETPARAM
  * Feature: gem_core
+ * Functionality: device topology
  * Run type: BAT
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: basic-eu-total
  * Description: Examine the export of EU_TOTAL parameter
diff --git a/tests/i915/i915_hangman.c b/tests/i915/i915_hangman.c
index ef45b25adacd..fc46bd29764b 100644
--- a/tests/i915/i915_hangman.c
+++ b/tests/i915/i915_hangman.c
@@ -42,43 +42,65 @@
 #include "sw_sync.h"
 /**
  * TEST: i915 hangman
+ * Category: Server
  * Description: Tests for hang detection and recovery
  * Feature: reset
+ * Functionality: error handling
+ * Sub-category: debugger
+ * Test category: GEM_Legacy
  *
  * SUBTEST: detector
- * Description: Check that hang detector works
+ * Description:
+ *   Check that hang detector works
+ *   error detection
  * Run type: FULL
  *
  * SUBTEST: engine-engine-error
- * Description: Per engine hang recovery (invalid CS, engine reset)
+ * Description:
+ *   Per engine hang recovery (invalid CS, engine reset)
+ *   error detection
  * Run type: FULL
  *
  * SUBTEST: engine-engine-hang
- * Description: Per engine hang recovery (spin, engine reset)
+ * Description:
+ *   Per engine hang recovery (spin, engine reset)
+ *   error detection
  * Run type: FULL
  *
  * SUBTEST: engine-error-state-capture
- * Description: Per engine error capture (engine reset)
+ * Description:
+ *   Per engine error capture (engine reset)
+ *   error detection
  * Run type: FULL
  *
  * SUBTEST: error-state-basic
- * Description: Basic error capture
+ * Description:
+ *   Basic error capture
+ *   error detection
  * Run type: BAT
  *
  * SUBTEST: gt-engine-error
- * Description: Per engine hang recovery (invalid CS, GT reset)
+ * Description:
+ *   Per engine hang recovery (invalid CS, GT reset)
+ *   error detection
  * Run type: FULL
  *
  * SUBTEST: gt-engine-hang
- * Description: Per engine hang recovery (spin, GT reset)
+ * Description:
+ *   Per engine hang recovery (spin, GT reset)
+ *   error detection
  * Run type: FULL
  *
  * SUBTEST: gt-error-state-capture
- * Description: Per engine error capture (GT reset)
+ * Description:
+ *   Per engine error capture (GT reset)
+ *   error detection
  * Run type: FULL
  *
  * SUBTEST: hangcheck-unterminated
- * Description: Check that executing unintialised memory causes a hang
+ * Description:
+ *   Check that executing unintialised memory causes a hang
+ *   error detection
  * Run type: FULL
  */
 
diff --git a/tests/i915/i915_hwmon.c b/tests/i915/i915_hwmon.c
index 6d1334172c40..279f6821b0da 100644
--- a/tests/i915/i915_hwmon.c
+++ b/tests/i915/i915_hwmon.c
@@ -13,6 +13,7 @@
  * Description: Tests for i915 hwmon
  * Feature: hwmon
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: hwmon-read
  * Description: Verify we can read all hwmon attributes
diff --git a/tests/i915/i915_module_load.c b/tests/i915/i915_module_load.c
index ae4e01ef18bc..386be7d602dc 100644
--- a/tests/i915/i915_module_load.c
+++ b/tests/i915/i915_module_load.c
@@ -25,7 +25,11 @@
 #include <sys/utsname.h>
 /**
  * TEST: i915 module load
+ * Category: Infrastructure
  * Description: Tests the i915 module loading.
+ * Functionality: driver handler
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: load
  * Description: Check if i915 and friends are not yet loaded, then load them.
diff --git a/tests/i915/i915_pciid.c b/tests/i915/i915_pciid.c
index ae3d2a09d208..c44be56dcbc1 100644
--- a/tests/i915/i915_pciid.c
+++ b/tests/i915/i915_pciid.c
@@ -30,9 +30,13 @@
 #include "intel_chipset.h"
 /**
  * TEST: i915 pciid
+ * Category: Infrastructure
  * Description: Check that igt/i915 know about this PCI-ID
  * Feature: core
+ * Functionality: device management
  * Run type: BAT
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST:
  */
diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
index d9b4cbbfe615..4c0888ecc4c5 100644
--- a/tests/i915/i915_pm_rpm.c
+++ b/tests/i915/i915_pm_rpm.c
@@ -42,9 +42,13 @@
 #include <sys/stat.h>
 /**
  * TEST: i915 pm rpm
+ * Functionality: Validate PCI device D3 state enter-exit scenario using runtime PM
+ * Test category: pm_rpm
  *
  * SUBTEST: basic-pci-d3-state
- * Feature: pm_rpm
+ * Feature:
+ *   pm_rpm
+ *   pm_rpm
  * Run type: BAT
  *
  * SUBTEST: basic-rte
diff --git a/tests/i915/i915_pm_rps.c b/tests/i915/i915_pm_rps.c
index 050d68a16559..0c803eed5fdb 100644
--- a/tests/i915/i915_pm_rps.c
+++ b/tests/i915/i915_pm_rps.c
@@ -52,13 +52,21 @@
  *
  * SUBTEST: engine-order
  * Description: Check if context reuse does not affect waitboosting
- * Feature: pm_rps
+ * Feature:
+ *   pm_rps
+ *   pm_rps
+ * Functionality: Render P-States tests - verify GPU frequency changes
  * Run type: FULL
+ * Test category: pm_rps
  *
  * SUBTEST: fence-order
  * Description: Check if the order of fences does not affect waitboosting
- * Feature: pm_rps, synchronization
+ * Feature:
+ *   pm_rps, synchronization
+ *   pm_rps
+ * Functionality: Render P-States tests - verify GPU frequency changes
  * Run type: FULL
+ * Test category: pm_rps
  *
  * SUBTEST: min-max-config-idle
  * Feature: pm_rps
diff --git a/tests/i915/i915_power.c b/tests/i915/i915_power.c
index 383c212d2807..3675b9d6d75c 100644
--- a/tests/i915/i915_power.c
+++ b/tests/i915/i915_power.c
@@ -12,6 +12,7 @@
  * Description: i915 power measurement tests
  * Feature: hwmon
  * Run type: FULL
+ * Test category: GEM_Legacy
  *
  * SUBTEST: sanity
  * Description: Sanity check gpu power measurement
diff --git a/tests/i915/i915_query.c b/tests/i915/i915_query.c
index 10c6d43fa7fc..de3aa5c24f2d 100644
--- a/tests/i915/i915_query.c
+++ b/tests/i915/i915_query.c
@@ -29,8 +29,12 @@
 #include <limits.h>
 /**
  * TEST: i915 query
+ * Category: Infrastructure
  * Description: Testing the i915 query uAPI.
+ * Functionality: device topology
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: engine-info
  * Description: Positive tests for DRM_I915_QUERY_ENGINE_INFO
diff --git a/tests/i915/i915_suspend.c b/tests/i915/i915_suspend.c
index 448cadfb0804..31456a45d9c8 100644
--- a/tests/i915/i915_suspend.c
+++ b/tests/i915/i915_suspend.c
@@ -46,19 +46,29 @@
 #include "igt_device_scan.h"
 /**
  * TEST: i915 suspend
+ * Test category: suspend
  *
  * SUBTEST: basic-s2idle-without-i915
  * Description: Validate suspend-to-idle without i915 module
- * Feature: suspend
+ * Feature:
+ *   suspend
+ *   suspend
+ * Functionality: Validate suspend-to-idle without i915 module
  * Run type: BAT
  *
  * SUBTEST: basic-s3-without-i915
  * Description: Validate S3 without i915 module
- * Feature: suspend
+ * Feature:
+ *   suspend
+ *   suspend
+ * Functionality: Validate S3 state without i915 module
  * Run type: BAT
  *
  * SUBTEST: debugfs-reader
- * Feature: suspend
+ * Feature:
+ *   suspend
+ *   suspend
+ * Functionality: Test debugfs behavior during suspend to idle
  * Run type: FULL
  *
  * SUBTEST: debugfs-reader-hibernate
@@ -82,7 +92,10 @@
  * Run type: FULL
  *
  * SUBTEST: forcewake
- * Feature: suspend
+ * Feature:
+ *   suspend
+ *   suspend
+ * Functionality: Test to prevent GT from suspend by opening forcewake handle
  * Run type: FULL
  *
  * SUBTEST: forcewake-hibernate
@@ -94,7 +107,10 @@
  * Run type: FULL
  *
  * SUBTEST: sysfs-reader
- * Feature: suspend
+ * Feature:
+ *   suspend
+ *   suspend
+ * Functionality: Test sysfs behavior during suspend to idle
  * Run type: FULL
  *
  * SUBTEST: sysfs-reader-hibernate
diff --git a/tests/i915/sysfs_defaults.c b/tests/i915/sysfs_defaults.c
index 73478559fcda..066532f0a5e2 100644
--- a/tests/i915/sysfs_defaults.c
+++ b/tests/i915/sysfs_defaults.c
@@ -35,8 +35,12 @@
 #include "igt_sysfs.h"
 /**
  * TEST: sysfs defaults
+ * Category: Infrastructure
  * Feature: gem_core
+ * Functionality: driver handler
  * Run type: FULL
+ * Sub-category: i915
+ * Test category: GEM_Legacy
  *
  * SUBTEST: readonly
  */
diff --git a/tests/i915/sysfs_heartbeat_interval.c b/tests/i915/sysfs_heartbeat_interval.c
index 2971acb32811..9161ea5bbf59 100644
--- a/tests/i915/sysfs_heartbeat_interval.c
+++ b/tests/i915/sysfs_heartbeat_interval.c
@@ -45,20 +45,26 @@
  * TEST: sysfs heartbeat interval
  * Feature: SMI, cmd_submission
  * Run type: FULL
+ * Test category: SysMan
  *
  * SUBTEST: idempotent
+ * Functionality: Test to check whether the heartbeat parameter reports the values set.
  *
  * SUBTEST: invalid
+ * Functionality: Test to check if heartbeat parameter rejects any unrepresentable intervals.
  *
  * SUBTEST: long
  *
  * SUBTEST: mixed
+ * Functionality: Run a mixed workload with non-preemptable hogs that exceed the heartbeat, and quicker innocents. Inspect the fence status of each to verify that only the hogs are reset.
  *
  * SUBTEST: nopreempt
+ * Functionality: Test heartbeats with forced preemption disabled.
  *
  * SUBTEST: off
  *
  * SUBTEST: precise
+ * Functionality: Tests the heartbeats with preemption and heartbeat parameter enabled.
  */
 
 #define ATTR "heartbeat_interval_ms"
diff --git a/tests/i915/sysfs_preempt_timeout.c b/tests/i915/sysfs_preempt_timeout.c
index e7c09949930c..b7ec5ec3e4b7 100644
--- a/tests/i915/sysfs_preempt_timeout.c
+++ b/tests/i915/sysfs_preempt_timeout.c
@@ -44,14 +44,18 @@
  * TEST: sysfs preempt timeout
  * Feature: SMI, context
  * Run type: FULL
+ * Test category: SysMan
  *
  * SUBTEST: idempotent
+ * Functionality: Test to check whether the preempt_timeout parameter reports the values set.
  *
  * SUBTEST: invalid
+ * Functionality: Test to check if preempt_timeout parameter rejects any unrepresentable intervals.
  *
  * SUBTEST: off
  *
  * SUBTEST: timeout
+ * Functionality: Test to measure the delay from requestion the preemption to its completion. Send down some non-preemptable workloads and then request a switch to a higher priority context. The HW will not be able to respond, so the kernel will be forced to reset the hog.
  */
 
 #define ATTR "preempt_timeout_ms"
diff --git a/tests/i915/sysfs_timeslice_duration.c b/tests/i915/sysfs_timeslice_duration.c
index 0f4905d8b613..58b0ed3f02d2 100644
--- a/tests/i915/sysfs_timeslice_duration.c
+++ b/tests/i915/sysfs_timeslice_duration.c
@@ -47,16 +47,21 @@
  * TEST: sysfs timeslice duration
  * Feature: SMI, cmd_submission
  * Run type: FULL
+ * Test category: SysMan
  *
  * SUBTEST: duration
+ * Functionality: Test to measure the timeslice duration by watching the xCS_TIMESTAMP and recording its value every time we switch into the context, using a couple of semaphores to busyspin for the timeslice.
  *
  * SUBTEST: idempotent
+ * Functionality: Test to check whether timeslice parameter reports the values set.
  *
  * SUBTEST: invalid
+ * Functionality: Test to check if timeslice parameter rejects any unrepresentable intervals.
  *
  * SUBTEST: off
  *
  * SUBTEST: timeout
+ * Functionality: Couple a unpreemptable hog with a fast forced reset and measure the timeslice by how long it takes for the hog to be reset and the high priority context to complete.
  */
 
 #define ATTR "timeslice_duration_ms"
-- 
2.40.1

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 6/6] i915/: better document the remaining i915 tests
  2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 6/6] i915/: better document the remaining i915 tests Mauro Carvalho Chehab
@ 2023-05-19 16:15   ` Kamil Konieczny
  0 siblings, 0 replies; 15+ messages in thread
From: Kamil Konieczny @ 2023-05-19 16:15 UTC (permalink / raw)
  To: igt-dev

Hi Mauro,

there are some problems, see below.

On 2023-05-17 at 17:11:10 +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
> 
> Merge data from some ancillary internal documentation to improve
> i915 test descriptions.
> 
> This patch was auto-generated via script.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
>  tests/i915/api_intel_allocator.c         | 23 ++++++-
>  tests/i915/api_intel_bb.c                | 33 +++++++++-
>  tests/i915/gem_barrier_race.c            |  1 +
>  tests/i915/gem_basic.c                   |  7 +++
>  tests/i915/gem_blits.c                   |  4 ++
>  tests/i915/gem_busy.c                    |  7 +++
>  tests/i915/gem_caching.c                 |  4 ++
>  tests/i915/gem_close.c                   |  4 ++
>  tests/i915/gem_close_race.c              |  7 +++
>  tests/i915/gem_create.c                  | 41 ++++++++++++-
>  tests/i915/gem_cs_tlb.c                  |  4 ++
>  tests/i915/gem_eio.c                     | 68 ++++++++++++++++++++-
>  tests/i915/gem_exercise_blt.c            |  9 ++-
>  tests/i915/gem_flink_basic.c             | 14 ++++-
>  tests/i915/gem_flink_race.c              |  4 ++
>  tests/i915/gem_gpgpu_fill.c              |  4 ++
>  tests/i915/gem_linear_blits.c            |  6 ++
>  tests/i915/gem_lmem_evict.c              |  1 +
>  tests/i915/gem_lmem_swapping.c           |  4 ++
>  tests/i915/gem_madvise.c                 |  4 ++
>  tests/i915/gem_mmap_offset.c             |  4 ++
>  tests/i915/gem_pipe_control_store_loop.c |  4 ++
>  tests/i915/gem_ppgtt.c                   |  6 ++
>  tests/i915/gem_request_retire.c          |  4 ++
>  tests/i915/gem_ringfill.c                |  8 +++
>  tests/i915/gem_shrink.c                  |  4 ++
>  tests/i915/gem_softpin.c                 | 69 ++++++++++++++++++++-
>  tests/i915/gem_spin_batch.c              | 37 ++++++++++++
>  tests/i915/gem_sync.c                    | 14 +++++
>  tests/i915/gem_unref_active_buffers.c    |  4 ++
>  tests/i915/gem_userptr_blits.c           | 76 ++++++++++++++++++++++++
>  tests/i915/gem_vm_create.c               |  4 ++
>  tests/i915/gem_wait.c                    |  4 ++
>  tests/i915/gem_workarounds.c             | 32 +++++++++-
>  tests/i915/i915_getparams_basic.c        |  4 ++
>  tests/i915/i915_hangman.c                | 40 ++++++++++---
>  tests/i915/i915_hwmon.c                  |  1 +
>  tests/i915/i915_module_load.c            |  4 ++
>  tests/i915/i915_pciid.c                  |  4 ++
>  tests/i915/i915_pm_rpm.c                 |  6 +-
>  tests/i915/i915_pm_rps.c                 | 12 +++-
>  tests/i915/i915_power.c                  |  1 +
>  tests/i915/i915_query.c                  |  4 ++
>  tests/i915/i915_suspend.c                | 26 ++++++--
>  tests/i915/sysfs_defaults.c              |  4 ++
>  tests/i915/sysfs_heartbeat_interval.c    |  6 ++
>  tests/i915/sysfs_preempt_timeout.c       |  4 ++
>  tests/i915/sysfs_timeslice_duration.c    |  5 ++
>  48 files changed, 609 insertions(+), 31 deletions(-)
> 
> diff --git a/tests/i915/api_intel_allocator.c b/tests/i915/api_intel_allocator.c
> index 3962231ebcc7..7759032b75db 100644
> --- a/tests/i915/api_intel_allocator.c
> +++ b/tests/i915/api_intel_allocator.c
> @@ -11,44 +11,65 @@
>  #include "intel_allocator.h"
>  /**
>   * TEST: api intel allocator
> + * Category: Infrastructure
>   * Feature: igt_core
> + * Functionality: virtual address ranges
>   * Run type: FULL
> + * Sub-category: IGT Lib
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: alloc-simple
> + * Description: checking the virtual address ranges
>   *
>   * SUBTEST: default-alignment
>   * Description:
>   *   For simple allocator check does default alignment is properly handled in open and alloc
>   *   functions
> + *   checking the virtual address ranges
>   *
>   * SUBTEST: execbuf-with-allocator
> + * Description: checking the virtual address ranges
>   *
>   * SUBTEST: fork-simple-once
> + * Description: checking the virtual address ranges
>   *
>   * SUBTEST: fork-simple-stress
> + * Description: checking the virtual address ranges
>   *
>   * SUBTEST: fork-simple-stress-signal
> + * Description: checking the virtual address ranges
>   *
>   * SUBTEST: gem-pool
> - * Description: Verifies creating and executing bb from gem pool
> + * Description:
> + *   Verifies creating and executing bb from gem pool
> + *   checking the virtual address ranges
>   *
>   * SUBTEST: open-vm
> + * Description: checking the virtual address ranges
>   *
>   * SUBTEST: reloc-allocator
> + * Description: checking the virtual address ranges
>   *
>   * SUBTEST: reopen
> + * Description: checking the virtual address ranges
>   *
>   * SUBTEST: reopen-fork
> + * Description: checking the virtual address ranges
>   *
>   * SUBTEST: reserve-simple
> + * Description: checking the virtual address ranges
>   *
>   * SUBTEST: simple-allocator
> + * Description: checking the virtual address ranges
>   *
>   * SUBTEST: standalone
> + * Description: checking the virtual address ranges
>   *
>   * SUBTEST: two-level-inception
> + * Description: checking the virtual address ranges
>   *
>   * SUBTEST: two-level-inception-interruptible
> + * Description: checking the virtual address ranges
>   */
>  
>  #define OBJ_SIZE 1024
> diff --git a/tests/i915/api_intel_bb.c b/tests/i915/api_intel_bb.c
> index 198a29eb4f26..09d90199ef4a 100644
> --- a/tests/i915/api_intel_bb.c
> +++ b/tests/i915/api_intel_bb.c
> @@ -43,66 +43,95 @@
>  #include "i915/i915_blt.h"
>  /**
>   * TEST: api intel bb
> + * Category: Infrastructure
>   * Description: intel_bb API check.
>   * Feature: igt_core
> + * Functionality: dummy buffer creation & submission
>   * Run type: FULL
> + * Sub-category: IGT Lib
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: add-remove-objects
> + * Description: checking dummy buffer creation & submission
>   *
>   * SUBTEST: bb-with-allocator
> + * Description: checking dummy buffer creation & submission
>   *
>   * SUBTEST: blit-noreloc-keep-cache
> + * Description: checking dummy buffer creation & submission
>   *
>   * SUBTEST: blit-noreloc-purge-cache
> + * Description: checking dummy buffer creation & submission
>   *
>   * SUBTEST: blit-reloc-keep-cache
> + * Description: checking dummy buffer creation & submission
>   *
>   * SUBTEST: blit-reloc-purge-cache
> + * Description: checking dummy buffer creation & submission
>   *
>   * SUBTEST: crc32
>   * Description: Compare cpu and gpu crc32 sums on input object
>   *
>   * SUBTEST: delta-check
> + * Description: checking dummy buffer creation & submission
>   *
>   * SUBTEST: destroy-bb
> + * Description: checking dummy buffer creation & submission
>   *
>   * SUBTEST: full-batch
> + * Description: checking dummy buffer creation & submission
>   *
>   * SUBTEST: intel-bb-blit-none
> + * Description: checking dummy buffer creation & submission
>   *
>   * SUBTEST: intel-bb-blit-x
>   *
>   * SUBTEST: intel-bb-blit-y
> + * Description: checking dummy buffer creation & submission
>   *
>   * SUBTEST: lot-of-buffers
> + * Description: checking dummy buffer creation & submission
>   *
>   * SUBTEST: misplaced-blitter
> - * Description: Execute intel_bb with set of engines provided by userspace
> + * Description:
> + *   Execute intel_bb with set of engines provided by userspace
> + *   checking dummy buffer creation & submission
>   *
>   * SUBTEST: object-noreloc-keep-cache-simple
> + * Description: checking dummy buffer creation & submission
>   *
>   * SUBTEST: object-noreloc-purge-cache-simple
> + * Description: checking dummy buffer creation & submission
>   *
>   * SUBTEST: object-reloc-keep-cache
> + * Description: checking dummy buffer creation & submission
>   *
>   * SUBTEST: object-reloc-purge-cache
> + * Description: checking dummy buffer creation & submission
>   *
>   * SUBTEST: offset-control
> + * Description: checking dummy buffer creation & submission
>   *
>   * SUBTEST: purge-bb
> + * Description: checking dummy buffer creation & submission
>   *
>   * SUBTEST: render
>   *
>   * SUBTEST: render-ccs
>   *
>   * SUBTEST: reset-bb
> - * Description: Ensure reset is possible on fresh bb
> + * Description:
> + *   Ensure reset is possible on fresh bb
> + *   checking dummy buffer creation & submission
>   *
>   * SUBTEST: reset-flags
> + * Description: checking dummy buffer creation & submission
>   *
>   * SUBTEST: simple-bb
> + * Description: checking dummy buffer creation & submission
>   *
>   * SUBTEST: simple-bb-ctx
> + * Description: checking dummy buffer creation & submission
>   */
>  
>  #define PAGE_SIZE 4096
> diff --git a/tests/i915/gem_barrier_race.c b/tests/i915/gem_barrier_race.c
> index ec8ebaa63611..be71d20e7f24 100644
> --- a/tests/i915/gem_barrier_race.c
> +++ b/tests/i915/gem_barrier_race.c
> @@ -22,6 +22,7 @@
>   * Description: Exercise engine barriers and their interaction with other subsystems
>   * Feature: core
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: remote-request
>   * Description:
> diff --git a/tests/i915/gem_basic.c b/tests/i915/gem_basic.c
> index 8605429799aa..8df581bb3e48 100644
> --- a/tests/i915/gem_basic.c
> +++ b/tests/i915/gem_basic.c
> @@ -43,27 +43,34 @@
>  #include "lib/igt_device_scan.h"
>  /**
>   * TEST: gem basic
> + * Category: Infrastructure
>   * Description: Tests basic gem_create and gem_close IOCTLs
> + * Functionality: driver handler
> + * Sub-category: i915
>   *
>   * SUBTEST: bad-close
>   * Description: Verify that gem_close fails with bad params.
>   * Feature: gem_core
>   * Run type: BAT
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: create-close
>   * Description: Verify basic functionality of gem_create and gem_close.
>   * Feature: gem_core
>   * Run type: BAT
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: create-fd-close
>   * Description: Verify that closing drm driver is possible with opened gem object.
>   * Feature: gem_core
>   * Run type: BAT
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: multigpu-create-close
>   * Description: Verify basic functionality of gem_create and gem_close on multi-GPU.
>   * Feature: gem_core, multigpu
>   * Run type: FULL
> + * Test category: MultiGPU
>   */
>  
>  IGT_TEST_DESCRIPTION("Tests basic gem_create and gem_close IOCTLs");
> diff --git a/tests/i915/gem_blits.c b/tests/i915/gem_blits.c
> index acc1adc165f3..681fe046665b 100644
> --- a/tests/i915/gem_blits.c
> +++ b/tests/i915/gem_blits.c
> @@ -30,8 +30,12 @@
>  #include "i915/i915_blt.h"
>  /**
>   * TEST: gem blits
> + * Category: Infrastructure
>   * Feature: blitter
> + * Functionality: command streamer
>   * Run type: FULL
> + * Sub-category: HW
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic
>   */
> diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
> index 38d66f8f292a..34f6c5984b0b 100644
> --- a/tests/i915/gem_busy.c
> +++ b/tests/i915/gem_busy.c
> @@ -32,19 +32,25 @@
>  #include "igt_vgem.h"
>  /**
>   * TEST: gem busy
> + * Category: Desktop client
>   * Description: Basic check of busy-ioctl ABI.
>   * Feature: cmd_submission
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: busy
>   * Description: Basic test to check busyness of each engine.
> + * Functionality: semaphore
>   * Run type: FULL
>   *
>   * SUBTEST: close-race
>   * Description: Test to check race condition by randomly closing the handle using gem_close.
> + * Functionality: semaphore
>   * Run type: FULL
>   *
>   * SUBTEST: extended
>   * Description: Extended test to check busyness of dwstore-capable engines.
> + * Functionality: semaphore
>   * Run type: FULL
>   *
>   * SUBTEST: hang
> @@ -61,6 +67,7 @@
>   * Description:
>   *   Extended test to check busyness of dwstore-capable engines while doing parallel
>   *   execution.
> + * Functionality: semaphore
>   * Run type: FULL
>   *
>   * SUBTEST: semaphore
> diff --git a/tests/i915/gem_caching.c b/tests/i915/gem_caching.c
> index d24e6cce059b..7af427d7e48c 100644
> --- a/tests/i915/gem_caching.c
> +++ b/tests/i915/gem_caching.c
> @@ -42,9 +42,13 @@
>  #include "i915/i915_blt.h"
>  /**
>   * TEST: gem caching
> + * Category: Desktop client
>   * Description: Test snoop consistency when touching partial cachelines.
>   * Feature: caching
> + * Functionality: data coherency
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: read-writes
>   *
> diff --git a/tests/i915/gem_close.c b/tests/i915/gem_close.c
> index 212fd8e9062a..20aff600d595 100644
> --- a/tests/i915/gem_close.c
> +++ b/tests/i915/gem_close.c
> @@ -27,8 +27,12 @@
>  #include "igt_types.h"
>  /**
>   * TEST: gem close
> + * Category: Infrastructure
>   * Feature: mapping
> + * Functionality: driver handler
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic
>   *
> diff --git a/tests/i915/gem_close_race.c b/tests/i915/gem_close_race.c
> index 802fa3abbe6a..e02cea17ccad 100644
> --- a/tests/i915/gem_close_race.c
> +++ b/tests/i915/gem_close_race.c
> @@ -50,12 +50,16 @@
>  #include "igt_device_scan.h"
>  /**
>   * TEST: gem close race
> + * Category: Infrastructure
>   * Description: Test try to race gem_close against workload submission.
> + * Functionality: driver handler
> + * Sub-category: i915
>   *
>   * SUBTEST: basic-process
>   * Description: Basic workload submission.
>   * Feature: synchronization
>   * Run type: BAT
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic-threads
>   * Description:
> @@ -63,6 +67,7 @@
>   *   continuous workload with minimum timeout.
>   * Feature: synchronization
>   * Run type: BAT
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: contexts
>   * Description:
> @@ -82,11 +87,13 @@
>   * Description: Basic workload submission on multi-GPU machine.
>   * Feature: multigpu, synchronization
>   * Run type: FULL
> + * Test category: MultiGPU
>   *
>   * SUBTEST: multigpu-basic-threads
>   * Description: Run basic-threads race on multi-GPU machine.
>   * Feature: multigpu, synchronization
>   * Run type: FULL
> + * Test category: MultiGPU
>   *
>   * SUBTEST: process-exit
>   * Description: Test try to race gem_close against submission of continuous workload.
> diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c
> index fc99189499b8..ed79031f59de 100644
> --- a/tests/i915/gem_create.c
> +++ b/tests/i915/gem_create.c
> @@ -67,50 +67,89 @@
>   * Description:
>   *   Ensure that basic gem_create and gem_create_ext works and that invalid input combinations
>   *   are rejected.
> - * Feature: mapping
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: busy-create
> + * Category: Infrastructure
>   * Description: Create buffer objects while GPU is busy.
> + * Feature: mapping
> + * Functionality: buffer management
> + * Sub-category: i915
>   *
>   * SUBTEST: create-clear
> + * Category: Infrastructure
>   * Description: Verify that all new objects are clear.
> + * Feature: mapping
> + * Functionality: buffer management
> + * Sub-category: i915
>   *
>   * SUBTEST: create-ext-cpu-access-big
>   * Description:
>   *   Verify the extreme cases with very large objects and.
>   *   I915_GEM_CREATE_EXT_FLAG_NEEDS_CPU_ACCESS
> + * Feature: mapping
>   *
>   * SUBTEST: create-ext-cpu-access-sanity-check
>   * Description:
>   *   Verify the basic functionally and expected ABI contract around.
>   *   I915_GEM_CREATE_EXT_FLAG_NEEDS_CPU_ACCESS
> + * Feature: mapping
>   *
>   * SUBTEST: create-ext-placement-all
> + * Category: Infrastructure
>   * Description: Create objects in every memory region using create_ext.
> + * Feature: mapping
> + * Functionality: buffer management
> + * Sub-category: i915
>   *
>   * SUBTEST: create-ext-placement-each
> + * Category: Infrastructure
>   * Description: Create one object with memory pieces in each memory region using create_ext.
> + * Feature: mapping
> + * Functionality: buffer management
> + * Sub-category: i915
>   *
>   * SUBTEST: create-ext-placement-sanity-check
> + * Category: Infrastructure
>   * Description: Exercise create_ext placements extension.
> + * Feature: mapping
> + * Functionality: buffer management
> + * Sub-category: i915
>   *
>   * SUBTEST: create-invalid-size
> + * Category: Infrastructure
>   * Description: Try to create a gem object of invalid size 0 and check if ioctl returns error.
> + * Feature: mapping
> + * Functionality: buffer management
> + * Sub-category: i915
>   *
>   * SUBTEST: create-massive
> + * Category: Infrastructure
>   * Description: Exercise creation of buffer object with impossible size and check for the expected error.
> + * Feature: mapping
> + * Functionality: buffer management
> + * Sub-category: i915
>   *
>   * SUBTEST: create-size-update
> + * Category: Infrastructure
>   * Description: Try to create a gem object with size 15 and check actual created size.
> + * Feature: mapping
> + * Functionality: buffer management
> + * Sub-category: i915
>   *
>   * SUBTEST: create-valid-nonaligned
> + * Category: Infrastructure
>   * Description:
>   *   Try to create an object with non-aligned size, check we got one with size aligned up to page
>   *   size and test we can write into the padded extra memory.
> + * Feature: mapping
> + * Functionality: buffer management
> + * Sub-category: i915
>   *
>   * SUBTEST: hog-create
>   * Description: Create buffer objects while GPU is busy.
> + * Feature: mapping
>   */
>  
>  IGT_TEST_DESCRIPTION("Ensure that basic gem_create and gem_create_ext works"
> diff --git a/tests/i915/gem_cs_tlb.c b/tests/i915/gem_cs_tlb.c
> index ab09efa251b3..3f285f42c1ac 100644
> --- a/tests/i915/gem_cs_tlb.c
> +++ b/tests/i915/gem_cs_tlb.c
> @@ -54,9 +54,13 @@
>  #include "igt.h"
>  /**
>   * TEST: gem cs tlb
> + * Category: Infrastructure
>   * Description: Check whether we correctly invalidate the cs tlb.
>   * Feature: mapping
> + * Functionality: command submission
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: engines
>   */
> diff --git a/tests/i915/gem_eio.c b/tests/i915/gem_eio.c
> index 4aef96d18e8c..3b7d02f74294 100644
> --- a/tests/i915/gem_eio.c
> +++ b/tests/i915/gem_eio.c
> @@ -54,96 +54,158 @@
>  #include "sw_sync.h"
>  /**
>   * TEST: gem eio
> + * Category: Infrastructure
>   * Description: Test that specific ioctls report a wedged GPU (EIO).
>   * Run type: FULL
> + * Sub-category: i915
>   *
>   * SUBTEST: banned
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: context-create
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: create
>   * Description: Validate i915_gem_create_ioctl, while gpu is wedged for fb scanout.
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: create-ext
>   * Description:
>   *   Validate i915_gem_create_ext_ioctl and checks if returns clear backing store while gpu is
>   *   wedged for fb scanout.
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: execbuf
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: hibernate
> - * Feature: hibernate, reset
> + * Feature:
> + *   hibernate, reset
> + *   suspend
> + * Functionality: Test that specific ioctls report a wedged GPU (EIO) during suspend
-------------------- ^
This is description ?

> + * Test category: suspend
>   *
>   * SUBTEST: in-flight-10ms
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: in-flight-1us
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: in-flight-contexts-10ms
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: in-flight-contexts-1us
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: in-flight-contexts-immediate
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: in-flight-external
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: in-flight-immediate
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: in-flight-internal-10ms
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: in-flight-internal-1us
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: in-flight-internal-immediate
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: in-flight-suspend
> - * Feature: reset
> + * Feature:
> + *   reset
> + *   suspend
> + * Functionality: Test that specific ioctls report a wedged GPU (EIO) during suspend
-------------------- ^
Same here.

> + * Test category: suspend
>   *
>   * SUBTEST: kms
>   * Feature: kms_gem_interop, reset
>   *
>   * SUBTEST: reset-stress
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: suspend
> - * Feature: reset, suspend
> + * Feature:
> + *   reset, suspend
> + *   suspend
> + * Functionality: Test that specific ioctls report a wedged GPU (EIO) during suspend
-------------------- ^
Same here.

> + * Test category: suspend
>   *
>   * SUBTEST: throttle
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: unwedge-stress
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: wait-10ms
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: wait-1us
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: wait-immediate
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: wait-wedge-10ms
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: wait-wedge-1us
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: wait-wedge-immediate
>   * Feature: reset
> + * Functionality: reset
> + * Test category: GEM_Legacy
>   */
>  
>  IGT_TEST_DESCRIPTION("Test that specific ioctls report a wedged GPU (EIO).");
> diff --git a/tests/i915/gem_exercise_blt.c b/tests/i915/gem_exercise_blt.c
> index af86d5edc2ab..3287ced76a59 100644
> --- a/tests/i915/gem_exercise_blt.c
> +++ b/tests/i915/gem_exercise_blt.c
> @@ -15,12 +15,17 @@
>   * Description: Exercise blitter commands
>   * Feature: blitter
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: fast-copy
> - * Description: Check fast-copy blit
> + * Description:
> + *   Check fast-copy blit
> + *   blitter
>   *
>   * SUBTEST: fast-copy-emit
> - * Description: Check multiple fast-copy in one batch
> + * Description:
> + *   Check multiple fast-copy in one batch
> + *   blitter
>   */
>  
>  IGT_TEST_DESCRIPTION("Exercise blitter commands");
> diff --git a/tests/i915/gem_flink_basic.c b/tests/i915/gem_flink_basic.c
> index 7feabf61a303..fd99ee5538e4 100644
> --- a/tests/i915/gem_flink_basic.c
> +++ b/tests/i915/gem_flink_basic.c
> @@ -40,24 +40,36 @@
>  #include "igt_types.h"
>  /**
>   * TEST: gem flink basic
> + * Category: Desktop client
>   * Description: Tests for flink - a way to export a gem object by name
>   * Feature: xorg_dri2
> - * Run type: BAT
> + * Functionality: buffer management
> + * Sub-category: DRM
>   *
>   * SUBTEST: bad-flink
>   * Description: Verify that GEM_FLINK ioctl with invalid gem object fails.
> + * Run type: BAT
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: bad-open
>   * Description: Verify that GEM_OPEN ioctl with invalid flink name fails.
> + * Run type: BAT
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic
>   * Description: Check if gem object can be exported to global namespace and then opened.
> + * Run type: BAT
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: double-flink
>   * Description: Tests that multiple flinks for the same gem object share the same name.
> + * Run type: BAT
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: flink-lifetime
>   * Description: Tests flink lifetime by referencing from multiple descriptors.
> + * Run type: BAT
> + * Test category: GEM_Legacy
>   */
>  
>  IGT_TEST_DESCRIPTION("Tests for flink - a way to export a gem object by name");
> diff --git a/tests/i915/gem_flink_race.c b/tests/i915/gem_flink_race.c
> index 5ebf1969b992..a9177ce1b775 100644
> --- a/tests/i915/gem_flink_race.c
> +++ b/tests/i915/gem_flink_race.c
> @@ -37,9 +37,13 @@
>  #include "igt_stats.h"
>  /**
>   * TEST: gem flink race
> + * Category: Desktop client
>   * Description: Check for flink/open vs. gem close races.
>   * Feature: xorg_dri2
> + * Functionality: buffer management
>   * Run type: FULL
> + * Sub-category: DRM
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: flink_close
>   *
> diff --git a/tests/i915/gem_gpgpu_fill.c b/tests/i915/gem_gpgpu_fill.c
> index f350e9fbb6d0..e79df7409c01 100644
> --- a/tests/i915/gem_gpgpu_fill.c
> +++ b/tests/i915/gem_gpgpu_fill.c
> @@ -50,8 +50,12 @@
>  #include "i915/intel_memory_region.h"
>  /**
>   * TEST: gem gpgpu fill
> + * Category: Server
>   * Feature: compute
> + * Functionality: command submission
>   * Run type: FULL
> + * Sub-category: Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic
>   */
> diff --git a/tests/i915/gem_linear_blits.c b/tests/i915/gem_linear_blits.c
> index 4c3576503ca3..40ab4fab3df4 100644
> --- a/tests/i915/gem_linear_blits.c
> +++ b/tests/i915/gem_linear_blits.c
> @@ -51,20 +51,26 @@
>  #include "i915/i915_blt.h"
>  /**
>   * TEST: gem linear blits
> + * Category: Infrastructure
>   * Description: Test doing many blits with a working set larger than the aperture size.
>   * Feature: blitter
> + * Functionality: command submission
> + * Sub-category: i915
>   *
>   * SUBTEST: basic
>   * Description: Basic blitter functionality check with 2 buffers
>   * Run type: BAT
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: interruptible
>   * Description: Test with interrupts in between the parent process
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: normal
>   * Description: The intent is to push beyond the working GTT size to force the driver to rebind the buffers
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   */
>  
>  IGT_TEST_DESCRIPTION("Test doing many blits with a working set larger than the"
> diff --git a/tests/i915/gem_lmem_evict.c b/tests/i915/gem_lmem_evict.c
> index e40eab2d2914..54277e11dac7 100644
> --- a/tests/i915/gem_lmem_evict.c
> +++ b/tests/i915/gem_lmem_evict.c
> @@ -12,6 +12,7 @@
>   * Description: Force tiny lmem size for easily testing eviction scenarios.
>   * Feature: local_memory
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: dontneed-evict-race
>   * Description: Regression test to verify that madvise will sync against busy dma-resv object for lmem
> diff --git a/tests/i915/gem_lmem_swapping.c b/tests/i915/gem_lmem_swapping.c
> index f6a1c0082c78..014068da79f3 100644
> --- a/tests/i915/gem_lmem_swapping.c
> +++ b/tests/i915/gem_lmem_swapping.c
> @@ -26,8 +26,12 @@
>  #include "i915/intel_mocs.h"
>  /**
>   * TEST: gem lmem swapping
> + * Category: Server
>   * Description: Exercise local memory swapping.
>   * Feature: local_memory
> + * Functionality: buffer management
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic
>   * Description: Exercise local memory swapping to system memory
> diff --git a/tests/i915/gem_madvise.c b/tests/i915/gem_madvise.c
> index 17653cc4ad53..139376d1b3e3 100644
> --- a/tests/i915/gem_madvise.c
> +++ b/tests/i915/gem_madvise.c
> @@ -40,8 +40,12 @@
>  #include "i915/gem_create.h"
>  /**
>   * TEST: gem madvise
> + * Category: Desktop client
>   * Description: Checks that the kernel reports EFAULT when trying to use purged bo.
> + * Functionality: buffer management
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: dontneed-after-mmap
>   * Description:
> diff --git a/tests/i915/gem_mmap_offset.c b/tests/i915/gem_mmap_offset.c
> index afabe2426291..f6d3374dd6e8 100644
> --- a/tests/i915/gem_mmap_offset.c
> +++ b/tests/i915/gem_mmap_offset.c
> @@ -39,9 +39,13 @@
>  #include "igt_x86.h"
>  /**
>   * TEST: gem mmap offset
> + * Category: Infrastructure
>   * Description: Basic MMAP_OFFSET IOCTL tests for mem regions
>   * Feature: mapping
> + * Functionality: memory management
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: bad-extensions
>   *
> diff --git a/tests/i915/gem_pipe_control_store_loop.c b/tests/i915/gem_pipe_control_store_loop.c
> index 5e6ef049085b..986dbf673164 100644
> --- a/tests/i915/gem_pipe_control_store_loop.c
> +++ b/tests/i915/gem_pipe_control_store_loop.c
> @@ -45,9 +45,13 @@
>  #include "igt.h"
>  /**
>   * TEST: gem pipe control store loop
> + * Category: Desktop client
>   * Description: Test (TLB-)Coherency of pipe_control QW writes.
>   * Feature: cmd_submission
> + * Functionality: command submission
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: fresh-buffer
>   * Description: Checks tlb consistency of the pipe_control with fresh buffer.
> diff --git a/tests/i915/gem_ppgtt.c b/tests/i915/gem_ppgtt.c
> index 368f8b17db75..6a0512ab6010 100644
> --- a/tests/i915/gem_ppgtt.c
> +++ b/tests/i915/gem_ppgtt.c
> @@ -50,15 +50,21 @@
>   * Feature: mapping
>   *
>   * SUBTEST: flink-and-close-vma-leak
> + * Category: Desktop client
>   * Feature: mapping, xorg_dri2
> + * Functionality: buffer management
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: shrink-vs-evict-any
>   * Description: Regression test to verify GTT eviction can't randomly fail due to object lock contention
>   * Feature: mapping
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: shrink-vs-evict-pinned
>   * Description: Regression test to verify GTT eviction can't randomly fail due to object lock contention
>   * Feature: mapping
> + * Test category: GEM_Legacy
>   */
>  
>  #define WIDTH 512
> diff --git a/tests/i915/gem_request_retire.c b/tests/i915/gem_request_retire.c
> index 9e074706d259..9814b435d937 100644
> --- a/tests/i915/gem_request_retire.c
> +++ b/tests/i915/gem_request_retire.c
> @@ -51,9 +51,13 @@
>  #include "igt_types.h"
>  /**
>   * TEST: gem request retire
> + * Category: Infrastructure
>   * Description: Collection of tests targeting request retirement code paths.
>   * Feature: cmd_submission
> + * Functionality: command submission
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: retire-vma-not-inactive
>   */
> diff --git a/tests/i915/gem_ringfill.c b/tests/i915/gem_ringfill.c
> index 451876526e9a..d350cd7fea57 100644
> --- a/tests/i915/gem_ringfill.c
> +++ b/tests/i915/gem_ringfill.c
> @@ -43,14 +43,18 @@
>  #include <sys/ioctl.h>
>  /**
>   * TEST: gem ringfill
> + * Category: Infrastructure
>   * Description:
>   *   Exercise many tiny batchbuffer operations, in the hope of catching failure to manage the ring
>   *   properly near full.
> + * Sub-category: i915
>   *
>   * SUBTEST: basic-all
>   * Description: Basic check to fill the ring upto maximum on all engines simultaneously.
>   * Feature: cmd_submission
> + * Functionality: command submission
>   * Run type: BAT
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: engines-S3
>   * Description: Handle a full ring across suspend cycle.
> @@ -65,7 +69,9 @@
>   * SUBTEST: engines-basic
>   * Description: Basic check how the driver handles a full ring.
>   * Feature: cmd_submission, multitile
> + * Functionality: Test spamming ring with contexts
>   * Run type: FULL
> + * Test category: MultiTile
>   *
>   * SUBTEST: engines-bomb
>   * Description:
> @@ -114,7 +120,9 @@
>   * SUBTEST: legacy-basic
>   * Description: Basic check how the driver handles a full ring - on legacy ring.
>   * Feature: cmd_submission, multitile
> + * Functionality: Test spamming ring with contexts - legacy path
>   * Run type: FULL
> + * Test category: MultiTile
>   *
>   * SUBTEST: legacy-bomb
>   * Description:
> diff --git a/tests/i915/gem_shrink.c b/tests/i915/gem_shrink.c
> index a65792c84137..79301754babc 100644
> --- a/tests/i915/gem_shrink.c
> +++ b/tests/i915/gem_shrink.c
> @@ -139,6 +139,10 @@
>   * SUBTEST: pwrite-userptr-dirty
>   *
>   * SUBTEST: reclaim
> + * Category: Desktop client
> + * Functionality: buffer management
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   */
>  
>  #ifndef MADV_FREE
> diff --git a/tests/i915/gem_softpin.c b/tests/i915/gem_softpin.c
> index 27e5781b9b73..6bea75d1fe37 100644
> --- a/tests/i915/gem_softpin.c
> +++ b/tests/i915/gem_softpin.c
> @@ -33,116 +33,183 @@
>  #include "intel_allocator.h"
>  /**
>   * TEST: gem softpin
> + * Category: Infrastructure
>   * Description:
>   *   Tests softpin feature with normal usage, invalid inputs scenarios and couple of eviction
>   *   tests which copy buffers between CPU and GPU.
> - * Feature: mapping
> + * Sub-category: i915
>   *
>   * SUBTEST: 32b-excludes-last-page
>   * Description: Check the last 32b page is excluded.
> + * Feature: mapping
> + * Functionality: command submission
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: allocator-basic
>   * Description: Check that we can place objects at start/end of the GTT using the allocator.
> + * Feature: mapping
> + * Functionality: command submission
>   * Run type: BAT
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: allocator-basic-reserve
>   * Description: Check that if we can reserve a space for an object starting from a given offset.
> + * Feature: mapping
> + * Functionality: command submission
>   * Run type: BAT
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: allocator-evict
>   * Description: Exercise eviction with softpinning.
> + * Feature: mapping
> + * Functionality: command submission
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: allocator-fork
>   * Description: Check if multiple processes can use alloctor.
> + * Feature: mapping
> + * Functionality: command submission
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: allocator-nopin
>   * Description: Check that we can combine manual placement with automatic GTT placement.
> + * Feature: mapping
> + * Functionality: command submission
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: allocator-nopin-reserve
>   * Description:
>   *   Check that we can combine manual placement with automatic GTT placement and
>   *   reserves/unreserves space for objects.
> + * Feature: mapping
> + * Functionality: command submission
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: evict-active
>   * Description: Check eviction with active bo.
> + * Feature: mapping
> + * Functionality: command submission
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: evict-active-interruptible
>   * Description: Check eviction with active bo with interrupts.
> + * Feature: mapping
> + * Functionality: command submission
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: evict-hang
>   * Description: Check eviction of softpinned bo with hung batch.
> + * Feature: mapping
>   * Run type: FULL
>   *
>   * SUBTEST: evict-prime
>   * Description: Check eviction of vma on importing prime fd in reopened drm fds
> + * Feature: mapping
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: evict-prime-sanity-check
>   * Description: Check eviction of vma on importing prime fd in reopened drm fd in single thread
> + * Feature: mapping
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: evict-single-offset
>   * Description: Use same offset for all engines and for different handles.
> + * Feature: mapping
> + * Functionality: command submission
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: evict-snoop
>   * Description: Check eviction against snooping.
> + * Feature: mapping
>   * Run type: FULL
>   *
>   * SUBTEST: evict-snoop-interruptible
>   * Description: Check eviction against snooping with interrupts.
> + * Feature: mapping
>   * Run type: FULL
>   *
>   * SUBTEST: full
>   * Description: Check the total occupancy by using pad-to-size to fill the entire GTT.
> + * Feature: mapping
> + * Functionality: command submission
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: invalid
>   * Description: Check that invalid inputs are handled correctly.
> + * Feature: mapping
> + * Functionality: command submission
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: noreloc
>   * Description: Check that noreloc support works.
> + * Feature: mapping
> + * Functionality: command submission
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: noreloc-S3
>   * Description: Check noreloc survives after suspend to RAM/resume cycle.
> + * Feature: mapping
>   * Run type: FULL
>   *
>   * SUBTEST: noreloc-S4
>   * Description: Check noreloc survives after suspend to disk/resume cycle.
> + * Feature: mapping
>   * Run type: FULL
>   *
>   * SUBTEST: noreloc-interruptible
>   * Description: Check noreloc support with interruptible.
> + * Feature: mapping
> + * Functionality: command submission
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: overlap
>   * Description: Check all the possible pages aligned overlaps.
> + * Feature: mapping
> + * Functionality: command submission
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: reverse
>   * Description: Check that if the user demands the vma will be swapped.
> + * Feature: mapping
> + * Functionality: command submission
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: safe-alignment
>   * Description: Check start offset and alignment detection.
> + * Feature: mapping
> + * Functionality: command submission
>   * Run type: BAT
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: softpin
>   * Description: Check softpinning of a gem buffer object.
> + * Feature: mapping
> + * Functionality: command submission
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: zero
>   * Description: Check full placement control under full-ppGTT.
> + * Feature: mapping
> + * Functionality: command submission
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   */
>  
>  IGT_TEST_DESCRIPTION("Tests softpin feature with normal usage, invalid inputs"
> diff --git a/tests/i915/gem_spin_batch.c b/tests/i915/gem_spin_batch.c
> index 0a6c088da630..cd828beb26c2 100644
> --- a/tests/i915/gem_spin_batch.c
> +++ b/tests/i915/gem_spin_batch.c
> @@ -28,42 +28,79 @@
>  /**
>   * TEST: gem spin batch
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: engines
> + * Category: Infrastructure
>   * Feature: context, igt_core
> + * Functionality: dummy workload
> + * Sub-category: IGT Lib
>   *
>   * SUBTEST: legacy
> + * Category: Infrastructure
>   * Feature: context, igt_core
> + * Functionality: dummy workload
> + * Sub-category: IGT Lib
>   *
>   * SUBTEST: legacy-resubmit
> + * Category: Infrastructure
>   * Feature: context, igt_core
> + * Functionality: dummy workload
> + * Sub-category: IGT Lib
>   *
>   * SUBTEST: legacy-resubmit-new
> + * Category: Infrastructure
>   * Feature: context, igt_core, multictx
> + * Functionality: dummy workload
> + * Sub-category: IGT Lib
>   *
>   * SUBTEST: resubmit
> + * Category: Infrastructure
>   * Feature: context, igt_core
> + * Functionality: dummy workload
> + * Sub-category: IGT Lib
>   *
>   * SUBTEST: resubmit-all
> + * Category: Infrastructure
>   * Feature: context, igt_core, multictx
> + * Functionality: dummy workload
> + * Sub-category: IGT Lib
>   *
>   * SUBTEST: resubmit-new
> + * Category: Infrastructure
>   * Feature: context, igt_core, multictx
> + * Functionality: dummy workload
> + * Sub-category: IGT Lib
>   *
>   * SUBTEST: resubmit-new-all
> + * Category: Infrastructure
>   * Feature: context, igt_core, multictx
> + * Functionality: dummy workload
> + * Sub-category: IGT Lib
>   *
>   * SUBTEST: spin-all
> + * Category: Infrastructure
>   * Feature: igt_core, multictx
> + * Functionality: dummy workload
> + * Sub-category: IGT Lib
>   *
>   * SUBTEST: spin-all-new
> + * Category: Infrastructure
>   * Feature: igt_core, multictx
> + * Functionality: dummy workload
> + * Sub-category: IGT Lib
>   *
>   * SUBTEST: spin-each
> + * Category: Infrastructure
>   * Feature: igt_core, multictx
> + * Functionality: dummy workload
> + * Sub-category: IGT Lib
>   *
>   * SUBTEST: user-each
> + * Category: Infrastructure
>   * Feature: igt_core, multictx
> + * Functionality: dummy workload
> + * Sub-category: IGT Lib
>   */
>  
>  #define MAX_ERROR 5 /* % */
> diff --git a/tests/i915/gem_sync.c b/tests/i915/gem_sync.c
> index 1c7e51a92bfa..9a855a221654 100644
> --- a/tests/i915/gem_sync.c
> +++ b/tests/i915/gem_sync.c
> @@ -57,29 +57,43 @@
>   * Run type: FULL
>   *
>   * SUBTEST: basic-all
> + * Category: Infrastructure
>   * Description: Basic test to wait upon a batch on all rings.
>   * Feature: synchronization
> + * Functionality: semaphore
>   * Run type: BAT
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic-each
>   * Description: Check synchronisation of ring.
>   * Feature: multitile, synchronization
> + * Functionality: Exercise all physical engine selection and legacy rings
-------------------- ^
imho semaphore, engine selection
but I am not sure, it looks more like description, here and below.

>   * Run type: BAT
> + * Test category: MultiTile
>   *
>   * SUBTEST: basic-many-each
>   * Description: Create race condition and see if we can catch interrupts.
>   * Feature: multitile, synchronization
> + * Functionality: Basic check of ring to ring write synchronisation
-------------------- ^

>   * Run type: FULL
> + * Test category: MultiTile
>   *
>   * SUBTEST: basic-store-all
> + * Category: Infrastructure
>   * Description: Basic version of store synchronisation test.
>   * Feature: synchronization
> + * Functionality: semaphore
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic-store-each
>   * Description: Check that store synchronisation works.
>   * Feature: multitile, synchronization
> + * Functionality: Basic check of ring to ring write, store synchronisation
-------------------- ^

>   * Run type: FULL
> + * Test category: MultiTile
>   *
>   * SUBTEST: default
>   * Description: Check synchronisation of rings on each engine.
> diff --git a/tests/i915/gem_unref_active_buffers.c b/tests/i915/gem_unref_active_buffers.c
> index 90a63e8f9acf..badded1f71a6 100644
> --- a/tests/i915/gem_unref_active_buffers.c
> +++ b/tests/i915/gem_unref_active_buffers.c
> @@ -43,9 +43,13 @@
>  #include "i915/gem_create.h"
>  /**
>   * TEST: gem unref active buffers
> + * Category: Infrastructure
>   * Description: Test unreferencing of active buffers.
>   * Feature: cmd_submission
> + * Functionality: buffer management
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST:
>   */
> diff --git a/tests/i915/gem_userptr_blits.c b/tests/i915/gem_userptr_blits.c
> index 4df604d6dcd6..e9235a6898d5 100644
> --- a/tests/i915/gem_userptr_blits.c
> +++ b/tests/i915/gem_userptr_blits.c
> @@ -81,7 +81,11 @@
>   * Feature: userptr
>   *
>   * SUBTEST: create-destroy-sync
> + * Category: Server
>   * Feature: userptr
> + * Functionality: buffer management
> + * Sub-category: Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: create-destroy-unsync
>   * Feature: userptr
> @@ -195,17 +199,29 @@
>   * Feature: userptr
>   *
>   * SUBTEST: huge-split
> + * Category: Server
>   * Feature: userptr
> + * Functionality: buffer management
> + * Sub-category: Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: input-checking
> + * Category: Server
>   * Feature: userptr
> + * Functionality: buffer management
> + * Sub-category: Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: invalid-mmap-offset-unsync
>   * Description: Verify unsynchronized userptr on mmap-offset mappings fails
>   * Feature: userptr
>   *
>   * SUBTEST: invalid-null-pointer
> + * Category: Server
>   * Feature: userptr
> + * Functionality: buffer management
> + * Sub-category: Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: major-normal-sync
>   * Feature: userptr
> @@ -260,14 +276,26 @@
>   * Feature: userptr
>   *
>   * SUBTEST: mmap-offset-banned
> + * Category: Server
>   * Description: Verify mmap_offset to userptr is banned
>   * Feature: userptr
> + * Functionality: buffer management
> + * Sub-category: Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: nohangcheck
> + * Category: Server
>   * Feature: userptr
> + * Functionality: buffer management
> + * Sub-category: Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: probe
> + * Category: Server
>   * Feature: userptr
> + * Functionality: buffer management
> + * Sub-category: Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: process-exit
>   * Feature: userptr
> @@ -285,22 +313,46 @@
>   * Feature: userptr
>   *
>   * SUBTEST: sd-probe
> + * Category: Server
>   * Feature: userptr
> + * Functionality: buffer management
> + * Sub-category: Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: set-cache-level
> + * Category: Server
>   * Feature: userptr
> + * Functionality: buffer management
> + * Sub-category: Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: stress-mm
> + * Category: Server
>   * Feature: userptr
> + * Functionality: buffer management
> + * Sub-category: Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: stress-mm-invalidate-close
> + * Category: Server
>   * Feature: userptr
> + * Functionality: buffer management
> + * Sub-category: Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: stress-mm-invalidate-close-overlap
> + * Category: Server
>   * Feature: userptr
> + * Functionality: buffer management
> + * Sub-category: Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: stress-purge
> + * Category: Server
>   * Feature: userptr
> + * Functionality: buffer management
> + * Sub-category: Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: swapping-normal-sync
>   * Feature: userptr
> @@ -315,16 +367,32 @@
>   * Feature: userptr
>   *
>   * SUBTEST: sync-overlap
> + * Category: Server
>   * Feature: userptr
> + * Functionality: buffer management
> + * Sub-category: Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: sync-unmap
> + * Category: Server
>   * Feature: userptr
> + * Functionality: buffer management
> + * Sub-category: Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: sync-unmap-after-close
> + * Category: Server
>   * Feature: userptr
> + * Functionality: buffer management
> + * Sub-category: Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: sync-unmap-cycles
> + * Category: Server
>   * Feature: userptr
> + * Functionality: buffer management
> + * Sub-category: Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: unsync-overlap
>   * Feature: userptr
> @@ -339,13 +407,21 @@
>   * Feature: userptr
>   *
>   * SUBTEST: usage-restrictions
> + * Category: Server
>   * Feature: userptr
> + * Functionality: buffer management
> + * Sub-category: Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: userfault
>   * Feature: userptr
>   *
>   * SUBTEST: vma-merge
> + * Category: Server
>   * Feature: userptr
> + * Functionality: buffer management
> + * Sub-category: Compute
> + * Test category: GEM_Legacy
>   */
>  
>  #ifndef PAGE_SIZE
> diff --git a/tests/i915/gem_vm_create.c b/tests/i915/gem_vm_create.c
> index 2b19ca973acc..f24aefdae729 100644
> --- a/tests/i915/gem_vm_create.c
> +++ b/tests/i915/gem_vm_create.c
> @@ -29,7 +29,11 @@
>  #include "igt_dummyload.h"
>  /**
>   * TEST: gem vm create
> + * Category: Server
> + * Functionality: context management
>   * Run type: FULL
> + * Sub-category: Compute
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: create-ext
>   * Feature: mapping
> diff --git a/tests/i915/gem_wait.c b/tests/i915/gem_wait.c
> index 874ccd87eee3..40e548579226 100644
> --- a/tests/i915/gem_wait.c
> +++ b/tests/i915/gem_wait.c
> @@ -33,8 +33,12 @@
>  #include "igt_vgem.h"
>  /**
>   * TEST: gem wait
> + * Category: Infrastructure
>   * Description: Tests the GEM_WAIT ioctl
>   * Feature: synchronization
> + * Functionality: semaphore
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: await
>   * Description: Verify GEM_WAIT functionality in await mode.
> diff --git a/tests/i915/gem_workarounds.c b/tests/i915/gem_workarounds.c
> index b635fd342ac5..02c8977d5cb6 100644
> --- a/tests/i915/gem_workarounds.c
> +++ b/tests/i915/gem_workarounds.c
> @@ -34,16 +34,24 @@
>  #include "igt_types.h"
>  /**
>   * TEST: gem workarounds
> + * Category: Infrastructure
>   * Run type: FULL
> + * Sub-category: HW
>   *
>   * SUBTEST: basic-read
>   * Feature: workarounds
> + * Functionality: context management
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic-read-context
>   * Feature: workarounds
> + * Functionality: context management
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic-read-fd
>   * Feature: workarounds
> + * Functionality: context management
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: hibernate-resume
>   * Feature: hibernate, workarounds
> @@ -56,21 +64,39 @@
>   *
>   * SUBTEST: reset
>   * Feature: workarounds
> + * Functionality: context management
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: reset-context
>   * Feature: workarounds
> + * Functionality: context management
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: reset-fd
>   * Feature: workarounds
> + * Functionality: context management
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: suspend-resume
> - * Feature: suspend, workarounds
> + * Feature:
> + *   suspend, workarounds
> + *   suspend
> + * Functionality: Test to verify gem WA registers during suspend-resume
-------------------- ^

> + * Test category: suspend
>   *
>   * SUBTEST: suspend-resume-context
> - * Feature: suspend, workarounds
> + * Feature:
> + *   suspend, workarounds
> + *   suspend
> + * Functionality: Test to verify gem WA registers during suspend-resume
-------------------- ^

> + * Test category: suspend
>   *
>   * SUBTEST: suspend-resume-fd
> - * Feature: suspend, workarounds
> + * Feature:
> + *   suspend, workarounds
> + *   suspend
> + * Functionality: Test to verify gem WA registers during suspend-resume
-------------------- ^

> + * Test category: suspend
>   */
>  
>  #define PAGE_SIZE 4096
> diff --git a/tests/i915/i915_getparams_basic.c b/tests/i915/i915_getparams_basic.c
> index e026aad565ff..74ccaf4d35f0 100644
> --- a/tests/i915/i915_getparams_basic.c
> +++ b/tests/i915/i915_getparams_basic.c
> @@ -32,9 +32,13 @@
>  #include <i915_drm.h>
>  /**
>   * TEST: i915 getparams basic
> + * Category: Infrastructure
>   * Description: Tests the export of parameters via DRM_IOCTL_I915_GETPARAM
>   * Feature: gem_core
> + * Functionality: device topology
>   * Run type: BAT
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic-eu-total
>   * Description: Examine the export of EU_TOTAL parameter
> diff --git a/tests/i915/i915_hangman.c b/tests/i915/i915_hangman.c
> index ef45b25adacd..fc46bd29764b 100644
> --- a/tests/i915/i915_hangman.c
> +++ b/tests/i915/i915_hangman.c
> @@ -42,43 +42,65 @@
>  #include "sw_sync.h"
>  /**
>   * TEST: i915 hangman
> + * Category: Server
>   * Description: Tests for hang detection and recovery
>   * Feature: reset
> + * Functionality: error handling
> + * Sub-category: debugger
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: detector
> - * Description: Check that hang detector works
> + * Description:
> + *   Check that hang detector works
> + *   error detection
>   * Run type: FULL
>   *
>   * SUBTEST: engine-engine-error
> - * Description: Per engine hang recovery (invalid CS, engine reset)
> + * Description:
> + *   Per engine hang recovery (invalid CS, engine reset)
> + *   error detection
>   * Run type: FULL
>   *
>   * SUBTEST: engine-engine-hang
> - * Description: Per engine hang recovery (spin, engine reset)
> + * Description:
> + *   Per engine hang recovery (spin, engine reset)
> + *   error detection
>   * Run type: FULL
>   *
>   * SUBTEST: engine-error-state-capture
> - * Description: Per engine error capture (engine reset)
> + * Description:
> + *   Per engine error capture (engine reset)
> + *   error detection
>   * Run type: FULL
>   *
>   * SUBTEST: error-state-basic
> - * Description: Basic error capture
> + * Description:
> + *   Basic error capture
> + *   error detection
>   * Run type: BAT
>   *
>   * SUBTEST: gt-engine-error
> - * Description: Per engine hang recovery (invalid CS, GT reset)
> + * Description:
> + *   Per engine hang recovery (invalid CS, GT reset)
> + *   error detection
>   * Run type: FULL
>   *
>   * SUBTEST: gt-engine-hang
> - * Description: Per engine hang recovery (spin, GT reset)
> + * Description:
> + *   Per engine hang recovery (spin, GT reset)
> + *   error detection
>   * Run type: FULL
>   *
>   * SUBTEST: gt-error-state-capture
> - * Description: Per engine error capture (GT reset)
> + * Description:
> + *   Per engine error capture (GT reset)
> + *   error detection
>   * Run type: FULL
>   *
>   * SUBTEST: hangcheck-unterminated
> - * Description: Check that executing unintialised memory causes a hang
> + * Description:
> + *   Check that executing unintialised memory causes a hang
> + *   error detection
>   * Run type: FULL
>   */
>  
> diff --git a/tests/i915/i915_hwmon.c b/tests/i915/i915_hwmon.c
> index 6d1334172c40..279f6821b0da 100644
> --- a/tests/i915/i915_hwmon.c
> +++ b/tests/i915/i915_hwmon.c
> @@ -13,6 +13,7 @@
>   * Description: Tests for i915 hwmon
>   * Feature: hwmon
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: hwmon-read
>   * Description: Verify we can read all hwmon attributes
> diff --git a/tests/i915/i915_module_load.c b/tests/i915/i915_module_load.c
> index ae4e01ef18bc..386be7d602dc 100644
> --- a/tests/i915/i915_module_load.c
> +++ b/tests/i915/i915_module_load.c
> @@ -25,7 +25,11 @@
>  #include <sys/utsname.h>
>  /**
>   * TEST: i915 module load
> + * Category: Infrastructure
>   * Description: Tests the i915 module loading.
> + * Functionality: driver handler
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: load
>   * Description: Check if i915 and friends are not yet loaded, then load them.
> diff --git a/tests/i915/i915_pciid.c b/tests/i915/i915_pciid.c
> index ae3d2a09d208..c44be56dcbc1 100644
> --- a/tests/i915/i915_pciid.c
> +++ b/tests/i915/i915_pciid.c
> @@ -30,9 +30,13 @@
>  #include "intel_chipset.h"
>  /**
>   * TEST: i915 pciid
> + * Category: Infrastructure
>   * Description: Check that igt/i915 know about this PCI-ID
>   * Feature: core
> + * Functionality: device management
>   * Run type: BAT
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST:
>   */
> diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
> index d9b4cbbfe615..4c0888ecc4c5 100644
> --- a/tests/i915/i915_pm_rpm.c
> +++ b/tests/i915/i915_pm_rpm.c
> @@ -42,9 +42,13 @@
>  #include <sys/stat.h>
>  /**
>   * TEST: i915 pm rpm
> + * Functionality: Validate PCI device D3 state enter-exit scenario using runtime PM
-------------------- ^

> + * Test category: pm_rpm
>   *
>   * SUBTEST: basic-pci-d3-state
> - * Feature: pm_rpm
> + * Feature:
> + *   pm_rpm
> + *   pm_rpm
>   * Run type: BAT
>   *
>   * SUBTEST: basic-rte
> diff --git a/tests/i915/i915_pm_rps.c b/tests/i915/i915_pm_rps.c
> index 050d68a16559..0c803eed5fdb 100644
> --- a/tests/i915/i915_pm_rps.c
> +++ b/tests/i915/i915_pm_rps.c
> @@ -52,13 +52,21 @@
>   *
>   * SUBTEST: engine-order
>   * Description: Check if context reuse does not affect waitboosting
> - * Feature: pm_rps
> + * Feature:
> + *   pm_rps
> + *   pm_rps
------- ^
Same string repeated.

> + * Functionality: Render P-States tests - verify GPU frequency changes
-------------------- ^

>   * Run type: FULL
> + * Test category: pm_rps
>   *
>   * SUBTEST: fence-order
>   * Description: Check if the order of fences does not affect waitboosting
> - * Feature: pm_rps, synchronization
> + * Feature:
> + *   pm_rps, synchronization
> + *   pm_rps
> + * Functionality: Render P-States tests - verify GPU frequency changes
-------------------- ^

>   * Run type: FULL
> + * Test category: pm_rps
>   *
>   * SUBTEST: min-max-config-idle
>   * Feature: pm_rps
> diff --git a/tests/i915/i915_power.c b/tests/i915/i915_power.c
> index 383c212d2807..3675b9d6d75c 100644
> --- a/tests/i915/i915_power.c
> +++ b/tests/i915/i915_power.c
> @@ -12,6 +12,7 @@
>   * Description: i915 power measurement tests
>   * Feature: hwmon
>   * Run type: FULL
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: sanity
>   * Description: Sanity check gpu power measurement
> diff --git a/tests/i915/i915_query.c b/tests/i915/i915_query.c
> index 10c6d43fa7fc..de3aa5c24f2d 100644
> --- a/tests/i915/i915_query.c
> +++ b/tests/i915/i915_query.c
> @@ -29,8 +29,12 @@
>  #include <limits.h>
>  /**
>   * TEST: i915 query
> + * Category: Infrastructure
>   * Description: Testing the i915 query uAPI.
> + * Functionality: device topology
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: engine-info
>   * Description: Positive tests for DRM_I915_QUERY_ENGINE_INFO
> diff --git a/tests/i915/i915_suspend.c b/tests/i915/i915_suspend.c
> index 448cadfb0804..31456a45d9c8 100644
> --- a/tests/i915/i915_suspend.c
> +++ b/tests/i915/i915_suspend.c
> @@ -46,19 +46,29 @@
>  #include "igt_device_scan.h"
>  /**
>   * TEST: i915 suspend
> + * Test category: suspend
>   *
>   * SUBTEST: basic-s2idle-without-i915
>   * Description: Validate suspend-to-idle without i915 module
> - * Feature: suspend
> + * Feature:
> + *   suspend
> + *   suspend
------- ^
Same string repeated.

> + * Functionality: Validate suspend-to-idle without i915 module
-------------------- ^

>   * Run type: BAT
>   *
>   * SUBTEST: basic-s3-without-i915
>   * Description: Validate S3 without i915 module
> - * Feature: suspend
> + * Feature:
> + *   suspend
> + *   suspend
> + * Functionality: Validate S3 state without i915 module
-------------------- ^
Taken from description.

>   * Run type: BAT
>   *
>   * SUBTEST: debugfs-reader
> - * Feature: suspend
> + * Feature:
> + *   suspend
> + *   suspend
------- ^
repeated

> + * Functionality: Test debugfs behavior during suspend to idle
-------------------- ^

>   * Run type: FULL
>   *
>   * SUBTEST: debugfs-reader-hibernate
> @@ -82,7 +92,10 @@
>   * Run type: FULL
>   *
>   * SUBTEST: forcewake
> - * Feature: suspend
> + * Feature:
> + *   suspend
> + *   suspend
------- ^
> + * Functionality: Test to prevent GT from suspend by opening forcewake handle
-------------------- ^

>   * Run type: FULL
>   *
>   * SUBTEST: forcewake-hibernate
> @@ -94,7 +107,10 @@
>   * Run type: FULL
>   *
>   * SUBTEST: sysfs-reader
> - * Feature: suspend
> + * Feature:
> + *   suspend
> + *   suspend
------- ^
> + * Functionality: Test sysfs behavior during suspend to idle
-------------------- ^

>   * Run type: FULL
>   *
>   * SUBTEST: sysfs-reader-hibernate
> diff --git a/tests/i915/sysfs_defaults.c b/tests/i915/sysfs_defaults.c
> index 73478559fcda..066532f0a5e2 100644
> --- a/tests/i915/sysfs_defaults.c
> +++ b/tests/i915/sysfs_defaults.c
> @@ -35,8 +35,12 @@
>  #include "igt_sysfs.h"
>  /**
>   * TEST: sysfs defaults
> + * Category: Infrastructure
>   * Feature: gem_core
> + * Functionality: driver handler
>   * Run type: FULL
> + * Sub-category: i915
> + * Test category: GEM_Legacy
>   *
>   * SUBTEST: readonly
>   */
> diff --git a/tests/i915/sysfs_heartbeat_interval.c b/tests/i915/sysfs_heartbeat_interval.c
> index 2971acb32811..9161ea5bbf59 100644
> --- a/tests/i915/sysfs_heartbeat_interval.c
> +++ b/tests/i915/sysfs_heartbeat_interval.c
> @@ -45,20 +45,26 @@
>   * TEST: sysfs heartbeat interval
>   * Feature: SMI, cmd_submission
>   * Run type: FULL
> + * Test category: SysMan
>   *
>   * SUBTEST: idempotent
> + * Functionality: Test to check whether the heartbeat parameter reports the values set.
-------------------- ^

>   *
>   * SUBTEST: invalid
> + * Functionality: Test to check if heartbeat parameter rejects any unrepresentable intervals.
-------------------- ^

>   *
>   * SUBTEST: long
>   *
>   * SUBTEST: mixed
> + * Functionality: Run a mixed workload with non-preemptable hogs that exceed the heartbeat, and quicker innocents. Inspect the fence status of each to verify that only the hogs are reset.
-------------------- ^

>   *
>   * SUBTEST: nopreempt
> + * Functionality: Test heartbeats with forced preemption disabled.
-------------------- ^

>   *
>   * SUBTEST: off
>   *
>   * SUBTEST: precise
> + * Functionality: Tests the heartbeats with preemption and heartbeat parameter enabled.
-------------------- ^

>   */
>  
>  #define ATTR "heartbeat_interval_ms"
> diff --git a/tests/i915/sysfs_preempt_timeout.c b/tests/i915/sysfs_preempt_timeout.c
> index e7c09949930c..b7ec5ec3e4b7 100644
> --- a/tests/i915/sysfs_preempt_timeout.c
> +++ b/tests/i915/sysfs_preempt_timeout.c
> @@ -44,14 +44,18 @@
>   * TEST: sysfs preempt timeout
>   * Feature: SMI, context
>   * Run type: FULL
> + * Test category: SysMan
>   *
>   * SUBTEST: idempotent
> + * Functionality: Test to check whether the preempt_timeout parameter reports the values set.
-------------------- ^

>   *
>   * SUBTEST: invalid
> + * Functionality: Test to check if preempt_timeout parameter rejects any unrepresentable intervals.
-------------------- ^

>   *
>   * SUBTEST: off
>   *
>   * SUBTEST: timeout
> + * Functionality: Test to measure the delay from requestion the preemption to its completion. Send down some non-preemptable workloads and then request a switch to a higher priority context. The HW will not be able to respond, so the kernel will be forced to reset the hog.
-------------------- ^
This definitly fits into description.

>   */
>  
>  #define ATTR "preempt_timeout_ms"
> diff --git a/tests/i915/sysfs_timeslice_duration.c b/tests/i915/sysfs_timeslice_duration.c
> index 0f4905d8b613..58b0ed3f02d2 100644
> --- a/tests/i915/sysfs_timeslice_duration.c
> +++ b/tests/i915/sysfs_timeslice_duration.c
> @@ -47,16 +47,21 @@
>   * TEST: sysfs timeslice duration
>   * Feature: SMI, cmd_submission
>   * Run type: FULL
> + * Test category: SysMan
>   *
>   * SUBTEST: duration
> + * Functionality: Test to measure the timeslice duration by watching the xCS_TIMESTAMP and recording its value every time we switch into the context, using a couple of semaphores to busyspin for the timeslice.
-------------------- ^
>   *
>   * SUBTEST: idempotent
> + * Functionality: Test to check whether timeslice parameter reports the values set.
-------------------- ^
>   *
>   * SUBTEST: invalid
> + * Functionality: Test to check if timeslice parameter rejects any unrepresentable intervals.
-------------------- ^
>   *
>   * SUBTEST: off
>   *
>   * SUBTEST: timeout
> + * Functionality: Couple a unpreemptable hog with a fast forced reset and measure the timeslice by how long it takes for the hog to be reset and the high priority context to complete.
-------------------- ^

Regards,
Kamil

>   */
>  
>  #define ATTR "timeslice_duration_ms"
> -- 
> 2.40.1
> 


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for Improve description of tests used by i915 validation
  2023-05-17 15:11 [igt-dev] [PATCH i-g-t 0/6] Improve description of tests used by i915 validation Mauro Carvalho Chehab
                   ` (5 preceding siblings ...)
  2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 6/6] i915/: better document the remaining i915 tests Mauro Carvalho Chehab
@ 2023-05-17 16:51 ` Patchwork
  2023-05-18  5:19 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  7 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2023-05-17 16:51 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 5592 bytes --]

== Series Details ==

Series: Improve description of tests used by i915 validation
URL   : https://patchwork.freedesktop.org/series/117889/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13160 -> IGTPW_8986
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/index.html

Participating hosts (36 -> 36)
------------------------------

  Additional (1): fi-kbl-soraka 
  Missing    (1): fi-snb-2520m 

Known issues
------------

  Here are the changes found in IGTPW_8986 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_huc_copy@huc-copy:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html

  * igt@gem_lmem_swapping@basic:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 similar issues
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html

  * igt@i915_selftest@live@gt_pm:
    - fi-kbl-soraka:      NOTRUN -> [DMESG-FAIL][3] ([i915#1886] / [i915#7913])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html

  * igt@i915_selftest@live@hangcheck:
    - bat-dg2-9:          [PASS][4] -> [ABORT][5] ([i915#7913] / [i915#7979])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13160/bat-dg2-9/igt@i915_selftest@live@hangcheck.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/bat-dg2-9/igt@i915_selftest@live@hangcheck.html

  * igt@i915_selftest@live@requests:
    - fi-kbl-soraka:      NOTRUN -> [ABORT][6] ([i915#7913])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/fi-kbl-soraka/igt@i915_selftest@live@requests.html

  * igt@i915_selftest@live@reset:
    - bat-rpls-1:         [PASS][7] -> [ABORT][8] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13160/bat-rpls-1/igt@i915_selftest@live@reset.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/bat-rpls-1/igt@i915_selftest@live@reset.html

  * igt@i915_selftest@live@slpc:
    - bat-rpls-2:         NOTRUN -> [DMESG-WARN][9] ([i915#6367])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/bat-rpls-2/igt@i915_selftest@live@slpc.html

  * igt@i915_suspend@basic-s2idle-without-i915:
    - bat-rpls-2:         NOTRUN -> [ABORT][10] ([i915#6687])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/bat-rpls-2/igt@i915_suspend@basic-s2idle-without-i915.html

  * igt@kms_chamelium_frames@hdmi-crc-fast:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][11] ([fdo#109271]) +14 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#4579])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/fi-kbl-soraka/igt@kms_setmode@basic-clone-single-crtc.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@reset:
    - bat-rpls-2:         [ABORT][13] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#8347]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13160/bat-rpls-2/igt@i915_selftest@live@reset.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/bat-rpls-2/igt@i915_selftest@live@reset.html

  * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1:
    - bat-dg2-8:          [FAIL][15] ([i915#7932]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13160/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
  [i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
  [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
  [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
  [i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
  [i915#7979]: https://gitlab.freedesktop.org/drm/intel/issues/7979
  [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
  [i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7294 -> IGTPW_8986

  CI-20190529: 20190529
  CI_DRM_13160: 2147c8fcc283c183aba29e5f51b653332d90a3ed @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8986: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/index.html
  IGT_7294: e1ab60dc90fc49f6b2ec1b37f14b021e59455e73 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/index.html

[-- Attachment #2: Type: text/html, Size: 7081 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for Improve description of tests used by i915 validation
  2023-05-17 15:11 [igt-dev] [PATCH i-g-t 0/6] Improve description of tests used by i915 validation Mauro Carvalho Chehab
                   ` (6 preceding siblings ...)
  2023-05-17 16:51 ` [igt-dev] ✓ Fi.CI.BAT: success for Improve description of tests used by i915 validation Patchwork
@ 2023-05-18  5:19 ` Patchwork
  7 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2023-05-18  5:19 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 15093 bytes --]

== Series Details ==

Series: Improve description of tests used by i915 validation
URL   : https://patchwork.freedesktop.org/series/117889/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13160_full -> IGTPW_8986_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/index.html

Participating hosts (7 -> 8)
------------------------------

  Additional (1): shard-rkl0 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_8986_full:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@gem_eio@in-flight-contexts-1us:
    - {shard-dg1}:        [PASS][1] -> [DMESG-WARN][2] +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13160/shard-dg1-15/igt@gem_eio@in-flight-contexts-1us.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/shard-dg1-12/igt@gem_eio@in-flight-contexts-1us.html

  
Known issues
------------

  Here are the changes found in IGTPW_8986_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_pm_rps@reset:
    - shard-snb:          [PASS][3] -> [INCOMPLETE][4] ([i915#7790])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13160/shard-snb7/igt@i915_pm_rps@reset.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/shard-snb5/igt@i915_pm_rps@reset.html

  * igt@kms_fbcon_fbt@fbc-suspend:
    - shard-apl:          [PASS][5] -> [FAIL][6] ([i915#4767])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13160/shard-apl3/igt@kms_fbcon_fbt@fbc-suspend.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2:
    - shard-glk:          [PASS][7] -> [FAIL][8] ([i915#79])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13160/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/shard-glk5/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2.html

  * igt@perf@stress-open-close@0-rcs0:
    - shard-glk:          [PASS][9] -> [ABORT][10] ([i915#5213] / [i915#7941])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13160/shard-glk3/igt@perf@stress-open-close@0-rcs0.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/shard-glk2/igt@perf@stress-open-close@0-rcs0.html

  
#### Possible fixes ####

  * igt@gem_barrier_race@remote-request@rcs0:
    - {shard-dg1}:        [ABORT][11] ([i915#7461] / [i915#8234]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13160/shard-dg1-17/igt@gem_barrier_race@remote-request@rcs0.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/shard-dg1-12/igt@gem_barrier_race@remote-request@rcs0.html

  * igt@gem_ctx_exec@basic-nohangcheck:
    - {shard-rkl}:        [FAIL][13] ([i915#6268]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13160/shard-rkl-4/igt@gem_ctx_exec@basic-nohangcheck.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/shard-rkl-4/igt@gem_ctx_exec@basic-nohangcheck.html

  * igt@i915_module_load@reload-with-fault-injection:
    - {shard-dg1}:        [DMESG-WARN][15] ([i915#4391]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13160/shard-dg1-17/igt@i915_module_load@reload-with-fault-injection.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/shard-dg1-14/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_pm_dc@dc6-dpms:
    - {shard-tglu}:       [FAIL][17] ([i915#3989] / [i915#454]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13160/shard-tglu-3/igt@i915_pm_dc@dc6-dpms.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/shard-tglu-2/igt@i915_pm_dc@dc6-dpms.html

  * igt@i915_pm_dc@dc9-dpms:
    - shard-apl:          [SKIP][19] ([fdo#109271]) -> [PASS][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13160/shard-apl3/igt@i915_pm_dc@dc9-dpms.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/shard-apl3/igt@i915_pm_dc@dc9-dpms.html

  * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
    - {shard-rkl}:        [SKIP][21] ([i915#1937] / [i915#4579]) -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13160/shard-rkl-2/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/shard-rkl-7/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html

  * igt@i915_pm_rc6_residency@rc6-idle@vcs0:
    - {shard-dg1}:        [FAIL][23] ([i915#3591]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13160/shard-dg1-14/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/shard-dg1-17/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html

  * igt@i915_pm_rps@reset:
    - {shard-tglu}:       [INCOMPLETE][25] ([i915#8320]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13160/shard-tglu-5/igt@i915_pm_rps@reset.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/shard-tglu-3/igt@i915_pm_rps@reset.html

  * igt@i915_suspend@basic-s3-without-i915:
    - {shard-rkl}:        [FAIL][27] ([fdo#103375]) -> [PASS][28]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13160/shard-rkl-6/igt@i915_suspend@basic-s3-without-i915.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/shard-rkl-1/igt@i915_suspend@basic-s3-without-i915.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
    - shard-glk:          [FAIL][29] ([i915#2346]) -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13160/shard-glk5/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

  * igt@kms_cursor_legacy@forked-bo@pipe-b:
    - {shard-rkl}:        [INCOMPLETE][31] ([i915#8011]) -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13160/shard-rkl-7/igt@kms_cursor_legacy@forked-bo@pipe-b.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/shard-rkl-4/igt@kms_cursor_legacy@forked-bo@pipe-b.html

  * igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@bc-hdmi-a1-hdmi-a2:
    - shard-glk:          [FAIL][33] ([i915#2122]) -> [PASS][34] +1 similar issue
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13160/shard-glk8/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@bc-hdmi-a1-hdmi-a2.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/shard-glk9/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@bc-hdmi-a1-hdmi-a2.html

  * igt@kms_hdmi_inject@inject-audio:
    - {shard-tglu}:       [SKIP][35] ([i915#433]) -> [PASS][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13160/shard-tglu-4/igt@kms_hdmi_inject@inject-audio.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/shard-tglu-6/igt@kms_hdmi_inject@inject-audio.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
  [fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
  [fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
  [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
  [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
  [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
  [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
  [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
  [i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
  [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
  [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
  [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
  [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
  [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
  [i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
  [i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
  [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
  [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
  [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
  [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
  [i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
  [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
  [i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936
  [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
  [i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
  [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
  [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
  [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
  [i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
  [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
  [i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
  [i915#4475]: https://gitlab.freedesktop.org/drm/intel/issues/4475
  [i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
  [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
  [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
  [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
  [i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
  [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
  [i915#4958]: https://gitlab.freedesktop.org/drm/intel/issues/4958
  [i915#5115]: https://gitlab.freedesktop.org/drm/intel/issues/5115
  [i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
  [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
  [i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
  [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
  [i915#5251]: https://gitlab.freedesktop.org/drm/intel/issues/5251
  [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
  [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
  [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
  [i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
  [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
  [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
  [i915#6786]: https://gitlab.freedesktop.org/drm/intel/issues/6786
  [i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
  [i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
  [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
  [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
  [i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
  [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
  [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
  [i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
  [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
  [i915#7790]: https://gitlab.freedesktop.org/drm/intel/issues/7790
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
  [i915#7941]: https://gitlab.freedesktop.org/drm/intel/issues/7941
  [i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
  [i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
  [i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
  [i915#8320]: https://gitlab.freedesktop.org/drm/intel/issues/8320
  [i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411
  [i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7294 -> IGTPW_8986
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_13160: 2147c8fcc283c183aba29e5f51b653332d90a3ed @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8986: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/index.html
  IGT_7294: e1ab60dc90fc49f6b2ec1b37f14b021e59455e73 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8986/index.html

[-- Attachment #2: Type: text/html, Size: 10577 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2023-05-19 16:15 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-17 15:11 [igt-dev] [PATCH i-g-t 0/6] Improve description of tests used by i915 validation Mauro Carvalho Chehab
2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 1/6] tests: better document core_* tests used for " Mauro Carvalho Chehab
2023-05-19 15:37   ` Kamil Konieczny
2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 2/6] tests: better document the remaining core used by " Mauro Carvalho Chehab
2023-05-19 15:43   ` Kamil Konieczny
2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 3/6] i915/gem_exec_*: better document gem exec tests used for " Mauro Carvalho Chehab
2023-05-19 15:46   ` Kamil Konieczny
2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 4/6] i915/gem_ctx_*: better document i915 context tests Mauro Carvalho Chehab
2023-05-19 15:48   ` Kamil Konieczny
2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 5/6] i915/perf_*: better document tests Mauro Carvalho Chehab
2023-05-19 15:52   ` Kamil Konieczny
2023-05-17 15:11 ` [igt-dev] [PATCH i-g-t 6/6] i915/: better document the remaining i915 tests Mauro Carvalho Chehab
2023-05-19 16:15   ` Kamil Konieczny
2023-05-17 16:51 ` [igt-dev] ✓ Fi.CI.BAT: success for Improve description of tests used by i915 validation Patchwork
2023-05-18  5:19 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox