* [igt-dev] [PATCH i-g-t 0/3] Negative tests to mmap offset
@ 2023-05-20 12:10 priyanka.dandamudi
2023-05-20 12:10 ` [igt-dev] [PATCH i-g-t 1/3] xe/xe_mmap: Negative test for mmap flags priyanka.dandamudi
` (4 more replies)
0 siblings, 5 replies; 12+ messages in thread
From: priyanka.dandamudi @ 2023-05-20 12:10 UTC (permalink / raw)
To: priyanka.dandamudi, ramadevi.gandi, janga.rahul.kumar,
kamil.konieczny, igt-dev
From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
Added 3 types of negative tests to check mmap offset.
Priyanka Dandamudi (3):
xe/xe_mmap: Negative test for mmap flags
xe/xe_mmap: Negative test to extensions
xe/xe_mmap: Negative test to object
tests/xe/xe_mmap.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 62 insertions(+)
--
2.25.1
^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] [PATCH i-g-t 1/3] xe/xe_mmap: Negative test for mmap flags
2023-05-20 12:10 [igt-dev] [PATCH i-g-t 0/3] Negative tests to mmap offset priyanka.dandamudi
@ 2023-05-20 12:10 ` priyanka.dandamudi
2023-05-22 11:36 ` Zbigniew Kempczyński
2023-05-22 11:39 ` Zbigniew Kempczyński
2023-05-20 12:10 ` [igt-dev] [PATCH i-g-t 2/3] xe/xe_mmap: Negative test to extensions priyanka.dandamudi
` (3 subsequent siblings)
4 siblings, 2 replies; 12+ messages in thread
From: priyanka.dandamudi @ 2023-05-20 12:10 UTC (permalink / raw)
To: priyanka.dandamudi, ramadevi.gandi, janga.rahul.kumar,
kamil.konieczny, igt-dev
From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
Add negative test by adding invalid mmap flags and check
for related errors.
Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
---
tests/xe/xe_mmap.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/tests/xe/xe_mmap.c b/tests/xe/xe_mmap.c
index 6b313a18..011b8893 100644
--- a/tests/xe/xe_mmap.c
+++ b/tests/xe/xe_mmap.c
@@ -57,6 +57,22 @@ test_mmap(int fd, uint32_t flags)
gem_close(fd, bo);
}
+/**
+ * SUBTEST: bad-flags
+ * Description: Test mmap offset with bad flags.
+ *
+ */
+static void test_bad_flags(int fd)
+{
+ struct drm_xe_gem_mmap_offset mmo = {
+ .handle = xe_bo_create(fd, 0, 0, 4096),
+ .flags = -1u,
+ };
+
+ do_ioctl_err(fd, DRM_IOCTL_XE_GEM_MMAP_OFFSET, &mmo, EINVAL);
+ gem_close(fd, mmo.handle);
+}
+
igt_main
{
int fd;
@@ -75,6 +91,9 @@ igt_main
igt_subtest("vram-system")
test_mmap(fd, vram_memory(fd, 0) | system_memory(fd));
+ igt_subtest("bad-flags")
+ test_bad_flags(fd);
+
igt_fixture {
xe_device_put(fd);
close(fd);
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [igt-dev] [PATCH i-g-t 2/3] xe/xe_mmap: Negative test to extensions
2023-05-20 12:10 [igt-dev] [PATCH i-g-t 0/3] Negative tests to mmap offset priyanka.dandamudi
2023-05-20 12:10 ` [igt-dev] [PATCH i-g-t 1/3] xe/xe_mmap: Negative test for mmap flags priyanka.dandamudi
@ 2023-05-20 12:10 ` priyanka.dandamudi
2023-05-22 11:41 ` Zbigniew Kempczyński
2023-05-20 12:10 ` [igt-dev] [PATCH i-g-t 3/3] xe/xe_mmap: Negative test to object priyanka.dandamudi
` (2 subsequent siblings)
4 siblings, 1 reply; 12+ messages in thread
From: priyanka.dandamudi @ 2023-05-20 12:10 UTC (permalink / raw)
To: priyanka.dandamudi, ramadevi.gandi, janga.rahul.kumar,
kamil.konieczny, igt-dev
From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
Add negative test to check bad extensions.
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
---
tests/xe/xe_mmap.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/tests/xe/xe_mmap.c b/tests/xe/xe_mmap.c
index 011b8893..f6f6b2af 100644
--- a/tests/xe/xe_mmap.c
+++ b/tests/xe/xe_mmap.c
@@ -73,6 +73,25 @@ static void test_bad_flags(int fd)
gem_close(fd, mmo.handle);
}
+/**
+ * SUBTEST: bad-extensions
+ * Description: Test mmap offset with bad extensions.
+ *
+ */
+static void test_bad_extensions(int fd)
+{
+ struct xe_user_extension ext;
+ struct drm_xe_gem_mmap_offset mmo = {
+ .handle = xe_bo_create(fd, 0, 0, 4096),
+ };
+
+ mmo.extensions = to_user_pointer(&ext);
+ ext.name = -1;
+
+ do_ioctl_err(fd, DRM_IOCTL_XE_GEM_MMAP_OFFSET, &mmo, EINVAL);
+ gem_close(fd, mmo.handle);
+}
+
igt_main
{
int fd;
@@ -94,6 +113,9 @@ igt_main
igt_subtest("bad-flags")
test_bad_flags(fd);
+ igt_subtest("bad-extensions")
+ test_bad_extensions(fd);
+
igt_fixture {
xe_device_put(fd);
close(fd);
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [igt-dev] [PATCH i-g-t 3/3] xe/xe_mmap: Negative test to object
2023-05-20 12:10 [igt-dev] [PATCH i-g-t 0/3] Negative tests to mmap offset priyanka.dandamudi
2023-05-20 12:10 ` [igt-dev] [PATCH i-g-t 1/3] xe/xe_mmap: Negative test for mmap flags priyanka.dandamudi
2023-05-20 12:10 ` [igt-dev] [PATCH i-g-t 2/3] xe/xe_mmap: Negative test to extensions priyanka.dandamudi
@ 2023-05-20 12:10 ` priyanka.dandamudi
2023-05-22 11:44 ` Zbigniew Kempczyński
2023-05-20 21:15 ` [igt-dev] ✓ Fi.CI.BAT: success for Negative tests to mmap offset Patchwork
2023-05-20 22:38 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 1 reply; 12+ messages in thread
From: priyanka.dandamudi @ 2023-05-20 12:10 UTC (permalink / raw)
To: priyanka.dandamudi, ramadevi.gandi, janga.rahul.kumar,
kamil.konieczny, igt-dev
From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
Add negative test to check bad object.
Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
---
tests/xe/xe_mmap.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/tests/xe/xe_mmap.c b/tests/xe/xe_mmap.c
index f6f6b2af..95672e5d 100644
--- a/tests/xe/xe_mmap.c
+++ b/tests/xe/xe_mmap.c
@@ -92,6 +92,24 @@ static void test_bad_extensions(int fd)
gem_close(fd, mmo.handle);
}
+/**
+ * SUBTEST: bad-object
+ * Description: Test mmap offset with bad object.
+ *
+ */
+static void test_bad_object(int fd)
+{
+ struct drm_xe_gem_mmap_offset mmo = {
+ .handle = xe_bo_create(fd, 0, 0, 4096),
+ };
+
+ igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_GEM_MMAP_OFFSET, &mmo), 0);
+ gem_close(fd, mmo.handle);
+
+ mmo.handle = 0xdeadbeef;
+ do_ioctl_err(fd, DRM_IOCTL_XE_GEM_MMAP_OFFSET, &mmo, ENOENT);
+}
+
igt_main
{
int fd;
@@ -116,6 +134,9 @@ igt_main
igt_subtest("bad-extensions")
test_bad_extensions(fd);
+ igt_subtest("bad-object")
+ test_bad_object(fd);
+
igt_fixture {
xe_device_put(fd);
close(fd);
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for Negative tests to mmap offset
2023-05-20 12:10 [igt-dev] [PATCH i-g-t 0/3] Negative tests to mmap offset priyanka.dandamudi
` (2 preceding siblings ...)
2023-05-20 12:10 ` [igt-dev] [PATCH i-g-t 3/3] xe/xe_mmap: Negative test to object priyanka.dandamudi
@ 2023-05-20 21:15 ` Patchwork
2023-05-20 22:38 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-05-20 21:15 UTC (permalink / raw)
To: priyanka.dandamudi; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 6006 bytes --]
== Series Details ==
Series: Negative tests to mmap offset
URL : https://patchwork.freedesktop.org/series/118064/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13169 -> IGTPW_9014
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/index.html
Participating hosts (36 -> 36)
------------------------------
Additional (1): fi-kbl-soraka
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_9014:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_selftest@live@migrate:
- {bat-mtlp-8}: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13169/bat-mtlp-8/igt@i915_selftest@live@migrate.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/bat-mtlp-8/igt@i915_selftest@live@migrate.html
Known issues
------------
Here are the changes found in IGTPW_9014 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#4613]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_pm_backlight@basic-brightness@edp-1:
- bat-rplp-1: NOTRUN -> [ABORT][5] ([i915#7077])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/bat-rplp-1/igt@i915_pm_backlight@basic-brightness@edp-1.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [PASS][6] -> [DMESG-FAIL][7] ([i915#5334])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13169/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][8] ([i915#1886] / [i915#7913])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@requests:
- fi-kbl-soraka: NOTRUN -> [ABORT][9] ([i915#7913])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/fi-kbl-soraka/igt@i915_selftest@live@requests.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-rpls-1: NOTRUN -> [ABORT][10] ([i915#6687] / [i915#7978])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/bat-rpls-1/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][11] ([fdo#109271]) +14 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-kbl-soraka: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#4579])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/fi-kbl-soraka/igt@kms_setmode@basic-clone-single-crtc.html
#### Possible fixes ####
* igt@i915_selftest@live@requests:
- bat-rpls-1: [ABORT][13] ([i915#4983] / [i915#7911] / [i915#7920]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13169/bat-rpls-1/igt@i915_selftest@live@requests.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/bat-rpls-1/igt@i915_selftest@live@requests.html
#### Warnings ####
* igt@kms_setmode@basic-clone-single-crtc:
- bat-rplp-1: [ABORT][15] ([i915#4579] / [i915#8260]) -> [SKIP][16] ([i915#3555] / [i915#4579])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13169/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7077]: https://gitlab.freedesktop.org/drm/intel/issues/7077
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#8260]: https://gitlab.freedesktop.org/drm/intel/issues/8260
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7297 -> IGTPW_9014
CI-20190529: 20190529
CI_DRM_13169: f533234d40e8f5b8599bd5bc97fa8e30384aec03 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9014: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/index.html
IGT_7297: 0f0754413f14abe2fe6434fd0873c158dbc47ec9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
+igt@xe_mmap@bad-extensions
+igt@xe_mmap@bad-flags
+igt@xe_mmap@bad-object
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/index.html
[-- Attachment #2: Type: text/html, Size: 7292 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for Negative tests to mmap offset
2023-05-20 12:10 [igt-dev] [PATCH i-g-t 0/3] Negative tests to mmap offset priyanka.dandamudi
` (3 preceding siblings ...)
2023-05-20 21:15 ` [igt-dev] ✓ Fi.CI.BAT: success for Negative tests to mmap offset Patchwork
@ 2023-05-20 22:38 ` Patchwork
4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-05-20 22:38 UTC (permalink / raw)
To: priyanka.dandamudi; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 13328 bytes --]
== Series Details ==
Series: Negative tests to mmap offset
URL : https://patchwork.freedesktop.org/series/118064/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13169_full -> IGTPW_9014_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/index.html
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in IGTPW_9014_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_barrier_race@remote-request@rcs0:
- shard-glk: [PASS][1] -> [ABORT][2] ([i915#7461] / [i915#8211])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13169/shard-glk3/igt@gem_barrier_race@remote-request@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/shard-glk4/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][3] -> [FAIL][4] ([i915#2846])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13169/shard-glk2/igt@gem_exec_fair@basic-deadline.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/shard-glk6/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#2842]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13169/shard-glk6/igt@gem_exec_fair@basic-pace@vcs0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/shard-glk1/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][7] -> [ABORT][8] ([i915#5566])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13169/shard-glk2/igt@gen9_exec_parse@allowed-single.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/shard-glk8/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [PASS][9] -> [SKIP][10] ([fdo#109271])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13169/shard-apl4/igt@i915_pm_dc@dc9-dpms.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/shard-apl3/igt@i915_pm_dc@dc9-dpms.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#2346])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13169/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [PASS][13] -> [FAIL][14] ([i915#2346])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13169/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-0-25@pipe-a-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][15] ([fdo#109271]) +16 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/shard-snb1/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-0-25@pipe-a-hdmi-a-1.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#4579]) +12 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/shard-snb1/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-hdmi-a-1.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- {shard-rkl}: [FAIL][17] ([i915#7742]) -> [PASS][18] +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13169/shard-rkl-3/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/shard-rkl-1/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
* igt@gem_eio@hibernate:
- {shard-tglu}: [ABORT][19] ([i915#7975] / [i915#8213] / [i915#8398]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13169/shard-tglu-10/igt@gem_eio@hibernate.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/shard-tglu-7/igt@gem_eio@hibernate.html
* igt@gem_exec_fair@basic-pace@rcs0:
- {shard-rkl}: [FAIL][21] ([i915#2842]) -> [PASS][22] +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13169/shard-rkl-1/igt@gem_exec_fair@basic-pace@rcs0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/shard-rkl-3/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_lmem_swapping@smem-oom@lmem0:
- {shard-dg1}: [TIMEOUT][23] ([i915#5493]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13169/shard-dg1-12/igt@gem_lmem_swapping@smem-oom@lmem0.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/shard-dg1-15/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@i915_suspend@basic-s3-without-i915:
- {shard-rkl}: [FAIL][25] ([fdo#103375]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13169/shard-rkl-6/igt@i915_suspend@basic-s3-without-i915.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/shard-rkl-7/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-apl: [FAIL][27] ([i915#2346]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13169/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_draw_crc@draw-method-blt@xrgb2101010-ytiled:
- shard-glk: [DMESG-WARN][29] ([i915#7936]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13169/shard-glk5/igt@kms_draw_crc@draw-method-blt@xrgb2101010-ytiled.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/shard-glk6/igt@kms_draw_crc@draw-method-blt@xrgb2101010-ytiled.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- {shard-dg1}: [FAIL][31] ([fdo#103375]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13169/shard-dg1-18/igt@kms_frontbuffer_tracking@fbc-suspend.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/shard-dg1-16/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@perf_pmu@idle@rcs0:
- {shard-dg1}: [FAIL][33] ([i915#4349]) -> [PASS][34] +6 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13169/shard-dg1-15/igt@perf_pmu@idle@rcs0.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/shard-dg1-15/igt@perf_pmu@idle@rcs0.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6786]: https://gitlab.freedesktop.org/drm/intel/issues/6786
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7936]: https://gitlab.freedesktop.org/drm/intel/issues/7936
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8398]: https://gitlab.freedesktop.org/drm/intel/issues/8398
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7297 -> IGTPW_9014
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_13169: f533234d40e8f5b8599bd5bc97fa8e30384aec03 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9014: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/index.html
IGT_7297: 0f0754413f14abe2fe6434fd0873c158dbc47ec9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9014/index.html
[-- Attachment #2: Type: text/html, Size: 10367 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/3] xe/xe_mmap: Negative test for mmap flags
2023-05-20 12:10 ` [igt-dev] [PATCH i-g-t 1/3] xe/xe_mmap: Negative test for mmap flags priyanka.dandamudi
@ 2023-05-22 11:36 ` Zbigniew Kempczyński
2023-05-22 11:39 ` Zbigniew Kempczyński
1 sibling, 0 replies; 12+ messages in thread
From: Zbigniew Kempczyński @ 2023-05-22 11:36 UTC (permalink / raw)
To: priyanka.dandamudi; +Cc: igt-dev, kamil.konieczny, ramadevi.gandi
On Sat, May 20, 2023 at 05:40:54PM +0530, priyanka.dandamudi@intel.com wrote:
> From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
>
> Add negative test by adding invalid mmap flags and check
> for related errors.
>
> Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> ---
> tests/xe/xe_mmap.c | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/tests/xe/xe_mmap.c b/tests/xe/xe_mmap.c
> index 6b313a18..011b8893 100644
> --- a/tests/xe/xe_mmap.c
> +++ b/tests/xe/xe_mmap.c
> @@ -57,6 +57,22 @@ test_mmap(int fd, uint32_t flags)
> gem_close(fd, bo);
> }
>
> +/**
> + * SUBTEST: bad-flags
> + * Description: Test mmap offset with bad flags.
> + *
> + */
> +static void test_bad_flags(int fd)
> +{
> + struct drm_xe_gem_mmap_offset mmo = {
> + .handle = xe_bo_create(fd, 0, 0, 4096),
When we start rejecting unaligned allocations you'll assert at gem create.
--
Zbigniew
> + .flags = -1u,
> + };
> +
> + do_ioctl_err(fd, DRM_IOCTL_XE_GEM_MMAP_OFFSET, &mmo, EINVAL);
> + gem_close(fd, mmo.handle);
> +}
> +
> igt_main
> {
> int fd;
> @@ -75,6 +91,9 @@ igt_main
> igt_subtest("vram-system")
> test_mmap(fd, vram_memory(fd, 0) | system_memory(fd));
>
> + igt_subtest("bad-flags")
> + test_bad_flags(fd);
> +
> igt_fixture {
> xe_device_put(fd);
> close(fd);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/3] xe/xe_mmap: Negative test for mmap flags
2023-05-20 12:10 ` [igt-dev] [PATCH i-g-t 1/3] xe/xe_mmap: Negative test for mmap flags priyanka.dandamudi
2023-05-22 11:36 ` Zbigniew Kempczyński
@ 2023-05-22 11:39 ` Zbigniew Kempczyński
1 sibling, 0 replies; 12+ messages in thread
From: Zbigniew Kempczyński @ 2023-05-22 11:39 UTC (permalink / raw)
To: priyanka.dandamudi; +Cc: igt-dev, kamil.konieczny, ramadevi.gandi
On Sat, May 20, 2023 at 05:40:54PM +0530, priyanka.dandamudi@intel.com wrote:
> From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
>
> Add negative test by adding invalid mmap flags and check
> for related errors.
>
> Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> ---
> tests/xe/xe_mmap.c | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/tests/xe/xe_mmap.c b/tests/xe/xe_mmap.c
> index 6b313a18..011b8893 100644
> --- a/tests/xe/xe_mmap.c
> +++ b/tests/xe/xe_mmap.c
> @@ -57,6 +57,22 @@ test_mmap(int fd, uint32_t flags)
> gem_close(fd, bo);
> }
>
> +/**
> + * SUBTEST: bad-flags
> + * Description: Test mmap offset with bad flags.
> + *
> + */
> +static void test_bad_flags(int fd)
> +{
uint64_t size = xe_get_default_alignment(fd);
> + struct drm_xe_gem_mmap_offset mmo = {
> + .handle = xe_bo_create(fd, 0, 0, 4096),
^ -> size
> + .flags = -1u,
> + };
> +
> + do_ioctl_err(fd, DRM_IOCTL_XE_GEM_MMAP_OFFSET, &mmo, EINVAL);
> + gem_close(fd, mmo.handle);
> +}
Rest looks correct.
--
Zbigniew
> +
> igt_main
> {
> int fd;
> @@ -75,6 +91,9 @@ igt_main
> igt_subtest("vram-system")
> test_mmap(fd, vram_memory(fd, 0) | system_memory(fd));
>
> + igt_subtest("bad-flags")
> + test_bad_flags(fd);
> +
> igt_fixture {
> xe_device_put(fd);
> close(fd);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/3] xe/xe_mmap: Negative test to extensions
2023-05-20 12:10 ` [igt-dev] [PATCH i-g-t 2/3] xe/xe_mmap: Negative test to extensions priyanka.dandamudi
@ 2023-05-22 11:41 ` Zbigniew Kempczyński
0 siblings, 0 replies; 12+ messages in thread
From: Zbigniew Kempczyński @ 2023-05-22 11:41 UTC (permalink / raw)
To: priyanka.dandamudi; +Cc: igt-dev, kamil.konieczny, ramadevi.gandi
On Sat, May 20, 2023 at 05:40:55PM +0530, priyanka.dandamudi@intel.com wrote:
> From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
>
> Add negative test to check bad extensions.
>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> ---
> tests/xe/xe_mmap.c | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/tests/xe/xe_mmap.c b/tests/xe/xe_mmap.c
> index 011b8893..f6f6b2af 100644
> --- a/tests/xe/xe_mmap.c
> +++ b/tests/xe/xe_mmap.c
> @@ -73,6 +73,25 @@ static void test_bad_flags(int fd)
> gem_close(fd, mmo.handle);
> }
>
> +/**
> + * SUBTEST: bad-extensions
> + * Description: Test mmap offset with bad extensions.
> + *
> + */
> +static void test_bad_extensions(int fd)
> +{
> + struct xe_user_extension ext;
> + struct drm_xe_gem_mmap_offset mmo = {
> + .handle = xe_bo_create(fd, 0, 0, 4096),
Same issue like in 1/3. Rest looks correct.
--
Zbigniew
> + };
> +
> + mmo.extensions = to_user_pointer(&ext);
> + ext.name = -1;
> +
> + do_ioctl_err(fd, DRM_IOCTL_XE_GEM_MMAP_OFFSET, &mmo, EINVAL);
> + gem_close(fd, mmo.handle);
> +}
> +
> igt_main
> {
> int fd;
> @@ -94,6 +113,9 @@ igt_main
> igt_subtest("bad-flags")
> test_bad_flags(fd);
>
> + igt_subtest("bad-extensions")
> + test_bad_extensions(fd);
> +
> igt_fixture {
> xe_device_put(fd);
> close(fd);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/3] xe/xe_mmap: Negative test to object
2023-05-20 12:10 ` [igt-dev] [PATCH i-g-t 3/3] xe/xe_mmap: Negative test to object priyanka.dandamudi
@ 2023-05-22 11:44 ` Zbigniew Kempczyński
0 siblings, 0 replies; 12+ messages in thread
From: Zbigniew Kempczyński @ 2023-05-22 11:44 UTC (permalink / raw)
To: priyanka.dandamudi; +Cc: igt-dev, kamil.konieczny, ramadevi.gandi
On Sat, May 20, 2023 at 05:40:56PM +0530, priyanka.dandamudi@intel.com wrote:
> From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
>
> Add negative test to check bad object.
>
> Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> ---
> tests/xe/xe_mmap.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/tests/xe/xe_mmap.c b/tests/xe/xe_mmap.c
> index f6f6b2af..95672e5d 100644
> --- a/tests/xe/xe_mmap.c
> +++ b/tests/xe/xe_mmap.c
> @@ -92,6 +92,24 @@ static void test_bad_extensions(int fd)
> gem_close(fd, mmo.handle);
> }
>
> +/**
> + * SUBTEST: bad-object
> + * Description: Test mmap offset with bad object.
> + *
> + */
> +static void test_bad_object(int fd)
> +{
> + struct drm_xe_gem_mmap_offset mmo = {
> + .handle = xe_bo_create(fd, 0, 0, 4096),
> + };
> +
> + igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_GEM_MMAP_OFFSET, &mmo), 0);
> + gem_close(fd, mmo.handle);
I'm not sure what for is positive create/mmap here? I think simple
invalid handle should be enough to check this uapi.
--
Zbigniew
> +
> + mmo.handle = 0xdeadbeef;
> + do_ioctl_err(fd, DRM_IOCTL_XE_GEM_MMAP_OFFSET, &mmo, ENOENT);
> +}
> +
> igt_main
> {
> int fd;
> @@ -116,6 +134,9 @@ igt_main
> igt_subtest("bad-extensions")
> test_bad_extensions(fd);
>
> + igt_subtest("bad-object")
> + test_bad_object(fd);
> +
> igt_fixture {
> xe_device_put(fd);
> close(fd);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] [PATCH i-g-t 1/3] xe/xe_mmap: Negative test for mmap flags
2023-05-26 5:08 [igt-dev] [PATCH i-g-t 0/3] " priyanka.dandamudi
@ 2023-05-26 5:08 ` priyanka.dandamudi
2023-05-26 10:42 ` Zbigniew Kempczyński
0 siblings, 1 reply; 12+ messages in thread
From: priyanka.dandamudi @ 2023-05-26 5:08 UTC (permalink / raw)
To: priyanka.dandamudi, ramadevi.gandi, zbigniew.kempczynski,
janga.rahul.kumar, kamil.konieczny, igt-dev
From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
Add negative test by adding invalid mmap flags and check
for related errors.
v2: Add default alignment for the object size.(Zbigniew)
Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
---
tests/xe/xe_mmap.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/tests/xe/xe_mmap.c b/tests/xe/xe_mmap.c
index 6b313a18..3e3f165b 100644
--- a/tests/xe/xe_mmap.c
+++ b/tests/xe/xe_mmap.c
@@ -57,6 +57,23 @@ test_mmap(int fd, uint32_t flags)
gem_close(fd, bo);
}
+/**
+ * SUBTEST: bad-flags
+ * Description: Test mmap offset with bad flags.
+ *
+ */
+static void test_bad_flags(int fd)
+{
+ uint64_t size = xe_get_default_alignment(fd);
+ struct drm_xe_gem_mmap_offset mmo = {
+ .handle = xe_bo_create(fd, 0, 0, size),
+ .flags = -1u,
+ };
+
+ do_ioctl_err(fd, DRM_IOCTL_XE_GEM_MMAP_OFFSET, &mmo, EINVAL);
+ gem_close(fd, mmo.handle);
+}
+
igt_main
{
int fd;
@@ -75,6 +92,9 @@ igt_main
igt_subtest("vram-system")
test_mmap(fd, vram_memory(fd, 0) | system_memory(fd));
+ igt_subtest("bad-flags")
+ test_bad_flags(fd);
+
igt_fixture {
xe_device_put(fd);
close(fd);
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/3] xe/xe_mmap: Negative test for mmap flags
2023-05-26 5:08 ` [igt-dev] [PATCH i-g-t 1/3] xe/xe_mmap: Negative test for mmap flags priyanka.dandamudi
@ 2023-05-26 10:42 ` Zbigniew Kempczyński
0 siblings, 0 replies; 12+ messages in thread
From: Zbigniew Kempczyński @ 2023-05-26 10:42 UTC (permalink / raw)
To: priyanka.dandamudi; +Cc: igt-dev, kamil.konieczny, ramadevi.gandi
On Fri, May 26, 2023 at 10:38:53AM +0530, priyanka.dandamudi@intel.com wrote:
> From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
>
> Add negative test by adding invalid mmap flags and check
> for related errors.
>
> v2: Add default alignment for the object size.(Zbigniew)
>
> Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
Looks good,
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
--
Zbigniew
> ---
> tests/xe/xe_mmap.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/tests/xe/xe_mmap.c b/tests/xe/xe_mmap.c
> index 6b313a18..3e3f165b 100644
> --- a/tests/xe/xe_mmap.c
> +++ b/tests/xe/xe_mmap.c
> @@ -57,6 +57,23 @@ test_mmap(int fd, uint32_t flags)
> gem_close(fd, bo);
> }
>
> +/**
> + * SUBTEST: bad-flags
> + * Description: Test mmap offset with bad flags.
> + *
> + */
> +static void test_bad_flags(int fd)
> +{
> + uint64_t size = xe_get_default_alignment(fd);
> + struct drm_xe_gem_mmap_offset mmo = {
> + .handle = xe_bo_create(fd, 0, 0, size),
> + .flags = -1u,
> + };
> +
> + do_ioctl_err(fd, DRM_IOCTL_XE_GEM_MMAP_OFFSET, &mmo, EINVAL);
> + gem_close(fd, mmo.handle);
> +}
> +
> igt_main
> {
> int fd;
> @@ -75,6 +92,9 @@ igt_main
> igt_subtest("vram-system")
> test_mmap(fd, vram_memory(fd, 0) | system_memory(fd));
>
> + igt_subtest("bad-flags")
> + test_bad_flags(fd);
> +
> igt_fixture {
> xe_device_put(fd);
> close(fd);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-05-26 10:43 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-20 12:10 [igt-dev] [PATCH i-g-t 0/3] Negative tests to mmap offset priyanka.dandamudi
2023-05-20 12:10 ` [igt-dev] [PATCH i-g-t 1/3] xe/xe_mmap: Negative test for mmap flags priyanka.dandamudi
2023-05-22 11:36 ` Zbigniew Kempczyński
2023-05-22 11:39 ` Zbigniew Kempczyński
2023-05-20 12:10 ` [igt-dev] [PATCH i-g-t 2/3] xe/xe_mmap: Negative test to extensions priyanka.dandamudi
2023-05-22 11:41 ` Zbigniew Kempczyński
2023-05-20 12:10 ` [igt-dev] [PATCH i-g-t 3/3] xe/xe_mmap: Negative test to object priyanka.dandamudi
2023-05-22 11:44 ` Zbigniew Kempczyński
2023-05-20 21:15 ` [igt-dev] ✓ Fi.CI.BAT: success for Negative tests to mmap offset Patchwork
2023-05-20 22:38 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-05-26 5:08 [igt-dev] [PATCH i-g-t 0/3] " priyanka.dandamudi
2023-05-26 5:08 ` [igt-dev] [PATCH i-g-t 1/3] xe/xe_mmap: Negative test for mmap flags priyanka.dandamudi
2023-05-26 10:42 ` Zbigniew Kempczyński
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox