Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v4 06/11] i915/perf_*: better document tests
Date: Fri, 26 May 2023 08:32:29 +0200	[thread overview]
Message-ID: <20230526083229.7650ded3@maurocar-mobl2> (raw)
In-Reply-To: <20230525204255.ejzjyfxpfji4n7it@kamilkon-desk1>

On Thu, 25 May 2023 22:42:55 +0200
Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote:

> Hi Mauro,
> 
> On 2023-05-25 at 11:05:30 +0200, Mauro Carvalho Chehab wrote:
> > From: Mauro Carvalho Chehab <mchehab@kernel.org>
> > 
> > Merge data from some ancillary internal documentation to improve
> > i915 perf test descriptions.
> > 
> > This patch was auto-generated via script.
> > 
> > Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

> >   * SUBTEST: non-zero-reason
> > - * Description: Test that reason field in OA reports is never 0 on Gen8+
> > - * Feature: oa
> > + * Description:
> > + *   Test that reason field in OA reports is never 0 on Gen8+.
> > + *   Test that reason field in OA reports is never 0 on Gen8+  
> ------- ^
> Repeated without ending dot.
> 
> Rest looks good, you can add my r-b if you feel this can be
> corrected later.

I'll fix it now. Basically, "+" needs to be escaped at the regex
I'm using to drop duplicated comment. A single-line change on my
import script fixed it.

I'll merge the change on this patch and add your R-B.

Regards,
Mauro

  reply	other threads:[~2023-05-26  6:32 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-25  9:05 [igt-dev] [PATCH i-g-t v4 00/11] Improve description of tests used by i915 validation Mauro Carvalho Chehab
2023-05-25  9:05 ` [igt-dev] [PATCH i-g-t v4 01/11] gem_exec_fence: fix a typo Mauro Carvalho Chehab
2023-05-25 18:41   ` Kamil Konieczny
2023-05-25  9:05 ` [igt-dev] [PATCH i-g-t v4 02/11] tests: better document core_* tests used for i915 validation Mauro Carvalho Chehab
2023-05-25 18:58   ` Kamil Konieczny
2023-05-25  9:05 ` [igt-dev] [PATCH i-g-t v4 03/11] tests: better document the remaining core used by " Mauro Carvalho Chehab
2023-05-25 19:02   ` Kamil Konieczny
2023-05-25  9:05 ` [igt-dev] [PATCH i-g-t v4 04/11] i915/gem_exec_*: better document gem exec tests used for " Mauro Carvalho Chehab
2023-05-25 19:22   ` Kamil Konieczny
2023-05-26  6:37     ` Mauro Carvalho Chehab
2023-05-25  9:05 ` [igt-dev] [PATCH i-g-t v4 05/11] i915/gem_ctx_*: better document i915 context tests Mauro Carvalho Chehab
2023-05-25 19:55   ` Kamil Konieczny
2023-05-26  6:13     ` Mauro Carvalho Chehab
2023-05-25  9:05 ` [igt-dev] [PATCH i-g-t v4 06/11] i915/perf_*: better document tests Mauro Carvalho Chehab
2023-05-25 20:42   ` Kamil Konieczny
2023-05-26  6:32     ` Mauro Carvalho Chehab [this message]
2023-05-25  9:05 ` [igt-dev] [PATCH i-g-t v4 07/11] i915/: better document the remaining i915 tests Mauro Carvalho Chehab
2023-05-25 20:58   ` Kamil Konieczny
2023-05-25  9:05 ` [igt-dev] [PATCH i-g-t v4 08/11] tests: add documentation for dynamic subtests Mauro Carvalho Chehab
2023-05-25 21:02   ` Kamil Konieczny
2023-05-25  9:05 ` [igt-dev] [PATCH i-g-t v4 09/11] scripts/test_list.py: add dynamic subtest support Mauro Carvalho Chehab
2023-05-25 21:04   ` Kamil Konieczny
2023-05-25  9:05 ` [igt-dev] [PATCH i-g-t v4 10/11] i915_test_config.json: exclude gem_concurrent_blit.c Mauro Carvalho Chehab
2023-05-25 21:06   ` Kamil Konieczny
2023-05-25  9:05 ` [igt-dev] [PATCH i-g-t v4 11/11] testplan/meson.build: make it check for missing i915 documentation Mauro Carvalho Chehab
2023-05-25 21:11   ` Kamil Konieczny
2023-05-26  5:54     ` Mauro Carvalho Chehab
2023-05-26  6:55     ` Mauro Carvalho Chehab
2023-05-25  9:33 ` [igt-dev] ✗ Fi.CI.BUILD: failure for Improve description of tests used by i915 validation Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230526083229.7650ded3@maurocar-mobl2 \
    --to=mauro.chehab@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox