Re: [igt-dev] [PATCH i-g-t v4 04/11] i915/gem_exec_*: better document gem exec tests used for i915 validation

[Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>]

On Thu, 25 May 2023 21:22:45 +0200
Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote:

> Hi Mauro,
> 
> On 2023-05-25 at 11:05:28 +0200, Mauro Carvalho Chehab wrote:
> > From: Mauro Carvalho Chehab <mchehab@kernel.org>
> > 
> > Merge data from some ancillary internal documentation to improve
> > core test descriptions.
> > 
> > This patch was auto-generated via script.
> > 
> > Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

> > diff --git a/tests/i915/gem_exec_fence.c b/tests/i915/gem_exec_fence.c
> > index 76a86e8f4197..1d09cfe07135 100644
> > --- a/tests/i915/gem_exec_fence.c
> > +++ b/tests/i915/gem_exec_fence.c

> >   * SUBTEST: basic-wait-all
> > - * Description: Basic check for composite fence with additional wait on all busy engines.
> > + * Description:
> > + *   Basic check for composite fence with additional wait on all busy engines.
> > + *   Execute the same batch on each engine and check that the composite fence across all engines completes only after the batch is completed on every engine.  
> ------- ^
> Looks strange.

Comment makes sense to me. I'll keep this one. It can be changed later on,
if it doesn't reflect the test behavior.


> >   * SUBTEST: nb-await
> > - * Description: Check for explicit fence with non-blocking wait on each engine.
> > + * Description:
> > + *   Check for explicit fence with non-blocking wait on each engine.
> > + *   Check for explicit fence with non-blocking wait on each  
> ------- ^
> This one is out of place, repeated with last word cut off.
> 
> >   * Feature: cmd_submission, multitile, synchronization
> > + * Functionality: semaphore
> >   * Run type: BAT
> > + * Test category: MultiTile
> >   *
> >   * SUBTEST: nb-await-hang
> >   * Description: Check for explicit fence with non-blocking async wait on each engine with a pending gpu hang.
> > @@ -122,9 +153,12 @@
> >   * Run type: FULL
> >   *
> >   * SUBTEST: parallel
> > - * Description: Check for EXEC_FENCE_SUBMIT in parallel execution scenarios on each engine.
> > + * Description:
> > + *   Check for EXEC_FENCE_SUBMIT in parallel execution scenarios on each engine.
> > + *   Check for EXEC_FENCE_SUBMIT in parallel execution scenarios  
> ------- ^
> Same here.
> 
> Rest looks ok, if you think that descriptions may be corrected
> later add my r-b.

I'll fix those two comments about the duplicated (incomplete)
descriptions, and add your R-B.

Thanks!
Mauro